]> code.citadel.org Git - citadel.git/blobdiff - citadel/msgbase.c
* Replication fixes
[citadel.git] / citadel / msgbase.c
index 2e8ea9feb43e6b3c867d346389f156e1110b8abf..73bc6944e56072462c6fecfefc79ac23ec46f02d 100644 (file)
 
 #define desired_section ((char *)CtdlGetUserData(SYM_DESIRED_SECTION))
 #define ma ((struct ma_info *)CtdlGetUserData(SYM_MA_INFO))
+#define msg_repl ((struct repl *)CtdlGetUserData(SYM_REPL))
 
 extern struct config config;
 
+char *msgkeys[] = {
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", 
+       "from",
+       "", "", "", "", "", "", 
+       "hnod",
+       "msgn",
+       "", "", "",
+       "text",
+       "node",
+       "room",
+       "path",
+       "",
+       "rcpt",
+       "",
+       "time",
+       "subj",
+       "",
+       "",
+       "",
+       "",
+       ""
+};
 
 /*
  * This function is self explanatory.
@@ -184,12 +215,45 @@ void simple_listing(long msgnum)
 }
 
 
+
+/* Determine if a given message matches the fields in a message template.
+ * Return 0 for a successful match.
+ */
+int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
+       int i;
+
+       /* If there aren't any fields in the template, all messages will
+        * match.
+        */
+       if (template == NULL) return(0);
+
+       /* Null messages are bogus. */
+       if (msg == NULL) return(1);
+
+       for (i='A'; i<='Z'; ++i) {
+               if (template->cm_fields[i] != NULL) {
+                       if (msg->cm_fields[i] == NULL) {
+                               return 1;
+                       }
+                       if (strcasecmp(msg->cm_fields[i],
+                               template->cm_fields[i])) return 1;
+               }
+       }
+
+       /* All compares succeeded: we have a match! */
+       return 0;
+}
+
+
+
+
 /*
  * API function to perform an operation for each qualifying message in the
  * current room.
  */
 void CtdlForEachMessage(int mode, long ref,
                        char *content_type,
+                       struct CtdlMessage *compare,
                        void (*CallBack) (long msgnum))
 {
 
@@ -200,6 +264,7 @@ void CtdlForEachMessage(int mode, long ref,
        int num_msgs = 0;
        long thismsg;
        struct SuppMsgInfo smi;
+       struct CtdlMessage *msg;
 
        /* Learn about the user and room in question */
        get_mm();
@@ -232,6 +297,24 @@ void CtdlForEachMessage(int mode, long ref,
                                }
 
        num_msgs = sort_msglist(msglist, num_msgs);
+
+       /* If a template was supplied, filter out the messages which
+        * don't match.  (This could induce some delays!)
+        */
+       if (num_msgs > 0) {
+               if (compare != NULL) {
+                       for (a = 0; a < num_msgs; ++a) {
+                               msg = CtdlFetchMessage(msglist[a]);
+                               if (msg != NULL) {
+                                       if (CtdlMsgCmp(msg, compare)) {
+                                               msglist[a] = 0L;
+                                       }
+                                       CtdlFreeMessage(msg);
+                               }
+                       }
+               }
+       }
+
        
        /*
         * Now iterate through the message list, according to the
@@ -240,7 +323,6 @@ void CtdlForEachMessage(int mode, long ref,
        if (num_msgs > 0)
                for (a = 0; a < num_msgs; ++a) {
                        thismsg = msglist[a];
-                       lprintf(9, "Iterating through <%ld>\n", thismsg);
                        if ((thismsg > 0)
                            && (
 
@@ -254,7 +336,6 @@ void CtdlForEachMessage(int mode, long ref,
                                || ((mode == MSGS_GT) && (thismsg > ref))
                            )
                            ) {
-                               lprintf(9, "Issuing callback for <%ld>\n", thismsg);
                                CallBack(thismsg);
                        }
                }
@@ -271,10 +352,17 @@ void cmd_msgs(char *cmdbuf)
 {
        int mode = 0;
        char which[256];
+       char buf[256];
+       char tfield[256];
+       char tvalue[256];
        int cm_ref = 0;
+       int i;
+       int with_template = 0;
+       struct CtdlMessage *template = NULL;
 
        extract(which, cmdbuf, 0);
        cm_ref = extract_int(cmdbuf, 1);
+       with_template = extract_int(cmdbuf, 2);
 
        mode = MSGS_ALL;
        strcat(which, "   ");
@@ -293,8 +381,30 @@ void cmd_msgs(char *cmdbuf)
                cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN);
                return;
        }
-       cprintf("%d Message list...\n", LISTING_FOLLOWS);
-       CtdlForEachMessage(mode, cm_ref, NULL, simple_listing);
+
+       if (with_template) {
+               cprintf("%d Send template then receive message list\n",
+                       START_CHAT_MODE);
+               template = (struct CtdlMessage *)
+                       mallok(sizeof(struct CtdlMessage));
+               memset(template, 0, sizeof(struct CtdlMessage));
+               while(client_gets(buf), strcmp(buf,"000")) {
+                       extract(tfield, buf, 0);
+                       extract(tvalue, buf, 1);
+                       for (i='A'; i<='Z'; ++i) if (msgkeys[i]!=NULL) {
+                               if (!strcasecmp(tfield, msgkeys[i])) {
+                                       template->cm_fields[i] =
+                                               strdoop(tvalue);
+                               }
+                       }
+               }
+       }
+       else {
+               cprintf("%d Message list...\n", LISTING_FOLLOWS);
+       }
+
+       CtdlForEachMessage(mode, cm_ref, NULL, template, simple_listing);
+       if (template != NULL) CtdlFreeMessage(template);
        cprintf("000\n");
 }
 
@@ -359,7 +469,7 @@ void memfmout(int width, char *mptr, char subst)
        strcpy(buffer, "");
        c = 1;                  /* c is the current pos */
 
-      FMTA:if (subst) {
+FMTA:  if (subst) {
                while (ch = *mptr, ((ch != 0) && (strlen(buffer) < 126))) {
                        ch = *mptr++;
                        buffer[strlen(buffer) + 1] = 0;
@@ -372,8 +482,9 @@ void memfmout(int width, char *mptr, char subst)
                buffer[strlen(buffer) + 1] = 0;
                a = buffer[0];
                strcpy(buffer, &buffer[1]);
-       } else
+       } else {
                ch = *mptr++;
+       }
 
        old = real;
        real = ch;
@@ -563,9 +674,32 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
        } while ((field_length > 0) && (field_header != 'M'));
 
        cdb_free(dmsgtext);
+
+       /* Perform "before read" hooks (aborting if any return nonzero) */
+       if (PerformMessageHooks(ret, EVT_BEFOREREAD) > 0) {
+               CtdlFreeMessage(ret);
+               return NULL;
+       }
+
        return (ret);
 }
 
+
+/*
+ * Returns 1 if the supplied pointer points to a valid Citadel message.
+ * If the pointer is NULL or the magic number check fails, returns 0.
+ */
+int is_valid_message(struct CtdlMessage *msg) {
+       if (msg == NULL)
+               return 0;
+       if ((msg->cm_magic) != CTDLMESSAGE_MAGIC) {
+               lprintf(3, "is_valid_message() -- self-check failed\n");
+               return 0;
+       }
+       return 1;
+}
+
+
 /*
  * 'Destructor' for struct CtdlMessage
  */
@@ -573,16 +707,13 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
 {
        int i;
 
-       if (msg == NULL)
-               return;
-       if ((msg->cm_magic) != CTDLMESSAGE_MAGIC) {
-               lprintf(3, "CtdlFreeMessage() -- self-check failed\n");
-               return;
-       }
+       if (is_valid_message(msg) == 0) return;
+
        for (i = 0; i < 256; ++i)
                if (msg->cm_fields[i] != NULL)
                        phree(msg->cm_fields[i]);
 
+       msg->cm_magic = 0;      /* just in case */
        phree(msg);
 }
 
@@ -595,10 +726,12 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
 void output_message(char *msgid, int mode, int headers_only)
 {
        long msg_num;
-       int a, i;
+       int a, i, k;
        char buf[1024];
        time_t xtime;
        CIT_UBYTE ch;
+       char allkeys[256];
+       char display_name[256];
 
        struct CtdlMessage *TheMessage = NULL;
 
@@ -688,46 +821,44 @@ void output_message(char *msgid, int mode, int headers_only)
 
        if ((mode == MT_CITADEL) || (mode == MT_MIME)) {
 
-               if (TheMessage->cm_fields['P']) {
-                       cprintf("path=%s\n", TheMessage->cm_fields['P']);
-               }
-               if (TheMessage->cm_fields['I']) {
-                       cprintf("msgn=%s\n", TheMessage->cm_fields['I']);
-               }
-               if (TheMessage->cm_fields['T']) {
-                       cprintf("time=%s\n", TheMessage->cm_fields['T']);
-               }
+               strcpy(display_name, "<unknown>");
                if (TheMessage->cm_fields['A']) {
                        strcpy(buf, TheMessage->cm_fields['A']);
                        PerformUserHooks(buf, (-1L), EVT_OUTPUTMSG);
                        if (TheMessage->cm_anon_type == MES_ANON)
-                               cprintf("from=****");
+                               strcpy(display_name, "****");
                        else if (TheMessage->cm_anon_type == MES_AN2)
-                               cprintf("from=anonymous");
+                               strcpy(display_name, "anonymous");
                        else
-                               cprintf("from=%s", buf);
+                               strcpy(display_name, buf);
                        if ((is_room_aide())
                            && ((TheMessage->cm_anon_type == MES_ANON)
                             || (TheMessage->cm_anon_type == MES_AN2))) {
-                               cprintf(" [%s]", buf);
+                               sprintf(&display_name[strlen(display_name)],
+                                       " [%s]", buf);
                        }
-                       cprintf("\n");
-               }
-               if (TheMessage->cm_fields['O']) {
-                       cprintf("room=%s\n", TheMessage->cm_fields['O']);
-               }
-               if (TheMessage->cm_fields['N']) {
-                       cprintf("node=%s\n", TheMessage->cm_fields['N']);
                }
-               if (TheMessage->cm_fields['H']) {
-                       cprintf("hnod=%s\n", TheMessage->cm_fields['H']);
-               }
-               if (TheMessage->cm_fields['R']) {
-                       cprintf("rcpt=%s\n", TheMessage->cm_fields['R']);
-               }
-               if (TheMessage->cm_fields['U']) {
-                       cprintf("subj=%s\n", TheMessage->cm_fields['U']);
+
+               strcpy(allkeys, FORDER);
+               for (i=0; i<strlen(allkeys); ++i) {
+                       k = (int) allkeys[i];
+                       if (k != 'M') {
+                               if (TheMessage->cm_fields[k] != NULL) {
+                                       if (k == 'A') {
+                                               cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       display_name);
+                                       }
+                                       else {
+                                               cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       TheMessage->cm_fields[k]
+                                       );
+                                       }
+                               }
+                       }
                }
+
        }
 
        /* begin header processing loop for RFC822 transfer format */
@@ -900,7 +1031,8 @@ void cmd_msg2(char *cmdbuf)
 void cmd_msg3(char *cmdbuf)
 {
        long msgnum;
-       struct cdbdata *dmsgtext;
+       struct CtdlMessage *msg;
+       struct ser_ret smr;
 
        if (CC->internal_pgm == 0) {
                cprintf("%d This command is for internal programs only.\n",
@@ -909,15 +1041,25 @@ void cmd_msg3(char *cmdbuf)
        }
 
        msgnum = extract_long(cmdbuf, 0);
+       msg = CtdlFetchMessage(msgnum);
+       if (msg == NULL) {
+               cprintf("%d Message %ld not found.\n", 
+                       ERROR, msgnum);
+               return;
+       }
 
-       dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
-       if (dmsgtext == NULL) {
-               cprintf("%d Message %ld not found\n", ERROR, msgnum);
+       serialize_message(&smr, msg);
+       CtdlFreeMessage(msg);
+
+       if (smr.len == 0) {
+               cprintf("%d Unable to serialize message\n",
+                       ERROR+INTERNAL_ERROR);
+               return;
        }
 
-       cprintf("%d %ld\n", BINARY_FOLLOWS, dmsgtext->len);
-       client_write(dmsgtext->ptr, dmsgtext->len);
-       cdb_free(dmsgtext);
+       cprintf("%d %ld\n", BINARY_FOLLOWS, smr.len);
+       client_write(smr.ser, smr.len);
+       phree(smr.ser);
 }
 
 
@@ -952,39 +1094,40 @@ void cmd_opna(char *cmdbuf)
 /*
  * Message base operation to send a message to the master file
  * (returns new message number)
+ *
+ * This is the back end for CtdlSaveMsg() and should not be directly
+ * called by server-side modules.
+ *
  */
-long send_message(char *message_in_memory,
-                                                       /* pointer to buffer */
-                                                  size_t message_length,       /* length of buffer */
-                                                     int generate_id)
-{                              /* 1 to generate an I field */
-
+long send_message(struct CtdlMessage *msg,     /* pointer to buffer */
+               int generate_id,                /* generate 'I' field? */
+               FILE *save_a_copy)              /* save a copy to disk? */
+{
        long newmsgid;
-       char *actual_message;
-       size_t actual_length;
        long retval;
        char msgidbuf[32];
+        struct ser_ret smr;
 
        /* Get a new message number */
        newmsgid = get_new_message_number();
+       sprintf(msgidbuf, "%ld", newmsgid);
 
        if (generate_id) {
-               sprintf(msgidbuf, "I%ld", newmsgid);
-               actual_length = message_length + strlen(msgidbuf) + 1;
-               actual_message = mallok(actual_length);
-               memcpy(actual_message, message_in_memory, 3);
-               memcpy(&actual_message[3], msgidbuf, (strlen(msgidbuf) + 1));
-               memcpy(&actual_message[strlen(msgidbuf) + 4],
-                      &message_in_memory[3], message_length - 3);
-       } else {
-               actual_message = message_in_memory;
-               actual_length = message_length;
+               msg->cm_fields['I'] = strdoop(msgidbuf);
        }
+       
+        serialize_message(&smr, msg);
+
+        if (smr.len == 0) {
+                cprintf("%d Unable to serialize message\n",
+                        ERROR+INTERNAL_ERROR);
+                return (-1L);
+        }
 
        /* Write our little bundle of joy into the message base */
        begin_critical_section(S_MSGMAIN);
        if (cdb_store(CDB_MSGMAIN, &newmsgid, sizeof(long),
-                     actual_message, actual_length) < 0) {
+                     smr.ser, smr.len) < 0) {
                lprintf(2, "Can't store message\n");
                retval = 0L;
        } else {
@@ -992,72 +1135,191 @@ long send_message(char *message_in_memory,
        }
        end_critical_section(S_MSGMAIN);
 
-       if (generate_id) {
-               phree(actual_message);
+       /* If the caller specified that a copy should be saved to a particular
+        * file handle, do that now too.
+        */
+       if (save_a_copy != NULL) {
+               fwrite(smr.ser, smr.len, 1, save_a_copy);
        }
-       /* Finally, return the pointers */
-       return (retval);
+
+       /* Free the memory we used for the serialized message */
+        phree(smr.ser);
+
+       /* Return the *local* message ID to the caller
+        * (even if we're storing an incoming network message)
+        */
+       return(retval);
 }
 
 
 
 /*
- * this is a simple file copy routine.
+ * Serialize a struct CtdlMessage into the format used on disk and network.
+ * 
+ * This function loads up a "struct ser_ret" (defined in server.h) which
+ * contains the length of the serialized message and a pointer to the
+ * serialized message in memory.  THE LATTER MUST BE FREED BY THE CALLER.
  */
-void copy_file(char *from, char *to)
+void serialize_message(struct ser_ret *ret,            /* return values */
+                       struct CtdlMessage *msg)        /* unserialized msg */
 {
-       FILE *ffp, *tfp;
-       int a;
+       size_t wlen;
+       int i;
+       static char *forder = FORDER;
 
-       ffp = fopen(from, "r");
-       if (ffp == NULL)
-               return;
-       tfp = fopen(to, "w");
-       if (tfp == NULL) {
-               fclose(ffp);
+       lprintf(9, "serialize_message() called\n");
+
+       if (is_valid_message(msg) == 0) return;         /* self check */
+
+       lprintf(9, "magic number check OK.\n");
+
+       ret->len = 3;
+       for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL)
+               ret->len = ret->len +
+                       strlen(msg->cm_fields[(int)forder[i]]) + 2;
+
+       lprintf(9, "message is %d bytes\n", ret->len);
+
+       lprintf(9, "calling malloc\n");
+       ret->ser = mallok(ret->len);
+       if (ret->ser == NULL) {
+               ret->len = 0;
                return;
        }
-       while (a = getc(ffp), a >= 0) {
-               putc(a, tfp);
+
+       ret->ser[0] = 0xFF;
+       ret->ser[1] = msg->cm_anon_type;
+       ret->ser[2] = msg->cm_format_type;
+       wlen = 3;
+
+       lprintf(9, "stuff\n");
+       for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL) {
+               ret->ser[wlen++] = (char)forder[i];
+               strcpy(&ret->ser[wlen], msg->cm_fields[(int)forder[i]]);
+               wlen = wlen + strlen(msg->cm_fields[(int)forder[i]]) + 1;
        }
-       fclose(ffp);
-       fclose(tfp);
+       if (ret->len != wlen) lprintf(3, "ERROR: len=%d wlen=%d\n",
+               ret->len, wlen);
+       lprintf(9, "done serializing\n");
+
        return;
 }
 
 
 
 /*
- * message base operation to save a message and install its pointers
+ * Back end for the ReplicationChecks() function
+ */
+void check_repl(long msgnum) {
+       struct CtdlMessage *msg;
+       time_t timestamp;
+
+       msg = NULL;  /* FIX change to get */
+
+
+       if (msg->cm_fields['T'] != NULL) {
+               timestamp = atol(msg->cm_fields['T']);
+               if (timestamp > msg_repl->highest) {
+                       msg_repl->highest = timestamp;  /* newer! */
+                       return;
+               }
+       }
+
+       /* Existing isn't newer?  Then delete the old one(s). */
+       CtdlDeleteMessages(&CC->quickroom.QRname, msgnum, NULL);
+}
+
+
+/*
+ * Check to see if any messages already exist which carry the same Extended ID
+ * as this one.  
+ *
+ * If any are found:
+ * -> With older timestamps: delete them and return 0.  Message will be saved.
+ * -> With newer timestamps: return 1.  Message save will be aborted.
+ */
+int ReplicationChecks(struct CtdlMessage *msg) {
+       struct CtdlMessage *template;
+       int abort_this = 0;
+
+       /* No extended id?  Don't do anything. */
+       if (msg->cm_fields['E'] == NULL) return 0;
+       if (strlen(msg->cm_fields['E']) == 0) return 0;
+
+       CtdlAllocUserData(SYM_REPL, sizeof(struct repl));
+       strcpy(msg_repl->extended_id, msg->cm_fields['E']);
+       msg_repl->highest = (-1L);
+
+       template = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
+       memset(template, 0, sizeof(struct CtdlMessage));
+       template->cm_fields['E'] = strdoop(msg->cm_fields['E']);
+
+       CtdlForEachMessage(MSGS_ALL, 0L, NULL, template, check_repl);
+
+       /* If a newer message exists with the same Extended ID, abort
+        * this save.
+        */
+       if (msg_repl->highest > atol(msg->cm_fields['T']) ) {
+               abort_this = 1;
+               }
+
+       CtdlFreeMessage(template);
+       return(abort_this);
+}
+
+
+
+
+
+
+
+
+/*
+ * Save a message to disk
  */
-void save_message(char *mtmp,  /* file containing proper message */
-                 char *rec,    /* Recipient (if mail) */
-                 char *force,  /* if non-zero length, force a room */
-                 int mailtype, /* local or remote type, see citadel.h */
-                 int generate_id)
-{                              /* set to 1 to generate an 'I' field */
+void CtdlSaveMsg(struct CtdlMessage *msg,      /* message to save */
+               char *rec,                      /* Recipient (mail) */
+               char *force,                    /* force a particular room? */
+               int mailtype,                   /* local or remote type */
+               int generate_id)                /* 1 = generate 'I' field */
+{
        char aaa[100];
        char hold_rm[ROOMNAMELEN];
        char actual_rm[ROOMNAMELEN];
        char force_room[ROOMNAMELEN];
        char content_type[256]; /* We have to learn this */
-       char ch, rch;
        char recipient[256];
        long newmsgid;
-       char *message_in_memory;
        char *mptr;
-       struct stat statbuf;
-       size_t templen;
-       FILE *fp;
        struct usersupp userbuf;
        int a;
-       static int seqnum = 0;
        int successful_local_recipients = 0;
        struct quickroom qtemp;
        struct SuppMsgInfo smi;
+       FILE *network_fp = NULL;
+       static int seqnum = 1;
 
-       lprintf(9, "save_message(%s,%s,%s,%d,%d)\n",
-               mtmp, rec, force, mailtype, generate_id);
+       lprintf(9, "CtdlSaveMsg() called\n");
+       if (is_valid_message(msg) == 0) return;         /* self check */
+
+       /* If this message has no timestamp, we take the liberty of
+        * giving it one, right now.
+        */
+       if (msg->cm_fields['T'] == NULL) {
+               sprintf(aaa, "%ld", time(NULL));
+               msg->cm_fields['T'] = strdoop(aaa);
+       }
+
+       /* If this message has no path, we generate one.
+        */
+       if (msg->cm_fields['P'] == NULL) {
+               msg->cm_fields['P'] = strdoop(msg->cm_fields['A']);
+               for (a=0; a<strlen(msg->cm_fields['P']); ++a) {
+                       if (isspace(msg->cm_fields['P'][a])) {
+                               msg->cm_fields['P'][a] = ' ';
+                       }
+               }
+       }
 
        strcpy(force_room, force);
 
@@ -1067,26 +1329,9 @@ void save_message(char *mtmp,    /* file containing proper message */
                if (!isprint(recipient[a]))
                        strcpy(&recipient[a], &recipient[a + 1]);
 
-       /* Measure the message */
-       stat(mtmp, &statbuf);
-       templen = statbuf.st_size;
-
-       /* Now read it into memory */
-       message_in_memory = (char *) mallok(templen);
-       if (message_in_memory == NULL) {
-               lprintf(2, "Can't allocate memory to save message!\n");
-               return;
-       }
-       fp = fopen(mtmp, "rb");
-       fread(message_in_memory, templen, 1, fp);
-       fclose(fp);
-
        /* Learn about what's inside, because it's what's inside that counts */
-       mptr = message_in_memory;
-       ++mptr;                 /* advance past 0xFF header */
-       ++mptr;                 /* advance past anon flag */
-       ch = *mptr++;
-       switch (ch) {
+
+       switch (msg->cm_format_type) {
        case 0:
                strcpy(content_type, "text/x-citadel-variformat");
                break;
@@ -1096,17 +1341,12 @@ void save_message(char *mtmp,   /* file containing proper message */
        case 4:
                strcpy(content_type, "text/plain");
                /* advance past header fields */
-               while (ch = *mptr++, (ch != 'M' && ch != 0)) {
-                       do {
-                               rch = *mptr++;
-                       } while (rch > 0);
-               }
+               mptr = msg->cm_fields['M'];
                a = strlen(mptr);
                while (--a) {
                        if (!strncasecmp(mptr, "Content-type: ", 14)) {
                                safestrncpy(content_type, mptr,
                                            sizeof(content_type));
-                               lprintf(9, "%s\n", content_type);
                                strcpy(content_type, &content_type[14]);
                                for (a = 0; a < strlen(content_type); ++a)
                                        if ((content_type[a] == ';')
@@ -1119,11 +1359,29 @@ void save_message(char *mtmp,   /* file containing proper message */
                        ++mptr;
                }
        }
-       lprintf(9, "Content type is <%s>\n", content_type);
+
+       /* Perform "before save" hooks (aborting if any return nonzero) */
+       if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return;
+
+       /* If this message has an Extended ID, perform replication checks */
+       if (ReplicationChecks(msg) > 0) return;
+
+       /* Network mail - send a copy to the network program. */
+       if ((strlen(recipient) > 0) && (mailtype != MES_LOCAL)) {
+               sprintf(aaa, "./network/spoolin/netmail.%04lx.%04x.%04x",
+                       (long) getpid(), CC->cs_pid, ++seqnum);
+               lprintf(9, "Saving a copy to %s\n", aaa);
+               network_fp = fopen(aaa, "ab+");
+               if (network_fp == NULL)
+                       lprintf(2, "ERROR: %s\n", strerror(errno));
+       }
 
        /* Save it to disk */
-       newmsgid = send_message(message_in_memory, templen, generate_id);
-       phree(message_in_memory);
+       newmsgid = send_message(msg, generate_id, network_fp);
+       if (network_fp != NULL) {
+               fclose(network_fp);
+               system("exec nohup ./netproc -i >/dev/null 2>&1 &");
+       }
        if (newmsgid <= 0L)
                return;
 
@@ -1142,7 +1400,6 @@ void save_message(char *mtmp,     /* file containing proper message */
                                strcpy(actual_rm, config.c_twitroom);
                        }
                /* ...or if this message is destined for Aide> then go there. */
-               lprintf(9, "actual room forcing loop\n");
                if (strlen(force_room) > 0) {
                        strcpy(hold_rm, actual_rm);
                        strcpy(actual_rm, force_room);
@@ -1168,13 +1425,7 @@ void save_message(char *mtmp,    /* file containing proper message */
                lputroom(&CC->quickroom);
                ++successful_local_recipients;
        }
-       /* Network mail - send a copy to the network program. */
-       if ((strlen(recipient) > 0) && (mailtype != MES_LOCAL)) {
-               sprintf(aaa, "./network/spoolin/netmail.%04lx.%04x.%04x",
-                       (long) getpid(), CC->cs_pid, ++seqnum);
-               copy_file(mtmp, aaa);
-               system("exec nohup ./netproc -i >/dev/null 2>&1 &");
-       }
+
        /* Bump this user's messages posted counter. */
        lgetuser(&CC->usersupp, CC->curr_user);
        CC->usersupp.posted = CC->usersupp.posted + 1;
@@ -1186,7 +1437,6 @@ void save_message(char *mtmp,     /* file containing proper message */
        if ((strlen(recipient) > 0) && (mailtype == MES_LOCAL)) {
                if (getuser(&userbuf, recipient) == 0) {
                        MailboxName(actual_rm, &userbuf, MAILROOM);
-                       lprintf(9, "Targeting mailbox: <%s>\n", actual_rm);
                        if (lgetroom(&qtemp, actual_rm) == 0) {
                                qtemp.QRhighest =
                                    AddMessageToRoom(&qtemp, newmsgid);
@@ -1201,7 +1451,6 @@ void save_message(char *mtmp,     /* file containing proper message */
        if (strlen(hold_rm) > 0) {
                usergoto(hold_rm, 0);
        }
-       unlink(mtmp);           /* delete the temporary file */
 
        /* Write a supplemental message info record.  This doesn't have to
         * be a critical section because nobody else knows about this message
@@ -1212,26 +1461,34 @@ void save_message(char *mtmp,   /* file containing proper message */
        smi.smi_refcount = successful_local_recipients;
        safestrncpy(smi.smi_content_type, content_type, 64);
        PutSuppMsgInfo(&smi);
+
+       /* Perform "after save" hooks */
+       PerformMessageHooks(msg, EVT_AFTERSAVE);
 }
 
 
+
 /*
- * Generate an administrative message and post it in the Aide> room.
+ * Convenience function for generating small administrative messages.
  */
-void aide_message(char *text)
+void quickie_message(char *from, char *to, char *room, char *text)
 {
-       FILE *fp;
-
-       fp = fopen(CC->temp, "wb");
-       fprintf(fp, "%c%c%c", 255, MES_NORMAL, 0);
-       fprintf(fp, "Psysop%c", 0);
-       fprintf(fp, "T%ld%c", (long) time(NULL), 0);
-       fprintf(fp, "ACitadel%c", 0);
-       fprintf(fp, "OAide%c", 0);
-       fprintf(fp, "N%s%c", NODENAME, 0);
-       fprintf(fp, "M%s\n%c", text, 0);
-       fclose(fp);
-       save_message(CC->temp, "", AIDEROOM, MES_LOCAL, 1);
+       struct CtdlMessage *msg;
+
+       msg = mallok(sizeof(struct CtdlMessage));
+       memset(msg, 0, sizeof(struct CtdlMessage));
+       msg->cm_magic = CTDLMESSAGE_MAGIC;
+       msg->cm_anon_type = MES_NORMAL;
+       msg->cm_format_type = 0;
+       msg->cm_fields['A'] = strdoop(from);
+       msg->cm_fields['O'] = strdoop(room);
+       msg->cm_fields['N'] = strdoop(NODENAME);
+       if (to != NULL)
+               msg->cm_fields['R'] = strdoop(to);
+       msg->cm_fields['M'] = strdoop(text);
+
+       CtdlSaveMsg(msg, "", room, MES_LOCAL, 1);
+       CtdlFreeMessage(msg);
        syslog(LOG_NOTICE, text);
 }
 
@@ -1240,8 +1497,7 @@ void aide_message(char *text)
  * Build a binary message to be saved on disk.
  */
 
-void make_message(
-       char *filename,                 /* temporary file name */
+struct CtdlMessage *make_message(
        struct usersupp *author,        /* author's usersupp structure */
        char *recipient,                /* NULL if it's not mail */
        char *room,                     /* room where it's going */
@@ -1251,12 +1507,19 @@ void make_message(
        char *fake_name)                /* who we're masquerading as */
 {
 
-       FILE *fp;
        int a;
-       time_t now;
        char dest_node[32];
        char buf[256];
-       size_t msglen = 0;
+       size_t message_len = 0;
+       size_t buffer_len = 0;
+       char *ptr;
+       struct CtdlMessage *msg;
+
+       msg = mallok(sizeof(struct CtdlMessage));
+       memset(msg, 0, sizeof(struct CtdlMessage));
+       msg->cm_magic = CTDLMESSAGE_MAGIC;
+       msg->cm_anon_type = type;
+       msg->cm_format_type = format_type;
 
        /* Don't confuse the poor folks if it's not routed mail. */
        strcpy(dest_node, "");
@@ -1272,53 +1535,74 @@ void make_message(
                }
        }
 
-       /* if net_type is MES_INTERNET, set the dest node to 'internet' */ if (net_type == MES_INTERNET) {
+       /* if net_type is MES_INTERNET, set the dest node to 'internet' */
+       if (net_type == MES_INTERNET) {
                strcpy(dest_node, "internet");
        }
 
        while (isspace(recipient[strlen(recipient) - 1]))
                recipient[strlen(recipient) - 1] = 0;
 
-       time(&now);
-       fp = fopen(filename, "w");
-       putc(255, fp);
-       putc(type, fp);         /* Normal or anonymous, see MES_ flags */
-       putc(format_type, fp);  /* Formatted or unformatted */
-       fprintf(fp, "Pcit%ld%c", author->usernum, 0);   /* path */
-       fprintf(fp, "T%ld%c", (long) now, 0);   /* date/time */
-
-       if (fake_name[0])
-               fprintf(fp, "A%s%c", fake_name, 0);
+       sprintf(buf, "cit%ld", author->usernum);                /* Path */
+       msg->cm_fields['P'] = strdoop(buf);
+
+       sprintf(buf, "%ld", time(NULL));                        /* timestamp */
+       msg->cm_fields['T'] = strdoop(buf);
+
+       if (fake_name[0])                                       /* author */
+               msg->cm_fields['A'] = strdoop(fake_name);
        else
-               fprintf(fp, "A%s%c", author->fullname, 0);      /* author */
+               msg->cm_fields['A'] = strdoop(author->fullname);
 
-       if (CC->quickroom.QRflags & QR_MAILBOX) {       /* room */
-               fprintf(fp, "O%s%c", &CC->quickroom.QRname[11], 0);
-       } else {
-               fprintf(fp, "O%s%c", CC->quickroom.QRname, 0);
-       }
+       if (CC->quickroom.QRflags & QR_MAILBOX)                 /* room */
+               msg->cm_fields['O'] = strdoop(&CC->quickroom.QRname[11]);
+       else
+               msg->cm_fields['O'] = strdoop(CC->quickroom.QRname);
 
-       fprintf(fp, "N%s%c", NODENAME, 0);      /* nodename */
-       fprintf(fp, "H%s%c", HUMANNODE, 0);     /* human nodename */
+       msg->cm_fields['N'] = strdoop(NODENAME);                /* nodename */
+       msg->cm_fields['H'] = strdoop(HUMANNODE);               /* hnodename */
 
        if (recipient[0] != 0)
-               fprintf(fp, "R%s%c", recipient, 0);
+               msg->cm_fields['R'] = strdoop(recipient);
        if (dest_node[0] != 0)
-               fprintf(fp, "D%s%c", dest_node, 0);
+               msg->cm_fields['D'] = strdoop(dest_node);
 
-       putc('M', fp);
+       msg->cm_fields['M'] = mallok(4096);
+       if (msg->cm_fields['M'] == NULL) {
+               while (client_gets(buf), strcmp(buf, "000")) ;; /* flush */
+               return(msg);
+       } else {
+               buffer_len = 4096;
+               msg->cm_fields['M'][0] = 0;
+               message_len = 0;
+       }
 
+       /* read in the lines of message text one by one */
        while (client_gets(buf), strcmp(buf, "000")) {
-               if (msglen < config.c_maxmsglen) 
-                       fprintf(fp, "%s\n", buf);
-               else
-                       lprintf(7, "Message exceeded %d byte limit\n",
-                               config.c_maxmsglen);
-               msglen = msglen + strlen(buf) + 1;
+
+               /* augment the buffer if we have to */
+               if ((message_len + strlen(buf) + 2) > buffer_len) {
+                       ptr = reallok(msg->cm_fields['M'], (buffer_len * 2) );
+                       if (ptr == NULL) {      /* flush if can't allocate */
+                               while (client_gets(buf), strcmp(buf, "000")) ;;
+                               return(msg);
+                       } else {
+                               buffer_len = (buffer_len * 2);
+                               msg->cm_fields['M'] = ptr;
+                       }
+               }
+
+               strcat(msg->cm_fields['M'], buf);
+               strcat(msg->cm_fields['M'], "\n");
+
+               /* if we've hit the max msg length, flush the rest */
+               if (message_len >= config.c_maxmsglen) {
+                       while (client_gets(buf), strcmp(buf, "000")) ;;
+                       return(msg);
+               }
        }
 
-       putc(0, fp);
-       fclose(fp);
+       return(msg);
 }
 
 
@@ -1335,7 +1619,7 @@ void cmd_ent0(char *entargs)
        int anon_flag = 0;
        int format_type = 0;
        char newusername[256];
-
+       struct CtdlMessage *msg;
        int a, b;
        int e = 0;
        int mtsflag = 0;
@@ -1392,9 +1676,7 @@ void cmd_ent0(char *entargs)
                        strcpy(buf, recipient);
                } else
                        strcpy(buf, "sysop");
-               lprintf(9, "calling alias()\n");
                e = alias(buf); /* alias and mail type */
-               lprintf(9, "alias() returned %d\n", e);
                if ((buf[0] == 0) || (e == MES_ERROR)) {
                        cprintf("%d Unknown address - cannot send message.\n",
                                ERROR + NO_SUCH_USER);
@@ -1424,7 +1706,7 @@ void cmd_ent0(char *entargs)
                        return;
                }
                /* Check to make sure the user exists; also get the correct
-                  * upper/lower casing of the name. 
+                * upper/lower casing of the name. 
                 */
                a = getuser(&tempUS, buf);
                if (a != 0) {
@@ -1454,19 +1736,22 @@ SKFALL: b = MES_NORMAL;
 
        cprintf("%d send message\n", SEND_LISTING);
 
+       /* Read in the message from the client. */
        if (CC->fake_postname[0])
-               make_message(CC->temp, &CC->usersupp, buf,
+               msg = make_message(&CC->usersupp, buf,
                        CC->quickroom.QRname, b, e, format_type,
                        CC->fake_postname);
        else if (CC->fake_username[0])
-               make_message(CC->temp, &CC->usersupp, buf,
+               msg = make_message(&CC->usersupp, buf,
                        CC->quickroom.QRname, b, e, format_type,
                        CC->fake_username);
        else
-               make_message(CC->temp, &CC->usersupp, buf,
+               msg = make_message(&CC->usersupp, buf,
                        CC->quickroom.QRname, b, e, format_type, "");
 
-       save_message(CC->temp, buf, (mtsflag ? AIDEROOM : ""), e, 1);
+       if (msg != NULL)
+               CtdlSaveMsg(msg, buf, (mtsflag ? AIDEROOM : ""), e, 1);
+               CtdlFreeMessage(msg);
        CC->fake_postname[0] = '\0';
        return;
 }
@@ -1479,20 +1764,22 @@ SKFALL: b = MES_NORMAL;
 void cmd_ent3(char *entargs)
 {
        char recp[256];
-       char buf[256];
        int a;
        int e = 0;
+       unsigned char ch, which_field;
        struct usersupp tempUS;
        long msglen;
-       long bloklen;
-       FILE *fp;
+       struct CtdlMessage *msg;
+       char *tempbuf;
 
        if (CC->internal_pgm == 0) {
                cprintf("%d This command is for internal programs only.\n",
                        ERROR);
                return;
        }
-       /* See if there's a recipient, but make sure it's a real one */ extract(recp, entargs, 1);
+
+       /* See if there's a recipient, but make sure it's a real one */
+       extract(recp, entargs, 1);
        for (a = 0; a < strlen(recp); ++a)
                if (!isprint(recp[a]))
                        strcpy(&recp[a], &recp[a + 1]);
@@ -1518,37 +1805,62 @@ void cmd_ent3(char *entargs)
                        }
                }
        }
+
        /* At this point, message has been approved. */
        if (extract_int(entargs, 0) == 0) {
                cprintf("%d OK to send\n", OK);
                return;
        }
-       /* open a temp file to hold the message */
-       fp = fopen(CC->temp, "wb");
-       if (fp == NULL) {
-               cprintf("%d Cannot open %s: %s\n",
-                       ERROR + INTERNAL_ERROR,
-                       CC->temp, strerror(errno));
+
+       msglen = extract_long(entargs, 2);
+       msg = mallok(sizeof(struct CtdlMessage));
+       if (msg == NULL) {
+               cprintf("%d Out of memory\n", ERROR+INTERNAL_ERROR);
                return;
        }
-       msglen = extract_long(entargs, 2);
-       cprintf("%d %ld\n", SEND_BINARY, msglen);
-       while (msglen > 0L) {
-               bloklen = ((msglen >= 255L) ? 255 : msglen);
-               client_read(buf, (int) bloklen);
-               fwrite(buf, (int) bloklen, 1, fp);
-               msglen = msglen - bloklen;
+
+       memset(msg, 0, sizeof(struct CtdlMessage));
+       tempbuf = mallok(msglen);
+       if (tempbuf == NULL) {
+               cprintf("%d Out of memory\n", ERROR+INTERNAL_ERROR);
+               phree(msg);
+               return;
        }
-       fclose(fp);
 
-       save_message(CC->temp, recp, "", e, 0);
+       cprintf("%d %ld\n", SEND_BINARY, msglen);
+
+       client_read(&ch, 1);                            /* 0xFF magic number */
+       msg->cm_magic = CTDLMESSAGE_MAGIC;
+       client_read(&ch, 1);                            /* anon type */
+       msg->cm_anon_type = ch;
+       client_read(&ch, 1);                            /* format type */
+       msg->cm_format_type = ch;
+       msglen = msglen - 3;
+
+       while (msglen > 0) {
+               client_read(&which_field, 1);
+               --msglen;
+               tempbuf[0] = 0;
+               do {
+                       client_read(&ch, 1);
+                       --msglen;
+                       a = strlen(tempbuf);
+                       tempbuf[a+1] = 0;
+                       tempbuf[a] = ch;
+               } while ( (ch != 0) && (msglen > 0) );
+               msg->cm_fields[which_field] = strdoop(tempbuf);
+       }
+
+       msg->cm_flags = CM_SKIP_HOOKS;
+       CtdlSaveMsg(msg, recp, "", e, 0);
+       CtdlFreeMessage(msg);
+       phree(tempbuf);
 }
 
 
 /*
  * API function to delete messages which match a set of criteria
  * (returns the actual number of messages deleted)
- * FIX ... still need to implement delete by content type
  */
 int CtdlDeleteMessages(char *room_name,                /* which room */
                       long dmsgnum,            /* or "0" for any */
@@ -1576,7 +1888,6 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
        }
        cdbfr = cdb_fetch(CDB_MSGLISTS, &qrbuf.QRnumber, sizeof(long));
 
-       lprintf(9, "doing mallok/memcpy loop\n");
        if (cdbfr != NULL) {
                msglist = mallok(cdbfr->len);
                memcpy(msglist, cdbfr->ptr, cdbfr->len);
@@ -1635,7 +1946,8 @@ void cmd_dele(char *delstr)
        getuser(&CC->usersupp, CC->curr_user);
        if ((CC->usersupp.axlevel < 6)
            && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
+           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
+           && (!(CC->internal_pgm))) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -1744,11 +2056,13 @@ void PutSuppMsgInfo(struct SuppMsgInfo *smibuf)
                  &TheIndex, sizeof(long),
                  smibuf, sizeof(struct SuppMsgInfo));
 
-}                              /*
+}
 
-                                * AdjRefCount  -  change the reference count for a message;
-                                *                 delete the message if it reaches zero
-                                */ void AdjRefCount(long msgnum, int incr)
+/*
+ * AdjRefCount  -  change the reference count for a message;
+ *                 delete the message if it reaches zero
+ */
+void AdjRefCount(long msgnum, int incr)
 {
 
        struct SuppMsgInfo smi;
@@ -1781,13 +2095,17 @@ void PutSuppMsgInfo(struct SuppMsgInfo *smibuf)
 
 /*
  * Write a generic object to this room
+ *
+ * Note: this could be much more efficient.  Right now we use two temporary
+ * files, and still pull the message into memory as with all others.
  */
 void CtdlWriteObject(char *req_room,           /* Room to stuff it in */
                        char *content_type,     /* MIME type of this object */
                        char *tempfilename,     /* Where to fetch it from */
-                       int is_mailbox,         /* Private mailbox room? */
+                       struct usersupp *is_mailbox,    /* Mailbox room? */
                        int is_binary,          /* Is encoding necessary? */
-                       int is_unique   /* Del others of this type? */
+                       int is_unique,          /* Del others of this type? */
+                       unsigned int flags      /* Internal save flags */
                        )
 {
 
@@ -1797,30 +2115,30 @@ void CtdlWriteObject(char *req_room,            /* Room to stuff it in */
        int ch;
        struct quickroom qrbuf;
        char roomname[ROOMNAMELEN];
+       struct CtdlMessage *msg;
+       size_t len;
 
-       if (is_mailbox)
-               MailboxName(roomname, &CC->usersupp, req_room);
+       if (is_mailbox != NULL)
+               MailboxName(roomname, is_mailbox, req_room);
        else
                safestrncpy(roomname, req_room, sizeof(roomname));
+       lprintf(9, "CtdlWriteObject() to <%s> (flags=%d)\n", roomname, flags);
 
        strcpy(filename, tmpnam(NULL));
        fp = fopen(filename, "w");
        if (fp == NULL)
                return;
 
-       fprintf(fp, "%c%c%c", 0xFF, MES_NORMAL, 4);
-       fprintf(fp, "T%ld%c", time(NULL), 0);
-       fprintf(fp, "A%s%c", CC->usersupp.fullname, 0);
-       fprintf(fp, "O%s%c", roomname, 0);
-       fprintf(fp, "N%s%c", config.c_nodename, 0);
-       fprintf(fp, "MContent-type: %s\n", content_type);
-
        tempfp = fopen(tempfilename, "r");
        if (tempfp == NULL) {
                fclose(fp);
                unlink(filename);
                return;
        }
+
+       fprintf(fp, "Content-type: %s\n", content_type);
+       lprintf(9, "Content-type: %s\n", content_type);
+
        if (is_binary == 0) {
                fprintf(fp, "Content-transfer-encoding: 7bit\n\n");
                while (ch = getc(tempfp), ch > 0)
@@ -1837,6 +2155,28 @@ void CtdlWriteObject(char *req_room,             /* Room to stuff it in */
                system(cmdbuf);
        }
 
+       lprintf(9, "Allocating\n");
+       msg = mallok(sizeof(struct CtdlMessage));
+       memset(msg, 0, sizeof(struct CtdlMessage));
+       msg->cm_magic = CTDLMESSAGE_MAGIC;
+       msg->cm_anon_type = MES_NORMAL;
+       msg->cm_format_type = 4;
+       msg->cm_fields['A'] = strdoop(CC->usersupp.fullname);
+       msg->cm_fields['O'] = strdoop(req_room);
+       msg->cm_fields['N'] = strdoop(config.c_nodename);
+       msg->cm_fields['H'] = strdoop(config.c_humannode);
+       msg->cm_flags = flags;
+       
+       lprintf(9, "Loading\n");
+       fp = fopen(filename, "rb");
+       fseek(fp, 0L, SEEK_END);
+       len = ftell(fp);
+       rewind(fp);
+       msg->cm_fields['M'] = mallok(len);
+       fread(msg->cm_fields['M'], len, 1, fp);
+       fclose(fp);
+       unlink(filename);
+
        /* Create the requested room if we have to. */
        if (getroom(&qrbuf, roomname) != 0) {
                create_room(roomname, 4, "", 0);
@@ -1849,5 +2189,6 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
                        CtdlDeleteMessages(roomname, 0L, content_type));
        }
        /* Now write the data */
-       save_message(filename, "", roomname, MES_LOCAL, 1);
+       CtdlSaveMsg(msg, "", roomname, MES_LOCAL, 1);
+       CtdlFreeMessage(msg);
 }