]> code.citadel.org Git - citadel.git/blobdiff - citadel/msgbase.c
warning fixes and cleanups for 64-bit machines
[citadel.git] / citadel / msgbase.c
index 5be0bcf3bbacc67bd94724f678b00adc1e13e568..e5c1bcac02e760bf4d21ce666ad7492387a07016 100644 (file)
@@ -1,11 +1,31 @@
-/* $Id$ */
+/*
+ * $Id$
+ *
+ * Implements the message store.
+ *
+ */
+
+#ifdef DLL_EXPORT
+#define IN_LIBCIT
+#endif
 
 #include "sysdep.h"
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <fcntl.h>
-#include <time.h>
+
+#if TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# if HAVE_SYS_TIME_H
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #include <ctype.h>
 #include <string.h>
 #include <syslog.h>
@@ -15,6 +35,7 @@
 #include <sys/stat.h>
 #include "citadel.h"
 #include "server.h"
+#include "dynloader.h"
 #include "database.h"
 #include "msgbase.h"
 #include "support.h"
@@ -24,7 +45,6 @@
 #include "user_ops.h"
 #include "file_ops.h"
 #include "control.h"
-#include "dynloader.h"
 #include "tools.h"
 #include "mime_parser.h"
 #include "html.h"
@@ -80,17 +100,17 @@ void remove_any_whitespace_to_the_left_or_right_of_at_symbol(char *name)
 {
        int i;
 
-       for (i = 0; i < strlen(name); ++i)
+       for (i = 0; i < strlen(name); ++i) {
                if (name[i] == '@') {
-                       if (i > 0)
-                               if (isspace(name[i - 1])) {
-                                       strcpy(&name[i - 1], &name[i]);
-                                       i = 0;
-                               }
+                       while (isspace(name[i - 1]) && i > 0) {
+                               strcpy(&name[i - 1], &name[i]);
+                               --i;
+                       }
                        while (isspace(name[i + 1])) {
                                strcpy(&name[i + 1], &name[i + 2]);
                        }
                }
+       }
 }
 
 
@@ -104,16 +124,13 @@ int alias(char *name)
        int a, b;
        char aaa[300], bbb[300];
 
-       TRACE;
        remove_any_whitespace_to_the_left_or_right_of_at_symbol(name);
-       TRACE;
 
        fp = fopen("network/mail.aliases", "r");
        if (fp == NULL)
                fp = fopen("/dev/null", "r");
        if (fp == NULL)
                return (MES_ERROR);
-       TRACE;
        strcpy(aaa, "");
        strcpy(bbb, "");
        while (fgets(aaa, sizeof aaa, fp) != NULL) {
@@ -130,7 +147,6 @@ int alias(char *name)
                if (!strcasecmp(name, aaa))
                        strcpy(name, bbb);
        }
-       TRACE;
        fclose(fp);
        lprintf(7, "Mail is being forwarded to %s\n", name);
 
@@ -145,18 +161,15 @@ int alias(char *name)
        }
 
        /* determine local or remote type, see citadel.h */
-       TRACE;
        for (a = 0; a < strlen(name); ++a)
                if (name[a] == '!')
                        return (MES_INTERNET);
-       TRACE;
        for (a = 0; a < strlen(name); ++a)
                if (name[a] == '@')
                        for (b = a; b < strlen(name); ++b)
                                if (name[b] == '.')
                                        return (MES_INTERNET);
        b = 0;
-       TRACE;
        for (a = 0; a < strlen(name); ++a)
                if (name[a] == '@')
                        ++b;
@@ -172,11 +185,10 @@ int alias(char *name)
                        strcpy(bbb, &bbb[1]);
                fp = fopen("network/mail.sysinfo", "r");
                if (fp == NULL)
-                       return (MES_ERROR);
+                       return (MES_ERROR);    
 GETSN:         do {
                        a = getstring(fp, aaa);
                } while ((a >= 0) && (strcasecmp(aaa, bbb)));
-               TRACE;
                a = getstring(fp, aaa);
                if (!strncmp(aaa, "use ", 4)) {
                        strcpy(bbb, &aaa[4]);
@@ -184,7 +196,6 @@ GETSN:              do {
                        goto GETSN;
                }
                fclose(fp);
-               TRACE;
                if (!strncmp(aaa, "uum", 3)) {
                        strcpy(bbb, name);
                        for (a = 0; a < strlen(bbb); ++a) {
@@ -218,7 +229,6 @@ GETSN:              do {
                }
                return (MES_ERROR);
        }
-       TRACE;
        lprintf(9, "returning MES_LOCAL\n");
        return (MES_LOCAL);
 }
@@ -235,7 +245,7 @@ void get_mm(void)
 
 
 
-void simple_listing(long msgnum)
+void simple_listing(long msgnum, void *userdata)
 {
        cprintf("%ld\n", msgnum);
 }
@@ -271,6 +281,81 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
 }
 
 
+/*
+ * Manipulate the "seen msgs" string.
+ */
+void CtdlSetSeen(long target_msgnum, int target_setting) {
+       char newseen[SIZ];
+       struct cdbdata *cdbfr;
+       int i;
+       int is_seen = 0;
+       int was_seen = 1;
+       long lo = (-1L);
+       long hi = (-1L);
+       struct visit vbuf;
+       long *msglist;
+       int num_msgs = 0;
+
+       /* Learn about the user and room in question */
+       get_mm();
+       getuser(&CC->usersupp, CC->curr_user);
+       CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+
+       /* Load the message list */
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+       if (cdbfr != NULL) {
+               msglist = mallok(cdbfr->len);
+               memcpy(msglist, cdbfr->ptr, cdbfr->len);
+               num_msgs = cdbfr->len / sizeof(long);
+               cdb_free(cdbfr);
+       } else {
+               return; /* No messages at all?  No further action. */
+       }
+
+       lprintf(9, "before optimize: %s\n", vbuf.v_seen);
+       strcpy(newseen, "");
+
+       for (i=0; i<num_msgs; ++i) {
+               is_seen = 0;
+
+               if (msglist[i] == target_msgnum) {
+                       is_seen = target_setting;
+               }
+               else {
+                       if (is_msg_in_mset(vbuf.v_seen, msglist[i])) {
+                               is_seen = 1;
+                       }
+               }
+
+               if (is_seen == 1) {
+                       if (lo < 0L) lo = msglist[i];
+                       hi = msglist[i];
+               }
+               if (  ((is_seen == 0) && (was_seen == 1))
+                  || ((is_seen == 1) && (i == num_msgs-1)) ) {
+                       if ( (strlen(newseen) + 20) > SIZ) {
+                               strcpy(newseen, &newseen[20]);
+                               newseen[0] = '*';
+                       }
+                       if (strlen(newseen) > 0) strcat(newseen, ",");
+                       if (lo == hi) {
+                               sprintf(&newseen[strlen(newseen)], "%ld", lo);
+                       }
+                       else {
+                               sprintf(&newseen[strlen(newseen)], "%ld:%ld",
+                                       lo, hi);
+                       }
+                       lo = (-1L);
+                       hi = (-1L);
+               }
+               was_seen = is_seen;
+       }
+
+       safestrncpy(vbuf.v_seen, newseen, SIZ);
+       lprintf(9, " after optimize: %s\n", vbuf.v_seen);
+       phree(msglist);
+       CtdlSetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+}
 
 
 /*
@@ -281,7 +366,8 @@ int CtdlForEachMessage(int mode, long ref,
                        int moderation_level,
                        char *content_type,
                        struct CtdlMessage *compare,
-                       void (*CallBack) (long msgnum))
+                       void (*CallBack) (long, void *),
+                       void *userdata)
 {
 
        int a;
@@ -293,6 +379,9 @@ int CtdlForEachMessage(int mode, long ref,
        long thismsg;
        struct SuppMsgInfo smi;
        struct CtdlMessage *msg;
+       int is_seen;
+       long lastold = 0L;
+       int printed_lastold = 0;
 
        /* Learn about the user and room in question */
        get_mm();
@@ -311,6 +400,9 @@ int CtdlForEachMessage(int mode, long ref,
        }
 
 
+       /*
+        * Now begin the traversal.
+        */
        if (num_msgs > 0) for (a = 0; a < num_msgs; ++a) {
                GetSuppMsgInfo(&smi, msglist[a]);
 
@@ -358,21 +450,27 @@ int CtdlForEachMessage(int mode, long ref,
        if (num_msgs > 0)
                for (a = 0; a < num_msgs; ++a) {
                        thismsg = msglist[a];
-                       if ((thismsg > 0)
+                       is_seen = is_msg_in_mset(vbuf.v_seen, thismsg);
+                       if (is_seen) lastold = thismsg;
+                       if ((thismsg > 0L)
                            && (
 
                                       (mode == MSGS_ALL)
-                                      || ((mode == MSGS_OLD) && (thismsg <= vbuf.v_lastseen))
-                                      || ((mode == MSGS_NEW) && (thismsg > vbuf.v_lastseen))
-                                      || ((mode == MSGS_NEW) && (thismsg >= vbuf.v_lastseen)
-                                   && (CC->usersupp.flags & US_LASTOLD))
+                                      || ((mode == MSGS_OLD) && (is_seen))
+                                      || ((mode == MSGS_NEW) && (!is_seen))
                                       || ((mode == MSGS_LAST) && (a >= (num_msgs - ref)))
                                   || ((mode == MSGS_FIRST) && (a < ref))
                                || ((mode == MSGS_GT) && (thismsg > ref))
                                || ((mode == MSGS_EQ) && (thismsg == ref))
                            )
                            ) {
-                               if (CallBack) CallBack(thismsg);
+                               if ((mode == MSGS_NEW) && (CC->usersupp.flags & US_LASTOLD) && (lastold > 0L) && (printed_lastold == 0) && (!is_seen)) {
+                                       if (CallBack)
+                                               CallBack(lastold, userdata);
+                                       printed_lastold = 1;
+                                       ++num_processed;
+                               }
+                               if (CallBack) CallBack(thismsg, userdata);
                                ++num_processed;
                        }
                }
@@ -389,10 +487,10 @@ int CtdlForEachMessage(int mode, long ref,
 void cmd_msgs(char *cmdbuf)
 {
        int mode = 0;
-       char which[256];
-       char buf[256];
-       char tfield[256];
-       char tvalue[256];
+       char which[SIZ];
+       char buf[SIZ];
+       char tfield[SIZ];
+       char tvalue[SIZ];
        int cm_ref = 0;
        int i;
        int with_template = 0;
@@ -443,7 +541,7 @@ void cmd_msgs(char *cmdbuf)
 
        CtdlForEachMessage(mode, cm_ref,
                CC->usersupp.moderation_filter,
-               NULL, template, simple_listing);
+               NULL, template, simple_listing, NULL);
        if (template != NULL) CtdlFreeMessage(template);
        cprintf("000\n");
 }
@@ -456,7 +554,7 @@ void cmd_msgs(char *cmdbuf)
  */
 void help_subst(char *strbuf, char *source, char *dest)
 {
-       char workbuf[256];
+       char workbuf[SIZ];
        int p;
 
        while (p = pattern2(strbuf, source), (p >= 0)) {
@@ -503,74 +601,72 @@ void memfmout(
        int old = 0;
        CIT_UBYTE ch;
        char aaa[140];
-       char buffer[256];
+       char buffer[SIZ];
 
        strcpy(aaa, "");
        old = 255;
        strcpy(buffer, "");
        c = 1;                  /* c is the current pos */
 
-FMTA:  if (subst) {
-               while (ch = *mptr, ((ch != 0) && (strlen(buffer) < 126))) {
-                       ch = *mptr++;
-                       buffer[strlen(buffer) + 1] = 0;
-                       buffer[strlen(buffer)] = ch;
-               }
-
-               if (buffer[0] == '^')
-                       do_help_subst(buffer);
+       do {
+               if (subst) {
+                       while (ch = *mptr, ((ch != 0) && (strlen(buffer) < 126))) {
+                               ch = *mptr++;
+                               buffer[strlen(buffer) + 1] = 0;
+                               buffer[strlen(buffer)] = ch;
+                       }
 
-               buffer[strlen(buffer) + 1] = 0;
-               a = buffer[0];
-               strcpy(buffer, &buffer[1]);
-       } else {
-               ch = *mptr++;
-       }
+                       if (buffer[0] == '^')
+                               do_help_subst(buffer);
 
-       old = real;
-       real = ch;
-       if (ch <= 0)
-               goto FMTEND;
+                       buffer[strlen(buffer) + 1] = 0;
+                       a = buffer[0];
+                       strcpy(buffer, &buffer[1]);
+               } else {
+                       ch = *mptr++;
+               }
 
-       if (((ch == 13) || (ch == 10)) && (old != 13) && (old != 10))
-               ch = 32;
-       if (((old == 13) || (old == 10)) && (isspace(real))) {
-               cprintf("%s", nl);
-               c = 1;
-       }
-       if (ch > 126)
-               goto FMTA;
+               old = real;
+               real = ch;
 
-       if (ch > 32) {
-               if (((strlen(aaa) + c) > (width - 5)) && (strlen(aaa) > (width - 5))) {
-                       cprintf("%s%s", nl, aaa);
-                       c = strlen(aaa);
-                       aaa[0] = 0;
-               }
-               b = strlen(aaa);
-               aaa[b] = ch;
-               aaa[b + 1] = 0;
-       }
-       if (ch == 32) {
-               if ((strlen(aaa) + c) > (width - 5)) {
+               if (((ch == 13) || (ch == 10)) && (old != 13) && (old != 10))
+                       ch = 32;
+               if (((old == 13) || (old == 10)) && (isspace(real))) {
                        cprintf("%s", nl);
                        c = 1;
                }
-               cprintf("%s ", aaa);
-               ++c;
-               c = c + strlen(aaa);
-               strcpy(aaa, "");
-               goto FMTA;
-       }
-       if ((ch == 13) || (ch == 10)) {
-               cprintf("%s%s", aaa, nl);
-               c = 1;
-               strcpy(aaa, "");
-               goto FMTA;
-       }
-       goto FMTA;
+               if (ch > 126)
+                       continue;
+
+               if (ch > 32) {
+                       if (((strlen(aaa) + c) > (width - 5)) && (strlen(aaa) > (width - 5))) {
+                               cprintf("%s%s", nl, aaa);
+                               c = strlen(aaa);
+                               aaa[0] = 0;
+                       }
+                       b = strlen(aaa);
+                       aaa[b] = ch;
+                       aaa[b + 1] = 0;
+               }
+               if (ch == 32) {
+                       if ((strlen(aaa) + c) > (width - 5)) {
+                               cprintf("%s", nl);
+                               c = 1;
+                       }
+                       cprintf("%s ", aaa);
+                       ++c;
+                       c = c + strlen(aaa);
+                       strcpy(aaa, "");
+               }
+               if ((ch == 13) || (ch == 10)) {
+                       cprintf("%s%s", aaa, nl);
+                       c = 1;
+                       strcpy(aaa, "");
+               }
+
+       } while (ch > 0);
 
-FMTEND:        cprintf("%s%s", aaa, nl);
+       cprintf("%s%s", aaa, nl);
 }
 
 
@@ -579,7 +675,8 @@ FMTEND:     cprintf("%s%s", aaa, nl);
  * Callback function for mime parser that simply lists the part
  */
 void list_this_part(char *name, char *filename, char *partnum, char *disp,
-                   void *content, char *cbtype, size_t length)
+                   void *content, char *cbtype, size_t length, char *encoding,
+                   void *cbuserdata)
 {
 
        cprintf("part=%s|%s|%s|%s|%s|%d\n",
@@ -591,7 +688,8 @@ void list_this_part(char *name, char *filename, char *partnum, char *disp,
  * Callback function for mime parser that opens a section for downloading
  */
 void mime_download(char *name, char *filename, char *partnum, char *disp,
-                  void *content, char *cbtype, size_t length)
+                  void *content, char *cbtype, size_t length, char *encoding,
+                  void *cbuserdata)
 {
 
        /* Silently go away if there's already a download open... */
@@ -723,31 +821,64 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
 
 
 /*
- * Callback function for mime parser that wants to display text
+ * Pre callback function for multipart/alternative
+ *
+ * NOTE: this differs from the standard behavior for a reason.  Normally when
+ *       displaying multipart/alternative you want to show the _last_ usable
+ *       format in the message.  Here we show the _first_ one, because it's
+ *       usually text/plain.  Since this set of functions is designed for text
+ *       output to non-MIME-aware clients, this is the desired behavior.
+ *
  */
-void fixed_output(char *name, char *filename, char *partnum, char *disp,
-               void *content, char *cbtype, size_t length)
-       {
-               char *ptr;
-               char *wptr;
-               size_t wlen;
-               CIT_UBYTE ch;
-       
+void fixed_output_pre(char *name, char *filename, char *partnum, char *disp,
+               void *content, char *cbtype, size_t length, char *encoding,
+               void *cbuserdata)
+{
+               lprintf(9, "fixed_output_pre() type=<%s>\n", cbtype);   
                if (!strcasecmp(cbtype, "multipart/alternative")) {
-                       strcpy(ma->prefix, partnum);
-                       strcat(ma->prefix, ".");
                        ma->is_ma = 1;
                        ma->did_print = 0;
                        return;
                }
-       
-               if ( (!strncasecmp(partnum, ma->prefix, strlen(ma->prefix)))
-               && (ma->is_ma == 1) 
-               && (ma->did_print == 1) ) {
+}
+
+/*
+ * Post callback function for multipart/alternative
+ */
+void fixed_output_post(char *name, char *filename, char *partnum, char *disp,
+               void *content, char *cbtype, size_t length, char *encoding,
+               void *cbuserdata)
+{
+               lprintf(9, "fixed_output_post() type=<%s>\n", cbtype);  
+               if (!strcasecmp(cbtype, "multipart/alternative")) {
+                       ma->is_ma = 0;
+                       ma->did_print = 0;
+                       return;
+               }
+}
+
+/*
+ * Inline callback function for mime parser that wants to display text
+ */
+void fixed_output(char *name, char *filename, char *partnum, char *disp,
+               void *content, char *cbtype, size_t length, char *encoding,
+               void *cbuserdata)
+       {
+               char *ptr;
+               char *wptr;
+               size_t wlen;
+               CIT_UBYTE ch = 0;
+
+               lprintf(9, "fixed_output() type=<%s>\n", cbtype);       
+
+               /*
+                * If we're in the middle of a multipart/alternative scope and
+                * we've already printed another section, skip this one.
+                */     
+               if ( (ma->is_ma == 1) && (ma->did_print == 1) ) {
                        lprintf(9, "Skipping part %s (%s)\n", partnum, cbtype);
                        return;
                }
-       
                ma->did_print = 1;
        
                if ( (!strcasecmp(cbtype, "text/plain")) 
@@ -756,9 +887,13 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp,
                        wptr = content;
                        while (wlen--) {
                                ch = *wptr++;
+                               /**********
                                if (ch==10) cprintf("\r\n");
                                else cprintf("%c", ch);
+                                **********/
+                               cprintf("%c", ch);
                        }
+                       if (ch != '\n') cprintf("\n");
                }
                else if (!strcasecmp(cbtype, "text/html")) {
                        ptr = html_to_ascii(content, 80, 0);
@@ -788,31 +923,13 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
                int do_proto,           /* do Citadel protocol responses? */
                int crlf                /* Use CRLF newlines instead of LF? */
 ) {
-       int i, k;
-       char buf[1024];
-       CIT_UBYTE ch;
-       char allkeys[256];
-       char display_name[256];
        struct CtdlMessage *TheMessage;
-       char *mptr;
-       char *nl;       /* newline string */
-
-       /* buffers needed for RFC822 translation */
-       char suser[256];
-       char luser[256];
-       char fuser[256];
-       char snode[256];
-       char lnode[256];
-       char mid[256];
-       char datestamp[256];
-       /*                                       */
+       int retcode;
 
        lprintf(7, "CtdlOutputMsg() msgnum=%ld, mode=%d\n", 
                msg_num, mode);
 
        TheMessage = NULL;
-       sprintf(mid, "%ld", msg_num);
-       nl = (crlf ? "\r\n" : "\n");
 
        if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
                if (do_proto) cprintf("%d Not logged in.\n",
@@ -842,6 +959,52 @@ int CtdlOutputMsg(long msg_num,            /* message number (local) to fetch */
                        ERROR, msg_num);
                return(om_no_such_msg);
        }
+       
+       retcode = CtdlOutputPreLoadedMsg(
+                       TheMessage, msg_num, mode,
+                       headers_only, do_proto, crlf);
+
+       CtdlFreeMessage(TheMessage);
+       return(retcode);
+}
+
+
+/*
+ * Get a message off disk.  (returns om_* values found in msgbase.h)
+ * 
+ */
+int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
+               long msg_num,
+               int mode,               /* how would you like that message? */
+               int headers_only,       /* eschew the message body? */
+               int do_proto,           /* do Citadel protocol responses? */
+               int crlf                /* Use CRLF newlines instead of LF? */
+) {
+       int i, k;
+       char buf[1024];
+       CIT_UBYTE ch;
+       char allkeys[SIZ];
+       char display_name[SIZ];
+       char *mptr;
+       char *nl;       /* newline string */
+
+       /* buffers needed for RFC822 translation */
+       char suser[SIZ];
+       char luser[SIZ];
+       char fuser[SIZ];
+       char snode[SIZ];
+       char lnode[SIZ];
+       char mid[SIZ];
+       char datestamp[SIZ];
+       /*                                       */
+
+       sprintf(mid, "%ld", msg_num);
+       nl = (crlf ? "\r\n" : "\n");
+
+       if (!is_valid_message(TheMessage)) {
+               lprintf(1, "ERROR: invalid preloaded message for output\n");
+               return(om_no_such_msg);
+       }
 
        /* Are we downloading a MIME component? */
        if (mode == MT_DOWNLOAD) {
@@ -856,7 +1019,9 @@ int CtdlOutputMsg(long msg_num,            /* message number (local) to fetch */
                } else {
                        /* Parse the message text component */
                        mptr = TheMessage->cm_fields['M'];
-                       mime_parser(mptr, NULL, *mime_download);
+                       mime_parser(mptr, NULL,
+                               *mime_download, NULL, NULL,
+                               NULL, 0);
                        /* If there's no file open by this time, the requested
                         * section wasn't found, so print an error
                         */
@@ -867,7 +1032,6 @@ int CtdlOutputMsg(long msg_num,            /* message number (local) to fetch */
                                        desired_section);
                        }
                }
-               CtdlFreeMessage(TheMessage);
                return((CC->download_fp != NULL) ? om_ok : om_mime_error);
        }
 
@@ -953,9 +1117,15 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
                                        strcpy(luser, mptr);
                                        strcpy(suser, mptr);
                                }
+/****
+ "Path:" removed for now because it confuses brain-dead Microsoft shitware
+ into thinking that mail messages are newsgroup messages instead.  When we
+ add NNTP support back into Citadel we'll have to add code to only output
+ this field when appropriate.
                                else if (i == 'P') {
                                        cprintf("Path: %s%s", mptr, nl);
                                }
+ ****/
                                else if (i == 'U')
                                        cprintf("Subject: %s%s", mptr, nl);
                                else if (i == 'I')
@@ -970,8 +1140,8 @@ int CtdlOutputMsg(long msg_num,            /* message number (local) to fetch */
                                else if (i == 'R')
                                        cprintf("To: %s%s", mptr, nl);
                                else if (i == 'T') {
-                                       generate_rfc822_datestamp(datestamp,
-                                                               atol(mptr) );
+                                       datestring(datestamp, atol(mptr),
+                                               DATESTRING_RFC822 );
                                        cprintf("Date: %s%s", datestamp, nl);
                                }
                        }
@@ -1014,12 +1184,15 @@ int CtdlOutputMsg(long msg_num,         /* message number (local) to fetch */
        /* Tell the client about the MIME parts in this message */
        if (TheMessage->cm_format_type == FMT_RFC822) {
                if (mode == MT_CITADEL) {
-                       mime_parser(mptr, NULL, *list_this_part);
+                       mime_parser(mptr, NULL,
+                               *list_this_part, NULL, NULL,
+                               NULL, 0);
                }
                else if (mode == MT_MIME) {     /* list parts only */
-                       mime_parser(mptr, NULL, *list_this_part);
+                       mime_parser(mptr, NULL,
+                               *list_this_part, NULL, NULL,
+                               NULL, 0);
                        if (do_proto) cprintf("000\n");
-                       CtdlFreeMessage(TheMessage);
                        return(om_ok);
                }
                else if (mode == MT_RFC822) {   /* unparsed RFC822 dump */
@@ -1034,14 +1207,12 @@ int CtdlOutputMsg(long msg_num,         /* message number (local) to fetch */
                                else cprintf("%c", ch);
                        }
                        if (do_proto) cprintf("000\n");
-                       CtdlFreeMessage(TheMessage);
                        return(om_ok);
                }
        }
 
        if (headers_only) {
                if (do_proto) cprintf("000\n");
-               CtdlFreeMessage(TheMessage);
                return(om_ok);
        }
 
@@ -1095,12 +1266,13 @@ int CtdlOutputMsg(long msg_num,         /* message number (local) to fetch */
        if (TheMessage->cm_format_type == FMT_RFC822) {
                CtdlAllocUserData(SYM_MA_INFO, sizeof(struct ma_info));
                memset(ma, 0, sizeof(struct ma_info));
-               mime_parser(mptr, NULL, *fixed_output);
+               mime_parser(mptr, NULL,
+                       *fixed_output, *fixed_output_pre, *fixed_output_post,
+                       NULL, 0);
        }
 
        /* now we're done */
        if (do_proto) cprintf("000\n");
-       CtdlFreeMessage(TheMessage);
        return(om_ok);
 }
 
@@ -1195,7 +1367,7 @@ void cmd_opna(char *cmdbuf)
 {
        long msgid;
 
-       CtdlAllocUserData(SYM_DESIRED_SECTION, 64);
+       CtdlAllocUserData(SYM_DESIRED_SECTION, SIZ);
 
        msgid = extract_long(cmdbuf, 0);
        extract(desired_section, cmdbuf, 1);
@@ -1339,7 +1511,7 @@ long send_message(struct CtdlMessage *msg,        /* pointer to buffer */
 {
        long newmsgid;
        long retval;
-       char msgidbuf[256];
+       char msgidbuf[SIZ];
         struct ser_ret smr;
 
        /* Get a new message number */
@@ -1360,7 +1532,6 @@ long send_message(struct CtdlMessage *msg,        /* pointer to buffer */
         }
 
        /* Write our little bundle of joy into the message base */
-       begin_critical_section(S_MSGMAIN);
        if (cdb_store(CDB_MSGMAIN, &newmsgid, sizeof(long),
                      smr.ser, smr.len) < 0) {
                lprintf(2, "Can't store message\n");
@@ -1368,7 +1539,6 @@ long send_message(struct CtdlMessage *msg,        /* pointer to buffer */
        } else {
                retval = newmsgid;
        }
-       end_critical_section(S_MSGMAIN);
 
        /* If the caller specified that a copy should be saved to a particular
         * file handle, do that now too.
@@ -1409,7 +1579,7 @@ void serialize_message(struct ser_ret *ret,               /* return values */
                ret->len = ret->len +
                        strlen(msg->cm_fields[(int)forder[i]]) + 2;
 
-       lprintf(9, "calling malloc(%d)\n", ret->len);
+       lprintf(9, "serialize_message() calling malloc(%d)\n", ret->len);
        ret->ser = mallok(ret->len);
        if (ret->ser == NULL) {
                ret->len = 0;
@@ -1437,7 +1607,7 @@ void serialize_message(struct ser_ret *ret,               /* return values */
 /*
  * Back end for the ReplicationChecks() function
  */
-void check_repl(long msgnum) {
+void check_repl(long msgnum, void *userdata) {
        struct CtdlMessage *msg;
        time_t timestamp = (-1L);
 
@@ -1487,7 +1657,8 @@ int ReplicationChecks(struct CtdlMessage *msg) {
        memset(template, 0, sizeof(struct CtdlMessage));
        template->cm_fields['E'] = strdoop(msg->cm_fields['E']);
 
-       CtdlForEachMessage(MSGS_ALL, 0L, (-127), NULL, template, check_repl);
+       CtdlForEachMessage(MSGS_ALL, 0L, (-127), NULL, template,
+               check_repl, NULL);
 
        /* If a newer message exists with the same Extended ID, abort
         * this save.
@@ -1516,8 +1687,8 @@ long CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
        char hold_rm[ROOMNAMELEN];
        char actual_rm[ROOMNAMELEN];
        char force_room[ROOMNAMELEN];
-       char content_type[256];                 /* We have to learn this */
-       char recipient[256];
+       char content_type[SIZ];                 /* We have to learn this */
+       char recipient[SIZ];
        long newmsgid;
        char *mptr = NULL;
        struct usersupp userbuf;
@@ -1538,7 +1709,7 @@ long CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
         */
        if (msg->cm_fields['T'] == NULL) {
                lprintf(9, "Generating timestamp\n");
-               sprintf(aaa, "%ld", time(NULL));
+               sprintf(aaa, "%ld", (long)time(NULL));
                msg->cm_fields['T'] = strdoop(aaa);
        }
 
@@ -1600,7 +1771,7 @@ long CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
                /* advance past header fields */
                mptr = msg->cm_fields['M'];
                a = strlen(mptr);
-               while (--a) {
+               while ((--a) > 0) {
                        if (!strncasecmp(mptr, "Content-type: ", 14)) {
                                safestrncpy(content_type, mptr,
                                            sizeof(content_type));
@@ -1672,7 +1843,7 @@ long CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
        newmsgid = send_message(msg, network_fp);
        if (network_fp != NULL) {
                fclose(network_fp);
-               system("exec nohup ./netproc -i >/dev/null 2>&1 &");
+               /* FIXME start a network run here */
        }
 
        if (newmsgid <= 0L) return(-1);
@@ -1748,7 +1919,7 @@ long CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
                        "Content-type: %s\n\nmsgid|%ld\nsubmitted|%ld\n"
                        "bounceto|%s@%s\n"
                        "remote|%s|0||\n",
-                       SPOOLMIME, newmsgid, time(NULL),
+                       SPOOLMIME, newmsgid, (long)time(NULL),
                        msg->cm_fields['A'], msg->cm_fields['N'],
                        recipient );
 
@@ -1802,10 +1973,11 @@ char *CtdlReadMessageBody(char *terminator,     /* token signalling EOT */
                        char *exist             /* if non-null, append to it;
                                                   exist is ALWAYS freed  */
                        ) {
-       char buf[256];
+       char buf[SIZ];
+       int linelen;
        size_t message_len = 0;
        size_t buffer_len = 0;
-       char *ptr, *append;
+       char *ptr;
        char *m;
 
        if (exist == NULL) {
@@ -1824,11 +1996,16 @@ char *CtdlReadMessageBody(char *terminator,     /* token signalling EOT */
                message_len = 0;
        }
        /* read in the lines of message text one by one */
-       append = NULL;
        while ( (client_gets(buf)>0) && strcmp(buf, terminator) ) {
 
+               /* strip trailing newline type stuff */
+               if (buf[strlen(buf)-1]==10) buf[strlen(buf)-1]=0;
+               if (buf[strlen(buf)-1]==13) buf[strlen(buf)-1]=0;
+
+               linelen = strlen(buf);
+
                /* augment the buffer if we have to */
-               if ((message_len + strlen(buf) + 2) > buffer_len) {
+               if ((message_len + linelen + 2) > buffer_len) {
                        lprintf(9, "realloking\n");
                        ptr = reallok(m, (buffer_len * 2) );
                        if (ptr == NULL) {      /* flush if can't allocate */
@@ -1838,20 +2015,23 @@ char *CtdlReadMessageBody(char *terminator,     /* token signalling EOT */
                        } else {
                                buffer_len = (buffer_len * 2);
                                m = ptr;
-                               append = NULL;
                                lprintf(9, "buffer_len is %d\n", buffer_len);
                        }
                }
 
-               if (append == NULL) append = m;
-               while (strlen(append) > 0) ++append;
-               strcpy(append, buf);
-               strcat(append, "\n");
-               message_len = message_len + strlen(buf) + 1;
+               /* Add the new line to the buffer.  We avoid using strcat()
+                * because that would involve traversing the entire message
+                * after each line, and this function needs to run fast.
+                */
+               strcpy(&m[message_len], buf);
+               m[message_len + linelen] = '\n';
+               m[message_len + linelen + 1] = 0;
+               message_len = message_len + linelen + 1;
 
                /* if we've hit the max msg length, flush the rest */
                if (message_len >= maxlen) {
-                       while ( (client_gets(buf)>0) && strcmp(buf, terminator)) ;;
+                       while ( (client_gets(buf)>0)
+                               && strcmp(buf, terminator)) ;;
                        return(m);
                }
        }
@@ -1865,7 +2045,7 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
  * Build a binary message to be saved on disk.
  */
 
-struct CtdlMessage *make_message(
+static struct CtdlMessage *make_message(
        struct usersupp *author,        /* author's usersupp structure */
        char *recipient,                /* NULL if it's not mail */
        char *room,                     /* room where it's going */
@@ -1877,7 +2057,7 @@ struct CtdlMessage *make_message(
 
        int a;
        char dest_node[32];
-       char buf[256];
+       char buf[SIZ];
        struct CtdlMessage *msg;
 
        msg = mallok(sizeof(struct CtdlMessage));
@@ -1911,7 +2091,7 @@ struct CtdlMessage *make_message(
        sprintf(buf, "cit%ld", author->usernum);                /* Path */
        msg->cm_fields['P'] = strdoop(buf);
 
-       sprintf(buf, "%ld", time(NULL));                        /* timestamp */
+       sprintf(buf, "%ld", (long)time(NULL));                  /* timestamp */
        msg->cm_fields['T'] = strdoop(buf);
 
        if (fake_name[0])                                       /* author */
@@ -1941,6 +2121,41 @@ struct CtdlMessage *make_message(
 }
 
 
+/*
+ * Check to see whether we have permission to post a message in the current
+ * room.  Returns a *CITADEL ERROR CODE* and puts a message in errmsgbuf, or
+ * returns 0 on success.
+ */
+int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf) {
+
+       if (!(CC->logged_in)) {
+               sprintf(errmsgbuf, "Not logged in.");
+               return (ERROR + NOT_LOGGED_IN);
+       }
+
+       if ((CC->usersupp.axlevel < 2)
+           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
+               sprintf(errmsgbuf, "Need to be validated to enter "
+                               "(except in %s> to sysop)", MAILROOM);
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       if ((CC->usersupp.axlevel < 4)
+          && (CC->quickroom.QRflags & QR_NETWORK)) {
+               sprintf(errmsgbuf, "Need net privileges to enter here.");
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       if ((CC->usersupp.axlevel < 6)
+          && (CC->quickroom.QRflags & QR_READONLY)) {
+               sprintf(errmsgbuf, "Sorry, this is a read-only room.");
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       strcpy(errmsgbuf, "Ok");
+       return(0);
+}
+
 
 
 
@@ -1950,16 +2165,17 @@ struct CtdlMessage *make_message(
 void cmd_ent0(char *entargs)
 {
        int post = 0;
-       char recipient[256];
+       char recipient[SIZ];
        int anon_flag = 0;
        int format_type = 0;
-       char newusername[256];
+       char newusername[SIZ];
        struct CtdlMessage *msg;
        int a, b;
        int e = 0;
        int mtsflag = 0;
        struct usersupp tempUS;
-       char buf[256];
+       char buf[SIZ];
+       int err = 0;
 
        post = extract_int(entargs, 0);
        extract(recipient, entargs, 1);
@@ -1968,28 +2184,13 @@ void cmd_ent0(char *entargs)
 
        /* first check to make sure the request is valid. */
 
-       if (!(CC->logged_in)) {
-               cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
-               return;
-       }
-       if ((CC->usersupp.axlevel < 2) && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
-               cprintf("%d Need to be validated to enter ",
-                       ERROR + HIGHER_ACCESS_REQUIRED);
-               cprintf("(except in %s> to sysop)\n", MAILROOM);
+       err = CtdlDoIHavePermissionToPostInThisRoom(buf);
+       if (err) {
+               cprintf("%d %s\n", err, buf);
                return;
        }
-       if ((CC->usersupp.axlevel < 4) && (CC->quickroom.QRflags & QR_NETWORK)) {
-               cprintf("%d Need net privileges to enter here.\n",
-                       ERROR + HIGHER_ACCESS_REQUIRED);
-               return;
-       }
-       if ((CC->usersupp.axlevel < 6) && (CC->quickroom.QRflags & QR_READONLY)) {
-               cprintf("%d Sorry, this is a read-only room.\n",
-                       ERROR + HIGHER_ACCESS_REQUIRED);
-               return;
-       }
-       mtsflag = 0;
 
+       /* Check some other permission type things. */
 
        if (post == 2) {
                if (CC->usersupp.axlevel < 6) {
@@ -2031,27 +2232,26 @@ void cmd_ent0(char *entargs)
                }
                if (!strcasecmp(buf, "sysop")) {
                        mtsflag = 1;
-                       goto SKFALL;
                }
-               if (e != MES_LOCAL)
-                       goto SKFALL;    /* don't search local file  */
-               if (!strcasecmp(buf, CC->usersupp.fullname)) {
-                       cprintf("%d Can't send mail to yourself!\n",
-                               ERROR + NO_SUCH_USER);
-                       return;
-               }
-               /* Check to make sure the user exists; also get the correct
-                * upper/lower casing of the name. 
-                */
-               a = getuser(&tempUS, buf);
-               if (a != 0) {
-                       cprintf("%d No such user.\n", ERROR + NO_SUCH_USER);
-                       return;
+               else if (e == MES_LOCAL) {      /* don't search local file */
+                       if (!strcasecmp(buf, CC->usersupp.fullname)) {
+                               cprintf("%d Can't send mail to yourself!\n",
+                                       ERROR + NO_SUCH_USER);
+                               return;
+                       }
+                       /* Check to make sure the user exists; also get the correct
+                        * upper/lower casing of the name.
+                        */
+                       a = getuser(&tempUS, buf);
+                       if (a != 0) {
+                               cprintf("%d No such user.\n", ERROR + NO_SUCH_USER);
+                               return;
+                       }
+                       strcpy(buf, tempUS.fullname);
                }
-               strcpy(buf, tempUS.fullname);
        }
 
-SKFALL:        b = MES_NORMAL;
+       b = MES_NORMAL;
        if (CC->quickroom.QRflags & QR_ANONONLY)
                b = MES_ANON;
        if (CC->quickroom.QRflags & QR_ANONOPT) {
@@ -2098,7 +2298,7 @@ SKFALL:   b = MES_NORMAL;
  */
 void cmd_ent3(char *entargs)
 {
-       char recp[256];
+       char recp[SIZ];
        int a;
        int e = 0;
        int valid_msg = 1;
@@ -2165,21 +2365,21 @@ void cmd_ent3(char *entargs)
 
        cprintf("%d %ld\n", SEND_BINARY, msglen);
 
-       client_read(&ch, 1);                            /* 0xFF magic number */
+       client_read((char*)&ch, 1);                             /* 0xFF magic number */
        msg->cm_magic = CTDLMESSAGE_MAGIC;
-       client_read(&ch, 1);                            /* anon type */
+       client_read((char*)&ch, 1);                             /* anon type */
        msg->cm_anon_type = ch;
-       client_read(&ch, 1);                            /* format type */
+       client_read((char*)&ch, 1);                             /* format type */
        msg->cm_format_type = ch;
        msglen = msglen - 3;
 
        while (msglen > 0) {
-               client_read(&which_field, 1);
+               client_read((char*)&which_field, 1);
                if (!isalpha(which_field)) valid_msg = 0;
                --msglen;
                tempbuf[0] = 0;
                do {
-                       client_read(&ch, 1);
+                       client_read((char*)&ch, 1);
                        --msglen;
                        a = strlen(tempbuf);
                        tempbuf[a+1] = 0;
@@ -2273,6 +2473,23 @@ int CtdlDeleteMessages(char *room_name,          /* which room */
 
 
 
+/*
+ * Check whether the current user has permission to delete messages from
+ * the current room (returns 1 for yes, 0 for no)
+ */
+int CtdlDoIHavePermissionToDeleteMessagesFromThisRoom(void) {
+       getuser(&CC->usersupp, CC->curr_user);
+       if ((CC->usersupp.axlevel < 6)
+           && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
+           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
+           && (!(CC->internal_pgm))) {
+               return(0);
+       }
+       return(1);
+}
+
+
+
 /*
  * Delete message from current room
  */
@@ -2281,11 +2498,7 @@ void cmd_dele(char *delstr)
        long delnum;
        int num_deleted;
 
-       getuser(&CC->usersupp, CC->curr_user);
-       if ((CC->usersupp.axlevel < 6)
-           && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
-           && (!(CC->internal_pgm))) {
+       if (CtdlDoIHavePermissionToDeleteMessagesFromThisRoom() == 0) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -2303,13 +2516,28 @@ void cmd_dele(char *delstr)
 }
 
 
+/*
+ * Back end API function for moves and deletes
+ */
+int CtdlCopyMsgToRoom(long msgnum, char *dest) {
+       int err;
+
+       err = CtdlSaveMsgPointerInRoom(dest, msgnum,
+               (SM_VERIFY_GOODNESS | SM_DO_REPL_CHECK) );
+       if (err != 0) return(err);
+
+       return(0);
+}
+
+
+
 /*
  * move or copy a message to another room
  */
 void cmd_move(char *args)
 {
        long num;
-       char targ[256];
+       char targ[SIZ];
        struct quickroom qtemp;
        int err;
        int is_copy = 0;
@@ -2332,8 +2560,7 @@ void cmd_move(char *args)
                return;
        }
 
-       err = CtdlSaveMsgPointerInRoom(targ, num,
-               (SM_VERIFY_GOODNESS | SM_DO_REPL_CHECK) );
+       err = CtdlCopyMsgToRoom(num, targ);
        if (err != 0) {
                cprintf("%d Cannot store message in %s: error %d\n",
                        err, targ, err);
@@ -2451,7 +2678,7 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
 
        FILE *fp, *tempfp;
        char filename[PATH_MAX];
-       char cmdbuf[256];
+       char cmdbuf[SIZ];
        char ch;
        struct quickroom qrbuf;
        char roomname[ROOMNAMELEN];
@@ -2520,8 +2747,8 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
        /* Create the requested room if we have to. */
        if (getroom(&qrbuf, roomname) != 0) {
                create_room(roomname, 
-                       ( (is_mailbox != NULL) ? 4 : 3 ),
-                       "", 0);
+                       ( (is_mailbox != NULL) ? 5 : 3 ),
+                       "", 0, 1);
        }
        /* If the caller specified this object as unique, delete all
         * other objects of this type that are currently in the room.
@@ -2540,7 +2767,7 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
 
 
 
-void CtdlGetSysConfigBackend(long msgnum) {
+void CtdlGetSysConfigBackend(long msgnum, void *userdata) {
        config_msgnum = msgnum;
 }
 
@@ -2550,7 +2777,7 @@ char *CtdlGetSysConfig(char *sysconfname) {
        long msgnum;
        char *conf;
        struct CtdlMessage *msg;
-       char buf[256];
+       char buf[SIZ];
        
        strcpy(hold_rm, CC->quickroom.QRname);
        if (getroom(&CC->quickroom, SYSCONFIGROOM) != 0) {
@@ -2563,7 +2790,7 @@ char *CtdlGetSysConfig(char *sysconfname) {
        begin_critical_section(S_CONFIG);
        config_msgnum = (-1L);
        CtdlForEachMessage(MSGS_LAST, 1, (-127), sysconfname, NULL,
-               CtdlGetSysConfigBackend);
+               CtdlGetSysConfigBackend, NULL);
        msgnum = config_msgnum;
        end_critical_section(S_CONFIG);
 
@@ -2583,10 +2810,8 @@ char *CtdlGetSysConfig(char *sysconfname) {
 
        getroom(&CC->quickroom, hold_rm);
 
-       lprintf(9, "eggstracting...\n");
        if (conf != NULL) do {
                extract_token(buf, conf, 0, '\n');
-               lprintf(9, "eggstracted <%s>\n", buf);
                strcpy(conf, &conf[strlen(buf)+1]);
        } while ( (strlen(conf)>0) && (strlen(buf)>0) );