#include <unistd.h>
#include <stdio.h>
#include <sys/stat.h>
+#include <ctype.h>
#include <string.h>
#if TIME_WITH_SYS_TIME
#include <errno.h>
#include "citadel.h"
#include "server.h"
-#include "dynloader.h"
+#include "serv_extensions.h"
#include "database.h"
#include "config.h"
#include "room_ops.h"
/*
* Generic routine for determining user access to rooms
*/
-int CtdlRoomAccess(struct quickroom *roombuf, struct usersupp *userbuf)
+int CtdlRoomAccess(struct ctdlroom *roombuf, struct ctdluser *userbuf)
{
int retval = 0;
struct visit vbuf;
CtdlGetRelationship(&vbuf, userbuf, roombuf);
/* Force the properties of the Aide room */
- if (!strcasecmp(roombuf->QRname, AIDEROOM)) {
+ if (!strcasecmp(roombuf->QRname, config.c_aideroom)) {
if (userbuf->axlevel >= 6) {
retval = UA_KNOWN | UA_GOTOALLOWED;
} else {
if ( ( ((roombuf->QRflags & QR_PRIVATE) == 0)
&& ((roombuf->QRflags & QR_MAILBOX) == 0) )
|| ( (roombuf->QRflags & QR_MAILBOX)
- && (atol(roombuf->QRname) == CC->usersupp.usernum))) {
+ && (atol(roombuf->QRname) == CC->user.usernum))) {
retval = retval | UA_ZAPPED;
}
}
/*
* Self-checking stuff for a room record read into memory
*/
-void room_sanity_check(struct quickroom *qrbuf)
+void room_sanity_check(struct ctdlroom *qrbuf)
{
/* Mailbox rooms are always on the lowest floor */
if (qrbuf->QRflags & QR_MAILBOX) {
}
/* Listing order of 0 is illegal except for base rooms */
if (qrbuf->QRorder == 0)
- if (!is_noneditable(qrbuf))
+ if (!(qrbuf->QRflags & QR_MAILBOX) &&
+ strncasecmp(qrbuf->QRname, config.c_baseroom, ROOMNAMELEN)
+ &&
+ strncasecmp(qrbuf->QRname, config.c_aideroom, ROOMNAMELEN))
qrbuf->QRorder = 64;
}
/*
* getroom() - retrieve room data from disk
*/
-int getroom(struct quickroom *qrbuf, char *room_name)
+int getroom(struct ctdlroom *qrbuf, char *room_name)
{
struct cdbdata *cdbqr;
char lowercase_name[ROOMNAMELEN];
}
lowercase_name[a] = 0;
- memset(qrbuf, 0, sizeof(struct quickroom));
+ memset(qrbuf, 0, sizeof(struct ctdlroom));
/* First, try the public namespace */
- cdbqr = cdb_fetch(CDB_QUICKROOM,
+ cdbqr = cdb_fetch(CDB_ROOMS,
lowercase_name, strlen(lowercase_name));
/* If that didn't work, try the user's personal namespace */
if (cdbqr == NULL) {
snprintf(personal_lowercase_name,
sizeof personal_lowercase_name, "%010ld.%s",
- CC->usersupp.usernum, lowercase_name);
- cdbqr = cdb_fetch(CDB_QUICKROOM,
+ CC->user.usernum, lowercase_name);
+ cdbqr = cdb_fetch(CDB_ROOMS,
personal_lowercase_name,
strlen(personal_lowercase_name));
}
if (cdbqr != NULL) {
memcpy(qrbuf, cdbqr->ptr,
- ((cdbqr->len > sizeof(struct quickroom)) ?
- sizeof(struct quickroom) : cdbqr->len));
+ ((cdbqr->len > sizeof(struct ctdlroom)) ?
+ sizeof(struct ctdlroom) : cdbqr->len));
cdb_free(cdbqr);
room_sanity_check(qrbuf);
/*
* lgetroom() - same as getroom() but locks the record (if supported)
*/
-int lgetroom(struct quickroom *qrbuf, char *room_name)
+int lgetroom(struct ctdlroom *qrbuf, char *room_name)
{
register int retval;
retval = getroom(qrbuf, room_name);
- if (retval == 0) begin_critical_section(S_QUICKROOM);
+ if (retval == 0) begin_critical_section(S_ROOMS);
return(retval);
}
* b_putroom() - back end to putroom() and b_deleteroom()
* (if the supplied buffer is NULL, delete the room record)
*/
-void b_putroom(struct quickroom *qrbuf, char *room_name)
+void b_putroom(struct ctdlroom *qrbuf, char *room_name)
{
char lowercase_name[ROOMNAMELEN];
int a;
}
if (qrbuf == NULL) {
- cdb_delete(CDB_QUICKROOM,
+ cdb_delete(CDB_ROOMS,
lowercase_name, strlen(lowercase_name));
} else {
time(&qrbuf->QRmtime);
- cdb_store(CDB_QUICKROOM,
+ cdb_store(CDB_ROOMS,
lowercase_name, strlen(lowercase_name),
- qrbuf, sizeof(struct quickroom));
+ qrbuf, sizeof(struct ctdlroom));
}
}
/*
* putroom() - store room data to disk
*/
-void putroom(struct quickroom *qrbuf) {
+void putroom(struct ctdlroom *qrbuf) {
b_putroom(qrbuf, qrbuf->QRname);
}
/*
* lputroom() - same as putroom() but unlocks the record (if supported)
*/
-void lputroom(struct quickroom *qrbuf)
+void lputroom(struct ctdlroom *qrbuf)
{
putroom(qrbuf);
- end_critical_section(S_QUICKROOM);
+ end_critical_section(S_ROOMS);
}
cdb_free(cdbfl);
} else {
if (floor_num == 0) {
- strcpy(flbuf->f_name, "Main Floor");
+ safestrncpy(flbuf->f_name, "Main Floor",
+ sizeof flbuf->f_name);
flbuf->f_flags = F_INUSE;
flbuf->f_ref_count = 3;
}
/*
* Traverse the room file...
*/
-void ForEachRoom(void (*CallBack) (struct quickroom *EachRoom, void *out_data),
+void ForEachRoom(void (*CallBack) (struct ctdlroom *EachRoom, void *out_data),
void *in_data)
{
- struct quickroom qrbuf;
+ struct ctdlroom qrbuf;
struct cdbdata *cdbqr;
- cdb_rewind(CDB_QUICKROOM);
+ cdb_rewind(CDB_ROOMS);
- while (cdbqr = cdb_next_item(CDB_QUICKROOM), cdbqr != NULL) {
- memset(&qrbuf, 0, sizeof(struct quickroom));
+ while (cdbqr = cdb_next_item(CDB_ROOMS), cdbqr != NULL) {
+ memset(&qrbuf, 0, sizeof(struct ctdlroom));
memcpy(&qrbuf, cdbqr->ptr,
- ((cdbqr->len > sizeof(struct quickroom)) ?
- sizeof(struct quickroom) : cdbqr->len));
+ ((cdbqr->len > sizeof(struct ctdlroom)) ?
+ sizeof(struct ctdlroom) : cdbqr->len));
cdb_free(cdbqr);
room_sanity_check(&qrbuf);
if (qrbuf.QRflags & QR_INUSE)
/*
* delete_msglist() - delete room message pointers
*/
-void delete_msglist(struct quickroom *whichroom)
+void delete_msglist(struct ctdlroom *whichroom)
{
struct cdbdata *cdbml;
/*
* Determine whether a given room is non-editable.
*/
-int is_noneditable(struct quickroom *qrbuf)
+int is_noneditable(struct ctdlroom *qrbuf)
{
- /* Lobby> and Aide> are non-editable */
- if (!strcasecmp(qrbuf->QRname, BASEROOM))
- return (1);
- else if (!strcasecmp(qrbuf->QRname, AIDEROOM))
- return (1);
-
- /* Mail> rooms are also non-editable */
- else if ( (qrbuf->QRflags & QR_MAILBOX)
+ /* Mail> rooms are non-editable */
+ if ( (qrbuf->QRflags & QR_MAILBOX)
&& (!strcasecmp(&qrbuf->QRname[11], MAILROOM)) )
return (1);
/* Everything else is editable */
- else
- return (0);
+ return (0);
}
/*
* Back-back-end for all room listing commands
*/
-void list_roomname(struct quickroom *qrbuf)
+void list_roomname(struct ctdlroom *qrbuf, int ra)
{
char truncated_roomname[ROOMNAMELEN];
/* For my own mailbox rooms, chop off the owner prefix */
if ( (qrbuf->QRflags & QR_MAILBOX)
- && (atol(qrbuf->QRname) == CC->usersupp.usernum) ) {
+ && (atol(qrbuf->QRname) == CC->user.usernum) ) {
strcpy(truncated_roomname, qrbuf->QRname);
strcpy(truncated_roomname, &truncated_roomname[11]);
cprintf("%s", truncated_roomname);
}
/* ...and now the other parameters */
- cprintf("|%u|%d|%d\n",
+ cprintf("|%u|%d|%d|%d|%d|\n",
qrbuf->QRflags,
(int) qrbuf->QRfloor,
- (int) qrbuf->QRorder);
+ (int) qrbuf->QRorder,
+ (int) qrbuf->QRflags2,
+ ra
+ );
}
/*
* cmd_lrms() - List all accessible rooms, known or forgotten
*/
-void cmd_lrms_backend(struct quickroom *qrbuf, void *data)
+void cmd_lrms_backend(struct ctdlroom *qrbuf, void *data)
{
int FloorBeingSearched = (-1);
+ int ra;
+
FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
- if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
- & (UA_KNOWN | UA_ZAPPED)))
+ if ((( ra & (UA_KNOWN | UA_ZAPPED)))
&& ((qrbuf->QRfloor == (FloorBeingSearched))
|| ((FloorBeingSearched) < 0)))
- list_roomname(qrbuf);
+ list_roomname(qrbuf, ra);
}
void cmd_lrms(char *argbuf)
if (CtdlAccessCheck(ac_logged_in)) return;
- if (getuser(&CC->usersupp, CC->curr_user)) {
+ if (getuser(&CC->user, CC->curr_user)) {
cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
return;
}
/*
* cmd_lkra() - List all known rooms
*/
-void cmd_lkra_backend(struct quickroom *qrbuf, void *data)
+void cmd_lkra_backend(struct ctdlroom *qrbuf, void *data)
{
int FloorBeingSearched = (-1);
+ int ra;
+
FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
- if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
- & (UA_KNOWN)))
+ if ((( ra & (UA_KNOWN)))
&& ((qrbuf->QRfloor == (FloorBeingSearched))
|| ((FloorBeingSearched) < 0)))
- list_roomname(qrbuf);
+ list_roomname(qrbuf, ra);
}
void cmd_lkra(char *argbuf)
if (CtdlAccessCheck(ac_logged_in)) return;
- if (getuser(&CC->usersupp, CC->curr_user)) {
+ if (getuser(&CC->user, CC->curr_user)) {
cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
return;
}
+void cmd_lprm_backend(struct ctdlroom *qrbuf, void *data)
+{
+ int FloorBeingSearched = (-1);
+ int ra;
+
+ FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
+
+ if ( ((qrbuf->QRflags & QR_PRIVATE) == 0)
+ && ((qrbuf->QRflags & QR_MAILBOX) == 0)
+ && ((qrbuf->QRfloor == (FloorBeingSearched))
+ || ((FloorBeingSearched) < 0)))
+ list_roomname(qrbuf, ra);
+}
+
+void cmd_lprm(char *argbuf)
+{
+ int FloorBeingSearched = (-1);
+ if (strlen(argbuf) > 0)
+ FloorBeingSearched = extract_int(argbuf, 0);
+
+ cprintf("%d Publiic rooms:\n", LISTING_FOLLOWS);
+
+ ForEachRoom(cmd_lprm_backend, &FloorBeingSearched);
+ cprintf("000\n");
+}
+
+
+
/*
* cmd_lkrn() - List all known rooms with new messages
*/
-void cmd_lkrn_backend(struct quickroom *qrbuf, void *data)
+void cmd_lkrn_backend(struct ctdlroom *qrbuf, void *data)
{
- int ra;
int FloorBeingSearched = (-1);
+ int ra;
+
FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
- ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
if ((ra & UA_KNOWN)
&& (ra & UA_HASNEWMSGS)
&& ((qrbuf->QRfloor == (FloorBeingSearched))
|| ((FloorBeingSearched) < 0)))
- list_roomname(qrbuf);
+ list_roomname(qrbuf, ra);
}
void cmd_lkrn(char *argbuf)
if (CtdlAccessCheck(ac_logged_in)) return;
- if (getuser(&CC->usersupp, CC->curr_user)) {
+ if (getuser(&CC->user, CC->curr_user)) {
cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
return;
}
/*
* cmd_lkro() - List all known rooms
*/
-void cmd_lkro_backend(struct quickroom *qrbuf, void *data)
+void cmd_lkro_backend(struct ctdlroom *qrbuf, void *data)
{
- int ra;
int FloorBeingSearched = (-1);
+ int ra;
+
FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
- ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
if ((ra & UA_KNOWN)
&& ((ra & UA_HASNEWMSGS) == 0)
&& ((qrbuf->QRfloor == (FloorBeingSearched))
|| ((FloorBeingSearched) < 0)))
- list_roomname(qrbuf);
+ list_roomname(qrbuf, ra);
}
void cmd_lkro(char *argbuf)
if (CtdlAccessCheck(ac_logged_in)) return;
- if (getuser(&CC->usersupp, CC->curr_user)) {
+ if (getuser(&CC->user, CC->curr_user)) {
cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
return;
}
/*
* cmd_lzrm() - List all forgotten rooms
*/
-void cmd_lzrm_backend(struct quickroom *qrbuf, void *data)
+void cmd_lzrm_backend(struct ctdlroom *qrbuf, void *data)
{
- int ra;
int FloorBeingSearched = (-1);
+
+ int ra;
FloorBeingSearched = *(int *)data;
+ ra = CtdlRoomAccess(qrbuf, &CC->user);
- ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
if ((ra & UA_GOTOALLOWED)
&& (ra & UA_ZAPPED)
&& ((qrbuf->QRfloor == (FloorBeingSearched))
|| ((FloorBeingSearched) < 0)))
- list_roomname(qrbuf);
+ list_roomname(qrbuf, ra);
}
void cmd_lzrm(char *argbuf)
if (CtdlAccessCheck(ac_logged_in)) return;
- if (getuser(&CC->usersupp, CC->curr_user)) {
+ if (getuser(&CC->user, CC->curr_user)) {
cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
return;
}
}
-
-void usergoto(char *where, int display_result, int *retmsgs, int *retnew)
+/*
+ * Make the specified room the current room for this session. No validation
+ * or access control is done here -- the caller should make sure that the
+ * specified room exists and is ok to access.
+ */
+void usergoto(char *where, int display_result, int transiently,
+ int *retmsgs, int *retnew)
{
int a;
int new_messages = 0;
struct cdbdata *cdbfr;
long *msglist = NULL;
int num_msgs = 0;
+ unsigned int original_v_flags;
+
+ /* If the supplied room name is NULL, the caller wants us to know that
+ * it has already copied the room record into CC->room, so
+ * we can skip the extra database fetch.
+ */
+ if (where != NULL) {
+ safestrncpy(CC->room.QRname, where, sizeof CC->room.QRname);
+ getroom(&CC->room, where);
+ }
- strcpy(CC->quickroom.QRname, where);
- getroom(&CC->quickroom, where);
+ /* Take care of all the formalities. */
- lgetuser(&CC->usersupp, CC->curr_user);
- CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+ begin_critical_section(S_USERS);
+ CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
+ original_v_flags = vbuf.v_flags;
- /* Know the room ... but not if it's the page log room */
- if (strcasecmp(where, config.c_logpages)) {
+ /* Know the room ... but not if it's the page log room, or if the
+ * caller specified that we're only entering this room transiently.
+ */
+ if ((strcasecmp(CC->room.QRname, config.c_logpages))
+ && (transiently == 0) ) {
vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
vbuf.v_flags = vbuf.v_flags | V_ACCESS;
}
- CtdlSetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
- lputuser(&CC->usersupp);
+
+ /* Only rewrite the database record if we changed something */
+ if (vbuf.v_flags != original_v_flags) {
+ CtdlSetRelationship(&vbuf, &CC->user, &CC->room);
+ }
+ end_critical_section(S_USERS);
- /* check for new mail */
+ /* Check for new mail */
newmailcount = NewMailCount();
/* set info to 1 if the user needs to read the room's info file */
- if (CC->quickroom.QRinfo > vbuf.v_lastseen)
+ if (CC->room.QRinfo > vbuf.v_lastseen) {
info = 1;
+ }
get_mm();
- cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+ cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
if (cdbfr != NULL) {
msglist = mallok(cdbfr->len);
memcpy(msglist, cdbfr->ptr, cdbfr->len);
if (msglist != NULL) phree(msglist);
- if (CC->quickroom.QRflags & QR_MAILBOX)
+ if (CC->room.QRflags & QR_MAILBOX)
rmailflag = 1;
else
rmailflag = 0;
- if ((CC->quickroom.QRroomaide == CC->usersupp.usernum)
- || (CC->usersupp.axlevel >= 6))
+ if ((CC->room.QRroomaide == CC->user.usernum)
+ || (CC->user.axlevel >= 6))
raideflag = 1;
else
raideflag = 0;
- strcpy(truncated_roomname, CC->quickroom.QRname);
- if ( (CC->quickroom.QRflags & QR_MAILBOX)
- && (atol(CC->quickroom.QRname) == CC->usersupp.usernum) ) {
+ strcpy(truncated_roomname, CC->room.QRname);
+ if ( (CC->room.QRflags & QR_MAILBOX)
+ && (atol(CC->room.QRname) == CC->user.usernum) ) {
strcpy(truncated_roomname, &truncated_roomname[11]);
}
if (retmsgs != NULL) *retmsgs = total_messages;
if (retnew != NULL) *retnew = new_messages;
- lprintf(9, "<%s> %d new of %d total messages\n",
- CC->quickroom.QRname, new_messages, total_messages);
+ lprintf(CTDL_DEBUG, "<%s> %d new of %d total messages\n",
+ CC->room.QRname,
+ new_messages, total_messages
+ );
- if (display_result)
- cprintf("%d%c%s|%d|%d|%d|%d|%ld|%ld|%d|%d|%d|%d\n",
+ if (display_result) {
+ cprintf("%d%c%s|%d|%d|%d|%d|%ld|%ld|%d|%d|%d|%d|%d|%d|\n",
CIT_OK, CtdlCheckExpress(),
truncated_roomname,
- new_messages, total_messages,
- info, CC->quickroom.QRflags,
- CC->quickroom.QRhighest,
- vbuf.v_lastseen,
- rmailflag, raideflag, newmailcount,
- CC->quickroom.QRfloor);
-
+ (int)new_messages,
+ (int)total_messages,
+ (int)info,
+ (int)CC->room.QRflags,
+ (long)CC->room.QRhighest,
+ (long)vbuf.v_lastseen,
+ (int)rmailflag,
+ (int)raideflag,
+ (int)newmailcount,
+ (int)CC->room.QRfloor,
+ (int)vbuf.v_view,
+ (int)CC->room.QRdefaultview
+ );
+ }
}
*/
void cmd_goto(char *gargs)
{
- struct quickroom QRscratch;
+ struct ctdlroom QRscratch;
int c;
int ok = 0;
int ra;
char augmented_roomname[SIZ];
char towhere[SIZ];
char password[SIZ];
+ int transiently = 0;
if (CtdlAccessCheck(ac_logged_in)) return;
extract(towhere, gargs, 0);
extract(password, gargs, 1);
+ transiently = extract_int(gargs, 2);
- getuser(&CC->usersupp, CC->curr_user);
+ getuser(&CC->user, CC->curr_user);
if (!strcasecmp(towhere, "_BASEROOM_"))
- strcpy(towhere, BASEROOM);
+ strcpy(towhere, config.c_baseroom);
if (!strcasecmp(towhere, "_MAIL_"))
strcpy(towhere, MAILROOM);
/* Then try a mailbox name match */
if (c != 0) {
MailboxName(augmented_roomname, sizeof augmented_roomname,
- &CC->usersupp, towhere);
+ &CC->user, towhere);
c = getroom(&QRscratch, augmented_roomname);
if (c == 0)
strcpy(towhere, augmented_roomname);
/* And if the room was found... */
if (c == 0) {
- /* let internal programs go directly to any room */
+ /* Let internal programs go directly to any room. */
if (CC->internal_pgm) {
- usergoto(towhere, 1, NULL, NULL);
+ memcpy(&CC->room, &QRscratch,
+ sizeof(struct ctdlroom));
+ usergoto(NULL, 1, transiently, NULL, NULL);
return;
}
/* See if there is an existing user/room relationship */
- ra = CtdlRoomAccess(&QRscratch, &CC->usersupp);
+ ra = CtdlRoomAccess(&QRscratch, &CC->user);
/* normal clients have to pass through security */
if (ra & UA_GOTOALLOWED) {
if (ok == 1) {
if ((QRscratch.QRflags & QR_MAILBOX) &&
((ra & UA_GOTOALLOWED))) {
- usergoto(towhere, 1, NULL, NULL);
+ memcpy(&CC->room, &QRscratch,
+ sizeof(struct ctdlroom));
+ usergoto(NULL, 1, transiently, NULL, NULL);
return;
} else if ((QRscratch.QRflags & QR_PASSWORDED) &&
((ra & UA_KNOWN) == 0) &&
(strcasecmp(QRscratch.QRpasswd, password)) &&
- (CC->usersupp.axlevel < 6)
+ (CC->user.axlevel < 6)
) {
cprintf("%d wrong or missing passwd\n",
ERROR + PASSWORD_REQUIRED);
((QRscratch.QRflags & QR_PASSWORDED) == 0) &&
((QRscratch.QRflags & QR_GUESSNAME) == 0) &&
((ra & UA_KNOWN) == 0) &&
- (CC->usersupp.axlevel < 6)
+ (CC->user.axlevel < 6)
) {
- lprintf(9, "Failed to acquire private room\n");
- goto NOPE;
+ lprintf(CTDL_DEBUG, "Failed to acquire private room\n");
} else {
- usergoto(towhere, 1, NULL, NULL);
+ memcpy(&CC->room, &QRscratch,
+ sizeof(struct ctdlroom));
+ usergoto(NULL, 1, transiently, NULL, NULL);
return;
}
}
}
-NOPE: cprintf("%d room '%s' not found\n", ERROR + ROOM_NOT_FOUND, towhere);
+ cprintf("%d room '%s' not found\n", ERROR + ROOM_NOT_FOUND, towhere);
}
void cmd_whok(void)
{
- struct usersupp temp;
+ struct ctdluser temp;
struct cdbdata *cdbus;
- getuser(&CC->usersupp, CC->curr_user);
+ getuser(&CC->user, CC->curr_user);
/*
* This command is only allowed by aides, room aides,
* and room namespace owners
*/
if (is_room_aide()
- || (atol(CC->quickroom.QRname) == CC->usersupp.usernum) ) {
+ || (atol(CC->room.QRname) == CC->user.usernum) ) {
/* access granted */
}
else {
}
cprintf("%d Who knows room:\n", LISTING_FOLLOWS);
- cdb_rewind(CDB_USERSUPP);
- while (cdbus = cdb_next_item(CDB_USERSUPP), cdbus != NULL) {
+ cdb_rewind(CDB_USERS);
+ while (cdbus = cdb_next_item(CDB_USERS), cdbus != NULL) {
memset(&temp, 0, sizeof temp);
memcpy(&temp, cdbus->ptr, sizeof temp);
cdb_free(cdbus);
- if ((CC->quickroom.QRflags & QR_INUSE)
- && (CtdlRoomAccess(&CC->quickroom, &temp) & UA_KNOWN)
+ if ((CC->room.QRflags & QR_INUSE)
+ && (CtdlRoomAccess(&CC->room, &temp) & UA_KNOWN)
)
cprintf("%s\n", temp.fullname);
}
if (CtdlAccessCheck(ac_logged_in)) return;
- getroom(&CC->quickroom, CC->quickroom.QRname);
- getuser(&CC->usersupp, CC->curr_user);
+ getroom(&CC->room, CC->room.QRname);
+ getuser(&CC->user, CC->curr_user);
- if ((CC->quickroom.QRflags & QR_DIRECTORY) == 0) {
+ if ((CC->room.QRflags & QR_DIRECTORY) == 0) {
cprintf("%d not here.\n", ERROR + NOT_HERE);
return;
}
- if (((CC->quickroom.QRflags & QR_VISDIR) == 0)
- && (CC->usersupp.axlevel < 6)
- && (CC->usersupp.usernum != CC->quickroom.QRroomaide)) {
+ if (((CC->room.QRflags & QR_VISDIR) == 0)
+ && (CC->user.axlevel < 6)
+ && (CC->user.usernum != CC->room.QRroomaide)) {
cprintf("%d not here.\n", ERROR + HIGHER_ACCESS_REQUIRED);
return;
}
cprintf("%d %s|%s/files/%s\n",
- LISTING_FOLLOWS, config.c_fqdn, BBSDIR, CC->quickroom.QRdirname);
+ LISTING_FOLLOWS, config.c_fqdn, BBSDIR, CC->room.QRdirname);
snprintf(buf, sizeof buf, "ls %s/files/%s >%s 2> /dev/null",
- BBSDIR, CC->quickroom.QRdirname, CC->temp);
+ BBSDIR, CC->room.QRdirname, CC->temp);
system(buf);
- snprintf(buf, sizeof buf, "%s/files/%s/filedir", BBSDIR, CC->quickroom.QRdirname);
+ snprintf(buf, sizeof buf, "%s/files/%s/filedir", BBSDIR, CC->room.QRdirname);
fd = fopen(buf, "r");
if (fd == NULL)
fd = fopen("/dev/null", "r");
flnm[strlen(flnm) - 1] = 0;
if (strcasecmp(flnm, "filedir")) {
snprintf(buf, sizeof buf, "%s/files/%s/%s",
- BBSDIR, CC->quickroom.QRdirname, flnm);
+ BBSDIR, CC->room.QRdirname, flnm);
stat(buf, &statbuf);
strcpy(comment, "");
fseek(fd, 0L, 0);
{
if (CtdlAccessCheck(ac_room_aide)) return;
- getroom(&CC->quickroom, CC->quickroom.QRname);
- cprintf("%d%c%s|%s|%s|%d|%d|%d\n",
+ getroom(&CC->room, CC->room.QRname);
+ cprintf("%d%c%s|%s|%s|%d|%d|%d|%d|%d|\n",
CIT_OK,
CtdlCheckExpress(),
- ((CC->quickroom.QRflags & QR_MAILBOX) ?
- &CC->quickroom.QRname[11] : CC->quickroom.QRname),
+ ((CC->room.QRflags & QR_MAILBOX) ?
+ &CC->room.QRname[11] : CC->room.QRname),
- ((CC->quickroom.QRflags & QR_PASSWORDED) ?
- CC->quickroom.QRpasswd : ""),
+ ((CC->room.QRflags & QR_PASSWORDED) ?
+ CC->room.QRpasswd : ""),
- ((CC->quickroom.QRflags & QR_DIRECTORY) ?
- CC->quickroom.QRdirname : ""),
+ ((CC->room.QRflags & QR_DIRECTORY) ?
+ CC->room.QRdirname : ""),
- CC->quickroom.QRflags,
- (int) CC->quickroom.QRfloor,
- (int) CC->quickroom.QRorder);
+ CC->room.QRflags,
+ (int) CC->room.QRfloor,
+ (int) CC->room.QRorder,
+
+ CC->room.QRdefaultview,
+ CC->room.QRflags2
+ );
}
* You can also specify which floor to move the room to, or specify -1 to
* keep the room on the same floor it was on.
*
- * This function is unaware of namespaces. If you are renaming a mailbox
- * room, you must supply the namespace prefix in both the old and new names!
+ * If you are renaming a mailbox room, you must supply the namespace prefix
+ * in *at least* the old name!
*/
int CtdlRenameRoom(char *old_name, char *new_name, int new_floor) {
int old_floor = 0;
- struct quickroom qrbuf;
- struct quickroom qrtmp;
+ struct ctdlroom qrbuf;
+ struct ctdlroom qrtmp;
int ret = 0;
struct floor *fl;
struct floor flbuf;
+ long owner = 0L;
+ char actual_old_name[SIZ];
-
- lprintf(9, "CtdlRenameRoom(%s, %s, %d)\n",
+ lprintf(CTDL_DEBUG, "CtdlRenameRoom(%s, %s, %d)\n",
old_name, new_name, new_floor);
if (new_floor >= 0) {
}
}
- begin_critical_section(S_QUICKROOM);
+ begin_critical_section(S_ROOMS);
if ( (getroom(&qrtmp, new_name) == 0)
&& (strcasecmp(new_name, old_name)) ) {
ret = crr_room_not_found;
}
- else if ( (CC->usersupp.axlevel < 6)
- && (CC->usersupp.usernum != qrbuf.QRroomaide)
- && ( (((qrbuf.QRflags & QR_MAILBOX) == 0) || (atol(qrbuf.QRname) != CC->usersupp.usernum))) ) {
+ else if ( (CC->user.axlevel < 6)
+ && (CC->user.usernum != qrbuf.QRroomaide)
+ && ( (((qrbuf.QRflags & QR_MAILBOX) == 0) || (atol(qrbuf.QRname) != CC->user.usernum))) ) {
ret = crr_access_denied;
}
}
else {
- safestrncpy(qrbuf.QRname, new_name, sizeof(qrbuf.QRname));
+ /* Rename it */
+ strcpy(actual_old_name, qrbuf.QRname);
+ if (qrbuf.QRflags & QR_MAILBOX) {
+ owner = atol(qrbuf.QRname);
+ }
+ if ( (owner > 0L) && (atol(new_name) == 0L) ) {
+ snprintf(qrbuf.QRname, sizeof(qrbuf.QRname),
+ "%010ld.%s", owner, new_name);
+ }
+ else {
+ safestrncpy(qrbuf.QRname, new_name,
+ sizeof(qrbuf.QRname));
+ }
+
+ /* Reject change of floor for baseroom/aideroom */
+ if (!strncasecmp(old_name, config.c_baseroom, ROOMNAMELEN) ||
+ !strncasecmp(old_name, config.c_aideroom, ROOMNAMELEN)) {
+ new_floor = 0;
+ }
+
+ /* Take care of floor stuff */
old_floor = qrbuf.QRfloor;
if (new_floor < 0) {
new_floor = old_floor;
qrbuf.QRfloor = new_floor;
putroom(&qrbuf);
+ begin_critical_section(S_CONFIG);
+
+ /* If baseroom/aideroom name changes, update config */
+ if (!strncasecmp(old_name, config.c_baseroom, ROOMNAMELEN)) {
+ safestrncpy(config.c_baseroom, new_name, ROOMNAMELEN);
+ put_config();
+ }
+ if (!strncasecmp(old_name, config.c_aideroom, ROOMNAMELEN)) {
+ safestrncpy(config.c_aideroom, new_name, ROOMNAMELEN);
+ put_config();
+ }
+
+ end_critical_section(S_CONFIG);
+
/* If the room name changed, then there are now two room
* records, so we have to delete the old one.
*/
if (strcasecmp(new_name, old_name)) {
- b_deleteroom(old_name);
+ b_deleteroom(actual_old_name);
}
ret = crr_ok;
}
- end_critical_section(S_QUICKROOM);
+ end_critical_section(S_ROOMS);
/* Adjust the floor reference counts if necessary */
if (new_floor != old_floor) {
lgetfloor(&flbuf, old_floor);
--flbuf.f_ref_count;
lputfloor(&flbuf, old_floor);
- lgetfloor(&flbuf, CC->quickroom.QRfloor);
+ lprintf(CTDL_DEBUG, "Reference count for floor %d is now %d\n", old_floor, flbuf.f_ref_count);
+ lgetfloor(&flbuf, new_floor);
++flbuf.f_ref_count;
- lputfloor(&flbuf, CC->quickroom.QRfloor);
+ lputfloor(&flbuf, new_floor);
+ lprintf(CTDL_DEBUG, "Reference count for floor %d is now %d\n", new_floor, flbuf.f_ref_count);
}
/* ...and everybody say "YATTA!" */
if (num_parms(args) >= 6) {
new_floor = extract_int(args, 5);
- }
- else {
+ } else {
new_floor = (-1); /* don't change the floor */
}
/* When is a new name more than just a new name? When the old name
* has a namespace prefix.
*/
- if (CC->quickroom.QRflags & QR_MAILBOX) {
- sprintf(new_name, "%010ld.", atol(CC->quickroom.QRname) );
- }
- else {
+ if (CC->room.QRflags & QR_MAILBOX) {
+ sprintf(new_name, "%010ld.", atol(CC->room.QRname) );
+ } else {
strcpy(new_name, "");
}
extract(&new_name[strlen(new_name)], args, 0);
- r = CtdlRenameRoom(CC->quickroom.QRname, new_name, new_floor);
+ r = CtdlRenameRoom(CC->room.QRname, new_name, new_floor);
if (r == crr_room_not_found) {
- cprintf("%d Internal error - room not found?\n", ERROR);
- }
- else if (r == crr_already_exists) {
+ cprintf("%d Internal error - room not found?\n", ERROR + INTERNAL_ERROR);
+ } else if (r == crr_already_exists) {
cprintf("%d '%s' already exists.\n",
ERROR + ALREADY_EXISTS, new_name);
- }
- else if (r == crr_noneditable) {
- cprintf("%d Cannot edit this room.\n", ERROR);
- }
- else if (r == crr_invalid_floor) {
+ } else if (r == crr_noneditable) {
+ cprintf("%d Cannot edit this room.\n", ERROR + NOT_HERE);
+ } else if (r == crr_invalid_floor) {
cprintf("%d Target floor does not exist.\n",
ERROR + INVALID_FLOOR_OPERATION);
- }
- else if (r == crr_access_denied) {
+ } else if (r == crr_access_denied) {
cprintf("%d You do not have permission to edit '%s'\n",
ERROR + HIGHER_ACCESS_REQUIRED,
- CC->quickroom.QRname);
- }
- else if (r != crr_ok) {
+ CC->room.QRname);
+ } else if (r != crr_ok) {
cprintf("%d Error: CtdlRenameRoom() returned %d\n",
- ERROR, r);
+ ERROR + INTERNAL_ERROR, r);
}
if (r != crr_ok) {
return;
}
- getroom(&CC->quickroom, new_name);
+ getroom(&CC->room, new_name);
/* Now we have to do a bunch of other stuff */
if (new_order > 127)
new_order = 127;
}
- lgetroom(&CC->quickroom, CC->quickroom.QRname);
- extract(buf, args, 1);
- buf[10] = 0;
- safestrncpy(CC->quickroom.QRpasswd, buf, sizeof CC->quickroom.QRpasswd);
+ lgetroom(&CC->room, CC->room.QRname);
+
+ /* Directory room */
extract(buf, args, 2);
buf[15] = 0;
- safestrncpy(CC->quickroom.QRdirname, buf,
- sizeof CC->quickroom.QRdirname);
- CC->quickroom.QRflags = (extract_int(args, 3) | QR_INUSE);
- if (num_parms(args) >= 7)
- CC->quickroom.QRorder = (char) new_order;
+ safestrncpy(CC->room.QRdirname, buf,
+ sizeof CC->room.QRdirname);
+
+ /* Default view */
+ if (num_parms(args) >= 8) {
+ CC->room.QRdefaultview = extract_int(args, 7);
+ }
+
+ /* Second set of flags */
+ if (num_parms(args) >= 9) {
+ CC->room.QRflags2 = extract_int(args, 8);
+ }
+ /* Misc. flags */
+ CC->room.QRflags = (extract_int(args, 3) | QR_INUSE);
/* Clean up a client boo-boo: if the client set the room to
* guess-name or passworded, ensure that the private flag is
* also set.
*/
- if ((CC->quickroom.QRflags & QR_GUESSNAME)
- || (CC->quickroom.QRflags & QR_PASSWORDED))
- CC->quickroom.QRflags |= QR_PRIVATE;
-
- /* Kick everyone out if the client requested it (by changing the
- * room's generation number)
- */
- if (extract_int(args, 4)) {
- time(&CC->quickroom.QRgen);
+ if ((CC->room.QRflags & QR_GUESSNAME)
+ || (CC->room.QRflags & QR_PASSWORDED))
+ CC->room.QRflags |= QR_PRIVATE;
+
+ /* Some changes can't apply to BASEROOM */
+ if (!strncasecmp(CC->room.QRname, config.c_baseroom,
+ ROOMNAMELEN)) {
+ CC->room.QRorder = 0;
+ CC->room.QRpasswd[0] = '\0';
+ CC->room.QRflags &= ~(QR_PRIVATE & QR_PASSWORDED &
+ QR_GUESSNAME & QR_PREFONLY & QR_MAILBOX);
+ CC->room.QRflags |= QR_PERMANENT;
+ } else {
+ /* March order (doesn't apply to AIDEROOM) */
+ if (num_parms(args) >= 7)
+ CC->room.QRorder = (char) new_order;
+ /* Room password */
+ extract(buf, args, 1);
+ buf[10] = 0;
+ safestrncpy(CC->room.QRpasswd, buf,
+ sizeof CC->room.QRpasswd);
+ /* Kick everyone out if the client requested it
+ * (by changing the room's generation number)
+ */
+ if (extract_int(args, 4)) {
+ time(&CC->room.QRgen);
+ }
+ }
+ /* Some changes can't apply to AIDEROOM */
+ if (!strncasecmp(CC->room.QRname, config.c_baseroom,
+ ROOMNAMELEN)) {
+ CC->room.QRorder = 0;
+ CC->room.QRflags &= ~QR_MAILBOX;
+ CC->room.QRflags |= QR_PERMANENT;
}
/* Write the room record back to disk */
- lputroom(&CC->quickroom);
+ lputroom(&CC->room);
- /* create a room directory if necessary */
- if (CC->quickroom.QRflags & QR_DIRECTORY) {
- snprintf(buf, sizeof buf,
- "mkdir ./files/%s </dev/null >/dev/null 2>/dev/null",
- CC->quickroom.QRdirname);
- system(buf);
+ /* Create a room directory if necessary */
+ if (CC->room.QRflags & QR_DIRECTORY) {
+ snprintf(buf, sizeof buf, "./files/%s",
+ CC->room.QRdirname);
+ mkdir(buf, 0755);
}
- snprintf(buf, sizeof buf, "%s> edited by %s\n", CC->quickroom.QRname, CC->curr_user);
+ snprintf(buf, sizeof buf, "%s> edited by %s\n", CC->room.QRname, CC->curr_user);
aide_message(buf);
cprintf("%d Ok\n", CIT_OK);
}
*/
void cmd_geta(void)
{
- struct usersupp usbuf;
+ struct ctdluser usbuf;
if (CtdlAccessCheck(ac_logged_in)) return;
- if (is_noneditable(&CC->quickroom)) {
- cprintf("%d Can't edit this room.\n", ERROR + NOT_HERE);
- return;
- }
- if (getuserbynumber(&usbuf, CC->quickroom.QRroomaide) == 0) {
+ if (getuserbynumber(&usbuf, CC->room.QRroomaide) == 0) {
cprintf("%d %s\n", CIT_OK, usbuf.fullname);
} else {
cprintf("%d \n", CIT_OK);
*/
void cmd_seta(char *new_ra)
{
- struct usersupp usbuf;
+ struct ctdluser usbuf;
long newu;
char buf[SIZ];
int post_notice;
newu = usbuf.usernum;
}
- lgetroom(&CC->quickroom, CC->quickroom.QRname);
+ lgetroom(&CC->room, CC->room.QRname);
post_notice = 0;
- if (CC->quickroom.QRroomaide != newu) {
+ if (CC->room.QRroomaide != newu) {
post_notice = 1;
}
- CC->quickroom.QRroomaide = newu;
- lputroom(&CC->quickroom);
+ CC->room.QRroomaide = newu;
+ lputroom(&CC->room);
/*
* We have to post the change notice _after_ writing changes to
* the room table, otherwise it would deadlock!
*/
if (post_notice == 1) {
- snprintf(buf, sizeof buf, "%s is now room aide for %s>\n",
- usbuf.fullname, CC->quickroom.QRname);
+ if (strlen(usbuf.fullname) > 0)
+ snprintf(buf, sizeof buf,
+ "%s is now room aide for %s>\n",
+ usbuf.fullname, CC->room.QRname);
+ else
+ snprintf(buf, sizeof buf,
+ "There is now no room aide for %s>\n",
+ CC->room.QRname);
aide_message(buf);
}
cprintf("%d Ok\n", CIT_OK);
* Generate an associated file name for a room
*/
void assoc_file_name(char *buf, size_t n,
- struct quickroom *qrbuf, const char *prefix)
+ struct ctdlroom *qrbuf, const char *prefix)
{
snprintf(buf, n, "./%s/%ld", prefix, qrbuf->QRnumber);
}
char buf[SIZ];
FILE *info_fp;
- assoc_file_name(filename, sizeof filename, &CC->quickroom, "info");
+ assoc_file_name(filename, sizeof filename, &CC->room, "info");
info_fp = fopen(filename, "r");
if (info_fp == NULL) {
- cprintf("%d No info file.\n", ERROR);
+ cprintf("%d No info file.\n", ERROR + FILE_NOT_FOUND);
return;
}
cprintf("%d Info:\n", LISTING_FOLLOWS);
/*
* Back end processing to delete a room and everything associated with it
*/
-void delete_room(struct quickroom *qrbuf)
+void delete_room(struct ctdlroom *qrbuf)
{
struct floor flbuf;
char filename[100];
- lprintf(9, "Deleting room <%s>\n", qrbuf->QRname);
+ lprintf(CTDL_NOTICE, "Deleting room <%s>\n", qrbuf->QRname);
/* Delete the info file */
assoc_file_name(filename, sizeof filename, qrbuf, "info");
unlink(filename);
/* Delete the messages in the room
- * (Careful: this opens an S_QUICKROOM critical section!)
+ * (Careful: this opens an S_ROOMS critical section!)
*/
CtdlDeleteMessages(qrbuf->QRname, 0L, "");
/*
* Check access control for deleting a room
*/
-int CtdlDoIHavePermissionToDeleteThisRoom(struct quickroom *qr) {
+int CtdlDoIHavePermissionToDeleteThisRoom(struct ctdlroom *qr) {
if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
return(0);
if (strlen(qr->QRname) < 12) return(0); /* bad name */
- if (atol(qr->QRname) != CC->usersupp.usernum) {
+ if (atol(qr->QRname) != CC->user.usernum) {
return(0); /* not my room */
}
/*
* For normal rooms, just check for aide or room aide status.
*/
- else {
- return(is_room_aide());
- }
-
- /* Should never get to this point, but to keep the compiler quiet... */
- return(0);
+ return(is_room_aide());
}
/*
*/
void cmd_kill(char *argbuf)
{
- char aaa[100];
char deleted_room_name[ROOMNAMELEN];
+ char msg[SIZ];
int kill_ok;
kill_ok = extract_int(argbuf, 0);
- if (CtdlDoIHavePermissionToDeleteThisRoom(&CC->quickroom) == 0) {
+ if (CtdlDoIHavePermissionToDeleteThisRoom(&CC->room) == 0) {
cprintf("%d Can't delete this room.\n", ERROR + NOT_HERE);
return;
}
if (kill_ok) {
- strcpy(deleted_room_name, CC->quickroom.QRname);
- delete_room(&CC->quickroom); /* Do the dirty work */
- usergoto(BASEROOM, 0, NULL, NULL); /* Return to the Lobby */
+ if (CC->room.QRflags & QR_MAILBOX) {
+ strcpy(deleted_room_name, &CC->room.QRname[11]);
+ }
+ else {
+ strcpy(deleted_room_name, CC->room.QRname);
+ }
+
+ /* Do the dirty work */
+ delete_room(&CC->room);
+
+ /* Return to the Lobby */
+ usergoto(config.c_baseroom, 0, 0, NULL, NULL);
/* tell the world what we did */
- snprintf(aaa, sizeof aaa, "%s> killed by %s\n",
+ snprintf(msg, sizeof msg, "%s> killed by %s\n",
deleted_room_name, CC->curr_user);
- aide_message(aaa);
+ aide_message(msg);
cprintf("%d '%s' deleted.\n", CIT_OK, deleted_room_name);
} else {
cprintf("%d ok to delete.\n", CIT_OK);
int new_room_type,
char *new_room_pass,
int new_room_floor,
- int really_create)
+ int really_create,
+ int avoid_access)
{
- struct quickroom qrbuf;
+ struct ctdlroom qrbuf;
struct floor flbuf;
struct visit vbuf;
- lprintf(9, "create_room(%s)\n", new_room_name);
+ lprintf(CTDL_DEBUG, "create_room(%s)\n", new_room_name);
if (getroom(&qrbuf, new_room_name) == 0) {
- lprintf(9, "%s already exists.\n", new_room_name);
+ lprintf(CTDL_DEBUG, "%s already exists.\n", new_room_name);
return (0); /* already exists */
}
- memset(&qrbuf, 0, sizeof(struct quickroom));
+ memset(&qrbuf, 0, sizeof(struct ctdlroom));
safestrncpy(qrbuf.QRpasswd, new_room_pass, sizeof qrbuf.QRpasswd);
qrbuf.QRflags = QR_INUSE;
if (new_room_type > 0)
* name accordingly (prepend the user number)
*/
if (new_room_type == 4) {
- MailboxName(qrbuf.QRname, sizeof qrbuf.QRname, &CC->usersupp, new_room_name);
+ MailboxName(qrbuf.QRname, sizeof qrbuf.QRname, &CC->user, new_room_name);
}
else {
safestrncpy(qrbuf.QRname, new_room_name, sizeof qrbuf.QRname);
* set the room aide to undefined.
*/
if ((qrbuf.QRflags & QR_PRIVATE) && (CREATAIDE == 1)) {
- qrbuf.QRroomaide = CC->usersupp.usernum;
+ qrbuf.QRroomaide = CC->user.usernum;
} else {
qrbuf.QRroomaide = (-1L);
}
flbuf.f_ref_count = flbuf.f_ref_count + 1;
lputfloor(&flbuf, (int) qrbuf.QRfloor);
- /* be sure not to kick the creator out of the room! */
- lgetuser(&CC->usersupp, CC->curr_user);
- CtdlGetRelationship(&vbuf, &CC->usersupp, &qrbuf);
- vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
- vbuf.v_flags = vbuf.v_flags | V_ACCESS;
- CtdlSetRelationship(&vbuf, &CC->usersupp, &qrbuf);
- lputuser(&CC->usersupp);
+ /* Grant the creator access to the room unless the avoid_access
+ * parameter was specified.
+ */
+ if (avoid_access == 0) {
+ lgetuser(&CC->user, CC->curr_user);
+ CtdlGetRelationship(&vbuf, &CC->user, &qrbuf);
+ vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
+ vbuf.v_flags = vbuf.v_flags | V_ACCESS;
+ CtdlSetRelationship(&vbuf, &CC->user, &qrbuf);
+ lputuser(&CC->user);
+ }
/* resume our happy day */
return (qrbuf.QRflags);
char aaa[SIZ];
unsigned newflags;
struct floor *fl;
+ int avoid_access = 0;
cre8_ok = extract_int(args, 0);
extract(new_room_name, args, 1);
new_room_name[ROOMNAMELEN - 1] = 0;
new_room_type = extract_int(args, 2);
extract(new_room_pass, args, 3);
+ avoid_access = extract_int(args, 5);
new_room_pass[9] = 0;
new_room_floor = 0;
if ((strlen(new_room_name) == 0) && (cre8_ok == 1)) {
- cprintf("%d Invalid room name.\n", ERROR);
+ cprintf("%d Invalid room name.\n", ERROR + ILLEGAL_VALUE);
return;
}
if (CtdlAccessCheck(ac_logged_in)) return;
- if (CC->usersupp.axlevel < config.c_createax) {
+ if (CC->user.axlevel < config.c_createax) {
cprintf("%d You need higher access to create rooms.\n",
ERROR + HIGHER_ACCESS_REQUIRED);
return;
return;
}
- if ((new_room_type < 0) || (new_room_type > 4)) {
- cprintf("%d Invalid room type.\n", ERROR);
+ if ((new_room_type < 0) || (new_room_type > 5)) {
+ cprintf("%d Invalid room type.\n", ERROR + ILLEGAL_VALUE);
return;
}
+ if (new_room_type == 5) {
+ if ((config.c_aide_mailboxes == 0)
+ || (CC->user.axlevel < 6)) {
+ cprintf("%d Higher access required\n",
+ ERROR + HIGHER_ACCESS_REQUIRED);
+ return;
+ }
+ }
+
/* Check to make sure the requested room name doesn't already exist */
newflags = create_room(new_room_name,
- new_room_type, new_room_pass, new_room_floor, 0);
+ new_room_type, new_room_pass, new_room_floor,
+ 0, avoid_access);
if (newflags == 0) {
cprintf("%d '%s' already exists.\n",
ERROR + ALREADY_EXISTS, new_room_name);
/* If we reach this point, the room needs to be created. */
newflags = create_room(new_room_name,
- new_room_type, new_room_pass, new_room_floor, 1);
+ new_room_type, new_room_pass, new_room_floor, 1, 0);
/* post a message in Aide> describing the new room */
safestrncpy(aaa, new_room_name, sizeof aaa);
strcat(aaa, "> created by ");
- strcat(aaa, CC->usersupp.fullname);
+ strcat(aaa, CC->user.fullname);
if (newflags & QR_MAILBOX)
strcat(aaa, " [personal]");
else if (newflags & QR_PRIVATE)
cprintf("%d Ok.\n", CIT_OK);
return;
}
- assoc_file_name(infofilename, sizeof infofilename, &CC->quickroom, "info");
- lprintf(9, "opening\n");
+ assoc_file_name(infofilename, sizeof infofilename, &CC->room, "info");
+ lprintf(CTDL_DEBUG, "opening\n");
fp = fopen(infofilename, "w");
- lprintf(9, "checking\n");
+ lprintf(CTDL_DEBUG, "checking\n");
if (fp == NULL) {
cprintf("%d Cannot open %s: %s\n",
ERROR + INTERNAL_ERROR, infofilename, strerror(errno));
fclose(fp);
/* now update the room index so people will see our new info */
- lgetroom(&CC->quickroom, CC->quickroom.QRname); /* lock so no one steps on us */
- CC->quickroom.QRinfo = CC->quickroom.QRhighest + 1L;
- lputroom(&CC->quickroom);
+ lgetroom(&CC->room, CC->room.QRname); /* lock so no one steps on us */
+ CC->room.QRinfo = CC->room.QRhighest + 1L;
+ lputroom(&CC->room);
}
extract(new_floor_name, argbuf, 0);
cflr_ok = extract_int(argbuf, 1);
-
if (CtdlAccessCheck(ac_aide)) return;
+ if (strlen(new_floor_name) == 0) {
+ cprintf("%d Blank floor name not allowed.\n",
+ ERROR + ILLEGAL_VALUE);
+ return;
+ }
+
for (a = 0; a < MAXFLOORS; ++a) {
getfloor(&flbuf, a);
np = num_parms(argbuf);
if (np < 1) {
- cprintf("%d Usage error.\n", ERROR);
+ cprintf("%d Usage error.\n", ERROR + ILLEGAL_VALUE);
return;
}