]> code.citadel.org Git - citadel.git/blobdiff - citadel/room_ops.c
* Got bounce messages working (mostly ... testers, please beat this up!)
[citadel.git] / citadel / room_ops.c
index 8daee0677f03f5430ee0a031cfaa03255e351cd6..61315accccfb821dcfc31da5afd06d87904c997c 100644 (file)
@@ -5,9 +5,6 @@
 #include <stdio.h>
 #include <sys/stat.h>
 #include <string.h>
-#ifdef HAVE_PTHREAD_H
-#include <pthread.h>
-#endif
 #include <time.h>
 #include <limits.h>
 #include <errno.h>
@@ -294,7 +291,8 @@ void lputfloor(struct floor *flbuf, int floor_num)
 /* 
  *  Traverse the room file...
  */
-void ForEachRoom(void (*CallBack) (struct quickroom * EachRoom))
+void ForEachRoom(void (*CallBack) (struct quickroom *EachRoom, void *out_data),
+               void *in_data)
 {
        struct quickroom qrbuf;
        struct cdbdata *cdbqr;
@@ -309,14 +307,14 @@ void ForEachRoom(void (*CallBack) (struct quickroom * EachRoom))
                cdb_free(cdbqr);
                room_sanity_check(&qrbuf);
                if (qrbuf.QRflags & QR_INUSE)
-                       (*CallBack) (&qrbuf);
+                       (*CallBack)(&qrbuf, in_data);
        }
 }
 
 
 /*
  * delete_msglist()  -  delete room message pointers
- * FIX - this really should check first to make sure there's actually a
+ * FIXME - this really should check first to make sure there's actually a
  *       msglist to delete.  As things stand now, calling this function on
  *       a room which has never been posted in will result in a message
  *       like "gdbm: illegal data" (no big deal, but could use fixing).
@@ -328,58 +326,6 @@ void delete_msglist(struct quickroom *whichroom)
 }
 
 
-/* 
- * Add a message number to a room's message list.  
- *
- * This function returns the highest message number present in the room after
- * the add operation is performed - which is not necessarily the message
- * being added.
- */
-long AddMessageToRoom(struct quickroom *whichroom, long newmsgid)
-{
-       struct cdbdata *cdbfr;
-       int num_msgs;
-       long *msglist;
-       long highest_msg = 0L;
-
-       lprintf(9, "AddMessageToRoom(%s, %ld)\n", whichroom->QRname, newmsgid);
-       cdbfr = cdb_fetch(CDB_MSGLISTS, &whichroom->QRnumber, sizeof(long));
-       if (cdbfr == NULL) {
-               msglist = NULL;
-               num_msgs = 0;
-       } else {
-               msglist = mallok(cdbfr->len);
-               if (msglist == NULL)
-                       lprintf(3, "ERROR malloc msglist!\n");
-               num_msgs = cdbfr->len / sizeof(long);
-               memcpy(msglist, cdbfr->ptr, cdbfr->len);
-               cdb_free(cdbfr);
-       }
-
-       /* Now add the new message */
-       ++num_msgs;
-       msglist = reallok(msglist,
-                         (num_msgs * sizeof(long)));
-
-       if (msglist == NULL) {
-               lprintf(3, "ERROR: can't realloc message list!\n");
-       }
-       msglist[num_msgs - 1] = newmsgid;
-
-       /* Sort the message list, so all the msgid's are in order */
-       num_msgs = sort_msglist(msglist, num_msgs);
-
-       /* Determine the highest message number */
-       highest_msg = msglist[num_msgs - 1];
-
-       /* Write it back to disk. */
-       cdb_store(CDB_MSGLISTS, &whichroom->QRnumber, sizeof(long),
-                 msglist, num_msgs * sizeof(long));
-
-       /* And finally, free up the memory we used. */
-       phree(msglist);
-       return (highest_msg);
-}
 
 
 /*
@@ -472,20 +418,23 @@ void list_roomname(struct quickroom *qrbuf)
 /* 
  * cmd_lrms()   -  List all accessible rooms, known or forgotten
  */
-void cmd_lrms_backend(struct quickroom *qrbuf)
+void cmd_lrms_backend(struct quickroom *qrbuf, void *data)
 {
+       int FloorBeingSearched = (-1);
+       FloorBeingSearched = *(int *)data;
+
        if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
              & (UA_KNOWN | UA_ZAPPED)))
-           && ((qrbuf->QRfloor == (CC->FloorBeingSearched))
-               || ((CC->FloorBeingSearched) < 0)))
+           && ((qrbuf->QRfloor == (FloorBeingSearched))
+               || ((FloorBeingSearched) < 0)))
                list_roomname(qrbuf);
 }
 
 void cmd_lrms(char *argbuf)
 {
-       CC->FloorBeingSearched = (-1);
+       int FloorBeingSearched = (-1);
        if (strlen(argbuf) > 0)
-               CC->FloorBeingSearched = extract_int(argbuf, 0);
+               FloorBeingSearched = extract_int(argbuf, 0);
 
        if (!(CC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -497,7 +446,7 @@ void cmd_lrms(char *argbuf)
        }
        cprintf("%d Accessible rooms:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lrms_backend);
+       ForEachRoom(cmd_lrms_backend, &FloorBeingSearched);
        cprintf("000\n");
 }
 
@@ -506,20 +455,23 @@ void cmd_lrms(char *argbuf)
 /* 
  * cmd_lkra()   -  List all known rooms
  */
-void cmd_lkra_backend(struct quickroom *qrbuf)
+void cmd_lkra_backend(struct quickroom *qrbuf, void *data)
 {
+       int FloorBeingSearched = (-1);
+       FloorBeingSearched = *(int *)data;
+
        if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
              & (UA_KNOWN)))
-           && ((qrbuf->QRfloor == (CC->FloorBeingSearched))
-               || ((CC->FloorBeingSearched) < 0)))
+           && ((qrbuf->QRfloor == (FloorBeingSearched))
+               || ((FloorBeingSearched) < 0)))
                list_roomname(qrbuf);
 }
 
 void cmd_lkra(char *argbuf)
 {
-       CC->FloorBeingSearched = (-1);
+       int FloorBeingSearched = (-1);
        if (strlen(argbuf) > 0)
-               CC->FloorBeingSearched = extract_int(argbuf, 0);
+               FloorBeingSearched = extract_int(argbuf, 0);
 
        if (!(CC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -531,7 +483,7 @@ void cmd_lkra(char *argbuf)
        }
        cprintf("%d Known rooms:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lkra_backend);
+       ForEachRoom(cmd_lkra_backend, &FloorBeingSearched);
        cprintf("000\n");
 }
 
@@ -540,23 +492,25 @@ void cmd_lkra(char *argbuf)
 /* 
  * cmd_lkrn()   -  List all known rooms with new messages
  */
-void cmd_lkrn_backend(struct quickroom *qrbuf)
+void cmd_lkrn_backend(struct quickroom *qrbuf, void *data)
 {
        int ra;
+       int FloorBeingSearched = (-1);
+       FloorBeingSearched = *(int *)data;
 
        ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
        if ((ra & UA_KNOWN)
            && (ra & UA_HASNEWMSGS)
-           && ((qrbuf->QRfloor == (CC->FloorBeingSearched))
-               || ((CC->FloorBeingSearched) < 0)))
+           && ((qrbuf->QRfloor == (FloorBeingSearched))
+               || ((FloorBeingSearched) < 0)))
                list_roomname(qrbuf);
 }
 
 void cmd_lkrn(char *argbuf)
 {
-       CC->FloorBeingSearched = (-1);
+       int FloorBeingSearched = (-1);
        if (strlen(argbuf) > 0)
-               CC->FloorBeingSearched = extract_int(argbuf, 0);
+               FloorBeingSearched = extract_int(argbuf, 0);
 
        if (!(CC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -568,7 +522,7 @@ void cmd_lkrn(char *argbuf)
        }
        cprintf("%d Rooms w/ new msgs:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lkrn_backend);
+       ForEachRoom(cmd_lkrn_backend, &FloorBeingSearched);
        cprintf("000\n");
 }
 
@@ -577,23 +531,25 @@ void cmd_lkrn(char *argbuf)
 /* 
  * cmd_lkro()   -  List all known rooms
  */
-void cmd_lkro_backend(struct quickroom *qrbuf)
+void cmd_lkro_backend(struct quickroom *qrbuf, void *data)
 {
        int ra;
+       int FloorBeingSearched = (-1);
+       FloorBeingSearched = *(int *)data;
 
        ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
        if ((ra & UA_KNOWN)
            && ((ra & UA_HASNEWMSGS) == 0)
-           && ((qrbuf->QRfloor == (CC->FloorBeingSearched))
-               || ((CC->FloorBeingSearched) < 0)))
+           && ((qrbuf->QRfloor == (FloorBeingSearched))
+               || ((FloorBeingSearched) < 0)))
                list_roomname(qrbuf);
 }
 
 void cmd_lkro(char *argbuf)
 {
-       CC->FloorBeingSearched = (-1);
+       int FloorBeingSearched = (-1);
        if (strlen(argbuf) > 0)
-               CC->FloorBeingSearched = extract_int(argbuf, 0);
+               FloorBeingSearched = extract_int(argbuf, 0);
 
        if (!(CC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -605,7 +561,7 @@ void cmd_lkro(char *argbuf)
        }
        cprintf("%d Rooms w/o new msgs:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lkro_backend);
+       ForEachRoom(cmd_lkro_backend, &FloorBeingSearched);
        cprintf("000\n");
 }
 
@@ -614,23 +570,25 @@ void cmd_lkro(char *argbuf)
 /* 
  * cmd_lzrm()   -  List all forgotten rooms
  */
-void cmd_lzrm_backend(struct quickroom *qrbuf)
+void cmd_lzrm_backend(struct quickroom *qrbuf, void *data)
 {
        int ra;
+       int FloorBeingSearched = (-1);
+       FloorBeingSearched = *(int *)data;
 
        ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
        if ((ra & UA_GOTOALLOWED)
            && (ra & UA_ZAPPED)
-           && ((qrbuf->QRfloor == (CC->FloorBeingSearched))
-               || ((CC->FloorBeingSearched) < 0)))
+           && ((qrbuf->QRfloor == (FloorBeingSearched))
+               || ((FloorBeingSearched) < 0)))
                list_roomname(qrbuf);
 }
 
 void cmd_lzrm(char *argbuf)
 {
-       CC->FloorBeingSearched = (-1);
+       int FloorBeingSearched = (-1);
        if (strlen(argbuf) > 0)
-               CC->FloorBeingSearched = extract_int(argbuf, 0);
+               FloorBeingSearched = extract_int(argbuf, 0);
 
        if (!(CC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -642,7 +600,7 @@ void cmd_lzrm(char *argbuf)
        }
        cprintf("%d Zapped rooms:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lzrm_backend);
+       ForEachRoom(cmd_lzrm_backend, &FloorBeingSearched);
        cprintf("000\n");
 }
 
@@ -731,7 +689,6 @@ void usergoto(char *where, int display_result)
                        rmailflag, raideflag, newmailcount,
                        CC->quickroom.QRfloor);
 
-       set_wtmpsupp_to_current_room();
 }
 
 
@@ -905,8 +862,9 @@ void cmd_rdir(void)
                                buf[strlen(buf) - 1] = 0;
                                if ((!strncasecmp(buf, flnm, strlen(flnm)))
                                    && (buf[strlen(flnm)] == ' '))
-                                       strncpy(comment,
-                                           &buf[strlen(flnm) + 1], 255);
+                                       safestrncpy(comment,
+                                           &buf[strlen(flnm) + 1],
+                                           sizeof comment);
                        }
                        cprintf("%s|%ld|%s\n", flnm, statbuf.st_size, comment);
                }
@@ -991,13 +949,14 @@ void cmd_setr(char *args)
        strcpy(old_name, CC->quickroom.QRname);
        extract(buf, args, 0);
        buf[ROOMNAMELEN] = 0;
-       strncpy(CC->quickroom.QRname, buf, ROOMNAMELEN - 1);
+       safestrncpy(CC->quickroom.QRname, buf, sizeof CC->quickroom.QRname);
        extract(buf, args, 1);
        buf[10] = 0;
-       strncpy(CC->quickroom.QRpasswd, buf, 9);
+       safestrncpy(CC->quickroom.QRpasswd, buf, sizeof CC->quickroom.QRpasswd);
        extract(buf, args, 2);
        buf[15] = 0;
-       strncpy(CC->quickroom.QRdirname, buf, 19);
+       safestrncpy(CC->quickroom.QRdirname, buf,
+               sizeof CC->quickroom.QRdirname);
        CC->quickroom.QRflags = (extract_int(args, 3) | QR_INUSE);
        if (num_parms(args) >= 7)
                CC->quickroom.QRorder = (char) new_order;
@@ -1250,8 +1209,8 @@ unsigned create_room(char *new_room_name,
                return (0);     /* already exists */
 
        memset(&qrbuf, 0, sizeof(struct quickroom));
-       strncpy(qrbuf.QRname, new_room_name, ROOMNAMELEN);
-       strncpy(qrbuf.QRpasswd, new_room_pass, 9);
+       safestrncpy(qrbuf.QRname, new_room_name, sizeof qrbuf.QRname);
+       safestrncpy(qrbuf.QRpasswd, new_room_pass, sizeof qrbuf.QRpasswd);
        qrbuf.QRflags = QR_INUSE;
        qrbuf.QRnumber = get_new_room_number();
        if (new_room_type > 0)
@@ -1389,7 +1348,7 @@ void cmd_cre8(char *args)
                           new_room_type, new_room_pass, new_room_floor);
 
        /* post a message in Aide> describing the new room */
-       strncpy(aaa, new_room_name, 255);
+       safestrncpy(aaa, new_room_name, sizeof aaa);
        strcat(aaa, "> created by ");
        strcat(aaa, CC->usersupp.fullname);
        if (newflags & QR_MAILBOX)
@@ -1542,7 +1501,7 @@ void cmd_cflr(char *argbuf)
        lgetfloor(&flbuf, free_slot);
        flbuf.f_flags = F_INUSE;
        flbuf.f_ref_count = 0;
-       strncpy(flbuf.f_name, new_floor_name, 255);
+       safestrncpy(flbuf.f_name, new_floor_name, sizeof flbuf.f_name);
        lputfloor(&flbuf, free_slot);
        cprintf("%d %d\n", OK, free_slot);
 }