#include <sys/wait.h>
#include <errno.h>
#include <stdarg.h>
+#include <libcitadel.h>
#include "citadel.h"
#include "citadel_ipc.h"
#include "citadel_decls.h"
#include "rooms.h"
#include "commands.h"
-#include "tools.h"
#include "messages.h"
#ifndef HAVE_SNPRINTF
#include "snprintf.h"
strcpy(floorlist[0], "Main Floor");
return;
}
- while (*listing && strlen(listing)) {
+ while (*listing && !IsEmptyStr(listing)) {
extract_token(buf, listing, 0, '\n', sizeof buf);
remove_token(listing, 0, '\n');
extract_token(floorlist[extract_int(buf, 0)], buf, 1, '|', SIZ);
} else {
strcpy(raide, "");
}
- if (strlen(raide) == 0) {
+ if (IsEmptyStr(raide)) {
strcpy(raide, "none");
}
attr->QRflags = set_room_attr(ipc, attr->QRflags, "Private room", QR_PRIVATE);
if (attr->QRflags & QR_PRIVATE) {
attr->QRflags = set_room_attr(ipc, attr->QRflags,
- "Accessible by guessing room name",
+ "Hidden room (accessible to anyone who knows the room name)",
QR_GUESSNAME);
}
attr->QRflags2 = set_room_attr(ipc, attr->QRflags2,
"Self-service list subscribe/unsubscribe",
QR2_SELFLIST);
+ attr->QRflags2 = set_room_attr(ipc, attr->QRflags2,
+ "public posting to this room via room_roomname@yourcitadel.org",
+ QR2_SMTP_PUBLIC);
+ attr->QRflags2 = set_room_attr(ipc, attr->QRflags2,
+ "moderated mailinglist",
+ QR2_MODERATED);
attr->QRflags = set_room_attr(ipc, attr->QRflags,
"Automatically make all messages anonymous",
QR_ANONONLY);
}
} while (r / 100 != 2);
- /* FIXME: Duplicate code??? */
- if (!strcasecmp(raide, "none")) {
- strcpy(raide, "");
- }
-
/* Angels and demons dancing in my head... */
do {
snprintf(buf, sizeof buf, "%d", attr->QRep.expire_mode);
scr_printf("Must specify a room to ungoto.\n");
return;
}
- if (strlen(towhere) == 0)
+ if (IsEmptyStr(towhere))
{
scr_printf("Must specify a room to ungoto.\n");
return;
{
static char save_dir[SIZ] = { 0 };
- if (strlen(save_dir) == 0) {
+ if (IsEmptyStr(save_dir)) {
if (getenv("HOME") == NULL) {
strcpy(save_dir, ".");
}
FILE *tpipe = NULL;
int broken = 0;
int r;
+ int rv = 0;
void *file = NULL; /* The downloaded file */
size_t filelen = 0L; /* The downloaded file length */
screen_reset();
stty_ctdl(SB_RESTORE);
- system(transmit_cmd);
+ rv = system(transmit_cmd);
stty_ctdl(SB_NO_INTR);
screen_set();
char flnm[256];
char flsz[32];
char comment[256];
+ char mimetype[256];
char buf[256];
char *listing = NULL; /* Returned directory listing */
int r;
extract_token(flnm, buf, 1, '|', sizeof flnm);
pprintf("\nDirectory of %s on %s\n", flnm, comment);
pprintf("-----------------------\n");
- while (listing && *listing && strlen(listing)) {
+ while (listing && *listing && !IsEmptyStr(listing)) {
extract_token(buf, listing, 0, '\n', sizeof buf);
remove_token(listing, 0, '\n');
extract_token(flnm, buf, 0, '|', sizeof flnm);
extract_token(flsz, buf, 1, '|', sizeof flsz);
- extract_token(comment, buf, 2, '|', sizeof comment);
+ extract_token(mimetype, buf, 2, '|', sizeof mimetype);
+ extract_token(comment, buf, 3, '|', sizeof comment);
if (strlen(flnm) <= 14)
- pprintf("%-14s %8s %s\n", flnm, flsz, comment);
+ pprintf("%-14s %8s %s [%s]\n", flnm, flsz, comment, mimetype);
else
- pprintf("%s\n%14s %8s %s\n", flnm, "", flsz,
- comment);
+ pprintf("%s\n%14s %8s %s [%s]\n", flnm, "", flsz,
+ comment, mimetype);
}
if (listing) free(listing);
}
}
newprompt("Name for new room? ", new_room_name, ROOMNAMELEN - 1);
- if (strlen(new_room_name) == 0) {
+ if (IsEmptyStr(new_room_name)) {
return;
}
- for (a = 0; a < strlen(new_room_name); ++a) {
+ for (a = 0; !IsEmptyStr(&new_room_name[a]); ++a) {
if (new_room_name[a] == '|') {
new_room_name[a] = '_';
}
IFNEXPERT formout(ipc, "roomaccess");
do {
- scr_printf("<?>Help\n<1>Public room\n<2>Guess-name room\n"
- "<3>Passworded room\n<4>Invitation-only room\n"
- "<5>Personal room\n"
- "Enter room type: ");
+ scr_printf("<?>Help\n"
+ "<1>Public room (shown to all users by default)\n"
+ "<2>Hidden room (accessible to anyone who knows the room name)\n"
+ "<3>Passworded room (hidden, plus requires a password to enter)\n"
+ "<4>Invitation-only room (requires access to be granted by an Aide)\n"
+ "<5>Personal room (accessible to you only)\n"
+ "Enter room type: "
+ );
do {
b = inkey();
} while (((b < '1') || (b > '5')) && (b != '?'));
new_room_type = b - 1;
if (new_room_type == 2) {
newprompt("Enter a room password: ", new_room_pass, 9);
- for (a = 0; a < strlen(new_room_pass); ++a)
+ for (a = 0; !IsEmptyStr(&new_room_pass[a]); ++a)
if (new_room_pass[a] == '|')
new_room_pass[a] = '_';
} else {
if (b == 1)
scr_printf(" public room.");
if (b == 2)
- scr_printf(" guess-name room.");
+ scr_printf(" hidden room.");
if (b == 3)
scr_printf(" passworded room, password: %s", new_room_pass);
if (b == 4)
else
strcpy(raide, "");
- if (strlen(raide) > 0)
+ if (!IsEmptyStr(raide))
scr_printf("Room aide is %s.\n\n", raide);
r = CtdlIPCRoomInfo(ipc, &text, buf);
pprintf("%s\n", buf);
return;
}
- while (strlen(listing) > 0) {
+ while (!IsEmptyStr(listing)) {
extract_token(buf, listing, 0, '\n', sizeof buf);
remove_token(listing, 0, '\n');
if (sigcaught == 0)
char cmd[SIZ];
int b, cksum, editor_exit;
- if (strlen(editor_paths[0]) == 0) {
+ if (IsEmptyStr(editor_paths[0])) {
scr_printf("Do you wish to re-enter %s? ", desc);
if (yesno() == 0)
return;
return;
}
- if (strlen(editor_paths[0]) > 0) {
+ if (!IsEmptyStr(editor_paths[0])) {
CtdlIPC_chat_send(ipc, read_cmd);
CtdlIPC_chat_recv(ipc, cmd);
if (cmd[0] == '1') {
cksum = file_checksum(temp);
- if (strlen(editor_paths[0]) > 0) {
+ if (!IsEmptyStr(editor_paths[0])) {
char tmp[SIZ];
snprintf(tmp, sizeof tmp, "WINDOW_TITLE=%s", desc);
floornum_to_delete = (-1);
scr_printf("(Press return to abort)\n");
newprompt("Delete which floor? ", buf, 255);
- if (strlen(buf) == 0)
+ if (IsEmptyStr(buf))
return;
for (a = 0; a < 128; ++a)
if (!strcasecmp(&floorlist[a][0], buf))