]> code.citadel.org Git - citadel.git/blobdiff - citadel/serv_listsub.c
mk_module_init.sh now tests to see if echo supports -e and -E
[citadel.git] / citadel / serv_listsub.c
index 2138fda19fddd66e71b2c2b3e5dee10dbb1eae51..93e93553b5a54c92618cb64125e6596b93baeced 100644 (file)
@@ -3,7 +3,7 @@
  *
  * This module handles self-service subscription/unsubscription to mail lists.
  *
- * Copyright (C) 2002 by Art Cancro and others.
+ * Copyright (C) 2002-2005 by Art Cancro and others.
  * This code is released under the terms of the GNU General Public License.
  *
  */
 #include <limits.h>
 #include "citadel.h"
 #include "server.h"
-#include "sysdep_decls.h"
 #include "citserver.h"
 #include "support.h"
 #include "config.h"
-#include "serv_extensions.h"
 #include "room_ops.h"
 #include "user_ops.h"
 #include "policy.h"
 #endif
 
 
+
+#include "ctdl_module.h"
+
+
 /*
  * Generate a randomizationalisticized token to use for authentication of
  * a subscribe or unsubscribe request.
@@ -83,13 +85,13 @@ void listsub_generate_token(char *buf) {
 void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
        struct ctdlroom qrbuf;
        FILE *ncfp;
-       char filename[SIZ];
-       char token[SIZ];
-       char confirmation_request[SIZ];
-       char buf[SIZ];
-       char urlroom[SIZ];
-       char scancmd[SIZ];
-       char scanemail[SIZ];
+       char filename[256];
+       char token[256];
+       char confirmation_request[2048];
+       char buf[512];
+       char urlroom[ROOMNAMELEN];
+       char scancmd[64];
+       char scanemail[256];
        int found_sub = 0;
 
        if (getroom(&qrbuf, room) != 0) {
@@ -106,7 +108,7 @@ void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
 
        listsub_generate_token(token);
 
-       assoc_file_name(filename, sizeof filename, &qrbuf, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &qrbuf, ctdl_netcfg_dir);
 
        /* 
         * Make sure the requested address isn't already subscribed
@@ -116,8 +118,8 @@ void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
        if (ncfp != NULL) {
                while (fgets(buf, sizeof buf, ncfp) != NULL) {
                        buf[strlen(buf)-1] = 0;
-                       extract(scancmd, buf, 0);
-                       extract(scanemail, buf, 1);
+                       extract_token(scancmd, buf, 0, '|', sizeof scancmd);
+                       extract_token(scanemail, buf, 1, '|', sizeof scanemail);
                        if ((!strcasecmp(scancmd, "listrecp"))
                           || (!strcasecmp(scancmd, "digestrecp"))) {
                                if (!strcasecmp(scanemail, email)) {
@@ -158,17 +160,44 @@ void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
        urlesc(urlroom, qrbuf.QRname);
 
        snprintf(confirmation_request, sizeof confirmation_request,
-               "Content-type: text/html\n\n"
-               "<HTML><BODY>"
+
+               "MIME-Version: 1.0\n"
+               "Content-Type: multipart/alternative; boundary=\"__ctdlmultipart__\"\n"
+               "\n"
+               "This is a multipart message in MIME format.\n"
+               "\n"
+               "--__ctdlmultipart__\n"
+               "Content-type: text/plain\n"
+               "\n"
+               "Someone (probably you) has submitted a request to subscribe\n"
+               "<%s> to the '%s' mailing list.\n"
+               "\n"
+               "Please go here to confirm this request:\n"
+               "  %s?room=%s&token=%s&cmd=confirm  \n"
+               "\n"
+               "If this request has been submitted in error and you do not\n"
+               "wish to receive the '%s' mailing list, simply do nothing,\n"
+               "and you will not receive any further mailings.\n"
+               "\n"
+               "--__ctdlmultipart__\n"
+               "Content-type: text/html\n"
+               "\n"
+               "<HTML><BODY>\n"
                "Someone (probably you) has submitted a request to subscribe\n"
                "&lt;%s&gt; to the <B>%s</B> mailing list.<BR><BR>\n"
                "Please click here to confirm this request:<BR>\n"
-               "<A HREF=\"http://%s?room=%s&token=%s&cmd=confirm\">"
-               "http://%s?room=%s&token=%s&cmd=confirm</A><BR><BR>\n"
+               "<A HREF=\"%s?room=%s&token=%s&cmd=confirm\">"
+               "%s?room=%s&token=%s&cmd=confirm</A><BR><BR>\n"
                "If this request has been submitted in error and you do not\n"
                "wish to receive the '%s' mailing list, simply do nothing,\n"
                "and you will not receive any further mailings.\n"
-               "</BODY></HTML>\n",
+               "</BODY></HTML>\n"
+               "\n"
+               "--__ctdlmultipart__--\n",
+
+               email, qrbuf.QRname,
+               webpage, urlroom, token,
+               qrbuf.QRname,
 
                email, qrbuf.QRname,
                webpage, urlroom, token,
@@ -178,6 +207,7 @@ void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
 
        quickie_message(        /* This delivers the message */
                "Citadel",
+               NULL,
                email,
                NULL,
                confirmation_request,
@@ -195,13 +225,13 @@ void do_subscribe(char *room, char *email, char *subtype, char *webpage) {
 void do_unsubscribe(char *room, char *email, char *webpage) {
        struct ctdlroom qrbuf;
        FILE *ncfp;
-       char filename[SIZ];
-       char token[SIZ];
-       char buf[SIZ];
-       char confirmation_request[SIZ];
-       char urlroom[SIZ];
-       char scancmd[SIZ];
-       char scanemail[SIZ];
+       char filename[256];
+       char token[256];
+       char buf[512];
+       char confirmation_request[2048];
+       char urlroom[ROOMNAMELEN];
+       char scancmd[256];
+       char scanemail[256];
        int found_sub = 0;
 
        if (getroom(&qrbuf, room) != 0) {
@@ -219,7 +249,7 @@ void do_unsubscribe(char *room, char *email, char *webpage) {
 
        listsub_generate_token(token);
 
-       assoc_file_name(filename, sizeof filename, &qrbuf, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &qrbuf, ctdl_netcfg_dir);
 
        /* 
         * Make sure there's actually a subscription there to remove
@@ -229,8 +259,8 @@ void do_unsubscribe(char *room, char *email, char *webpage) {
        if (ncfp != NULL) {
                while (fgets(buf, sizeof buf, ncfp) != NULL) {
                        buf[strlen(buf)-1] = 0;
-                       extract(scancmd, buf, 0);
-                       extract(scanemail, buf, 1);
+                       extract_token(scancmd, buf, 0, '|', sizeof scancmd);
+                       extract_token(scanemail, buf, 1, '|', sizeof scanemail);
                        if ((!strcasecmp(scancmd, "listrecp"))
                           || (!strcasecmp(scancmd, "digestrecp"))) {
                                if (!strcasecmp(scanemail, email)) {
@@ -270,19 +300,44 @@ void do_unsubscribe(char *room, char *email, char *webpage) {
        urlesc(urlroom, qrbuf.QRname);
 
        snprintf(confirmation_request, sizeof confirmation_request,
-               "Content-type: text/html\n\n"
-               "<HTML><BODY>"
-               "Someone (probably you) has submitted a request "
-               "to unsubscribe\n"
+
+               "MIME-Version: 1.0\n"
+               "Content-Type: multipart/alternative; boundary=\"__ctdlmultipart__\"\n"
+               "\n"
+               "This is a multipart message in MIME format.\n"
+               "\n"
+               "--__ctdlmultipart__\n"
+               "Content-type: text/plain\n"
+               "\n"
+               "Someone (probably you) has submitted a request to unsubscribe\n"
+               "<%s> from the '%s' mailing list.\n"
+               "\n"
+               "Please go here to confirm this request:\n"
+               "  %s?room=%s&token=%s&cmd=confirm  \n"
+               "\n"
+               "If this request has been submitted in error and you do not\n"
+               "wish to unsubscribe from the '%s' mailing list, simply do nothing,\n"
+               "and the request will not be processed.\n"
+               "\n"
+               "--__ctdlmultipart__\n"
+               "Content-type: text/html\n"
+               "\n"
+               "<HTML><BODY>\n"
+               "Someone (probably you) has submitted a request to unsubscribe\n"
                "&lt;%s&gt; from the <B>%s</B> mailing list.<BR><BR>\n"
                "Please click here to confirm this request:<BR>\n"
-               "<A HREF=\"http://%s?room=%s&token=%s&cmd=confirm\">"
-               "http://%s?room=%s&token=%s&cmd=confirm</A><BR><BR>\n"
-               "If this request has been submitted in error and you do\n"
-               "<i>not</i> wish to unsubscribe from the "
-               "'%s' mailing list, simply do nothing,\n"
-               "and you will remain subscribed to the list.\n"
-               "</BODY></HTML>\n",
+               "<A HREF=\"%s?room=%s&token=%s&cmd=confirm\">"
+               "%s?room=%s&token=%s&cmd=confirm</A><BR><BR>\n"
+               "If this request has been submitted in error and you do not\n"
+               "wish to unsubscribe from the '%s' mailing list, simply do nothing,\n"
+               "and the request will not be processed.\n"
+               "</BODY></HTML>\n"
+               "\n"
+               "--__ctdlmultipart__--\n",
+
+               email, qrbuf.QRname,
+               webpage, urlroom, token,
+               qrbuf.QRname,
 
                email, qrbuf.QRname,
                webpage, urlroom, token,
@@ -292,6 +347,7 @@ void do_unsubscribe(char *room, char *email, char *webpage) {
 
        quickie_message(        /* This delivers the message */
                "Citadel",
+               NULL,
                email,
                NULL,
                confirmation_request,
@@ -309,18 +365,18 @@ void do_unsubscribe(char *room, char *email, char *webpage) {
 void do_confirm(char *room, char *token) {
        struct ctdlroom qrbuf;
        FILE *ncfp;
-       char filename[SIZ];
-       char line_token[SIZ];
+       char filename[256];
+       char line_token[256];
        long line_offset;
        int line_length;
-       char buf[SIZ];
-       char cmd[SIZ];
-       char email[SIZ];
-       char subtype[SIZ];
+       char buf[512];
+       char cmd[256];
+       char email[256];
+       char subtype[128];
        int success = 0;
-       char address_to_unsubscribe[SIZ];
-       char scancmd[SIZ];
-       char scanemail[SIZ];
+       char address_to_unsubscribe[256];
+       char scancmd[256];
+       char scanemail[256];
        char *holdbuf = NULL;
        int linelen = 0;
        int buflen = 0;
@@ -344,7 +400,7 @@ void do_confirm(char *room, char *token) {
         * Now start scanning this room's netconfig file for the
         * specified token.
         */
-       assoc_file_name(filename, sizeof filename, &qrbuf, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &qrbuf, ctdl_netcfg_dir);
        begin_critical_section(S_NETCONFIGS);
        ncfp = fopen(filename, "r+");
        if (ncfp != NULL) {
@@ -352,17 +408,17 @@ void do_confirm(char *room, char *token) {
                      (fgets(buf, sizeof buf, ncfp) != NULL) ) {
                        buf[strlen(buf)-1] = 0;
                        line_length = strlen(buf);
-                       extract(cmd, buf, 0);
+                       extract_token(cmd, buf, 0, '|', sizeof cmd);
                        if (!strcasecmp(cmd, "subpending")) {
-                               extract(email, buf, 1);
-                               extract(subtype, buf, 2);
-                               extract(line_token, buf, 3);
+                               extract_token(email, buf, 1, '|', sizeof email);
+                               extract_token(subtype, buf, 2, '|', sizeof subtype);
+                               extract_token(line_token, buf, 3, '|', sizeof line_token);
                                if (!strcasecmp(token, line_token)) {
                                        if (!strcasecmp(subtype, "digest")) {
-                                               strcpy(buf, "digestrecp|");
+                                               safestrncpy(buf, "digestrecp|", sizeof buf);
                                        }
                                        else {
-                                               strcpy(buf, "listrecp|");
+                                               safestrncpy(buf, "listrecp|", sizeof buf);
                                        }
                                        strcat(buf, email);
                                        strcat(buf, "|");
@@ -379,9 +435,10 @@ void do_confirm(char *room, char *token) {
                                }
                        }
                        if (!strcasecmp(cmd, "unsubpending")) {
-                               extract(line_token, buf, 2);
+                               extract_token(line_token, buf, 2, '|', sizeof line_token);
                                if (!strcasecmp(token, line_token)) {
-                                       extract(address_to_unsubscribe, buf, 1);
+                                       extract_token(address_to_unsubscribe, buf, 1, '|',
+                                               sizeof address_to_unsubscribe);
                                }
                        }
                }
@@ -395,15 +452,15 @@ void do_confirm(char *room, char *token) {
         * that address.
         */
        if (strlen(address_to_unsubscribe) > 0) {
-               holdbuf = mallok(SIZ);
+               holdbuf = malloc(SIZ);
                begin_critical_section(S_NETCONFIGS);
                ncfp = fopen(filename, "r+");
                if (ncfp != NULL) {
                        while (line_offset = ftell(ncfp),
                              (fgets(buf, sizeof buf, ncfp) != NULL) ) {
                                buf[strlen(buf)-1]=0;
-                               extract(scancmd, buf, 0);
-                               extract(scanemail, buf, 1);
+                               extract_token(scancmd, buf, 0, '|', sizeof scancmd);
+                               extract_token(scanemail, buf, 1, '|', sizeof scanemail);
                                if ( (!strcasecmp(scancmd, "listrecp"))
                                   && (!strcasecmp(scanemail,
                                                address_to_unsubscribe)) ) {
@@ -426,7 +483,7 @@ void do_confirm(char *room, char *token) {
                                }
                                else {  /* Not relevant, so *keep* it! */
                                        linelen = strlen(buf);
-                                       holdbuf = reallok(holdbuf,
+                                       holdbuf = realloc(holdbuf,
                                                (buflen + linelen + 2) );
                                        strcpy(&holdbuf[buflen], buf);
                                        buflen += linelen;
@@ -442,7 +499,7 @@ void do_confirm(char *room, char *token) {
                        fclose(ncfp);
                }
                end_critical_section(S_NETCONFIGS);
-               phree(holdbuf);
+               free(holdbuf);
        }
 
        /*
@@ -450,6 +507,7 @@ void do_confirm(char *room, char *token) {
         */
        if (success) {
                cprintf("%d %d operation(s) confirmed.\n", CIT_OK, success);
+               lprintf(CTDL_NOTICE, "Mailing list: %s %ssubscribed to %s with token %s\n", email, (strlen(address_to_unsubscribe) > 0) ? "un" : "", room, token);
        }
        else {
                cprintf("%d Invalid token.\n", ERROR + ILLEGAL_VALUE);
@@ -464,37 +522,37 @@ void do_confirm(char *room, char *token) {
  */
 void cmd_subs(char *cmdbuf) {
 
-       char opr[SIZ];
-       char room[SIZ];
-       char email[SIZ];
-       char subtype[SIZ];
-       char token[SIZ];
-       char webpage[SIZ];
+       char opr[256];
+       char room[ROOMNAMELEN];
+       char email[256];
+       char subtype[256];
+       char token[256];
+       char webpage[256];
 
-       extract(opr, cmdbuf, 0);
+       extract_token(opr, cmdbuf, 0, '|', sizeof opr);
        if (!strcasecmp(opr, "subscribe")) {
-               extract(subtype, cmdbuf, 3);
+               extract_token(subtype, cmdbuf, 3, '|', sizeof subtype);
                if ( (strcasecmp(subtype, "list"))
                   && (strcasecmp(subtype, "digest")) ) {
                        cprintf("%d Invalid subscription type '%s'\n",
                                ERROR + ILLEGAL_VALUE, subtype);
                }
                else {
-                       extract(room, cmdbuf, 1);
-                       extract(email, cmdbuf, 2);
-                       extract(webpage, cmdbuf, 4);
+                       extract_token(room, cmdbuf, 1, '|', sizeof room);
+                       extract_token(email, cmdbuf, 2, '|', sizeof email);
+                       extract_token(webpage, cmdbuf, 4, '|', sizeof webpage);
                        do_subscribe(room, email, subtype, webpage);
                }
        }
        else if (!strcasecmp(opr, "unsubscribe")) {
-               extract(room, cmdbuf, 1);
-               extract(email, cmdbuf, 2);
-               extract(webpage, cmdbuf, 3);
+               extract_token(room, cmdbuf, 1, '|', sizeof room);
+               extract_token(email, cmdbuf, 2, '|', sizeof email);
+               extract_token(webpage, cmdbuf, 3, '|', sizeof webpage);
                do_unsubscribe(room, email, webpage);
        }
        else if (!strcasecmp(opr, "confirm")) {
-               extract(room, cmdbuf, 1);
-               extract(token, cmdbuf, 2);
+               extract_token(room, cmdbuf, 1, '|', sizeof room);
+               extract_token(token, cmdbuf, 2, '|', sizeof token);
                do_confirm(room, token);
        }
        else {
@@ -506,8 +564,10 @@ void cmd_subs(char *cmdbuf) {
 /*
  * Module entry point
  */
-char *serv_listsub_init(void)
+CTDL_MODULE_INIT(listsub)
 {
        CtdlRegisterProtoHook(cmd_subs, "SUBS", "List subscribe/unsubscribe");
+
+       /* return our Subversion id for the Log */
        return "$Id$";
 }