]> code.citadel.org Git - citadel.git/blobdiff - citadel/serv_network.c
more sprintf removals
[citadel.git] / citadel / serv_network.c
index d0400d13db1a0624ccd560f29484a5aa1b769fe2..164e890c9d9ecd75078c42785b279741f7e25326 100644 (file)
@@ -74,140 +74,103 @@ struct RoomProcList *rplist = NULL;
  */
 struct NetMap *the_netmap = NULL;
 
-
 /*
- * Manage the use table.  This is a list of messages which have recently
- * arrived on the system.  It is maintained and queried to prevent the same
- * message from being entered into the database multiple times if it happens
- * to arrive multiple times by accident.
+ * Keep track of what messages to reject
  */
-int network_usetable(int operation, struct CtdlMessage *msg) {
-
-       static struct UseTable *ut = NULL;
-       struct UseTable *uptr = NULL;
-       char *serialized_table = NULL;
-       char *ptr;
-       char msgid[SIZ];
-       char buf[SIZ];
+struct FilterList *load_filter_list(void) {
+       char *serialized_list = NULL;
        int i;
-       size_t stlen = 0;
+       char buf[SIZ];
+       struct FilterList *newlist = NULL;
+       struct FilterList *nptr;
 
-       switch(operation) {
-       
-               case UT_LOAD:
-                       serialized_table = CtdlGetSysConfig(USETABLE);
-                       if (serialized_table == NULL) return(0);
-
-                       ptr = serialized_table;
-                       i = 0;
-                       buf[0] = 0;
-                       while (ptr[0] != 0) {
-                               buf[i] = *ptr;
-               
-                               if (buf[i]=='\n') {
-                                       buf[i] = 0;
-                                       if (strlen(buf) > 0) {
-
-                                               uptr = (struct UseTable *)
-                                                       mallok(sizeof(struct UseTable));
-                                               if (uptr != NULL) {
-                                                       uptr->next = ut;
-                                                       extract(msgid, buf, 0);
-                                                       uptr->message_id = strdoop(msgid);
-                                                       uptr->timestamp = extract_long(buf, 1);
-                                                       ut = uptr;
-                                               }
-                                       }
+       serialized_list = CtdlGetSysConfig(FILTERLIST);
+       if (serialized_list == NULL) return(NULL); /* if null, no entries */
 
-                                       i = 0;
-                                       buf[0] = 0;
-                               }
-                               else {
-                                       ++i;
-                               }
-                               ++ptr;
-                       }
+       /* Use the string tokenizer to grab one line at a time */
+       for (i=0; i<num_tokens(serialized_list, '\n'); ++i) {
+               extract_token(buf, serialized_list, i, '\n');
+               nptr = (struct FilterList *) mallok(sizeof(struct FilterList));
+               extract(nptr->fl_user, buf, 0);
+               striplt(nptr->fl_user);
+               extract(nptr->fl_room, buf, 1);
+               striplt(nptr->fl_room);
+               extract(nptr->fl_node, buf, 2);
+               striplt(nptr->fl_node);
+
+               /* Cowardly refuse to add an any/any/any entry that would
+                * end up filtering every single message.
+                */
+               if (strlen(nptr->fl_user) + strlen(nptr->fl_room)
+                  + strlen(nptr->fl_node) == 0) {
+                       phree(nptr);
+               }
+               else {
+                       nptr->next = newlist;
+                       newlist = nptr;
+               }
+       }
 
-                       phree(serialized_table);
-                       serialized_table = NULL;
-                       return(0);
+       phree(serialized_list);
+       return newlist;
+}
 
-               case UT_INSERT:
-                       /* Bail out if we can't generate a message ID */
-                       if (msg == NULL) {
-                               return(0);
-                       }
-                       if (msg->cm_fields['I'] == NULL) {
-                               return(0);
-                       }
-                       if (strlen(msg->cm_fields['I']) == 0) {
-                               return(0);
-                       }
 
-                       /* Generate the message ID */
-                       strcpy(msgid, msg->cm_fields['I']);
-                       if (haschar(msgid, '@') == 0) {
-                               strcat(msgid, "@");
-                               if (msg->cm_fields['N'] != NULL) {
-                                       strcat(msgid, msg->cm_fields['N']);
-                               }
-                               else {
-                                       return(0);
-                               }
-                       }
+void free_filter_list(struct FilterList *fl) {
+       if (fl == NULL) return;
+       free_filter_list(fl->next);
+       phree(fl);
+}
 
-                       /* Compare to the existing list */
-                       for (uptr = ut; uptr != NULL; uptr = uptr->next) {
-                               if (!strcasecmp(msgid, uptr->message_id)) {
-                                       return(1);
-                               }
-                       }
 
-                       /* If we got to this point, it's unique: add it. */
-                       uptr = (struct UseTable *)
-                               mallok(sizeof(struct UseTable));
-                       if (uptr == NULL) return(0);
-                       uptr->next = ut;
-                       uptr->message_id = strdoop(msgid);
-                       uptr->timestamp = time(NULL);
-                       ut = uptr;
-                       return(0);
 
-               case UT_SAVE:
-                       /* Figure out how big the serialized buffer should be */
-                       stlen = 0;
-                       for (uptr = ut; uptr != NULL; uptr = uptr->next) {
-                               stlen = stlen + strlen(uptr->message_id) + 20;
-                       }
-                       serialized_table = mallok(stlen);
-                       memset(serialized_table, 0, stlen);
-
-                       while (ut != NULL) {
-                               if ( (serialized_table != NULL) 
-                                  && ( (ut->timestamp - time(NULL)) <
-                                     USETABLE_RETAIN) ) {
-                                       sprintf(&serialized_table[strlen(
-                                         serialized_table)], "%s|%ld\n",
-                                           ut->message_id,
-                                           (long)ut->timestamp);
-                               }
+/*
+ * Check the use table.  This is a list of messages which have recently
+ * arrived on the system.  It is maintained and queried to prevent the same
+ * message from being entered into the database multiple times if it happens
+ * to arrive multiple times by accident.
+ */
+int network_usetable(struct CtdlMessage *msg) {
 
-                               /* Now free the memory */
-                               uptr = ut;
-                               ut = ut->next;
-                               phree(uptr->message_id);
-                               phree(uptr);
-                       }
+       char msgid[SIZ];
+       struct cdbdata *cdbut;
+       struct UseTable ut;
 
-                       /* Write to disk */
-                       CtdlPutSysConfig(USETABLE, serialized_table);
-                       phree(serialized_table);
+       /* Bail out if we can't generate a message ID */
+       if (msg == NULL) {
+               return(0);
+       }
+       if (msg->cm_fields['I'] == NULL) {
+               return(0);
+       }
+       if (strlen(msg->cm_fields['I']) == 0) {
+               return(0);
+       }
+
+       /* Generate the message ID */
+       strcpy(msgid, msg->cm_fields['I']);
+       if (haschar(msgid, '@') == 0) {
+               strcat(msgid, "@");
+               if (msg->cm_fields['N'] != NULL) {
+                       strcat(msgid, msg->cm_fields['N']);
+               }
+               else {
                        return(0);
+               }
+       }
 
+       cdbut = cdb_fetch(CDB_USETABLE, msgid, strlen(msgid));
+       if (cdbut != NULL) {
+               cdb_free(cdbut);
+               return(1);
        }
 
-       /* should never get here unless illegal operation specified */
-       return(2);
+       /* If we got to this point, it's unique: add it. */
+       strcpy(ut.ut_msgid, msgid);
+       ut.ut_timestamp = time(NULL);
+       cdb_store(CDB_USETABLE, msgid, strlen(msgid),
+               &ut, sizeof(struct UseTable) );
+       return(0);
 }
 
 
@@ -359,7 +322,7 @@ void cmd_gnet(char *argbuf) {
        FILE *fp;
 
        if (CtdlAccessCheck(ac_room_aide)) return;
-       assoc_file_name(filename, &CC->quickroom, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &CC->quickroom, "netconfigs");
        cprintf("%d Network settings for room #%ld <%s>\n",
                LISTING_FOLLOWS,
                CC->quickroom.QRnumber, CC->quickroom.QRname);
@@ -385,7 +348,7 @@ void cmd_snet(char *argbuf) {
 
        if (CtdlAccessCheck(ac_room_aide)) return;
        safestrncpy(tempfilename, tmpnam(NULL), sizeof tempfilename);
-       assoc_file_name(filename, &CC->quickroom, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &CC->quickroom, "netconfigs");
 
        fp = fopen(tempfilename, "w");
        if (fp == NULL) {
@@ -608,7 +571,7 @@ void network_spoolout_room(char *room_to_spool) {
        }
 
        memset(&sc, 0, sizeof(struct SpoolControl));
-       assoc_file_name(filename, &CC->quickroom, "netconfigs");
+       assoc_file_name(filename, sizeof filename, &CC->quickroom, "netconfigs");
 
        fp = fopen(filename, "r");
        if (fp == NULL) {
@@ -755,8 +718,8 @@ void network_bounce(struct CtdlMessage *msg, char *reason) {
        if (msg->cm_fields['I'] != NULL) {
                phree(msg->cm_fields['I']);
        }
-       sprintf(buf, "%ld.%04x.%04x@%s",
-               (long)time(NULL), getpid(), ++serialnum, config.c_fqdn);
+       sprintf(buf, "%ld.%04lx.%04x@%s",
+               (long)time(NULL), (long)getpid(), ++serialnum, config.c_fqdn);
        msg->cm_fields['I'] = strdoop(buf);
 
        /*
@@ -920,7 +883,7 @@ void network_process_buffer(char *buffer, long size) {
        /*
         * Check to see if we already have a copy of this message
         */
-       if (network_usetable(UT_INSERT, msg) != 0) {
+       if (network_usetable(msg) != 0) {
                sprintf(buf,
                        "Loopzapper rejected message <%s> "
                        "from <%s> in <%s> @ <%s>\n",
@@ -1328,10 +1291,10 @@ void network_do_queue(void) {
        network_poll_other_citadel_nodes();
 
        /*
-        * Load the network map and use table into memory.
+        * Load the network map and filter list into memory.
         */
        read_network_map();
-       network_usetable(UT_LOAD, NULL);
+       filterlist = load_filter_list();
 
        /* 
         * Go ahead and run the queue
@@ -1350,16 +1313,18 @@ void network_do_queue(void) {
        lprintf(7, "network: processing inbound queue\n");
        network_do_spoolin();
 
-       /* Save the usetable and network map back to disk */
-       network_usetable(UT_SAVE, NULL);
+       /* Save the network map back to disk */
        write_network_map();
 
+       /* Free the filter list in memory */
+       free_filter_list(filterlist);
+       filterlist = NULL;
+
        lprintf(7, "network: queue run completed\n");
        doing_queue = 0;
 }
 
 
-
 /*
  * cmd_netp() - authenticate to the server as another Citadel node polling
  *              for network traffic
@@ -1398,6 +1363,8 @@ void cmd_netp(char *cmdbuf)
 
 
 
+
+
 /*
  * Module entry point
  */