]> code.citadel.org Git - citadel.git/blobdiff - citadel/serv_network.c
warning fixes and cleanups for 64-bit machines
[citadel.git] / citadel / serv_network.c
index 195b3918fcefed3bf91326a4db65d477bd6f27b3..37feb4079c198d6be6a93217795252b6c3df80cf 100644 (file)
 #include "clientsocket.h"
 #include "file_ops.h"
 
+#ifndef HAVE_SNPRINTF
+#include "snprintf.h"
+#endif
+
 
 /*
  * When we do network processing, it's accomplished in two passes; one to
@@ -71,33 +75,116 @@ struct RoomProcList *rplist = NULL;
 struct NetMap *the_netmap = NULL;
 
 
-
-
-
-
 /*
  * Manage the use table.  This is a list of messages which have recently
  * arrived on the system.  It is maintained and queried to prevent the same
- * message from being entered into the  FIXME not finished
+ * message from being entered into the database multiple times if it happens
+ * to arrive multiple times by accident.
  */
 int network_usetable(int operation, struct CtdlMessage *msg) {
 
        static struct UseTable *ut = NULL;
        struct UseTable *uptr = NULL;
+       char *serialized_table = NULL;
+       char msgid[SIZ];
+       char buf[SIZ];
+       int i;
+       size_t stlen = 0;
 
        switch(operation) {
        
                case UT_LOAD:
-                       return(1);
-                       break;
+                       serialized_table = CtdlGetSysConfig(USETABLE);
+                       if (serialized_table == NULL) return(0);
+
+                       for (i=0; i<num_tokens(serialized_table, '\n'); ++i) {
+                               extract_token(buf, serialized_table, i, '\n');
+                               uptr = (struct UseTable *)
+                                       mallok(sizeof(struct UseTable));
+                               if (uptr != NULL) {
+                                       uptr->next = ut;
+                                       extract(msgid, buf, 0);
+                                       uptr->message_id = strdoop(msgid);
+                                       uptr->timestamp = extract_long(buf, 1);
+                                       ut = uptr;
+                               }
+                       }
 
-               case UT_SAVE:
-                       return(1);
-                       break;
+                       phree(serialized_table);
+                       serialized_table = NULL;
+                       return(0);
 
                case UT_INSERT:
-                       return(1);
-                       break;
+                       /* Bail out if we can't generate a message ID */
+                       if (msg == NULL) {
+                               return(0);
+                       }
+                       if (msg->cm_fields['I'] == NULL) {
+                               return(0);
+                       }
+                       if (strlen(msg->cm_fields['I']) == 0) {
+                               return(0);
+                       }
+
+                       /* Generate the message ID */
+                       strcpy(msgid, msg->cm_fields['I']);
+                       if (haschar(msgid, '@') == 0) {
+                               strcat(msgid, "@");
+                               if (msg->cm_fields['N'] != NULL) {
+                                       strcat(msgid, msg->cm_fields['N']);
+                               }
+                               else {
+                                       return(0);
+                               }
+                       }
+
+                       /* Compare to the existing list */
+                       for (uptr = ut; uptr != NULL; uptr = uptr->next) {
+                               if (!strcasecmp(msgid, uptr->message_id)) {
+                                       return(1);
+                               }
+                       }
+
+                       /* If we got to this point, it's unique: add it. */
+                       uptr = (struct UseTable *)
+                               mallok(sizeof(struct UseTable));
+                       if (uptr == NULL) return(0);
+                       uptr->next = ut;
+                       uptr->message_id = strdoop(msgid);
+                       uptr->timestamp = time(NULL);
+                       ut = uptr;
+                       return(0);
+
+               case UT_SAVE:
+                       /* Figure out how big the serialized buffer should be */
+                       stlen = 0;
+                       for (uptr = ut; uptr != NULL; uptr = uptr->next) {
+                               stlen = stlen + strlen(uptr->message_id) + 20;
+                       }
+                       serialized_table = mallok(stlen);
+                       memset(serialized_table, 0, stlen);
+
+                       while (ut != NULL) {
+                               if ( (serialized_table != NULL) 
+                                  && ( (ut->timestamp - time(NULL)) <
+                                     USETABLE_RETAIN) ) {
+                                       sprintf(&serialized_table[strlen(
+                                         serialized_table)], "%s|%ld\n",
+                                           ut->message_id,
+                                           (long)ut->timestamp);
+                               }
+
+                               /* Now free the memory */
+                               uptr = ut;
+                               ut = ut->next;
+                               phree(uptr->message_id);
+                               phree(uptr);
+                       }
+
+                       /* Write to disk */
+                       CtdlPutSysConfig(USETABLE, serialized_table);
+                       phree(serialized_table);
+                       return(0);
 
        }
 
@@ -150,7 +237,7 @@ void write_network_map(void) {
                                sprintf(&serialized_map[strlen(serialized_map)],
                                        "%s|%ld|%s\n",
                                        nmptr->nodename,
-                                       nmptr->lastcontact,
+                                       (long)nmptr->lastcontact,
                                        nmptr->nexthop);
                        }
                }
@@ -359,7 +446,7 @@ void network_spool_msg(long msgnum, void *userdata) {
                sprintf(instr,
                        "Content-type: %s\n\nmsgid|%ld\nsubmitted|%ld\n"
                        "bounceto|postmaster@%s\n" ,
-                       SPOOLMIME, msgnum, time(NULL), config.c_fqdn );
+                       SPOOLMIME, msgnum, (long)time(NULL), config.c_fqdn );
        
                /* Generate delivery instructions for each recipient */
                for (nptr = sc->listrecps; nptr != NULL; nptr = nptr->next) {
@@ -648,7 +735,7 @@ void network_bounce(struct CtdlMessage *msg, char *reason) {
                phree(msg->cm_fields['I']);
        }
        sprintf(buf, "%ld.%04x.%04x@%s",
-               time(NULL), getpid(), ++serialnum, config.c_fqdn);
+               (long)time(NULL), getpid(), ++serialnum, config.c_fqdn);
        msg->cm_fields['I'] = strdoop(buf);
 
        /*
@@ -744,6 +831,7 @@ void network_process_buffer(char *buffer, long size) {
        char *oldpath = NULL;
        char filename[SIZ];
        FILE *fp;
+       char buf[SIZ];
 
        /* Set default target room to trash */
        strcpy(target_room, TWITROOM);
@@ -813,7 +901,17 @@ void network_process_buffer(char *buffer, long size) {
                }
        }
 
-       /* FIXME check to see if we already have this message */
+       /*
+        * Check to see if we already have a copy of this message
+        */
+       if (network_usetable(UT_INSERT, msg) != 0) {
+               sprintf(buf, "Loopzapper rejected message <%s>\n",
+                       msg->cm_fields['I']);
+               aide_message(buf);
+               CtdlFreeMessage(msg);
+               msg = NULL;
+               return;
+       }
 
        /* Learn network topology from the path */
        if ((msg->cm_fields['N'] != NULL) && (msg->cm_fields['P'] != NULL)) {
@@ -1213,9 +1311,10 @@ void network_do_queue(void) {
        network_poll_other_citadel_nodes();
 
        /*
-        * Load the network map into memory.
+        * Load the network map and use table into memory.
         */
        read_network_map();
+       network_usetable(UT_LOAD, NULL);
 
        /* 
         * Go ahead and run the queue
@@ -1234,6 +1333,8 @@ void network_do_queue(void) {
        lprintf(7, "network: processing inbound queue\n");
        network_do_spoolin();
 
+       /* Save the usetable and network map back to disk */
+       network_usetable(UT_SAVE, NULL);
        write_network_map();
 
        lprintf(7, "network: queue run completed\n");