]> code.citadel.org Git - citadel.git/blobdiff - citadel/sysdep.c
threads are using signals and the GC code is #ifdef if available.
[citadel.git] / citadel / sysdep.c
index 265f879e7838eff771687237610a320512a7b961..13c5c908928ba9b9948154f1c86e3de2be41a829 100644 (file)
@@ -2,7 +2,7 @@
  * $Id$
  *
  * Citadel "system dependent" stuff.
- * See copyright.txt for copyright information.
+ * See COPYING for copyright information.
  *
  * Here's where we (hopefully) have most parts of the Citadel server that
  * would need to be altered to run the server in a non-POSIX environment.
@@ -60,6 +60,7 @@
 #include "housekeeping.h"
 #include "modules/crypto/serv_crypto.h"        /* Needed for init_ssl, client_write_ssl, client_read_ssl, destruct_ssl */
 #include "ecrash.h"
+#include "context.h"
 
 #ifdef HAVE_SYS_SELECT_H
 #include <sys/select.h>
@@ -71,6 +72,9 @@
 
 #include "ctdl_module.h"
 #include "threads.h"
+#include "user_ops.h"
+#include "control.h"
+
 
 #ifdef DEBUG_MEMORY_LEAKS
 struct igheap {
@@ -84,14 +88,8 @@ struct igheap *igheap = NULL;
 #endif
 
 
-citthread_key_t MyConKey;                              /* TSD key for MyContext() */
-
 int verbosity = DEFAULT_VERBOSITY;             /* Logging level */
 
-struct CitContext masterCC;
-time_t last_purge = 0;                         /* Last dead session purge */
-int num_sessions = 0;                          /* Current number of sessions */
-
 int syslog_facility = LOG_DAEMON;
 int enable_syslog = 0;
 
@@ -122,18 +120,19 @@ void vCtdlLogPrintf(enum LogLevel loglevel, const char *format, va_list arg_ptr)
                struct timeval tv;
                struct tm tim;
                time_t unixtime;
+               CitContext *CCC = CC;
 
                gettimeofday(&tv, NULL);
                /* Promote to time_t; types differ on some OSes (like darwin) */
                unixtime = tv.tv_sec;
                localtime_r(&unixtime, &tim);
-               if (CC->cs_pid != 0) {
+               if ((CCC != NULL) && (CCC->cs_pid != 0)) {
                        sprintf(buf,
                                "%04d/%02d/%02d %2d:%02d:%02d.%06ld [%3d] ",
                                tim.tm_year + 1900, tim.tm_mon + 1,
                                tim.tm_mday, tim.tm_hour, tim.tm_min,
                                tim.tm_sec, (long)tv.tv_usec,
-                               CC->cs_pid);
+                               CCC->cs_pid);
                } else {
                        sprintf(buf,
                                "%04d/%02d/%02d %2d:%02d:%02d.%06ld ",
@@ -160,11 +159,10 @@ volatile int restart_server = 0;
 volatile int running_as_daemon = 0;
 
 static RETSIGTYPE signal_cleanup(int signum) {
-#ifdef THREADS_USESIGNALS
+
        if (CT)
                CT->signal = signum;
        else
-#endif
        {
                CtdlLogPrintf(CTDL_DEBUG, "Caught signal %d; shutting down.\n", signum);
                exit_signal = signum;
@@ -326,12 +324,15 @@ int ig_uds_server(char *sockpath, int queue_len, char **errormessage)
        int s;
        int i;
        int actual_queue_len;
+#ifdef HAVE_STRUCT_UCRED
+       int passcred = 1;
+#endif
 
        actual_queue_len = queue_len;
        if (actual_queue_len < 5) actual_queue_len = 5;
 
        i = unlink(sockpath);
-       if (i != 0) if (errno != ENOENT) {
+       if ((i != 0) && (errno != ENOENT)) {
                *errormessage = (char*) malloc(SIZ + 1);
                snprintf(*errormessage, SIZ, "citserver: can't unlink %s: %s",
                        sockpath, strerror(errno));
@@ -382,6 +383,10 @@ int ig_uds_server(char *sockpath, int queue_len, char **errormessage)
                return(-1);
        }
 
+#ifdef HAVE_STRUCT_UCRED
+       setsockopt(s, SOL_SOCKET, SO_PASSCRED, &passcred, sizeof(passcred));
+#endif
+
        chmod(sockpath, S_ISGID|S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IROTH|S_IWOTH|S_IXOTH);
        return(s);
 }
@@ -389,84 +394,8 @@ int ig_uds_server(char *sockpath, int queue_len, char **errormessage)
 
 
 /*
- * Return a pointer to the CitContext structure bound to the thread which
- * called this function.  If there's no such binding (for example, if it's
- * called by the housekeeper thread) then a generic 'master' CC is returned.
- *
- * This function is used *VERY* frequently and must be kept small.
- */
-struct CitContext *MyContext(void) {
-
-       register struct CitContext *c;
-
-       return ((c = (struct CitContext *) citthread_getspecific(MyConKey),
-               c == NULL) ? &masterCC : c
-       );
-}
-
-
-/*
- * Initialize a new context and place it in the list.  The session number
- * used to be the PID (which is why it's called cs_pid), but that was when we
- * had one process per session.  Now we just assign them sequentially, starting
- * at 1 (don't change it to 0 because masterCC uses 0).
- */
-struct CitContext *CreateNewContext(void) {
-       struct CitContext *me;
-       static int next_pid = 0;
-
-       me = (struct CitContext *) malloc(sizeof(struct CitContext));
-       if (me == NULL) {
-               CtdlLogPrintf(CTDL_ALERT, "citserver: can't allocate memory!!\n");
-               return NULL;
-       }
-       memset(me, 0, sizeof(struct CitContext));
-
-       /* The new context will be created already in the CON_EXECUTING state
-        * in order to prevent another thread from grabbing it while it's
-        * being set up.
-        */
-       me->state = CON_EXECUTING;
-       /*
-        * Generate a unique session number and insert this context into
-        * the list.
-        */
-       begin_critical_section(S_SESSION_TABLE);
-       me->cs_pid = ++next_pid;
-       me->prev = NULL;
-       me->next = ContextList;
-       ContextList = me;
-       if (me->next != NULL) {
-               me->next->prev = me;
-       }
-       ++num_sessions;
-       end_critical_section(S_SESSION_TABLE);
-       return (me);
-}
-
-
-struct CitContext *CtdlGetContextArray(int *count)
-{
-       int nContexts, i;
-       struct CitContext *nptr, *cptr;
-       
-       nContexts = num_sessions;
-       nptr = malloc(sizeof(struct CitContext) * nContexts);
-       if (!nptr)
-               return NULL;
-       begin_critical_section(S_SESSION_TABLE);
-       for (cptr = ContextList, i=0; cptr != NULL && i < nContexts; cptr = cptr->next, i++)
-               memcpy(&nptr[i], cptr, sizeof (struct CitContext));
-       end_critical_section (S_SESSION_TABLE);
-       
-       *count = i;
-       return nptr;
-}
-
-/*
- * The following functions implement output buffering. If the kernel supplies
- * native TCP buffering (Linux & *BSD), use that; otherwise, emulate it with
- * user-space buffering.
+ * The following functions implement output buffering on operating systems which
+ * support it (such as Linux and various BSD flavors).
  */
 #ifndef HAVE_DARWIN
 #ifdef TCP_CORK
@@ -479,64 +408,33 @@ struct CitContext *CtdlGetContextArray(int *count)
 #endif /* TCP_CORK */
 #endif /* HAVE_DARWIN */
 
-#ifdef HAVE_TCP_BUFFERING
 static unsigned on = 1, off = 0;
-void buffer_output(void) {
-       struct CitContext *ctx = MyContext();
-       setsockopt(ctx->client_socket, IPPROTO_TCP, TCP_CORK, &on, 4);
-       ctx->buffering = 1;
-}
 
-void unbuffer_output(void) {
-       struct CitContext *ctx = MyContext();
-       setsockopt(ctx->client_socket, IPPROTO_TCP, TCP_CORK, &off, 4);
-       ctx->buffering = 0;
-}
-
-void flush_output(void) {
-       struct CitContext *ctx = MyContext();
-       setsockopt(ctx->client_socket, IPPROTO_TCP, TCP_CORK, &off, 4);
-       setsockopt(ctx->client_socket, IPPROTO_TCP, TCP_CORK, &on, 4);
-}
-#else 
-#ifdef HAVE_DARWIN
-/* Stub functions for Darwin/OS X where TCP buffering isn't liked at all */
 void buffer_output(void) {
-       CC->buffering = 0;
+#ifdef HAVE_TCP_BUFFERING
+#ifdef HAVE_OPENSSL
+       if (!CC->redirect_ssl)
+#endif
+               setsockopt(CC->client_socket, IPPROTO_TCP, TCP_CORK, &on, 4);
+#endif
 }
+
 void unbuffer_output(void) {
-       CC->buffering = 0;
-}
-void flush_output(void) {
-}
-#else
-void buffer_output(void) {
-       if (CC->buffering == 0) {
-               CC->buffering = 1;
-               CC->buffer_len = 0;
-               CC->output_buffer = malloc(SIZ);
-       }
+#ifdef HAVE_TCP_BUFFERING
+#ifdef HAVE_OPENSSL
+       if (!CC->redirect_ssl)
+#endif
+               setsockopt(CC->client_socket, IPPROTO_TCP, TCP_CORK, &off, 4);
+#endif
 }
 
 void flush_output(void) {
-       if (CC->buffering == 1) {
-               client_write(CC->output_buffer, CC->buffer_len);
-               CC->buffer_len = 0;
-       }
-}
-
-void unbuffer_output(void) {
-       if (CC->buffering == 1) {
-               CC->buffering = 0;
-               /* We don't call flush_output because we can't. */
-               client_write(CC->output_buffer, CC->buffer_len);
-               CC->buffer_len = 0;
-               free(CC->output_buffer);
-               CC->output_buffer = NULL;
-       }
+#ifdef HAVE_TCP_BUFFERING
+       struct CitContext *CCC = CC;
+       setsockopt(CCC->client_socket, IPPROTO_TCP, TCP_CORK, &off, 4);
+       setsockopt(CCC->client_socket, IPPROTO_TCP, TCP_CORK, &on, 4);
+#endif
 }
-#endif /* HAVE_DARWIN */
-#endif /* HAVE_TCP_BUFFERING */
 
 
 
@@ -551,7 +449,7 @@ int client_write(char *buf, int nbytes)
        int old_buffer_len = 0;
 #endif
        fd_set wset;
-       t_context *Ctx;
+       CitContext *Ctx;
        int fdflags;
 
        Ctx = CC;
@@ -567,19 +465,6 @@ int client_write(char *buf, int nbytes)
                return 0;
        }
 
-#ifndef HAVE_TCP_BUFFERING
-       /* If we're buffering for later, do that now. */
-       if (Ctx->buffering) {
-               old_buffer_len = Ctx->buffer_len;
-               Ctx->buffer_len += nbytes;
-               Ctx->output_buffer = realloc(Ctx->output_buffer, Ctx->buffer_len);
-               memcpy(&Ctx->output_buffer[old_buffer_len], buf, nbytes);
-               return 0;
-       }
-#endif
-
-       /* Ok, at this point we're not buffering.  Go ahead and write. */
-
 #ifdef HAVE_OPENSSL
        if (Ctx->redirect_ssl) {
                client_write_ssl(buf, nbytes);
@@ -594,13 +479,25 @@ int client_write(char *buf, int nbytes)
                        FD_ZERO(&wset);
                        FD_SET(Ctx->client_socket, &wset);
                        if (select(1, NULL, &wset, NULL, NULL) == -1) {
-                               CtdlLogPrintf(CTDL_ERR,
-                                       "client_write(%d bytes) select failed: %s (%d)\n",
-                                       nbytes - bytes_written,
-                                       strerror(errno), errno);
-                               cit_backtrace();
-                               Ctx->kill_me = 1;
-                               return -1;
+                               if (errno == EINTR)
+                               {
+                                       CtdlLogPrintf(CTDL_DEBUG, "client_write(%d bytes) select() interrupted.\n", nbytes-bytes_written);
+                                       if (CtdlThreadCheckStop()) {
+                                               CC->kill_me = 1;
+                                               return (-1);
+                                       } else {
+                                               /* can't trust fd's and stuff so we need to re-create them */
+                                               continue;
+                                       }
+                               } else {
+                                       CtdlLogPrintf(CTDL_ERR,
+                                               "client_write(%d bytes) select failed: %s (%d)\n",
+                                               nbytes - bytes_written,
+                                               strerror(errno), errno);
+                                       cit_backtrace();
+                                       Ctx->kill_me = 1;
+                                       return -1;
+                               }
                        }
                }
 
@@ -623,13 +520,12 @@ int client_write(char *buf, int nbytes)
 
 
 /*
- * cprintf()  ...   Send formatted printable data to the client.   It is
- *               implemented in terms of client_write() but remains in
- *               sysdep.c in case we port to somewhere without va_args...
+ * cprintf()   Send formatted printable data to the client.
+ *             Implemented in terms of client_write() so it's technically not sysdep...
  */
 void cprintf(const char *format, ...) {   
        va_list arg_ptr;   
-       char buf[1024];   
+       char buf[1024];
    
        va_start(arg_ptr, format);   
        if (vsnprintf(buf, sizeof buf, format, arg_ptr) == -1)
@@ -674,7 +570,17 @@ int client_read_to(char *buf, int bytes, int timeout)
                {
                        if (errno == EINTR)
                        {
-                               CtdlLogPrintf(CTDL_DEBUG, "Interrupted select().\n");
+                               CtdlLogPrintf(CTDL_DEBUG, "Interrupted select() in client_read_to().\n");
+                               if (CtdlThreadCheckStop()) {
+                                       CC->kill_me = 1;
+                                       return (-1);
+                               } else {
+                                       /* can't trust fd's and stuff so we need to re-create them */
+                                       continue;
+                               }
+                       }
+                       else {
+                               CtdlLogPrintf(CTDL_DEBUG, "Failed select() in client_read_to().\n");
                                CC->kill_me = 1;
                                return (-1);
                        }
@@ -746,36 +652,6 @@ int client_getln(char *buf, int bufsize)
 /*
  * Cleanup any contexts that are left lying around
  */
-void context_cleanup(void)
-{
-       struct CitContext *ptr = NULL;
-       struct CitContext *rem = NULL;
-
-       /*
-        * Clean up the contexts.
-        * There are no threads so no critical_section stuff is needed.
-        */
-       ptr = ContextList;
-       
-       /* We need to update the ContextList because some modules may want to itterate it
-        * Question is should we NULL it before iterating here or should we just keep updating it
-        * as we remove items?
-        *
-        * Answer is to NULL it first to prevent modules from doing any actions on the list at all
-        */
-       ContextList=NULL;
-       while (ptr != NULL){
-               /* Remove the session from the active list */
-               rem = ptr->next;
-               --num_sessions;
-               
-               CtdlLogPrintf(CTDL_DEBUG, "Purging session %d\n", ptr->cs_pid);
-               RemoveContext(ptr);
-               free (ptr);
-               ptr = rem;
-       }
-}
-
 
 
 void close_masters (void)
@@ -832,7 +708,6 @@ void sysdep_master_cleanup(void) {
        CtdlDestroySessionHooks();
        CtdlDestroyServiceHook();
        CtdlDestroyRoomHooks();
-       CtdlDestroyDirectoryServiceFuncs();
        #ifdef HAVE_BACKTRACE
        eCrash_Uninit();
        #endif
@@ -840,23 +715,6 @@ void sysdep_master_cleanup(void) {
 
 
 
-/*
- * Terminate another session.
- * (This could justifiably be moved out of sysdep.c because it
- * no longer does anything that is system-dependent.)
- */
-void kill_session(int session_to_kill) {
-       struct CitContext *ptr;
-
-       begin_critical_section(S_SESSION_TABLE);
-       for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-               if (ptr->cs_pid == session_to_kill) {
-                       ptr->kill_me = 1;
-               }
-       }
-       end_critical_section(S_SESSION_TABLE);
-}
-
 pid_t current_child;
 void graceful_shutdown(int signum) {
        kill(current_child, signum);
@@ -864,6 +722,9 @@ void graceful_shutdown(int signum) {
        exit(0);
 }
 
+int nFireUps = 0;
+int nFireUpsNonRestart = 0;
+pid_t ForkedPid = 1;
 
 /*
  * Start running as a daemon.
@@ -919,31 +780,24 @@ void start_daemon(int unused) {
                        }
                        waitpid(current_child, &status, 0);
                }
-
                do_restart = 0;
+               nFireUpsNonRestart = nFireUps;
+               
+               /* Exit code 0 means the watcher should exit */
+               if (WIFEXITED(status) && (WEXITSTATUS(status) == CTDLEXIT_SHUTDOWN)) {
+                       do_restart = 0;
+               }
 
-               /* Did the main process exit with an actual exit code? */
-               if (WIFEXITED(status)) {
-
-                       /* Exit code 0 means the watcher should exit */
-                       if (WEXITSTATUS(status) == 0) {
-                               do_restart = 0;
-                       }
-
-                       /* Exit code 101-109 means the watcher should exit */
-                       else if ( (WEXITSTATUS(status) >= 101) && (WEXITSTATUS(status) <= 109) ) {
-                               do_restart = 0;
-                       }
-
-                       /* Any other exit code means we should restart. */
-                       else {
-                               do_restart = 1;
-                       }
+               /* Exit code 101-109 means the watcher should exit */
+               else if (WIFEXITED(status) && (WEXITSTATUS(status) >= 101) && (WEXITSTATUS(status) <= 109)) {
+                       do_restart = 0;
                }
 
-               /* Any other type of termination (signals, etc.) should also restart. */
+               /* Any other exit code, or no exit code, means we should restart. */
                else {
                        do_restart = 1;
+                       nFireUps++;
+                       ForkedPid = current_child;
                }
 
        } while (do_restart);
@@ -954,6 +808,33 @@ void start_daemon(int unused) {
 
 
 
+void checkcrash(void)
+{
+       if (nFireUpsNonRestart != nFireUps)
+       {
+               StrBuf *CrashMail;
+
+               CrashMail = NewStrBuf();
+               CtdlLogPrintf(CTDL_ALERT, "Posting crash message\n");
+               StrBufPrintf(CrashMail, 
+                       " \n"
+                       " The Citadel server process (citserver) terminated unexpectedly."
+                       "\n \n"
+                       " This could be the result of a bug in the server program, or some external "
+                       "factor.\n \n"
+                       " You can obtain more information about this by enabling core dumps.\n \n"
+                       " For more information, please see:\n \n"
+                       " http://citadel.org/doku.php/faq:mastering_your_os:gdb#how.do.i.make.my.system.produce.core-files"
+                       "\n \n"
+                       " If you have already done this, the core dump is likely to be found at %score.%d\n"
+                       ,
+                       ctdl_run_dir, ForkedPid);
+               CtdlAideMessage(ChrPtr(CrashMail), "Citadel server process terminated unexpectedly");
+               FreeStrBuf(&CrashMail);
+       }
+}
+
+
 /*
  * Generic routine to convert a login name to a full name (gecos)
  * Returns nonzero if a conversion took place
@@ -975,89 +856,6 @@ int convert_login(char NameToConvert[]) {
        }
 }
 
-/*
- * Purge all sessions which have the 'kill_me' flag set.
- * This function has code to prevent it from running more than once every
- * few seconds, because running it after every single unbind would waste a lot
- * of CPU time and keep the context list locked too much.  To force it to run
- * anyway, set "force" to nonzero.
- */
-void dead_session_purge(int force) {
-       struct CitContext *ptr, *ptr2;          /* general-purpose utility pointer */
-       struct CitContext *rem = NULL;  /* list of sessions to be destroyed */
-       
-       if (force == 0) {
-               if ( (time(NULL) - last_purge) < 5 ) {
-                       return; /* Too soon, go away */
-               }
-       }
-       time(&last_purge);
-
-       if (try_critical_section(S_SESSION_TABLE))
-               return;
-               
-       ptr = ContextList;
-       while (ptr) {
-               ptr2 = ptr;
-               ptr = ptr->next;
-               
-               if ( (ptr2->state == CON_IDLE) && (ptr2->kill_me) ) {
-                       /* Remove the session from the active list */
-                       if (ptr2->prev) {
-                               ptr2->prev->next = ptr2->next;
-                       }
-                       else {
-                               ContextList = ptr2->next;
-                       }
-                       if (ptr2->next) {
-                               ptr2->next->prev = ptr2->prev;
-                       }
-
-                       --num_sessions;
-                       /* And put it on our to-be-destroyed list */
-                       ptr2->next = rem;
-                       rem = ptr2;
-               }
-       }
-       end_critical_section(S_SESSION_TABLE);
-
-       /* Now that we no longer have the session list locked, we can take
-        * our time and destroy any sessions on the to-be-killed list, which
-        * is allocated privately on this thread's stack.
-        */
-       while (rem != NULL) {
-               CtdlLogPrintf(CTDL_DEBUG, "Purging session %d\n", rem->cs_pid);
-               RemoveContext(rem);
-               ptr = rem;
-               rem = rem->next;
-               free(ptr);
-       }
-}
-
-
-
-
-
-/*
- * masterCC is the context we use when not attached to a session.  This
- * function initializes it.
- */
-void InitializeMasterCC(void) {
-       memset(&masterCC, 0, sizeof(struct CitContext));
-       masterCC.internal_pgm = 1;
-       masterCC.cs_pid = 0;
-}
-
-
-
-
-/*
- * Bind a thread to a context.  (It's inline merely to speed things up.)
- */
-INLINE void become_session(struct CitContext *which_con) {
-       citthread_setspecific(MyConKey, (void *)which_con );
-}
-
 
 
 /* 
@@ -1089,18 +887,13 @@ INLINE void become_session(struct CitContext *which_con) {
  */
  
 void *worker_thread(void *arg) {
-       int i;
        int highest;
-       struct CitContext *ptr;
-       struct CitContext *bind_me = NULL;
+       CitContext *ptr;
+       CitContext *bind_me = NULL;
        fd_set readfds;
        int retval = 0;
-       struct CitContext *con= NULL;   /* Temporary context pointer */
-       struct ServiceFunctionHook *serviceptr;
-       int ssock;                      /* Descriptor for client socket */
        struct timeval tv;
        int force_purge = 0;
-       int m;
        
 
        while (!CtdlThreadCheckStop()) {
@@ -1118,7 +911,8 @@ do_select: force_purge = 0;
 
                begin_critical_section(S_SESSION_TABLE);
                for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-                       if (ptr->state == CON_IDLE) {
+                       /* Dont select on dead sessions only truly idle ones */
+                       if ((ptr->state == CON_IDLE)) {
                                FD_SET(ptr->client_socket, &readfds);
                                if (ptr->client_socket > highest)
                                        highest = ptr->client_socket;
@@ -1126,6 +920,11 @@ do_select:        force_purge = 0;
                        if ((bind_me == NULL) && (ptr->state == CON_READY)) {
                                bind_me = ptr;
                                ptr->state = CON_EXECUTING;
+                               break;
+                       }
+                       if ((bind_me == NULL) && (ptr->state == CON_STARTING)) {
+                               bind_me = ptr;
+                               break;
                        }
                }
                end_critical_section(S_SESSION_TABLE);
@@ -1139,20 +938,134 @@ do_select:      force_purge = 0;
                 * ahead and get ready to select().
                 */
 
+               if (!CtdlThreadCheckStop()) {
+                       tv.tv_sec = 1;          /* wake up every second if no input */
+                       tv.tv_usec = 0;
+                       retval = CtdlThreadSelect(highest + 1, &readfds, NULL, NULL, &tv);
+               }
+               else
+                       return NULL;
+
+               /* Now figure out who made this select() unblock.
+                * First, check for an error or exit condition.
+                */
+               if (retval < 0) {
+                       if (errno == EBADF) {
+                               CtdlLogPrintf(CTDL_NOTICE, "select() failed: (%s)\n",
+                                       strerror(errno));
+                               goto do_select;
+                       }
+                       if (errno != EINTR) {
+                               CtdlLogPrintf(CTDL_EMERG, "Exiting (%s)\n", strerror(errno));
+                               CtdlThreadStopAll();
+                               continue;
+                       } else {
+                               CtdlLogPrintf(CTDL_DEBUG, "Interrupted CtdlThreadSelect.\n");
+                               if (CtdlThreadCheckStop()) return(NULL);
+                               goto do_select;
+                       }
+               }
+               else if(retval == 0) {
+                       if (CtdlThreadCheckStop()) return(NULL);
+               }
+
+               /* It must be a client socket.  Find a context that has data
+                * waiting on its socket *and* is in the CON_IDLE state.  Any
+                * active sockets other than our chosen one are marked as
+                * CON_READY so the next thread that comes around can just bind
+                * to one without having to select() again.
+                */
+               begin_critical_section(S_SESSION_TABLE);
+               for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
+                       if ( (FD_ISSET(ptr->client_socket, &readfds))
+                          && (ptr->state != CON_EXECUTING) ) {
+                               ptr->input_waiting = 1;
+                               if (!bind_me) {
+                                       bind_me = ptr;  /* I choose you! */
+                                       bind_me->state = CON_EXECUTING;
+                               }
+                               else {
+                                       ptr->state = CON_READY;
+                               }
+                       }
+               }
+               end_critical_section(S_SESSION_TABLE);
+
+SKIP_SELECT:
+               /* We're bound to a session */
+               if (bind_me != NULL) {
+                       become_session(bind_me);
+
+                       if (bind_me->state == CON_STARTING) {
+                               bind_me->state = CON_EXECUTING;
+                               begin_session(bind_me);
+                               bind_me->h_greeting_function();
+                       }
+                       /* If the client has sent a command, execute it. */
+                       if (CC->input_waiting) {
+                               CC->h_command_function();
+                               CC->input_waiting = 0;
+                       }
+
+                       /* If there are asynchronous messages waiting and the
+                        * client supports it, do those now */
+                       if ((CC->is_async) && (CC->async_waiting)
+                          && (CC->h_async_function != NULL)) {
+                               CC->h_async_function();
+                               CC->async_waiting = 0;
+                       }
+                       
+                       force_purge = CC->kill_me;
+                       become_session(NULL);
+                       bind_me->state = CON_IDLE;
+               }
+
+               dead_session_purge(force_purge);
+               do_housekeeping();
+       }
+       /* If control reaches this point, the server is shutting down */        
+       return(NULL);
+}
+
+
+
+
+/*
+ * A function to handle selecting on master sockets.
+ * In other words it handles new connections.
+ * It is a thread.
+ */
+void *select_on_master (void *arg)
+{
+       struct ServiceFunctionHook *serviceptr;
+       fd_set master_fds;
+       int highest;
+       struct timeval tv;
+       int ssock;                      /* Descriptor for client socket */
+       CitContext *con= NULL;  /* Temporary context pointer */
+       int m;
+       int i;
+       int retval;
+
+       while (!CtdlThreadCheckStop()) {
+               /* Initialize the fdset. */
+               FD_ZERO(&master_fds);
+               highest = 0;
+
                /* First, add the various master sockets to the fdset. */
                for (serviceptr = ServiceHookTable; serviceptr != NULL;
                serviceptr = serviceptr->next ) {
                        m = serviceptr->msock;
-                       FD_SET(m, &readfds);
+                       FD_SET(m, &master_fds);
                        if (m > highest) {
                                highest = m;
                        }
                }
 
                if (!CtdlThreadCheckStop()) {
-                       tv.tv_sec = 1;          /* wake up every second if no input */
+                       tv.tv_sec = 60;         /* wake up every second if no input */
                        tv.tv_usec = 0;
-                       retval = CtdlThreadSelect(highest + 1, &readfds, NULL, NULL, &tv);
+                       retval = CtdlThreadSelect(highest + 1, &master_fds, NULL, NULL, &tv);
                }
                else
                        return NULL;
@@ -1164,7 +1077,7 @@ do_select:        force_purge = 0;
                        if (errno == EBADF) {
                                CtdlLogPrintf(CTDL_NOTICE, "select() failed: (%s)\n",
                                        strerror(errno));
-                               goto do_select;
+                               continue;
                        }
                        if (errno != EINTR) {
                                CtdlLogPrintf(CTDL_EMERG, "Exiting (%s)\n", strerror(errno));
@@ -1172,12 +1085,12 @@ do_select:      force_purge = 0;
                        } else {
                                CtdlLogPrintf(CTDL_DEBUG, "Interrupted CtdlThreadSelect.\n");
                                if (CtdlThreadCheckStop()) return(NULL);
-                               goto do_select;
+                               continue;
                        }
                }
                else if(retval == 0) {
                        if (CtdlThreadCheckStop()) return(NULL);
-                       goto SKIP_SELECT;
+                       continue;
                }
                /* Next, check to see if it's a new client connecting
                 * on a master socket.
@@ -1185,7 +1098,7 @@ do_select:        force_purge = 0;
                else for (serviceptr = ServiceHookTable; serviceptr != NULL;
                     serviceptr = serviceptr->next ) {
 
-                       if (FD_ISSET(serviceptr->msock, &readfds)) {
+                       if (FD_ISSET(serviceptr->msock, &master_fds)) {
                                ssock = accept(serviceptr->msock, NULL, 0);
                                if (ssock >= 0) {
                                        CtdlLogPrintf(CTDL_DEBUG,
@@ -1213,6 +1126,7 @@ do_select:        force_purge = 0;
                                                serviceptr->h_command_function;
                                        con->h_async_function =
                                                serviceptr->h_async_function;
+                                       con->h_greeting_function = serviceptr->h_greeting_function;
                                        con->ServiceName =
                                                serviceptr->ServiceName;
                                        
@@ -1226,72 +1140,20 @@ do_select:      force_purge = 0;
                                                SO_REUSEADDR,
                                                &i, sizeof(i));
 
-                                       become_session(con);
-                                       begin_session(con);
-                                       serviceptr->h_greeting_function();
-                                       become_session(NULL);
-                                       con->state = CON_IDLE;
-                                       goto do_select;
-                               }
-                       }
-               }
+                                       con->state = CON_STARTING;
 
-               /* It must be a client socket.  Find a context that has data
-                * waiting on its socket *and* is in the CON_IDLE state.  Any
-                * active sockets other than our chosen one are marked as
-                * CON_READY so the next thread that comes around can just bind
-                * to one without having to select() again.
-                */
-               begin_critical_section(S_SESSION_TABLE);
-               for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-                       if ( (FD_ISSET(ptr->client_socket, &readfds))
-                          && (ptr->state != CON_EXECUTING) ) {
-                               ptr->input_waiting = 1;
-                               if (!bind_me) {
-                                       bind_me = ptr;  /* I choose you! */
-                                       bind_me->state = CON_EXECUTING;
-                               }
-                               else {
-                                       ptr->state = CON_READY;
+                                       retval--;
+                                       if (retval == 0)
+                                               break;
                                }
                        }
                }
-               end_critical_section(S_SESSION_TABLE);
-
-SKIP_SELECT:
-               /* We're bound to a session */
-               if (bind_me != NULL) {
-                       become_session(bind_me);
-
-                       /* If the client has sent a command, execute it. */
-                       if (CC->input_waiting) {
-                               CC->h_command_function();
-                               CC->input_waiting = 0;
-                       }
-
-                       /* If there are asynchronous messages waiting and the
-                        * client supports it, do those now */
-                       if ((CC->is_async) && (CC->async_waiting)
-                          && (CC->h_async_function != NULL)) {
-                               CC->h_async_function();
-                               CC->async_waiting = 0;
-                       }
-                       
-                       force_purge = CC->kill_me;
-                       become_session(NULL);
-                       bind_me->state = CON_IDLE;
-               }
-
-               dead_session_purge(force_purge);
-               do_housekeeping();
        }
-       /* If control reaches this point, the server is shutting down */        
-       return(NULL);
+       return NULL;
 }
 
 
 
-
 /*
  * SyslogFacility()
  * Translate text facility name to syslog.h defined value.