]> code.citadel.org Git - citadel.git/blobdiff - citadel/sysdep.c
* Changed a lot of strncpy() calls to safestrncpy() and replaced most of their
[citadel.git] / citadel / sysdep.c
index 579b1f0d0b11f458a88ffdf50176eb9c3faab966..26d132b5fe9270e6d2618204a723495a98281be5 100644 (file)
@@ -34,6 +34,9 @@
 #include <stdarg.h>
 #include <syslog.h>
 #include <grp.h>
+#ifdef __GNUC__
+#include <malloc.h>
+#endif
 #ifdef HAVE_PTHREAD_H
 #include <pthread.h>
 #endif
@@ -64,7 +67,7 @@ pthread_mutex_t Critters[MAX_SEMAPHORES];     /* Things needing locking */
 pthread_key_t MyConKey;                                /* TSD key for MyContext() */
 
 int msock;                                     /* master listening socket */
-int verbosity = 3;                             /* Logging level */
+int verbosity = 9;                             /* Logging level */
 
 struct CitContext masterCC;
 
@@ -96,7 +99,11 @@ void *tracked_malloc(size_t tsize, char *tfile, int tline) {
        struct TheHeap *hptr;
 
        ptr = malloc(tsize);
-       if (ptr == NULL) return(NULL);
+       if (ptr == NULL) {
+               lprintf(3, "DANGER!  mallok(%d) at %s:%d failed!\n",
+                       tsize, tfile, tline);
+               return(NULL);
+       }
 
        hptr = (struct TheHeap *) malloc(sizeof(struct TheHeap));
        strcpy(hptr->h_file, tfile);
@@ -160,6 +167,10 @@ void dump_tracked() {
                cprintf("%20s %5d\n",
                        hptr->h_file, hptr->h_line);
                }
+#ifdef __GNUC__
+        malloc_stats();
+#endif
+
        cprintf("000\n");
        }
 #endif
@@ -385,7 +396,6 @@ struct CitContext *MyContext(void) {
 struct CitContext *CreateNewContext(void) {
        struct CitContext *me;
 
-       lprintf(9, "CreateNewContext: calling malloc()\n");
        me = (struct CitContext *) mallok(sizeof(struct CitContext));
        if (me == NULL) {
                lprintf(1, "citserver: can't allocate memory!!\n");
@@ -423,15 +433,14 @@ void InitMyContext(struct CitContext *con)
 /*
  * Remove a context from the context list.
  */
-void RemoveContext(struct CitContext *con)
+void RemoveContext(int con)
 {
-       struct CitContext *ptr;
+       struct CitContext *ptr = NULL;
+       struct CitContext *ToFree = NULL;
 
        lprintf(7, "Starting RemoveContext()\n");
-       lprintf(9, "Session count before RemoveContext is %d\n",
-               session_count());
-       if (con==NULL) {
-               lprintf(7, "WARNING: RemoveContext() called with null!\n");
+       if (con==0) {
+               lprintf(7, "WARNING: RemoveContext() called with 0!\n");
                return;
                }
 
@@ -440,29 +449,26 @@ void RemoveContext(struct CitContext *con)
         * so do not call it from within this loop.
         */
        begin_critical_section(S_SESSION_TABLE);
-       lprintf(7, "Closing socket %d\n", con->client_socket);
-       close(con->client_socket);
 
-       lprintf(9, "Dereferencing session context\n");
-       if (ContextList==con) {
+       if (ContextList->client_socket == con) {
+               ToFree = ContextList;
                ContextList = ContextList->next;
                }
        else {
                for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-                       if (ptr->next == con) {
-                               ptr->next = con->next;
+                       if (ptr->next->client_socket == con) {
+                               ToFree = ptr->next;
+                               ptr->next = ptr->next->next;
                                }
                        }
                }
 
-       lprintf(9, "Freeing session context...\n");     
-       phree(con);
-       lprintf(9, "...done.\n");
-       end_critical_section(S_SESSION_TABLE);
 
-       lprintf(9, "Session count after RemoveContext is %d\n",
-               session_count());
+       lprintf(7, "Closing socket %d\n", ToFree->client_socket);
+       close(ToFree->client_socket);
+       phree(ToFree);
 
+       end_critical_section(S_SESSION_TABLE);
        lprintf(7, "Done with RemoveContext\n");
        }
 
@@ -475,15 +481,12 @@ int session_count(void) {
        struct CitContext *ptr;
        int TheCount = 0;
 
-       lprintf(9, "session_count() starting\n");
        begin_critical_section(S_SESSION_TABLE);
        for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
                ++TheCount;
-               lprintf(9, "Counted session %3d (%d)\n", ptr->cs_pid, TheCount);
                }
        end_critical_section(S_SESSION_TABLE);
 
-       lprintf(9, "session_count() finishing\n");
        return(TheCount);
        }
 
@@ -634,7 +637,6 @@ void kill_session(int session_to_kill) {
        struct CitContext *ptr;
        THREAD killme = 0;
 
-       lprintf(9, "kill_session() scanning for thread to cancel...\n");
        begin_critical_section(S_SESSION_TABLE);
        for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
                if (ptr->cs_pid == session_to_kill) {
@@ -642,11 +644,9 @@ void kill_session(int session_to_kill) {
                        }
                }
        end_critical_section(S_SESSION_TABLE);
-       lprintf(9, "kill_session() finished scanning.\n");
 
        if (killme != 0) {
 #ifdef HAVE_PTHREAD_CANCEL
-               lprintf(9, "calling pthread_cancel()\n");
                pthread_cancel(killme);
 #else
                pthread_kill(killme, SIGUSR1);
@@ -793,6 +793,7 @@ int main(int argc, char **argv)
        int alen;                       /* Data for master socket */
        int ssock;                      /* Descriptor for master socket */
        THREAD SessThread;              /* Thread descriptor */
+       THREAD HousekeepingThread;      /* Thread descriptor */
         pthread_attr_t attr;           /* Thread attributes */
        struct CitContext *con;         /* Temporary context pointer */
        char tracefile[128];            /* Name of file to log traces to */
@@ -900,18 +901,29 @@ int main(int argc, char **argv)
                        }
                }
 
+       /*
+        * Do non system dependent startup functions.
+        */
+       master_startup();
+
+       /*
+        * Load any server-side modules (plugins) available here.
+        */
        lprintf(7, "Initializing loadable modules\n");
        if ((moddir = malloc(strlen(bbs_home_directory) + 9)) != NULL) {
                sprintf(moddir, "%s/modules", bbs_home_directory);
                DLoader_Init(moddir);
                free(moddir);
                }
-       lprintf(9, "Modules done initializing.\n");
 
-       /*
-        * Do non system dependent startup functions.
-        */
-       master_startup();
+       lprintf(7, "Starting housekeeper thread\n");
+       pthread_attr_init(&attr);
+               pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
+       if (pthread_create(&HousekeepingThread, &attr,
+          (void* (*)(void*)) housekeeping_loop, NULL) != 0) {
+               lprintf(1, "Can't create housekeeping thead: %s\n",
+                       strerror(errno));
+       }
 
        /* 
         * Endless loop.  Listen on the master socket.  When a connection
@@ -936,24 +948,20 @@ int main(int argc, char **argv)
                        }
                else {
                        lprintf(7, "citserver: Client socket %d\n", ssock);
-                       lprintf(9, "creating context\n");
                        con = CreateNewContext();
                        con->client_socket = ssock;
 
                        /* Set the SO_REUSEADDR socket option */
-                       lprintf(9, "setting socket options\n");
                        i = 1;
                        setsockopt(ssock, SOL_SOCKET, SO_REUSEADDR,
                                &i, sizeof(i));
 
                        /* set attributes for the new thread */
-                       lprintf(9, "setting thread attributes\n");
                        pthread_attr_init(&attr);
                        pthread_attr_setdetachstate(&attr,
                                PTHREAD_CREATE_DETACHED);
 
                        /* now create the thread */
-                       lprintf(9, "creating thread\n");
                        if (pthread_create(&SessThread, &attr,
                                           (void* (*)(void*)) sd_context_loop,
                                           con)
@@ -963,15 +971,6 @@ int main(int argc, char **argv)
                                        strerror(errno));
                                }
 
-                       /* detach the thread 
-                        * (defunct -- now done at thread creation time)
-                        * if (pthread_detach(&SessThread) != 0) {
-                        *      lprintf(1,
-                        *              "citserver: can't detach thread: %s\n",
-                        *              strerror(errno));
-                        *      }
-                        */
-                       lprintf(9, "done!\n");
                        }
                }
        master_cleanup();