]> code.citadel.org Git - citadel.git/blobdiff - citadel/sysdep.c
* Replaced all "Citadel/UX" references with "Citadel"
[citadel.git] / citadel / sysdep.c
index 9ec508e087021882395e0b09ecb894e5d02796f9..9c97ef21df290107394eef25b319dd3c2d80684d 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * $Id$
  *
- * Citadel/UX "system dependent" stuff.
+ * Citadel "system dependent" stuff.
  * See copyright.txt for copyright information.
  *
  * Here's where we (hopefully) have most parts of the Citadel server that
@@ -27,6 +27,7 @@
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
+#include <sys/syslog.h>
 
 #if TIME_WITH_SYS_TIME
 # include <sys/time.h>
@@ -47,7 +48,6 @@
 #include <pwd.h>
 #include <errno.h>
 #include <stdarg.h>
-#include <syslog.h>
 #include <grp.h>
 #ifdef HAVE_PTHREAD_H
 #include <pthread.h>
 #include "snprintf.h"
 #endif
 
+
 #ifdef DEBUG_MEMORY_LEAKS
-struct TheHeap *heap = NULL;
+struct igheap {
+       struct igheap *next;
+       char file[32];
+       int line;
+       void *block;
+};
+
+struct igheap *igheap = NULL;
 #endif
 
+
 pthread_mutex_t Critters[MAX_SEMAPHORES];      /* Things needing locking */
 pthread_key_t MyConKey;                                /* TSD key for MyContext() */
 
 int verbosity = DEFAULT_VERBOSITY;             /* Logging level */
 
 struct CitContext masterCC;
-int rescan[2];                                 /* The Rescan Pipe */
 time_t last_purge = 0;                         /* Last dead session purge */
 static int num_threads = 0;                    /* Current number of threads */
 int num_sessions = 0;                          /* Current number of sessions */
 
-fd_set masterfds;                              /* Master sockets etc. */
-int masterhighest;
-
 pthread_t initial_thread;              /* tid for main() thread */
 
+int syslog_facility = (-1);
+
 
 /*
  * lprintf()  ...   Write logging information
@@ -99,15 +106,26 @@ pthread_t initial_thread;          /* tid for main() thread */
  * Note: the variable "buf" below needs to be large enough to handle any
  * log data sent through this function.  BE CAREFUL!
  */
-void lprintf(int loglevel, const char *format, ...) {   
-        va_list arg_ptr;
+void lprintf(enum LogLevel loglevel, const char *format, ...) {   
+       va_list arg_ptr;
        char buf[SIZ];
-  
-        va_start(arg_ptr, format);   
-        vsnprintf(buf, sizeof(buf), format, arg_ptr);   
-        va_end(arg_ptr);   
-
-       if (loglevel <= verbosity) { 
+       va_start(arg_ptr, format);   
+       vsnprintf(buf, sizeof(buf), format, arg_ptr);   
+       va_end(arg_ptr);   
+
+       if (syslog_facility >= 0) {
+               if (loglevel <= verbosity) {
+                       /* Hackery -IO */
+                       if (CC && CC->cs_pid) {
+                               memmove(buf + 6, buf, sizeof(buf) - 6);
+                               snprintf(buf, 6, "[%3d]", CC->cs_pid);
+                               buf[5] = ' ';
+                       }
+                       syslog(loglevel, buf);
+               }
+       }
+       else if (loglevel <= verbosity) { 
                struct timeval tv;
                struct tm *tim;
                time_t unixtime;
@@ -122,18 +140,37 @@ void lprintf(int loglevel, const char *format, ...) {
                 * %03ld to %06ld and remove " / 1000" after tv.tv_usec.
                 */
                if (CC && CC->cs_pid) {
+#if 0
+                       /* Millisecond display */
                        fprintf(stderr,
                                "%04d/%02d/%02d %2d:%02d:%02d.%03ld [%3d] %s",
                                tim->tm_year + 1900, tim->tm_mon + 1,
                                tim->tm_mday, tim->tm_hour, tim->tm_min,
                                tim->tm_sec, (long)tv.tv_usec / 1000,
                                CC->cs_pid, buf);
+#endif
+                       /* Microsecond display */
+                       fprintf(stderr,
+                               "%04d/%02d/%02d %2d:%02d:%02d.%06ld [%3d] %s",
+                               tim->tm_year + 1900, tim->tm_mon + 1,
+                               tim->tm_mday, tim->tm_hour, tim->tm_min,
+                               tim->tm_sec, (long)tv.tv_usec,
+                               CC->cs_pid, buf);
                } else {
+#if 0
+                       /* Millisecond display */
                        fprintf(stderr,
                                "%04d/%02d/%02d %2d:%02d:%02d.%03ld %s",
                                tim->tm_year + 1900, tim->tm_mon + 1,
                                tim->tm_mday, tim->tm_hour, tim->tm_min,
                                tim->tm_sec, (long)tv.tv_usec / 1000, buf);
+#endif
+                       /* Microsecond display */
+                       fprintf(stderr,
+                               "%04d/%02d/%02d %2d:%02d:%02d.%06ld %s",
+                               tim->tm_year + 1900, tim->tm_mon + 1,
+                               tim->tm_mday, tim->tm_hour, tim->tm_min,
+                               tim->tm_sec, (long)tv.tv_usec, buf);
                }
                fflush(stderr);
        }
@@ -143,89 +180,6 @@ void lprintf(int loglevel, const char *format, ...) {
 
 
 
-#ifdef DEBUG_MEMORY_LEAKS
-void *tracked_malloc(size_t tsize, char *tfile, int tline) {
-       void *ptr;
-       struct TheHeap *hptr;
-
-       ptr = malloc(tsize);
-       if (ptr == NULL) {
-               lprintf(3, "DANGER!  mallok(%d) at %s:%d failed!\n",
-                       tsize, tfile, tline);
-               return(NULL);
-       }
-
-       hptr = (struct TheHeap *) malloc(sizeof(struct TheHeap));
-       strcpy(hptr->h_file, tfile);
-       hptr->h_line = tline;
-       hptr->next = heap;
-       hptr->h_ptr = ptr;
-       heap = hptr;
-       return ptr;
-}
-
-char *tracked_strdup(const char *orig, char *tfile, int tline) {
-       char *s;
-
-       s = tracked_malloc( (strlen(orig)+1), tfile, tline);
-       if (s == NULL) return NULL;
-
-       strcpy(s, orig);
-       return s;
-}
-
-void tracked_free(void *ptr) {
-       struct TheHeap *hptr, *freeme;
-
-       if (heap->h_ptr == ptr) {
-               hptr = heap->next;
-               free(heap);
-               heap = hptr;
-       }
-       else {
-               for (hptr=heap; hptr->next!=NULL; hptr=hptr->next) {
-                       if (hptr->next->h_ptr == ptr) {
-                               freeme = hptr->next;
-                               hptr->next = hptr->next->next;
-                               free(freeme);
-                       }
-               }
-       }
-
-       free(ptr);
-}
-
-void *tracked_realloc(void *ptr, size_t size) {
-       void *newptr;
-       struct TheHeap *hptr;
-       
-       newptr = realloc(ptr, size);
-
-       for (hptr=heap; hptr!=NULL; hptr=hptr->next) {
-               if (hptr->h_ptr == ptr) hptr->h_ptr = newptr;
-       }
-
-       return newptr;
-}
-
-
-void dump_tracked() {
-       struct TheHeap *hptr;
-
-       cprintf("%d Here's what's allocated...\n", LISTING_FOLLOWS);    
-       for (hptr=heap; hptr!=NULL; hptr=hptr->next) {
-               cprintf("%20s %5d\n",
-                       hptr->h_file, hptr->h_line);
-       }
-#ifdef __GNUC__
-        malloc_stats();
-#endif
-
-       cprintf("000\n");
-}
-#endif
-
-
 /*
  * We used to use master_cleanup() as a signal handler to shut down the server.
  * however, master_cleanup() and the functions it calls do some things that
@@ -264,7 +218,7 @@ void init_sysdep(void) {
         * session to which the calling thread is currently bound.
         */
        if (pthread_key_create(&MyConKey, NULL) != 0) {
-               lprintf(1, "Can't create TSD key!!  %s\n", strerror(errno));
+               lprintf(CTDL_CRIT, "Can't create TSD key!!  %s\n", strerror(errno));
        }
 
        /*
@@ -290,10 +244,19 @@ void init_sysdep(void) {
  */
 void begin_critical_section(int which_one)
 {
-       /* lprintf(9, "begin_critical_section(%d)\n", which_one); */
-       /* ensure nobody ever tries to do a critical section within a
-          transaction; this could lead to deadlock. */
-       cdb_check_handles();
+       /* lprintf(CTDL_DEBUG, "begin_critical_section(%d)\n", which_one); */
+
+       /* For all types of critical sections except those listed here,
+        * ensure nobody ever tries to do a critical section within a
+        * transaction; this could lead to deadlock.
+        */
+       if (    (which_one != S_FLOORCACHE)
+#ifdef DEBUG_MEMORY_LEAKS
+               && (which_one != S_DEBUGMEMLEAKS)
+#endif
+       ) {
+               cdb_check_handles();
+       }
        pthread_mutex_lock(&Critters[which_one]);
 }
 
@@ -302,7 +265,6 @@ void begin_critical_section(int which_one)
  */
 void end_critical_section(int which_one)
 {
-       /* lprintf(9, "end_critical_section(%d)\n", which_one); */
        pthread_mutex_unlock(&Critters[which_one]);
 }
 
@@ -313,7 +275,7 @@ void end_critical_section(int which_one)
  * a TCP port.  The server shuts down if the bind fails.
  *
  */
-int ig_tcp_server(int port_number, int queue_len)
+int ig_tcp_server(char *ip_addr, int port_number, int queue_len)
 {
        struct sockaddr_in sin;
        int s, i;
@@ -324,13 +286,22 @@ int ig_tcp_server(int port_number, int queue_len)
 
        memset(&sin, 0, sizeof(sin));
        sin.sin_family = AF_INET;
-       sin.sin_addr.s_addr = INADDR_ANY;
        sin.sin_port = htons((u_short)port_number);
+       if (ip_addr == NULL) {
+               sin.sin_addr.s_addr = INADDR_ANY;
+       }
+       else {
+               sin.sin_addr.s_addr = inet_addr(ip_addr);
+       }
+                                                                               
+       if (sin.sin_addr.s_addr == INADDR_NONE) {
+               sin.sin_addr.s_addr = INADDR_ANY;
+       }
 
        s = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP);
 
        if (s < 0) {
-               lprintf(1, "citserver: Can't create a socket: %s\n",
+               lprintf(CTDL_EMERG, "citserver: Can't create a socket: %s\n",
                        strerror(errno));
                return(-1);
        }
@@ -339,14 +310,14 @@ int ig_tcp_server(int port_number, int queue_len)
        setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &i, sizeof(i));
 
        if (bind(s, (struct sockaddr *)&sin, sizeof(sin)) < 0) {
-               lprintf(1, "citserver: Can't bind: %s\n",
+               lprintf(CTDL_EMERG, "citserver: Can't bind: %s\n",
                        strerror(errno));
                close(s);
                return(-1);
        }
 
        if (listen(s, actual_queue_len) < 0) {
-               lprintf(1, "citserver: Can't listen: %s\n", strerror(errno));
+               lprintf(CTDL_EMERG, "citserver: Can't listen: %s\n", strerror(errno));
                close(s);
                return(-1);
        }
@@ -371,7 +342,7 @@ int ig_uds_server(char *sockpath, int queue_len)
 
        i = unlink(sockpath);
        if (i != 0) if (errno != ENOENT) {
-               lprintf(1, "citserver: can't unlink %s: %s\n",
+               lprintf(CTDL_EMERG, "citserver: can't unlink %s: %s\n",
                        sockpath, strerror(errno));
                return(-1);
        }
@@ -382,19 +353,19 @@ int ig_uds_server(char *sockpath, int queue_len)
 
        s = socket(AF_UNIX, SOCK_STREAM, 0);
        if (s < 0) {
-               lprintf(1, "citserver: Can't create a socket: %s\n",
+               lprintf(CTDL_EMERG, "citserver: Can't create a socket: %s\n",
                        strerror(errno));
                return(-1);
        }
 
        if (bind(s, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
-               lprintf(1, "citserver: Can't bind: %s\n",
+               lprintf(CTDL_EMERG, "citserver: Can't bind: %s\n",
                        strerror(errno));
                return(-1);
        }
 
        if (listen(s, actual_queue_len) < 0) {
-               lprintf(1, "citserver: Can't listen: %s\n", strerror(errno));
+               lprintf(CTDL_EMERG, "citserver: Can't listen: %s\n", strerror(errno));
                return(-1);
        }
 
@@ -411,7 +382,7 @@ int ig_uds_server(char *sockpath, int queue_len)
  *
  * It's inlined because it's used *VERY* frequently.
  */
-inline struct CitContext *MyContext(void) {
+INLINE struct CitContext *MyContext(void) {
        return ((pthread_getspecific(MyConKey) == NULL)
                ? &masterCC
                : (struct CitContext *) pthread_getspecific(MyConKey)
@@ -429,9 +400,9 @@ inline struct CitContext *MyContext(void) {
 struct CitContext *CreateNewContext(void) {
        struct CitContext *me, *ptr;
 
-       me = (struct CitContext *) mallok(sizeof(struct CitContext));
+       me = (struct CitContext *) malloc(sizeof(struct CitContext));
        if (me == NULL) {
-               lprintf(1, "citserver: can't allocate memory!!\n");
+               lprintf(CTDL_ALERT, "citserver: can't allocate memory!!\n");
                return NULL;
        }
        memset(me, 0, sizeof(struct CitContext));
@@ -486,13 +457,13 @@ DONE:     ++num_sessions;
 
 /*
  * buffer_output() ... tell client_write to buffer all output until
- *                     instructed to dump it all out later
+ *                  instructed to dump it all out later
  */
 void buffer_output(void) {
        if (CC->buffering == 0) {
                CC->buffering = 1;
                CC->buffer_len = 0;
-               CC->output_buffer = mallok(SIZ);
+               CC->output_buffer = malloc(SIZ);
        }
 }
 
@@ -503,7 +474,7 @@ void unbuffer_output(void) {
        if (CC->buffering == 1) {
                CC->buffering = 0;
                client_write(CC->output_buffer, CC->buffer_len);
-               phree(CC->output_buffer);
+               free(CC->output_buffer);
                CC->output_buffer = NULL;
                CC->buffer_len = 0;
        }
@@ -537,7 +508,7 @@ void client_write(char *buf, int nbytes)
        if (CC->buffering) {
                old_buffer_len = CC->buffer_len;
                CC->buffer_len += nbytes;
-               CC->output_buffer = reallok(CC->output_buffer, CC->buffer_len);
+               CC->output_buffer = realloc(CC->output_buffer, CC->buffer_len);
                memcpy(&CC->output_buffer[old_buffer_len], buf, nbytes);
                return;
        }
@@ -555,7 +526,7 @@ void client_write(char *buf, int nbytes)
                retval = write(sock, &buf[bytes_written],
                        nbytes - bytes_written);
                if (retval < 1) {
-                       lprintf(2, "client_write() failed: %s\n",
+                       lprintf(CTDL_ERR, "client_write() failed: %s\n",
                                strerror(errno));
                        if (sock == CC->client_socket) CC->kill_me = 1;
                        return;
@@ -567,15 +538,15 @@ void client_write(char *buf, int nbytes)
 
 /*
  * cprintf()  ...   Send formatted printable data to the client.   It is
- *                  implemented in terms of client_write() but remains in
- *                  sysdep.c in case we port to somewhere without va_args...
+ *               implemented in terms of client_write() but remains in
+ *               sysdep.c in case we port to somewhere without va_args...
  */
 void cprintf(const char *format, ...) {   
-        va_list arg_ptr;   
-        char buf[SIZ];   
+       va_list arg_ptr;   
+       char buf[SIZ];   
    
-        va_start(arg_ptr, format);   
-        if (vsnprintf(buf, sizeof buf, format, arg_ptr) == -1)
+       va_start(arg_ptr, format);   
+       if (vsnprintf(buf, sizeof buf, format, arg_ptr) == -1)
                buf[sizeof buf - 2] = '\n';
        client_write(buf, strlen(buf)); 
        va_end(arg_ptr);
@@ -618,7 +589,7 @@ int client_read_to(char *buf, int bytes, int timeout)
 
                rlen = read(CC->client_socket, &buf[len], bytes-len);
                if (rlen<1) {
-                       lprintf(2, "client_read() failed: %s\n",
+                       lprintf(CTDL_ERR, "client_read() failed: %s\n",
                                strerror(errno));
                        CC->kill_me = 1;
                        return(-1);
@@ -633,7 +604,7 @@ int client_read_to(char *buf, int bytes, int timeout)
  * (This is implemented in terms of client_read_to() and could be
  * justifiably moved out of sysdep.c)
  */
-inline int client_read(char *buf, int bytes)
+INLINE int client_read(char *buf, int bytes)
 {
        return(client_read_to(buf, bytes, config.c_sleeping));
 }
@@ -686,11 +657,11 @@ void sysdep_master_cleanup(void) {
            serviceptr = serviceptr->next ) {
 
                if (serviceptr->tcp_port > 0)
-                       lprintf(3, "Closing listener on port %d\n",
+                       lprintf(CTDL_INFO, "Closing listener on port %d\n",
                                serviceptr->tcp_port);
 
                if (serviceptr->sockpath != NULL)
-                       lprintf(3, "Closing listener on '%s'\n",
+                       lprintf(CTDL_INFO, "Closing listener on '%s'\n",
                                serviceptr->sockpath);
 
                close(serviceptr->msock);
@@ -773,15 +744,15 @@ void create_worker(void) {
        struct worker_node *n;
        pthread_attr_t attr;
 
-       n = mallok(sizeof(struct worker_node));
+       n = malloc(sizeof(struct worker_node));
        if (n == NULL) {
-               lprintf(1, "can't allocate worker_node, exiting\n");
+               lprintf(CTDL_EMERG, "can't allocate worker_node, exiting\n");
                time_to_die = -1;
                return;
        }
 
        if ((ret = pthread_attr_init(&attr))) {
-               lprintf(1, "pthread_attr_init: %s\n", strerror(ret));
+               lprintf(CTDL_EMERG, "pthread_attr_init: %s\n", strerror(ret));
                time_to_die = -1;
                return;
        }
@@ -789,7 +760,7 @@ void create_worker(void) {
        /* we seem to need something bigger than FreeBSD's default 64k stack */
 
        if ((ret = pthread_attr_setstacksize(&attr, 128 * 1024))) {
-               lprintf(1, "pthread_attr_setstacksize: %s\n", strerror(ret));
+               lprintf(CTDL_EMERG, "pthread_attr_setstacksize: %s\n", strerror(ret));
                time_to_die = -1;
                return;
        }
@@ -797,7 +768,7 @@ void create_worker(void) {
        if ((ret = pthread_create(&n->tid, &attr, worker_thread, NULL) != 0))
        {
 
-               lprintf(1, "Can't create worker thread: %s\n",
+               lprintf(CTDL_ALERT, "Can't create worker thread: %s\n",
                        strerror(ret));
        }
 
@@ -811,17 +782,21 @@ void create_worker(void) {
  * Purge all sessions which have the 'kill_me' flag set.
  * This function has code to prevent it from running more than once every
  * few seconds, because running it after every single unbind would waste a lot
- * of CPU time and keep the context list locked too much.
+ * of CPU time and keep the context list locked too much.  To force it to run
+ * anyway, set "force" to nonzero.
+ *
  *
- * After that's done, we raise or lower the size of the worker thread pool
+ * After that's done, we raise the size of the worker thread pool
  * if such an action is appropriate.
  */
-void dead_session_purge(void) {
+void dead_session_purge(int force) {
        struct CitContext *ptr, *rem;
-       struct worker_node **node, *tmp;
-       pthread_t self;
 
-       if ( (time(NULL) - last_purge) < 5 ) return;    /* Too soon, go away */
+       if (force == 0) {
+               if ( (time(NULL) - last_purge) < 5 ) {
+                       return; /* Too soon, go away */
+               }
+       }
        time(&last_purge);
 
        do {
@@ -838,18 +813,13 @@ void dead_session_purge(void) {
                 * section, so we have to do it like this.
                 */     
                if (rem != NULL) {
-                       lprintf(9, "Purging session %d\n", rem->cs_pid);
+                       lprintf(CTDL_DEBUG, "Purging session %d\n", rem->cs_pid);
                        RemoveContext(rem);
                }
 
        } while (rem != NULL);
 
-
-       /* Raise or lower the size of the worker thread pool if such
-        * an action is appropriate.
-        */
-
-       self = pthread_self();
+       /* Raise the size of the worker thread pool if necessary. */
 
        if ( (num_sessions > num_threads)
           && (num_threads < config.c_max_workers) ) {
@@ -857,33 +827,6 @@ void dead_session_purge(void) {
                create_worker();
                end_critical_section(S_WORKER_LIST);
        }
-       
-       /* don't let the initial thread die since it's responsible for
-          waiting for all the other threads to terminate. */
-       else if ( (num_sessions < num_threads)
-          && (num_threads > config.c_min_workers)
-          && (self != initial_thread) ) {
-               cdb_free_tsd();
-               begin_critical_section(S_WORKER_LIST);
-               --num_threads;
-
-               /* we're exiting before server shutdown... unlink ourself from
-                  the worker list and detach our thread to avoid memory leaks
-                */
-
-               for (node = &worker_list; *node != NULL; node = &(*node)->next)
-                       if ((*node)->tid == self) {
-                               tmp = *node;
-                               *node = (*node)->next;
-                               phree(tmp);
-                               break;
-                       }
-
-               pthread_detach(self);
-               end_critical_section(S_WORKER_LIST);
-               pthread_exit(NULL);
-       }
-
 }
 
 
@@ -918,37 +861,7 @@ void InitializeMasterCC(void) {
 
 
 
-/*
- * Set up a fd_set containing all the master sockets to which we
- * always listen.  It's computationally less expensive to just copy
- * this to a local fd_set when starting a new select() and then add
- * the client sockets than it is to initialize a new one and then
- * figure out what to put there.
- */
-void init_master_fdset(void) {
-       struct ServiceFunctionHook *serviceptr;
-       int m;
-
-       lprintf(9, "Initializing master fdset\n");
-
-       FD_ZERO(&masterfds);
-       masterhighest = 0;
-
-       lprintf(9, "Will listen on rescan pipe %d\n", rescan[0]);
-       FD_SET(rescan[0], &masterfds);
-       if (rescan[0] > masterhighest) masterhighest = rescan[0];
 
-       for (serviceptr = ServiceHookTable; serviceptr != NULL;
-           serviceptr = serviceptr->next ) {
-               m = serviceptr->msock;
-               lprintf(9, "Will listen on master socket %d\n", m);
-               FD_SET(m, &masterfds);
-               if (m > masterhighest) {
-                       masterhighest = m;
-               }
-       }
-       lprintf(9, "masterhighest = %d\n", masterhighest);
-}
 
 
 /*
@@ -965,7 +878,6 @@ INLINE void become_session(struct CitContext *which_con) {
  */    
 void *worker_thread(void *arg) {
        int i;
-       char junk;
        int highest;
        struct CitContext *ptr;
        struct CitContext *bind_me = NULL;
@@ -975,6 +887,8 @@ void *worker_thread(void *arg) {
        struct ServiceFunctionHook *serviceptr;
        int ssock;                      /* Descriptor for client socket */
        struct timeval tv;
+       int force_purge = 0;
+       int m;
 
        num_threads++;
 
@@ -982,26 +896,17 @@ void *worker_thread(void *arg) {
 
        while (!time_to_die) {
 
-               /* 
-                * A naive implementation would have all idle threads
-                * calling select() and then they'd all wake up at once
-                * (known in computer science as the "thundering herd"
-                * problem).  We solve this problem by putting the select()
-                * in a critical section, so only one thread has the
-                * opportunity to wake up.  If we wake up on a master
-                * socket, create a new session context; otherwise, just
-                * bind the thread to the context we want and go on our
-                * merry way.
-                */
-
                /* make doubly sure we're not holding any stale db handles
                 * which might cause a deadlock.
                 */
                cdb_check_handles();
+do_select:     force_purge = 0;
+               bind_me = NULL;         /* Which session shall we handle? */
+
+               /* Initialize the fdset. */
+               FD_ZERO(&readfds);
+               highest = 0;
 
-               begin_critical_section(S_I_WANNA_SELECT);
-SETUP_FD:      memcpy(&readfds, &masterfds, sizeof masterfds);
-               highest = masterhighest;
                begin_critical_section(S_SESSION_TABLE);
                for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
                        if (ptr->state == CON_IDLE) {
@@ -1009,17 +914,36 @@ SETUP_FD:        memcpy(&readfds, &masterfds, sizeof masterfds);
                                if (ptr->client_socket > highest)
                                        highest = ptr->client_socket;
                        }
+                       if ((bind_me == NULL) && (ptr->state == CON_READY)) {
+                               bind_me = ptr;
+                               ptr->state = CON_EXECUTING;
+                       }
                }
                end_critical_section(S_SESSION_TABLE);
 
-               tv.tv_sec = 1;          /* wake up every second if no input */
-               tv.tv_usec = 0;
+               if (bind_me) goto SKIP_SELECT;
+
+               /* If we got this far, it means that there are no sessions
+                * which a previous thread marked for attention, so we go
+                * ahead and get ready to select().
+                */
+
+               /* First, add the various master sockets to the fdset. */
+               for (serviceptr = ServiceHookTable; serviceptr != NULL;
+               serviceptr = serviceptr->next ) {
+                       m = serviceptr->msock;
+                       FD_SET(m, &readfds);
+                       if (m > highest) {
+                               highest = m;
+                       }
+               }
 
-               do_select:
-               if (!time_to_die)
+               if (!time_to_die) {
+                       tv.tv_sec = 1;          /* wake up every second if no input */
+                       tv.tv_usec = 0;
                        retval = select(highest + 1, &readfds, NULL, NULL, &tv);
+               }
                else {
-                       end_critical_section(S_I_WANNA_SELECT);
                        break;
                }
 
@@ -1027,8 +951,13 @@ SETUP_FD: memcpy(&readfds, &masterfds, sizeof masterfds);
                 * First, check for an error or exit condition.
                 */
                if (retval < 0) {
+                       if (errno == EBADF) {
+                               lprintf(CTDL_NOTICE, "select() failed: (%s)\n",
+                                       strerror(errno));
+                               goto do_select;
+                       }
                        if (errno != EINTR) {
-                               lprintf(9, "Exiting (%s)\n", strerror(errno));
+                               lprintf(CTDL_EMERG, "Exiting (%s)\n", strerror(errno));
                                time_to_die = 1;
                        } else if (!time_to_die)
                                goto do_select;
@@ -1043,11 +972,12 @@ SETUP_FD:        memcpy(&readfds, &masterfds, sizeof masterfds);
                        if (FD_ISSET(serviceptr->msock, &readfds)) {
                                ssock = accept(serviceptr->msock, NULL, 0);
                                if (ssock < 0) {
-                                       lprintf(2, "citserver: accept(): %s\n",
+                                       lprintf(CTDL_CRIT,
+                                               "citserver: accept(): %s\n",
                                                strerror(errno));
                                }
                                else {
-                                       lprintf(7, "citserver: "
+                                       lprintf(CTDL_NOTICE,
                                                "New client socket %d\n",
                                                ssock);
 
@@ -1060,6 +990,8 @@ SETUP_FD:  memcpy(&readfds, &masterfds, sizeof masterfds);
                                        con->client_socket = ssock;
                                        con->h_command_function =
                                                serviceptr->h_command_function;
+                                       con->h_async_function =
+                                               serviceptr->h_async_function;
 
                                        /* Determine whether local socket */
                                        if (serviceptr->sockpath != NULL)
@@ -1076,63 +1008,62 @@ SETUP_FD:       memcpy(&readfds, &masterfds, sizeof masterfds);
                                        serviceptr->h_greeting_function();
                                        become_session(NULL);
                                        con->state = CON_IDLE;
-                                       goto SETUP_FD;
+                                       goto do_select;
                                }
                        }
                }
 
-               /* If the rescan pipe went active, someone is telling this
-                * thread that the &readfds needs to be refreshed with more
-                * current data.
-                */
                if (time_to_die) {
-                       end_critical_section(S_I_WANNA_SELECT);
                        break;
                }
 
-               if (FD_ISSET(rescan[0], &readfds)) {
-                       read(rescan[0], &junk, 1);
-                       goto SETUP_FD;
-               }
-
                /* It must be a client socket.  Find a context that has data
-                * waiting on its socket *and* is in the CON_IDLE state.
+                * waiting on its socket *and* is in the CON_IDLE state.  Any
+                * active sockets other than our chosen one are marked as
+                * CON_READY so the next thread that comes around can just bind
+                * to one without having to select() again.
                 */
-               else {
-                       bind_me = NULL;
-                       begin_critical_section(S_SESSION_TABLE);
-                       for (ptr = ContextList;
-                           ( (ptr != NULL) && (bind_me == NULL) );
-                           ptr = ptr->next) {
-                               if ( (FD_ISSET(ptr->client_socket, &readfds))
-                                  && (ptr->state == CON_IDLE) ) {
-                                       bind_me = ptr;
+               begin_critical_section(S_SESSION_TABLE);
+               for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
+                       if ( (FD_ISSET(ptr->client_socket, &readfds))
+                          && (ptr->state != CON_EXECUTING) ) {
+                               ptr->input_waiting = 1;
+                               if (!bind_me) {
+                                       bind_me = ptr;  /* I choose you! */
+                                       bind_me->state = CON_EXECUTING;
+                               }
+                               else {
+                                       ptr->state = CON_READY;
                                }
                        }
-                       if (bind_me != NULL) {
-                               /* Found one.  Stake a claim to it before
-                                * letting anyone else touch the context list.
-                                */
-                               bind_me->state = CON_EXECUTING;
-                       }
+               }
+               end_critical_section(S_SESSION_TABLE);
 
-                       end_critical_section(S_SESSION_TABLE);
-                       end_critical_section(S_I_WANNA_SELECT);
+SKIP_SELECT:
+               /* We're bound to a session */
+               if (bind_me != NULL) {
+                       become_session(bind_me);
 
-                       /* We're bound to a session, now do *one* command */
-                       if (bind_me != NULL) {
-                               become_session(bind_me);
+                       /* If the client has sent a command, execute it. */
+                       if (CC->input_waiting) {
                                CC->h_command_function();
-                               become_session(NULL);
-                               bind_me->state = CON_IDLE;
-                               if (bind_me->kill_me == 1) {
-                                       RemoveContext(bind_me);
-                               } 
-                               write(rescan[1], &junk, 1);
+                               CC->input_waiting = 0;
                        }
 
+                       /* If there are asynchronous messages waiting and the
+                        * client supports it, do those now */
+                       if ((CC->is_async) && (CC->async_waiting)
+                          && (CC->h_async_function != NULL)) {
+                               CC->h_async_function();
+                               CC->async_waiting = 0;
+                       }
+                       
+                       force_purge = CC->kill_me;
+                       become_session(NULL);
+                       bind_me->state = CON_IDLE;
                }
-               dead_session_purge();
+
+               dead_session_purge(force_purge);
                do_housekeeping();
                check_sched_shutdown();
        }
@@ -1141,3 +1072,154 @@ SETUP_FD:       memcpy(&readfds, &masterfds, sizeof masterfds);
        --num_threads;
        return NULL;
 }
+
+
+
+
+/*
+ * SyslogFacility()
+ * Translate text facility name to syslog.h defined value.
+ */
+int SyslogFacility(char *name)
+{
+       int i;
+       struct
+       {
+               int facility;
+               char *name;
+       }   facTbl[] =
+       {
+               {   LOG_KERN,   "kern"          },
+               {   LOG_USER,   "user"          },
+               {   LOG_MAIL,   "mail"          },
+               {   LOG_DAEMON, "daemon"        },
+               {   LOG_AUTH,   "auth"          },
+               {   LOG_SYSLOG, "syslog"        },
+               {   LOG_LPR,    "lpr"           },
+               {   LOG_NEWS,   "news"          },
+               {   LOG_UUCP,   "uucp"          },
+               {   LOG_LOCAL0, "local0"        },
+               {   LOG_LOCAL1, "local1"        },
+               {   LOG_LOCAL2, "local2"        },
+               {   LOG_LOCAL3, "local3"        },
+               {   LOG_LOCAL4, "local4"        },
+               {   LOG_LOCAL5, "local5"        },
+               {   LOG_LOCAL6, "local6"        },
+               {   LOG_LOCAL7, "local7"        },
+               {   0,            NULL          }
+       };
+       for(i = 0; facTbl[i].name != NULL; i++) {
+               if(!strcasecmp(name, facTbl[i].name))
+                       return facTbl[i].facility;
+       }
+       return -1;
+}
+
+
+/********** MEM CHEQQER ***********/
+
+#ifdef DEBUG_MEMORY_LEAKS
+
+#undef malloc
+#undef realloc
+#undef strdup
+#undef free
+
+void *tracked_malloc(size_t size, char *file, int line) {
+       struct igheap *thisheap;
+       void *block;
+
+       block = malloc(size);
+       if (block == NULL) return(block);
+
+       thisheap = malloc(sizeof(struct igheap));
+       if (thisheap == NULL) {
+               free(block);
+               return(NULL);
+       }
+
+       thisheap->block = block;
+       strcpy(thisheap->file, file);
+       thisheap->line = line;
+       
+       begin_critical_section(S_DEBUGMEMLEAKS);
+       thisheap->next = igheap;
+       igheap = thisheap;
+       end_critical_section(S_DEBUGMEMLEAKS);
+
+       return(block);
+}
+
+
+void *tracked_realloc(void *ptr, size_t size, char *file, int line) {
+       struct igheap *thisheap;
+       void *block;
+
+       block = realloc(ptr, size);
+       if (block == NULL) return(block);
+
+       thisheap = malloc(sizeof(struct igheap));
+       if (thisheap == NULL) {
+               free(block);
+               return(NULL);
+       }
+
+       thisheap->block = block;
+       strcpy(thisheap->file, file);
+       thisheap->line = line;
+       
+       begin_critical_section(S_DEBUGMEMLEAKS);
+       thisheap->next = igheap;
+       igheap = thisheap;
+       end_critical_section(S_DEBUGMEMLEAKS);
+
+       return(block);
+}
+
+
+
+void tracked_free(void *ptr) {
+       struct igheap *thisheap;
+       struct igheap *trash;
+
+       free(ptr);
+
+       if (igheap == NULL) return;
+       begin_critical_section(S_DEBUGMEMLEAKS);
+       for (thisheap = igheap; thisheap != NULL; thisheap = thisheap->next) {
+               if (thisheap->next != NULL) {
+                       if (thisheap->next->block == ptr) {
+                               trash = thisheap->next;
+                               thisheap->next = thisheap->next->next;
+                               free(trash);
+                       }
+               }
+       }
+       if (igheap->block == ptr) {
+               trash = igheap;
+               igheap = igheap->next;
+               free(trash);
+       }
+       end_critical_section(S_DEBUGMEMLEAKS);
+}
+
+char *tracked_strdup(const char *s, char *file, int line) {
+       char *ptr;
+
+       if (s == NULL) return(NULL);
+       ptr = tracked_malloc(strlen(s) + 1, file, line);
+       if (ptr == NULL) return(NULL);
+       strncpy(ptr, s, strlen(s));
+       return(ptr);
+}
+
+void dump_heap(void) {
+       struct igheap *thisheap;
+
+       for (thisheap = igheap; thisheap != NULL; thisheap = thisheap->next) {
+               lprintf(CTDL_CRIT, "UNFREED: %30s : %d\n",
+                       thisheap->file, thisheap->line);
+       }
+}
+
+#endif /*  DEBUG_MEMORY_LEAKS */