]> code.citadel.org Git - citadel.git/blobdiff - libcitadel/lib/mime_parser.c
* use a lookup table to convert hex to char (like we already do vice versa) to be...
[citadel.git] / libcitadel / lib / mime_parser.c
index 14f292a6def95a637e5fe9275f2804e03a21f88a..038851e2114b6c480691b471e3cb2220d1497312 100644 (file)
@@ -1,9 +1,7 @@
 /*
- * $Id$
- *
  * This is the MIME parser for Citadel.
  *
- * Copyright (c) 1998-2007 by the citadel.org development team.
+ * Copyright (c) 1998-2010 by the citadel.org development team.
  * This code is distributed under the GNU General Public License v3.
  *
  */
 
 #include "xdgmime/xdgmime.h"
 #include "libcitadel.h"
+#include "libcitadellocal.h"
+
+const unsigned char FromHexTable [256] = {
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //  0
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 10
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 20
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 30
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x01, // 40
+       0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0xFF, 0xFF, // 50
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, // 60
+       0x0F, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 70
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 80
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x0A, 0x0B, 0x0C, // 90
+       0x0D, 0x0E, 0x0F, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //100
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //110
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //120
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //130
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //140
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //150
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //160
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //170
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //180
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //190
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //200
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //210
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //220
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //230
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //240
+       0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF                          //250
+};
 
-void extract_key(char *target, char *source, char *key)
+
+void extract_key(char *target, char *source, long sourcelen, char *key, long keylen, char KeyEnd)
 {
-       char *ptr;
-       char looking_for[256];
+       char *sptr, *ptr = NULL;
        int double_quotes = 0;
+       long RealKeyLen = keylen;
 
-       snprintf(looking_for, sizeof looking_for, "%s=", key);
+       sptr = source;
 
-       ptr = bmstrcasestr(source, looking_for);
+       while (sptr != NULL)
+       {
+               ptr = bmstrcasestr_len(sptr, sourcelen - (sptr - source), 
+                                      key, keylen);
+               if(ptr != NULL)
+               {
+                       while (isspace(*(ptr + RealKeyLen)))
+                               RealKeyLen ++;
+                       if (*(ptr + RealKeyLen) == KeyEnd)
+                       {
+                               sptr = NULL;
+                               RealKeyLen ++;                          
+                       }
+                       else
+                       {
+                               sptr = ptr + RealKeyLen + 1;
+                       }
+               }
+               else 
+                       sptr = ptr;
+       }
        if (ptr == NULL) {
-               strcpy(target, "");
+               *target = '\0';
                return;
        }
-       strcpy(target, (ptr + strlen(looking_for)));
+       strcpy(target, (ptr + RealKeyLen));
 
-       for (ptr=target; (*ptr != 0); ++ptr) {
+       for (ptr=target; (*ptr != 0); ptr++) {
 
                /* A semicolon means we've hit the end of the key, unless we're inside double quotes */
                if ( (double_quotes != 1) && (*ptr == ';')) {
@@ -56,6 +105,7 @@ void extract_key(char *target, char *source, char *key)
                        }
                }
        }
+       *ptr = '\0';
 }
 
 
@@ -70,6 +120,24 @@ char *fixed_partnum(char *supplied_partnum) {
 }
 
 
+static inline unsigned int _decode_hex(const char *Source)
+{
+       int ret = '?';
+       unsigned char LO_NIBBLE;
+       unsigned char HI_NIBBLE;
+
+       HI_NIBBLE = FromHexTable[(unsigned char) *Source];
+       LO_NIBBLE = FromHexTable[(unsigned char) *(Source+1)];
+       
+       if ((LO_NIBBLE == 0xFF) || (LO_NIBBLE == 0xFF))
+               return ret;
+       ret = HI_NIBBLE;
+       ret = ret << 4;
+       ret = ret | LO_NIBBLE;
+       return ret;
+}
+
+unsigned int decode_hex(char *Source) {return _decode_hex(Source);}
 
 /*
  * Convert "quoted-printable" to binary.  Returns number of bytes decoded.
@@ -82,20 +150,26 @@ int CtdlDecodeQuotedPrintable(char *decoded, char *encoded, int sourcelen) {
 
        while (pos < sourcelen)
        {
-               if (!strncmp(&encoded[pos], "=\r\n", 3))
+               if (*(encoded + pos) == '=')
                {
-                       pos += 3;
-               }
-               else if (!strncmp(&encoded[pos], "=\n", 2))
-               {
-                       pos += 2;
-               }
-               else if (encoded[pos] == '=')
-               {
-                       ch = 0;
-                       sscanf(&encoded[pos+1], "%02x", &ch);
-                       pos += 3;
-                       decoded[decoded_length++] = ch;
+                       pos ++;
+                       if (*(encoded + pos) == '\n')
+                       {
+                               pos ++;
+                       }
+                       else if (*(encoded + pos) == '\r')
+                       {
+                               pos ++;
+                               if (*(encoded + pos) == '\n')
+                                       pos++;
+                       }
+                       else if (encoded[pos] == '=')
+                       {
+                               ch = 0;
+                               ch = _decode_hex(&encoded[pos]);
+                               pos += 2;
+                               decoded[decoded_length++] = ch;
+                       }
                }
                else
                {
@@ -116,43 +190,13 @@ void mime_decode(char *partnum,
                 char *part_start, size_t length,
                 char *content_type, char *charset, char *encoding,
                 char *disposition,
+                char *id,
                 char *name, char *filename,
-                void (*CallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-                void (*PreMultiPartCallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-                void (*PostMultiPartCallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-                 void *userdata,
-                 int dont_decode
-)
+                MimeParserCallBackType CallBack,
+                MimeParserCallBackType PreMultiPartCallBack,
+                MimeParserCallBackType PostMultiPartCallBack,
+                void *userdata,
+                int dont_decode)
 {
 
        char *decoded;
@@ -171,7 +215,7 @@ void mime_decode(char *partnum,
                if (CallBack != NULL) {
                        CallBack(name, filename, fixed_partnum(partnum),
                                disposition, part_start,
-                               content_type, charset, length, encoding, userdata);
+                               content_type, charset, length, encoding, id, userdata);
                        }
                return;
        }
@@ -203,7 +247,7 @@ void mime_decode(char *partnum,
        if (bytes_decoded > 0) if (CallBack != NULL) {
                CallBack(name, filename, fixed_partnum(partnum),
                        disposition, decoded,
-                       content_type, charset, bytes_decoded, "binary", userdata);
+                       content_type, charset, bytes_decoded, "binary", id, userdata);
        }
 
        free(decoded);
@@ -217,42 +261,11 @@ void mime_decode(char *partnum,
  */
 void the_mime_parser(char *partnum,
                     char *content_start, char *content_end,
-                    void (*CallBack)
-                     (char *cbname,
-                      char *cbfilename,
-                      char *cbpartnum,
-                      char *cbdisp,
-                      void *cbcontent,
-                      char *cbtype,
-                      char *cbcharset,
-                      size_t cblength,
-                      char *cbencoding,
-                      void *cbuserdata),
-                    void (*PreMultiPartCallBack)
-                     (char *cbname,
-                      char *cbfilename,
-                      char *cbpartnum,
-                      char *cbdisp,
-                      void *cbcontent,
-                      char *cbtype,
-                      char *cbcharset,
-                      size_t cblength,
-                      char *cbencoding,
-                      void *cbuserdata),
-                    void (*PostMultiPartCallBack)
-                     (char *cbname,
-                      char *cbfilename,
-                      char *cbpartnum,
-                      char *cbdisp,
-                      void *cbcontent,
-                      char *cbtype,
-                      char *cbcharset,
-                      size_t cblength,
-                      char *cbencoding,
-                      void *cbuserdata),
-                     void *userdata,
-                     int dont_decode
-)
+                    MimeParserCallBackType CallBack,
+                    MimeParserCallBackType PreMultiPartCallBack,
+                    MimeParserCallBackType PostMultiPartCallBack,
+                    void *userdata,
+                    int dont_decode)
 {
 
        char *ptr;
@@ -267,9 +280,12 @@ void the_mime_parser(char *partnum,
        char *next_boundary;
        char *content_type;
        char *charset;
+       size_t content_type_len;
        size_t content_length;
        char *encoding;
        char *disposition;
+       size_t disposition_len;
+       char *id;
        char *name = NULL;
        char *content_type_name;
        char *content_disposition_name;
@@ -287,38 +303,41 @@ void the_mime_parser(char *partnum,
        ptr = content_start;
        content_length = 0;
 
-       boundary = malloc(SIZ);
-       memset(boundary, 0, SIZ);
+       boundary = malloc(SIZ * 12);
+       *boundary = '\0';
+
+       startary = boundary + SIZ * 1;
+       *startary = '\0';
 
-       startary = malloc(SIZ);
-       memset(startary, 0, SIZ);
+       endary = boundary + SIZ * 2;
+       *endary = '\0';
 
-       endary = malloc(SIZ);
-       memset(endary, 0, SIZ);
+       header = boundary + SIZ * 3;
+       *header = '\0';
 
-       header = malloc(SIZ);
-       memset(header, 0, SIZ);
+       content_type = boundary + SIZ * 4;
+       *content_type = '\0';
 
-       content_type = malloc(SIZ);
-       memset(content_type, 0, SIZ);
+       charset = boundary + SIZ * 5;
+       *charset = '\0';
 
-       charset = malloc(SIZ);
-       memset(charset, 0, SIZ);
+       encoding = boundary + SIZ * 6;
+       *encoding = '\0';
 
-       encoding = malloc(SIZ);
-       memset(encoding, 0, SIZ);
+       content_type_name = boundary + SIZ * 7;
+       *content_type_name = '\0';
 
-       content_type_name = malloc(SIZ);
-       memset(content_type_name, 0, SIZ);
+       content_disposition_name = boundary + SIZ * 8;
+       *content_disposition_name = '\0';
 
-       content_disposition_name = malloc(SIZ);
-       memset(content_disposition_name, 0, SIZ);
+       filename = boundary + SIZ * 9;
+       *filename = '\0';
 
-       filename = malloc(SIZ);
-       memset(filename, 0, SIZ);
+       disposition = boundary + SIZ * 10;
+       *disposition = '\0';
 
-       disposition = malloc(SIZ);
-       memset(disposition, 0, SIZ);
+       id = boundary + SIZ * 11;
+       *id = '\0';
 
        /* If the caller didn't supply an endpointer, generate one by measure */
        if (content_end == NULL) {
@@ -342,30 +361,37 @@ void the_mime_parser(char *partnum,
 
                if (!isspace(buf[0])) {
                        if (!strncasecmp(header, "Content-type:", 13)) {
-                               strcpy(content_type, &header[13]);
-                               striplt(content_type);
-                               extract_key(content_type_name, content_type, "name");
-                               extract_key(charset, content_type, "charset");
-                               extract_key(boundary, header, "boundary");
+                               memcpy (content_type, &header[13], headerlen - 12);
+                               content_type_len = striplt (content_type);
+
+                               extract_key(content_type_name, content_type, content_type_len, HKEY("name"), '=');
+                               extract_key(charset,           content_type, content_type_len, HKEY("charset"), '=');
+                               extract_key(boundary,          header,       headerlen,        HKEY("boundary"), '=');
+
                                /* Deal with weird headers */
                                if (strchr(content_type, ' '))
                                        *(strchr(content_type, ' ')) = '\0';
                                if (strchr(content_type, ';'))
                                        *(strchr(content_type, ';')) = '\0';
                        }
-                       if (!strncasecmp(header, "Content-Disposition:", 20)) {
-                               strcpy(disposition, &header[20]);
-                               striplt(disposition);
-                               extract_key(content_disposition_name, disposition, "name");
-                               extract_key(filename, disposition, "filename");
+                       else if (!strncasecmp(header, "Content-Disposition:", 20)) {
+                               memcpy (disposition, &header[20], headerlen - 19);
+                               disposition_len = striplt(disposition);
+                               extract_key(content_disposition_name, disposition, disposition_len,  HKEY("name"), '=');
+                               extract_key(filename,                 disposition, disposition_len, HKEY("filename"), '=');
                        }
-                       if (!strncasecmp(header, "Content-length: ", 15)) {
+                       else if (!strncasecmp(header, "Content-ID:", 11)) {
+                               strcpy(id, &header[11]);
+                               striplt(id);
+                               stripallbut(id, '<', '>');
+                       }
+                       else if (!strncasecmp(header, "Content-length: ", 15)) {
                                char clbuf[10];
                                safestrncpy(clbuf, &header[15], sizeof clbuf);
                                striplt(clbuf);
                                content_length = (size_t) atol(clbuf);
                        }
-                       if (!strncasecmp(header, "Content-transfer-encoding: ", 26)) {
+                       else if (!strncasecmp(header, "Content-transfer-encoding: ", 26)) {
                                strcpy(encoding, &header[26]);
                                striplt(encoding);
                        }
@@ -400,13 +426,12 @@ void the_mime_parser(char *partnum,
                if (PreMultiPartCallBack != NULL) {
                        PreMultiPartCallBack("", "", partnum, "",
                                NULL, content_type, charset,
-                               0, encoding, userdata);
+                               0, encoding, id, userdata);
                }
 
                /* Figure out where the boundaries are */
-               snprintf(startary, SIZ, "--%s", boundary);
+               startary_len = snprintf(startary, SIZ, "--%s", boundary);
                snprintf(endary, SIZ, "--%s--", boundary);
-               startary_len = strlen(startary);
 
                part_start = NULL;
                do {
@@ -478,7 +503,7 @@ void the_mime_parser(char *partnum,
 
                if (PostMultiPartCallBack != NULL) {
                        PostMultiPartCallBack("", "", partnum, "", NULL,
-                               content_type, charset, 0, encoding, userdata);
+                               content_type, charset, 0, encoding, id, userdata);
                }
                goto end_parser;
        }
@@ -493,18 +518,15 @@ void the_mime_parser(char *partnum,
                }
                part_end = content_end;
 
-               /******
-                * I thought there was an off-by-one error here, but there isn't.
-                * This probably means that there's an off-by-one error somewhere
-                * else ... or maybe only in certain messages?
-               --part_end;
-               --length;
-               ******/
-               
-               /* Truncate if the header told us to */
-               if ( (content_length > 0) && (length > content_length) ) {
-                       length = content_length;
-               }
+
+               /* The following code will truncate the MIME part to the size
+                * specified by the Content-length: header.   We have commented it
+                * out because these headers have a tendency to be wrong.
+                *
+                *      if ( (content_length > 0) && (length > content_length) ) {
+                *              length = content_length;
+                *      }
+                 */
 
                /* Sometimes the "name" field is tacked on to Content-type,
                 * and sometimes it's tacked on to Content-disposition.  Use
@@ -521,7 +543,7 @@ void the_mime_parser(char *partnum,
                 */
                mime_decode(partnum,
                        part_start, length,
-                       content_type, charset, encoding, disposition,
+                       content_type, charset, encoding, disposition, id,
                        name, filename,
                        CallBack, NULL, NULL,
                        userdata, dont_decode
@@ -535,7 +557,7 @@ void the_mime_parser(char *partnum,
                        if (PreMultiPartCallBack != NULL) {
                                PreMultiPartCallBack("", "", partnum, "",
                                        NULL, content_type, charset,
-                                       0, encoding, userdata);
+                                       0, encoding, id, userdata);
                        }
                        if (CallBack != NULL) {
                                if (strlen(partnum) > 0) {
@@ -560,7 +582,7 @@ void the_mime_parser(char *partnum,
                        }
                        if (PostMultiPartCallBack != NULL) {
                                PostMultiPartCallBack("", "", partnum, "", NULL,
-                                       content_type, charset, 0, encoding, userdata);
+                                       content_type, charset, 0, encoding, id, userdata);
                        }
 
 
@@ -570,16 +592,6 @@ void the_mime_parser(char *partnum,
 
 end_parser:    /* free the buffers!  end the oppression!! */
        free(boundary);
-       free(startary);
-       free(endary);   
-       free(header);
-       free(content_type);
-       free(charset);
-       free(encoding);
-       free(content_type_name);
-       free(content_disposition_name);
-       free(filename);
-       free(disposition);
 }
 
 
@@ -591,47 +603,12 @@ end_parser:       /* free the buffers!  end the oppression!! */
  * considered to have ended when the parser encounters a 0x00 byte.
  */
 void mime_parser(char *content_start,
-               char *content_end,
-
-                void (*CallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-
-                void (*PreMultiPartCallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-
-                void (*PostMultiPartCallBack)
-                 (char *cbname,
-                  char *cbfilename,
-                  char *cbpartnum,
-                  char *cbdisp,
-                  void *cbcontent,
-                  char *cbtype,
-                  char *cbcharset,
-                  size_t cblength,
-                  char *cbencoding,
-                  void *cbuserdata),
-
-                 void *userdata,
-                 int dont_decode
-)
+                char *content_end,
+                MimeParserCallBackType CallBack,
+                MimeParserCallBackType PreMultiPartCallBack,
+                MimeParserCallBackType PostMultiPartCallBack,
+                void *userdata,
+                int dont_decode)
 {
 
        the_mime_parser("", content_start, content_end,
@@ -681,7 +658,7 @@ MimeGuess MyMimes [] = {
 };
 
 
-const char *GuessMimeType(char *data, size_t dlen)
+const char *GuessMimeType(const char *data, size_t dlen)
 {
        int MimeIndex = 0;
 
@@ -708,33 +685,37 @@ const char *GuessMimeType(char *data, size_t dlen)
 const char* GuessMimeByFilename(const char *what, size_t len)
 {
        /* we know some hardcoded on our own, try them... */
-       if (!strncasecmp(&what[len - 4], ".gif", 4))
+       if ((len > 3) && !strncasecmp(&what[len - 4], ".gif", 4))
                return "image/gif";
-       else if (!strncasecmp(&what[len - 3], ".js", 3))
+       else if ((len > 2) && !strncasecmp(&what[len - 3], ".js", 3))
                return  "text/javascript";
-       else if (!strncasecmp(&what[len - 4], ".txt", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".txt", 4))
                return "text/plain";
-       else if (!strncasecmp(&what[len - 4], ".css", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".css", 4))
                return "text/css";
-       else if (!strncasecmp(&what[len - 4], ".jpg", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".htc", 4))
+               return "text/x-component";
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".jpg", 4))
                return "image/jpeg";
-       else if (!strncasecmp(&what[len - 4], ".png", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".png", 4))
                return "image/png";
-       else if (!strncasecmp(&what[len - 4], ".ico", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".ico", 4))
                return "image/x-icon";
-       else if (!strncasecmp(&what[len - 5], ".html", 5))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".vcf", 4))
+               return "text/x-vcard";
+       else if ((len > 4) && !strncasecmp(&what[len - 5], ".html", 5))
                return "text/html";
-       else if (!strncasecmp(&what[len - 4], ".htm", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".htm", 4))
                return "text/html";
-       else if (!strncasecmp(&what[len - 4], ".wml", 4))
+       else if ((len > 3) && !strncasecmp(&what[len - 4], ".wml", 4))
                return "text/vnd.wap.wml";
-       else if (!strncasecmp(&what[len - 5], ".wmls", 5))
+       else if ((len > 4) && !strncasecmp(&what[len - 5], ".wmls", 5))
                return "text/vnd.wap.wmlscript";
-       else if (!strncasecmp(&what[len - 5], ".wmlc", 5))
+       else if ((len > 4) && !strncasecmp(&what[len - 5], ".wmlc", 5))
                return "application/vnd.wap.wmlc";
-       else if (!strncasecmp(&what[len - 6], ".wmlsc", 6))
+       else if ((len > 5) && !strncasecmp(&what[len - 6], ".wmlsc", 6))
                return "application/vnd.wap.wmlscriptc";
-       else if (!strncasecmp(&what[len - 5], ".wbmp", 5))
+       else if ((len > 4) && !strncasecmp(&what[len - 5], ".wbmp", 5))
                return "image/vnd.wap.wbmp";
        else
                /* and let xdgmime do the fallback. */
@@ -755,8 +736,10 @@ static void DeleteIcon(void *IconNamePtr)
        IconName *Icon = (IconName*) IconNamePtr;
        free(Icon->FlatName);
        free(Icon->FileName);
+       free(Icon);
 }
 
+/*
 static const char *PrintFlat(void *IconNamePtr)
 {
        IconName *Icon = (IconName*) IconNamePtr;
@@ -767,6 +750,8 @@ static const char *PrintFile(void *IconNamePtr)
        IconName *Icon = (IconName*) IconNamePtr;
        return Icon->FileName;
 }
+*/
+
 #define GENSTR "x-generic"
 #define IGNORE_PREFIX_1 "gnome-mime"
 int LoadIconDir(const char *DirName)
@@ -778,7 +763,7 @@ int LoadIconDir(const char *DirName)
        IconName *Icon;
 
        filedir = opendir (DirName);
-       IconHash = NewHash();
+       IconHash = NewHash(1, NULL);
        if (filedir == NULL) {
                return 0;
        }
@@ -837,24 +822,27 @@ int LoadIconDir(const char *DirName)
                Put(IconHash, Icon->FlatName, d_without_ext, Icon, DeleteIcon);
 //             PrintHash(IconHash, PrintFlat, PrintFile);
        }
+       closedir(filedir);
        return 1;
 }
 
 const char *GetIconFilename(char *MimeType, size_t len)
 {
+       void *vIcon;
        IconName *Icon;
        
        if(IconHash == NULL)
                return NULL;
 
-       GetHash(IconHash, MimeType, len, (void**)&Icon);
+       GetHash(IconHash, MimeType, len, &vIcon), Icon = (IconName*) vIcon;
        /* didn't find the exact mimetype? try major only. */
        if (Icon == NULL) {
                char * pMinor;
                pMinor = strchr(MimeType, '/');
                if (pMinor != NULL) {
                        *pMinor = '\0';
-                       GetHash(IconHash, MimeType, pMinor - MimeType, (void**)&Icon);
+                       GetHash(IconHash, MimeType, pMinor - MimeType, &vIcon),
+                               Icon = (IconName*) vIcon;
                }
        }
        if (Icon == NULL) {
@@ -865,7 +853,7 @@ const char *GetIconFilename(char *MimeType, size_t len)
        return Icon->FileName;
 }
 
-void ShutDownLibCitadel(void)
+void ShutDownLibCitadelMime(void)
 {
        DeleteHash(&IconHash);
 }