tools: replace st00pid uses of strcpy

[citadel.git] / libcitadel / lib / tools.c

diff --git a/libcitadel/lib/tools.c b/libcitadel/lib/tools.c
index b269433ef7cfb07cb4127a0fdc92adb4262874f1..c0d3f9f1e00f0ef063ae6482f0785b84980cabfb 100644 (file)
--- a/libcitadel/lib/tools.c
+++ b/libcitadel/lib/tools.c
@@ -387,7 +387,6 @@ size_t CtdlEncodeBase64(char *dest, const char *source, size_t sourcelen, int li
                dest[dpos++] = '\r';
                dest[dpos++] = '\n';
                dest[dpos] = 0;
-               thisline = 0;
        }
 
        return(dpos);
@@ -574,7 +573,7 @@ void fmt_date(char *buf, size_t n, time_t thetime, int seconds) {
                "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"
        };
 
-       strcpy(buf, "");
+       *buf = '\0';
        localtime_r(&thetime, &tm);
 
        hour = tm.tm_hour;
@@ -836,7 +835,7 @@ void urlesc(char *outbuf, size_t oblen, char *strbuf)
        int a, b, c, len, eclen, olen;
        char *ec = " +#&;`'|*?-~<>^()[]{}/$\"\\";
 
-       strcpy(outbuf, "");
+       *outbuf = '\0';
        len = strlen(strbuf);
        eclen = strlen(ec);
        olen = 0;
@@ -875,13 +874,31 @@ char *strcpy(char *dest, const char *src) {
  */
 void generate_uuid(char *buf) {
        static int seq = (-1);
+       static int no_kernel_uuid = 0;
+
+       /* If we are running on Linux then we have a kernelspace uuid generator available */
+
+       if (no_kernel_uuid == 0) {
+               FILE *fp;
+               fp = fopen("/proc/sys/kernel/random/uuid", "rb");
+               if (fp) {
+                       int rv;
+                       rv = fread(buf, 36, 1, fp);
+                       fclose(fp);
+                       if (rv == 1) {
+                               buf[36] = 0;
+                               return;
+                       }
+               }
+       }
+
+       /* If the kernel didn't provide us with a uuid, we generate a pseudo-random one */
+
+       no_kernel_uuid = 1;
 
-<<<<<<< HEAD
        if (seq == (-1)) {
                seq = (int)rand();
        }
-=======
->>>>>>> d0e228d... generate_uuid() now generates more or less DCE-compliant uuid's
        ++seq;
        seq = (seq % 0x0FFF) ;