]> code.citadel.org Git - citadel.git/blobdiff - webcit/messages.c
* lets start knit-picking on buffersizes.
[citadel.git] / webcit / messages.c
index 348fa1dea301866bb64610ab8a758ac4111274e3..032b79c04b9337d238cbeb9391a2364a1a64268b 100644 (file)
@@ -74,7 +74,7 @@ void utf8ify_rfc822_string(char *buf) {
        char *isav;                     /**< Saved pointer to input buffer */
        char *osav;                     /**< Saved pointer to output buffer */
        int passes = 0;
-       int i;
+       int i, len;
        int illegal_non_rfc2047_encoding = 0;
 
        /** Sometimes, badly formed messages contain strings which were simply
@@ -83,9 +83,11 @@ void utf8ify_rfc822_string(char *buf) {
         *  handle it anyway by converting from a user-specified default
         *  charset to UTF-8 if we see any nonprintable characters.
         */
-       for (i=0; i<strlen(buf); ++i) {
+       len = strlen(buf);
+       for (i=0; i<len; ++i) {
                if ((buf[i] < 32) || (buf[i] > 126)) {
                        illegal_non_rfc2047_encoding = 1;
+                       i = len; ///< take a shortcut, it won't be more than one.
                }
        }
        if (illegal_non_rfc2047_encoding) {
@@ -211,14 +213,15 @@ void utf8ify_rfc822_string(char *buf) {
 void rfc2047encode(char *target, int maxlen, char *source)
 {
        int need_to_encode = 0;
-       int i;
+       int i, len;
        unsigned char ch;
 
        if (target == NULL) return;
-
-       for (i=0; i<strlen(source); ++i) {
+       len = strlen(source);
+       for (i=0; i<len; ++i) {
                if ((source[i] < 32) || (source[i] > 126)) {
                        need_to_encode = 1;
+                       i = len; ///< shortcut. won't become more than 1
                }
        }
 
@@ -228,7 +231,7 @@ void rfc2047encode(char *target, int maxlen, char *source)
        }
 
        strcpy(target, "=?UTF-8?Q?");
-       for (i=0; i<strlen(source); ++i) {
+       for (i=0; i<len; ++i) {
                ch = (unsigned char) source[i];
                if ((ch < 32) || (ch > 126) || (ch == 61)) {
                        sprintf(&target[strlen(target)], "=%02X", ch);
@@ -251,51 +254,52 @@ void rfc2047encode(char *target, int maxlen, char *source)
  */
 void url(char *buf)
 {
-
-       int pos;
-       int start, end;
+       int len;
+       char *start, *end, *pos;
        char urlbuf[SIZ];
        char outbuf[1024];
-       start = (-1);
-       end = strlen(buf);
 
-       for (pos = 0; pos < strlen(buf); ++pos) {
-               if (!strncasecmp(&buf[pos], "http://", 7))
+       start = NULL;
+       len = strlen(buf);
+       end = buf + len;
+       for (pos = buf; (pos < end) && (start == NULL); ++pos) {
+               if (!strncasecmp(pos, "http://", 7))
                        start = pos;
-               if (!strncasecmp(&buf[pos], "ftp://", 6))
+               if (!strncasecmp(pos, "ftp://", 6))
                        start = pos;
        }
 
-       if (start < 0)
+       if (start == NULL)
                return;
 
-       for (pos = strlen(buf); pos > start; --pos) {
-               if (  (!isprint(buf[pos]))
-                  || (isspace(buf[pos]))
-                  || (buf[pos] == '{')
-                  || (buf[pos] == '}')
-                  || (buf[pos] == '|')
-                  || (buf[pos] == '\\')
-                  || (buf[pos] == '^')
-                  || (buf[pos] == '[')
-                  || (buf[pos] == ']')
-                  || (buf[pos] == '`')
-                  || (buf[pos] == '<')
-                  || (buf[pos] == '>')
-                  || (buf[pos] == '(')
-                  || (buf[pos] == ')')
+       for (pos = buf+len; pos > start; --pos) {
+               if (  (!isprint(*pos))
+                  || (isspace(*pos))
+                  || (*pos == '{')
+                  || (*pos == '}')
+                  || (*pos == '|')
+                  || (*pos == '\\')
+                  || (*pos == '^')
+                  || (*pos == '[')
+                  || (*pos == ']')
+                  || (*pos == '`')
+                  || (*pos == '<')
+                  || (*pos == '>')
+                  || (*pos == '(')
+                  || (*pos == ')')
                ) {
                        end = pos;
                }
        }
 
-       strncpy(urlbuf, &buf[start], end - start);
-       urlbuf[end - start] = 0;
+       strncpy(urlbuf, start, end - start);
+       urlbuf[end - start] = '\0';
 
-       strncpy(outbuf, buf, start);
-       sprintf(&outbuf[start], "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
+       if (start != buf)
+               strncpy(outbuf, buf, start - buf );
+       sprintf(&outbuf[start-buf], "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
                LB, QU, urlbuf, QU, QU, TARGET, QU, RB, urlbuf, LB, RB);
-       strcat(outbuf, &buf[end]);
+       strcat(outbuf, end);
        if ( strlen(outbuf) < 250 )
                strcpy(buf, outbuf);
 }
@@ -308,29 +312,32 @@ void url(char *buf)
 void vcard_n_prettyize(char *name)
 {
        char *original_name;
-       int i;
+       int i, j, len;
 
        original_name = strdup(name);
+       len = strlen(original_name);
        for (i=0; i<5; ++i) {
-               if (strlen(original_name) > 0) {
-                       if (original_name[strlen(original_name)-1] == ' ') {
-                               original_name[strlen(original_name)-1] = 0;
+               if (len > 0) {
+                       if (original_name[len-1] == ' ') {
+                               original_name[--len] = 0;
                        }
-                       if (original_name[strlen(original_name)-1] == ';') {
-                               original_name[strlen(original_name)-1] = 0;
+                       if (original_name[len-1] == ';') {
+                               original_name[--len] = 0;
                        }
                }
        }
        strcpy(name, "");
-       for (i=0; i<strlen(original_name); ++i) {
+       j=0;
+       for (i=0; i<len; ++i) {
                if (original_name[i] == ';') {
-                       strcat(name, ", ");
+                       name[j++] = ',';
+                       name[j++] = ' ';                        
                }
                else {
-                       name[strlen(name)+1] = 0;
-                       name[strlen(name)] = original_name[i];
+                       name[j++] = original_name[i];
                }
        }
+       name[j] = '\0';
        free(original_name);
 }
 
@@ -422,7 +429,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
        for (pass=1; pass<=2; ++pass) {
 
                if (v->numprops) for (i=0; i<(v->numprops); ++i) {
-
+                       int len;
                        thisname = strdup(v->prop[i].name);
                        extract_token(firsttoken, thisname, 0, ';', sizeof firsttoken);
        
@@ -437,16 +444,20 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                        remove_token(thisname, j, ';');
                                }
                        }
+                       
+                       len = strlen(v->prop[i].value);
        
                        if (is_qp) {
-                               thisvalue = malloc(strlen(v->prop[i].value) + 50);
+                               // %ff can become 6 bytes in utf8 
+                               thisvalue = malloc(len * 2 + 3); 
                                j = CtdlDecodeQuotedPrintable(
                                        thisvalue, v->prop[i].value,
-                                       strlen(v->prop[i].value) );
+                                       len);
                                thisvalue[j] = 0;
                        }
                        else if (is_b64) {
-                               thisvalue = malloc(strlen(v->prop[i].value) + 50);
+                               // ff will become one byte..
+                               thisvalue = malloc(len + 50);
                                CtdlDecodeBase64(
                                        thisvalue, v->prop[i].value,
                                        strlen(v->prop[i].value) );
@@ -459,7 +470,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
        
                        /** N is name, but only if there's no FN already there */
                        if (!strcasecmp(firsttoken, "n")) {
-                               if (strlen(fullname) == 0) {
+                               if (IsEmptyStr(fullname)) {
                                        strcpy(fullname, thisvalue);
                                        vcard_n_prettyize(fullname);
                                }
@@ -481,7 +492,8 @@ void display_parsed_vcard(struct vCard *v, int full) {
                        }
        
                        else if (!strcasecmp(firsttoken, "email")) {
-                               if (strlen(mailto) > 0) strcat(mailto, "<br />");
+                               if (!IsEmptyStr(mailto)) strcat(mailto, "<br />");
+                               long len;
                                strcat(mailto,
                                        "<a href=\"display_enter"
                                        "?force_room=_MAIL_?recp=");
@@ -492,11 +504,12 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                urlesc(&mailto[strlen(mailto)], ">");
 
                                strcat(mailto, "\">");
-                               stresc(&mailto[strlen(mailto)], thisvalue, 1, 1);
+                               len = strlen(mailto);
+                               stresc(mailto+len, SIZ - len, thisvalue, 1, 1);
                                strcat(mailto, "</A>");
                        }
                        else if (!strcasecmp(firsttoken, "tel")) {
-                               if (strlen(phone) > 0) strcat(phone, "<br />");
+                               if (!IsEmptyStr(phone)) strcat(phone, "<br />");
                                strcat(phone, thisvalue);
                                for (j=0; j<num_tokens(thisname, ';'); ++j) {
                                        extract_token(buf, thisname, j, ';', sizeof buf);
@@ -522,7 +535,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                        wprintf("</TD><TD>");
                                        for (j=0; j<num_tokens(thisvalue, ';'); ++j) {
                                                extract_token(buf, thisvalue, j, ';', sizeof buf);
-                                               if (strlen(buf) > 0) {
+                                               if (!IsEmptyStr(buf)) {
                                                        escputs(buf);
                                                        if (j<3) wprintf("<br />");
                                                        else wprintf(" ");
@@ -564,24 +577,24 @@ void display_parsed_vcard(struct vCard *v, int full) {
                        "<FONT SIZE=+1><B>");
                        escputs(fullname);
                        wprintf("</B></FONT>");
-                       if (strlen(title) > 0) {
+                       if (!IsEmptyStr(title)) {
                                wprintf("<div align=right>");
                                escputs(title);
                                wprintf("</div>");
                        }
-                       if (strlen(org) > 0) {
+                       if (!IsEmptyStr(org)) {
                                wprintf("<div align=right>");
                                escputs(org);
                                wprintf("</div>");
                        }
                        wprintf("</TD></TR>\n");
                
-                       if (strlen(phone) > 0) {
+                       if (!IsEmptyStr(phone)) {
                                wprintf("<tr><td>");
                                wprintf(_("Telephone:"));
                                wprintf("</td><td>%s</td></tr>\n", phone);
                        }
-                       if (strlen(mailto) > 0) {
+                       if (!IsEmptyStr(mailto)) {
                                wprintf("<tr><td>");
                                wprintf(_("E-mail:"));
                                wprintf("</td><td>%s</td></tr>\n", mailto);
@@ -713,6 +726,7 @@ void read_message(long msgnum, int printable_view, char *section) {
 
        /** begin message header table */
        wprintf("<div class=\"message_header\">");
+
        strcpy(m_subject, "");
        strcpy(m_cc, "");
 
@@ -746,12 +760,14 @@ void read_message(long msgnum, int printable_view, char *section) {
                        safestrncpy(m_subject, &buf[5], sizeof m_subject);
                }
                if (!strncasecmp(buf, "cccc=", 5)) {
+                       int len;
                        safestrncpy(m_cc, &buf[5], sizeof m_cc);
-                       if (strlen(reply_all) > 0) {
+                       if (!IsEmptyStr(reply_all)) {
                                strcat(reply_all, ", ");
                        }
-                       safestrncpy(&reply_all[strlen(reply_all)], &buf[5],
-                               (sizeof reply_all - strlen(reply_all)) );
+                       len = strlen(reply_all);
+                       safestrncpy(&reply_all[len], &buf[5],
+                               (sizeof reply_all - len) );
                }
                if ((!strncasecmp(buf, "hnod=", 5))
                    && (strcasecmp(&buf[5], serv_info.serv_humannode))) {
@@ -759,7 +775,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
                if ((!strncasecmp(buf, "room=", 5))
                    && (strcasecmp(&buf[5], WC->wc_roomname))
-                   && (strlen(&buf[5])>0) ) {
+                   && (!IsEmptyStr(&buf[5])) ) {
                        wprintf(_("in "));
                        wprintf("%s&gt; ", &buf[5]);
                }
@@ -775,18 +791,20 @@ void read_message(long msgnum, int printable_view, char *section) {
                        if ( ((WC->room_flags & QR_NETWORK)
                        || ((strcasecmp(&buf[5], serv_info.serv_nodename)
                        && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
-                       && (strlen(rfca)==0)
+                       && (IsEmptyStr(rfca))
                        ) {
                                wprintf("@%s ", &buf[5]);
                        }
                }
                if (!strncasecmp(buf, "rcpt=", 5)) {
+                       int len;
                        wprintf(_("to "));
-                       if (strlen(reply_all) > 0) {
+                       if (!IsEmptyStr(reply_all)) {
                                strcat(reply_all, ", ");
                        }
-                       safestrncpy(&reply_all[strlen(reply_all)], &buf[5],
-                               (sizeof reply_all - strlen(reply_all)) );
+                       len = strlen(reply_all);
+                       safestrncpy(&reply_all[len], &buf[5],
+                               (sizeof reply_all - len) );
 #ifdef HAVE_ICONV
                        utf8ify_rfc822_string(&buf[5]);
 #endif
@@ -795,7 +813,9 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
                if (!strncasecmp(buf, "time=", 5)) {
                        fmt_date(now, atol(&buf[5]), 0);
+                       wprintf("<span>");
                        wprintf("%s ", now);
+                       wprintf("</span>");
                }
 
                if (!strncasecmp(buf, "part=", 5)) {
@@ -808,12 +828,12 @@ void read_message(long msgnum, int printable_view, char *section) {
 
                        striplt(mime_name);
                        striplt(mime_filename);
-                       if ( (strlen(mime_filename) == 0) && (strlen(mime_name) > 0) ) {
+                       if ( (IsEmptyStr(mime_filename)) && (!IsEmptyStr(mime_name)) ) {
                                strcpy(mime_filename, mime_name);
                        }
 
                        if (!strcasecmp(mime_content_type, "message/rfc822")) {
-                               if (strlen(mime_submessages) > 0) {
+                               if (!IsEmptyStr(mime_submessages)) {
                                        strcat(mime_submessages, "|");
                                }
                                strcat(mime_submessages, mime_partnum);
@@ -831,7 +851,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        else if ( ( (!strcasecmp(mime_disposition, "attachment")) 
                             || (!strcasecmp(mime_disposition, "inline"))
                             || (!strcasecmp(mime_disposition, ""))
-                            ) && (strlen(mime_content_type) > 0)
+                            ) && (!IsEmptyStr(mime_content_type))
                        ) {
                                ++num_attach_links;
                                attach_links = realloc(attach_links,
@@ -873,8 +893,8 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Generate a reply-to address */
-       if (strlen(rfca) > 0) {
-               if (strlen(from) > 0) {
+       if (!IsEmptyStr(rfca)) {
+               if (!IsEmptyStr(from)) {
                        snprintf(reply_to, sizeof(reply_to), "%s <%s>", from, rfca);
                }
                else {
@@ -882,7 +902,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
        }
        else {
-               if ( (strlen(node) > 0)
+       if ((!IsEmptyStr(node))
                   && (strcasecmp(node, serv_info.serv_nodename))
                   && (strcasecmp(node, serv_info.serv_humannode)) ) {
                        snprintf(reply_to, sizeof(reply_to), "%s @ %s",
@@ -897,31 +917,15 @@ void read_message(long msgnum, int printable_view, char *section) {
                wprintf("****");
        }
 
-       wprintf("</div>");
-
 #ifdef HAVE_ICONV
        utf8ify_rfc822_string(m_cc);
        utf8ify_rfc822_string(m_subject);
 #endif
-       if (strlen(m_cc) > 0) {
-               wprintf("<div class=\"message_subject\">");
-               wprintf(_("CC:"));
-               wprintf(" ");
-               escputs(m_cc);
-               wprintf("</div>");
-       }
-       if (strlen(m_subject) > 0) {
-               wprintf("<div class=\"message_subject\">");
-               wprintf(_("Subject:"));
-               wprintf(" ");
-               escputs(m_subject);
-               wprintf("</div>");
-       }
-
 
         /** start msg buttons */
+
         if (!printable_view) {
-                wprintf("<div id=\"msg%ld\" class=\"msgbuttons\" >\n",msgnum);
+                wprintf("<p id=\"msg%ld\" class=\"msgbuttons\" >\n",msgnum);
 
                /** Reply */
                if ( (WC->wc_view == VIEW_MAILBOX) || (WC->wc_view == VIEW_BBS) ) {
@@ -931,7 +935,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        }
                        wprintf("?recp=");
                        urlescputs(reply_to);
-                       if (strlen(m_subject) > 0) {
+                       if (!IsEmptyStr(m_subject)) {
                                wprintf("?subject=");
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
@@ -946,7 +950,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                                wprintf("?replyquote=%ld", msgnum);
                                wprintf("?recp=");
                                urlescputs(reply_to);
-                               if (strlen(m_subject) > 0) {
+                               if (!IsEmptyStr(m_subject)) {
                                        wprintf("?subject=");
                                        if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                        urlescputs(m_subject);
@@ -963,7 +967,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        urlescputs(reply_to);
                        wprintf("?cc=");
                        urlescputs(reply_all);
-                       if (strlen(m_subject) > 0) {
+                       if (!IsEmptyStr(m_subject)) {
                                wprintf("?subject=");
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
@@ -1002,11 +1006,26 @@ void read_message(long msgnum, int printable_view, char *section) {
                wprintf("<a href=\"#\" onClick=\"window.open('printmsg/%ld', 'print%ld', 'toolbar=no,location=no,directories=no,copyhistory=no,status=yes,scrollbars=yes,resizable=yes,width=600,height=400'); \" >"
                        "<span>[</span>%s<span>]</span></a>", msgnum, msgnum, _("Print"));
 
-               wprintf("</div>");
+               wprintf("</p>");
 
        }
 
+       if (!IsEmptyStr(m_cc)) {
+               wprintf("<p>");
+               wprintf(_("CC:"));
+               wprintf(" ");
+               escputs(m_cc);
+               wprintf("</p>");
+       }
+       if (!IsEmptyStr(m_subject)) {
+               wprintf("<p class=\"message_subject\">");
+               wprintf(_("Subject:"));
+               wprintf(" ");
+               escputs(m_subject);
+               wprintf("</p>");
+       }
 
+       wprintf("</div>");
 
        /** Begin body */
        wprintf("<div class=\"message_content\">");
@@ -1015,7 +1034,7 @@ void read_message(long msgnum, int printable_view, char *section) {
         * Learn the content type
         */
        strcpy(mime_content_type, "text/plain");
-       while (serv_getln(buf, sizeof buf), (strlen(buf) > 0)) {
+       while (serv_getln(buf, sizeof buf), (!IsEmptyStr(buf))) {
                if (!strcmp(buf, "000")) {
                        wprintf("<i>");
                        wprintf(_("unexpected end of message"));
@@ -1027,22 +1046,27 @@ void read_message(long msgnum, int printable_view, char *section) {
                        striplt(msg4_partnum);
                }
                if (!strncasecmp(buf, "Content-type:", 13)) {
+                       int len;
                        safestrncpy(mime_content_type, &buf[13], sizeof(mime_content_type));
                        striplt(mime_content_type);
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       len = strlen(mime_content_type);
+                       for (i=0; i<len; ++i) {
                                if (!strncasecmp(&mime_content_type[i], "charset=", 8)) {
                                        safestrncpy(mime_charset, &mime_content_type[i+8],
                                                sizeof mime_charset);
                                }
                        }
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       for (i=0; i<len; ++i) {
                                if (mime_content_type[i] == ';') {
                                        mime_content_type[i] = 0;
+                                       len = i - 1;
                                }
                        }
-                       for (i=0; i<strlen(mime_charset); ++i) {
+                       len = strlen(mime_charset);
+                       for (i=0; i<len; ++i) {
                                if (mime_charset[i] == ';') {
                                        mime_charset[i] = 0;
+                                       len = i - 1;
                                }
                        }
                }
@@ -1071,9 +1095,12 @@ void read_message(long msgnum, int printable_view, char *section) {
        /** Boring old 80-column fixed format text gets handled this way... */
        else if ( (!strcasecmp(mime_content_type, "text/plain"))
                || (!strcasecmp(mime_content_type, "text")) ) {
+               buf [0] = '\0';
                while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
-                       if (buf[strlen(buf)-1] == '\n') buf[strlen(buf)-1] = 0;
-                       if (buf[strlen(buf)-1] == '\r') buf[strlen(buf)-1] = 0;
+                       int len;
+                       len = strlen(buf);
+                       if ((len > 0) && buf[len-1] == '\n') buf[--len] = 0;
+                       if ((len > 0) && buf[len-1] == '\r') buf[--len] = 0;
 
 #ifdef HAVE_ICONV
                        if (ic != (iconv_t)(-1) ) {
@@ -1089,8 +1116,9 @@ void read_message(long msgnum, int printable_view, char *section) {
                        }
 #endif
 
-                       while ((strlen(buf) > 0) && (isspace(buf[strlen(buf) - 1])))
-                               buf[strlen(buf) - 1] = 0;
+                       len = strlen(buf);
+                       while ((!IsEmptyStr(buf)) && (isspace(buf[len-1])))
+                               buf[--len] = 0;
                        if ((bq == 0) &&
                        ((!strncmp(buf, ">", 1)) || (!strncmp(buf, " >", 2)) )) {
                                wprintf("<blockquote>");
@@ -1121,7 +1149,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** If there are attached submessages, display them now... */
-       if ( (strlen(mime_submessages) > 0) && (!section[0]) ) {
+       if ( (!IsEmptyStr(mime_submessages)) && (!section[0]) ) {
                for (i=0; i<num_tokens(mime_submessages, '|'); ++i) {
                        extract_token(buf, mime_submessages, i, '|', sizeof buf);
                        /** use printable_view to suppress buttons */
@@ -1142,7 +1170,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Handler for vCard parts */
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                part_source = load_mimepart(msgnum, vcard_partnum);
                if (part_source != NULL) {
 
@@ -1163,7 +1191,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Handler for calendar parts */
-       if (strlen(cal_partnum) > 0) {
+       if (!IsEmptyStr(cal_partnum)) {
                part_source = load_mimepart(msgnum, cal_partnum);
                if (part_source != NULL) {
                        cal_process_attachment(part_source,
@@ -1362,7 +1390,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
                        if ((!strncasecmp(buf, "room=", 5))
                            && (strcasecmp(&buf[5], WC->wc_roomname))
-                           && (strlen(&buf[5])>0) ) {
+                           && (!IsEmptyStr(&buf[5])) ) {
                                wprintf(_("in "));
                                wprintf("%s&gt; ", &buf[5]);
                        }
@@ -1378,7 +1406,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                if ( ((WC->room_flags & QR_NETWORK)
                                || ((strcasecmp(&buf[5], serv_info.serv_nodename)
                                && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
-                               && (strlen(rfca)==0)
+                               && (IsEmptyStr(rfca))
                                ) {
                                        wprintf("@%s ", &buf[5]);
                                }
@@ -1419,7 +1447,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
 #ifdef HAVE_ICONV
                utf8ify_rfc822_string(m_subject);
 #endif
-               if (strlen(m_subject) > 0) {
+               if (!IsEmptyStr(m_subject)) {
                        wprintf(_("Subject:"));
                        wprintf(" ");
                        msgescputs(m_subject);
@@ -1436,12 +1464,13 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
         * Learn the content type
         */
        strcpy(mime_content_type, "text/plain");
-       while (serv_getln(buf, sizeof buf), (strlen(buf) > 0)) {
+       while (serv_getln(buf, sizeof buf), (!IsEmptyStr(buf))) {
                if (!strcmp(buf, "000")) {
                        wprintf("%s (4)", _("unexpected end of message"));
                        goto ENDBODY;
                }
                if (!strncasecmp(buf, "Content-type: ", 14)) {
+                       int len;
                        safestrncpy(mime_content_type, &buf[14],
                                sizeof(mime_content_type));
                        for (i=0; i<strlen(mime_content_type); ++i) {
@@ -1450,14 +1479,18 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                                sizeof mime_charset);
                                }
                        }
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       len = strlen(mime_content_type);
+                       for (i=0; i<len; ++i) {
                                if (mime_content_type[i] == ';') {
                                        mime_content_type[i] = 0;
+                                       len = i - 1;
                                }
                        }
-                       for (i=0; i<strlen(mime_charset); ++i) {
+                       len = strlen(mime_charset);
+                       for (i=0; i<len; ++i) {
                                if (mime_charset[i] == ';') {
                                        mime_charset[i] = 0;
+                                       len = i - 1;
                                }
                        }
                }
@@ -1485,13 +1518,15 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
        /* Boring old 80-column fixed format text gets handled this way... */
        else if (!strcasecmp(mime_content_type, "text/plain")) {
                while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
-                       if (buf[strlen(buf)-1] == '\n') buf[strlen(buf)-1] = 0;
-                       if (buf[strlen(buf)-1] == '\r') buf[strlen(buf)-1] = 0;
+                       int len;
+                       len = strlen(buf);
+                       if (buf[len-1] == '\n') buf[--len] = 0;
+                       if (buf[len-1] == '\r') buf[--len] = 0;
 
 #ifdef HAVE_ICONV
                        if (ic != (iconv_t)(-1) ) {
                                ibuf = buf;
-                               ibuflen = strlen(ibuf);
+                               ibuflen = len;
                                obuflen = SIZ;
                                obuf = (char *) malloc(obuflen);
                                osav = obuf;
@@ -1502,8 +1537,9 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
 #endif
 
-                       while ((strlen(buf) > 0) && (isspace(buf[strlen(buf) - 1])))
-                               buf[strlen(buf) - 1] = 0;
+                       len = strlen(buf);
+                       while ((!IsEmptyStr(buf)) && (isspace(buf[len - 1]))) 
+                               buf[--len] = 0;
                        if ((bq == 0) &&
                        ((!strncmp(buf, ">", 1)) || (!strncmp(buf, " >", 2)) )) {
                                wprintf("<blockquote>");
@@ -1515,7 +1551,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
                        wprintf("<tt>");
                        url(buf);
-                       msgescputs(buf);
+                       msgescputs1(buf);
                        wprintf("</tt><br />");
                }
                wprintf("</i><br />");
@@ -1670,7 +1706,7 @@ void display_addressbook(long msgnum, char alpha) {
                }
        }
 
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                vcard_source = load_mimepart(msgnum, vcard_partnum);
                if (vcard_source != NULL) {
 
@@ -1731,7 +1767,7 @@ void fetch_ab_name(long msgnum, char *namebuf) {
        int mime_length;
        char vcard_partnum[SIZ];
        char *vcard_source = NULL;
-       int i;
+       int i, len;
        struct message_summary summ;
 
        if (namebuf == NULL) return;
@@ -1761,7 +1797,7 @@ void fetch_ab_name(long msgnum, char *namebuf) {
                }
        }
 
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                vcard_source = load_mimepart(msgnum, vcard_partnum);
                if (vcard_source != NULL) {
 
@@ -1774,7 +1810,8 @@ void fetch_ab_name(long msgnum, char *namebuf) {
 
        lastfirst_firstlast(namebuf);
        striplt(namebuf);
-       for (i=0; i<strlen(namebuf); ++i) {
+       len = strlen(namebuf);
+       for (i=0; i<len; ++i) {
                if (namebuf[i] != ';') return;
        }
        strcpy(namebuf, _("(no name)"));
@@ -1801,8 +1838,8 @@ int abcmp(const void *ab1, const void *ab2) {
  * \param tabbuf the tabbuffer to add name to
  * \param name the name to add to the tabbuffer
  */
-void nametab(char *tabbuf, char *name) {
-       stresc(tabbuf, name, 0, 0);
+void nametab(char *tabbuf, long len, char *name) {
+       stresc(tabbuf, len, name, 0, 0);
        tabbuf[0] = toupper(tabbuf[0]);
        tabbuf[1] = tolower(tabbuf[1]);
        tabbuf[2] = tolower(tabbuf[2]);
@@ -1854,8 +1891,8 @@ void do_addrbook_view(struct addrbookent *addrbook, int num_ab) {
                tabfirst = i * NAMESPERPAGE;
                tablast = tabfirst + NAMESPERPAGE - 1;
                if (tablast > (num_ab - 1)) tablast = (num_ab - 1);
-               nametab(tabfirst_label, addrbook[tabfirst].ab_name);
-               nametab(tablast_label, addrbook[tablast].ab_name);
+               nametab(tabfirst_label, 64, addrbook[tabfirst].ab_name);
+               nametab(tablast_label, 64, addrbook[tablast].ab_name);
                sprintf(this_tablabel, "%s&nbsp;-&nbsp;%s", tabfirst_label, tablast_label);
                tablabels[i] = strdup(this_tablabel);
        }
@@ -1964,11 +2001,11 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                WC->summ[nummsgs-1].msgnum = WC->msgarr[nummsgs-1];
                                safestrncpy(WC->summ[nummsgs-1].subj,
                                        _("(no subject)"), sizeof WC->summ[nummsgs-1].subj);
-                               if (strlen(fullname) > 0) {
+                               if (!IsEmptyStr(fullname)) {
                                        safestrncpy(WC->summ[nummsgs-1].from,
                                                fullname, sizeof WC->summ[nummsgs-1].from);
                                }
-                               if (strlen(subject) > 0) {
+                               if (!IsEmptyStr(subject)) {
                                safestrncpy(WC->summ[nummsgs-1].subj, subject,
                                        sizeof WC->summ[nummsgs-1].subj);
                                }
@@ -1980,7 +2017,7 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                        strcpy(&WC->summ[nummsgs-1].subj[72], "...");
                                }
 
-                               if (strlen(nodename) > 0) {
+                               if (!IsEmptyStr(nodename)) {
                                        if ( ((WC->room_flags & QR_NETWORK)
                                           || ((strcasecmp(nodename, serv_info.serv_nodename)
                                           && (strcasecmp(nodename, serv_info.serv_fqdn)))))
@@ -2173,13 +2210,13 @@ void readloop(char *oper)
        get_preference(sortpref_name, sortpref_value, sizeof sortpref_value);
 
        sortby = bstr("sortby");
-       if ( (strlen(sortby) > 0) && (strcasecmp(sortby, sortpref_value)) ) {
+       if ( (!IsEmptyStr(sortby)) && (strcasecmp(sortby, sortpref_value)) ) {
                set_preference(sortpref_name, sortby, 1);
        }
-       if (strlen(sortby) == 0) sortby = sortpref_value;
+       if (IsEmptyStr(sortby)) sortby = sortpref_value;
 
        /** mailbox sort */
-       if (strlen(sortby) == 0) sortby = "rdate";
+       if (IsEmptyStr(sortby)) sortby = "rdate";
 
        /** message board sort */
        if (!strcasecmp(sortby, "reverse")) {
@@ -2418,6 +2455,102 @@ void readloop(char *oper)
                );
        }
 
+
+       /**
+        * Set the "is_bbview" variable if it appears that we are looking at
+        * a classic bulletin board view.
+        */
+       if ((!is_tasks) && (!is_calendar) && (!is_addressbook)
+             && (!is_notes) && (!is_singlecard) && (!is_summary)) {
+               is_bbview = 1;
+       }
+
+       /**
+        * If we're not currently looking at ALL requested
+        * messages, then display the selector bar
+        */
+       if (is_bbview) {
+               /** begin bbview scroller */
+               wprintf("<form name=\"msgomatictop\" class=\"selector_top\" >");
+               wprintf(_("Reading #"), lowest_displayed, highest_displayed);
+
+               wprintf("<select name=\"whichones\" size=\"1\" "
+                       "OnChange=\"location.href=msgomatictop.whichones.options"
+                       "[selectedIndex].value\">\n");
+
+               if (bbs_reverse) {
+                       for (b=nummsgs-1; b>=0; b = b - maxmsgs) {
+                               hi = b + 1;
+                               lo = b - maxmsgs + 2;
+                               if (lo < 1) lo = 1;
+                               wprintf("<option %s value="
+                                       "\"%s"
+                                       "?startmsg=%ld"
+                                       "?maxmsgs=%d"
+                                       "?summary=%d\">"
+                                       "%d-%d</option> \n",
+                                       ((WC->msgarr[lo-1] == startmsg) ? "selected" : ""),
+                                       oper,
+                                       WC->msgarr[lo-1],
+                                       maxmsgs,
+                                       is_summary,
+                                       hi, lo);
+                       }
+               }
+               else {
+                       for (b=0; b<nummsgs; b = b + maxmsgs) {
+                               lo = b + 1;
+                               hi = b + maxmsgs + 1;
+                               if (hi > nummsgs) hi = nummsgs;
+                               wprintf("<option %s value="
+                                       "\"%s"
+                                       "?startmsg=%ld"
+                                       "?maxmsgs=%d"
+                                       "?summary=%d\">"
+                                       "%d-%d</option> \n",
+                                       ((WC->msgarr[b] == startmsg) ? "selected" : ""),
+                                       oper,
+                                       WC->msgarr[lo-1],
+                                       maxmsgs,
+                                       is_summary,
+                                       lo, hi);
+                       }
+               }
+
+               wprintf("<option value=\"%s?startmsg=%ld"
+                       "?maxmsgs=9999999?summary=%d\">",
+                       oper,
+                       WC->msgarr[0], is_summary);
+               wprintf(_("All"));
+               wprintf("</option>");
+               wprintf("</select> ");
+               wprintf(_("of %d messages."), nummsgs);
+
+               /** forward/reverse */
+               wprintf("<input type=\"radio\" %s name=\"direction\" value=\"\""
+                       "OnChange=\"location.href='%s?sortby=forward'\"",  
+                       (bbs_reverse ? "" : "checked"),
+                       oper
+               );
+               wprintf(">");
+               wprintf(_("oldest to newest"));
+               wprintf("&nbsp;&nbsp;&nbsp;&nbsp;");
+
+               wprintf("<input type=\"radio\" %s name=\"direction\" value=\"\""
+                       "OnChange=\"location.href='%s?sortby=reverse'\"", 
+                       (bbs_reverse ? "checked" : ""),
+                       oper
+               );
+               wprintf(">");
+               wprintf(_("newest to oldest"));
+               wprintf("\n");
+       
+               wprintf("</select></form>\n");
+               /** end bbview scroller */
+       }
+
+
+
        for (a = 0; a < nummsgs; ++a) {
                if ((WC->msgarr[a] >= startmsg) && (num_displayed < maxmsgs)) {
 
@@ -2458,14 +2591,6 @@ void readloop(char *oper)
                }
        }
 
-       /**
-        * Set the "is_bbview" variable if it appears that we are looking at
-        * a classic bulletin board view.
-        */
-       if ((!is_tasks) && (!is_calendar) && (!is_addressbook)
-             && (!is_notes) && (!is_singlecard) && (!is_summary)) {
-               is_bbview = 1;
-       }
 
        /** Output loop */
        if (displayed_msgs != NULL) {
@@ -2513,7 +2638,7 @@ void readloop(char *oper)
         */
        if (is_bbview) {
                /** begin bbview scroller */
-               wprintf("<form name=\"msgomatic\">");
+               wprintf("<form name=\"msgomatic\" class=\"selector_bottom\" >");
                wprintf(_("Reading #"), lowest_displayed, highest_displayed);
 
                wprintf("<select name=\"whichones\" size=\"1\" "
@@ -2560,32 +2685,33 @@ void readloop(char *oper)
                }
 
                wprintf("<option value=\"%s?startmsg=%ld"
-                       "?maxmsgs=9999999?summary=%d\">"
-                       "ALL"
-                       "</option> ",
+                       "?maxmsgs=9999999?summary=%d\">",
                        oper,
                        WC->msgarr[0], is_summary);
-
+               wprintf(_("All"));
+               wprintf("</option>");
                wprintf("</select> ");
                wprintf(_("of %d messages."), nummsgs);
 
                /** forward/reverse */
-               wprintf("&nbsp;<select name=\"direction\" size=\"1\" "
-                       "OnChange=\"location.href=msgomatic.direction.options"
-                       "[selectedIndex].value\">\n"
-               );
-
-               wprintf("<option %s value=\"%s?sortby=forward\">oldest to newest</option>\n",
-                       (bbs_reverse ? "" : "selected"),
+               wprintf("<input type=\"radio\" %s name=\"direction\" value=\"\""
+                       "OnChange=\"location.href='%s?sortby=forward'\"",  
+                       (bbs_reverse ? "" : "checked"),
                        oper
                );
-       
-               wprintf("<option %s value=\"%s?sortby=reverse\">newest to oldest</option>\n",
-                       (bbs_reverse ? "selected" : ""),
+               wprintf(">");
+               wprintf(_("oldest to newest"));
+               wprintf("&nbsp;&nbsp;&nbsp;&nbsp;");
+               wprintf("<input type=\"radio\" %s name=\"direction\" value=\"\""
+                       "OnChange=\"location.href='%s?sortby=reverse'\"", 
+                       (bbs_reverse ? "checked" : ""),
                        oper
                );
-       
-               wprintf("</select></form>\n");
+               wprintf(">");
+               wprintf(_("newest to oldest"));
+               wprintf("\n");
+
+               wprintf("</form>\n");
                /** end bbview scroller */
        }
 
@@ -2756,10 +2882,10 @@ void post_message(void)
                return;
        }
 
-       if (strlen(bstr("cancel_button")) > 0) {
+       if (!IsEmptyStr(bstr("cancel_button"))) {
                sprintf(WC->ImportantMessage, 
                        _("Cancelled.  Message was not posted."));
-       } else if (strlen(bstr("attach_button")) > 0) {
+       } else if (!IsEmptyStr(bstr("attach_button"))) {
                display_enter();
                return;
        } else if (atol(bstr("postseq")) == dont_post) {
@@ -2782,9 +2908,9 @@ void post_message(void)
                serv_getln(buf, sizeof buf);
                if (buf[0] == '4') {
                        post_mime_to_server();
-                       if ( (strlen(bstr("recp")) > 0)
-                          || (strlen(bstr("cc")) > 0)
-                          || (strlen(bstr("bcc")) > 0)
+                       if (  (!IsEmptyStr(bstr("recp")))
+                          || (!IsEmptyStr(bstr("cc"  )))
+                          || (!IsEmptyStr(bstr("bcc" )))
                        ) {
                                sprintf(WC->ImportantMessage, _("Message has been sent.\n"));
                        }
@@ -2806,13 +2932,13 @@ void post_message(void)
         *  We may have been supplied with instructions regarding the location
         *  to which we must return after posting.  If found, go there.
         */
-       if (strlen(bstr("return_to")) > 0) {
+       if (!IsEmptyStr(bstr("return_to"))) {
                http_redirect(bstr("return_to"));
        }
        /**
         *  If we were editing a page in a wiki room, go to that page now.
         */
-       else if (strlen(bstr("wikipage")) > 0) {
+       else if (!IsEmptyStr(bstr("wikipage"))) {
                snprintf(buf, sizeof buf, "wiki?page=%s", bstr("wikipage"));
                http_redirect(buf);
        }
@@ -2846,7 +2972,7 @@ void display_enter(void)
 
        now = time(NULL);
 
-       if (strlen(bstr("force_room")) > 0) {
+       if (!IsEmptyStr(bstr("force_room"))) {
                gotoroom(bstr("force_room"));
        }
 
@@ -2925,7 +3051,9 @@ void display_enter(void)
                serv_getln(buf, sizeof buf);
 
                if (!strncmp(buf, "570", 3)) {  /** 570 means we have an invalid recipient listed */
-                       if (strlen(bstr("recp")) + strlen(bstr("cc")) + strlen(bstr("bcc")) > 0) {
+                       if (!IsEmptyStr(bstr("recp")) && 
+                           !IsEmptyStr(bstr("cc"  )) && 
+                           !IsEmptyStr(bstr("bcc" ))) {
                                recipient_bad = 1;
                        }
                }
@@ -3121,10 +3249,12 @@ void display_enter(void)
        if ( (WC->is_mailbox) && (strcmp(bstr("sig_inserted"), "yes")) ) {
                get_preference("use_sig", buf, sizeof buf);
                if (!strcasecmp(buf, "yes")) {
+                       int len;
                        get_preference("signature", ebuf, sizeof ebuf);
                        euid_unescapize(buf, ebuf);
                        wprintf("<br>--<br>");
-                       for (i=0; i<strlen(buf); ++i) {
+                       len = strlen(buf);
+                       for (i=0; i<len; ++i) {
                                if (buf[i] == '\n') {
                                        wprintf("<br>");
                                }
@@ -3159,7 +3289,7 @@ void display_enter(void)
        do_template("richedit");
 
        /** Enumerate any attachments which are already in place... */
-       wprintf("<div><img src=\"static/diskette_24x.gif\" class=\"imgedit\" ");
+       wprintf("<div class=\"attachment buttons\"><img src=\"static/diskette_24x.gif\" class=\"imgedit\" > ");
        wprintf(_("Attachments:"));
        wprintf(" ");
        wprintf("<select name=\"which_attachment\" size=1>");
@@ -3176,7 +3306,7 @@ void display_enter(void)
        /** Now offer the ability to attach additional files... */
        wprintf("&nbsp;&nbsp;&nbsp;");
        wprintf(_("Attach file:"));
-       wprintf(" <input name=\"attachfile\" "
+       wprintf(" <input name=\"attachfile\" class=\"attachfile\" "
                "size=16 type=\"file\">\n&nbsp;&nbsp;"
                "<input type=\"submit\" name=\"attach_button\" value=\"%s\">\n", _("Add"));
        wprintf("</div>");
@@ -3229,7 +3359,7 @@ void move_msg(void)
 
        msgid = atol(bstr("msgid"));
 
-       if (strlen(bstr("move_button")) > 0) {
+       if (!IsEmptyStr(bstr("move_button"))) {
                sprintf(buf, "MOVE %ld|%s", msgid, bstr("target_room"));
                serv_puts(buf);
                serv_getln(buf, sizeof buf);
@@ -3259,12 +3389,12 @@ void confirm_move_msg(void)
 
        output_headers(1, 1, 2, 0, 0, 0);
        wprintf("<div id=\"banner\">\n");
-       wprintf("<TABLE WIDTH=100%% BORDER=0><TR><TD>");
-       wprintf("<SPAN CLASS=\"titlebar\">");
+       wprintf("<h1>");
        wprintf(_("Confirm move of message"));
-       wprintf("</SPAN>\n");
-       wprintf("</TD></TR></TABLE>\n");
-       wprintf("</div>\n<div id=\"content\">\n");
+       wprintf("</h1>");
+       wprintf("</div>\n");
+
+       wprintf("<div id=\"content\" class=\"service\">\n");
 
        wprintf("<CENTER>");