]> code.citadel.org Git - citadel.git/blobdiff - webcit/messages.c
* migrated SUBST stuff to hash
[citadel.git] / webcit / messages.c
index d12d54e99130a81e1b19abf767c3ad7e61df04e7..ab45068e9d0c99ad801bc08e1d743d2ddf01e000 100644 (file)
@@ -13,7 +13,7 @@
 #define SENDER_COL_WIDTH_PCT           30      /**< Mailbox view column width */
 #define DATE_PLUS_BUTTONS_WIDTH_PCT    20      /**< Mailbox view column width */
 
-/**
+/*
  * Address book entry (keep it short and sweet, it's just a quickie lookup
  * which we can use to get to the real meat and bones later)
  */
@@ -26,13 +26,13 @@ struct addrbookent {
 
 #ifdef HAVE_ICONV
 
-/**
- * \brief      Wrapper around iconv_open()
- *             Our version adds aliases for non-standard Microsoft charsets
- *           such as 'MS950', aliasing them to names like 'CP950'
+/*
+ * Wrapper around iconv_open()
+ * Our version adds aliases for non-standard Microsoft charsets
+ * such as 'MS950', aliasing them to names like 'CP950'
  *
- * \param      tocode          Target encoding
- * \param      fromcode        Source encoding
+ * tocode      Target encoding
+ * fromcode    Source encoding
  */
 iconv_t ctdl_iconv_open(const char *tocode, const char *fromcode)
 {
@@ -51,11 +51,27 @@ iconv_t ctdl_iconv_open(const char *tocode, const char *fromcode)
 }
 
 
-/**
- * \brief  Handle subjects with RFC2047 encoding
- *  such as:
+
+inline char *FindNextEnd (char *bptr)
+{
+       char * end;
+       /* Find the next ?Q? */
+       end = strchr(bptr + 2, '?');
+       if (end == NULL) return NULL;
+       if (((*(end + 1) == 'B') || (*(end + 1) == 'Q')) && 
+           (*(end + 2) == '?')) {
+               /* skip on to the end of the cluster, the next ?= */
+               end = strstr(end + 3, "?=");
+       }
+       else
+               /* sort of half valid encoding, try to find an end. */
+               end = strstr(bptr, "?=");
+       return end;
+}
+
+/*
+ * Handle subjects with RFC2047 encoding such as:
  * =?koi8-r?B?78bP0s3Mxc7JxSDXz9rE1dvO2c3JINvB0sHNySDP?=
- * \param buf the stringbuffer to process
  */
 void utf8ify_rfc822_string(char *buf) {
        char *start, *end, *next, *nextend, *ptr;
@@ -74,7 +90,7 @@ void utf8ify_rfc822_string(char *buf) {
        int i, len, delta;
        int illegal_non_rfc2047_encoding = 0;
 
-       /** Sometimes, badly formed messages contain strings which were simply
+       /* Sometimes, badly formed messages contain strings which were simply
         *  written out directly in some foreign character set instead of
         *  using RFC2047 encoding.  This is illegal but we will attempt to
         *  handle it anyway by converting from a user-specified default
@@ -114,14 +130,14 @@ void utf8ify_rfc822_string(char *buf) {
        nextend = end = NULL;
        len = strlen(buf);
        start = strstr(buf, "=?");
-       if (start != NULL)
-               end = strstr(start, "?=");
+       if (start != NULL) 
+               end = FindNextEnd (start);
 
        while ((start != NULL) && (end != NULL))
        {
                next = strstr(end, "=?");
                if (next != NULL)
-                       nextend = strstr(next, "?=");
+                       nextend = FindNextEnd(next);
                if (nextend == NULL)
                        next = NULL;
 
@@ -158,10 +174,10 @@ void utf8ify_rfc822_string(char *buf) {
                end = nextend;
        }
 
-       /** Now we handle foreign character sets properly encoded
-        *  in RFC2047 format.
+       /* Now we handle foreign character sets properly encoded
+        * in RFC2047 format.
         */
-       while (start=strstr(buf, "=?"), end=strstr(buf, "?="),
+       while (start=strstr(buf, "=?"), end=FindNextEnd((start != NULL)? start : buf),
                ((start != NULL) && (end != NULL) && (end > start)) )
        {
                extract_token(charset, start, 1, '?', sizeof charset);
@@ -230,7 +246,7 @@ void utf8ify_rfc822_string(char *buf) {
 
                free(isav);
 
-               /**
+               /*
                 * Since spammers will go to all sorts of absurd lengths to get their
                 * messages through, there are LOTS of corrupt headers out there.
                 * So, prevent a really badly formed RFC2047 header from throwing
@@ -257,58 +273,82 @@ inline void utf8ify_rfc822_string(char *a){};
  * \param      target          Target buffer.
  * \param      maxlen          Maximum size of target buffer.
  * \param      source          Source string to be encoded.
+ * \param       SourceLen       Length of the source string
+ * \returns     encoded length; -1 if non success.
  */
-void webcit_rfc2047encode(char *target, int maxlen, char *source)
+int webcit_rfc2047encode(char *target, int maxlen, char *source, long SourceLen)
 {
+       const char headerStr[] = "=?UTF-8?Q?";
        int need_to_encode = 0;
-       int i, len;
+       int i = 0;
+       int len;
        unsigned char ch;
 
-       if (target == NULL) return;
-       len = strlen(source);
-       for (i=0; i<len; ++i) {
-               if ((source[i] < 32) || (source[i] > 126)) {
+       if ((source == NULL) || 
+           (target == NULL) ||
+           (SourceLen > maxlen)) return -1;
+
+       while ((!IsEmptyStr (&source[i])) && 
+              (need_to_encode == 0) &&
+              (i < SourceLen) ) {
+               if (((unsigned char) source[i] < 32) || 
+                   ((unsigned char) source[i] > 126)) {
                        need_to_encode = 1;
-                       i = len; ///< shortcut. won't become more than 1
                }
+               i++;
        }
 
        if (!need_to_encode) {
-               safestrncpy(target, source, maxlen);
-               return;
+               memcpy (target, source, SourceLen);
+               target[SourceLen] = '\0';
+               return SourceLen;
        }
-
-       strcpy(target, "=?UTF-8?Q?");
-       for (i=0; i<len; ++i) {
+       
+       if (sizeof (headerStr + SourceLen + 2) > maxlen)
+               return -1;
+       memcpy (target, headerStr, sizeof (headerStr));
+       len = sizeof (headerStr) - 1;
+       for (i=0; (i < SourceLen) && (len + 3< maxlen) ; ++i) {
                ch = (unsigned char) source[i];
                if ((ch < 32) || (ch > 126) || (ch == 61)) {
-                       sprintf(&target[strlen(target)], "=%02X", ch);
+                       sprintf(&target[len], "=%02X", ch);
+                       len += 3;
                }
                else {
-                       sprintf(&target[strlen(target)], "%c", ch);
+                       sprintf(&target[len], "%c", ch);
+                       len ++;
                }
        }
        
-       strcat(target, "?=");
+       if (len + 2 < maxlen) {
+               strcat(&target[len], "?=");
+               len +=2;
+               return len;
+       }
+       else
+               return -1;
 }
 
 
 
 
-/**
- * \brief Look for URL's embedded in a buffer and make them linkable.  We use a
- * target window in order to keep the BBS session in its own window.
- * \param buf the message buffer
+/*
+ * Look for URL's embedded in a buffer and make them linkable.  We use a
+ * target window in order to keep the Citadel session in its own window.
  */
-void url(char *buf)
+void url(char *buf, size_t bufsize)
 {
-       int len;
+       int len, UrlLen, Offset, TrailerLen, outpos;
        char *start, *end, *pos;
        char urlbuf[SIZ];
-       char outbuf[1024];
+       char outbuf[SIZ];
 
        start = NULL;
        len = strlen(buf);
+       if (len > bufsize) {
+               lprintf(1, "URL: content longer than buffer!");
+               return;
+       }
        end = buf + len;
        for (pos = buf; (pos < end) && (start == NULL); ++pos) {
                if (!strncasecmp(pos, "http://", 7))
@@ -339,17 +379,35 @@ void url(char *buf)
                        end = pos;
                }
        }
+       
+       UrlLen = end - start;
+       if (UrlLen > sizeof(urlbuf)){
+               lprintf(1, "URL: content longer than buffer!");
+               return;
+       }
+       memcpy(urlbuf, start, UrlLen);
+       urlbuf[UrlLen] = '\0';
+
+       Offset = start - buf;
+       if ((Offset != 0) && (Offset < sizeof(outbuf)))
+               memcpy(outbuf, buf, Offset);
+       outpos = snprintf(&outbuf[Offset], sizeof(outbuf) - Offset,  
+                         "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
+                         LB, QU, urlbuf, QU, QU, TARGET, QU, RB, urlbuf, LB, RB);
+       if (outpos >= sizeof(outbuf) - Offset) {
+               lprintf(1, "URL: content longer than buffer!");
+               return;
+       }
 
-       strncpy(urlbuf, start, end - start);
-       urlbuf[end - start] = '\0';
-
-       if (start != buf)
-               strncpy(outbuf, buf, start - buf );
-       sprintf(&outbuf[start-buf], "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
-               LB, QU, urlbuf, QU, QU, TARGET, QU, RB, urlbuf, LB, RB);
-       strcat(outbuf, end);
-       if ( strlen(outbuf) < 250 )
-               strcpy(buf, outbuf);
+       TrailerLen = len - (end - start);
+       if (TrailerLen > 0)
+               memcpy(outbuf + Offset + outpos, end, TrailerLen);
+       if (Offset + outpos + TrailerLen > bufsize) {
+               lprintf(1, "URL: content longer than buffer!");
+               return;
+       }
+       memcpy (buf, outbuf, Offset + outpos + TrailerLen);
+       *(buf + Offset + outpos + TrailerLen) = '\0';
 }
 
 
@@ -431,8 +489,9 @@ void fetchname_parsed_vcard(struct vCard *v, char *storename) {
  * understand in a simple two-column name/value format.
  * \param v the vCard to display
  * \param full display all items of the vcard?
+ * \param msgnum Citadel message pointer
  */
-void display_parsed_vcard(struct vCard *v, int full) {
+void display_parsed_vcard(struct vCard *v, int full, long msgnum) {
        int i, j;
        char buf[SIZ];
        char *name;
@@ -601,6 +660,14 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                        wprintf("</TD></TR>\n");
                                }
                        }
+                       else if (!strcasecmp(firsttoken, "photo") && full && pass == 2) { 
+                               // Only output on second pass
+                               wprintf("<tr><td>");
+                               wprintf(_("Photo:"));
+                               wprintf("</td><td>");
+                               wprintf("<img src=\"/vcardphoto/%d/\" alt=\"Contact photo\"/>",msgnum);
+                               wprintf("</td></tr>\n");
+                       }
                        else if (!strcasecmp(firsttoken, "version")) {
                                /* ignore */
                        }
@@ -675,8 +742,10 @@ void display_parsed_vcard(struct vCard *v, int full) {
  * \param alpha what???
  * \param full should we usse all lines?
  * \param storename where to store???
+ * \param msgnum Citadel message pointer
  */
-void display_vcard(char *vcard_source, char alpha, int full, char *storename) {
+void display_vcard(char *vcard_source, char alpha, int full, char *storename, 
+       long msgnum) {
        struct vCard *v;
        char *name;
        char buf[SIZ];
@@ -699,7 +768,7 @@ void display_vcard(char *vcard_source, char alpha, int full, char *storename) {
                        || ((isalpha(alpha)) && (tolower(alpha) == tolower(this_alpha)) )
                        || ((!isalpha(alpha)) && (!isalpha(this_alpha)))
                ) {
-               display_parsed_vcard(v, full);
+               display_parsed_vcard(v, full,msgnum);
        }
 
        vcard_free(v);
@@ -740,6 +809,8 @@ void read_message(long msgnum, int printable_view, char *section) {
        char rfca[256] = "";
        char reply_to[512] = "";
        char reply_all[4096] = "";
+       char reply_references[1024] = "";
+       char reply_inreplyto[256] = "";
        char now[64] = "";
        int format_type = 0;
        int nhdr = 0;
@@ -811,6 +882,12 @@ void read_message(long msgnum, int printable_view, char *section) {
                if (!strncasecmp(buf, "subj=", 5)) {
                        safestrncpy(m_subject, &buf[5], sizeof m_subject);
                }
+               if (!strncasecmp(buf, "msgn=", 5)) {
+                       safestrncpy(reply_inreplyto, &buf[5], sizeof reply_inreplyto);
+               }
+               if (!strncasecmp(buf, "wefw=", 5)) {
+                       safestrncpy(reply_references, &buf[5], sizeof reply_references);
+               }
                if (!strncasecmp(buf, "cccc=", 5)) {
                        int len;
                        safestrncpy(m_cc, &buf[5], sizeof m_cc);
@@ -952,7 +1029,16 @@ void read_message(long msgnum, int printable_view, char *section) {
 
        }
 
-       /** Generate a reply-to address */
+       /* Trim down excessively long lists of thread references.  We eliminate the
+        * second one in the list so that the thread root remains intact.
+        */
+       int rrtok = num_tokens(reply_references, '|');
+       int rrlen = strlen(reply_references);
+       if ( ((rrtok >= 3) && (rrlen > 900)) || (rrtok > 10) ) {
+               remove_token(reply_references, 1, '|');
+       }
+
+       /* Generate a reply-to address */
        if (!IsEmptyStr(rfca)) {
                if (!IsEmptyStr(from)) {
                        snprintf(reply_to, sizeof(reply_to), "%s <%s>", from, rfca);
@@ -985,7 +1071,7 @@ void read_message(long msgnum, int printable_view, char *section) {
         if (!printable_view) {
                 wprintf("<p id=\"msg%ld\" class=\"msgbuttons\" >\n",msgnum);
 
-               /** Reply */
+               /* Reply */
                if ( (WC->wc_view == VIEW_MAILBOX) || (WC->wc_view == VIEW_BBS) ) {
                        wprintf("<a href=\"display_enter");
                        if (WC->is_mailbox) {
@@ -998,10 +1084,16 @@ void read_message(long msgnum, int printable_view, char *section) {
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
                        }
+                       wprintf("?references=");
+                       if (!IsEmptyStr(reply_references)) {
+                               urlescputs(reply_references);
+                               urlescputs("|");
+                       }
+                       urlescputs(reply_inreplyto);
                        wprintf("\"><span>[</span>%s<span>]</span></a> ", _("Reply"));
                }
 
-               /** ReplyQuoted */
+               /* ReplyQuoted */
                if ( (WC->wc_view == VIEW_MAILBOX) || (WC->wc_view == VIEW_BBS) ) {
                        if (!WC->is_mailbox) {
                                wprintf("<a href=\"display_enter");
@@ -1013,11 +1105,17 @@ void read_message(long msgnum, int printable_view, char *section) {
                                        if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                        urlescputs(m_subject);
                                }
+                               wprintf("?references=");
+                               if (!IsEmptyStr(reply_references)) {
+                                       urlescputs(reply_references);
+                                       urlescputs("|");
+                               }
+                               urlescputs(reply_inreplyto);
                                wprintf("\"><span>[</span>%s<span>]</span></a> ", _("ReplyQuoted"));
                        }
                }
 
-               /** ReplyAll */
+               /* ReplyAll */
                if (WC->wc_view == VIEW_MAILBOX) {
                        wprintf("<a href=\"display_enter");
                        wprintf("?replyquote=%ld", msgnum);
@@ -1030,10 +1128,16 @@ void read_message(long msgnum, int printable_view, char *section) {
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
                        }
+                       wprintf("?references=");
+                       if (!IsEmptyStr(reply_references)) {
+                               urlescputs(reply_references);
+                               urlescputs("|");
+                       }
+                       urlescputs(reply_inreplyto);
                        wprintf("\"><span>[</span>%s<span>]</span></a> ", _("ReplyAll"));
                }
 
-               /** Forward */
+               /* Forward */
                if (WC->wc_view == VIEW_MAILBOX) {
                        wprintf("<a href=\"display_enter?fwdquote=%ld?subject=", msgnum);
                        if (strncasecmp(m_subject, "Fwd:", 4)) wprintf("Fwd:%20");
@@ -1041,7 +1145,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        wprintf("\"><span>[</span>%s<span>]</span></a> ", _("Forward"));
                }
 
-               /** If this is one of my own rooms, or if I'm an Aide or Room Aide, I can move/delete */
+               /* If this is one of my own rooms, or if I'm an Aide or Room Aide, I can move/delete */
                if ( (WC->is_room_aide) || (WC->is_mailbox) || (WC->room_flags2 & QR2_COLLABDEL) ) {
                        /** Move */
                        wprintf("<a href=\"confirm_move_msg?msgid=%ld\"><span>[</span>%s<span>]</span></a> ",
@@ -1055,12 +1159,12 @@ void read_message(long msgnum, int printable_view, char *section) {
                        );
                }
 
-               /** Headers */
+               /* Headers */
                wprintf("<a href=\"#\" onClick=\"window.open('msgheaders/%ld', 'headers%ld', 'toolbar=no,location=no,directories=no,copyhistory=no,status=yes,scrollbars=yes,resizable=yes,width=600,height=400'); \" >"
                        "<span>[</span>%s<span>]</span></a>", msgnum, msgnum, _("Headers"));
 
 
-               /** Print */
+               /* Print */
                wprintf("<a href=\"#\" onClick=\"window.open('printmsg/%ld', 'print%ld', 'toolbar=no,location=no,directories=no,copyhistory=no,status=yes,scrollbars=yes,resizable=yes,width=600,height=400'); \" >"
                        "<span>[</span>%s<span>]</span></a>", msgnum, msgnum, _("Print"));
 
@@ -1085,10 +1189,10 @@ void read_message(long msgnum, int printable_view, char *section) {
 
        wprintf("</div>");
 
-       /** Begin body */
+       /* Begin body */
        wprintf("<div class=\"message_content\">");
 
-       /**
+       /*
         * Learn the content type
         */
        strcpy(mime_content_type, "text/plain");
@@ -1128,7 +1232,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
        }
 
-       /** Set up a character set conversion if we need to (and if we can) */
+       /* Set up a character set conversion if we need to (and if we can) */
 #ifdef HAVE_ICONV
        if (strchr(mime_charset, ';')) strcpy(strchr(mime_charset, ';'), "");
        if ( (strcasecmp(mime_charset, "us-ascii"))
@@ -1143,12 +1247,12 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 #endif
 
-       /** Messages in legacy Citadel variformat get handled thusly... */
+       /* Messages in legacy Citadel variformat get handled thusly... */
        if (!strcasecmp(mime_content_type, "text/x-citadel-variformat")) {
                fmout("JUSTIFY");
        }
 
-       /** Boring old 80-column fixed format text gets handled this way... */
+       /* Boring old 80-column fixed format text gets handled this way... */
        else if ( (!strcasecmp(mime_content_type, "text/plain"))
                || (!strcasecmp(mime_content_type, "text")) ) {
                buf [0] = '\0';
@@ -1185,7 +1289,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                                bq = 0;
                        }
                        wprintf("<tt>");
-                       url(buf);
+                       url(buf, sizeof(buf));
                        escputs(buf);
                        wprintf("</tt><br />\n");
                }
@@ -1243,7 +1347,7 @@ ENDBODY:  /* If there are attached submessages, display them now... */
                        }
 
                        /** In all cases, display the full card */
-                       display_vcard(part_source, 0, 1, NULL);
+                       display_vcard(part_source, 0, 1, NULL,msgnum);
                }
        }
 
@@ -1381,7 +1485,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
        char *ptr = NULL;
        int num_attachments = 0;
        struct wc_attachment *att, *aptr;
-       char m_subject[256];
+       char m_subject[1024];
        char from[256];
        char node[256];
        char rfca[256];
@@ -1455,7 +1559,6 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                msgescputs(rfca);
                                wprintf("&gt; ");
                        }
-       
                        if (!strncasecmp(buf, "node=", 5)) {
                                strcpy(node, &buf[5]);
                                if ( ((WC->room_flags & QR_NETWORK)
@@ -1605,7 +1708,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                bq = 0;
                        }
                        wprintf("<tt>");
-                       url(buf);
+                       url(buf, sizeof(buf));
                        msgescputs1(buf);
                        wprintf("</tt><br />");
                }
@@ -1618,7 +1721,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        strcat(buf, "\n");
                        msgescputs(buf);
                }
-       }
+       }//// TODO: charset? utf8?
 
        /** Unknown weirdness ... don't know how to handle this content type */
        else {
@@ -1767,7 +1870,7 @@ void display_addressbook(long msgnum, char alpha) {
                if (vcard_source != NULL) {
 
                        /** Display the summary line */
-                       display_vcard(vcard_source, alpha, 0, NULL);
+                       display_vcard(vcard_source, alpha, 0, NULL,msgnum);
 
                        /** If it's my vCard I can edit it */
                        if (    (!strcasecmp(WC->wc_roomname, USERCONFIGROOM))
@@ -1858,7 +1961,7 @@ void fetch_ab_name(long msgnum, char *namebuf) {
                if (vcard_source != NULL) {
 
                        /* Grab the name off the card */
-                       display_vcard(vcard_source, 0, 0, namebuf);
+                       display_vcard(vcard_source, 0, 0, namebuf,msgnum);
 
                        free(vcard_source);
                }
@@ -2013,8 +2116,9 @@ int load_msg_ptrs(char *servcmd, int with_headers)
        char fullname[128];
        char nodename[128];
        char inetaddr[128];
-       char subject[256];
+       char subject[1024];
        int nummsgs;
+       int sbjlen;
        int maxload = 0;
 
        int num_summ_alloc = 0;
@@ -2069,8 +2173,12 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                        safestrncpy(WC->summ[nummsgs-1].subj, subject,
                                                    sizeof WC->summ[nummsgs-1].subj);
                                }
-                               if (strlen(WC->summ[nummsgs-1].subj) > 75) {
-                                       strcpy(&WC->summ[nummsgs-1].subj[72], "...");
+                               sbjlen = Ctdl_Utf8StrLen(WC->summ[nummsgs-1].subj);
+                               if (sbjlen > 75) {
+                                       char *ptr;
+                                       ptr = Ctdl_Utf8StrCut(WC->summ[nummsgs-1].subj, 72);
+
+                                       strcpy(ptr, "...");
                                }
 
                                if (!IsEmptyStr(nodename)) {
@@ -2220,7 +2328,7 @@ int summcmp_rdate(const void *s1, const void *s2) {
  */
 void readloop(char *oper)
 {
-       char cmd[256];
+       char cmd[256] = "";
        char buf[SIZ];
        char old_msgs[SIZ];
        int a, b;
@@ -2256,9 +2364,9 @@ void readloop(char *oper)
                return;
        }
 
-       startmsg = atol(bstr("startmsg"));
-       maxmsgs = atoi(bstr("maxmsgs"));
-       is_summary = atoi(bstr("is_summary"));
+       startmsg = lbstr("startmsg");
+       maxmsgs = ibstr("maxmsgs");
+       is_summary = ibstr("is_summary");
        if (maxmsgs == 0) maxmsgs = DEFAULT_MAXMSGS;
 
        snprintf(sortpref_name, sizeof sortpref_name, "sort %s", WCC->wc_roomname);
@@ -2294,7 +2402,7 @@ void readloop(char *oper)
                strcpy(cmd, "MSGS OLD");
        }
        else if (!strcmp(oper, "do_search")) {
-               sprintf(cmd, "MSGS SEARCH|%s", bstr("query"));
+               snprintf(cmd, sizeof(cmd), "MSGS SEARCH|%s", bstr("query"));
        }
        else {
                strcpy(cmd, "MSGS ALL");
@@ -2303,7 +2411,7 @@ void readloop(char *oper)
        if ((WCC->wc_view == VIEW_MAILBOX) && (maxmsgs > 1)) {
                is_summary = 1;
                if (!strcmp(oper, "do_search")) {
-                       sprintf(cmd, "MSGS SEARCH|%s", bstr("query"));
+                       snprintf(cmd, sizeof(cmd), "MSGS SEARCH|%s", bstr("query"));
                }
                else {
                        strcpy(cmd, "MSGS ALL");
@@ -2313,7 +2421,7 @@ void readloop(char *oper)
        if ((WCC->wc_view == VIEW_ADDRESSBOOK) && (maxmsgs > 1)) {
                is_addressbook = 1;
                if (!strcmp(oper, "do_search")) {
-                       sprintf(cmd, "MSGS SEARCH|%s", bstr("query"));
+                       snprintf(cmd, sizeof(cmd), "MSGS SEARCH|%s", bstr("query"));
                }
                else {
                        strcpy(cmd, "MSGS ALL");
@@ -2322,7 +2430,7 @@ void readloop(char *oper)
        }
 
        if (is_summary) {                       /**< fetch header summary */
-               snprintf(cmd, sizeof cmd, "MSGS %s|%s||1",
+               snprintf(cmd, sizeof(cmd), "MSGS %s|%s||1",
                        (!strcmp(oper, "do_search") ? "SEARCH" : "ALL"),
                        (!strcmp(oper, "do_search") ? bstr("query") : "")
                );
@@ -2344,7 +2452,7 @@ void readloop(char *oper)
                }
        }
 
-       is_singlecard = atoi(bstr("is_singlecard"));
+       is_singlecard = ibstr("is_singlecard");
 
        if (WCC->wc_default_view == VIEW_CALENDAR) {            /**< calendar */
                is_calendar = 1;
@@ -2835,8 +2943,8 @@ DONE:
 }
 
 
-/**
- * \brief Back end for post_message()
+/*
+ * Back end for post_message()
  * ... this is where the actual message gets transmitted to the server.
  */
 void post_mime_to_server(void) {
@@ -2861,25 +2969,22 @@ void post_mime_to_server(void) {
                ++seq
        );
 
-       /** RFC2045 requires this, and some clients look for it... */
+       /* RFC2045 requires this, and some clients look for it... */
        serv_puts("MIME-Version: 1.0");
        serv_puts("X-Mailer: " PACKAGE_STRING);
 
-       /** If there are attachments, we have to do multipart/mixed */
+       /* If there are attachments, we have to do multipart/mixed */
        if (WC->first_attachment != NULL) {
                is_multipart = 1;
        }
 
        if (is_multipart) {
-               /** Remember, serv_printf() appends an extra newline */
-               serv_printf("Content-type: multipart/mixed; "
-                       "boundary=\"%s\"\n", top_boundary);
+               /* Remember, serv_printf() appends an extra newline */
+               serv_printf("Content-type: multipart/mixed; boundary=\"%s\"\n", top_boundary);
                serv_printf("This is a multipart message in MIME format.\n");
                serv_printf("--%s", top_boundary);
        }
 
-
-
        /* Remember, serv_printf() appends an extra newline */
        serv_printf("Content-type: multipart/alternative; "
                "boundary=\"%s\"\n", alt_boundary);
@@ -2890,7 +2995,7 @@ void post_mime_to_server(void) {
        serv_puts("Content-Transfer-Encoding: quoted-printable");
        serv_puts("");
        txtmail = html_to_ascii(bstr("msgtext"), 0, 80, 0);
-        text_to_server_qp(txtmail);     /** Transmit message in quoted-printable encoding */
+        text_to_server_qp(txtmail);     /* Transmit message in quoted-printable encoding */
         free(txtmail);
 
        serv_printf("--%s", alt_boundary);
@@ -2899,19 +3004,14 @@ void post_mime_to_server(void) {
        serv_puts("Content-Transfer-Encoding: quoted-printable");
        serv_puts("");
        serv_puts("<html><body>\r\n");
-       text_to_server_qp(bstr("msgtext"));     /** Transmit message in quoted-printable encoding */
+       text_to_server_qp(bstr("msgtext"));     /* Transmit message in quoted-printable encoding */
        serv_puts("</body></html>\r\n");
 
-
        serv_printf("--%s--", alt_boundary);
-
-
-
-
        
        if (is_multipart) {
 
-               /** Add in the attachments */
+               /* Add in the attachments */
                for (att = WC->first_attachment; att!=NULL; att=att->next) {
 
                        encoded_length = ((att->length * 150) / 100);
@@ -2921,8 +3021,7 @@ void post_mime_to_server(void) {
 
                        serv_printf("--%s", top_boundary);
                        serv_printf("Content-type: %s", att->content_type);
-                       serv_printf("Content-disposition: attachment; "
-                               "filename=\"%s\"", att->filename);
+                       serv_printf("Content-disposition: attachment; filename=\"%s\"", att->filename);
                        serv_puts("Content-transfer-encoding: base64");
                        serv_puts("");
                        serv_write(encoded, encoded_strlen);
@@ -2937,8 +3036,8 @@ void post_mime_to_server(void) {
 }
 
 
-/**
- * \brief Post message (or don't post message)
+/*
+ * Post message (or don't post message)
  *
  * Note regarding the "dont_post" variable:
  * A random value (actually, it's just a timestamp) is inserted as a hidden
@@ -2950,40 +3049,52 @@ void post_mime_to_server(void) {
  */
 void post_message(void)
 {
+       urlcontent *u;
+       void *U;
        char buf[1024];
-       char encoded_subject[1024];
+       char *encoded_subject = NULL;
        static long dont_post = (-1L);
        struct wc_attachment *att, *aptr;
        int is_anonymous = 0;
-       char *display_name;
+       const char *display_name;
+       long dpLen = 0;
+       struct wcsession *WCC = WC;
+       char *ptr = NULL;
 
-       if (!IsEmptyStr(bstr("force_room"))) {
+       if (havebstr("force_room")) {
                gotoroom(bstr("force_room"));
        }
 
-       display_name = bstr("display_name");
+       if (GetHash(WC->urlstrings, HKEY("display_name"), &U)) {
+               u = (urlcontent*) U;
+               display_name = u->url_data;
+               dpLen = u->url_data_size;
+       }
+       else {
+               display_name="";
+       }
        if (!strcmp(display_name, "__ANONYMOUS__")) {
                display_name = "";
                is_anonymous = 1;
        }
 
-       if (WC->upload_length > 0) {
+       if (WCC->upload_length > 0) {
 
-               lprintf(9, "%s:%d: we are uploading %d bytes\n", __FILE__, __LINE__, WC->upload_length);
+               lprintf(9, "%s:%d: we are uploading %d bytes\n", __FILE__, __LINE__, WCC->upload_length);
                /** There's an attachment.  Save it to this struct... */
                att = malloc(sizeof(struct wc_attachment));
                memset(att, 0, sizeof(struct wc_attachment));
-               att->length = WC->upload_length;
-               strcpy(att->content_type, WC->upload_content_type);
-               strcpy(att->filename, WC->upload_filename);
+               att->length = WCC->upload_length;
+               strcpy(att->content_type, WCC->upload_content_type);
+               strcpy(att->filename, WCC->upload_filename);
                att->next = NULL;
 
                /** And add it to the list. */
-               if (WC->first_attachment == NULL) {
-                       WC->first_attachment = att;
+               if (WCC->first_attachment == NULL) {
+                       WCC->first_attachment = att;
                }
                else {
-                       aptr = WC->first_attachment;
+                       aptr = WCC->first_attachment;
                        while (aptr->next != NULL) aptr = aptr->next;
                        aptr->next = att;
                }
@@ -3004,49 +3115,102 @@ void post_message(void)
                 * Transfer control of this memory from the upload struct
                 * to the attachment struct.
                 */
-               att->data = WC->upload;
-               WC->upload_length = 0;
-               WC->upload = NULL;
+               att->data = WCC->upload;
+               WCC->upload_length = 0;
+               WCC->upload = NULL;
                display_enter();
                return;
        }
 
-       if (!IsEmptyStr(bstr("cancel_button"))) {
-               sprintf(WC->ImportantMessage, 
+       if (havebstr("cancel_button")) {
+               sprintf(WCC->ImportantMessage, 
                        _("Cancelled.  Message was not posted."));
-       } else if (!IsEmptyStr(bstr("attach_button"))) {
+       } else if (havebstr("attach_button")) {
                display_enter();
                return;
-       } else if (atol(bstr("postseq")) == dont_post) {
-               sprintf(WC->ImportantMessage, 
+       } else if (lbstr("postseq") == dont_post) {
+               sprintf(WCC->ImportantMessage, 
                        _("Automatically cancelled because you have already "
                        "saved this message."));
        } else {
-               webcit_rfc2047encode(encoded_subject, sizeof encoded_subject, bstr("subject"));
-               sprintf(buf, "ENT0 1|%s|%d|4|%s|%s||%s|%s|%s|%s",
-                       bstr("recp"),
+               const char CMD[] = "ENT0 1|%s|%d|4|%s|%s||%s|%s|%s|%s|%s";
+               const char *Recp = ""; 
+               const char *Cc = "";
+               const char *Bcc = "";
+               const char *Wikipage = "";
+               const char *my_email_addr = "";
+               char *CmdBuf = NULL;;
+               long len = 0;
+               size_t nLen;
+               char references[SIZ] = "";
+               size_t references_len = 0;
+
+               safestrncpy(references, bstr("references"), sizeof references);
+               lprintf(9, "Converting: %s\n", references);
+               for (ptr=references; *ptr != 0; ++ptr) {
+                       if (*ptr == '|') *ptr = '!';
+                       ++references_len;
+               } 
+               lprintf(9, "Converted: %s\n", references);
+
+               if (havebstr("subject")) {
+                       char *Subj;
+                       size_t SLen;
+                       /*
+                        * make enough room for the encoded string; 
+                        * plus the QP header 
+                        */
+                       Subj = xbstr("subject", &SLen);
+                       len = SLen * 3 + 32;
+                       encoded_subject = malloc (len);
+                       len = webcit_rfc2047encode(encoded_subject, len, Subj, SLen);
+                       if (len < 0) {
+                               free (encoded_subject);
+                               return;
+                       }
+               }
+               len += sizeof (CMD) + dpLen;
+               Recp = xbstr("recp", &nLen);
+               len += nLen;
+               Cc = xbstr("cc", &nLen);
+               len += nLen;
+               Bcc = xbstr("bcc", &nLen);
+               len += nLen;
+               Wikipage = xbstr("wikipage", &nLen);
+               len += nLen;
+               my_email_addr = xbstr("my_email_addr", &nLen);
+               len += nLen;
+               len += references_len;
+
+               CmdBuf = (char*) malloc (len + 11);
+
+               snprintf(CmdBuf, len + 1, CMD,
+                       Recp,
                        is_anonymous,
-                       encoded_subject,
+                       (encoded_subject ? encoded_subject : ""),
                        display_name,
-                       bstr("cc"),
-                       bstr("bcc"),
-                       bstr("wikipage"),
-                       bstr("my_email_addr")
-               );
-               serv_puts(buf);
+                       Cc,
+                       Bcc,
+                       Wikipage,
+                       my_email_addr,
+                       references);
+               lprintf(9, "%s\n", CmdBuf);
+               serv_puts(CmdBuf);
                serv_getln(buf, sizeof buf);
+               free (CmdBuf);
+               if (encoded_subject) free(encoded_subject);
                if (buf[0] == '4') {
                        post_mime_to_server();
-                       if (  (!IsEmptyStr(bstr("recp")))
-                          || (!IsEmptyStr(bstr("cc"  )))
-                          || (!IsEmptyStr(bstr("bcc" )))
+                       if (  (havebstr("recp"))
+                          || (havebstr("cc"  ))
+                          || (havebstr("bcc" ))
                        ) {
-                               sprintf(WC->ImportantMessage, _("Message has been sent.\n"));
+                               sprintf(WCC->ImportantMessage, _("Message has been sent.\n"));
                        }
                        else {
                                sprintf(WC->ImportantMessage, _("Message has been posted.\n"));
                        }
-                       dont_post = atol(bstr("postseq"));
+                       dont_post = lbstr("postseq");
                } else {
                        lprintf(9, "%s:%d: server post error: %s\n", __FILE__, __LINE__, buf);
                        sprintf(WC->ImportantMessage, "%s", &buf[4]);
@@ -3055,19 +3219,19 @@ void post_message(void)
                }
        }
 
-       free_attachments(WC);
+       free_attachments(WCC);
 
        /**
         *  We may have been supplied with instructions regarding the location
         *  to which we must return after posting.  If found, go there.
         */
-       if (!IsEmptyStr(bstr("return_to"))) {
+       if (havebstr("return_to")) {
                http_redirect(bstr("return_to"));
        }
        /**
         *  If we were editing a page in a wiki room, go to that page now.
         */
-       else if (!IsEmptyStr(bstr("wikipage"))) {
+       else if (havebstr("wikipage")) {
                snprintf(buf, sizeof buf, "wiki?page=%s", bstr("wikipage"));
                http_redirect(buf);
        }
@@ -3098,16 +3262,18 @@ void display_enter(void)
        int i;
        int is_anonymous = 0;
        long existing_page = (-1L);
+       size_t dplen;
 
        now = time(NULL);
 
-       if (!IsEmptyStr(bstr("force_room"))) {
+       if (havebstr("force_room")) {
                gotoroom(bstr("force_room"));
        }
 
-       display_name = bstr("display_name");
+       display_name = xbstr("display_name", &dplen);
        if (!strcmp(display_name, "__ANONYMOUS__")) {
                display_name = "";
+               dplen = 0;
                is_anonymous = 1;
        }
 
@@ -3167,20 +3333,41 @@ void display_enter(void)
        wprintf("<div id=\"content\">\n"
                "<div class=\"fix_scrollbar_bug message \">");
 
-       /** Now check our actual recipients if there are any */
+       /* Now check our actual recipients if there are any */
        if (recipient_required) {
-               sprintf(buf, "ENT0 0|%s|%d|0||%s||%s|%s|%s",
-                       bstr("recp"),
-                       is_anonymous,
-                       display_name,
-                       bstr("cc"), bstr("bcc"), bstr("wikipage"));
-               serv_puts(buf);
+               const char *Recp = ""; 
+               const char *Cc = "";
+               const char *Bcc = "";
+               const char *Wikipage = "";
+               char *CmdBuf = NULL;;
+               size_t len = 0;
+               size_t nLen;
+               const char CMD[] = "ENT0 0|%s|%d|0||%s||%s|%s|%s";
+               
+               len = sizeof(CMD) + dplen;
+               Recp = xbstr("recp", &nLen);
+               len += nLen;
+               Cc = xbstr("cc", &nLen);
+               len += nLen;
+               Bcc = xbstr("bcc", &nLen);
+               len += nLen;
+               Wikipage = xbstr("wikipage", &nLen);
+               len += nLen;
+               
+
+               CmdBuf = (char*) malloc (len + 1);
+
+               snprintf(CmdBuf, len, CMD,
+                        Recp, is_anonymous,
+                        display_name,
+                        Cc, Bcc, Wikipage);
+               serv_puts(CmdBuf);
                serv_getln(buf, sizeof buf);
 
                if (!strncmp(buf, "570", 3)) {  /** 570 means we have an invalid recipient listed */
-                       if (!IsEmptyStr(bstr("recp")) && 
-                           !IsEmptyStr(bstr("cc"  )) && 
-                           !IsEmptyStr(bstr("bcc" ))) {
+                       if (havebstr("recp") && 
+                           havebstr("cc"  ) && 
+                           havebstr("bcc" )) {
                                recipient_bad = 1;
                        }
                }
@@ -3192,7 +3379,7 @@ void display_enter(void)
 
        /** If we got this far, we can display the message entry screen. */
 
-       /** begin message entry screen */
+       /* begin message entry screen */
        wprintf("<form "
                "enctype=\"multipart/form-data\" "
                "method=\"POST\" "
@@ -3209,6 +3396,9 @@ void display_enter(void)
        wprintf("<input type=\"hidden\" name=\"force_room\" value=\"");
        escputs(WC->wc_roomname);
        wprintf("\">\n");
+       wprintf("<input type=\"hidden\" name=\"references\" value=\"");
+       escputs(bstr("references"));
+       wprintf("\">\n");
 
        /** submit or cancel buttons */
         wprintf("<p class=\"send_edit_msg\">");
@@ -3297,8 +3487,7 @@ void display_enter(void)
                wprintf(_("To:"));
                wprintf("</label></th>"
                        "<td><input autocomplete=\"off\" type=\"text\" name=\"recp\" id=\"recp_id\" value=\"");
-               ccraw = bstr("recp");
-               len = strlen(ccraw);
+               ccraw = xbstr("recp", &len);
                copy = (char*) malloc(len * 2 + 1);
                memcpy(copy, ccraw, len + 1); 
                utf8ify_rfc822_string(copy);
@@ -3325,8 +3514,7 @@ void display_enter(void)
                wprintf(_("CC:"));
                wprintf("</label></th>"
                        "<td><input autocomplete=\"off\" type=\"text\" name=\"cc\" id=\"cc_id\" value=\"");
-               ccraw = bstr("cc");
-               len = strlen(ccraw);
+               ccraw = xbstr("cc", &len);
                copy = (char*) malloc(len * 2 + 1);
                memcpy(copy, ccraw, len + 1); 
                utf8ify_rfc822_string(copy);
@@ -3340,8 +3528,7 @@ void display_enter(void)
                wprintf(_("BCC:"));
                wprintf("</label></th>"
                        "<td><input autocomplete=\"off\" type=\"text\" name=\"bcc\" id=\"bcc_id\" value=\"");
-               ccraw = bstr("bcc");
-               len = strlen(ccraw);
+               ccraw = xbstr("bcc", &len);
                copy = (char*) malloc(len * 2 + 1);
                memcpy(copy, ccraw, len + 1); 
                utf8ify_rfc822_string(copy);
@@ -3381,18 +3568,18 @@ void display_enter(void)
        msgescputs(bstr("msgtext"));
 
        /* If we're forwarding a message, insert it here... */
-       if (atol(bstr("fwdquote")) > 0L) {
+       if (lbstr("fwdquote") > 0L) {
                wprintf("<br><div align=center><i>");
                wprintf(_("--- forwarded message ---"));
                wprintf("</i></div><br>");
-               pullquote_message(atol(bstr("fwdquote")), 1, 1);
+               pullquote_message(lbstr("fwdquote"), 1, 1);
        }
 
        /** If we're replying quoted, insert the quote here... */
-       else if (atol(bstr("replyquote")) > 0L) {
+       else if (lbstr("replyquote") > 0L) {
                wprintf("<br>"
                        "<blockquote>");
-               pullquote_message(atol(bstr("replyquote")), 0, 1);
+               pullquote_message(lbstr("replyquote"), 0, 1);
                wprintf("</blockquote><br>");
        }
 
@@ -3407,7 +3594,7 @@ void display_enter(void)
        }
 
        /** Insert our signature if appropriate... */
-       if ( (WC->is_mailbox) && (strcmp(bstr("sig_inserted"), "yes")) ) {
+       if ( (WC->is_mailbox) && yesbstr("sig_inserted") ) {
                get_preference("use_sig", buf, sizeof buf);
                if (!strcasecmp(buf, "yes")) {
                        int len;
@@ -3496,7 +3683,7 @@ void delete_msg(void)
        long msgid;
        char buf[SIZ];
 
-       msgid = atol(bstr("msgid"));
+       msgid = lbstr("msgid");
 
        if (WC->wc_is_trash) {  /** Delete from Trash is a real delete */
                serv_printf("DELE %ld", msgid); 
@@ -3520,9 +3707,9 @@ void move_msg(void)
        long msgid;
        char buf[SIZ];
 
-       msgid = atol(bstr("msgid"));
+       msgid = lbstr("msgid");
 
-       if (!IsEmptyStr(bstr("move_button"))) {
+       if (havebstr("move_button")) {
                sprintf(buf, "MOVE %ld|%s", msgid, bstr("target_room"));
                serv_puts(buf);
                serv_getln(buf, sizeof buf);
@@ -3547,7 +3734,7 @@ void confirm_move_msg(void)
        char buf[SIZ];
        char targ[SIZ];
 
-       msgid = atol(bstr("msgid"));
+       msgid = lbstr("msgid");
 
 
        output_headers(1, 1, 2, 0, 0, 0);