]> code.citadel.org Git - citadel.git/blobdiff - webcit/messages.c
Created ctdl_iconv_open() wrapper around iconv_open()
[citadel.git] / webcit / messages.c
index 84689122c86bc7ff9a4d55d3f5c818b5be32e089..ec3e13ff9580a051e0a54e8150a9faa68a3ad9de 100644 (file)
@@ -3,6 +3,7 @@
  */
 /**
  * \defgroup MsgDisp Functions which deal with the fetching and displaying of messages.
+ * \ingroup WebcitDisplayItems
  *
  */
 /*@{*/
@@ -11,9 +12,9 @@
 #include "webserver.h"
 #include "groupdav.h"
 
-#define SUBJ_COL_WIDTH_PCT                 50 /**< ??? */
-#define SENDER_COL_WIDTH_PCT           30 /**< ??? */
-#define DATE_PLUS_BUTTONS_WIDTH_PCT    20 /**< ??? */
+#define SUBJ_COL_WIDTH_PCT             50      /**< Mailbox view column width */
+#define SENDER_COL_WIDTH_PCT           30      /**< Mailbox view column width */
+#define DATE_PLUS_BUTTONS_WIDTH_PCT    20      /**< Mailbox view column width */
 
 /**
  * Address book entry (keep it short and sweet, it's just a quickie lookup
  */
 struct addrbookent {
        char ab_name[64]; /**< name string */
-       long ab_msgnum;   /**< number in the citadel???? */
+       long ab_msgnum;   /**< message number of address book entry */
 };
 
 
 
 #ifdef HAVE_ICONV
+
+/**
+ * \brief      Wrapper around iconv_open()
+ *             Our version adds aliases for non-standard Microsoft charsets
+ *              such as 'MS950', aliasing them to names like 'CP950'
+ *
+ * \param      tocode          Target encoding
+ * \param      fromcode        Source encoding
+ */
+iconv_t ctdl_iconv_open(const char *tocode, const char *fromcode)
+{
+       iconv_t ic = (iconv_t)(-1) ;
+       ic = iconv_open(tocode, fromcode);
+       if (ic == (iconv_t)(-1) ) {
+               char alias_fromcode[64];
+               if ( (strlen(fromcode) == 5) && (!strncasecmp(fromcode, "MS", 2)) ) {
+                       safestrncpy(alias_fromcode, fromcode, sizeof alias_fromcode);
+                       alias_fromcode[0] = 'C';
+                       alias_fromcode[1] = 'P';
+                       ic = iconv_open(tocode, alias_fromcode);
+               }
+       }
+       return(ic);
+}
+
+
 /**
  * \brief  Handle subjects with RFC2047 encoding
  *  such as:
@@ -72,7 +99,7 @@ void utf8ify_rfc822_string(char *buf) {
                        ibuflen = strlen(istr);
                }
 
-               ic = iconv_open("UTF-8", charset);
+               ic = ctdl_iconv_open("UTF-8", charset);
                if (ic != (iconv_t)(-1) ) {
                        obuf = malloc(1024);
                        obuflen = 1024;
@@ -654,13 +681,16 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
                if (!strncasecmp(buf, "rcpt=", 5)) {
                        wprintf(_("to "));
-                       escputs(&buf[5]);
-                       wprintf(" ");
                        if (strlen(reply_all) > 0) {
                                strcat(reply_all, ", ");
                        }
                        safestrncpy(&reply_all[strlen(reply_all)], &buf[5],
                                (sizeof reply_all - strlen(reply_all)) );
+#ifdef HAVE_ICONV
+                       utf8ify_rfc822_string(&buf[5]);
+#endif
+                       escputs(&buf[5]);
+                       wprintf(" ");
                }
                if (!strncasecmp(buf, "time=", 5)) {
                        fmt_date(now, atol(&buf[5]), 0);
@@ -691,15 +721,21 @@ void read_message(long msgnum, int printable_view, char *section) {
                             || (!strcasecmp(mime_disposition, "inline")) ) {
                                snprintf(&mime_http[strlen(mime_http)],
                                        (sizeof(mime_http) - strlen(mime_http) - 1),
-                                       "<a href=\"mimepart/%ld/%s/%s\" "
-                                       "target=\"wc.%ld.%s\">"
                                        "<img src=\"static/diskette_24x.gif\" "
                                        "border=0 align=middle>\n"
-                                       "%s (%s, %d bytes)</a><br />\n",
+                                       "%s (%s, %d bytes) [ "
+                                       "<a href=\"mimepart/%ld/%s/%s\""
+                                       "target=\"wc.%ld.%s\">%s</a>"
+                                       " | "
+                                       "<a href=\"mimepart_download/%ld/%s/%s\">%s</a>"
+                                       " ]<br />\n",
+                                       mime_filename,
+                                       mime_content_type, mime_length,
                                        msgnum, mime_partnum, mime_filename,
                                        msgnum, mime_partnum,
-                                       mime_filename,
-                                       mime_content_type, mime_length
+                                       _("View"),
+                                       msgnum, mime_partnum, mime_filename,
+                                       _("Download")
                                );
                        }
 
@@ -887,7 +923,7 @@ void read_message(long msgnum, int printable_view, char *section) {
           && (strcasecmp(mime_charset, "UTF-8"))
           && (strcasecmp(mime_charset, ""))
        ) {
-               ic = iconv_open("UTF-8", mime_charset);
+               ic = ctdl_iconv_open("UTF-8", mime_charset);
                if (ic == (iconv_t)(-1) ) {
                        lprintf(5, "%s:%d iconv_open(UTF-8, %s) failed: %s\n",
                                __FILE__, __LINE__, mime_charset, strerror(errno));
@@ -1025,7 +1061,8 @@ ENDBODY:
 /**
  * \brief Unadorned HTML output of an individual message, suitable
  * for placing in a hidden iframe, for printing, or whatever
- * \param msgnum_as_string the message to embed???
+ *
+ * \param msgnum_as_string Message number, as a string instead of as a long int
  */
 void embed_message(char *msgnum_as_string) {
        long msgnum = 0L;
@@ -1039,7 +1076,8 @@ void embed_message(char *msgnum_as_string) {
 
 /**
  * \brief Printable view of a message
- * \param msgnum_as_string the message to print??? 
+ *
+ * \param msgnum_as_string Message number, as a string instead of as a long int
  */
 void print_message(char *msgnum_as_string) {
        long msgnum = 0L;
@@ -1068,7 +1106,8 @@ void print_message(char *msgnum_as_string) {
 
 /**
  * \brief Display a message's headers
- * \param msgnum_as_string the message headers to print???
+ *
+ * \param msgnum_as_string Message number, as a string instead of as a long int
  */
 void display_headers(char *msgnum_as_string) {
        long msgnum = 0L;
@@ -1098,15 +1137,16 @@ void display_headers(char *msgnum_as_string) {
 
 /**
  * \brief Read message in simple, JavaScript-embeddable form for 'forward'
- * or 'reply quoted' operations.
+ *        or 'reply quoted' operations.
  *
  * NOTE: it is VITALLY IMPORTANT that we output no single-quotes or linebreaks
  *       in this function.  Doing so would throw a JavaScript error in the
  *       'supplied text' argument to the editor.
- * \param msgnum the citadel message number
- * \param forward_attachments atachment to forward???
+ *
+ * \param msgnum Message number of the message we want to quote
+ * \param forward_attachments Nonzero if we want attachments to be forwarded
  */
-void pullquote_message(long msgnum, int forward_attachments) {
+void pullquote_message(long msgnum, int forward_attachments, int include_headers) {
        char buf[SIZ];
        char mime_partnum[256];
        char mime_filename[256];
@@ -1160,57 +1200,59 @@ void pullquote_message(long msgnum, int forward_attachments) {
                        wprintf(_("unexpected end of message"));
                        return;
                }
-               if (!strncasecmp(buf, "nhdr=yes", 8))
-                       nhdr = 1;
-               if (nhdr == 1)
-                       buf[0] = '_';
-               if (!strncasecmp(buf, "type=", 5))
-                       format_type = atoi(&buf[5]);
-               if (!strncasecmp(buf, "from=", 5)) {
-                       strcpy(from, &buf[5]);
-                       wprintf(_("from "));
+               if (include_headers) {
+                       if (!strncasecmp(buf, "nhdr=yes", 8))
+                               nhdr = 1;
+                       if (nhdr == 1)
+                               buf[0] = '_';
+                       if (!strncasecmp(buf, "type=", 5))
+                               format_type = atoi(&buf[5]);
+                       if (!strncasecmp(buf, "from=", 5)) {
+                               strcpy(from, &buf[5]);
+                               wprintf(_("from "));
 #ifdef HAVE_ICONV
-                       utf8ify_rfc822_string(from);
+                               utf8ify_rfc822_string(from);
 #endif
-                       msgescputs(from);
-               }
-               if (!strncasecmp(buf, "subj=", 5)) {
-                       strcpy(m_subject, &buf[5]);
-               }
-               if ((!strncasecmp(buf, "hnod=", 5))
-                   && (strcasecmp(&buf[5], serv_info.serv_humannode))) {
-                       wprintf("(%s) ", &buf[5]);
-               }
-               if ((!strncasecmp(buf, "room=", 5))
-                   && (strcasecmp(&buf[5], WC->wc_roomname))
-                   && (strlen(&buf[5])>0) ) {
-                       wprintf(_("in "));
-                       wprintf("%s&gt; ", &buf[5]);
-               }
-               if (!strncasecmp(buf, "rfca=", 5)) {
-                       strcpy(rfca, &buf[5]);
-                       wprintf("&lt;");
-                       msgescputs(rfca);
-                       wprintf("&gt; ");
-               }
-
-               if (!strncasecmp(buf, "node=", 5)) {
-                       strcpy(node, &buf[5]);
-                       if ( ((WC->room_flags & QR_NETWORK)
-                       || ((strcasecmp(&buf[5], serv_info.serv_nodename)
-                       && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
-                       && (strlen(rfca)==0)
-                       ) {
-                               wprintf("@%s ", &buf[5]);
+                               msgescputs(from);
+                       }
+                       if (!strncasecmp(buf, "subj=", 5)) {
+                               strcpy(m_subject, &buf[5]);
+                       }
+                       if ((!strncasecmp(buf, "hnod=", 5))
+                           && (strcasecmp(&buf[5], serv_info.serv_humannode))) {
+                               wprintf("(%s) ", &buf[5]);
+                       }
+                       if ((!strncasecmp(buf, "room=", 5))
+                           && (strcasecmp(&buf[5], WC->wc_roomname))
+                           && (strlen(&buf[5])>0) ) {
+                               wprintf(_("in "));
+                               wprintf("%s&gt; ", &buf[5]);
+                       }
+                       if (!strncasecmp(buf, "rfca=", 5)) {
+                               strcpy(rfca, &buf[5]);
+                               wprintf("&lt;");
+                               msgescputs(rfca);
+                               wprintf("&gt; ");
+                       }
+       
+                       if (!strncasecmp(buf, "node=", 5)) {
+                               strcpy(node, &buf[5]);
+                               if ( ((WC->room_flags & QR_NETWORK)
+                               || ((strcasecmp(&buf[5], serv_info.serv_nodename)
+                               && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
+                               && (strlen(rfca)==0)
+                               ) {
+                                       wprintf("@%s ", &buf[5]);
+                               }
+                       }
+                       if (!strncasecmp(buf, "rcpt=", 5)) {
+                               wprintf(_("to "));
+                               wprintf("%s ", &buf[5]);
+                       }
+                       if (!strncasecmp(buf, "time=", 5)) {
+                               fmt_date(now, atol(&buf[5]), 0);
+                               wprintf("%s ", now);
                        }
-               }
-               if (!strncasecmp(buf, "rcpt=", 5)) {
-                       wprintf(_("to "));
-                       wprintf("%s ", &buf[5]);
-               }
-               if (!strncasecmp(buf, "time=", 5)) {
-                       fmt_date(now, atol(&buf[5]), 0);
-                       wprintf("%s ", now);
                }
 
                /**
@@ -1226,23 +1268,25 @@ void pullquote_message(long msgnum, int forward_attachments) {
 
        }
 
-       wprintf("<br>");
+       if (include_headers) {
+               wprintf("<br>");
 
 #ifdef HAVE_ICONV
-       utf8ify_rfc822_string(m_subject);
+               utf8ify_rfc822_string(m_subject);
 #endif
-       if (strlen(m_subject) > 0) {
-               wprintf(_("Subject:"));
-               wprintf(" ");
-               msgescputs(m_subject);
+               if (strlen(m_subject) > 0) {
+                       wprintf(_("Subject:"));
+                       wprintf(" ");
+                       msgescputs(m_subject);
+                       wprintf("<br />");
+               }
+
+               /**
+                * Begin body
+                */
                wprintf("<br />");
        }
 
-       /**
-        * Begin body
-        */
-       wprintf("<br>");
-
        /**
         * Learn the content type
         */
@@ -1275,7 +1319,7 @@ void pullquote_message(long msgnum, int forward_attachments) {
           && (strcasecmp(mime_charset, "UTF-8"))
           && (strcasecmp(mime_charset, ""))
        ) {
-               ic = iconv_open("UTF-8", mime_charset);
+               ic = ctdl_iconv_open("UTF-8", mime_charset);
                if (ic == (iconv_t)(-1) ) {
                        lprintf(5, "%s:%d iconv_open() failed: %s\n",
                                __FILE__, __LINE__, strerror(errno));
@@ -1330,6 +1374,7 @@ void pullquote_message(long msgnum, int forward_attachments) {
        /** HTML just gets escaped and stuffed back into the editor */
        else if (!strcasecmp(mime_content_type, "text/html")) {
                while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
+                       strcat(buf, "\n");
                        msgescputs(buf);
                }
        }
@@ -1400,8 +1445,9 @@ ENDBODY:
 }
 
 /**
- * \brief display sumarized item???
- * \param num hom many? which???
+ * \brief Display one row in the mailbox summary view
+ *
+ * \param num The row number to be displayed
  */
 void display_summarized(int num) {
        char datebuf[64];
@@ -1800,9 +1846,10 @@ int load_msg_ptrs(char *servcmd, int with_headers)
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two longs in descending order.
+ *
+ * \param s1 first number to compare 
+ * \param s2 second number to compare
  */
 int longcmp_r(const void *s1, const void *s2) {
        long l1;
@@ -1818,9 +1865,10 @@ int longcmp_r(const void *s1, const void *s2) {
 
  
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by ascending subject.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_subj(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1832,9 +1880,10 @@ int summcmp_subj(const void *s1, const void *s2) {
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by descending subject.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_rsubj(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1846,9 +1895,10 @@ int summcmp_rsubj(const void *s1, const void *s2) {
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by ascending sender.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_sender(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1860,9 +1910,10 @@ int summcmp_sender(const void *s1, const void *s2) {
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by descending sender.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_rsender(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1874,9 +1925,10 @@ int summcmp_rsender(const void *s1, const void *s2) {
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by ascending date.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_date(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1891,9 +1943,10 @@ int summcmp_date(const void *s1, const void *s2) {
 }
 
 /**
- * \brief compare what????
- * \param s1 first thing to compare 
- * \param s2 second thing to compare
+ * \brief qsort() compatible function to compare two message summary structs by descending date.
+ *
+ * \param s1 first item to compare 
+ * \param s2 second item to compare
  */
 int summcmp_rdate(const void *s1, const void *s2) {
        struct message_summary *summ1;
@@ -1907,9 +1960,12 @@ int summcmp_rdate(const void *s1, const void *s2) {
        else return 0;
 }
 
+
+
 /**
  * \brief command loop for reading messages
- * \param oper what???
+ *
+ * \param oper Set to "readnew" or "readold" or "readfwd" or "headers"
  */
 void readloop(char *oper)
 {
@@ -2022,7 +2078,8 @@ void readloop(char *oper)
 
        is_singlecard = atoi(bstr("is_singlecard"));
 
-       if (WC->wc_view == VIEW_CALENDAR) {             /**< calendar */
+       if ((WC->wc_view == VIEW_CALENDAR) ||
+               (WC->wc_view == VIEW_CALBRIEF)){                /**< calendar */
                is_calendar = 1;
                strcpy(cmd, "MSGS ALL");
                maxmsgs = 32767;
@@ -2182,6 +2239,11 @@ void readloop(char *oper)
                );
        }
 
+       if (is_notes) {
+               wprintf("<div align=center>%s</div>\n", _("Click on any note to edit it."));
+               wprintf("<div id=\"new_notes_here\"></div>\n");
+       }
+
        for (a = 0; a < nummsgs; ++a) {
                if ((WC->msgarr[a] >= startmsg) && (num_displayed < maxmsgs)) {
 
@@ -2403,7 +2465,7 @@ void post_mime_to_server(void) {
        }
 
        if (is_multipart) {
-               sprintf(boundary, "---Citadel-Multipart-%s-%04x%04x---",
+               sprintf(boundary, "=_Citadel_Multipart_%s_%04x%04x",
                        serv_info.serv_fqdn,
                        getpid(),
                        ++seq
@@ -2417,12 +2479,12 @@ void post_mime_to_server(void) {
        }
 
        serv_puts("Content-type: text/html; charset=utf-8");
+       serv_puts("Content-Transfer-Encoding: quoted-printable");
        serv_puts("");
-       serv_puts("<html><body>\n");            /** Future templates go here */
-       text_to_server(bstr("msgtext"), 0);
-       serv_puts("</body></html>\n");
+       serv_puts("<html><body>\r\n");
+       text_to_server_qp(bstr("msgtext"));     /** Transmit message in quoted-printable encoding */
+       serv_puts("</body></html>\r\n");
        
-
        if (is_multipart) {
 
                /** Add in the attachments */
@@ -2557,7 +2619,27 @@ void post_message(void)
        }
 
        free_attachments(WC);
-       readloop("readnew");
+
+       /**
+        *  We may have been supplied with instructions regarding the location
+        *  to which we must return after posting.  If found, go there.
+        */
+       if (strlen(bstr("return_to")) > 0) {
+               http_redirect(bstr("return_to"));
+       }
+       /**
+        *  If we were editing a page in a wiki room, go to that page now.
+        */
+       else if (strlen(bstr("wikipage")) > 0) {
+               snprintf(buf, sizeof buf, "wiki?page=%s", bstr("wikipage"));
+               http_redirect(buf);
+       }
+       /**
+        *  Otherwise, just go to the "read messages" loop.
+        */
+       else {
+               readloop("readnew");
+       }
 }
 
 
@@ -2600,7 +2682,8 @@ void display_enter(void)
         * Are we perhaps in a calendar view?  If so, then an "enter
         * message" command really means "add new calendar item."
         */
-       if (WC->wc_view == VIEW_CALENDAR) {
+       if ((WC->wc_view == VIEW_CALENDAR) ||
+               (WC->wc_view == VIEW_CALBRIEF)){
                display_edit_event();
                return;
        }
@@ -2674,14 +2757,18 @@ void display_enter(void)
        stresc(&buf[strlen(buf)], WC->wc_roomname, 1, 1);
 
        /** begin message entry screen */
-       wprintf("<form enctype=\"multipart/form-data\" "
-               "method=\"POST\" action=\"post\" "
+       wprintf("<form "
+               "enctype=\"multipart/form-data\" "
+               "method=\"POST\" "
+               "accept-charset=\"UTF-8\" "
+               "action=\"post\" "
                "name=\"enterform\""
                ">\n");
        wprintf("<input type=\"hidden\" name=\"postseq\" value=\"%ld\">\n", now);
        if (WC->wc_view == VIEW_WIKI) {
                wprintf("<input type=\"hidden\" name=\"wikipage\" value=\"%s\">\n", bstr("wikipage"));
        }
+       wprintf("<input type=\"hidden\" name=\"return_to\" value=\"%s\">\n", bstr("return_to"));
 
        wprintf("<img src=\"static/newmess3_24x.gif\" align=middle alt=\" \">");
        wprintf("%s\n", buf);   /** header bar */
@@ -2768,14 +2855,14 @@ void display_enter(void)
                wprintf("<br><div align=center><i>");
                wprintf(_("--- forwarded message ---"));
                wprintf("</i></div><br>");
-               pullquote_message(atol(bstr("fwdquote")), 1);
+               pullquote_message(atol(bstr("fwdquote")), 1, 1);
        }
 
        /** If we're replying quoted, insert the quote here... */
        else if (atol(bstr("replyquote")) > 0L) {
                wprintf("<br>"
                        "<blockquote>");
-               pullquote_message(atol(bstr("replyquote")), 0);
+               pullquote_message(atol(bstr("replyquote")), 0, 1);
                wprintf("</blockquote>\n\n");
        }
 
@@ -2785,7 +2872,7 @@ void display_enter(void)
                str_wiki_index(buf);
                existing_page = locate_message_by_uid(buf);
                if (existing_page >= 0L) {
-                       pullquote_message(existing_page, 1);
+                       pullquote_message(existing_page, 1, 0);
                }
        }