Fix drag and drop bugs

[citadel.git] / webcit / static / summaryview.js

diff --git a/webcit/static/summaryview.js b/webcit/static/summaryview.js
index eb9e2ebe1119164791002c6d314f383884d70057..7f5da8b1bb9fee73263bb55182b50c54610ec5a0 100644 (file)
--- a/webcit/static/summaryview.js
+++ b/webcit/static/summaryview.js
@@ -5,6 +5,14 @@
  * Copyright 2009 The Citadel Team
  * Licensed under the GPL V3
  */
+/* QA reminders: because I keep forgetting / get cursed.
+Can you:
+1. Resort messages in both normal and paged view.
+2. Select a range with shift-click 
+3. Select messages with ctrl-click
+4. Normal click will deselect everything done above
+5. Move messages, and they will disappear
+*/
 document.observe("dom:loaded", createMessageView);
 
 var msgs = null;
@@ -20,19 +28,23 @@ var mlh_from = null;
 var currentSorterToggle = null;
 var query = "";
 var currentlyMarkedRows = new Object();
-var markedRowId = null;
+var markedRowIndex = null;
 
 var mouseDownEvent = null;
 var exitedMouseDown = false;
 
+var originalMarkedRow = null;
+var previousFinish = 0;
+var markedFrom = 0;
 var trTemplate = new Array(11);
 trTemplate[0] = "<tr id=\"";
 trTemplate[2] = "\" citadel:dropenabled=\"dropenabled\" class=\"";
-trTemplate[4] = "\" citadel:dndelement=\"summaryViewDragAndDropHandler\" citadel:msgID=\"";
-trTemplate[6] = "\"><td class=\"col1\">";
-trTemplate[8] = "</td><td class=\"col2\">";
-trTemplate[10] = "</td><td class=\"col3\">";
-trTemplate[12] = "</td></tr>";
+trTemplate[4] = "\" citadel:dndelement=\"summaryViewDragAndDropHandler\" citadel:msgid=\"";
+trTemplate[6] = "\" citadel:ctdlrowid=\"";
+trTemplate[8] = "\"><td class=\"col1\">";
+trTemplate[10] = "</td><td class=\"col2\">";
+trTemplate[12] = "</td><td class=\"col3\">";
+trTemplate[14] = "</td></tr>";
 
 var currentPage = 0;
 var sortModes = {
@@ -106,11 +118,18 @@ new Ajax.Request("roommsgs", {
        });
 }
 function evalJSON(data) {
+  var jsonData = null;
   if (typeof(JSON) === 'object' && typeof(JSON.parse) === 'function') {
-    return JSON.parse(data);
-  } else {
-    return eval('('+data+')');
+    try {
+    jsonData = JSON.parse(data);
+    } catch (e) {
+      // ignore
+    }
+  }
+  if (jsonData == null) {
+    jsonData = eval('('+data+')');
   }
+  return jsonData;
 }
 function loadMessages(transport) {
   try {
@@ -152,9 +171,13 @@ function resortAndDisplay(sortMode) {
   var message_view_parent = message_view.parentNode;
   message_view_parent.removeChild(message_view);
   var startSort = new Date();
+  try {
   if (sortMode != null) {
     msgs.sort(sortMode);
   }
+  } catch (e) {
+    WCLog("Sort error: " + e);
+  }
   var endSort = new Date();
   WCLog("Sort rowArray in " + (endSort-startSort));
   var start = new Date();
@@ -176,13 +199,14 @@ function resortAndDisplay(sortMode) {
     }
     trTemplate[3] = className;
     trTemplate[5] = currentRow[0];
-    trTemplate[7] = currentRow[1];
-    trTemplate[9] = currentRow[2];
-    trTemplate[11] = currentRow[4];
+    trTemplate[7] = x;
+    trTemplate[9] = currentRow[1];
+    trTemplate[11] = currentRow[2];
+    trTemplate[13] = currentRow[4];
     var i = x+1;
     compiled[i] = trTemplate.join("");
     } catch (e) {
-      alert("Exception on row " +  x + ":" + e);
+      WCLog("Exception on row " +  x + ":" + e);
     }
   }
   compiled[length+2] = "</tbody>";
@@ -237,8 +261,11 @@ function CtdlMessageListClick(evt) {
   var msgId = parent.getAttribute("citadel:msgid");
   // If the ctrl key modifier wasn't used, unmark all rows and load the message
   if (!event.shiftKey && !event.ctrlKey && !event.altKey) {
+    previousFinish = 0;
+    markedFrom = 0;
     unmarkAllRows();
-    markedRowId = parent.ctdlRowId;
+    markedRowIndex = parent.rowIndex;
+    originalMarkedRow = parent;
     document.getElementById("preview_pane").innerHTML = "";
     new Ajax.Updater('preview_pane', 'msg/'+msgId, {method: 'get'});
     markRow(parent);
@@ -248,24 +275,31 @@ function CtdlMessageListClick(evt) {
          onComplete: CtdlMarkRowAsRead(parent)});
   // If the shift key modifier is used, mark a range...
   } else if (event.button != 2 && event.shiftKey) {
+    unmarkAllRows();
     markRow(parent);
-    var rowId = parent.ctdlRowId;
+    markRow(originalMarkedRow);
+    var rowIndex = parent.rowIndex;
+    if (markedFrom == 0) {
+      markedFrom = rowIndex;
+    }
     var startMarkingFrom = 0;
     var finish = 0;
-    if (rowId > markedRowId) {
-      startMarkingFrom = markedRowId+1;
-      finish = rowId;
-    } else if (rowId < markedRowId) {
-      startMarkingFrom = rowId+1;
-      finish = markedRowId;
-    } 
+    if (rowIndex > markedRowIndex) {
+      startMarkingFrom = markedRowIndex+1;
+      finish = rowIndex;
+    } else if (rowIndex < markedRowIndex) {
+      startMarkingFrom = rowIndex+1;
+      finish = markedRowIndex;
+    }
+    previousFinish = finish;
+    WCLog('startMarkingFrom=' + startMarkingFrom + ', finish=' + finish);
     for(var x = startMarkingFrom; x<finish; x++) {
-      WCLog("Marking row "+x);
-      markRow(rowArray[x]);
+      WCLog("Marking row " + x);
+      markRow(parent.parentNode.rows[x]);
     }
   // If the ctrl key modifier is used, toggle one message
   } else if (event.button != 2 && (event.ctrlKey || event.altKey)) {
-    if (parent.ctdlMarked == true) {
+    if (parent.getAttribute("citadel:marked")) {
       unmarkRow(parent);
     }
     else {
@@ -339,22 +373,22 @@ function unmarkAllRows() {
 function deleteAllMarkedRows() {
   for(msgId in currentlyMarkedRows) {
     var row = currentlyMarkedRows[msgId];
-    var rowArrayId = row.ctdlRowId;
+    var rowArrayId = row.getAttribute("citadel:ctdlrowid");
     row.parentNode.removeChild(row);
     delete currentlyMarkedRows[msgId];
-    delete rowArray[rowArrayId];
+    delete msgs[rowArrayId];
   }
   // Now we have to reconstruct rowarray as the array length has changed */
-  var newRowArray = new Array();
+  var newMsgs = new Array(msgs.length-1);
   var x=0;
   for(var i=0; i<rowArray.length; i++) {
-    var currentRow = rowArray[i];
+    var currentRow = msgs[i];
     if (currentRow != null) {
-      newRowArray[x] = currentRow;
+      newMsgs[x] = currentRow;
       x++;
     }
   }
-  rowArray = newRowArray;
+  msgs = newMsgs;
   resortAndDisplay(null);
 }