summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
2b24cf7)
fixed a transaction-leak/deadlock problem in cdb_delete;
solved the SIGPIPE mystery (GDB stops on SIGPIPE is all it was)
+ Revision 573.107 2001/03/06 03:31:58 nbryant
+ database-related cleanups and paranoia tests;
+ fixed a transaction-leak/deadlock problem in cdb_delete;
+ solved the SIGPIPE mystery (GDB stops on SIGPIPE is all it was)
+
Revision 573.106 2001/03/05 04:59:31 ajc
* IMAP COPY
Revision 573.106 2001/03/05 04:59:31 ajc
* IMAP COPY
Fri Jul 10 1998 Art Cancro <ajc@uncensored.citadel.org>
* Initial CVS import
Fri Jul 10 1998 Art Cancro <ajc@uncensored.citadel.org>
* Initial CVS import
void cdb_free_tsd(void) {
}
void cdb_free_tsd(void) {
}
-void cdb_release_handles(void) {
+void cdb_check_handles(void) {
void cdb_end_transaction(void);
void cdb_allocate_tsd(void);
void cdb_free_tsd(void);
void cdb_end_transaction(void);
void cdb_allocate_tsd(void);
void cdb_free_tsd(void);
-void cdb_release_handles(void);
+void cdb_check_handles(void);
#define MYTID (((struct cdbtsd*)pthread_getspecific(tsdkey))->tid)
/* just a little helper function */
#define MYTID (((struct cdbtsd*)pthread_getspecific(tsdkey))->tid)
/* just a little helper function */
-static int txabort(DB_TXN *tid) {
+static void txabort(DB_TXN *tid) {
int ret = txn_abort(tid);
if (ret) {
lprintf(1, "cdb_*: txn_abort: %s\n", db_strerror(ret));
abort();
}
int ret = txn_abort(tid);
if (ret) {
lprintf(1, "cdb_*: txn_abort: %s\n", db_strerror(ret));
abort();
}
}
/* this one is even more helpful than the last. */
}
/* this one is even more helpful than the last. */
-static int txcommit(DB_TXN *tid) {
+static void txcommit(DB_TXN *tid) {
int ret = txn_commit(tid, 0);
if (ret) {
lprintf(1, "cdb_*: txn_commit: %s\n", db_strerror(ret));
abort();
}
int ret = txn_commit(tid, 0);
if (ret) {
lprintf(1, "cdb_*: txn_commit: %s\n", db_strerror(ret));
abort();
}
}
/* are you sensing a pattern yet? */
}
/* are you sensing a pattern yet? */
-static int txbegin(DB_TXN **tid) {
+static void txbegin(DB_TXN **tid) {
int ret = txn_begin(dbenv, NULL, tid, 0);
if (ret) {
lprintf(1, "cdb_*: txn_begin: %s\n", db_strerror(ret));
abort();
}
int ret = txn_begin(dbenv, NULL, tid, 0);
if (ret) {
lprintf(1, "cdb_*: txn_begin: %s\n", db_strerror(ret));
abort();
}
+static void cclose(DBC *cursor) {
+ int ret;
+
+ if ((ret = cursor->c_close(cursor))) {
+ lprintf(1, "cdb_*: c_close: %s\n", db_strerror(ret));
+ abort();
+ }
-static void release_handles(void *arg) {
+static void check_handles(void *arg) {
if (arg != NULL) {
struct cdbtsd *tsd = (struct cdbtsd *)arg;
if (tsd->cursor != NULL) {
if (arg != NULL) {
struct cdbtsd *tsd = (struct cdbtsd *)arg;
if (tsd->cursor != NULL) {
- lprintf(1, "cdb_*: WARNING: cursor still in progress; "
- "closing!\n");
- tsd->cursor->c_close(tsd->cursor);
+ lprintf(1, "cdb_*: cursor still in progress!");
+ abort();
}
if (tsd->tid != NULL) {
}
if (tsd->tid != NULL) {
- lprintf(1, "cdb_*: ERROR: transaction still in progress; "
- "aborting!\n");
- txabort(tsd->tid);
+ lprintf(1, "cdb_*: transaction still in progress!");
+ abort();
}
}
}
static void dest_tsd(void *arg) {
if (arg != NULL) {
}
}
}
static void dest_tsd(void *arg) {
if (arg != NULL) {
* to use database calls, except for whatever thread calls open_databases.
*/
void cdb_allocate_tsd(void) {
* to use database calls, except for whatever thread calls open_databases.
*/
void cdb_allocate_tsd(void) {
- struct cdbtsd *tsd = mallok(sizeof *tsd);
+ struct cdbtsd *tsd;
+
+ if (pthread_getspecific(tsdkey) != NULL)
+ return;
+
+ tsd = mallok(sizeof *tsd);
tsd->tid = NULL;
tsd->cursor = NULL;
tsd->tid = NULL;
tsd->cursor = NULL;
pthread_setspecific(tsdkey, NULL);
}
pthread_setspecific(tsdkey, NULL);
}
-void cdb_release_handles(void) {
- release_handles(pthread_getspecific(tsdkey));
+void cdb_check_handles(void) {
+ check_handles(pthread_getspecific(tsdkey));
return ret;
} else {
retry:
return ret;
} else {
retry:
- if (txbegin(&tid))
- return -1;
if ((ret = dbp[cdb]->put(dbp[cdb], /* db */
tid, /* transaction ID */
if ((ret = dbp[cdb]->put(dbp[cdb], /* db */
tid, /* transaction ID */
&ddata, /* data */
0))) { /* flags */
if (ret == DB_LOCK_DEADLOCK) {
&ddata, /* data */
0))) { /* flags */
if (ret == DB_LOCK_DEADLOCK) {
- if (txabort(tid))
- return ret;
- else
- goto retry;
+ txabort(tid);
+ goto retry;
} else {
lprintf(1, "cdb_store(%d): %s\n", cdb,
db_strerror(ret));
abort();
}
} else {
} else {
lprintf(1, "cdb_store(%d): %s\n", cdb,
db_strerror(ret));
abort();
}
} else {
+ txcommit(tid);
+ return ret;
if (MYTID != NULL) {
ret = dbp[cdb]->del(dbp[cdb], MYTID, &dkey, 0);
if (MYTID != NULL) {
ret = dbp[cdb]->del(dbp[cdb], MYTID, &dkey, 0);
+ if (ret) {
+ lprintf(1, "cdb_delete(%d): %s\n", cdb,
+ db_strerror(ret));
+ if (ret != DB_NOTFOUND)
+ abort();
+ }
- if (txbegin(&tid))
- return -1;
- if ((ret = dbp[cdb]->del(dbp[cdb], tid, &dkey, 0))) {
+ if ((ret = dbp[cdb]->del(dbp[cdb], tid, &dkey, 0))
+ && ret != DB_NOTFOUND) {
if (ret == DB_LOCK_DEADLOCK) {
if (ret == DB_LOCK_DEADLOCK) {
- if (txabort(tid))
- return ret;
- else
- goto retry;
+ txabort(tid);
+ goto retry;
} else {
lprintf(1, "cdb_delete(%d): %s\n", cdb,
db_strerror(ret));
} else {
lprintf(1, "cdb_delete(%d): %s\n", cdb,
db_strerror(ret));
- if (ret != DB_NOTFOUND) {
- abort();
- }
ret = dbp[cdb]->get(dbp[cdb], MYTID, &dkey, &dret, 0);
} else {
retry:
ret = dbp[cdb]->get(dbp[cdb], MYTID, &dkey, &dret, 0);
} else {
retry:
- if (txbegin(&tid))
- return NULL;
ret = dbp[cdb]->get(dbp[cdb], tid, &dkey, &dret, 0);
if (ret == DB_LOCK_DEADLOCK) {
ret = dbp[cdb]->get(dbp[cdb], tid, &dkey, &dret, 0);
if (ret == DB_LOCK_DEADLOCK) {
- if (txabort(tid))
- return NULL;
- else
- goto retry;
- } else if (txcommit(tid))
- return NULL;
+ txabort(tid);
+ goto retry;
+ }
+ if (ret && ret != DB_NOTFOUND)
+ abort();
+
+ txcommit(tid);
}
if ((ret != 0) && (ret != DB_NOTFOUND)) {
}
if ((ret != 0) && (ret != DB_NOTFOUND)) {
int ret = 0;
if (MYCURSOR != NULL)
int ret = 0;
if (MYCURSOR != NULL)
- MYCURSOR->c_close(MYCURSOR);
if (MYTID == NULL) {
lprintf(1, "cdb_rewind: ERROR: cursor use outside transaction\n");
if (MYTID == NULL) {
lprintf(1, "cdb_rewind: ERROR: cursor use outside transaction\n");
&key, &data, DB_NEXT);
if (ret) {
&key, &data, DB_NEXT);
if (ret) {
- MYCURSOR->c_close(MYCURSOR);
+ if (ret != DB_NOTFOUND) {
+ lprintf(1, "cdb_next_item(%d): %s\n",
+ cdb, db_strerror(ret));
+ abort();
+ }
+ cclose(MYCURSOR);
MYCURSOR = NULL;
return NULL; /* presumably, end of file */
}
MYCURSOR = NULL;
return NULL; /* presumably, end of file */
}
void cdb_end_transaction(void) {
if (MYCURSOR != NULL) {
lprintf(1, "cdb_end_transaction: WARNING: cursor still open at transaction end\n");
void cdb_end_transaction(void) {
if (MYCURSOR != NULL) {
lprintf(1, "cdb_end_transaction: WARNING: cursor still open at transaction end\n");
- MYCURSOR->c_close(MYCURSOR);
MYCURSOR = NULL;
}
if (MYTID == NULL) {
MYCURSOR = NULL;
}
if (MYTID == NULL) {
void begin_critical_section(int which_one)
{
/* lprintf(9, "begin_critical_section(%d)\n", which_one); */
void begin_critical_section(int which_one)
{
/* lprintf(9, "begin_critical_section(%d)\n", which_one); */
+ /* ensure nobody ever tries to do a critical section within a
+ transaction; this could lead to deadlock. */
+ cdb_check_handles();
pthread_mutex_lock(&Critters[which_one]);
}
pthread_mutex_lock(&Critters[which_one]);
}
}
while (bytes_written < nbytes) {
}
while (bytes_written < nbytes) {
- signal(SIGPIPE, SIG_IGN);
retval = write(sock, &buf[bytes_written],
nbytes - bytes_written);
if (retval < 1) {
retval = write(sock, &buf[bytes_written],
nbytes - bytes_written);
if (retval < 1) {
/* make doubly sure we're not holding any stale db handles
* which might cause a deadlock.
*/
/* make doubly sure we're not holding any stale db handles
* which might cause a deadlock.
*/
begin_critical_section(S_I_WANNA_SELECT);
SETUP_FD: memcpy(&readfds, &masterfds, sizeof masterfds);
begin_critical_section(S_I_WANNA_SELECT);
SETUP_FD: memcpy(&readfds, &masterfds, sizeof masterfds);
dead_session_purge();
if ((time(NULL) - last_timer) > 60L) {
last_timer = time(NULL);
dead_session_purge();
if ((time(NULL) - last_timer) > 60L) {
last_timer = time(NULL);
- cdb_release_handles(); /* suggested by Justin Case */
+ cdb_check_handles(); /* suggested by Justin Case */
PerformSessionHooks(EVT_TIMER);
}
PerformSessionHooks(EVT_TIMER);
}