Remove all uses of __FUNCTION__ because it is not portable

diff --git a/citadel/clientsocket.c b/citadel/clientsocket.c
index f8a25f3e4fcb99b686e53cd00552c2c615f1dcbe..95e8e7c6c6c89244a3959a9ffaeb04a77cd8e973 100644 (file)
--- a/citadel/clientsocket.c
+++ b/citadel/clientsocket.c
@@ -6,9 +6,9 @@
  *
  * Copyright (c) 1987-2011 by the citadel.org team
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
+ * This program is open source software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as published
+ * by the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -18,7 +18,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #include "sysdep.h"
@@ -86,7 +86,7 @@ int sock_connect(char *host, char *service)
 
        rc = getaddrinfo(host, service, &hints, &res);
        if (rc != 0) {
-               syslog(LOG_ERR, "%s: %s\n", host, gai_strerror(rc));
+               syslog(LOG_ERR, "%s: %s", host, gai_strerror(rc));
                return(-1);
        }
 
@@ -96,7 +96,7 @@ int sock_connect(char *host, char *service)
        for (ai = res; ai != NULL; ai = ai->ai_next) {
                sock = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
                if (sock < 0) {
-                       syslog(LOG_ERR, "socket() failed: %s\n", strerror(errno));
+                       syslog(LOG_ERR, "socket() failed: %s", strerror(errno));
                        freeaddrinfo(res);
                        return(-1);
                }
@@ -106,7 +106,7 @@ int sock_connect(char *host, char *service)
                        return(sock);
                }
                else {
-                       syslog(LOG_ERR, "connect() failed: %s\n", strerror(errno));
+                       syslog(LOG_ERR, "connect() failed: %s", strerror(errno));
                        close(sock);
                }
        }
@@ -139,10 +139,10 @@ int socket_read_blob(int *Socket, StrBuf * Target, int bytes, int timeout)
        retval = StrBufReadBLOBBuffered(Target,
                                        CCC->sReadBuf,
                                        &CCC->sPos,
-                                       Socket, 1, bytes, O_TERM, &Error);
+                                       Socket, 1, bytes, O_TERM, &Error
+       );
        if (retval < 0) {
-               syslog(LOG_CRIT,
-                             "%s failed: %s\n", __FUNCTION__, Error);
+               syslog(LOG_CRIT, "socket_read_blob() failed: %s", Error);
        }
        return retval;
 }
@@ -160,8 +160,7 @@ int CtdlSockGetLine(int *sock, StrBuf * Target, int nSec)
                                               &CCC->sPos,
                                               sock, nSec, 1, &Error);
        if ((rc < 0) && (Error != NULL))
-               syslog(LOG_CRIT,
-                             "%s failed: %s\n", __FUNCTION__, Error);
+               syslog(LOG_CRIT, "CtdlSockGetLine() failed: %s", Error);
        return rc;
 }
 

diff --git a/citadel/ecrash.c b/citadel/ecrash.c
index 6c2bb848940d1b4ddaab67b557ccf478631b804a..b03e2fe10545fdc709651eb400c1483062f008bd 100644 (file)
--- a/citadel/ecrash.c
+++ b/citadel/ecrash.c
@@ -45,7 +45,7 @@
 #include "citserver.h"
 #include "ecrash.h"
 
-#define NIY()  printf("%s: Not Implemented Yet!\n", __FUNCTION__)
+#define NIY()  printf("function not implemented yet!\n");
 #ifdef HAVE_BACKTRACE
 #include <execinfo.h>
 static eCrashParameters gbl_params;

diff --git a/citadel/sysdep.c b/citadel/sysdep.c
index c264640168d132f0e469fa156e00d024d44b22d6..3917ff818fe2241368f8b0edeed15132e92656ac 100644 (file)
--- a/citadel/sysdep.c
+++ b/citadel/sysdep.c
@@ -581,7 +581,7 @@ int client_read_blob(StrBuf *Target, int bytes, int timeout)
 #endif
                retval = client_read_sslblob(Target, bytes, timeout);
                if (retval < 0) {
-                       syslog(LOG_CRIT, "%s failed", __FUNCTION__);
+                       syslog(LOG_CRIT, "client_read_blob() failed");
                }
 #ifdef BIGBAD_IODBG
                snprintf(fn, SIZ, "/tmp/foolog_%s.%d", CCC->ServiceName, CCC->cs_pid);
@@ -624,7 +624,7 @@ int client_read_blob(StrBuf *Target, int bytes, int timeout)
                                                O_TERM,
                                                &Error);
                if (retval < 0) {
-                       syslog(LOG_CRIT, "%s failed: %s\n", __FUNCTION__, Error);
+                       syslog(LOG_CRIT, "client_read_blob() failed: %s", Error);
                        client_close();
                        return retval;
                }
@@ -803,10 +803,9 @@ int CtdlClientGetLine(StrBuf *Target)
                         StrLength(Target), ChrPtr(Target));
                 fclose(fd);
 
-               if (rc < 0)
-                       syslog(LOG_CRIT, 
-                                     "%s failed\n",
-                                     __FUNCTION__);
+               if (rc < 0) {
+                       syslog(LOG_CRIT, "CtdlClientGetLine() failed");
+               }
 #endif
                return rc;
        }
@@ -861,11 +860,9 @@ int CtdlClientGetLine(StrBuf *Target)
                         StrLength(Target), ChrPtr(Target));
                 fclose(fd);
 
-               if ((rc < 0) && (Error != NULL))
-                       syslog(LOG_CRIT, 
-                                     "%s failed: %s\n",
-                                     __FUNCTION__,
-                                     Error);
+               if ((rc < 0) && (Error != NULL)) {
+                       syslog(LOG_CRIT, "CtdlClientGetLine() failed: %s", Error);
+               }
 #endif
                return rc;
        }
@@ -1321,7 +1318,6 @@ void *select_on_master(void *blah)
        int m;
        int i;
        int retval;
-       struct CitContext select_on_master_CC;
 
        while (!server_shutting_down) {
                /* Initialize the fdset. */