]> code.citadel.org Git - citadel.git/blobdiff - citadel/messages.c
* Holy war on strlen: use IsEmptyStr where apropriate.
[citadel.git] / citadel / messages.c
index 1bcf7add8f21b7bb5ea55cd4c28a2bd874ebed69..79e03b1b4d32e931a62b89e52e988ee24fe0f787 100644 (file)
@@ -61,7 +61,7 @@ struct cittext {
 
 void stty_ctdl(int cmd);
 int haschar(const char *st, int ch);
-void getline(char *string, int lim);
+void ctdl_getline(char *string, int lim);
 int file_checksum(char *filename);
 void progress(CtdlIPC* ipc, unsigned long curr, unsigned long cmax);
 
@@ -69,9 +69,9 @@ unsigned long *msg_arr = NULL;
 int msg_arr_size = 0;
 int num_msgs;
 char rc_alt_semantics;
-char rc_reply_extedit;
 extern char room_name[];
 extern unsigned room_flags;
+extern unsigned room_flags2;
 extern long highest_msg_read;
 extern char temp[];
 extern char temp2[];
@@ -261,12 +261,10 @@ void citedit(CtdlIPC *ipc, FILE * fp)
                if (a == 127)
                        a = 8;
 
-       /******* new ***********/
-               if ((a > 32) && (a < 127) && (prev == 13)) {
+               if ((a != 32) && (prev == 13)) {
                        add_word(textlist, "\n");
                        scr_printf(" ");
                }
-       /***********************/
 
                if ((a == 32) && (prev == 13)) {
                        add_word(textlist, "\n");
@@ -274,7 +272,7 @@ void citedit(CtdlIPC *ipc, FILE * fp)
                }
 
                if (a == 8) {
-                       if (strlen(wordbuf) > 0) {
+                       if (!IsEmptyStr(wordbuf)) {
                                wordbuf[strlen(wordbuf) - 1] = 0;
                                scr_putc(8);
                                scr_putc(32);
@@ -286,10 +284,10 @@ void citedit(CtdlIPC *ipc, FILE * fp)
                                scr_putc(8);
                                scr_putc(32);
                                scr_putc(8);
-                       } while (strlen(wordbuf) && wordbuf[strlen(wordbuf) - 1] != ' ');
+                       } while (!IsEmptyStr(wordbuf) && wordbuf[strlen(wordbuf) - 1] != ' ');
                } else if (a == 13) {
                        scr_printf("\n");
-                       if (strlen(wordbuf) == 0)
+                       if (IsEmptyStr(wordbuf))
                                finished = 1;
                        else {
                                for (b = 0; b < strlen(wordbuf); ++b)
@@ -438,17 +436,17 @@ int read_message(CtdlIPC *ipc,
                                message->nhdr ? "yes" : "no",
                                message->author, message->type,
                                message->msgid);
-               if (strlen(message->subject)) {
+               if (!IsEmptyStr(message->subject)) {
                        pprintf("subj=%s\n", message->subject);
                }
-               if (strlen(message->email)) {
+               if (!IsEmptyStr(message->email)) {
                        pprintf("rfca=%s\n", message->email);
                }
                pprintf("hnod=%s\nroom=%s\nnode=%s\ntime=%s",
                                message->hnod, message->room,
                                message->node, 
                                asctime(localtime(&message->time)));
-               if (strlen(message->recipient)) {
+               if (!IsEmptyStr(message->recipient)) {
                        pprintf("rcpt=%s\n", message->recipient);
                }
                if (message->attachments) {
@@ -488,7 +486,7 @@ int read_message(CtdlIPC *ipc,
                fmt_date(now, sizeof now, message->time, 0);
                if (dest) {
                        fprintf(dest, "%s from %s ", now, message->author);
-                       if (strlen(message->email)) {
+                       if (!IsEmptyStr(message->email)) {
                                fprintf(dest, "<%s> ", message->email);
                        }
                } else {
@@ -498,7 +496,7 @@ int read_message(CtdlIPC *ipc,
                        scr_printf("from ");
                        color(BRIGHT_CYAN);
                        scr_printf("%s ", message->author);
-                       if (strlen(message->email)) {
+                       if (!IsEmptyStr(message->email)) {
                                color(DIM_WHITE);
                                scr_printf("<");
                                color(BRIGHT_BLUE);
@@ -507,11 +505,11 @@ int read_message(CtdlIPC *ipc,
                                scr_printf("> ");
                        }
                }
-               if (strlen(message->node)) {
+               if (!IsEmptyStr(message->node)) {
                        if ((room_flags & QR_NETWORK)
                            || ((strcasecmp(message->node, ipc->ServInfo.nodename)
                             && (strcasecmp(message->node, ipc->ServInfo.fqdn))))) {
-                               if (strlen(message->email) == 0) {
+                               if (IsEmptyStr(message->email)) {
                                        if (dest) {
                                                fprintf(dest, "@%s ", message->node);
                                        } else {
@@ -524,7 +522,7 @@ int read_message(CtdlIPC *ipc,
                        }
                }
                if (strcasecmp(message->hnod, ipc->ServInfo.humannode)
-                   && (strlen(message->hnod)) && (!strlen(message->email))) {
+                   && (!IsEmptyStr(message->hnod)) && (IsEmptyStr(message->email))) {
                        if (dest) {
                                fprintf(dest, "(%s) ", message->hnod);
                        } else {
@@ -536,7 +534,7 @@ int read_message(CtdlIPC *ipc,
                                scr_printf(") ");
                        }
                }
-               if (strcasecmp(message->room, room_name) && (strlen(message->email) == 0)) {
+               if (strcasecmp(message->room, room_name) && (IsEmptyStr(message->email))) {
                        if (dest) {
                                fprintf(dest, "in %s> ", message->room);
                        } else {
@@ -546,7 +544,7 @@ int read_message(CtdlIPC *ipc,
                                scr_printf("%s> ", message->room);
                        }
                }
-               if (strlen(message->recipient)) {
+               if (!IsEmptyStr(message->recipient)) {
                        if (dest) {
                                fprintf(dest, "to %s ", message->recipient);
                        } else {
@@ -566,8 +564,13 @@ int read_message(CtdlIPC *ipc,
 
        /* Set the reply-to address to an Internet e-mail address if possible
         */
-       if (message->email != NULL) if (strlen(message->email) > 0) {
-               safestrncpy(reply_to, message->email, sizeof reply_to);
+       if (message->email != NULL) if (!IsEmptyStr(message->email)) {
+               if (!IsEmptyStr(message->author)) {
+                       snprintf(reply_to, sizeof reply_to, "%s <%s>", message->author, message->email);
+               }
+               else {
+                       safestrncpy(reply_to, message->email, sizeof reply_to);
+               }
        }
 
        /* But if we can't do that, set it to a Citadel address.
@@ -585,7 +588,7 @@ int read_message(CtdlIPC *ipc,
        if (message->subject != NULL) {
                safestrncpy(reply_subject, message->subject,
                                                sizeof reply_subject);
-               if (strlen(message->subject) > 0) {
+               if (!IsEmptyStr(message->subject)) {
                        if (dest) {
                                fprintf(dest, "Subject: %s\n",
                                                        message->subject);
@@ -703,19 +706,26 @@ int read_message(CtdlIPC *ipc,
 
                for (ptr = message->attachments; ptr; ptr = ptr->next) {
                        if ( (!strcasecmp(ptr->disposition, "attachment"))
-                          || (!strcasecmp(ptr->disposition, "inline"))) {
-                               color(DIM_WHITE);
-                               pprintf("Part ");
-                               color(BRIGHT_MAGENTA);
-                               pprintf("%s", ptr->number);
-                               color(DIM_WHITE);
-                               pprintf(": ");
-                               color(BRIGHT_CYAN);
-                               pprintf("%s", ptr->filename);
-                               color(DIM_WHITE);
-                               pprintf(" (%s, %ld bytes)\n", ptr->mimetype, ptr->length);
-                               if (!strncmp(ptr->mimetype, "image/", 6))
-                                       has_images++;
+                          || (!strcasecmp(ptr->disposition, "inline"))
+                          || (!strcasecmp(ptr->disposition, ""))
+                       ) {
+                               if ( (strcasecmp(ptr->number, message->mime_chosen))
+                                  && (!IsEmptyStr(ptr->mimetype))
+                               ) {
+                                       color(DIM_WHITE);
+                                       pprintf("Part ");
+                                       color(BRIGHT_MAGENTA);
+                                       pprintf("%s", ptr->number);
+                                       color(DIM_WHITE);
+                                       pprintf(": ");
+                                       color(BRIGHT_CYAN);
+                                       pprintf("%s", ptr->filename);
+                                       color(DIM_WHITE);
+                                       pprintf(" (%s, %ld bytes)\n", ptr->mimetype, ptr->length);
+                                       if (!strncmp(ptr->mimetype, "image/", 6)) {
+                                               has_images++;
+                                       }
+                               }
                        }
                }
        }
@@ -749,12 +759,12 @@ void replace_string(char *filename, long int startpos)
        long msglen = 0L;
 
        scr_printf("Enter text to be replaced:\n: ");
-       getline(srch_str, (sizeof(srch_str)-1) );
-       if (strlen(srch_str) == 0)
+       ctdl_getline(srch_str, (sizeof(srch_str)-1) );
+       if (IsEmptyStr(srch_str))
                return;
 
        scr_printf("Enter text to replace it with:\n: ");
-       getline(rplc_str, (sizeof(rplc_str)-1) );
+       ctdl_getline(rplc_str, (sizeof(rplc_str)-1) );
 
        fp = fopen(filename, "r+");
        if (fp == NULL)
@@ -784,7 +794,7 @@ void replace_string(char *filename, long int startpos)
                }
        }
        fseek(fp, wpos, 0);
-       if (strlen(buf) > 0)
+       if (!IsEmptyStr(buf))
                fwrite((char *) buf, strlen(buf), 1, fp);
        wpos = ftell(fp);
        fclose(fp);
@@ -796,12 +806,13 @@ void replace_string(char *filename, long int startpos)
  * Function to begin composing a new message
  */
 int client_make_message(CtdlIPC *ipc,
-               char *filename,         /* temporary file name */
-               char *recipient,        /* NULL if it's not mail */
-               int is_anonymous,
-               int format_type,
-               int mode,
-               char *subject)          /* buffer to store subject line */
+                                               char *filename,         /* temporary file name */
+                                               char *recipient,        /* NULL if it's not mail */
+                                               int is_anonymous,
+                                               int format_type,
+                                               int mode,
+                                               char *subject,          /* buffer to store subject line */
+                                               int subject_required)
 {
        FILE *fp;
        int a, b, e_ex_code;
@@ -813,9 +824,9 @@ int client_make_message(CtdlIPC *ipc,
 
        if (mode >= 2)
        {
-               if((mode-2) < MAX_EDITORS && strlen(editor_paths[mode-2]) > 0) {
+               if((mode-2) < MAX_EDITORS && !IsEmptyStr(editor_paths[mode-2])) {
                        editor_path = editor_paths[mode-2];
-               } else if (strlen(editor_paths[0]) > 0) {
+               } else if (!IsEmptyStr(editor_paths[0])) {
                        editor_path = editor_paths[0];
                } else {
                        err_printf("*** No editor available, "
@@ -836,16 +847,20 @@ int client_make_message(CtdlIPC *ipc,
                        datestr,
                        (is_anonymous ? "[anonymous]" : fullname)
                        );
-               if (strlen(recipient) > 0) {
+               if (!IsEmptyStr(recipient)) {
                        size_t tmp = strlen(header);
                        snprintf(&header[tmp], sizeof header - tmp,
                                " to %s", recipient);
                }
        }
        scr_printf("%s\n", header);
-       if (subject != NULL) if (strlen(subject) > 0) {
+       if (subject != NULL) if (!IsEmptyStr(subject)) {
                scr_printf("Subject: %s\n", subject);
        }
+       
+       if ( (subject_required) && (IsEmptyStr(subject)) ) {
+               newprompt("Subject: ", subject, 70);
+       }
 
        beg = 0L;
 
@@ -958,11 +973,11 @@ MECR:     if (mode >= 2) {
        if (b == 's') goto MEFIN;
        if (b == 'p') {
                scr_printf(" %s from %s", datestr, fullname);
-               if (strlen(recipient) > 0) {
+               if (!IsEmptyStr(recipient)) {
                        scr_printf(" to %s", recipient);
                }
                scr_printf("\n");
-               if (subject != NULL) if (strlen(subject) > 0) {
+               if (subject != NULL) if (!IsEmptyStr(subject)) {
                        scr_printf("Subject: %s\n", subject);
                }
                fp = fopen(filename, "r");
@@ -1101,8 +1116,9 @@ void break_big_lines(char *msg) {
  */
 int entmsg(CtdlIPC *ipc,
                int is_reply,   /* nonzero if this was a <R>eply command */
-               int c)          /* mode */
-{
+               int c,          /* mode */
+               int masquerade  /* prompt for a non-default display name? */
+) {
        char buf[SIZ];
        int a, b;
        int need_recp = 0;
@@ -1113,6 +1129,7 @@ int entmsg(CtdlIPC *ipc,
        struct ctdlipcmessage message;
        unsigned long *msgarr = NULL;
        int r;                  /* IPC response code */
+       int subject_required = 0;
 
        if (c > 0)
                mode = 1;
@@ -1128,10 +1145,15 @@ int entmsg(CtdlIPC *ipc,
        strcpy(message.recipient, "");
        strcpy(message.author, "");
        strcpy(message.subject, "");
-       message.text = message.author;  /* point to "", changes later */
+       message.text = "";              /* point to "", changes later */
        message.anonymous = 0;
        message.type = mode;
-       r = CtdlIPCPostMessage(ipc, 0, &message, buf);
+
+       if (masquerade) {
+               newprompt("Display name for this message: ", message.author, 40);
+       }
+
+       r = CtdlIPCPostMessage(ipc, 0, &subject_required, &message, buf);
 
        if (r / 100 != 2 && r / 10 != 57) {
                scr_printf("%s\n", buf);
@@ -1159,8 +1181,8 @@ int entmsg(CtdlIPC *ipc,
                                strcpy(buf, reply_to);
                        } else {
                                scr_printf("Enter recipient: ");
-                               getline(buf, (SIZ-100) );
-                               if (strlen(buf) == 0)
+                               ctdl_getline(buf, (SIZ-100) );
+                               if (IsEmptyStr(buf))
                                        return (1);
                        }
                } else
@@ -1169,7 +1191,7 @@ int entmsg(CtdlIPC *ipc,
        strcpy(message.recipient, buf);
 
        if (is_reply) {
-               if (strlen(reply_subject) > 0) {
+               if (!IsEmptyStr(reply_subject)) {
                        if (!strncasecmp(reply_subject,
                           "Re: ", 3)) {
                                strcpy(message.subject, reply_subject);
@@ -1190,8 +1212,8 @@ int entmsg(CtdlIPC *ipc,
        }
 
        /* If it's mail, we've got to check the validity of the recipient... */
-       if (strlen(message.recipient) > 0) {
-               r = CtdlIPCPostMessage(ipc, 0, &message, buf);
+       if (!IsEmptyStr(message.recipient)) {
+               r = CtdlIPCPostMessage(ipc, 0, &subject_required,  &message, buf);
                if (r / 100 != 2) {
                        scr_printf("%s\n", buf);
                        return (1);
@@ -1212,7 +1234,8 @@ int entmsg(CtdlIPC *ipc,
 
        /* Now compose the message... */
        if (client_make_message(ipc, temp, message.recipient,
-          message.anonymous, 0, c, message.subject) != 0) {
+          message.anonymous, 0, c, message.subject, subject_required) != 0) {
+           if (msgarr) free(msgarr);   
                return (2);
        }
 
@@ -1235,7 +1258,7 @@ int entmsg(CtdlIPC *ipc,
        break_big_lines(message.text);
 
        /* Transmit message to the server */
-       r = CtdlIPCPostMessage(ipc, 1, &message, buf);
+       r = CtdlIPCPostMessage(ipc, 1, NULL, &message, buf);
        if (r / 100 != 4) {
                scr_printf("%s\n", buf);
                return (1);
@@ -1284,6 +1307,7 @@ int entmsg(CtdlIPC *ipc,
                scr_printf("*** %d additional messages have been entered "
                        "in this room by other users.\n", b);
        }
+    free(message.text);
 
        return(0);
 }
@@ -1310,10 +1334,10 @@ void process_quote(void)
                scr_printf("%2d %s", ++line, buf);
        }
        scr_printf("Begin quoting at [ 1] : ");
-       getline(buf, 3);
+       ctdl_getline(buf, 3);
        qstart = (buf[0] == 0) ? (1) : atoi(buf);
        scr_printf("  End quoting at [%d] : ", line);
-       getline(buf, 3);
+       ctdl_getline(buf, 3);
        qend = (buf[0] == 0) ? (line) : atoi(buf);
        rewind(qfile);
        line = 0;
@@ -1465,9 +1489,8 @@ void image_view(CtdlIPC *ipc, unsigned long msg)
                                        len = (size_t)extract_long(buf, 0);
                                        progress(ipc, len, len);
                                        scr_flush();
-                                       snprintf(tmp, sizeof tmp, "%s.%s",
-                                               tmpnam(NULL),
-                                               ptr->filename);
+                                       CtdlMakeTempFileName(tmp, sizeof tmp);
+                                       strcat(tmp, ptr->filename);
                                        save_buffer(file, len, tmp);
                                        free(file);
                                        do_image_view(tmp);
@@ -1510,7 +1533,7 @@ void readmsgs(CtdlIPC *ipc,
        else
                b = 0;
 
-       strcpy(prtfile, tmpnam(NULL));
+       CtdlMakeTempFileName(prtfile, sizeof prtfile);
 
        if (msg_arr) {
                free(msg_arr);
@@ -1624,7 +1647,7 @@ RMSGREAD: scr_flush();
                        keyopt("<B>ack <A>gain <Q>uote <R>eply <N>ext <S>top ");
                        if (rc_url_cmd[0] && num_urls)
                                keyopt("<U>RLview ");
-                       if (has_images > 0 && strlen(imagecmd) > 0)
+                       if (has_images > 0 && !IsEmptyStr(imagecmd))
                                keyopt("<I>mages ");
                        keyopt("<?>help -> ");
 
@@ -1637,14 +1660,15 @@ RMSGREAD:       scr_flush();
 /* space key same as <N> */ if (e == 32)
                                        e = 'n';
 /* del/move for aides only */
-                                   if ((!is_room_aide)
-                                       && ((room_flags & QR_MAILBOX) ==
-                                           0)) {
+                                   if (  (!is_room_aide)
+                                      && ((room_flags & QR_MAILBOX) == 0)
+                                      && ((room_flags2 & QR2_COLLABDEL) == 0)
+                                      ) {
                                        if ((e == 'd') || (e == 'm'))
                                                e = 0;
                                }
 /* print only if available */
-                               if ((e == 'p') && (strlen(printcmd) == 0))
+                               if ((e == 'p') && (IsEmptyStr(printcmd)))
                                        e = 0;
 /* can't file if not allowed */
                                    if ((e == 'f')
@@ -1652,10 +1676,10 @@ RMSGREAD:       scr_flush();
                                        e = 0;
 /* link only if browser avail*/
                                    if ((e == 'u')
-                                       && (strlen(rc_url_cmd) == 0))
+                                       && (IsEmptyStr(rc_url_cmd)))
                                        e = 0;
                                if ((e == 'i')
-                                       && (!strlen(imagecmd) || !has_images))
+                                       && (IsEmptyStr(imagecmd) || !has_images))
                                        e = 0;
                        } while ((e != 'a') && (e != 'n') && (e != 's')
                                 && (e != 'd') && (e != 'm') && (e != 'p')
@@ -1727,13 +1751,15 @@ RMSGREAD:       scr_flush();
                                " N  Next (continue with next message)\n"
                                " Y  My Next (continue with next message you authored)\n"
                                " B  Back (go back to previous message)\n");
-                       if ((is_room_aide)
-                           || (room_flags & QR_MAILBOX)) {
+                       if (  (is_room_aide)
+                          || (room_flags & QR_MAILBOX)
+                          || (room_flags2 & QR2_COLLABDEL)
+                       ) {
                                scr_printf(" D  Delete this message\n"
                                        " M  Move message to another room\n");
                        }
                        scr_printf(" C  Copy message to another room\n");
-                       if (strlen(printcmd) > 0)
+                       if (!IsEmptyStr(printcmd))
                                scr_printf(" P  Print this message\n");
                        scr_printf(
                                " Q  Quote portions of this message for your next post\n"
@@ -1743,9 +1769,9 @@ RMSGREAD: scr_flush();
                        if (rc_allow_attachments)
                                scr_printf
                                    (" F  (save attachments to a file)\n");
-                       if (strlen(rc_url_cmd) > 0)
+                       if (!IsEmptyStr(rc_url_cmd))
                                scr_printf(" U  (list URL's for display)\n");
-                       if (strlen(imagecmd) > 0 && has_images > 0)
+                       if (!IsEmptyStr(imagecmd) && has_images > 0)
                                scr_printf(" I  Image viewer\n");
                        scr_printf("\n");
                        goto RMSGREAD;
@@ -1774,7 +1800,7 @@ RMSGREAD: scr_flush();
                case 'c':
                        newprompt("Enter target room: ",
                                  targ, ROOMNAMELEN - 1);
-                       if (strlen(targ) > 0) {
+                       if (!IsEmptyStr(targ)) {
                                r = CtdlIPCMoveMessage(ipc, (e == 'c' ? 1 : 0),
                                                       msg_arr[a], targ, cmd);
                                scr_printf("%s\n", cmd);
@@ -1799,7 +1825,7 @@ RMSGREAD: scr_flush();
                                 * Part 1 won't have a filename; use the
                                 * subject of the message instead. IO
                                 */
-                               if (!strlen(filename))
+                               if (IsEmptyStr(filename))
                                        strcpy(filename, reply_subject);
                                destination_directory(save_to, filename);
                                save_buffer(attachment,
@@ -1827,7 +1853,7 @@ RMSGREAD: scr_flush();
                        goto RMSGREAD;
                case 'r':
                        savedpos = num_msgs;
-                       entmsg(ipc, 1, (rc_reply_extedit ? 2 : 0));
+                       entmsg(ipc, 1, ((userflags & US_EXTEDIT) ? 2 : 0), 0);
                        num_msgs = savedpos;
                        goto RMSGREAD;
                case 'u':
@@ -1841,7 +1867,7 @@ RMSGREAD: scr_flush();
             /* find the next message by me, stay here if we find nothing */
             int finda;
             int lasta = a;
-            for (finda = a; ((finda < num_msgs) && (finda >= 0)); finda += rdir)
+            for (finda = (a + rdir); ((finda < num_msgs) && (finda >= 0)); finda += rdir)
               {
                /* This is repetitively dumb, but that's what computers are for.
                   We have to load up messages until we find one by us */
@@ -1909,7 +1935,7 @@ void check_message_base(CtdlIPC *ipc)
                return;
        }
 
-       while (transcript && strlen(transcript)) {
+       while (transcript && !IsEmptyStr(transcript)) {
                lines_printed = 1;
                extract_token(buf, transcript, 0, '\n', sizeof buf);
                remove_token(transcript, 0, '\n');