Create some directories to hold the source files for the utility
[citadel.git] / citadel / messages.c
index 41d391858668e691c9e579944c12cd09f8ed0423..fdd8d46b4c2649ad23967994f283bbddf4d04138 100644 (file)
@@ -2,7 +2,7 @@
  * $Id$
  *
  * Citadel message support routines
- * see copyright.txt for copyright information
+ * see COPYING for copyright information
  */
 
 #include "sysdep.h"
 #endif
 
 #include <stdarg.h>
+#include <libcitadel.h>
 #include "citadel.h"
 #include "citadel_ipc.h"
 #include "citadel_decls.h"
 #include "messages.h"
 #include "commands.h"
 #include "rooms.h"
-#include "tools.h"
-#include "html.h"
 #ifndef HAVE_SNPRINTF
 #include "snprintf.h"
 #endif
@@ -53,6 +52,8 @@
 
 char reply_to[SIZ];
 char reply_subject[SIZ];
+char reply_references[SIZ];
+char reply_inreplyto[SIZ];
 
 struct cittext {
        struct cittext *next;
@@ -70,6 +71,7 @@ int msg_arr_size = 0;
 int num_msgs;
 char rc_alt_semantics;
 extern char room_name[];
+extern char tempdir[];
 extern unsigned room_flags;
 extern unsigned room_flags2;
 extern long highest_msg_read;
@@ -217,6 +219,7 @@ void citedit(CtdlIPC *ipc, FILE * fp)
        struct cittext *textlist = NULL;
        struct cittext *ptr;
        char wordbuf[MAXWORDBUF];
+       int rv = 0;
 
        /* first, load the text into the buffer */
        fseek(fp, 0L, 0);
@@ -272,7 +275,7 @@ void citedit(CtdlIPC *ipc, FILE * fp)
                }
 
                if (a == 8) {
-                       if (strlen(wordbuf) > 0) {
+                       if (!IsEmptyStr(wordbuf)) {
                                wordbuf[strlen(wordbuf) - 1] = 0;
                                scr_putc(8);
                                scr_putc(32);
@@ -284,10 +287,10 @@ void citedit(CtdlIPC *ipc, FILE * fp)
                                scr_putc(8);
                                scr_putc(32);
                                scr_putc(8);
-                       } while (strlen(wordbuf) && wordbuf[strlen(wordbuf) - 1] != ' ');
+                       } while (!IsEmptyStr(wordbuf) && wordbuf[strlen(wordbuf) - 1] != ' ');
                } else if (a == 13) {
                        scr_printf("\n");
-                       if (strlen(wordbuf) == 0)
+                       if (IsEmptyStr(wordbuf))
                                finished = 1;
                        else {
                                for (b = 0; b < strlen(wordbuf); ++b)
@@ -345,7 +348,7 @@ void citedit(CtdlIPC *ipc, FILE * fp)
        }
        putc(10, fp);
        fflush(fp);
-       ftruncate(fileno(fp), ftell(fp));
+       rv = ftruncate(fileno(fp), ftell(fp));
 
        /* and deallocate the memory we used */
        while (textlist != NULL) {
@@ -404,16 +407,18 @@ int read_message(CtdlIPC *ipc,
 
        strcpy(reply_to, NO_REPLY_TO);
        strcpy(reply_subject, "");
+       strcpy(reply_references, "");
+       strcpy(reply_inreplyto, "");
 
-       r = CtdlIPCGetSingleMessage(ipc, num, (pagin == READ_HEADER ? 1 : 0),
-                               (can_do_msg4 ? 4 : 0),
-                               &message, buf);
+       r = CtdlIPCGetSingleMessage(ipc, num, (pagin == READ_HEADER ? 1 : 0), 4, &message, buf);
        if (r / 100 != 1) {
                err_printf("*** msg #%ld: %d %s\n", num, r, buf);
                ++lines_printed;
-               lines_printed =
-                   checkpagin(lines_printed, pagin, screenheight);
+               lines_printed = checkpagin(lines_printed, pagin, screenheight);
                stty_ctdl(0);
+               free(message->text);
+               free_parts(message->attachments);
+               free(message);
                return (0);
        }
 
@@ -436,17 +441,17 @@ int read_message(CtdlIPC *ipc,
                                message->nhdr ? "yes" : "no",
                                message->author, message->type,
                                message->msgid);
-               if (strlen(message->subject)) {
+               if (!IsEmptyStr(message->subject)) {
                        pprintf("subj=%s\n", message->subject);
                }
-               if (strlen(message->email)) {
+               if (!IsEmptyStr(message->email)) {
                        pprintf("rfca=%s\n", message->email);
                }
                pprintf("hnod=%s\nroom=%s\nnode=%s\ntime=%s",
                                message->hnod, message->room,
                                message->node, 
                                asctime(localtime(&message->time)));
-               if (strlen(message->recipient)) {
+               if (!IsEmptyStr(message->recipient)) {
                        pprintf("rcpt=%s\n", message->recipient);
                }
                if (message->attachments) {
@@ -461,6 +466,9 @@ int read_message(CtdlIPC *ipc,
                }
                pprintf("\n");
                stty_ctdl(0);
+               free(message->text);
+               free_parts(message->attachments);
+               free(message);
                return (0);
        }
 
@@ -486,7 +494,7 @@ int read_message(CtdlIPC *ipc,
                fmt_date(now, sizeof now, message->time, 0);
                if (dest) {
                        fprintf(dest, "%s from %s ", now, message->author);
-                       if (strlen(message->email)) {
+                       if (!IsEmptyStr(message->email)) {
                                fprintf(dest, "<%s> ", message->email);
                        }
                } else {
@@ -496,7 +504,7 @@ int read_message(CtdlIPC *ipc,
                        scr_printf("from ");
                        color(BRIGHT_CYAN);
                        scr_printf("%s ", message->author);
-                       if (strlen(message->email)) {
+                       if (!IsEmptyStr(message->email)) {
                                color(DIM_WHITE);
                                scr_printf("<");
                                color(BRIGHT_BLUE);
@@ -505,11 +513,11 @@ int read_message(CtdlIPC *ipc,
                                scr_printf("> ");
                        }
                }
-               if (strlen(message->node)) {
+               if (!IsEmptyStr(message->node)) {
                        if ((room_flags & QR_NETWORK)
                            || ((strcasecmp(message->node, ipc->ServInfo.nodename)
                             && (strcasecmp(message->node, ipc->ServInfo.fqdn))))) {
-                               if (strlen(message->email) == 0) {
+                               if (IsEmptyStr(message->email)) {
                                        if (dest) {
                                                fprintf(dest, "@%s ", message->node);
                                        } else {
@@ -522,7 +530,7 @@ int read_message(CtdlIPC *ipc,
                        }
                }
                if (strcasecmp(message->hnod, ipc->ServInfo.humannode)
-                   && (strlen(message->hnod)) && (!strlen(message->email))) {
+                   && (!IsEmptyStr(message->hnod)) && (IsEmptyStr(message->email))) {
                        if (dest) {
                                fprintf(dest, "(%s) ", message->hnod);
                        } else {
@@ -534,7 +542,7 @@ int read_message(CtdlIPC *ipc,
                                scr_printf(") ");
                        }
                }
-               if (strcasecmp(message->room, room_name) && (strlen(message->email) == 0)) {
+               if (strcasecmp(message->room, room_name) && (IsEmptyStr(message->email))) {
                        if (dest) {
                                fprintf(dest, "in %s> ", message->room);
                        } else {
@@ -544,7 +552,7 @@ int read_message(CtdlIPC *ipc,
                                scr_printf("%s> ", message->room);
                        }
                }
-               if (strlen(message->recipient)) {
+               if (!IsEmptyStr(message->recipient)) {
                        if (dest) {
                                fprintf(dest, "to %s ", message->recipient);
                        } else {
@@ -564,8 +572,8 @@ int read_message(CtdlIPC *ipc,
 
        /* Set the reply-to address to an Internet e-mail address if possible
         */
-       if (message->email != NULL) if (strlen(message->email) > 0) {
-               if (strlen(message->author) > 0) {
+       if ((message->email != NULL) && (!IsEmptyStr(message->email))) {
+               if (!IsEmptyStr(message->author)) {
                        snprintf(reply_to, sizeof reply_to, "%s <%s>", message->author, message->email);
                }
                else {
@@ -585,10 +593,18 @@ int read_message(CtdlIPC *ipc,
                lines_printed = checkpagin(lines_printed, pagin, screenheight);
        }
 
+
+       if (message->msgid != NULL) {
+               safestrncpy(reply_inreplyto, message->msgid, sizeof reply_inreplyto);
+       }
+
+       if (message->references != NULL) if (!IsEmptyStr(message->references)) {
+               safestrncpy(reply_references, message->references, sizeof reply_references);
+       }
+
        if (message->subject != NULL) {
-               safestrncpy(reply_subject, message->subject,
-                                               sizeof reply_subject);
-               if (strlen(message->subject) > 0) {
+               safestrncpy(reply_subject, message->subject, sizeof reply_subject);
+               if (!IsEmptyStr(message->subject)) {
                        if (dest) {
                                fprintf(dest, "Subject: %s\n",
                                                        message->subject);
@@ -669,7 +685,7 @@ int read_message(CtdlIPC *ipc,
 
                        if (sigcaught == 0) {
                                linelen = strlen(lineptr);
-                               if (lineptr[linelen-1] == '\r') {
+                               if (linelen && (lineptr[linelen-1] == '\r')) {
                                        lineptr[--linelen] = 0;
                                }
                                if (dest) {
@@ -697,11 +713,12 @@ int read_message(CtdlIPC *ipc,
                        scr_printf("\n");
                        ++lines_printed;
                        lines_printed = checkpagin(lines_printed, pagin, screenheight);
+                       fr = sigcaught;         
                }
        }
 
        /* Enumerate any attachments */
-       if ( (pagin == 1) && (can_do_msg4) && (message->attachments) ) {
+       if ( (pagin == 1) && (message->attachments) ) {
                struct parts *ptr;
 
                for (ptr = message->attachments; ptr; ptr = ptr->next) {
@@ -710,7 +727,7 @@ int read_message(CtdlIPC *ipc,
                           || (!strcasecmp(ptr->disposition, ""))
                        ) {
                                if ( (strcasecmp(ptr->number, message->mime_chosen))
-                                  && (strlen(ptr->mimetype) > 0)
+                                  && (!IsEmptyStr(ptr->mimetype))
                                ) {
                                        color(DIM_WHITE);
                                        pprintf("Part ");
@@ -757,18 +774,21 @@ void replace_string(char *filename, long int startpos)
        char *ptr;
        int substitutions = 0;
        long msglen = 0L;
+       int rv;
 
        scr_printf("Enter text to be replaced:\n: ");
        ctdl_getline(srch_str, (sizeof(srch_str)-1) );
-       if (strlen(srch_str) == 0)
+       if (IsEmptyStr(srch_str)) {
                return;
+       }
 
        scr_printf("Enter text to replace it with:\n: ");
        ctdl_getline(rplc_str, (sizeof(rplc_str)-1) );
 
        fp = fopen(filename, "r+");
-       if (fp == NULL)
+       if (fp == NULL) {
                return;
+       }
 
        wpos = startpos;
        fseek(fp, startpos, 0);
@@ -787,18 +807,19 @@ void replace_string(char *filename, long int startpos)
                if (strlen(buf) > 384) {
                        rpos = ftell(fp);
                        fseek(fp, wpos, 0);
-                       fwrite((char *) buf, 128, 1, fp);
+                       rv = fwrite((char *) buf, 128, 1, fp);
                        strcpy(buf, &buf[128]);
                        wpos = ftell(fp);
                        fseek(fp, rpos, 0);
                }
        }
        fseek(fp, wpos, 0);
-       if (strlen(buf) > 0)
-               fwrite((char *) buf, strlen(buf), 1, fp);
+       if (!IsEmptyStr(buf)) {
+               rv = fwrite((char *) buf, strlen(buf), 1, fp);
+       }
        wpos = ftell(fp);
        fclose(fp);
-       truncate(filename, wpos);
+       rv = truncate(filename, wpos);
        scr_printf("<R>eplace made %d substitution(s).\n\n", substitutions);
 }
 
@@ -806,12 +827,13 @@ void replace_string(char *filename, long int startpos)
  * Function to begin composing a new message
  */
 int client_make_message(CtdlIPC *ipc,
-               char *filename,         /* temporary file name */
-               char *recipient,        /* NULL if it's not mail */
-               int is_anonymous,
-               int format_type,
-               int mode,
-               char *subject)          /* buffer to store subject line */
+                                               char *filename,         /* temporary file name */
+                                               char *recipient,        /* NULL if it's not mail */
+                                               int is_anonymous,
+                                               int format_type,
+                                               int mode,
+                                               char *subject,          /* buffer to store subject line */
+                                               int subject_required)
 {
        FILE *fp;
        int a, b, e_ex_code;
@@ -823,9 +845,9 @@ int client_make_message(CtdlIPC *ipc,
 
        if (mode >= 2)
        {
-               if((mode-2) < MAX_EDITORS && strlen(editor_paths[mode-2]) > 0) {
+               if((mode-2) < MAX_EDITORS && !IsEmptyStr(editor_paths[mode-2])) {
                        editor_path = editor_paths[mode-2];
-               } else if (strlen(editor_paths[0]) > 0) {
+               } else if (!IsEmptyStr(editor_paths[0])) {
                        editor_path = editor_paths[0];
                } else {
                        err_printf("*** No editor available, "
@@ -846,16 +868,20 @@ int client_make_message(CtdlIPC *ipc,
                        datestr,
                        (is_anonymous ? "[anonymous]" : fullname)
                        );
-               if (strlen(recipient) > 0) {
+               if (!IsEmptyStr(recipient)) {
                        size_t tmp = strlen(header);
                        snprintf(&header[tmp], sizeof header - tmp,
                                " to %s", recipient);
                }
        }
        scr_printf("%s\n", header);
-       if (subject != NULL) if (strlen(subject) > 0) {
+       if (subject != NULL) if (!IsEmptyStr(subject)) {
                scr_printf("Subject: %s\n", subject);
        }
+       
+       if ( (subject_required) && (IsEmptyStr(subject)) ) {
+               newprompt("Subject: ", subject, 70);
+       }
 
        beg = 0L;
 
@@ -968,11 +994,11 @@ MECR:     if (mode >= 2) {
        if (b == 's') goto MEFIN;
        if (b == 'p') {
                scr_printf(" %s from %s", datestr, fullname);
-               if (strlen(recipient) > 0) {
+               if (!IsEmptyStr(recipient)) {
                        scr_printf(" to %s", recipient);
                }
                scr_printf("\n");
-               if (subject != NULL) if (strlen(subject) > 0) {
+               if (subject != NULL) if (!IsEmptyStr(subject)) {
                        scr_printf("Subject: %s\n", subject);
                }
                fp = fopen(filename, "r");
@@ -1010,65 +1036,6 @@ MEABT2:  unlink(filename);
 }
 
 
-#if 0
-/*
- * Transmit message text to the server.
- * 
- * This loop also implements a "tick" counter that displays the progress, if
- * we're sending something that will take a long time to transmit.
- */
-void transmit_message(CtdlIPC *ipc, FILE *fp)
-{
-       char buf[SIZ];
-       int ch, a;
-       long msglen;
-       time_t lasttick;
-
-       fseek(fp, 0L, SEEK_END);
-       msglen = ftell(fp);
-       rewind(fp);
-       lasttick = time(NULL);
-       strcpy(buf, "");
-       while (ch = getc(fp), (ch >= 0)) {
-               if (ch == 10) {
-                       if (!strcmp(buf, "000"))
-                               strcpy(buf, ">000");
-                       CtdlIPC_putline(ipc, buf);
-                       strcpy(buf, "");
-               } else {
-                       a = strlen(buf);
-                       buf[a + 1] = 0;
-                       buf[a] = ch;
-                       if ((ch == 32) && (strlen(buf) > 200)) {
-                               buf[a] = 0;
-                               if (!strcmp(buf, "000"))
-                                       strcpy(buf, ">000");
-                               CtdlIPC_putline(ipc, buf);
-                               strcpy(buf, "");
-                       }
-                       if (strlen(buf) > 250) {
-                               if (!strcmp(buf, "000"))
-                                       strcpy(buf, ">000");
-                               CtdlIPC_putline(ipc, buf);
-                               strcpy(buf, "");
-                       }
-               }
-
-               if ((time(NULL) - lasttick) > 2L) {
-                       scr_printf(" %3ld%% completed\r",
-                              ((ftell(fp) * 100L) / msglen));
-                       scr_flush();
-                       lasttick = time(NULL);
-               }
-
-       }
-       CtdlIPC_putline(ipc, buf);
-       scr_printf("                \r");
-       scr_flush();
-}
-#endif
-
-
 /*
  * Make sure there's room in msg_arr[] for at least one more.
  */
@@ -1124,6 +1091,7 @@ int entmsg(CtdlIPC *ipc,
        struct ctdlipcmessage message;
        unsigned long *msgarr = NULL;
        int r;                  /* IPC response code */
+       int subject_required = 0;
 
        if (c > 0)
                mode = 1;
@@ -1139,6 +1107,7 @@ int entmsg(CtdlIPC *ipc,
        strcpy(message.recipient, "");
        strcpy(message.author, "");
        strcpy(message.subject, "");
+       strcpy(message.references, "");
        message.text = "";              /* point to "", changes later */
        message.anonymous = 0;
        message.type = mode;
@@ -1147,7 +1116,7 @@ int entmsg(CtdlIPC *ipc,
                newprompt("Display name for this message: ", message.author, 40);
        }
 
-       r = CtdlIPCPostMessage(ipc, 0, &message, buf);
+       r = CtdlIPCPostMessage(ipc, 0, &subject_required, &message, buf);
 
        if (r / 100 != 2 && r / 10 != 57) {
                scr_printf("%s\n", buf);
@@ -1176,7 +1145,7 @@ int entmsg(CtdlIPC *ipc,
                        } else {
                                scr_printf("Enter recipient: ");
                                ctdl_getline(buf, (SIZ-100) );
-                               if (strlen(buf) == 0)
+                               if (IsEmptyStr(buf))
                                        return (1);
                        }
                } else
@@ -1185,7 +1154,8 @@ int entmsg(CtdlIPC *ipc,
        strcpy(message.recipient, buf);
 
        if (is_reply) {
-               if (strlen(reply_subject) > 0) {
+
+               if (!IsEmptyStr(reply_subject)) {
                        if (!strncasecmp(reply_subject,
                           "Re: ", 3)) {
                                strcpy(message.subject, reply_subject);
@@ -1197,6 +1167,21 @@ int entmsg(CtdlIPC *ipc,
                                        reply_subject);
                        }
                }
+
+               /* Trim down excessively long lists of thread references.  We eliminate the
+                * second one in the list so that the thread root remains intact.
+                */
+               int rrtok = num_tokens(reply_references, '|');
+               int rrlen = strlen(reply_references);
+               if ( ((rrtok >= 3) && (rrlen > 900)) || (rrtok > 10) ) {
+                       remove_token(reply_references, 1, '|');
+               }
+
+               snprintf(message.references, sizeof message.references, "%s%s%s",
+                       reply_references,
+                       (IsEmptyStr(reply_references) ? "" : "|"),
+                       reply_inreplyto
+               );
        }
 
        if (room_flags & QR_ANONOPT) {
@@ -1206,8 +1191,8 @@ int entmsg(CtdlIPC *ipc,
        }
 
        /* If it's mail, we've got to check the validity of the recipient... */
-       if (strlen(message.recipient) > 0) {
-               r = CtdlIPCPostMessage(ipc, 0, &message, buf);
+       if (!IsEmptyStr(message.recipient)) {
+               r = CtdlIPCPostMessage(ipc, 0, &subject_required,  &message, buf);
                if (r / 100 != 2) {
                        scr_printf("%s\n", buf);
                        return (1);
@@ -1228,7 +1213,7 @@ int entmsg(CtdlIPC *ipc,
 
        /* Now compose the message... */
        if (client_make_message(ipc, temp, message.recipient,
-          message.anonymous, 0, c, message.subject) != 0) {
+          message.anonymous, 0, c, message.subject, subject_required) != 0) {
            if (msgarr) free(msgarr);   
                return (2);
        }
@@ -1252,7 +1237,7 @@ int entmsg(CtdlIPC *ipc,
        break_big_lines(message.text);
 
        /* Transmit message to the server */
-       r = CtdlIPCPostMessage(ipc, 1, &message, buf);
+       r = CtdlIPCPostMessage(ipc, 1, NULL, &message, buf);
        if (r / 100 != 4) {
                scr_printf("%s\n", buf);
                return (1);
@@ -1323,19 +1308,23 @@ void process_quote(void)
 
        /* Display the quotable text with line numbers added */
        line = 0;
-       fgets(buf, 128, qfile);
+       if (fgets(buf, 128, qfile) == NULL) {
+               /* we're skipping a line here */
+       }
        while (fgets(buf, 128, qfile) != NULL) {
-               scr_printf("%2d %s", ++line, buf);
+               scr_printf("%3d %s", ++line, buf);
        }
-       scr_printf("Begin quoting at [ 1] : ");
-       ctdl_getline(buf, 3);
+       scr_printf("Begin quoting at [1] : ");
+       ctdl_getline(buf, 4);
        qstart = (buf[0] == 0) ? (1) : atoi(buf);
        scr_printf("  End quoting at [%d] : ", line);
-       ctdl_getline(buf, 3);
+       ctdl_getline(buf, 4);
        qend = (buf[0] == 0) ? (line) : atoi(buf);
        rewind(qfile);
        line = 0;
-       fgets(buf, 128, qfile);
+       if (fgets(buf, 128, qfile) == NULL) {
+               /* we're skipping a line here */
+       }
        tfile = fopen(temp, "w");
        while (fgets(buf, 128, qfile) != NULL) {
                if ((++line >= qstart) && (line <= qend))
@@ -1356,6 +1345,7 @@ void list_urls(CtdlIPC *ipc)
 {
        int i;
        char cmd[SIZ];
+       int rv;
 
        if (num_urls == 0) {
                scr_printf("There were no URL's in the previous message.\n\n");
@@ -1370,7 +1360,7 @@ void list_urls(CtdlIPC *ipc)
                i = intprompt("Display which one", 1, 1, num_urls);
 
        snprintf(cmd, sizeof cmd, rc_url_cmd, urls[i - 1]);
-       system(cmd);
+       rv = system(cmd);
        scr_printf("\n");
 }
 
@@ -1519,8 +1509,10 @@ void readmsgs(CtdlIPC *ipc,
        char filename[PATH_MAX];
        char save_to[PATH_MAX];
        void *attachment = NULL;        /* Downloaded attachment */
-       FILE *dest = NULL;      /* Alternate destination other than screen */
+       FILE *dest = NULL;              /* Alternate destination other than screen */
        int r;                          /* IPC response code */
+       static int att_seq = 0;         /* Attachment download sequence number */
+       int rv = 0;                     /* silence the stupid warn_unused_result warnings */
 
        if (c < 0)
                b = (num_msgs - 1);
@@ -1596,6 +1588,8 @@ RMSGREAD: scr_flush();
                        quotflag = 0;
                        enable_color = hold_color;
                        process_quote();
+                       e = 'r';
+                       goto DONE_QUOTING;
                }
                if (arcflag) {
                        fclose(dest);
@@ -1604,7 +1598,9 @@ RMSGREAD: scr_flush();
                        enable_color = hold_color;
                        f = fork();
                        if (f == 0) {
-                               freopen(prtfile, "r", stdin);
+                               if (freopen(prtfile, "r", stdin) == NULL) {
+                                       /* we probably should handle the error condition here */
+                               }
                                screen_reset();
                                stty_ctdl(SB_RESTORE);
                                ka_system(printcmd);
@@ -1624,10 +1620,10 @@ RMSGREAD:       scr_flush();
 
                        r = CtdlIPCSetMessageSeen(ipc, msg_arr[a], 1, buf);
                }
-               if (e == 3)
+               if (e == SIGQUIT)
                        return;
-               if (((userflags & US_NOPROMPT) || (e == 2))
-                   && (((room_flags & QR_MAILBOX) == 0)
+               if (((userflags & US_NOPROMPT) || (e == SIGINT))
+                       && (((room_flags & QR_MAILBOX) == 0)
                        || (rc_force_mail_prompts == 0))) {
                        e = 'n';
                } else {
@@ -1638,10 +1634,10 @@ RMSGREAD:       scr_flush();
                        color(DIM_WHITE);
                        scr_printf(") ");
 
-                       keyopt("<B>ack <A>gain <Q>uote <R>eply <N>ext <S>top ");
+                       keyopt("<B>ack <A>gain <R>eply reply<Q>uoted <N>ext <S>top ");
                        if (rc_url_cmd[0] && num_urls)
                                keyopt("<U>RLview ");
-                       if (has_images > 0 && strlen(imagecmd) > 0)
+                       if (has_images > 0 && !IsEmptyStr(imagecmd))
                                keyopt("<I>mages ");
                        keyopt("<?>help -> ");
 
@@ -1662,7 +1658,7 @@ RMSGREAD: scr_flush();
                                                e = 0;
                                }
 /* print only if available */
-                               if ((e == 'p') && (strlen(printcmd) == 0))
+                               if ((e == 'p') && (IsEmptyStr(printcmd)))
                                        e = 0;
 /* can't file if not allowed */
                                    if ((e == 'f')
@@ -1670,17 +1666,17 @@ RMSGREAD:       scr_flush();
                                        e = 0;
 /* link only if browser avail*/
                                    if ((e == 'u')
-                                       && (strlen(rc_url_cmd) == 0))
+                                       && (IsEmptyStr(rc_url_cmd)))
                                        e = 0;
                                if ((e == 'i')
-                                       && (!strlen(imagecmd) || !has_images))
+                                       && (IsEmptyStr(imagecmd) || !has_images))
                                        e = 0;
                        } while ((e != 'a') && (e != 'n') && (e != 's')
                                 && (e != 'd') && (e != 'm') && (e != 'p')
                                 && (e != 'q') && (e != 'b') && (e != 'h')
                                 && (e != 'r') && (e != 'f') && (e != '?')
                                 && (e != 'u') && (e != 'c') && (e != 'y')
-                                && (e != 'i'));
+                                && (e != 'i') && (e != 'o') );
                        switch (e) {
                        case 's':
                                scr_printf("Stop");
@@ -1704,7 +1700,7 @@ RMSGREAD: scr_flush();
                                scr_printf("Print");
                                break;
                        case 'q':
-                               scr_printf("Quote");
+                               scr_printf("reply Quoted");
                                break;
                        case 'b':
                                scr_printf("Back");
@@ -1715,6 +1711,9 @@ RMSGREAD: scr_flush();
                        case 'r':
                                scr_printf("Reply");
                                break;
+                       case 'o':
+                               scr_printf("Open attachments");
+                               break;
                        case 'f':
                                scr_printf("File");
                                break;
@@ -1736,7 +1735,7 @@ RMSGREAD: scr_flush();
                                scr_printf("\n");
                        scr_flush();
                }
-               switch (e) {
+DONE_QUOTING:  switch (e) {
                case '?':
                        scr_printf("Options available here:\n"
                                " ?  Help (prints this message)\n"
@@ -1753,19 +1752,20 @@ RMSGREAD:       scr_flush();
                                        " M  Move message to another room\n");
                        }
                        scr_printf(" C  Copy message to another room\n");
-                       if (strlen(printcmd) > 0)
+                       if (!IsEmptyStr(printcmd))
                                scr_printf(" P  Print this message\n");
                        scr_printf(
-                               " Q  Quote portions of this message for your next post\n"
+                               " Q  Reply to this message, quoting portions of it\n"
                                " H  Headers (display message headers only)\n");
                        if (is_mail)
                                scr_printf(" R  Reply to this message\n");
-                       if (rc_allow_attachments)
-                               scr_printf
-                                   (" F  (save attachments to a file)\n");
-                       if (strlen(rc_url_cmd) > 0)
+                       if (rc_allow_attachments) {
+                               scr_printf(" O  (Open attachments)\n");
+                               scr_printf(" F  (save attachments to a File)\n");
+                       }
+                       if (!IsEmptyStr(rc_url_cmd))
                                scr_printf(" U  (list URL's for display)\n");
-                       if (strlen(imagecmd) > 0 && has_images > 0)
+                       if (!IsEmptyStr(imagecmd) && has_images > 0)
                                scr_printf(" I  Image viewer\n");
                        scr_printf("\n");
                        goto RMSGREAD;
@@ -1794,7 +1794,7 @@ RMSGREAD: scr_flush();
                case 'c':
                        newprompt("Enter target room: ",
                                  targ, ROOMNAMELEN - 1);
-                       if (strlen(targ) > 0) {
+                       if (!IsEmptyStr(targ)) {
                                r = CtdlIPCMoveMessage(ipc, (e == 'c' ? 1 : 0),
                                                       msg_arr[a], targ, cmd);
                                scr_printf("%s\n", cmd);
@@ -1806,9 +1806,9 @@ RMSGREAD: scr_flush();
                        if (r / 100 != 2)       /* r will be init'ed, FIXME */
                                goto RMSGREAD;  /* the logic here sucks */
                        break;
+               case 'o':
                case 'f':
-                       newprompt("Which section? ", filename,
-                                 ((sizeof filename) - 1));
+                       newprompt("Which section? ", filename, ((sizeof filename) - 1));
                        r = CtdlIPCAttachmentDownload(ipc, msg_arr[a],
                                        filename, &attachment, progress, cmd);
                        if (r / 100 != 2) {
@@ -1819,12 +1819,23 @@ RMSGREAD:       scr_flush();
                                 * Part 1 won't have a filename; use the
                                 * subject of the message instead. IO
                                 */
-                               if (!strlen(filename))
+                               if (IsEmptyStr(filename)) {
                                        strcpy(filename, reply_subject);
-                               destination_directory(save_to, filename);
-                               save_buffer(attachment,
-                                               extract_unsigned_long(cmd, 0),
-                                               save_to);
+                               }
+                               if (e == 'o') {         /* open attachment */
+                                       mkdir(tempdir, 0700);
+                                       snprintf(save_to, sizeof save_to, "%s/%04x.%s",
+                                               tempdir,
+                                               ++att_seq,
+                                               filename);
+                                       save_buffer(attachment, extract_unsigned_long(cmd, 0), save_to);
+                                       snprintf(cmd, sizeof cmd, rc_open_cmd, save_to);
+                                       rv = system(cmd);
+                               }
+                               else {                  /* save attachment to disk */
+                                       destination_directory(save_to, filename);
+                                       save_buffer(attachment, extract_unsigned_long(cmd, 0), save_to);
+                               }
                        }
                        if (attachment) {
                                free(attachment);
@@ -1929,7 +1940,7 @@ void check_message_base(CtdlIPC *ipc)
                return;
        }
 
-       while (transcript && strlen(transcript)) {
+       while (transcript && !IsEmptyStr(transcript)) {
                lines_printed = 1;
                extract_token(buf, transcript, 0, '\n', sizeof buf);
                remove_token(transcript, 0, '\n');