* ical 'getics' now frees the icalcomponent data
[citadel.git] / citadel / modules / calendar / serv_calendar.c
index 7106a367273cfc00eae5dd34ea4991fc7c6a8351..247d177409bac73742b8e7b5f9de3cc586175ded 100644 (file)
@@ -19,7 +19,7 @@
 #ifdef HAVE_STRINGS_H
 #include <strings.h>
 #endif
-#include <ical.h>
+#include <libical/ical.h>
 #include <libcitadel.h>
 #include "citadel.h"
 #include "server.h"
@@ -52,8 +52,7 @@ icalcomponent *icalcomponent_new_citadel_vcalendar(void) {
 
        encaps = icalcomponent_new_vcalendar();
        if (encaps == NULL) {
-               CtdlLogPrintf(CTDL_CRIT, "Error at %s:%d - could not allocate component!\n",
-                       __FILE__, __LINE__);
+               CtdlLogPrintf(CTDL_CRIT, "ERROR: could not allocate component!\n");
                return NULL;
        }
 
@@ -87,11 +86,6 @@ icalcomponent *ical_encapsulate_subcomponent(icalcomponent *subcomp) {
        /* Encapsulate the subcomponent inside */
        icalcomponent_add_component(encaps, subcomp);
 
-       /* Convert all timestamps to UTC so we don't have to deal with
-        * stupid VTIMEZONE crap.
-        */
-       ical_dezonify(encaps);
-
        /* Return the object we just created. */
        return(encaps);
 }
@@ -105,8 +99,6 @@ icalcomponent *ical_encapsulate_subcomponent(icalcomponent *subcomp) {
  * to the currently selected room.
  */
 void ical_write_to_cal(struct ctdluser *u, icalcomponent *cal) {
-       char temp[PATH_MAX];
-       FILE *fp = NULL;
        char *ser = NULL;
        icalcomponent *encaps = NULL;
        struct CtdlMessage *msg = NULL;
@@ -126,29 +118,21 @@ void ical_write_to_cal(struct ctdluser *u, icalcomponent *cal) {
                return;
        }
 
-       ser = icalcomponent_as_ical_string(cal);
+       ser = icalcomponent_as_ical_string_r(cal);
        if (ser == NULL) return;
 
        /* If the caller supplied a user, write to that user's default calendar room */
        if (u) {
-               /* Make a temp file out of it */
-               CtdlMakeTempFileName(temp, sizeof temp);
-               fp = fopen(temp, "w");
-               if (fp != NULL) {
-                       fwrite(ser, strlen(ser), 1, fp);
-                       fclose(fp);
-               
-                       /* This handy API function does all the work for us. */
-                       CtdlWriteObject(USERCALENDARROOM,       /* which room */
-                               "text/calendar",        /* MIME type */
-                               temp,                   /* temp file */
-                               u,                      /* which user */
-                               0,                      /* not binary */
-                               0,                      /* don't delete others of this type */
-                               0                       /* no flags */
-                       );
-                       unlink(temp);
-               }
+               /* This handy API function does all the work for us. */
+               CtdlWriteObject(USERCALENDARROOM,       /* which room */
+                       "text/calendar",        /* MIME type */
+                       ser,                    /* data */
+                       strlen(ser)+1,          /* length */
+                       u,                      /* which user */
+                       0,                      /* not binary */
+                       0,                      /* don't delete others of this type */
+                       0                       /* no flags */
+               );
        }
 
        /* If the caller did not supply a user, write to the currently selected room */
@@ -167,44 +151,15 @@ void ical_write_to_cal(struct ctdluser *u, icalcomponent *cal) {
                strcat(msg->cm_fields['M'], ser);
        
                /* Now write the data */
-               CtdlSubmitMsg(msg, NULL, "");
+               CtdlSubmitMsg(msg, NULL, "", QP_EADDR);
                CtdlFreeMessage(msg);
        }
 
        /* In either case, now we can free the serialized calendar object */
-//     free(ser);
-}
-
-
-/*
- * Add a calendar object to the user's calendar
- * 
- * ok because it uses ical_write_to_cal()
- */
-void ical_add(icalcomponent *cal, int recursion_level) {
-       icalcomponent *c;
-
-       /*
-        * The VEVENT subcomponent is the one we're interested in saving.
-        */
-       if (icalcomponent_isa(cal) == ICAL_VEVENT_COMPONENT) {
-       
-               ical_write_to_cal(&CC->user, cal);
-
-       }
-
-       /* If the component has subcomponents, recurse through them. */
-       for (c = icalcomponent_get_first_component(cal, ICAL_ANY_COMPONENT);
-           (c != 0);
-           c = icalcomponent_get_next_component(cal, ICAL_ANY_COMPONENT)) {
-               /* Recursively process subcomponent */
-               ical_add(c, recursion_level+1);
-       }
-
+       free(ser);
 }
 
 
-
 /*
  * Send a reply to a meeting invitation.
  *
@@ -325,14 +280,14 @@ void ical_send_a_reply(icalcomponent *request, char *action) {
        }
 
        /* Now generate the reply message and send it out. */
-       serialized_reply = strdup(icalcomponent_as_ical_string(the_reply));
+       serialized_reply = icalcomponent_as_ical_string_r(the_reply);
        icalcomponent_free(the_reply);  /* don't need this anymore */
        if (serialized_reply == NULL) return;
 
        reply_message_text = malloc(strlen(serialized_reply) + SIZ);
        if (reply_message_text != NULL) {
                sprintf(reply_message_text,
-                       "Content-type: text/calendar charset=\"utf-8\"\r\n\r\n%s\r\n",
+                       "Content-type: text/calendar; charset=\"utf-8\"\r\n\r\n%s\r\n",
                        serialized_reply
                );
 
@@ -349,7 +304,7 @@ void ical_send_a_reply(icalcomponent *request, char *action) {
        
                if (msg != NULL) {
                        valid = validate_recipients(organizer_string, NULL, 0);
-                       CtdlSubmitMsg(msg, valid, "");
+                       CtdlSubmitMsg(msg, valid, "", QP_EADDR);
                        CtdlFreeMessage(msg);
                        free_recipients(valid);
                }
@@ -365,7 +320,7 @@ void ical_send_a_reply(icalcomponent *request, char *action) {
  */
 void ical_locate_part(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-               void *cbuserdata) {
+               char *cbid, void *cbuserdata) {
 
        struct ical_respond_data *ird = NULL;
 
@@ -392,9 +347,6 @@ void ical_locate_part(char *name, char *filename, char *partnum, char *disp,
        }
 
        ird->cal = icalcomponent_new_from_string(content);
-       if (ird->cal != NULL) {
-               ical_dezonify(ird->cal);
-       }
 }
 
 
@@ -445,7 +397,7 @@ void ical_respond(long msgnum, char *partnum, char *action) {
        if (ird.cal != NULL) {
                /* Save this in the user's calendar if necessary */
                if (!strcasecmp(action, "accept")) {
-                       ical_add(ird.cal, 0);
+                       ical_write_to_cal(&CC->user, ird.cal);
                }
 
                /* Send a reply if necessary */
@@ -453,9 +405,9 @@ void ical_respond(long msgnum, char *partnum, char *action) {
                        ical_send_a_reply(ird.cal, action);
                }
 
-               /* Now that we've processed this message, we don't need it
-                * anymore.  So delete it.  (NOTE we don't do this anymore.)
-               CtdlDeleteMessages(CC->room.QRname, &msgnum, 1, "");
+               /* We used to delete the invitation after handling it.
+                * We don't do that anymore, but here is the code that handled it:
+                * CtdlDeleteMessages(CC->room.QRname, &msgnum, 1, "");
                 */
 
                /* Free the memory we allocated and return a response. */
@@ -524,7 +476,7 @@ struct original_event_container {
  */
 void ical_locate_original_event(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-               void *cbuserdata) {
+               char *cbid, void *cbuserdata) {
 
        struct original_event_container *oec = NULL;
 
@@ -656,7 +608,7 @@ int ical_update_my_calendar_with_reply(icalcomponent *cal) {
        /*
         * Look in the EUID index for a message with
         * the Citadel EUID set to the value we're looking for.  Since
-        * Citadel always sets the message EUID to the vCalendar UID of
+        * Citadel always sets the message EUID to the iCalendar UID of
         * the event, this will work.
         */
        msgnum_being_replaced = locate_message_by_euid(uid, &CC->room);
@@ -698,7 +650,7 @@ int ical_update_my_calendar_with_reply(icalcomponent *cal) {
        ical_merge_attendee_reply(original_event, cal);
 
        /* Serialize it */
-       serialized_event = strdup(icalcomponent_as_ical_string(original_event));
+       serialized_event = icalcomponent_as_ical_string_r(original_event);
        icalcomponent_free(original_event);     /* Don't need this anymore. */
        if (serialized_event == NULL) return(2);
 
@@ -707,7 +659,7 @@ int ical_update_my_calendar_with_reply(icalcomponent *cal) {
        message_text = malloc(strlen(serialized_event) + SIZ);
        if (message_text != NULL) {
                sprintf(message_text,
-                       "Content-type: text/calendar charset=\"utf-8\"\r\n\r\n%s\r\n",
+                       "Content-type: text/calendar; charset=\"utf-8\"\r\n\r\n%s\r\n",
                        serialized_event
                );
 
@@ -725,7 +677,7 @@ int ical_update_my_calendar_with_reply(icalcomponent *cal) {
        
                if (msg != NULL) {
                        CIT_ICAL->avoid_sending_invitations = 1;
-                       CtdlSubmitMsg(msg, NULL, roomname);
+                       CtdlSubmitMsg(msg, NULL, roomname, QP_EADDR);
                        CtdlFreeMessage(msg);
                        CIT_ICAL->avoid_sending_invitations = 0;
                }
@@ -861,26 +813,22 @@ int ical_ctdl_is_overlap(
 
        /* First, check for all-day events */
        if (t1start.is_date) {
-               if (!icaltime_compare_date_only(t1start, t2start, 
-                                               icaltimezone_get_utc_timezone())) {
+               if (!icaltime_compare_date_only(t1start, t2start)) {
                        return(1);
                }
                if (!icaltime_is_null_time(t2end)) {
-                       if (!icaltime_compare_date_only(t1start, t2end, 
-                                                       icaltimezone_get_utc_timezone())) {
+                       if (!icaltime_compare_date_only(t1start, t2end)) {
                                return(1);
                        }
                }
        }
 
        if (t2start.is_date) {
-               if (!icaltime_compare_date_only(t2start, t1start,
-                                               icaltimezone_get_utc_timezone())) {
+               if (!icaltime_compare_date_only(t2start, t1start)) {
                        return(1);
                }
                if (!icaltime_is_null_time(t1end)) {
-                       if (!icaltime_compare_date_only(t2start, t1end, 
-                                                       icaltimezone_get_utc_timezone())) {
+                       if (!icaltime_compare_date_only(t2start, t1end)) {
                                return(1);
                        }
                }
@@ -904,87 +852,229 @@ int ical_ctdl_is_overlap(
 
 
 
+/* 
+ * Phase 6 of "hunt for conflicts"
+ * called by ical_conflicts_phase5()
+ *
+ * Now both the proposed and existing events have been boiled down to start and end times.
+ * Check for overlap and output any conflicts.
+ */
+void ical_conflicts_phase6(struct icaltimetype t1start,
+                       struct icaltimetype t1end,
+                       struct icaltimetype t2start,
+                       struct icaltimetype t2end,
+                       long existing_msgnum,
+                       char *conflict_event_uid,
+                       char *conflict_event_summary,
+                       char *compare_uid)
+{
+
+       /* debugging cruft */
+       //      time_t tt;
+       //      tt = icaltime_as_timet(t1start);
+       //      CtdlLogPrintf(CTDL_DEBUG, "PROPOSED START: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t1end);
+       //      CtdlLogPrintf(CTDL_DEBUG, "  PROPOSED END: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t2start);
+       //      CtdlLogPrintf(CTDL_DEBUG, "EXISTING START: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t2end);
+       //      CtdlLogPrintf(CTDL_DEBUG, "  EXISTING END: %s", ctime(&tt));
+
+       /* compare and output */
+
+       if (ical_ctdl_is_overlap(t1start, t1end, t2start, t2end)) {
+               cprintf("%ld||%s|%s|%d|\n",
+                       existing_msgnum,
+                       conflict_event_uid,
+                       conflict_event_summary,
+                       (       ((strlen(compare_uid)>0)
+                               &&(!strcasecmp(compare_uid,
+                               conflict_event_uid))) ? 1 : 0
+                       )
+               );
+       }
+
+}
+
+
+
 /*
- * Backend for ical_hunt_for_conflicts()
+ * Phase 5 of "hunt for conflicts"
+ * Called by ical_conflicts_phase4()
+ *
+ * We have the proposed event boiled down to start and end times.
+ * Now check it against an existing event. 
  */
-void ical_hunt_for_conflicts_backend(long msgnum, void *data) {
-       icalcomponent *cal;
-       struct CtdlMessage *msg = NULL;
-       struct ical_respond_data ird;
-       struct icaltimetype t1start, t1end, t2start, t2end;
-       icalproperty *p;
+void ical_conflicts_phase5(struct icaltimetype t1start,
+                       struct icaltimetype t1end,
+                       icalcomponent *existing_event,
+                       long existing_msgnum,
+                       char *compare_uid)
+{
        char conflict_event_uid[SIZ];
        char conflict_event_summary[SIZ];
-       char compare_uid[SIZ];
+       struct icaltimetype t2start, t2end;
+       icalproperty *p;
 
-       cal = (icalcomponent *)data;
-       strcpy(compare_uid, "");
+       /* recur variables */
+       icalproperty *rrule = NULL;
+       struct icalrecurrencetype recur;
+       icalrecur_iterator *ritr = NULL;
+       struct icaldurationtype dur;
+       int num_recur = 0;
+
+       /* initialization */
        strcpy(conflict_event_uid, "");
        strcpy(conflict_event_summary, "");
+       t2start = icaltime_null_time();
+       t2end = icaltime_null_time();
 
-       msg = CtdlFetchMessage(msgnum, 1);
-       if (msg == NULL) return;
-       memset(&ird, 0, sizeof ird);
-       strcpy(ird.desired_partnum, "_HUNT_");
-       mime_parser(msg->cm_fields['M'],
-               NULL,
-               *ical_locate_part,              /* callback function */
-               NULL, NULL,
-               (void *) &ird,                  /* user data */
-               0
-       );
-       CtdlFreeMessage(msg);
+       /* existing event stuff */
+       p = ical_ctdl_get_subprop(existing_event, ICAL_DTSTART_PROPERTY);
+       if (p == NULL) return;
+       if (p != NULL) t2start = icalproperty_get_dtstart(p);
 
-       if (ird.cal == NULL) return;
+       p = ical_ctdl_get_subprop(existing_event, ICAL_DTEND_PROPERTY);
+       if (p != NULL) {
+               t2end = icalproperty_get_dtend(p);
+               dur = icaltime_subtract(t2end, t2start);
+       }
+
+       rrule = ical_ctdl_get_subprop(existing_event, ICAL_RRULE_PROPERTY);
+       if (rrule) {
+               recur = icalproperty_get_rrule(rrule);
+               ritr = icalrecur_iterator_new(recur, t2start);
+               CtdlLogPrintf(CTDL_DEBUG, "Recurrence found: %s\n", icalrecurrencetype_as_string(&recur));
+       }
 
+       do {
+               p = ical_ctdl_get_subprop(existing_event, ICAL_UID_PROPERTY);
+               if (p != NULL) {
+                       strcpy(conflict_event_uid, icalproperty_get_comment(p));
+               }
+       
+               p = ical_ctdl_get_subprop(existing_event, ICAL_SUMMARY_PROPERTY);
+               if (p != NULL) {
+                       strcpy(conflict_event_summary, icalproperty_get_comment(p));
+               }
+       
+               ical_conflicts_phase6(t1start, t1end, t2start, t2end,
+                       existing_msgnum, conflict_event_uid, conflict_event_summary, compare_uid
+               );
+
+               if (rrule) {
+                       t2start = icalrecur_iterator_next(ritr);
+                       if (!icaltime_is_null_time(t2end)) {
+                               t2end = icaltime_add(t2start, dur);
+                       }
+                       ++num_recur;
+               }
+
+       } while ( (rrule) && (!icaltime_is_null_time(t2start)) && (num_recur < MAX_RECUR) );
+       icalrecur_iterator_free(ritr);
+       if (num_recur > 0) CtdlLogPrintf(CTDL_DEBUG, "Iterated over existing event %d times.\n", num_recur);
+}
+
+
+
+
+/*
+ * Phase 4 of "hunt for conflicts"
+ * Called by ical_hunt_for_conflicts_backend()
+ *
+ * At this point we've got it boiled down to two icalcomponent events in memory.
+ * If they conflict, output something to the client.
+ */
+void ical_conflicts_phase4(icalcomponent *proposed_event,
+               icalcomponent *existing_event,
+               long existing_msgnum)
+{
+       struct icaltimetype t1start, t1end;
        t1start = icaltime_null_time();
        t1end = icaltime_null_time();
-       t2start = icaltime_null_time();
-       t1end = icaltime_null_time();
+       icalproperty *p;
+       char compare_uid[SIZ];
 
-       /* Now compare cal to ird.cal */
-       p = ical_ctdl_get_subprop(ird.cal, ICAL_DTSTART_PROPERTY);
-       if (p == NULL) return;
-       if (p != NULL) t2start = icalproperty_get_dtstart(p);
-       
-       p = ical_ctdl_get_subprop(ird.cal, ICAL_DTEND_PROPERTY);
-       if (p != NULL) t2end = icalproperty_get_dtend(p);
+       /* recur variables */
+       icalproperty *rrule = NULL;
+       struct icalrecurrencetype recur;
+       icalrecur_iterator *ritr = NULL;
+       struct icaldurationtype dur;
+       int num_recur = 0;
 
-       p = ical_ctdl_get_subprop(cal, ICAL_DTSTART_PROPERTY);
+       /* initialization */
+       strcpy(compare_uid, "");
+
+       /* proposed event stuff */
+
+       p = ical_ctdl_get_subprop(proposed_event, ICAL_DTSTART_PROPERTY);
        if (p == NULL) return;
        if (p != NULL) t1start = icalproperty_get_dtstart(p);
        
-       p = ical_ctdl_get_subprop(cal, ICAL_DTEND_PROPERTY);
-       if (p != NULL) t1end = icalproperty_get_dtend(p);
-       
-       p = ical_ctdl_get_subprop(cal, ICAL_UID_PROPERTY);
+       p = ical_ctdl_get_subprop(proposed_event, ICAL_DTEND_PROPERTY);
        if (p != NULL) {
-               strcpy(compare_uid, icalproperty_get_comment(p));
+               t1end = icalproperty_get_dtend(p);
+               dur = icaltime_subtract(t1end, t1start);
        }
 
-       p = ical_ctdl_get_subprop(ird.cal, ICAL_UID_PROPERTY);
-       if (p != NULL) {
-               strcpy(conflict_event_uid, icalproperty_get_comment(p));
+       rrule = ical_ctdl_get_subprop(proposed_event, ICAL_RRULE_PROPERTY);
+       if (rrule) {
+               recur = icalproperty_get_rrule(rrule);
+               ritr = icalrecur_iterator_new(recur, t1start);
+               CtdlLogPrintf(CTDL_DEBUG, "Recurrence found: %s\n", icalrecurrencetype_as_string(&recur));
        }
 
-       p = ical_ctdl_get_subprop(ird.cal, ICAL_SUMMARY_PROPERTY);
+       p = ical_ctdl_get_subprop(proposed_event, ICAL_UID_PROPERTY);
        if (p != NULL) {
-               strcpy(conflict_event_summary, icalproperty_get_comment(p));
+               strcpy(compare_uid, icalproperty_get_comment(p));
        }
 
-       icalcomponent_free(ird.cal);
+       do {
+               ical_conflicts_phase5(t1start, t1end, existing_event, existing_msgnum, compare_uid);
 
-       if (ical_ctdl_is_overlap(t1start, t1end, t2start, t2end)) {
-               cprintf("%ld||%s|%s|%d|\n",
-                       msgnum,
-                       conflict_event_uid,
-                       conflict_event_summary,
-                       (       ((strlen(compare_uid)>0)
-                               &&(!strcasecmp(compare_uid,
-                               conflict_event_uid))) ? 1 : 0
-                       )
-               );
-       }
+               if (rrule) {
+                       t1start = icalrecur_iterator_next(ritr);
+                       if (!icaltime_is_null_time(t1end)) {
+                               t1end = icaltime_add(t1start, dur);
+                       }
+                       ++num_recur;
+               }
+
+       } while ( (rrule) && (!icaltime_is_null_time(t1start)) && (num_recur < MAX_RECUR) );
+       icalrecur_iterator_free(ritr);
+       if (num_recur > 0) CtdlLogPrintf(CTDL_DEBUG, "Iterated over proposed event %d times.\n", num_recur);
+}
+
+
+
+/*
+ * Phase 3 of "hunt for conflicts"
+ * Called by ical_hunt_for_conflicts()
+ */
+void ical_hunt_for_conflicts_backend(long msgnum, void *data) {
+       icalcomponent *proposed_event;
+       struct CtdlMessage *msg = NULL;
+       struct ical_respond_data ird;
+
+       proposed_event = (icalcomponent *)data;
+
+       msg = CtdlFetchMessage(msgnum, 1);
+       if (msg == NULL) return;
+       memset(&ird, 0, sizeof ird);
+       strcpy(ird.desired_partnum, "_HUNT_");
+       mime_parser(msg->cm_fields['M'],
+               NULL,
+               *ical_locate_part,              /* callback function */
+               NULL, NULL,
+               (void *) &ird,                  /* user data */
+               0
+       );
+       CtdlFreeMessage(msg);
+
+       if (ird.cal == NULL) return;
+
+       ical_conflicts_phase4(proposed_event, ird.cal, msgnum);
+       icalcomponent_free(ird.cal);
 }
 
 
@@ -992,7 +1082,7 @@ void ical_hunt_for_conflicts_backend(long msgnum, void *data) {
 /* 
  * Phase 2 of "hunt for conflicts" operation.
  * At this point we have a calendar object which represents the VEVENT that
- * we're considering adding to the calendar.  Now hunt through the user's
+ * is proposed for addition to the calendar.  Now hunt through the user's
  * calendar room, and output zero or more existing VEVENTs which conflict
  * with this one.
  */
@@ -1086,8 +1176,6 @@ void ical_add_to_freebusy(icalcomponent *fb, icalcomponent *cal) {
                return;
        }
 
-       ical_dezonify(cal);
-
        /* If this event is not opaque, the user isn't publishing it as
         * busy time, so don't bother doing anything else.
         */
@@ -1343,7 +1431,7 @@ void ical_freebusy(char *who) {
 
        /* Serialize it */
        CtdlLogPrintf(CTDL_DEBUG, "Serializing\n");
-       serialized_request = strdup(icalcomponent_as_ical_string(encaps));
+       serialized_request = icalcomponent_as_ical_string_r(encaps);
        icalcomponent_free(encaps);     /* Don't need this anymore. */
 
        cprintf("%d Here is the free/busy data:\n", LISTING_FOLLOWS);
@@ -1429,13 +1517,12 @@ void ical_getics(void)
        if ( (CC->room.QRdefaultview != VIEW_CALENDAR)
           &&(CC->room.QRdefaultview != VIEW_TASKS) ) {
                cprintf("%d Not a calendar room\n", ERROR+NOT_HERE);
-               return;         /* Not a vCalendar-centric room */
+               return;         /* Not an iCalendar-centric room */
        }
 
        encaps = icalcomponent_new_vcalendar();
        if (encaps == NULL) {
-               CtdlLogPrintf(CTDL_DEBUG, "Error at %s:%d - could not allocate component!\n",
-                       __FILE__, __LINE__);
+               CtdlLogPrintf(CTDL_DEBUG, "ERROR: could not allocate component!\n");
                cprintf("%d Could not allocate memory\n", ERROR+INTERNAL_ERROR);
                return;
        }
@@ -1459,12 +1546,11 @@ void ical_getics(void)
                (void *) encaps
        );
 
-       ser = strdup(icalcomponent_as_ical_string(encaps));
+       ser = icalcomponent_as_ical_string_r(encaps);
+       icalcomponent_free(encaps);                     /* Don't need this anymore. */
        client_write(ser, strlen(ser));
        free(ser);
        cprintf("\n000\n");
-       icalcomponent_free(encaps);     /* Don't need this anymore. */
-
 }
 
 
@@ -1481,7 +1567,7 @@ void ical_putics(void)
        if ( (CC->room.QRdefaultview != VIEW_CALENDAR)
           &&(CC->room.QRdefaultview != VIEW_TASKS) ) {
                cprintf("%d Not a calendar room\n", ERROR+NOT_HERE);
-               return;         /* Not a vCalendar-centric room */
+               return;         /* Not an iCalendar-centric room */
        }
 
        if (!CtdlDoIHavePermissionToDeleteMessagesFromThisRoom()) {
@@ -1497,7 +1583,6 @@ void ical_putics(void)
 
        cal = icalcomponent_new_from_string(calstream);
        free(calstream);
-       ical_dezonify(cal);
 
        /* We got our data stream -- now do something with it. */
 
@@ -1667,10 +1752,14 @@ void ical_create_room(void)
 
 
 /*
- * ical_send_out_invitations() is called by ical_saving_vevent() when it
- * finds a VEVENT.
+ * ical_send_out_invitations() is called by ical_saving_vevent() when it finds a VEVENT.
+ *
+ * top_level_cal is the highest available level calendar object.
+ * cal is the subcomponent containing the VEVENT.
+ *
+ * Note: if you change the encapsulation code here, change it in WebCit's ical_encapsulate_subcomponent()
  */
-void ical_send_out_invitations(icalcomponent *cal) {
+void ical_send_out_invitations(icalcomponent *top_level_cal, icalcomponent *cal) {
        icalcomponent *the_request = NULL;
        char *serialized_request = NULL;
        icalcomponent *encaps = NULL;
@@ -1684,6 +1773,13 @@ void ical_send_out_invitations(icalcomponent *cal) {
        char summary_string[SIZ];
        icalproperty *summary = NULL;
        size_t reqsize;
+       icalproperty *p;
+       struct icaltimetype t;
+       icaltimezone *attached_zones[5] = { NULL, NULL, NULL, NULL, NULL };
+       int i;
+       icaltimezone *z;
+       int num_zones_attached = 0;
+       int zone_already_attached;
 
        if (cal == NULL) {
                CtdlLogPrintf(CTDL_ERR, "ERROR: trying to reply to NULL event?\n");
@@ -1693,7 +1789,7 @@ void ical_send_out_invitations(icalcomponent *cal) {
 
        /* If this is a VCALENDAR component, look for a VEVENT subcomponent. */
        if (icalcomponent_isa(cal) == ICAL_VCALENDAR_COMPONENT) {
-               ical_send_out_invitations(
+               ical_send_out_invitations(top_level_cal,
                        icalcomponent_get_first_component(
                                cal, ICAL_VEVENT_COMPONENT
                        )
@@ -1753,8 +1849,7 @@ void ical_send_out_invitations(icalcomponent *cal) {
        /* Encapsulate the VEVENT component into a complete VCALENDAR */
        encaps = icalcomponent_new_vcalendar();
        if (encaps == NULL) {
-               CtdlLogPrintf(CTDL_DEBUG, "Error at %s:%d - could not allocate component!\n",
-                       __FILE__, __LINE__);
+               CtdlLogPrintf(CTDL_DEBUG, "ERROR: could not allocate component!\n");
                icalcomponent_free(the_request);
                return;
        }
@@ -1768,20 +1863,101 @@ void ical_send_out_invitations(icalcomponent *cal) {
        /* Set the method to REQUEST */
        icalcomponent_set_method(encaps, ICAL_METHOD_REQUEST);
 
-       /* Now make sure all of the DTSTART and DTEND properties are UTC. */
-       ical_dezonify(the_request);
+       /* Look for properties containing timezone parameters, to see if we need to attach VTIMEZONEs */
+       for (p = icalcomponent_get_first_property(the_request, ICAL_ANY_PROPERTY);
+            p != NULL;
+            p = icalcomponent_get_next_property(the_request, ICAL_ANY_PROPERTY))
+       {
+               if ( (icalproperty_isa(p) == ICAL_COMPLETED_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_CREATED_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DATEMAX_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DATEMIN_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DTEND_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DTSTAMP_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DTSTART_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_DUE_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_EXDATE_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_LASTMODIFIED_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_MAXDATE_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_MINDATE_PROPERTY)
+                 || (icalproperty_isa(p) == ICAL_RECURRENCEID_PROPERTY)
+               ) {
+                       t = icalproperty_get_dtstart(p);        // it's safe to use dtstart for all of them
+                       CtdlLogPrintf(CTDL_DEBUG, "Found an icaltimetype: %s\n",
+                               icaltime_as_ical_string(t)
+                       );
+
+                       /* First see if there's a timezone attached to the data structure itself */
+                       if (icaltime_is_utc(t)) {
+                               z = icaltimezone_get_utc_timezone();
+                       }
+                       else {
+                               z = icaltime_get_timezone(t);
+                       }
+                       if (z) CtdlLogPrintf(CTDL_DEBUG, "Timezone is present in data structure\n");
+
+                       /* If not, try to determine the tzid from the parameter using attached zones */
+                       if (!z) {
+                               z = icalcomponent_get_timezone(top_level_cal,
+                                       icalparameter_get_tzid(
+                                               icalproperty_get_first_parameter(p, ICAL_TZID_PARAMETER)
+                                       )
+                               );
+                               if (z) CtdlLogPrintf(CTDL_DEBUG, "Timezone was found in attached zones\n");
+                       }
 
-       /* Here we go: put the VEVENT into the VCALENDAR.  We now no longer
+                       /* Still no good?  Try our internal database */
+                       if (!z) {
+                               z = icaltimezone_get_builtin_timezone_from_tzid(
+                                       icalparameter_get_tzid(
+                                               icalproperty_get_first_parameter(p, ICAL_TZID_PARAMETER)
+                                       )
+                               );
+                               if (z) CtdlLogPrintf(CTDL_DEBUG, "Timezone was found in internal db\n");
+                       }
+
+                       if (z) {
+                               CtdlLogPrintf(CTDL_DEBUG, "Have valid timezone, need to attach it.\n");
+
+                               zone_already_attached = 0;
+                               for (i=0; i<5; ++i) {
+                                       if (z == attached_zones[i]) {
+                                               ++zone_already_attached;
+                                               CtdlLogPrintf(CTDL_DEBUG, "zone already attached!!\n");
+                                       }
+                               }
+                               if ((!zone_already_attached) && (num_zones_attached < 5)) {
+                                       CtdlLogPrintf(CTDL_DEBUG, "attach zone %d\n", num_zones_attached);
+                                       attached_zones[num_zones_attached++] = z;
+                               }
+
+                               icalproperty_set_parameter(p,
+                                       icalparameter_new_tzid(icaltimezone_get_tzid(z))
+                               );
+                       }
+               }
+       }
+
+       /* Encapsulate any timezones we need */
+       if (num_zones_attached > 0) for (i=0; i<num_zones_attached; ++i) {
+               icalcomponent *zc;
+               zc = icalcomponent_new_clone(icaltimezone_get_component(attached_zones[i]));
+               icalcomponent_add_component(encaps, zc);
+       }
+
+       /* Here we go: encapsulate the VEVENT into the VCALENDAR.  We now no longer
         * are responsible for "the_request"'s memory -- it will be freed
         * when we free "encaps".
         */
        icalcomponent_add_component(encaps, the_request);
 
        /* Serialize it */
-       serialized_request = strdup(icalcomponent_as_ical_string(encaps));
+       serialized_request = icalcomponent_as_ical_string_r(encaps);
        icalcomponent_free(encaps);     /* Don't need this anymore. */
        if (serialized_request == NULL) return;
 
+       CtdlLogPrintf(CTDL_DEBUG, "SENDING INVITATIONS:\n%s\n", serialized_request);
+
        reqsize = strlen(serialized_request) + SIZ;
        request_message_text = malloc(reqsize);
        if (request_message_text != NULL) {
@@ -1803,7 +1979,7 @@ void ical_send_out_invitations(icalcomponent *cal) {
        
                if (msg != NULL) {
                        valid = validate_recipients(attendees_string, NULL, 0);
-                       CtdlSubmitMsg(msg, valid, "");
+                       CtdlSubmitMsg(msg, valid, "", QP_EADDR);
                        CtdlFreeMessage(msg);
                        free_recipients(valid);
                }
@@ -1817,8 +1993,13 @@ void ical_send_out_invitations(icalcomponent *cal) {
  * and the user saving it is the organizer.  If so, send out invitations
  * to any listed attendees.
  *
+ * This function is recursive.  The caller can simply supply the same object
+ * as both arguments.  When it recurses it will alter the second argument
+ * while holding on to the top level object.  This allows us to go back and
+ * grab things like time zones which might be attached.
+ *
  */
-void ical_saving_vevent(icalcomponent *cal) {
+void ical_saving_vevent(icalcomponent *top_level_cal, icalcomponent *cal) {
        icalcomponent *c;
        icalproperty *organizer = NULL;
        char organizer_string[SIZ];
@@ -1856,7 +2037,7 @@ void ical_saving_vevent(icalcomponent *cal) {
                         * organizer, then send out invitations.
                         */
                        if (CtdlIsMe(organizer_string, sizeof organizer_string)) {
-                               ical_send_out_invitations(cal);
+                               ical_send_out_invitations(top_level_cal, cal);
                        }
                }
        }
@@ -1866,7 +2047,7 @@ void ical_saving_vevent(icalcomponent *cal) {
            (c != NULL);
            c = icalcomponent_get_next_component(cal, ICAL_ANY_COMPONENT)) {
                /* Recursively process subcomponent */
-               ical_saving_vevent(c);
+               ical_saving_vevent(top_level_cal, c);
        }
 
 }
@@ -1879,16 +2060,17 @@ void ical_saving_vevent(icalcomponent *cal) {
  * the summary of the event (becomes message subject),
  * and the start time (becomes message date/time).
  */
-void ical_ctdl_set_exclusive_msgid(char *name, char *filename, char *partnum,
+void ical_obj_beforesave_backend(char *name, char *filename, char *partnum,
                char *disp, void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        icalcomponent *cal, *nested_event, *nested_todo, *whole_cal;
        icalproperty *p;
-       struct icalmessagemod *imm;
-       char new_uid[SIZ];
+       char new_uid[256] = "";
+       char buf[1024] = "";
+       struct CtdlMessage *msg = (struct CtdlMessage *) cbuserdata;
 
-       imm = (struct icalmessagemod *)cbuserdata;
+       if (!msg) return;
 
        /* We're only interested in calendar data. */
        if (  (strcasecmp(cbtype, "text/calendar"))
@@ -1920,6 +2102,9 @@ void ical_ctdl_set_exclusive_msgid(char *name, char *filename, char *partnum,
                }
                
                if (cal != NULL) {
+
+                       /* Set the message EUID to the iCalendar UID */
+
                        p = ical_ctdl_get_subprop(cal, ICAL_UID_PROPERTY);
                        if (p == NULL) {
                                /* If there's no uid we must generate one */
@@ -1928,16 +2113,44 @@ void ical_ctdl_set_exclusive_msgid(char *name, char *filename, char *partnum,
                                p = ical_ctdl_get_subprop(cal, ICAL_UID_PROPERTY);
                        }
                        if (p != NULL) {
-                               strcpy(imm->uid, icalproperty_get_comment(p));
+                               safestrncpy(buf, icalproperty_get_comment(p), sizeof buf);
+                               if (!IsEmptyStr(buf)) {
+                                       if (msg->cm_fields['E'] != NULL) {
+                                               free(msg->cm_fields['E']);
+                                       }
+                                       msg->cm_fields['E'] = strdup(buf);
+                                       CtdlLogPrintf(CTDL_DEBUG, "Saving calendar UID <%s>\n", buf);
+                               }
                        }
+
+                       /* Set the message subject to the iCalendar summary */
+
                        p = ical_ctdl_get_subprop(cal, ICAL_SUMMARY_PROPERTY);
                        if (p != NULL) {
-                               strcpy(imm->subject, icalproperty_get_comment(p));
+                               safestrncpy(buf, icalproperty_get_comment(p), sizeof buf);
+                               if (!IsEmptyStr(buf)) {
+                                       if (msg->cm_fields['U'] != NULL) {
+                                               free(msg->cm_fields['U']);
+                                       }
+                                       msg->cm_fields['U'] = strdup(buf);
+                               }
                        }
+
+                       /* Set the message date/time to the iCalendar start time */
+
                        p = ical_ctdl_get_subprop(cal, ICAL_DTSTART_PROPERTY);
                        if (p != NULL) {
-                               imm->dtstart = icaltime_as_timet(icalproperty_get_dtstart(p));
+                               time_t idtstart;
+                               idtstart = icaltime_as_timet(icalproperty_get_dtstart(p));
+                               if (idtstart > 0) {
+                                       if (msg->cm_fields['T'] != NULL) {
+                                               free(msg->cm_fields['T']);
+                                       }
+                                       msg->cm_fields['T'] = strdup("000000000000000000");
+                                       sprintf(msg->cm_fields['T'], "%ld", idtstart);
+                               }
                        }
+
                }
                icalcomponent_free(cal);
                if (whole_cal != cal) {
@@ -1951,24 +2164,18 @@ void ical_ctdl_set_exclusive_msgid(char *name, char *filename, char *partnum,
 
 /*
  * See if we need to prevent the object from being saved (we don't allow
- * MIME types other than text/calendar in "calendar" or "tasks"  rooms).  Also,
- * when saving an event to the calendar, set the message's Citadel exclusive
- * message ID to the UID of the object.  This causes our replication checker to
- * automatically delete any existing instances of the same object.  (Isn't
- * that cool?)
+ * MIME types other than text/calendar in "calendar" or "tasks" rooms).
  *
- * We also set the message's Subject to the event summary, and the Date/time to
- * the event start time.
+ * If the message is being saved, we also set various message header fields
+ * using data found in the iCalendar object.
  */
 int ical_obj_beforesave(struct CtdlMessage *msg)
 {
-       struct icalmessagemod imm;
-
        /* First determine if this is a calendar or tasks room */
        if (  (CC->room.QRdefaultview != VIEW_CALENDAR)
           && (CC->room.QRdefaultview != VIEW_TASKS)
        ) {
-               return(0);              /* Not a vCalendar-centric room */
+               return(0);              /* Not an iCalendar-centric room */
        }
 
        /* It must be an RFC822 message! */
@@ -1981,38 +2188,15 @@ int ical_obj_beforesave(struct CtdlMessage *msg)
                return(1);              /* You tried to save a null message! */
        }
 
-       memset(&imm, 0, sizeof(struct icalmessagemod));
-       
        /* Do all of our lovely back-end parsing */
        mime_parser(msg->cm_fields['M'],
                NULL,
-               *ical_ctdl_set_exclusive_msgid,
+               *ical_obj_beforesave_backend,
                NULL, NULL,
-               (void *)&imm,
+               (void *)msg,
                0
        );
 
-       if (!IsEmptyStr(imm.uid)) {
-               if (msg->cm_fields['E'] != NULL) {
-                       free(msg->cm_fields['E']);
-               }
-               msg->cm_fields['E'] = strdup(imm.uid);
-               CtdlLogPrintf(CTDL_DEBUG, "Saving calendar UID <%s>\n", msg->cm_fields['E']);
-       }
-       if (!IsEmptyStr(imm.subject)) {
-               if (msg->cm_fields['U'] != NULL) {
-                       free(msg->cm_fields['U']);
-               }
-               msg->cm_fields['U'] = strdup(imm.subject);
-       }
-       if (imm.dtstart > 0) {
-               if (msg->cm_fields['T'] != NULL) {
-                       free(msg->cm_fields['T']);
-               }
-               msg->cm_fields['T'] = strdup("000000000000000000");
-               sprintf(msg->cm_fields['T'], "%ld", imm.dtstart);
-       }
-
        return(0);
 }
 
@@ -2022,7 +2206,7 @@ int ical_obj_beforesave(struct CtdlMessage *msg)
  */
 void ical_obj_aftersave_backend(char *name, char *filename, char *partnum,
                char *disp, void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        icalcomponent *cal;
 
@@ -2041,7 +2225,7 @@ void ical_obj_aftersave_backend(char *name, char *filename, char *partnum,
           || (!strcasecmp(cbtype, "application/ics")) ) {
                cal = icalcomponent_new_from_string(content);
                if (cal != NULL) {
-                       ical_saving_vevent(cal);
+                       ical_saving_vevent(cal, cal);
                        icalcomponent_free(cal);
                }
        }
@@ -2146,7 +2330,7 @@ void ical_fixed_output_backend(icalcomponent *cal,
 
 
 /*
- * Function to output vcalendar data as plain text.  Nobody uses MSG0
+ * Function to output iCalendar data as plain text.  Nobody uses MSG0
  * anymore, so really this is just so we expose the vCard data to the full
  * text indexer.
  */
@@ -2163,7 +2347,6 @@ void ical_fixed_output(char *ptr, int len) {
                return;
        }
 
-       ical_dezonify(cal);
        ical_fixed_output_backend(cal, 0);
 
        /* Free the memory we obtained from libical's constructor */
@@ -2184,6 +2367,14 @@ CTDL_MODULE_INIT(calendar)
 {
        if (!threading)
        {
+
+               /* Tell libical to return errors instead of aborting if it gets bad data */
+               icalerror_errors_are_fatal = 0;
+
+               /* Use our own application prefix in tzid's generated from system tzdata */
+               icaltimezone_set_tzid_prefix("/citadel.org/");
+
+               /* Initialize our hook functions */
                CtdlRegisterMessageHook(ical_obj_beforesave, EVT_BEFORESAVE);
                CtdlRegisterMessageHook(ical_obj_aftersave, EVT_AFTERSAVE);
                CtdlRegisterSessionHook(ical_create_room, EVT_LOGIN);
@@ -2198,4 +2389,3 @@ CTDL_MODULE_INIT(calendar)
        /* return our Subversion id for the Log */
        return "$Id$";
 }
-