]> code.citadel.org Git - citadel.git/blobdiff - citadel/modules/calendar/serv_calendar.c
Back end calendar handlers in citserver no longer convert
[citadel.git] / citadel / modules / calendar / serv_calendar.c
index d8f02831cc673768a252325ba15a5323433a93c7..775ab5f97b74acf42c5123faf721a44f04fe1e2d 100644 (file)
@@ -19,7 +19,7 @@
 #ifdef HAVE_STRINGS_H
 #include <strings.h>
 #endif
-#include <ical.h>
+#include <libical/ical.h>
 #include <libcitadel.h>
 #include "citadel.h"
 #include "server.h"
@@ -87,11 +87,6 @@ icalcomponent *ical_encapsulate_subcomponent(icalcomponent *subcomp) {
        /* Encapsulate the subcomponent inside */
        icalcomponent_add_component(encaps, subcomp);
 
-       /* Convert all timestamps to UTC so we don't have to deal with
-        * stupid VTIMEZONE crap.
-        */
-       ical_dezonify(encaps);
-
        /* Return the object we just created. */
        return(encaps);
 }
@@ -124,7 +119,7 @@ void ical_write_to_cal(struct ctdluser *u, icalcomponent *cal) {
                return;
        }
 
-       ser = icalcomponent_as_ical_string(cal);
+       ser = icalcomponent_as_ical_string_r(cal);
        if (ser == NULL) return;
 
        /* If the caller supplied a user, write to that user's default calendar room */
@@ -162,7 +157,7 @@ void ical_write_to_cal(struct ctdluser *u, icalcomponent *cal) {
        }
 
        /* In either case, now we can free the serialized calendar object */
-//     free(ser);
+       free(ser);
 }
 
 
@@ -315,7 +310,7 @@ void ical_send_a_reply(icalcomponent *request, char *action) {
        }
 
        /* Now generate the reply message and send it out. */
-       serialized_reply = strdup(icalcomponent_as_ical_string(the_reply));
+       serialized_reply = icalcomponent_as_ical_string_r(the_reply);
        icalcomponent_free(the_reply);  /* don't need this anymore */
        if (serialized_reply == NULL) return;
 
@@ -355,7 +350,7 @@ void ical_send_a_reply(icalcomponent *request, char *action) {
  */
 void ical_locate_part(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-               void *cbuserdata) {
+               char *cbid, void *cbuserdata) {
 
        struct ical_respond_data *ird = NULL;
 
@@ -382,9 +377,6 @@ void ical_locate_part(char *name, char *filename, char *partnum, char *disp,
        }
 
        ird->cal = icalcomponent_new_from_string(content);
-       if (ird->cal != NULL) {
-               ical_dezonify(ird->cal);
-       }
 }
 
 
@@ -514,7 +506,7 @@ struct original_event_container {
  */
 void ical_locate_original_event(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-               void *cbuserdata) {
+               char *cbid, void *cbuserdata) {
 
        struct original_event_container *oec = NULL;
 
@@ -688,7 +680,7 @@ int ical_update_my_calendar_with_reply(icalcomponent *cal) {
        ical_merge_attendee_reply(original_event, cal);
 
        /* Serialize it */
-       serialized_event = strdup(icalcomponent_as_ical_string(original_event));
+       serialized_event = icalcomponent_as_ical_string_r(original_event);
        icalcomponent_free(original_event);     /* Don't need this anymore. */
        if (serialized_event == NULL) return(2);
 
@@ -908,15 +900,15 @@ void ical_conflicts_phase6(struct icaltimetype t1start,
 {
 
        /* debugging cruft */
-       time_t tt;
-       tt = icaltime_as_timet(t1start);
-       CtdlLogPrintf(CTDL_DEBUG, "PROPOSED START: %s", ctime(&tt));
-       tt = icaltime_as_timet(t1end);
-       CtdlLogPrintf(CTDL_DEBUG, "  PROPOSED END: %s", ctime(&tt));
-       tt = icaltime_as_timet(t2start);
-       CtdlLogPrintf(CTDL_DEBUG, "EXISTING START: %s", ctime(&tt));
-       tt = icaltime_as_timet(t2end);
-       CtdlLogPrintf(CTDL_DEBUG, "  EXISTING END: %s", ctime(&tt));
+       //      time_t tt;
+       //      tt = icaltime_as_timet(t1start);
+       //      CtdlLogPrintf(CTDL_DEBUG, "PROPOSED START: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t1end);
+       //      CtdlLogPrintf(CTDL_DEBUG, "  PROPOSED END: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t2start);
+       //      CtdlLogPrintf(CTDL_DEBUG, "EXISTING START: %s", ctime(&tt));
+       //      tt = icaltime_as_timet(t2end);
+       //      CtdlLogPrintf(CTDL_DEBUG, "  EXISTING END: %s", ctime(&tt));
 
        /* compare and output */
 
@@ -930,10 +922,6 @@ void ical_conflicts_phase6(struct icaltimetype t1start,
                                conflict_event_uid))) ? 1 : 0
                        )
                );
-               CtdlLogPrintf(CTDL_DEBUG, "  --- CONFLICT --- \n");
-       }
-       else {
-               CtdlLogPrintf(CTDL_DEBUG, "  --- no conflict --- \n");
        }
 
 }
@@ -958,38 +946,63 @@ void ical_conflicts_phase5(struct icaltimetype t1start,
        struct icaltimetype t2start, t2end;
        icalproperty *p;
 
-       /* initialization */
+       /* recur variables */
+       icalproperty *rrule = NULL;
+       struct icalrecurrencetype recur;
+       icalrecur_iterator *ritr = NULL;
+       struct icaldurationtype dur;
+       int num_recur = 0;
 
+       /* initialization */
        strcpy(conflict_event_uid, "");
        strcpy(conflict_event_summary, "");
        t2start = icaltime_null_time();
        t2end = icaltime_null_time();
 
-
        /* existing event stuff */
-
        p = ical_ctdl_get_subprop(existing_event, ICAL_DTSTART_PROPERTY);
        if (p == NULL) return;
        if (p != NULL) t2start = icalproperty_get_dtstart(p);
-       
-       p = ical_ctdl_get_subprop(existing_event, ICAL_DTEND_PROPERTY);
-       if (p != NULL) t2end = icalproperty_get_dtend(p);
 
-       p = ical_ctdl_get_subprop(existing_event, ICAL_UID_PROPERTY);
+       p = ical_ctdl_get_subprop(existing_event, ICAL_DTEND_PROPERTY);
        if (p != NULL) {
-               strcpy(conflict_event_uid, icalproperty_get_comment(p));
+               t2end = icalproperty_get_dtend(p);
+               dur = icaltime_subtract(t2end, t2start);
        }
 
-       p = ical_ctdl_get_subprop(existing_event, ICAL_SUMMARY_PROPERTY);
-       if (p != NULL) {
-               strcpy(conflict_event_summary, icalproperty_get_comment(p));
+       rrule = ical_ctdl_get_subprop(existing_event, ICAL_RRULE_PROPERTY);
+       if (rrule) {
+               recur = icalproperty_get_rrule(rrule);
+               ritr = icalrecur_iterator_new(recur, t2start);
+               CtdlLogPrintf(CTDL_DEBUG, "Recurrence found: %s\n", icalrecurrencetype_as_string(&recur));
        }
 
+       do {
+               p = ical_ctdl_get_subprop(existing_event, ICAL_UID_PROPERTY);
+               if (p != NULL) {
+                       strcpy(conflict_event_uid, icalproperty_get_comment(p));
+               }
+       
+               p = ical_ctdl_get_subprop(existing_event, ICAL_SUMMARY_PROPERTY);
+               if (p != NULL) {
+                       strcpy(conflict_event_summary, icalproperty_get_comment(p));
+               }
+       
+               ical_conflicts_phase6(t1start, t1end, t2start, t2end,
+                       existing_msgnum, conflict_event_uid, conflict_event_summary, compare_uid
+               );
 
-       ical_conflicts_phase6(t1start, t1end, t2start, t2end,
-                               existing_msgnum, conflict_event_uid, conflict_event_summary, compare_uid
-       );
+               if (rrule) {
+                       t2start = icalrecur_iterator_next(ritr);
+                       if (!icaltime_is_null_time(t2end)) {
+                               t2end = icaltime_add(t2start, dur);
+                       }
+                       ++num_recur;
+               }
 
+       } while ( (rrule) && (!icaltime_is_null_time(t2start)) && (num_recur < MAX_RECUR) );
+       icalrecur_iterator_free(ritr);
+       if (num_recur > 0) CtdlLogPrintf(CTDL_DEBUG, "Iterated over existing event %d times.\n", num_recur);
 }
 
 
@@ -1012,12 +1025,16 @@ void ical_conflicts_phase4(icalcomponent *proposed_event,
        icalproperty *p;
        char compare_uid[SIZ];
 
+       /* recur variables */
+       icalproperty *rrule = NULL;
+       struct icalrecurrencetype recur;
+       icalrecur_iterator *ritr = NULL;
+       struct icaldurationtype dur;
+       int num_recur = 0;
 
        /* initialization */
-
        strcpy(compare_uid, "");
 
-
        /* proposed event stuff */
 
        p = ical_ctdl_get_subprop(proposed_event, ICAL_DTSTART_PROPERTY);
@@ -1025,14 +1042,37 @@ void ical_conflicts_phase4(icalcomponent *proposed_event,
        if (p != NULL) t1start = icalproperty_get_dtstart(p);
        
        p = ical_ctdl_get_subprop(proposed_event, ICAL_DTEND_PROPERTY);
-       if (p != NULL) t1end = icalproperty_get_dtend(p);
-       
+       if (p != NULL) {
+               t1end = icalproperty_get_dtend(p);
+               dur = icaltime_subtract(t1end, t1start);
+       }
+
+       rrule = ical_ctdl_get_subprop(proposed_event, ICAL_RRULE_PROPERTY);
+       if (rrule) {
+               recur = icalproperty_get_rrule(rrule);
+               ritr = icalrecur_iterator_new(recur, t1start);
+               CtdlLogPrintf(CTDL_DEBUG, "Recurrence found: %s\n", icalrecurrencetype_as_string(&recur));
+       }
+
        p = ical_ctdl_get_subprop(proposed_event, ICAL_UID_PROPERTY);
        if (p != NULL) {
                strcpy(compare_uid, icalproperty_get_comment(p));
        }
 
-       ical_conflicts_phase5(t1start, t1end, existing_event, existing_msgnum, compare_uid);
+       do {
+               ical_conflicts_phase5(t1start, t1end, existing_event, existing_msgnum, compare_uid);
+
+               if (rrule) {
+                       t1start = icalrecur_iterator_next(ritr);
+                       if (!icaltime_is_null_time(t1end)) {
+                               t1end = icaltime_add(t1start, dur);
+                       }
+                       ++num_recur;
+               }
+
+       } while ( (rrule) && (!icaltime_is_null_time(t1start)) && (num_recur < MAX_RECUR) );
+       icalrecur_iterator_free(ritr);
+       if (num_recur > 0) CtdlLogPrintf(CTDL_DEBUG, "Iterated over proposed event %d times.\n", num_recur);
 }
 
 
@@ -1166,8 +1206,6 @@ void ical_add_to_freebusy(icalcomponent *fb, icalcomponent *cal) {
                return;
        }
 
-       ical_dezonify(cal);
-
        /* If this event is not opaque, the user isn't publishing it as
         * busy time, so don't bother doing anything else.
         */
@@ -1423,7 +1461,7 @@ void ical_freebusy(char *who) {
 
        /* Serialize it */
        CtdlLogPrintf(CTDL_DEBUG, "Serializing\n");
-       serialized_request = strdup(icalcomponent_as_ical_string(encaps));
+       serialized_request = icalcomponent_as_ical_string_r(encaps);
        icalcomponent_free(encaps);     /* Don't need this anymore. */
 
        cprintf("%d Here is the free/busy data:\n", LISTING_FOLLOWS);
@@ -1539,7 +1577,7 @@ void ical_getics(void)
                (void *) encaps
        );
 
-       ser = strdup(icalcomponent_as_ical_string(encaps));
+       ser = icalcomponent_as_ical_string_r(encaps);
        client_write(ser, strlen(ser));
        free(ser);
        cprintf("\n000\n");
@@ -1577,7 +1615,6 @@ void ical_putics(void)
 
        cal = icalcomponent_new_from_string(calstream);
        free(calstream);
-       ical_dezonify(cal);
 
        /* We got our data stream -- now do something with it. */
 
@@ -1848,9 +1885,6 @@ void ical_send_out_invitations(icalcomponent *cal) {
        /* Set the method to REQUEST */
        icalcomponent_set_method(encaps, ICAL_METHOD_REQUEST);
 
-       /* Now make sure all of the DTSTART and DTEND properties are UTC. */
-       ical_dezonify(the_request);
-
        /* Here we go: put the VEVENT into the VCALENDAR.  We now no longer
         * are responsible for "the_request"'s memory -- it will be freed
         * when we free "encaps".
@@ -1858,7 +1892,7 @@ void ical_send_out_invitations(icalcomponent *cal) {
        icalcomponent_add_component(encaps, the_request);
 
        /* Serialize it */
-       serialized_request = strdup(icalcomponent_as_ical_string(encaps));
+       serialized_request = icalcomponent_as_ical_string_r(encaps);
        icalcomponent_free(encaps);     /* Don't need this anymore. */
        if (serialized_request == NULL) return;
 
@@ -1961,7 +1995,7 @@ void ical_saving_vevent(icalcomponent *cal) {
  */
 void ical_obj_beforesave_backend(char *name, char *filename, char *partnum,
                char *disp, void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        icalcomponent *cal, *nested_event, *nested_todo, *whole_cal;
        icalproperty *p;
@@ -2105,7 +2139,7 @@ int ical_obj_beforesave(struct CtdlMessage *msg)
  */
 void ical_obj_aftersave_backend(char *name, char *filename, char *partnum,
                char *disp, void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        icalcomponent *cal;
 
@@ -2246,7 +2280,6 @@ void ical_fixed_output(char *ptr, int len) {
                return;
        }
 
-       ical_dezonify(cal);
        ical_fixed_output_backend(cal, 0);
 
        /* Free the memory we obtained from libical's constructor */
@@ -2267,6 +2300,11 @@ CTDL_MODULE_INIT(calendar)
 {
        if (!threading)
        {
+
+               /* Tell libical to return errors instead of aborting if it gets bad data */
+               icalerror_errors_are_fatal = 0;
+
+               /* Initialize our hook functions */
                CtdlRegisterMessageHook(ical_obj_beforesave, EVT_BEFORESAVE);
                CtdlRegisterMessageHook(ical_obj_aftersave, EVT_AFTERSAVE);
                CtdlRegisterSessionHook(ical_create_room, EVT_LOGIN);