* make uid fetch and friends dynamic in size
[citadel.git] / citadel / modules / imap / imap_fetch.c
index a311aa1ece44444f2c2b3845a50abce601150237..5b80dd97431251c1eb5c48defb6fa6e30f2806d9 100644 (file)
@@ -4,6 +4,21 @@
  * Implements the FETCH command in IMAP.
  * This is a good example of the protocol's gratuitous complexity.
  *
+ * Copyright (c) 2001-2009 by the citadel.org team
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
 
 #include "citserver.h"
 #include "support.h"
 #include "config.h"
-#include "room_ops.h"
 #include "user_ops.h"
 #include "policy.h"
 #include "database.h"
 #include "msgbase.h"
 #include "internet_addressing.h"
-#include "serv_imap.h"
 #include "imap_tools.h"
+#include "serv_imap.h"
 #include "imap_fetch.h"
 #include "genstamp.h"
 #include "ctdl_module.h"
@@ -87,6 +101,7 @@ void imap_fetch_flags(int seq) {
        cprintf(")");
 }
 
+
 void imap_fetch_internaldate(struct CtdlMessage *msg) {
        char buf[SIZ];
        time_t msgdate;
@@ -113,9 +128,9 @@ void imap_fetch_internaldate(struct CtdlMessage *msg) {
  *     "RFC822.SIZE"   size of translated message
  *     "RFC822.TEXT"   body only (without leading blank line)
  */
-void imap_fetch_rfc822(long msgnum, char *whichfmt) {
+void imap_fetch_rfc822(long msgnum, const char *whichfmt) {
        char buf[SIZ];
-       char *ptr = NULL;
+       const char *ptr = NULL;
        size_t headers_size, text_size, total_size;
        size_t bytes_to_send = 0;
        struct MetaData smi;
@@ -175,7 +190,8 @@ void imap_fetch_rfc822(long msgnum, char *whichfmt) {
                CC->redirect_alloc = SIZ;
                CtdlOutputMsg(msgnum, MT_RFC822,
                        (need_body ? HEADERS_ALL : HEADERS_FAST),
-                             0, 1, NULL, 0);
+                       0, 1, NULL, SUPPRESS_ENV_TO
+               );
                if (!need_body) cprintf("\r\n");        /* extra trailing newline */
                IMAP->cached_rfc822_data = CC->redirect_buffer;
                IMAP->cached_rfc822_len = CC->redirect_len;
@@ -320,25 +336,25 @@ void imap_output_envelope_from(struct CtdlMessage *msg) {
 
        /* For everything else, we do stuff. */
        cprintf("((");                          /* open double-parens */
-       imap_strout(msg->cm_fields['A']);       /* personal name */
+       plain_imap_strout(msg->cm_fields['A']); /* personal name */
        cprintf(" NIL ");                       /* source route (not used) */
 
 
        if (msg->cm_fields['F'] != NULL) {
                process_rfc822_addr(msg->cm_fields['F'], user, node, name);
-               imap_strout(user);              /* mailbox name (user id) */
+               plain_imap_strout(user);                /* mailbox name (user id) */
                cprintf(" ");
                if (!strcasecmp(node, config.c_nodename)) {
-                       imap_strout(config.c_fqdn);
+                       plain_imap_strout(config.c_fqdn);
                }
                else {
-                       imap_strout(node);              /* host name */
+                       plain_imap_strout(node);                /* host name */
                }
        }
        else {
-               imap_strout(msg->cm_fields['A']); /* mailbox name (user id) */
+               plain_imap_strout(msg->cm_fields['A']); /* mailbox name (user id) */
                cprintf(" ");
-               imap_strout(msg->cm_fields['N']);       /* host name */
+               plain_imap_strout(msg->cm_fields['N']); /* host name */
        }
        
        cprintf(")) ");                         /* close double-parens */
@@ -381,11 +397,11 @@ void imap_output_envelope_addr(char *addr) {
                striplt(individual_addr);
                process_rfc822_addr(individual_addr, user, node, name);
                cprintf("(");
-               imap_strout(name);
+               plain_imap_strout(name);
                cprintf(" NIL ");
-               imap_strout(user);
+               plain_imap_strout(user);
                cprintf(" ");
-               imap_strout(node);
+               plain_imap_strout(node);
                cprintf(")");
                if (i < (num_addrs-1)) cprintf(" ");
        }
@@ -425,11 +441,11 @@ void imap_fetch_envelope(struct CtdlMessage *msg) {
        cprintf("ENVELOPE (");
 
        /* Date */
-       imap_strout(datestringbuf);
+       plain_imap_strout(datestringbuf);
        cprintf(" ");
 
        /* Subject */
-       imap_strout(msg->cm_fields['U']);
+       plain_imap_strout(msg->cm_fields['U']);
        cprintf(" ");
 
        /* From */
@@ -476,12 +492,12 @@ void imap_fetch_envelope(struct CtdlMessage *msg) {
 
        /* In-reply-to */
        fieldptr = rfc822_fetch_field(msg->cm_fields['M'], "In-reply-to");
-       imap_strout(fieldptr);
+       plain_imap_strout(fieldptr);
        cprintf(" ");
        if (fieldptr != NULL) free(fieldptr);
 
        /* message ID */
-       imap_strout(msg->cm_fields['I']);
+       plain_imap_strout(msg->cm_fields['I']);
 
        cprintf(")");
 }
@@ -502,7 +518,7 @@ void imap_strip_headers(char *section) {
        char *boiled_headers = NULL;
        int ok = 0;
        int done_headers = 0;
-       char *ptr = NULL;
+       const char *ptr = NULL;
 
        if (CC->redirect_buffer == NULL) return;
 
@@ -523,7 +539,7 @@ void imap_strip_headers(char *section) {
                        break;
                }
        }
-       num_parms = imap_parameterize(parms, which_fields);
+       num_parms = old_imap_parameterize(parms, which_fields);
 
        boiled_headers = malloc(CC->redirect_alloc);
        strcpy(boiled_headers, "");
@@ -574,7 +590,7 @@ void imap_strip_headers(char *section) {
 /*
  * Implements the BODY and BODY.PEEK fetch items
  */
-void imap_fetch_body(long msgnum, char *item, int is_peek) {
+void imap_fetch_body(long msgnum, const char *item, int is_peek) {
        struct CtdlMessage *msg = NULL;
        char section[SIZ];
        char partial[SIZ];
@@ -591,7 +607,8 @@ void imap_fetch_body(long msgnum, char *item, int is_peek) {
        }
        CtdlLogPrintf(CTDL_DEBUG, "Section is: %s%s\n", 
                section, 
-               IsEmptyStr(section) ? "(empty)" : "");
+               IsEmptyStr(section) ? "(empty)" : ""
+       );
 
        /* Burn the cache if we don't have the same section of the 
         * same message again.
@@ -640,11 +657,11 @@ void imap_fetch_body(long msgnum, char *item, int is_peek) {
        }
 
        else if ( (!strcmp(section, "1")) && (msg->cm_format_type != 4) ) {
-               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_NONE, 0, 1, 0);
+               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_NONE, 0, 1, SUPPRESS_ENV_TO);
        }
 
        else if (!strcmp(section, "")) {
-               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ALL, 0, 1, 0);
+               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ALL, 0, 1, SUPPRESS_ENV_TO);
        }
 
        /*
@@ -656,7 +673,7 @@ void imap_fetch_body(long msgnum, char *item, int is_peek) {
                 * IMAP library and this broke Mail.App and iPhone Mail, so we had to change it
                 * to HEADERS_ONLY so the trendy hipsters with their iPhones can read mail.
                 */
-               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ONLY, 0, 1, 0);
+               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ONLY, 0, 1, SUPPRESS_ENV_TO);
                imap_strip_headers(section);
        }
 
@@ -664,7 +681,7 @@ void imap_fetch_body(long msgnum, char *item, int is_peek) {
         * Strip it down if the client asked for everything _except_ headers.
         */
        else if (!strncasecmp(section, "TEXT", 4)) {
-               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_NONE, 0, 1, 0);
+               CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_NONE, 0, 1, SUPPRESS_ENV_TO);
        }
 
        /*
@@ -744,7 +761,7 @@ void imap_fetch_bodystructure_post(
 
        /* disposition */
        extract_token(subtype, cbtype, 1, '/', sizeof subtype);
-       imap_strout(subtype);
+       plain_imap_strout(subtype);
 
        /* body language */
        /* cprintf(" NIL"); We thought we needed this at one point, but maybe we don't... */
@@ -782,9 +799,9 @@ void imap_fetch_bodystructure_part(
        }
 
        cprintf("(");
-       imap_strout(cbmaintype);                                        /* body type */
+       plain_imap_strout(cbmaintype);                                  /* body type */
        cprintf(" ");
-       imap_strout(cbsubtype);                                         /* body subtype */
+       plain_imap_strout(cbsubtype);                                           /* body subtype */
        cprintf(" ");
 
        cprintf("(");                                                   /* begin body parameter list */
@@ -795,19 +812,19 @@ void imap_fetch_bodystructure_part(
         */
        if (name != NULL) if (!IsEmptyStr(name)) {
                cprintf("\"NAME\" ");
-               imap_strout(name);
+               plain_imap_strout(name);
                cprintf(" ");
        }
 
        cprintf("\"CHARSET\" ");
        if (cbcharset == NULL) {
-               imap_strout("US-ASCII");
+               plain_imap_strout("US-ASCII");
        }
        else if (cbcharset[0] == 0) {
-               imap_strout("US-ASCII");
+               plain_imap_strout("US-ASCII");
        }
        else {
-               imap_strout(cbcharset);
+               plain_imap_strout(cbcharset);
        }
        cprintf(") ");                                                  /* end body parameter list */
 
@@ -816,10 +833,10 @@ void imap_fetch_bodystructure_part(
 
        if (encoding != NULL) if (encoding[0] != 0)  have_encoding = 1;
        if (have_encoding) {
-               imap_strout(encoding);
+               plain_imap_strout(encoding);
        }
        else {
-               imap_strout("7BIT");
+               plain_imap_strout("7BIT");
        }
        cprintf(" ");
 
@@ -858,10 +875,10 @@ void imap_fetch_bodystructure_part(
        }
        else {
                cprintf("(");
-               imap_strout(disp);
+               plain_imap_strout(disp);
                if (filename != NULL) if (!IsEmptyStr(filename)) {
                        cprintf(" (\"FILENAME\" ");
-                       imap_strout(filename);
+                       plain_imap_strout(filename);
                        cprintf(")");
                }
                cprintf(")");
@@ -877,14 +894,15 @@ void imap_fetch_bodystructure_part(
  * Spew the BODYSTRUCTURE data for a message.
  *
  */
-void imap_fetch_bodystructure (long msgnum, char *item,
+void imap_fetch_bodystructure (long msgnum, const char *item,
                struct CtdlMessage *msg) {
-       char *rfc822 = NULL;
-       char *rfc822_body = NULL;
+       const char *rfc822 = NULL;
+       const char *rfc822_body = NULL;
        size_t rfc822_len;
        size_t rfc822_headers_len;
        size_t rfc822_body_len;
-       char *ptr = NULL;
+       const char *ptr = NULL;
+       char *pch;
        char buf[SIZ];
        int lines = 0;
 
@@ -908,8 +926,8 @@ void imap_fetch_bodystructure (long msgnum, char *item,
                CC->redirect_buffer = malloc(SIZ);
                CC->redirect_len = 0;
                CC->redirect_alloc = SIZ;
-               CtdlOutputPreLoadedMsg(msg, MT_RFC822, 0, 0, 1, 0);
-               rfc822 = CC->redirect_buffer;
+               CtdlOutputPreLoadedMsg(msg, MT_RFC822, 0, 0, 1, SUPPRESS_ENV_TO);
+               rfc822 = pch = CC->redirect_buffer;
                rfc822_len = CC->redirect_len;
                CC->redirect_buffer = NULL;
                CC->redirect_len = 0;
@@ -926,7 +944,7 @@ void imap_fetch_bodystructure (long msgnum, char *item,
 
                rfc822_headers_len = rfc822_body - rfc822;
                rfc822_body_len = rfc822_len - rfc822_headers_len;
-               free(rfc822);
+               free(pch);
 
                cprintf("BODYSTRUCTURE (\"TEXT\" \"PLAIN\" "
                        "(\"CHARSET\" \"US-ASCII\") NIL NIL "
@@ -951,82 +969,83 @@ void imap_fetch_bodystructure (long msgnum, char *item,
  * imap_do_fetch() calls imap_do_fetch_msg() to output the data of an
  * individual message, once it has been selected for output.
  */
-void imap_do_fetch_msg(int seq, int num_items, char **itemlist) {
+void imap_do_fetch_msg(int seq, citimap_command *Cmd) {
        int i;
+       citimap *Imap = IMAP;
        struct CtdlMessage *msg = NULL;
        int body_loaded = 0;
 
        /* Don't attempt to fetch bogus messages or UID's */
        if (seq < 1) return;
-       if (IMAP->msgids[seq-1] < 1L) return;
+       if (Imap->msgids[seq-1] < 1L) return;
 
        buffer_output();
        cprintf("* %d FETCH (", seq);
 
-       for (i=0; i<num_items; ++i) {
+       for (i=0; i<Cmd->num_parms; ++i) {
 
                /* Fetchable without going to the message store at all */
-               if (!strcasecmp(itemlist[i], "UID")) {
+               if (!strcasecmp(Cmd->Params[i].Key, "UID")) {
                        imap_fetch_uid(seq);
                }
-               else if (!strcasecmp(itemlist[i], "FLAGS")) {
+               else if (!strcasecmp(Cmd->Params[i].Key, "FLAGS")) {
                        imap_fetch_flags(seq-1);
                }
 
                /* Potentially fetchable from cache, if the client requests
                 * stuff from the same message several times in a row.
                 */
-               else if (!strcasecmp(itemlist[i], "RFC822")) {
-                       imap_fetch_rfc822(IMAP->msgids[seq-1], itemlist[i]);
+               else if (!strcasecmp(Cmd->Params[i].Key, "RFC822")) {
+                       imap_fetch_rfc822(Imap->msgids[seq-1], Cmd->Params[i].Key);
                }
-               else if (!strcasecmp(itemlist[i], "RFC822.HEADER")) {
-                       imap_fetch_rfc822(IMAP->msgids[seq-1], itemlist[i]);
+               else if (!strcasecmp(Cmd->Params[i].Key, "RFC822.HEADER")) {
+                       imap_fetch_rfc822(Imap->msgids[seq-1], Cmd->Params[i].Key);
                }
-               else if (!strcasecmp(itemlist[i], "RFC822.SIZE")) {
-                       imap_fetch_rfc822(IMAP->msgids[seq-1], itemlist[i]);
+               else if (!strcasecmp(Cmd->Params[i].Key, "RFC822.SIZE")) {
+                       imap_fetch_rfc822(Imap->msgids[seq-1], Cmd->Params[i].Key);
                }
-               else if (!strcasecmp(itemlist[i], "RFC822.TEXT")) {
-                       imap_fetch_rfc822(IMAP->msgids[seq-1], itemlist[i]);
+               else if (!strcasecmp(Cmd->Params[i].Key, "RFC822.TEXT")) {
+                       imap_fetch_rfc822(Imap->msgids[seq-1], Cmd->Params[i].Key);
                }
 
                /* BODY fetches do their own fetching and caching too. */
-               else if (!strncasecmp(itemlist[i], "BODY[", 5)) {
-                       imap_fetch_body(IMAP->msgids[seq-1], itemlist[i], 0);
+               else if (!strncasecmp(Cmd->Params[i].Key, "BODY[", 5)) {
+                       imap_fetch_body(Imap->msgids[seq-1], Cmd->Params[i].Key, 0);
                }
-               else if (!strncasecmp(itemlist[i], "BODY.PEEK[", 10)) {
-                       imap_fetch_body(IMAP->msgids[seq-1], itemlist[i], 1);
+               else if (!strncasecmp(Cmd->Params[i].Key, "BODY.PEEK[", 10)) {
+                       imap_fetch_body(Imap->msgids[seq-1], Cmd->Params[i].Key, 1);
                }
 
                /* Otherwise, load the message into memory.
                 */
-               else if (!strcasecmp(itemlist[i], "BODYSTRUCTURE")) {
+               else if (!strcasecmp(Cmd->Params[i].Key, "BODYSTRUCTURE")) {
                        if ((msg != NULL) && (!body_loaded)) {
                                CtdlFreeMessage(msg);   /* need the whole thing */
                                msg = NULL;
                        }
                        if (msg == NULL) {
-                               msg = CtdlFetchMessage(IMAP->msgids[seq-1], 1);
+                               msg = CtdlFetchMessage(Imap->msgids[seq-1], 1);
                                body_loaded = 1;
                        }
-                       imap_fetch_bodystructure(IMAP->msgids[seq-1],
-                                       itemlist[i], msg);
+                       imap_fetch_bodystructure(Imap->msgids[seq-1],
+                                       Cmd->Params[i].Key, msg);
                }
-               else if (!strcasecmp(itemlist[i], "ENVELOPE")) {
+               else if (!strcasecmp(Cmd->Params[i].Key, "ENVELOPE")) {
                        if (msg == NULL) {
-                               msg = CtdlFetchMessage(IMAP->msgids[seq-1], 0);
+                               msg = CtdlFetchMessage(Imap->msgids[seq-1], 0);
                                body_loaded = 0;
                        }
                        imap_fetch_envelope(msg);
                }
-               else if (!strcasecmp(itemlist[i], "INTERNALDATE")) {
+               else if (!strcasecmp(Cmd->Params[i].Key, "INTERNALDATE")) {
                        if (msg == NULL) {
-                               msg = CtdlFetchMessage(IMAP->msgids[seq-1], 0);
+                               msg = CtdlFetchMessage(Imap->msgids[seq-1], 0);
                                body_loaded = 0;
                        }
                        imap_fetch_internaldate(msg);
                }
 
-               if (i != num_items-1) cprintf(" ");
+               if (i != Cmd->num_parms-1) cprintf(" ");
        }
 
        cprintf(")\r\n");
@@ -1042,8 +1061,28 @@ void imap_do_fetch_msg(int seq, int num_items, char **itemlist) {
  * imap_fetch() calls imap_do_fetch() to do its actual work, once it's
  * validated and boiled down the request a bit.
  */
-void imap_do_fetch(int num_items, char **itemlist) {
+void imap_do_fetch(citimap_command *Cmd) {
        int i;
+#if 0
+/* debug output the parsed vector */
+       {
+               int i;
+               CtdlLogPrintf(CTDL_DEBUG, "----- %ld params \n",
+                             Cmd->num_parms);
+
+       for (i=0; i < Cmd->num_parms; i++) {
+               if (Cmd->Params[i].len != strlen(Cmd->Params[i].Key))
+                       CtdlLogPrintf(CTDL_DEBUG, "*********** %ld != %ld : %s\n",
+                                     Cmd->Params[i].len, 
+                                     strlen(Cmd->Params[i].Key),
+                                     Cmd->Params[i].Key);
+               else
+                       CtdlLogPrintf(CTDL_DEBUG, "%ld : %s\n",
+                                     Cmd->Params[i].len, 
+                                     Cmd->Params[i].Key);
+       }}
+
+#endif
 
        if (IMAP->num_msgs > 0) {
                for (i = 0; i < IMAP->num_msgs; ++i) {
@@ -1057,7 +1096,7 @@ void imap_do_fetch(int num_items, char **itemlist) {
 
                        /* Get any message marked for fetch. */
                        if (IMAP->flags[i] & IMAP_SELECTED) {
-                               imap_do_fetch_msg(i+1, num_items, itemlist);
+                               imap_do_fetch_msg(i+1, Cmd);
                        }
                }
        }
@@ -1070,22 +1109,25 @@ void imap_do_fetch(int num_items, char **itemlist) {
  * Note that this function *only* looks at the beginning of the string.  It
  * is not a generic search-and-replace function.
  */
-void imap_macro_replace(char *str, char *find, char *replace) {
-       char holdbuf[SIZ];
-       int findlen;
-
-       findlen = strlen(find);
-
-       if (!strncasecmp(str, find, findlen)) {
-               if (str[findlen]==' ') {
-                       strcpy(holdbuf, &str[findlen+1]);
-                       strcpy(str, replace);
-                       strcat(str, " ");
-                       strcat(str, holdbuf);
+void imap_macro_replace(StrBuf *Buf, long where, 
+                       StrBuf *TmpBuf,
+                       char *find, long findlen, 
+                       char *replace, long replacelen) 
+{
+
+       if (StrLength(Buf) - where > findlen)
+               return;
+
+       if (!strncasecmp(ChrPtr(Buf) + where, find, findlen)) {
+               if (ChrPtr(Buf)[where + findlen] == ' ') {
+                       StrBufPlain(TmpBuf, replace, replacelen);
+                       StrBufAppendBufPlain(TmpBuf, HKEY(" "), 0);
+                       StrBufReplaceToken(Buf, where, findlen, 
+                                          SKEY(TmpBuf));
                }
-               if (str[findlen]==0) {
-                       strcpy(holdbuf, &str[findlen+1]);
-                       strcpy(str, replace);
+               if (where + findlen == StrLength(Buf)) {
+                       StrBufReplaceToken(Buf, where, findlen, 
+                                          replace, replacelen);
                }
        }
 }
@@ -1097,39 +1139,46 @@ void imap_macro_replace(char *str, char *find, char *replace) {
  * (What the heck are macros doing in a wire protocol?  Are we trying to save
  * the computer at the other end the trouble of typing a lot of characters?)
  */
-void imap_handle_macros(char *str) {
-       int i;
+void imap_handle_macros(citimap_command *Cmd) {
+       long i;
        int nest = 0;
-
-       for (i=0; str[i]; ++i) {
-               if (str[i]=='(') ++nest;
-               if (str[i]=='[') ++nest;
-               if (str[i]=='<') ++nest;
-               if (str[i]=='{') ++nest;
-               if (str[i]==')') --nest;
-               if (str[i]==']') --nest;
-               if (str[i]=='>') --nest;
-               if (str[i]=='}') --nest;
+       StrBuf *Tmp = NewStrBuf();
+
+       for (i=0; i < StrLength(Cmd->CmdBuf); ++i) {
+               char ch = ChrPtr(Cmd->CmdBuf)[i];
+               if ((ch=='(') ||
+                   (ch=='[') ||
+                   (ch=='<') ||
+                   (ch=='{')) ++nest;
+               else if ((ch==')') ||
+                        (ch==']') ||
+                        (ch=='>') ||
+                        (ch=='}')) --nest;
 
                if (nest <= 0) {
-                       imap_macro_replace(&str[i],
-                               "ALL",
-                               "FLAGS INTERNALDATE RFC822.SIZE ENVELOPE"
+                       imap_macro_replace(Cmd->CmdBuf, i,
+                                          Tmp, 
+                                          HKEY("ALL"),
+                                          HKEY("FLAGS INTERNALDATE RFC822.SIZE ENVELOPE")
                        );
-                       imap_macro_replace(&str[i],
-                               "BODY",
-                               "BODYSTRUCTURE"
+                       imap_macro_replace(Cmd->CmdBuf, i,
+                                          Tmp, 
+                                          HKEY("BODY"),
+                                          HKEY("BODYSTRUCTURE")
                        );
-                       imap_macro_replace(&str[i],
-                               "FAST",
-                               "FLAGS INTERNALDATE RFC822.SIZE"
+                       imap_macro_replace(Cmd->CmdBuf, i,
+                                          Tmp, 
+                                          HKEY("FAST"),
+                                          HKEY("FLAGS INTERNALDATE RFC822.SIZE")
                        );
-                       imap_macro_replace(&str[i],
-                               "FULL",
-                               "FLAGS INTERNALDATE RFC822.SIZE ENVELOPE BODY"
+                       imap_macro_replace(Cmd->CmdBuf, i,
+                                          Tmp, 
+                                          HKEY("FULL"),
+                                          HKEY("FLAGS INTERNALDATE RFC822.SIZE ENVELOPE BODY")
                        );
                }
        }
+       FreeStrBuf(&Tmp);
 }
 
 
@@ -1139,56 +1188,85 @@ void imap_handle_macros(char *str) {
  * NOTE: this function alters the string it is fed, and uses it as a buffer
  * to hold the data for the pointers it returns.
  */
-int imap_extract_data_items(char **argv, char *items) {
-       int num_items = 0;
+int imap_extract_data_items(citimap_command *Cmd) 
+{
+       int nArgs;
        int nest = 0;
-       int i;
-       char *start;
+       const char *pch, *end;
        long initial_len;
 
        /* Convert all whitespace to ordinary space characters. */
-       for (i=0; items[i]; ++i) {
-               if (isspace(items[i])) items[i]=' ';
+       pch = ChrPtr(Cmd->CmdBuf);
+       end = pch + StrLength(Cmd->CmdBuf);
+
+       while (pch < end)
+       {
+               if (isspace(*pch)) 
+                       StrBufPeek(Cmd->CmdBuf, pch, 0, ' ');
+               pch++;
        }
 
        /* Strip leading and trailing whitespace, then strip leading and
         * trailing parentheses if it's a list
         */
-       striplt(items);
-       if ( (items[0]=='(') && (items[strlen(items)-1]==')') ) {
-               items[strlen(items)-1] = 0;
-               strcpy(items, &items[1]);
-               striplt(items);
+       StrBufTrim(Cmd->CmdBuf);
+       pch = ChrPtr(Cmd->CmdBuf);
+       if ( (pch[0]=='(') && 
+            (pch[StrLength(Cmd->CmdBuf)-1]==')') ) 
+       {
+               StrBufCutRight(Cmd->CmdBuf, 1);
+               StrBufCutLeft(Cmd->CmdBuf, 1);
+               StrBufTrim(Cmd->CmdBuf);
        }
 
        /* Parse any macro data items */
-       imap_handle_macros(items);
+       imap_handle_macros(Cmd);
 
        /*
         * Now break out the data items.  We throw in one trailing space in
         * order to avoid having to break out the last one manually.
         */
-       strcat(items, " ");
-       start = items;
-       initial_len = strlen(items);
-       for (i=0; i<initial_len; ++i) {
-               if (items[i]=='(') ++nest;
-               if (items[i]=='[') ++nest;
-               if (items[i]=='<') ++nest;
-               if (items[i]=='{') ++nest;
-               if (items[i]==')') --nest;
-               if (items[i]==']') --nest;
-               if (items[i]=='>') --nest;
-               if (items[i]=='}') --nest;
-
-               if (nest <= 0) if (items[i]==' ') {
-                       items[i] = 0;
-                       argv[num_items++] = start;
-                       start = &items[i+1];
+       nArgs = StrLength(Cmd->CmdBuf) / 10 + 10;
+       nArgs = CmdAdjust(Cmd, nArgs, 0);
+       initial_len = StrLength(Cmd->CmdBuf);
+       Cmd->num_parms = 0;
+       Cmd->Params[Cmd->num_parms].Key = pch = ChrPtr(Cmd->CmdBuf);
+       end = Cmd->Params[Cmd->num_parms].Key + StrLength(Cmd->CmdBuf);
+
+       while (pch < end) 
+       {
+               if ((*pch=='(') ||
+                   (*pch=='[') ||
+                   (*pch=='<') ||
+                   (*pch=='{'))
+                       ++nest;
+
+               else if ((*pch==')') ||
+                        (*pch==']') ||
+                        (*pch=='>') ||
+                        (*pch=='}'))
+                       --nest;
+
+               if ((nest <= 0) && (*pch==' ')) {
+                       StrBufPeek(Cmd->CmdBuf, pch, 0, '\0');
+                       Cmd->Params[Cmd->num_parms].len = 
+                               pch - Cmd->Params[Cmd->num_parms].Key;
+
+                       if (Cmd->num_parms + 1 >= Cmd->avail_parms) {
+                               nArgs = CmdAdjust(Cmd, nArgs * 2, 1);
+                       }
+                       Cmd->num_parms++;                       
+                       Cmd->Params[Cmd->num_parms].Key = ++pch;
                }
-       }
+               else if (pch + 1 == end) {
+                       Cmd->Params[Cmd->num_parms].len = 
+                               pch - Cmd->Params[Cmd->num_parms].Key + 1;
 
-       return(num_items);
+                       Cmd->num_parms++;                       
+               }
+               pch ++;
+       }
+       return Cmd->num_parms;
 
 }
 
@@ -1208,14 +1286,14 @@ int imap_extract_data_items(char **argv, char *items) {
  *
  * Set is_uid to 1 to fetch by UID instead of sequence number.
  */
-void imap_pick_range(char *supplied_range, int is_uid) {
+void imap_pick_range(const char *supplied_range, int is_uid) {
        int i;
        int num_sets;
        int s;
        char setstr[SIZ], lostr[SIZ], histr[SIZ];
        long lo, hi;
        char actual_range[SIZ];
-       struct citimap *Imap;
+       citimap *Imap;
 
        /* 
         * Handle the "ALL" macro
@@ -1268,7 +1346,6 @@ void imap_pick_range(char *supplied_range, int is_uid) {
                        }
                }
        }
-
 }
 
 
@@ -1276,61 +1353,63 @@ void imap_pick_range(char *supplied_range, int is_uid) {
 /*
  * This function is called by the main command loop.
  */
-void imap_fetch(int num_parms, char *parms[]) {
-       char items[SIZ];
-       char *itemlist[512];
+void imap_fetch(int num_parms, ConstStr *Params) {
+       citimap_command Cmd;
        int num_items;
-       int i;
-
+       
        if (num_parms < 4) {
-               cprintf("%s BAD invalid parameters\r\n", parms[0]);
+               cprintf("%s BAD invalid parameters\r\n", Params[0].Key);
                return;
        }
 
-       imap_pick_range(parms[2], 0);
+       imap_pick_range(Params[2].Key, 0);
 
-       strcpy(items, "");
-       for (i=3; i<num_parms; ++i) {
-               strcat(items, parms[i]);
-               if (i < (num_parms-1)) strcat(items, " ");
-       }
+       memset(&Cmd, 0, sizeof(citimap_command));
+       Cmd.CmdBuf = NewStrBufPlain(NULL, StrLength(IMAP->Cmd.CmdBuf));
+       MakeStringOf(Cmd.CmdBuf, 3);
 
-       num_items = imap_extract_data_items(itemlist, items);
+       num_items = imap_extract_data_items(&Cmd);
        if (num_items < 1) {
-               cprintf("%s BAD invalid data item list\r\n", parms[0]);
+               cprintf("%s BAD invalid data item list\r\n", Params[0].Key);
+               FreeStrBuf(&Cmd.CmdBuf);
+               free(Cmd.Params);
                return;
        }
 
-       imap_do_fetch(num_items, itemlist);
-       cprintf("%s OK FETCH completed\r\n", parms[0]);
+       imap_do_fetch(&Cmd);
+       cprintf("%s OK FETCH completed\r\n", Params[0].Key);
+       FreeStrBuf(&Cmd.CmdBuf);
+       free(Cmd.Params);
 }
 
 /*
  * This function is called by the main command loop.
  */
-void imap_uidfetch(int num_parms, char *parms[]) {
-       char items[SIZ];
-       char *itemlist[512];
+void imap_uidfetch(int num_parms, ConstStr *Params) {
+       citimap_command Cmd;
        int num_items;
        int i;
        int have_uid_item = 0;
 
        if (num_parms < 5) {
-               cprintf("%s BAD invalid parameters\r\n", parms[0]);
+               cprintf("%s BAD invalid parameters\r\n", Params[0].Key);
                return;
        }
 
-       imap_pick_range(parms[3], 1);
+       imap_pick_range(Params[3].Key, 1);
 
-       strcpy(items, "");
-       for (i=4; i<num_parms; ++i) {
-               strcat(items, parms[i]);
-               if (i < (num_parms-1)) strcat(items, " ");
-       }
+       memset(&Cmd, 0, sizeof(citimap_command));
+       Cmd.CmdBuf = NewStrBufPlain(NULL, StrLength(IMAP->Cmd.CmdBuf));
 
-       num_items = imap_extract_data_items(itemlist, items);
+       MakeStringOf(Cmd.CmdBuf, 4);
+#if 0
+       CtdlLogPrintf(CTDL_DEBUG, "-------%s--------\n", ChrPtr(Cmd.CmdBuf));
+#endif
+       num_items = imap_extract_data_items(&Cmd);
        if (num_items < 1) {
-               cprintf("%s BAD invalid data item list\r\n", parms[0]);
+               cprintf("%s BAD invalid data item list\r\n", Params[0].Key);
+               FreeStrBuf(&Cmd.CmdBuf);
+               free(Cmd.Params);
                return;
        }
 
@@ -1338,16 +1417,23 @@ void imap_uidfetch(int num_parms, char *parms[]) {
         * (at the beginning) because this is a UID FETCH command
         */
        for (i=0; i<num_items; ++i) {
-               if (!strcasecmp(itemlist[i], "UID")) ++have_uid_item;
+               if (!strcasecmp(Cmd.Params[i].Key, "UID")) ++have_uid_item;
        }
        if (have_uid_item == 0) {
-               memmove(&itemlist[1], &itemlist[0], (sizeof(itemlist[0]) * num_items));
-               ++num_items;
-               itemlist[0] = "UID";
+               if (Cmd.num_parms + 1 >= Cmd.avail_parms)
+                       CmdAdjust(&Cmd, Cmd.avail_parms + 1, 1);
+               memmove(&Cmd.Params[1], 
+                       &Cmd.Params[0], 
+                       sizeof(ConstStr) * Cmd.num_parms);
+
+               Cmd.num_parms++;
+               Cmd.Params[0] = (ConstStr){HKEY("UID")};
        }
 
-       imap_do_fetch(num_items, itemlist);
-       cprintf("%s OK UID FETCH completed\r\n", parms[0]);
+       imap_do_fetch(&Cmd);
+       cprintf("%s OK UID FETCH completed\r\n", Params[0].Key);
+       FreeStrBuf(&Cmd.CmdBuf);
+       free(Cmd.Params);
 }