Lists: don't overwrite from: header. this only needs to be done for participates.
[citadel.git] / citadel / modules / network / serv_netmail.c
index b98e30bb1416d54d3a1f6e5234f71256e78b7ae1..a04bcfb12719aed29726c6a83410af3724d4c2b6 100644 (file)
 #include "netspool.h"
 #include "netmail.h"
 
+void network_deliver_list(struct CtdlMessage *msg, SpoolControl *sc, const char *RoomName);
+
+void aggregate_recipients(StrBuf **recps, RoomNetCfg Which, OneRoomNetCfg *OneRNCfg, long nSegments)
+{
+       int i;
+       size_t recps_len = 0;
+       RoomNetCfgLine *nptr;
+       struct CitContext *CCC = CC;
+
+       *recps = NULL;
+       /*
+        * Figure out how big a buffer we need to allocate
+        */
+       for (nptr = OneRNCfg->NetConfigs[Which]; nptr != NULL; nptr = nptr->next) {
+               recps_len = recps_len + StrLength(nptr->Value[0]) + 2;
+       }
+
+       /* Nothing todo... */
+       if (recps_len == 0)
+               return;
+
+       *recps = NewStrBufPlain(NULL, recps_len);
+
+       if (*recps == NULL) {
+               QN_syslog(LOG_EMERG,
+                         "Cannot allocate %ld bytes for recps...\n",
+                         (long)recps_len);
+               abort();
+       }
+
+       /* Each recipient */
+       for (nptr = OneRNCfg->NetConfigs[Which]; nptr != NULL; nptr = nptr->next) {
+               if (nptr != OneRNCfg->NetConfigs[Which]) {
+                       for (i = 0; i < nSegments; i++)
+                               StrBufAppendBufPlain(*recps, HKEY(","), i);
+               }
+               StrBufAppendBuf(*recps, nptr->Value[0], 0);
+       }
+}
+
+static void ListCalculateSubject(struct CtdlMessage *msg)
+{
+       struct CitContext *CCC = CC;
+       StrBuf *Subject, *FlatSubject;
+       int rlen;
+       char *pCh;
+
+       if (msg->cm_fields['U'] == NULL) {
+               Subject = NewStrBufPlain(HKEY("(no subject)"));
+       }
+       else {
+               Subject = NewStrBufPlain(
+                       msg->cm_fields['U'], -1);
+       }
+       FlatSubject = NewStrBufPlain(NULL, StrLength(Subject));
+       StrBuf_RFC822_to_Utf8(FlatSubject, Subject, NULL, NULL);
+
+       rlen = strlen(CCC->room.QRname);
+       pCh  = strstr(ChrPtr(FlatSubject), CCC->room.QRname);
+       if ((pCh == NULL) ||
+           (*(pCh + rlen) != ']') ||
+           (pCh == ChrPtr(FlatSubject)) ||
+           (*(pCh - 1) != '[')
+               )
+       {
+               StrBuf *tmp;
+               StrBufPlain(Subject, HKEY("["));
+               StrBufAppendBufPlain(Subject,
+                                    CCC->room.QRname,
+                                    rlen, 0);
+               StrBufAppendBufPlain(Subject, HKEY("] "), 0);
+               StrBufAppendBuf(Subject, FlatSubject, 0);
+               /* so we can free the right one swap them */
+               tmp = Subject;
+               Subject = FlatSubject;
+               FlatSubject = tmp;
+               StrBufRFC2047encode(&Subject, FlatSubject);
+       }
+
+       if (msg->cm_fields['U'] != NULL)
+               free (msg->cm_fields['U']);
+       msg->cm_fields['U'] = SmashStrBuf(&Subject);
+
+       FreeStrBuf(&FlatSubject);
+}
 
 /*
  * Deliver digest messages
  */
 void network_deliver_digest(SpoolControl *sc)
 {
-       struct CitContext *CCC = CC;
        char buf[SIZ];
-       int i;
        struct CtdlMessage *msg = NULL;
        long msglen;
-       StrBuf *recps = NULL;
-       char *precps;
-       size_t recps_len = SIZ;
        struct recptypes *valid;
-       RoomNetCfgLine *nptr;
        char bounce_to[256];
 
+       if (sc->Users[listrecp] == NULL)
+               return;
+
        if (sc->num_msgs_spooled < 1) {
                fclose(sc->digestfp);
                sc->digestfp = NULL;
@@ -115,22 +197,12 @@ void network_deliver_digest(SpoolControl *sc)
        msg->cm_fields['A'] = strdup(CC->room.QRname);
        snprintf(buf, sizeof buf, "[%s]", CC->room.QRname);
        msg->cm_fields['U'] = strdup(buf);
-       sprintf(buf, "room_%s@%s", CC->room.QRname, config.c_fqdn);
-       for (i=0; buf[i]; ++i) {
-               if (isspace(buf[i])) buf[i]='_';
-               buf[i] = tolower(buf[i]);
-       }
-       msg->cm_fields['F'] = strdup(buf);
-       msg->cm_fields['R'] = strdup(buf);
+
+       CtdlMsgSetCM_Fields(msg, 'F', SKEY(sc->Users[roommailalias]));
+       CtdlMsgSetCM_Fields(msg, 'R', SKEY(sc->Users[roommailalias]));
 
        /* Set the 'List-ID' header */
-       msg->cm_fields['L'] = malloc(1024);
-       snprintf(msg->cm_fields['L'], 1024,
-                "%s <%ld.list-id.%s>",
-                CC->room.QRname,
-                CC->room.QRnumber,
-                config.c_fqdn
-               );
+       CtdlMsgSetCM_Fields(msg, 'L', SKEY(sc->ListID));
 
        /*
         * Go fetch the contents of the digest
@@ -147,39 +219,15 @@ void network_deliver_digest(SpoolControl *sc)
        sc->digestfp = NULL;
 
        /* Now generate the delivery instructions */
-
-       /*
-        * Figure out how big a buffer we need to allocate
-        */
-       for (nptr = sc->RNCfg->NetConfigs[digestrecp]; nptr != NULL; nptr = nptr->next) {
-               recps_len = recps_len + StrLength(nptr->Value[0]) + 2;
-       }
-
-       recps = NewStrBufPlain(NULL, recps_len);
-
-       if (recps == NULL) {
-               QN_syslog(LOG_EMERG,
-                         "Cannot allocate %ld bytes for recps...\n",
-                         (long)recps_len);
-               abort();
-       }
-
-       /* Each recipient */
-       for (nptr = sc->RNCfg->NetConfigs[digestrecp]; nptr != NULL; nptr = nptr->next) {
-               if (nptr != sc->RNCfg->NetConfigs[digestrecp]) {
-                       StrBufAppendBufPlain(recps, HKEY(","), 0);
-               }
-               StrBufAppendBuf(recps, nptr->Value[0], 0);
-       }
+       if (sc->Users[listrecp] == NULL)
+               return;
 
        /* Where do we want bounces and other noise to be heard?
         *Surely not the list members! */
        snprintf(bounce_to, sizeof bounce_to, "room_aide@%s", config.c_fqdn);
 
        /* Now submit the message */
-       precps = SmashStrBuf(&recps);
-       valid = validate_recipients(precps, NULL, 0);
-       free(precps);
+       valid = validate_recipients(ChrPtr(sc->Users[listrecp]), NULL, 0);
        if (valid != NULL) {
                valid->bounce_to = strdup(bounce_to);
                valid->envelope_from = strdup(bounce_to);
@@ -198,7 +246,7 @@ void network_process_digest(SpoolControl *sc, struct CtdlMessage *omsg, long *de
        /*
         * Process digest recipients
         */
-       if ((sc->RNCfg->NetConfigs[digestrecp] == NULL) || 
+       if ((sc->Users[digestrecp] == NULL)||
            (sc->digestfp == NULL))
                return;
 
@@ -257,16 +305,12 @@ void network_process_digest(SpoolControl *sc, struct CtdlMessage *omsg, long *de
 
 void network_process_list(SpoolControl *sc, struct CtdlMessage *omsg, long *delete_after_send)
 {
-       int rlen;
-       char *pCh;
-       StrBuf *Subject, *FlatSubject;
        struct CtdlMessage *msg = NULL;
-       int i;
 
        /*
         * Process mailing list recipients
         */
-       if (sc->RNCfg->NetConfigs[listrecp] == NULL) 
+       if (sc->Users[listrecp] == NULL)
                return;
 
        /* create our own copy of the message.
@@ -276,78 +320,8 @@ void network_process_list(SpoolControl *sc, struct CtdlMessage *omsg, long *dele
 
        msg = CtdlDuplicateMessage(omsg);
 
-       if (msg->cm_fields['K'] != NULL)
-               free(msg->cm_fields['K']);
-       if (msg->cm_fields['V'] == NULL){
-               /* local message, no enVelope */
-               StrBuf *Buf;
-               Buf = NewStrBuf();
-               StrBufAppendBufPlain(Buf,
-                                    msg->cm_fields['O']
-                                    , -1, 0);
-               StrBufAppendBufPlain(Buf, HKEY("@"), 0);
-               StrBufAppendBufPlain(Buf, config.c_fqdn, -1, 0);
-
-               msg->cm_fields['K'] = SmashStrBuf(&Buf);
-       }
-       else {
-               msg->cm_fields['K'] =
-                       strdup (msg->cm_fields['V']);
-       }
-       /* Set the 'List-ID' header */
-       if (msg->cm_fields['L'] != NULL) {
-               free(msg->cm_fields['L']);
-       }
-       msg->cm_fields['L'] = malloc(1024);
-       snprintf(msg->cm_fields['L'], 1024,
-                "%s <%ld.list-id.%s>",
-                CC->room.QRname,
-                CC->room.QRnumber,
-                config.c_fqdn
-               );
-
-       /* Prepend "[List name]" to the subject */
-       if (msg->cm_fields['U'] == NULL) {
-               Subject = NewStrBufPlain(HKEY("(no subject)"));
-       }
-       else {
-               Subject = NewStrBufPlain(
-                       msg->cm_fields['U'], -1);
-       }
-       FlatSubject = NewStrBufPlain(NULL, StrLength(Subject));
-       StrBuf_RFC822_to_Utf8(FlatSubject, Subject, NULL, NULL);
-
-       rlen = strlen(CC->room.QRname);
-       pCh  = strstr(ChrPtr(FlatSubject), CC->room.QRname);
-       if ((pCh == NULL) ||
-           (*(pCh + rlen) != ']') ||
-           (pCh == ChrPtr(FlatSubject)) ||
-           (*(pCh - 1) != '[')
-               )
-       {
-               StrBuf *tmp;
-               StrBufPlain(Subject, HKEY("["));
-               StrBufAppendBufPlain(Subject,
-                                    CC->room.QRname,
-                                    rlen, 0);
-               StrBufAppendBufPlain(Subject, HKEY("] "), 0);
-               StrBufAppendBuf(Subject, FlatSubject, 0);
-               /* so we can free the right one swap them */
-               tmp = Subject;
-               Subject = FlatSubject;
-               FlatSubject = tmp;
-               StrBufRFC2047encode(&Subject, FlatSubject);
-       }
-
-       if (msg->cm_fields['U'] != NULL)
-               free (msg->cm_fields['U']);
-       msg->cm_fields['U'] = SmashStrBuf(&Subject);
 
-       FreeStrBuf(&FlatSubject);
-
-       /* else we won't modify the buffer, since the
-        * roomname is already here.
-        */
+       CtdlMsgSetCM_Fields(msg, 'K', SKEY(sc->Users[roommailalias]));
 
        /* if there is no other recipient, Set the recipient
         * of the list message to the email address of the
@@ -356,22 +330,18 @@ void network_process_list(SpoolControl *sc, struct CtdlMessage *omsg, long *dele
        if ((msg->cm_fields['R'] == NULL) ||
            IsEmptyStr(msg->cm_fields['R']))
        {
-               if (msg->cm_fields['R'] != NULL)
-                       free(msg->cm_fields['R']);
-
-               msg->cm_fields['R'] = malloc(256);
-               snprintf(msg->cm_fields['R'], 256,
-                        "room_%s@%s", CC->room.QRname,
-                        config.c_fqdn);
-               for (i=0; msg->cm_fields['R'][i]; ++i) {
-                       if (isspace(msg->cm_fields['R'][i])) {
-                               msg->cm_fields['R'][i] = '_';
-                       }
-               }
+               CtdlMsgSetCM_Fields(msg, 'R', SKEY(sc->Users[roommailalias]));
        }
 
+       /* Set the 'List-ID' header */
+       CtdlMsgSetCM_Fields(msg, 'L', SKEY(sc->ListID));
+
+
+       /* Prepend "[List name]" to the subject */
+       ListCalculateSubject(msg);
+
        /* Handle delivery */
-//                     network_deliver_list(msg, sc, CC->room.QRname);
+       network_deliver_list(msg, sc, CC->room.QRname);
        CtdlFreeMessage(msg);
 }
 
@@ -380,51 +350,21 @@ void network_process_list(SpoolControl *sc, struct CtdlMessage *omsg, long *dele
  */
 void network_deliver_list(struct CtdlMessage *msg, SpoolControl *sc, const char *RoomName)
 {
-       struct CitContext *CCC = CC;
-       StrBuf *recps = NULL;
-       char *precps = NULL;
-       size_t recps_len = SIZ;
        struct recptypes *valid;
-       RoomNetCfgLine *nptr;
        char bounce_to[256];
 
        /* Don't do this if there were no recipients! */
-       if (sc->RNCfg->NetConfigs[listrecp] == NULL) return;
+       if (sc->Users[listrecp] == NULL)
+               return;
 
        /* Now generate the delivery instructions */
 
-       /*
-        * Figure out how big a buffer we need to allocate
-        */
-       for (nptr = sc->RNCfg->NetConfigs[listrecp]; nptr != NULL; nptr = nptr->next) {
-               recps_len = recps_len + StrLength(nptr->Value[0]) + 2;
-       }
-
-       recps = NewStrBufPlain(NULL, recps_len);
-
-       if (recps == NULL) {
-               QN_syslog(LOG_EMERG,
-                         "Cannot allocate %ld bytes for recps...\n",
-                         (long)recps_len);
-               abort();
-       }
-
-       /* Each recipient */
-       for (nptr = sc->RNCfg->NetConfigs[listrecp]; nptr != NULL; nptr = nptr->next) {
-               if (nptr != sc->RNCfg->NetConfigs[listrecp]) {
-                       StrBufAppendBufPlain(recps, HKEY(","), 0);
-               }
-               StrBufAppendBuf(recps, nptr->Value[0], 0);
-       }
-
        /* Where do we want bounces and other noise to be heard?
         *  Surely not the list members! */
        snprintf(bounce_to, sizeof bounce_to, "room_aide@%s", config.c_fqdn);
 
        /* Now submit the message */
-       precps = SmashStrBuf(&recps);
-       valid = validate_recipients(precps, NULL, 0);
-       free(precps);
+       valid = validate_recipients(ChrPtr(sc->Users[listrecp]), NULL, 0);
        if (valid != NULL) {
                valid->bounce_to = strdup(bounce_to);
                valid->envelope_from = strdup(bounce_to);
@@ -439,16 +379,14 @@ void network_deliver_list(struct CtdlMessage *msg, SpoolControl *sc, const char
 void network_process_participate(SpoolControl *sc, struct CtdlMessage *omsg, long *delete_after_send)
 {
        struct CtdlMessage *msg = NULL;
-       int i;
        int ok_to_participate = 0;
        StrBuf *Buf = NULL;
-       RoomNetCfgLine *nptr;
        struct recptypes *valid;
 
        /*
         * Process client-side list participations for this room
         */
-       if (sc->RNCfg->NetConfigs[participate] == NULL)
+       if (sc->Users[participate] == NULL)
                return;
 
        msg = CtdlDuplicateMessage(omsg);
@@ -475,45 +413,20 @@ void network_process_participate(SpoolControl *sc, struct CtdlMessage *omsg, lon
                        ok_to_participate = 1;
                }
        }
-       if (ok_to_participate) {
-               if (msg->cm_fields['F'] != NULL) {
-                       free(msg->cm_fields['F']);
-               }
-               msg->cm_fields['F'] = malloc(SIZ);
+       if (ok_to_participate)
+       {
                /* Replace the Internet email address of the
                 * actual author with the email address of the
                 * room itself, so the remote listserv doesn't
                 * reject us.
-                * FIXME  I want to be able to pick any address
-                */
-               snprintf(msg->cm_fields['F'], SIZ,
-                        "room_%s@%s", CC->room.QRname,
-                        config.c_fqdn);
-               for (i=0; msg->cm_fields['F'][i]; ++i) {
-                       if (isspace(msg->cm_fields['F'][i])) {
-                               msg->cm_fields['F'][i] = '_';
-                       }
-               }
-               
-               /*
-                * Figure out how big a buffer we need to alloc
                 */
-               for (nptr = sc->RNCfg->NetConfigs[participate];
-                    nptr != NULL;
-                    nptr = nptr->next)
-               {
-                       if (msg->cm_fields['R'] != NULL) {
-                               free(msg->cm_fields['R']);
-                       }
-                       msg->cm_fields['R'] =
-                               strdup(ChrPtr(nptr->Value[0]));
-                       
-                       valid = validate_recipients(msg->cm_fields['R'],
-                                                   NULL, 0);
-                       
-                       CtdlSubmitMsg(msg, valid, "", 0);
-                       free_recipients(valid);
-               }
+               CtdlMsgSetCM_Fields(msg, 'F', SKEY(sc->Users[roommailalias]));
+
+               valid = validate_recipients(ChrPtr(sc->Users[participate]) , NULL, 0);
+
+               CtdlMsgSetCM_Fields(msg, 'R', SKEY(sc->Users[roommailalias]));
+               CtdlSubmitMsg(msg, valid, "", 0);
+               free_recipients(valid);
        }
        FreeStrBuf(&Buf);
        CtdlFreeMessage(msg);
@@ -521,6 +434,9 @@ void network_process_participate(SpoolControl *sc, struct CtdlMessage *omsg, lon
 
 void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long *delete_after_send)
 {
+       StrBuf *Recipient;
+       StrBuf *RemoteRoom;
+       const char *Pos = NULL;
        struct CtdlMessage *msg = NULL;
        struct CitContext *CCC = CC;
        struct ser_ret sermsg;
@@ -529,14 +445,14 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
        FILE *fp;
        size_t newpath_len;
        char *newpath = NULL;
-       RoomNetCfgLine* mptr;
        StrBuf *Buf = NULL;
        int i;
        int bang = 0;
        int send = 1;
 
-       if (sc->RNCfg->NetConfigs[ignet_push_share] == NULL)
+       if (sc->Users[ignet_push_share] == NULL)
                return;
+
        /*
         * Process IGnet push shares
         */
@@ -568,12 +484,14 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
        }
 
        /* Now send it to every node */
-       for (mptr = sc->RNCfg->NetConfigs[ignet_push_share];
-            mptr != NULL;
-            mptr = mptr->next)
+       Recipient = NewStrBufPlain(NULL, StrLength(sc->Users[ignet_push_share]));
+       RemoteRoom = NewStrBufPlain(NULL, StrLength(sc->Users[ignet_push_share]));
+       while ((Pos != StrBufNOTNULL) &&
+              StrBufExtract_NextToken(Recipient, sc->Users[ignet_push_share], &Pos, ','))
        {
+               StrBufExtract_NextToken(RemoteRoom, sc->Users[ignet_push_share], &Pos, ',');
                send = 1;
-               NewStrBufDupAppendFlush(&Buf, mptr->Value[0], NULL, 1);
+               NewStrBufDupAppendFlush(&Buf, Recipient, NULL, 1);
                        
                /* Check for valid node name */
                if (CtdlIsValidNode(NULL,
@@ -584,7 +502,7 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                {
                        QN_syslog(LOG_ERR,
                                  "Invalid node <%s>\n",
-                                 ChrPtr(mptr->Value[0]));
+                                 ChrPtr(Recipient));
                        
                        send = 0;
                }
@@ -600,8 +518,8 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                                              sizeof buf);
 
                                QN_syslog(LOG_DEBUG, "Compare <%s> to <%s>\n",
-                                         buf, ChrPtr(mptr->Value[0])) ;
-                               if (!strcasecmp(buf, ChrPtr(mptr->Value[0]))) {
+                                         buf, ChrPtr(Recipient)) ;
+                               if (!strcasecmp(buf, ChrPtr(Recipient))) {
                                        send = 0;
                                        break;
                                }
@@ -610,7 +528,7 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                        QN_syslog(LOG_INFO,
                                  "%sSending to %s\n",
                                  (send)?"":"Not ",
-                                 ChrPtr(mptr->Value[0]));
+                                 ChrPtr(Recipient));
                }
                
                /* Send the message */
@@ -624,9 +542,9 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                        if (msg->cm_fields['C'] != NULL) {
                                free(msg->cm_fields['C']);
                        }
-                       if (StrLength(mptr->Value[0]) > 0) {
+                       if (StrLength(RemoteRoom) > 0) {
                                msg->cm_fields['C'] =
-                                       strdup(ChrPtr(mptr->Value[0]));
+                                       strdup(ChrPtr(RemoteRoom));
                        }
                        else {
                                msg->cm_fields['C'] =
@@ -642,7 +560,7 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                                         sizeof(filename),
                                         "%s/%s@%lx%x",
                                         ctdl_netout_dir,
-                                        ChrPtr(mptr->Value[0]),
+                                        ChrPtr(Recipient),
                                         time(NULL),
                                         rand()
                                        );
@@ -670,6 +588,8 @@ void network_process_ignetpush(SpoolControl *sc, struct CtdlMessage *omsg, long
                }
        }
        FreeStrBuf(&Buf);
+       FreeStrBuf(&Recipient);
+       FreeStrBuf(&RemoteRoom);
        CtdlFreeMessage(msg);
 }