Completed the rewrite of the network poller. Again I'm not terribly happy with this...
[citadel.git] / citadel / modules / network / serv_netspool.c
index 3ebac02fe1da072764f7e1b4da1835c01f9d9ceb..7ca9edcd8422f7936ae7d8ecfb321f9ad652e179 100644 (file)
@@ -2,7 +2,7 @@
  * This module handles shared rooms, inter-Citadel mail, and outbound
  * mailing list processing.
  *
- * Copyright (c) 2000-2016 by the citadel.org team
+ * Copyright (c) 2000-2017 by the citadel.org team
  *
  * This program is open source software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 3.
@@ -108,7 +108,7 @@ void network_bounce(struct CtdlMessage **pMsg, char *reason)
        long len;
        struct CtdlMessage *msg = *pMsg;
        *pMsg = NULL;
-       syslog(LOG_DEBUG, "entering network_bounce()");
+       syslog(LOG_DEBUG, "netspool: entering network_bounce()");
 
        if (msg == NULL) return;
 
@@ -171,7 +171,7 @@ void network_bounce(struct CtdlMessage **pMsg, char *reason)
        /* Clean up */
        if (valid != NULL) free_recipients(valid);
        CM_Free(msg);
-       syslog(LOG_DEBUG, "leaving network_bounce()");
+       syslog(LOG_DEBUG, "netspool: leaving network_bounce()");
 }
 
 
@@ -267,7 +267,7 @@ void InspectQueuedRoom(SpoolControl **pSC,
        SpoolControl *sc;
        int i = 0;
 
-       syslog(LOG_INFO, "InspectQueuedRoom(%s)", room_to_spool->name);
+       syslog(LOG_INFO, "netspool: InspectQueuedRoom(%s)", room_to_spool->name);
 
        sc = (SpoolControl*)malloc(sizeof(SpoolControl));
        memset(sc, 0, sizeof(SpoolControl));
@@ -280,7 +280,7 @@ void InspectQueuedRoom(SpoolControl **pSC,
         * queued for networking and then deleted before it can happen.
         */
        if (CtdlGetRoom(&sc->room, room_to_spool->name) != 0) {
-               syslog(LOG_INFO, "ERROR: cannot load <%s>", room_to_spool->name);
+               syslog(LOG_INFO, "netspool: ERROR; cannot load <%s>", room_to_spool->name);
                free(sc);
                return;
        }
@@ -289,11 +289,11 @@ void InspectQueuedRoom(SpoolControl **pSC,
 
        sc->RNCfg = CtdlGetNetCfgForRoom(sc->room.QRnumber);
 
-       syslog(LOG_DEBUG, "Room <%s> highest=%ld lastsent=%ld", room_to_spool->name, sc->room.QRhighest, sc->RNCfg->lastsent);
+       syslog(LOG_DEBUG, "netspool: room <%s> highest=%ld lastsent=%ld", room_to_spool->name, sc->room.QRhighest, sc->RNCfg->lastsent);
        if ( (!HaveSpoolConfig(sc->RNCfg)) || (sc->room.QRhighest <= sc->RNCfg->lastsent) ) 
        {
                // There is nothing to send from this room.
-               MARK_syslog(LOG_DEBUG, "Nothing to do for <%s>", room_to_spool->name);
+               syslog(LOG_DEBUG, "netspool: nothing to do for <%s>", room_to_spool->name);
                FreeRoomNetworkStruct(&sc->RNCfg);
                sc->RNCfg = NULL;
                free(sc);
@@ -325,27 +325,23 @@ void InspectQueuedRoom(SpoolControl **pSC,
 void CalcListID(SpoolControl *sc)
 {
        StrBuf *RoomName;
-       const char *err;
-       int fd;
        struct CitContext *CCC = CC;
-       char filename[PATH_MAX];
 #define MAX_LISTIDLENGTH 150
 
-       assoc_file_name(filename, sizeof filename, &sc->room, ctdl_info_dir);
-       fd = open(filename, 0);
-
-       if (fd > 0) {
-               struct stat stbuf;
-
-               if ((fstat(fd, &stbuf) == 0) &&
-                   (stbuf.st_size > 0))
-               {
-                       sc->RoomInfo = NewStrBufPlain(NULL, stbuf.st_size + 1);
-                       StrBufReadBLOB(sc->RoomInfo, &fd, 0, stbuf.st_size, &err);
-               }
-               close(fd);
+       // Load the room banner as the list description
+       struct CtdlMessage *msg = CtdlFetchMessage(sc->room.msgnum_info, 1, 1);
+        if (msg != NULL) {
+               CC->redirect_buffer = NewStrBufPlain(NULL, SIZ);
+                CtdlOutputPreLoadedMsg(msg, MT_CITADEL, HEADERS_NONE, 0, 0, 0);
+                CM_Free(msg);
+               sc->RoomInfo = CC->redirect_buffer;
+               CC->redirect_buffer = NULL;
+        }
+       else {
+               sc->RoomInfo = NewStrBufPlain(NULL, SIZ);
        }
 
+       // Calculate the List ID
        sc->ListID = NewStrBufPlain(NULL, 1024);
        if (StrLength(sc->RoomInfo) > 0)
        {
@@ -414,7 +410,6 @@ void CalcListID(SpoolControl *sc)
        FreeStrBuf(&RoomName);
 }
 
-static time_t last_digest_delivery = 0;
 
 /*
  * Batch up and send all outbound traffic from the current room
@@ -433,7 +428,7 @@ void network_spoolout_room(SpoolControl *sc)
         */
        memcpy (&CCC->room, &sc->room, sizeof(ctdlroom));
 
-       syslog(LOG_INFO, "network_spoolout_room(room=%s, lastsent=%ld)", CCC->room.QRname, sc->lastsent);
+       syslog(LOG_INFO, "netspool: network_spoolout_room(room=%s, lastsent=%ld)", CCC->room.QRname, sc->lastsent);
 
        CalcListID(sc);
 
@@ -454,8 +449,7 @@ void network_spoolout_room(SpoolControl *sc)
        }
        else
        {
-               snprintf(buf, sizeof buf, "room_%s@%s",
-                        CCC->room.QRname, CtdlGetConfigStr("c_fqdn"));
+               snprintf(buf, sizeof buf, "room_%s@%s", CCC->room.QRname, CtdlGetConfigStr("c_fqdn"));
        }
 
        for (i=0; buf[i]; ++i) {
@@ -465,45 +459,22 @@ void network_spoolout_room(SpoolControl *sc)
 
 
        /* If we wrote a digest, deliver it and then close it */
-       if (sc->Users[digestrecp] != NULL) {
-               time_t now = time(NULL);
-               time_t secs_today = now % (24 * 60 * 60);
-               long delta = 0;
-
-               if (last_digest_delivery != 0) {
-                       delta = now - last_digest_delivery;
-                       delta = (24 * 60 * 60) - delta;
-               }
-
-               if ((secs_today < 300) && 
-                   (delta < 300))
-               {
-                       if (sc->digestfp == NULL) {
-                               sc->digestfp = create_digest_file(&sc->room, 0);
-                       }
-                       if (sc->digestfp != NULL) {
-                               last_digest_delivery = now;
-                               fprintf(sc->digestfp,
-                                       " -----------------------------------"
-                                       "------------------------------------"
-                                       "-------\n"
-                                       "You are subscribed to the '%s' "
-                                       "list.\n"
-                                       "To post to the list: %s\n",
-                                       CCC->room.QRname, buf
-                                       );
-                               network_deliver_digest(sc);     /* deliver */
-                               remove_digest_file(&sc->room);
-                       }
-               }
-       }
-       if (sc->digestfp != NULL) {
+       if ( (sc->Users[digestrecp] != NULL) && (sc->digestfp != NULL) )
+       {
+               fprintf(sc->digestfp,
+                       " ------------------------------------------------------------------------------\n"
+                       "You are subscribed to the '%s' list.\n"
+                       "To post to the list: %s\n",
+                       CCC->room.QRname, buf
+               );
+               network_deliver_digest(sc);     /* deliver */
                fclose(sc->digestfp);
                sc->digestfp = NULL;
+               remove_digest_file(&sc->room);
        }
 
        /* Now rewrite the netconfig */
-       syslog(LOG_DEBUG, "lastsent was %ld , now it is %ld", lastsent, sc->lastsent);
+       syslog(LOG_DEBUG, "netspool: lastsent was %ld , now it is %ld", lastsent, sc->lastsent);
        if (sc->lastsent != lastsent)
        {
                OneRoomNetCfg *r;
@@ -527,8 +498,6 @@ void network_spoolout_room(SpoolControl *sc)
 int network_usetable(struct CtdlMessage *msg)
 {
        StrBuf *msgid;
-       struct CitContext *CCC = CC;
-       time_t now;
 
        /* Bail out if we can't generate a message ID */
        if ((msg == NULL) || CM_IsEmpty(msg, emessageId))
@@ -548,13 +517,7 @@ int network_usetable(struct CtdlMessage *msg)
                        return(0);
                }
        }
-       now = time(NULL);
-       if (CheckIfAlreadySeen("Networker Import",
-                              msgid,
-                              now, 0,
-                              eUpdate,
-                              CCC->cs_pid, 0) != 0)
-       {
+       if (CheckIfAlreadySeen(msgid)) {
                FreeStrBuf(&msgid);
                return(1);
        }
@@ -584,13 +547,13 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg,
        unsigned char firstbyte;
        unsigned char lastbyte;
 
-       syslog(LOG_DEBUG, "network_process_buffer() processing %ld bytes", size);
+       syslog(LOG_DEBUG, "netspool: network_process_buffer() processing %ld bytes", size);
 
        /* Validate just a little bit.  First byte should be FF and * last byte should be 00. */
        firstbyte = buffer[0];
        lastbyte = buffer[size-1];
        if ( (firstbyte != 255) || (lastbyte != 0) ) {
-               syslog(LOG_ERR, "Corrupt message ignored.  Length=%ld, firstbyte = %d, lastbyte = %d", size, firstbyte, lastbyte);
+               syslog(LOG_ERR, "netspool: corrupt message ignored.  Length=%ld, firstbyte = %d, lastbyte = %d", size, firstbyte, lastbyte);
                return;
        }
 
@@ -640,7 +603,7 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg,
                                         time(NULL),
                                         rand()
                                );
-                               syslog(LOG_DEBUG, "Appending to %s", filename);
+                               syslog(LOG_DEBUG, "netspool: appending to %s", filename);
                                fp = fopen(filename, "ab");
                                if (fp != NULL) {
                                        fwrite(sermsg.ser, sermsg.len, 1, fp);
@@ -701,7 +664,7 @@ void network_process_buffer(char *buffer, long size, HashList *working_ignetcfg,
                                "A message you sent could not be delivered due to an invalid address.\n"
                                "Please check the address and try sending the message again.\n");
                        free_recipients(recp);
-                       syslog(LOG_DEBUG, "Bouncing message due to invalid recipient address.");
+                       syslog(LOG_DEBUG, "netspool: bouncing message due to invalid recipient address.");
                        return;
                }
                strcpy(target_room, "");        /* no target room if mail */
@@ -778,12 +741,12 @@ void network_process_file(char *filename,
 
        fp = fopen(filename, "rb");
        if (fp == NULL) {
-               syslog(LOG_CRIT, "Error opening %s: %s", filename, strerror(errno));
+               syslog(LOG_ERR, "%s: %s", filename, strerror(errno));
                return;
        }
 
        fseek(fp, 0L, SEEK_END);
-       syslog(LOG_INFO, "network: processing %ld bytes from %s", ftell(fp), filename);
+       syslog(LOG_INFO, "netspool: processing %ld bytes from %s", ftell(fp), filename);
        rewind(fp);
 
        /* Look for messages in the data stream and break them out */
@@ -818,7 +781,7 @@ void network_process_file(char *filename,
        }
 
        if (nMessages > 0)
-               syslog(LOG_INFO, "network: processed %d messages in %s", nMessages, filename);
+               syslog(LOG_INFO, "netspool: processed %d messages in %s", nMessages, filename);
 
        fclose(fp);
        unlink(filename);
@@ -845,11 +808,11 @@ void network_do_spoolin(HashList *working_ignetcfg, HashList *the_netmap, int *n
         */
        if (stat(ctdl_netin_dir, &statbuf)) return;
        if (statbuf.st_mtime == last_spoolin_mtime) {
-               MARKM_syslog(LOG_DEBUG, "network: nothing in inbound queue");
+               syslog(LOG_DEBUG, "netspool: nothing in inbound queue");
                return;
        }
        last_spoolin_mtime = statbuf.st_mtime;
-       MARKM_syslog(LOG_DEBUG, "network: processing inbound queue");
+       syslog(LOG_DEBUG, "netspool: processing inbound queue");
 
        /*
         * Ok, there's something interesting in there, so scan it.
@@ -950,7 +913,6 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
        int nFailed = 0;
        int d_type = 0;
 
-
        /* Step 1: consolidate files in the outbound queue into one file per neighbor node */
        d = (struct dirent *)malloc(offsetof(struct dirent, d_name) + PATH_MAX + 1);
        if (d == NULL)  return;
@@ -1016,10 +978,10 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
                         ctdl_netout_dir,
                         ChrPtr(NextHop));
 
-               syslog(LOG_DEBUG, "Consolidate %s to %s", filename, ChrPtr(NextHop));
+               syslog(LOG_DEBUG, "netspool: consolidate %s to %s", filename, ChrPtr(NextHop));
                if (CtdlNetworkTalkingTo(SKEY(NextHop), NTT_CHECK)) {
                        nFailed++;
-                       syslog(LOG_DEBUG, "Currently online with %s - skipping for now", ChrPtr(NextHop));
+                       syslog(LOG_DEBUG, "netspool: currently online with %s - skipping for now", ChrPtr(NextHop));
                }
                else {
                        size_t dsize;
@@ -1031,10 +993,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
                        infd = open(filename, O_RDONLY);
                        if (infd == -1) {
                                nFailed++;
-                               syslog(LOG_ERR,
-                                         "failed to open %s for reading due to %s; skipping.",
-                                         filename, strerror(errno)
-                               );
+                               syslog(LOG_ERR, "%s: %s", filename, strerror(errno));
                                CtdlNetworkTalkingTo(SKEY(NextHop), NTT_REMOVE);
                                continue;                               
                        }
@@ -1050,10 +1009,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
                        }
                        if (outfd == -1) {
                                nFailed++;
-                               syslog(LOG_ERR,
-                                         "failed to open %s for reading due to %s; skipping.",
-                                         spooloutfilename, strerror(errno)
-                               );
+                               syslog(LOG_ERR, "%s: %s", spooloutfilename, strerror(errno));
                                close(infd);
                                CtdlNetworkTalkingTo(SKEY(NextHop), NTT_REMOVE);
                                continue;
@@ -1064,9 +1020,6 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
 
                        fstat(infd, &statbuf);
                        fsize = statbuf.st_size;
-/*
-                       fsize = lseek(infd, 0, SEEK_END);
-*/                     
                        IOB.fd = infd;
                        FDIOBufferInit(&FDIO, &IOB, outfd, fsize + dsize);
                        FDIO.ChunkSendRemain = fsize;
@@ -1076,11 +1029,11 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
                        do {} while ((FileMoveChunked(&FDIO, &err) > 0) && (err == NULL));
                        if (err == NULL) {
                                unlink(filename);
-                               syslog(LOG_DEBUG, "Spoolfile %s now "SIZE_T_FMT" KB", spooloutfilename, (dsize + fsize)/1024);
+                               syslog(LOG_DEBUG, "netspool: spoolfile %s now "SIZE_T_FMT" KB", spooloutfilename, (dsize + fsize)/1024);
                        }
                        else {
                                nFailed++;
-                               syslog(LOG_ERR, "failed to append to %s [%s]; rolling back..", spooloutfilename, strerror(errno));
+                               syslog(LOG_ERR, "netspool: failed to append to %s [%s]; rolling back..", spooloutfilename, strerror(errno));
                                /* whoops partial append?? truncate spooloutfilename again! */
                                ftruncate(outfd, dsize);
                        }
@@ -1094,7 +1047,7 @@ void network_consolidate_spoolout(HashList *working_ignetcfg, HashList *the_netm
 
        if (nFailed > 0) {
                FreeStrBuf(&NextHop);
-               syslog(LOG_INFO, "skipping Spoolcleanup because of %d files unprocessed.", nFailed);
+               syslog(LOG_INFO, "netspool: skipping Spoolcleanup because of %d files unprocessed.", nFailed);
 
                return;
        }
@@ -1181,27 +1134,26 @@ void free_spoolcontrol_struct_members(SpoolControl *sc)
 }
 
 
-
 /*
  * It's ok if these directories already exist.  Just fail silently.
  */
 void create_spool_dirs(void) {
        if ((mkdir(ctdl_spool_dir, 0700) != 0) && (errno != EEXIST))
-               syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_spool_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_spool_dir, strerror(errno));
        if (chown(ctdl_spool_dir, CTDLUID, (-1)) != 0)
-               syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_spool_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_spool_dir, strerror(errno));
        if ((mkdir(ctdl_netin_dir, 0700) != 0) && (errno != EEXIST))
-               syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_netin_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_netin_dir, strerror(errno));
        if (chown(ctdl_netin_dir, CTDLUID, (-1)) != 0)
-               syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_netin_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_netin_dir, strerror(errno));
        if ((mkdir(ctdl_nettmp_dir, 0700) != 0) && (errno != EEXIST))
-               syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_nettmp_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_nettmp_dir, strerror(errno));
        if (chown(ctdl_nettmp_dir, CTDLUID, (-1)) != 0)
-               syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_nettmp_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_nettmp_dir, strerror(errno));
        if ((mkdir(ctdl_netout_dir, 0700) != 0) && (errno != EEXIST))
-               syslog(LOG_EMERG, "unable to create directory [%s]: %s", ctdl_netout_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to create directory [%s]: %s", ctdl_netout_dir, strerror(errno));
        if (chown(ctdl_netout_dir, CTDLUID, (-1)) != 0)
-               syslog(LOG_EMERG, "unable to set the access rights for [%s]: %s", ctdl_netout_dir, strerror(errno));
+               syslog(LOG_EMERG, "netspool: unable to set the access rights for [%s]: %s", ctdl_netout_dir, strerror(errno));
 }
 
 /*