scraping the bits away
[citadel.git] / citadel / modules / network / serv_network.c
index a597a68bb93e6ebe6e1aa59ed8ac8a8331ad801e..0b77b359dc6304846e00edd052ee3100aecdc4af 100644 (file)
@@ -2,7 +2,7 @@
  * This module handles shared rooms, inter-Citadel mail, and outbound
  * mailing list processing.
  *
- * Copyright (c) 2000-2015 by the citadel.org team
+ * Copyright (c) 2000-2018 by the citadel.org team
  *
  * This program is open source software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 3.
@@ -18,7 +18,6 @@
  * so many things inside these, here are the rules:
  *  1. begin_critical_section(S_NETCONFIGS) *before* begin_ any others.
  *  2. Do *not* perform any I/O with the client during these sections.
- *
  */
 
 /*
@@ -79,7 +78,6 @@
 #include "netspool.h"
 #include "netmail.h"
 
-int NetQDebugEnabled = 0;
 struct CitContext networker_spool_CC;
 
 /* comes from lookup3.c from libcitadel... */
@@ -112,39 +110,43 @@ int network_sync_to(char *target_node, long len)
        SpoolControl sc;
        int num_spooled = 0;
 
-       /* Grab the configuration line we're looking for */
-       begin_critical_section(S_NETCONFIGS);
+       /* Load the netconfig for this room */
        pRNCFG = CtdlGetNetCfgForRoom(CCC->room.QRnumber);
-       if ((pRNCFG == NULL) || (pRNCFG->NetConfigs[ignet_push_share] == NULL))
+       if (pRNCFG == NULL) {                                   // no netconfig at all?
+               return -1;
+       }
+       if (pRNCFG->NetConfigs[ignet_push_share] == NULL)       // no ignet push shares?
        {
+               FreeRoomNetworkStruct(&pRNCFG);
                return -1;
        }
 
-       pCfgLine = pRNCFG->NetConfigs[ignet_push_share];
-       while (pCfgLine != NULL)
+       /* Search for an ignet_oush_share configuration bearing the target node's name */
+       for (pCfgLine = pRNCFG->NetConfigs[ignet_push_share]; pCfgLine != NULL; pCfgLine = pCfgLine->next)
        {
                if (!strcmp(ChrPtr(pCfgLine->Value[0]), target_node))
                        break;
-               pCfgLine = pCfgLine->next;
        }
+
+       /* If we aren't sharing with that node, bail out */
        if (pCfgLine == NULL)
        {
+               FreeRoomNetworkStruct(&pRNCFG);
                return -1;
        }
 
+       /* If we got here, we're good to go ... make up a dummy spoolconfig and roll with it */
+
+       begin_critical_section(S_NETCONFIGS);
        memset(&sc, 0, sizeof(SpoolControl));
        memset(&OneRNCFG, 0, sizeof(OneRoomNetCfg));
        sc.RNCfg = &OneRNCFG;
        sc.RNCfg->NetConfigs[ignet_push_share] = DuplicateOneGenericCfgLine(pCfgLine);
-       sc.Users[ignet_push_share] = NewStrBufPlain(NULL,
-                                                   StrLength(pCfgLine->Value[0]) +
-                                                   StrLength(pCfgLine->Value[1]) + 10
-       );
+       sc.Users[ignet_push_share] = NewStrBufPlain(NULL, (StrLength(pCfgLine->Value[0]) + StrLength(pCfgLine->Value[1]) + 10) );
        StrBufAppendBuf(sc.Users[ignet_push_share], pCfgLine->Value[0], 0);
        StrBufAppendBufPlain(sc.Users[ignet_push_share], HKEY(","), 0);
        StrBufAppendBuf(sc.Users[ignet_push_share], pCfgLine->Value[1], 0);
        CalcListID(&sc);
-
        end_critical_section(S_NETCONFIGS);
 
        sc.working_ignetcfg = CtdlLoadIgNetCfg();
@@ -154,14 +156,13 @@ int network_sync_to(char *target_node, long len)
        num_spooled = CtdlForEachMessage(MSGS_ALL, 0L, NULL, NULL, NULL, network_spool_msg, &sc);
 
        /* Concise cleanup because we know there's only one node in the sc */
-       DeleteGenericCfgLine(NULL/*TODO*/, &sc.RNCfg->NetConfigs[ignet_push_share]);
+       DeleteGenericCfgLine(NULL, &sc.RNCfg->NetConfigs[ignet_push_share]);
 
        DeleteHash(&sc.working_ignetcfg);
        DeleteHash(&sc.the_netmap);
        free_spoolcontrol_struct_members(&sc);
 
-       QN_syslog(LOG_NOTICE, "Synchronized %d messages to <%s>\n",
-                 num_spooled, target_node);
+       syslog(LOG_NOTICE, "network: synchronized %d messages to <%s>", num_spooled, target_node);
        return(num_spooled);
 }
 
@@ -182,8 +183,7 @@ void cmd_nsyn(char *argbuf) {
                cprintf("%d Spooled %d messages.\n", CIT_OK, num_spooled);
        }
        else {
-               cprintf("%d No such room/node share exists.\n",
-                       ERROR + ROOM_NOT_FOUND);
+               cprintf("%d No such room/node share exists.\n", ERROR + ROOM_NOT_FOUND);
        }
 }
 
@@ -193,11 +193,14 @@ RoomProcList *CreateRoomProcListEntry(struct ctdlroom *qrbuf, OneRoomNetCfg *One
        struct RoomProcList *ptr;
 
        ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
-       if (ptr == NULL) return NULL;
+       if (ptr == NULL) {
+               return NULL;
+       }
 
        ptr->namelen = strlen(qrbuf->QRname);
-       if (ptr->namelen > ROOMNAMELEN)
+       if (ptr->namelen > ROOMNAMELEN) {
                ptr->namelen = ROOMNAMELEN - 1;
+       }
 
        memcpy (ptr->name, qrbuf->QRname, ptr->namelen);
        ptr->name[ptr->namelen] = '\0';
@@ -210,8 +213,6 @@ RoomProcList *CreateRoomProcListEntry(struct ctdlroom *qrbuf, OneRoomNetCfg *One
 
        ptr->lcname[ptr->namelen] = '\0';
        ptr->key = hashlittle(ptr->lcname, ptr->namelen, 9872345);
-       ptr->lastsent = OneRNCFG->lastsent;
-       ptr->OneRNCfg = OneRNCFG;
        return ptr;
 }
 
@@ -223,8 +224,9 @@ void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data, OneRoom
        struct RoomProcList *ptr;
        roomlists *RP = (roomlists*) data;
 
-       if (!HaveSpoolConfig(OneRNCfg))
+       if (!HaveSpoolConfig(OneRNCfg)) {
                return;
+       }
 
        ptr = CreateRoomProcListEntry(qrbuf, OneRNCfg);
 
@@ -238,30 +240,36 @@ void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data, OneRoom
 /*
  * Batch up and send all outbound traffic from the current room
  */
-int network_room_handler (struct ctdlroom *qrbuf)
+int network_room_handler(struct ctdlroom *qrbuf)
 {
        struct RoomProcList *ptr;
-       OneRoomNetCfgRNCfg;
+       OneRoomNetCfg *RNCfg;
 
-       if (qrbuf->QRdefaultview == VIEW_QUEUE)
+       if (qrbuf->QRdefaultview == VIEW_QUEUE) {
                return 1;
+       }
 
        RNCfg = CtdlGetNetCfgForRoom(qrbuf->QRnumber);
-       if (RNCfg == NULL)
+       if (RNCfg == NULL) {
                return 1;
+       }
 
-       if (!HaveSpoolConfig(RNCfg))
+       if (!HaveSpoolConfig(RNCfg)) {
+               FreeRoomNetworkStruct(&RNCfg);
                return 1;
+       }
 
        ptr = CreateRoomProcListEntry(qrbuf, RNCfg);
-       if (ptr == NULL)
+       if (ptr == NULL) {
+               FreeRoomNetworkStruct(&RNCfg);
                return 1;
+       }
 
-       ptr->OneRNCfg = NULL;
        begin_critical_section(S_RPLIST);
        ptr->next = rplist;
        rplist = ptr;
        end_critical_section(S_RPLIST);
+       FreeRoomNetworkStruct(&RNCfg);
        return 1;
 }
 
@@ -293,7 +301,6 @@ void destroy_network_queue_room_locked (void)
  */
 void network_do_queue(void)
 {
-       struct CitContext *CCC = CC;
        static time_t last_run = 0L;
        int full_processing = 1;
        HashList *working_ignetcfg;
@@ -310,9 +317,7 @@ void network_do_queue(void)
        if ( (time(NULL) - last_run) < CtdlGetConfigLong("c_net_freq") )
        {
                full_processing = 0;
-               syslog(LOG_DEBUG, "Network full processing in %ld seconds.\n",
-                      CtdlGetConfigLong("c_net_freq") - (time(NULL)- last_run)
-               );
+               syslog(LOG_DEBUG, "network: full processing in %ld seconds.", CtdlGetConfigLong("c_net_freq") - (time(NULL)- last_run));
        }
 
        become_session(&networker_spool_CC);
@@ -320,34 +325,30 @@ void network_do_queue(void)
        RL.rplist = rplist;
        rplist = NULL;
        end_critical_section(S_RPLIST);
-///TODO hm, check whether we have a config at all here?
+
+       // TODO hm, check whether we have a config at all here?
        /* Load the IGnet Configuration into memory */
        working_ignetcfg = CtdlLoadIgNetCfg();
 
        /*
         * Load the network map and filter list into memory.
         */
-       if (!server_shutting_down)
+       if (!server_shutting_down) {
                the_netmap = CtdlReadNetworkMap();
-#if 0
-       /* filterlist isn't supported anymore
-       if (!server_shutting_down)
-               load_network_filter_list();
-       */
-#endif
+       }
 
        /* 
         * Go ahead and run the queue
         */
        if (full_processing && !server_shutting_down) {
-               QNM_syslog(LOG_DEBUG, "network: loading outbound queue");
-               CtdlForEachNetCfgRoom(network_queue_interesting_rooms, &RL, maxRoomNetCfg);
+               syslog(LOG_DEBUG, "network: loading outbound queue");
+               CtdlForEachNetCfgRoom(network_queue_interesting_rooms, &RL);
        }
 
        if ((RL.rplist != NULL) && (!server_shutting_down)) {
                RoomProcList *ptr, *cmp;
                ptr = RL.rplist;
-               QNM_syslog(LOG_DEBUG, "network: running outbound queue");
+               syslog(LOG_DEBUG, "network: running outbound queue");
                while (ptr != NULL && !server_shutting_down) {
                        
                        cmp = ptr->next;
@@ -364,10 +365,7 @@ void network_do_queue(void)
                        }
 
                        if (ptr->namelen > 0) {
-                               InspectQueuedRoom(&sc,
-                                                 ptr, 
-                                                 working_ignetcfg,
-                                                 the_netmap);
+                               InspectQueuedRoom(&sc, ptr, working_ignetcfg, the_netmap);
                        }
                        ptr = ptr->next;
                }
@@ -388,15 +386,6 @@ void network_do_queue(void)
                free_spoolcontrol_struct(&pSC);
                pSC = sc;
        }
-       /* If there is anything in the inbound queue, process it */
-       if (!server_shutting_down) {
-               network_do_spoolin(working_ignetcfg, 
-                                  the_netmap,
-                                  &netmap_changed);
-       }
-
-       /* Free the filter list in memory */
-       free_netfilter_list();
 
        /* Save the network map back to disk */
        if (netmap_changed) {
@@ -406,7 +395,7 @@ void network_do_queue(void)
                free(pMapStr);
        }
 
-       /* combine singe message files into one spool entry per remote node. */
+       /* combine single message files into one spool entry per remote node. */
        network_consolidate_spoolout(working_ignetcfg, the_netmap);
 
        /* shut down. */
@@ -415,23 +404,15 @@ void network_do_queue(void)
 
        DeleteHash(&working_ignetcfg);
 
-       QNM_syslog(LOG_DEBUG, "network: queue run completed");
+       syslog(LOG_DEBUG, "network: queue run completed");
 
        if (full_processing) {
                last_run = time(NULL);
        }
        destroy_network_queue_room(RL.rplist);
-       // SaveChangedConfigs();        // FIXME FOOFOO SAVE CHANGED THIS AACACACACCKK
-
 }
 
 
-
-
-
-
-
-
 void network_logout_hook(void)
 {
        CitContext *CCC = MyContext();
@@ -444,6 +425,8 @@ void network_logout_hook(void)
                CCC->net_node[0] = '\0';
        }
 }
+
+
 void network_cleanup_function(void)
 {
        struct CitContext *CCC = CC;
@@ -455,97 +438,16 @@ void network_cleanup_function(void)
 }
 
 
-int ignet_aftersave(struct CtdlMessage *msg,
-                   recptypes *recps)   /* recipients (if mail) */
-{
-       /* For IGnet mail, we have to save a new copy into the spooler for
-        * each recipient, with the R and D fields set to the recipient and
-        * destination-node.  This has two ugly side effects: all other
-        * recipients end up being unlisted in this recipient's copy of the
-        * message, and it has to deliver multiple messages to the same
-        * node.  We'll revisit this again in a year or so when everyone has
-        * a network spool receiver that can handle the new style messages.
-        */
-       if ((recps != NULL) && (recps->num_ignet > 0))
-       {
-               char *recipient;
-               int rv = 0;
-               struct ser_ret smr;
-               FILE *network_fp = NULL;
-               char submit_filename[128];
-               static int seqnum = 1;
-               int i;
-               char *hold_R, *hold_D, *RBuf, *DBuf;
-               long hrlen, hdlen, rblen, dblen, count, rlen;
-               CitContext *CCC = MyContext();
-
-               CM_GetAsField(msg, eRecipient, &hold_R, &hrlen);;
-               CM_GetAsField(msg, eDestination, &hold_D, &hdlen);;
-
-               count = num_tokens(recps->recp_ignet, '|');
-               rlen = strlen(recps->recp_ignet);
-               recipient = malloc(rlen + 1);
-               RBuf = malloc(rlen + 1);
-               DBuf = malloc(rlen + 1);
-               for (i=0; i<count; ++i) {
-                       extract_token(recipient, recps->recp_ignet, i,
-                                     '|', rlen + 1);
-
-                       rblen = extract_token(RBuf, recipient, 0, '@', rlen + 1);
-                       dblen = extract_token(DBuf, recipient, 1, '@', rlen + 1);
-               
-                       CM_SetAsField(msg, eRecipient, &RBuf, rblen);;
-                       CM_SetAsField(msg, eDestination, &DBuf, dblen);;
-                       CtdlSerializeMessage(&smr, msg);
-                       if (smr.len > 0) {
-                               snprintf(submit_filename, sizeof submit_filename,
-                                        "%s/netmail.%04lx.%04x.%04x",
-                                        ctdl_netin_dir,
-                                        (long) getpid(),
-                                        CCC->cs_pid,
-                                        ++seqnum);
-
-                               network_fp = fopen(submit_filename, "wb+");
-                               if (network_fp != NULL) {
-                                       rv = fwrite(smr.ser, smr.len, 1, network_fp);
-                                       if (rv == -1) {
-                                               MSG_syslog(LOG_EMERG, "CtdlSubmitMsg(): Couldn't write network spool file: %s\n",
-                                                          strerror(errno));
-                                       }
-                                       fclose(network_fp);
-                               }
-                               free(smr.ser);
-                       }
-                       CM_GetAsField(msg, eRecipient, &RBuf, &rblen);;
-                       CM_GetAsField(msg, eDestination, &DBuf, &dblen);;
-               }
-               free(RBuf);
-               free(DBuf);
-               free(recipient);
-               CM_SetAsField(msg, eRecipient, &hold_R, hrlen);
-               CM_SetAsField(msg, eDestination, &hold_D, hdlen);
-               return 1;
-       }
-       return 0;
-}
-
 /*
  * Module entry point
  */
 
-void SetNetQDebugEnabled(const int n)
-{
-       NetQDebugEnabled = n;
-}
 
 CTDL_MODULE_INIT(network)
 {
        if (!threading)
        {
-               CtdlRegisterMessageHook(ignet_aftersave, EVT_AFTERSAVE);
-
                CtdlFillSystemContext(&networker_spool_CC, "CitNetSpool");
-               CtdlRegisterDebugFlagHook(HKEY("networkqueue"), SetNetQDebugEnabled, &NetQDebugEnabled);
                CtdlRegisterSessionHook(network_cleanup_function, EVT_STOP, PRIO_STOP + 30);
                 CtdlRegisterSessionHook(network_logout_hook, EVT_LOGOUT, PRIO_LOGOUT + 10);
                CtdlRegisterProtoHook(cmd_nsyn, "NSYN", "Synchronize room to node");