use an Enum for the cm_fields vector instead of nameless chars
[citadel.git] / citadel / modules / network / serv_network.c
index 41eae0940e499bf0a4787c11b19bf604bbe8193b..1f0a680ca2a6437aad5b1ef35ab5a2e8a2b94d7b 100644 (file)
@@ -88,7 +88,6 @@ extern uint32_t hashlittle( const void *key, size_t length, uint32_t initval);
 
 typedef struct __roomlists {
        RoomProcList *rplist;
-       HashList *RoomsInterestedIn;
 }roomlists;
 /*
  * When we do network processing, it's accomplished in two passes; one to
@@ -97,39 +96,6 @@ typedef struct __roomlists {
  */
 struct RoomProcList *rplist = NULL;
 
-int GetNetworkedRoomNumbers(const char *DirName, HashList *DirList)
-{
-       DIR *filedir = NULL;
-       struct dirent *d;
-       struct dirent *filedir_entry;
-       long RoomNR;
-       long Count = 0;
-               
-       filedir = opendir (DirName);
-       if (filedir == NULL) {
-               return 0;
-       }
-
-       d = (struct dirent *)malloc(offsetof(struct dirent, d_name) + PATH_MAX + 1);
-       if (d == NULL) {
-               return 0;
-       }
-
-       while ((readdir_r(filedir, d, &filedir_entry) == 0) &&
-              (filedir_entry != NULL))
-       {
-               RoomNR = atol(filedir_entry->d_name);
-               if (RoomNR != 0) {
-                       Count++;
-                       Put(DirList, LKEY(RoomNR), &Count, reference_free_handler);
-               }
-       }
-       free(d);
-       closedir(filedir);
-       return Count;
-}
-
-
 
 
 /*
@@ -140,45 +106,40 @@ int GetNetworkedRoomNumbers(const char *DirName, HashList *DirList)
  */
 int network_usetable(struct CtdlMessage *msg)
 {
+       StrBuf *msgid;
        struct CitContext *CCC = CC;
-       char msgid[SIZ];
-       struct cdbdata *cdbut;
-       struct UseTable ut;
+       time_t now;
 
        /* Bail out if we can't generate a message ID */
-       if (msg == NULL) {
-               return(0);
-       }
-       if (msg->cm_fields['I'] == NULL) {
-               return(0);
-       }
-       if (IsEmptyStr(msg->cm_fields['I'])) {
+       if ((msg == NULL) || (msg->cm_fields[emessageId] == NULL) || (IsEmptyStr(msg->cm_fields[emessageId])))
+       {
                return(0);
        }
 
        /* Generate the message ID */
-       strcpy(msgid, msg->cm_fields['I']);
-       if (haschar(msgid, '@') == 0) {
-               strcat(msgid, "@");
-               if (msg->cm_fields['N'] != NULL) {
-                       strcat(msgid, msg->cm_fields['N']);
+       msgid = NewStrBufPlain(msg->cm_fields[emessageId], -1);
+       if (haschar(ChrPtr(msgid), '@') == 0) {
+               StrBufAppendBufPlain(msgid, HKEY("@"), 0);
+               if (msg->cm_fields[eNodeName] != NULL) {
+                       StrBufAppendBufPlain(msgid, msg->cm_fields[eNodeName], -1, 0);
                }
                else {
+                       FreeStrBuf(&msgid);
                        return(0);
                }
        }
-
-       cdbut = cdb_fetch(CDB_USETABLE, msgid, strlen(msgid));
-       if (cdbut != NULL) {
-               cdb_free(cdbut);
-               QN_syslog(LOG_DEBUG, "network_usetable() : we already have %s\n", msgid);
+       now = time(NULL);
+       if (CheckIfAlreadySeen("Networker Import",
+                              msgid,
+                              now, 0,
+                              eCheckUpdate,
+                              CCC->cs_pid, 0) != 0)
+       {
+               FreeStrBuf(&msgid);
                return(1);
        }
+       FreeStrBuf(&msgid);
 
-       /* If we got to this point, it's unique: add it. */
-       strcpy(ut.ut_msgid, msgid);
-       ut.ut_timestamp = time(NULL);
-       cdb_store(CDB_USETABLE, msgid, strlen(msgid), &ut, sizeof(struct UseTable) );
        return(0);
 }
 
@@ -192,24 +153,25 @@ int network_usetable(struct CtdlMessage *msg)
 int network_sync_to(char *target_node, long len)
 {
        struct CitContext *CCC = CC;
-       const OneRoomNetCfg *OneRNCFG;
+       OneRoomNetCfg OneRNCFG;
+       OneRoomNetCfg *pRNCFG;
        const RoomNetCfgLine *pCfgLine;
        SpoolControl sc;
        int num_spooled = 0;
 
        /* Grab the configuration line we're looking for */
        begin_critical_section(S_NETCONFIGS);
-       OneRNCFG = CtdlGetNetCfgForRoom(CCC->room.QRnumber);
-       if ((OneRNCFG == NULL) ||
-           (OneRNCFG->NetConfigs[ignet_push_share] == NULL))
+       pRNCFG = CtdlGetNetCfgForRoom(CCC->room.QRnumber);
+       if ((pRNCFG == NULL) ||
+           (pRNCFG->NetConfigs[ignet_push_share] == NULL))
        {
                return -1;
        }
 
-       pCfgLine = OneRNCFG->NetConfigs[ignet_push_share];
+       pCfgLine = pRNCFG->NetConfigs[ignet_push_share];
        while (pCfgLine != NULL)
        {
-               if (strcmp(ChrPtr(pCfgLine->Value[0]), target_node))
+               if (!strcmp(ChrPtr(pCfgLine->Value[0]), target_node))
                        break;
                pCfgLine = pCfgLine->next;
        }
@@ -217,9 +179,25 @@ int network_sync_to(char *target_node, long len)
        {
                return -1;
        }
-       memset(&sc, 0, sizeof(SpoolControl));
 
-       sc.NetConfigs[ignet_push_share] = DuplicateOneGenericCfgLine(pCfgLine);
+       memset(&sc, 0, sizeof(SpoolControl));
+       memset(&OneRNCFG, 0, sizeof(OneRoomNetCfg));
+       sc.RNCfg = &OneRNCFG;
+       sc.RNCfg->NetConfigs[ignet_push_share] = DuplicateOneGenericCfgLine(pCfgLine);
+       sc.Users[ignet_push_share] = NewStrBufPlain(NULL,
+                                                   StrLength(pCfgLine->Value[0]) +
+                                                   StrLength(pCfgLine->Value[1]) + 10);
+       StrBufAppendBuf(sc.Users[ignet_push_share], 
+                       pCfgLine->Value[0],
+                       0);
+       StrBufAppendBufPlain(sc.Users[ignet_push_share], 
+                            HKEY(","),
+                            0);
+
+       StrBufAppendBuf(sc.Users[ignet_push_share], 
+                       pCfgLine->Value[1],
+                       0);
+       CalcListID(&sc);
 
        end_critical_section(S_NETCONFIGS);
 
@@ -231,10 +209,11 @@ int network_sync_to(char *target_node, long len)
                network_spool_msg, &sc);
 
        /* Concise cleanup because we know there's only one node in the sc */
-       DeleteGenericCfgLine(NULL/*TODO*/, &sc.NetConfigs[ignet_push_share]);
+       DeleteGenericCfgLine(NULL/*TODO*/, &sc.RNCfg->NetConfigs[ignet_push_share]);
 
        DeleteHash(&sc.working_ignetcfg);
        DeleteHash(&sc.the_netmap);
+       free_spoolcontrol_struct_members(&sc);
 
        QN_syslog(LOG_NOTICE, "Synchronized %d messages to <%s>\n",
                  num_spooled, target_node);
@@ -263,23 +242,13 @@ void cmd_nsyn(char *argbuf) {
        }
 }
 
-
-
-/*
- * Batch up and send all outbound traffic from the current room
- */
-void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data) {
+RoomProcList *CreateRoomProcListEntry(struct ctdlroom *qrbuf, OneRoomNetCfg *OneRNCFG)
+{
        int i;
        struct RoomProcList *ptr;
-       long QRNum = qrbuf->QRnumber;
-       void *v;
-       roomlists *RP = (roomlists*) data;
-
-       if (!GetHash(RP->RoomsInterestedIn, LKEY(QRNum), &v))
-               return;
 
        ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
-       if (ptr == NULL) return;
+       if (ptr == NULL) return NULL;
 
        ptr->namelen = strlen(qrbuf->QRname);
        if (ptr->namelen > ROOMNAMELEN)
@@ -296,41 +265,59 @@ void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data) {
 
        ptr->lcname[ptr->namelen] = '\0';
        ptr->key = hashlittle(ptr->lcname, ptr->namelen, 9872345);
-       ptr->next = RP->rplist;
-       RP->rplist = ptr;
+       ptr->lastsent = OneRNCFG->lastsent;
+       ptr->OneRNCfg = OneRNCFG;
+       return ptr;
 }
 
 /*
  * Batch up and send all outbound traffic from the current room
  */
-void network_queue_room(struct ctdlroom *qrbuf, void *data) {
-       int i;
+void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data, OneRoomNetCfg *OneRNCfg)
+{
        struct RoomProcList *ptr;
+       roomlists *RP = (roomlists*) data;
 
-       if (qrbuf->QRdefaultview == VIEW_QUEUE)
+       if (!HaveSpoolConfig(OneRNCfg))
                return;
-       ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
-       if (ptr == NULL) return;
-
-       ptr->namelen = strlen(qrbuf->QRname);
-       if (ptr->namelen > ROOMNAMELEN)
-               ptr->namelen = ROOMNAMELEN - 1;
 
-       memcpy (ptr->name, qrbuf->QRname, ptr->namelen);
-       ptr->name[ptr->namelen] = '\0';
-       ptr->QRNum = qrbuf->QRnumber;
+       ptr = CreateRoomProcListEntry(qrbuf, OneRNCfg);
 
-       for (i = 0; i < ptr->namelen; i++)
+       if (ptr != NULL)
        {
-               ptr->lcname[i] = tolower(ptr->name[i]);
+               ptr->next = RP->rplist;
+               RP->rplist = ptr;
        }
-       ptr->lcname[ptr->namelen] = '\0';
-       ptr->key = hashlittle(ptr->lcname, ptr->namelen, 9872345);
+}
+
+/*
+ * Batch up and send all outbound traffic from the current room
+ */
+int network_room_handler (struct ctdlroom *qrbuf)
+{
+       struct RoomProcList *ptr;
+       OneRoomNetCfg* RNCfg;
+
+       if (qrbuf->QRdefaultview == VIEW_QUEUE)
+               return 1;
+
+       RNCfg = CtdlGetNetCfgForRoom(qrbuf->QRnumber);
+       if (RNCfg == NULL)
+               return 1;
 
+       if (!HaveSpoolConfig(RNCfg))
+               return 1;
+
+       ptr = CreateRoomProcListEntry(qrbuf, RNCfg);
+       if (ptr == NULL)
+               return 1;
+
+       ptr->OneRNCfg = NULL;
        begin_critical_section(S_RPLIST);
        ptr->next = rplist;
        rplist = ptr;
        end_critical_section(S_RPLIST);
+       return 1;
 }
 
 void destroy_network_queue_room(RoomProcList *rplist)
@@ -379,64 +366,64 @@ void network_bounce(struct CtdlMessage *msg, char *reason)
        /* 
         * Give it a fresh message ID
         */
-       if (msg->cm_fields['I'] != NULL) {
-               free(msg->cm_fields['I']);
+       if (msg->cm_fields[emessageId] != NULL) {
+               free(msg->cm_fields[emessageId]);
        }
        snprintf(buf, sizeof buf, "%ld.%04lx.%04x@%s",
                (long)time(NULL), (long)getpid(), ++serialnum, config.c_fqdn);
-       msg->cm_fields['I'] = strdup(buf);
+       msg->cm_fields[emessageId] = strdup(buf);
 
        /*
         * FIXME ... right now we're just sending a bounce; we really want to
         * include the text of the bounced message.
         */
-       if (msg->cm_fields['M'] != NULL) {
-               free(msg->cm_fields['M']);
+       if (msg->cm_fields[eMesageText] != NULL) {
+               free(msg->cm_fields[eMesageText]);
        }
-       msg->cm_fields['M'] = strdup(reason);
+       msg->cm_fields[eMesageText] = strdup(reason);
        msg->cm_format_type = 0;
 
        /*
         * Turn the message around
         */
-       if (msg->cm_fields['R'] == NULL) {
-               free(msg->cm_fields['R']);
+       if (msg->cm_fields[eRecipient] == NULL) {
+               free(msg->cm_fields[eRecipient]);
        }
 
-       if (msg->cm_fields['D'] == NULL) {
-               free(msg->cm_fields['D']);
+       if (msg->cm_fields[eDestination] == NULL) {
+               free(msg->cm_fields[eDestination]);
        }
 
        snprintf(recipient, sizeof recipient, "%s@%s",
-               msg->cm_fields['A'], msg->cm_fields['N']);
+               msg->cm_fields[eAuthor], msg->cm_fields[eNodeName]);
 
-       if (msg->cm_fields['A'] == NULL) {
-               free(msg->cm_fields['A']);
+       if (msg->cm_fields[eAuthor] == NULL) {
+               free(msg->cm_fields[eAuthor]);
        }
 
-       if (msg->cm_fields['N'] == NULL) {
-               free(msg->cm_fields['N']);
+       if (msg->cm_fields[eNodeName] == NULL) {
+               free(msg->cm_fields[eNodeName]);
        }
 
-       if (msg->cm_fields['U'] == NULL) {
-               free(msg->cm_fields['U']);
+       if (msg->cm_fields[eMsgSubject] == NULL) {
+               free(msg->cm_fields[eMsgSubject]);
        }
 
-       msg->cm_fields['A'] = strdup(BOUNCESOURCE);
-       msg->cm_fields['N'] = strdup(config.c_nodename);
-       msg->cm_fields['U'] = strdup("Delivery Status Notification (Failure)");
+       msg->cm_fields[eAuthor] = strdup(BOUNCESOURCE);
+       msg->cm_fields[eNodeName] = strdup(config.c_nodename);
+       msg->cm_fields[eMsgSubject] = strdup("Delivery Status Notification (Failure)");
 
        /* prepend our node to the path */
-       if (msg->cm_fields['P'] != NULL) {
-               oldpath = msg->cm_fields['P'];
-               msg->cm_fields['P'] = NULL;
+       if (msg->cm_fields[eMessagePath] != NULL) {
+               oldpath = msg->cm_fields[eMessagePath];
+               msg->cm_fields[eMessagePath] = NULL;
        }
        else {
                oldpath = strdup("unknown_user");
        }
        size = strlen(oldpath) + SIZ;
-       msg->cm_fields['P'] = malloc(size);
-       snprintf(msg->cm_fields['P'], size, "%s!%s", config.c_nodename, oldpath);
+       msg->cm_fields[eMessagePath] = malloc(size);
+       snprintf(msg->cm_fields[eMessagePath], size, "%s!%s", config.c_nodename, oldpath);
        free(oldpath);
 
        /* Now submit the message */
@@ -464,10 +451,6 @@ void network_bounce(struct CtdlMessage *msg, char *reason)
 
 
 
-
-
-
-
 /*
  * network_do_queue()
  * 
@@ -476,13 +459,14 @@ void network_bounce(struct CtdlMessage *msg, char *reason)
 void network_do_queue(void)
 {
        struct CitContext *CCC = CC;
-       static int doing_queue = 0;
        static time_t last_run = 0L;
        int full_processing = 1;
        HashList *working_ignetcfg;
        HashList *the_netmap = NULL;
        int netmap_changed = 0;
        roomlists RL;
+       SpoolControl *sc = NULL;
+       SpoolControl *pSC;
 
        /*
         * Run the full set of processing tasks no more frequently
@@ -495,32 +479,12 @@ void network_do_queue(void)
                );
        }
 
-       /*
-        * This is a simple concurrency check to make sure only one queue run
-        * is done at a time.  We could do this with a mutex, but since we
-        * don't really require extremely fine granularity here, we'll do it
-        * with a static variable instead.
-        */
-       if (doing_queue) {
-               return;
-       }
-       doing_queue = 1;
-
        become_session(&networker_spool_CC);
        begin_critical_section(S_RPLIST);
        RL.rplist = rplist;
        rplist = NULL;
        end_critical_section(S_RPLIST);
-
-       RL.RoomsInterestedIn = NewHash(1, lFlathash);
-       if (full_processing &&
-           (GetNetworkedRoomNumbers(ctdl_netcfg_dir, RL.RoomsInterestedIn)==0))
-       {
-               doing_queue = 0;
-               DeleteHash(&RL.RoomsInterestedIn);
-               if (RL.rplist == NULL)
-                       return;
-       }
+///TODO hm, check whether we have a config at all here?
        /* Load the IGnet Configuration into memory */
        working_ignetcfg = CtdlLoadIgNetCfg();
 
@@ -529,15 +493,19 @@ void network_do_queue(void)
         */
        if (!server_shutting_down)
                the_netmap = CtdlReadNetworkMap();
+#if 0
+       /* filterlist isn't supported anymore
        if (!server_shutting_down)
                load_network_filter_list();
+       */
+#endif
 
        /* 
         * Go ahead and run the queue
         */
        if (full_processing && !server_shutting_down) {
                QNM_syslog(LOG_DEBUG, "network: loading outbound queue");
-               CtdlForEachRoom(network_queue_interesting_rooms, &RL);
+               CtdlForEachNetCfgRoom(network_queue_interesting_rooms, &RL, maxRoomNetCfg);
        }
 
        if ((RL.rplist != NULL) && (!server_shutting_down)) {
@@ -547,7 +515,7 @@ void network_do_queue(void)
                while (ptr != NULL && !server_shutting_down) {
                        
                        cmp = ptr->next;
-
+                       /* filter duplicates from the list... */
                        while (cmp != NULL) {
                                if ((cmp->namelen > 0) &&
                                    (cmp->key == ptr->key) &&
@@ -560,14 +528,30 @@ void network_do_queue(void)
                        }
 
                        if (ptr->namelen > 0) {
-                               network_spoolout_room(ptr, 
-                                                     working_ignetcfg,
-                                                     the_netmap);
+                               InspectQueuedRoom(&sc,
+                                                 ptr, 
+                                                 working_ignetcfg,
+                                                 the_netmap);
                        }
                        ptr = ptr->next;
                }
        }
 
+
+       pSC = sc;
+       while (pSC != NULL)
+       {
+               network_spoolout_room(pSC);
+               pSC = pSC->next;
+       }
+
+       pSC = sc;
+       while (pSC != NULL)
+       {
+               sc = pSC->next;
+               free_spoolcontrol_struct(&pSC);
+               pSC = sc;
+       }
        /* If there is anything in the inbound queue, process it */
        if (!server_shutting_down) {
                network_do_spoolin(working_ignetcfg, 
@@ -581,7 +565,9 @@ void network_do_queue(void)
        /* Save the network map back to disk */
        if (netmap_changed) {
                StrBuf *MapStr = CtdlSerializeNetworkMap(the_netmap);
-               CtdlPutSysConfig(IGNETMAP, SmashStrBuf(&MapStr));
+               char *pMapStr = SmashStrBuf(&MapStr);
+               CtdlPutSysConfig(IGNETMAP, pMapStr);
+               free(pMapStr);
        }
 
        /* combine singe message files into one spool entry per remote node. */
@@ -598,19 +584,14 @@ void network_do_queue(void)
        if (full_processing) {
                last_run = time(NULL);
        }
-       DeleteHash(&RL.RoomsInterestedIn);
        destroy_network_queue_room(RL.rplist);
-       doing_queue = 0;
+       SaveChangedConfigs();
+
 }
 
 
 
 
-int network_room_handler (struct ctdlroom *room)
-{
-       network_queue_room(room, NULL);
-       return 0;
-}