More removal of $Id$ tags
[citadel.git] / citadel / modules / network / serv_network.c
index 2ac84e3afa3159e38b2be0e2bd6e1d130f6400df..840fb68e0226fc327e35fffc60c4e3cfe57185ce 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * $Id$ 
- *
  * This module handles shared rooms, inter-Citadel mail, and outbound
  * mailing list processing.
  *
@@ -68,7 +66,6 @@
 #include "support.h"
 #include "config.h"
 #include "user_ops.h"
-#include "policy.h"
 #include "database.h"
 #include "msgbase.h"
 #include "internet_addressing.h"
@@ -648,7 +645,19 @@ void network_spool_msg(long msgnum, void *userdata) {
                 */
                msg = CtdlFetchMessage(msgnum, 1);
                if (msg != NULL) {
-
+                       if (msg->cm_fields['V'] == NULL){
+                               /* local message, no enVelope */
+                               StrBuf *Buf;
+                               Buf = NewStrBuf();
+                               StrBufAppendBufPlain(Buf, msg->cm_fields['O'], -1, 0);
+                               StrBufAppendBufPlain(Buf, HKEY("@"), 0);
+                               StrBufAppendBufPlain(Buf, config.c_fqdn, -1, 0);
+                               
+                               msg->cm_fields['K'] = SmashStrBuf(&Buf);
+                       }
+                       else {
+                               msg->cm_fields['K'] = strdup (msg->cm_fields['V']);
+                       }
                        /* Set the 'List-ID' header */
                        if (msg->cm_fields['L'] != NULL) {
                                free(msg->cm_fields['L']);
@@ -716,20 +725,17 @@ void network_spool_msg(long msgnum, void *userdata) {
                                fprintf(sc->digestfp, "Subject: %s\n", msg->cm_fields['U']);
                        }
 
-                       CC->redirect_buffer = malloc(SIZ);
-                       CC->redirect_len = 0;
-                       CC->redirect_alloc = SIZ;
-
+                       CC->redirect_buffer = NewStrBufPlain(NULL, SIZ);
+                       
                        safestrncpy(CC->preferred_formats, "text/plain", sizeof CC->preferred_formats);
                        CtdlOutputPreLoadedMsg(msg, MT_CITADEL, HEADERS_NONE, 0, 0, 0);
 
-                       striplt(CC->redirect_buffer);
-                       fprintf(sc->digestfp, "\n%s\n", CC->redirect_buffer);
+                       StrBufTrim(CC->redirect_buffer);
+                       fwrite(HKEY("\n"), 1, sc->digestfp);
+                       fwrite(SKEY(CC->redirect_buffer), 1, sc->digestfp);
+                       fwrite(HKEY("\n"), 1, sc->digestfp);
 
-                       free(CC->redirect_buffer);
-                       CC->redirect_buffer = NULL;
-                       CC->redirect_len = 0;
-                       CC->redirect_alloc = 0;
+                       FreeStrBuf(&CC->redirect_buffer);
 
                        sc->num_msgs_spooled += 1;
                        free(msg);
@@ -878,10 +884,13 @@ void network_spool_msg(long msgnum, void *userdata) {
                                serialize_message(&sermsg, msg);
                                if (sermsg.len > 0) {
 
-                                       /* write it to the spool file */
-                                       snprintf(filename, sizeof filename,"%s/%s",
-                                                       ctdl_netout_dir,
-                                                       mptr->remote_nodename);
+                                       /* write it to a spool file */
+                                       snprintf(filename, sizeof filename,"%s/%s@%lx%x",
+                                               ctdl_netout_dir,
+                                               mptr->remote_nodename,
+                                               time(NULL),
+                                               rand()
+                                       );
                                        CtdlLogPrintf(CTDL_DEBUG, "Appending to %s\n", filename);
                                        fp = fopen(filename, "ab");
                                        if (fp != NULL) {
@@ -939,31 +948,31 @@ int read_spoolcontrol_file(SpoolControl **scc, char *filename)
                buf[strlen(buf)-1] = 0;
 
                extract_token(instr, buf, 0, '|', sizeof instr);
-               if (!strcasecmp(instr, "lastsent")) {
+               if (!strcasecmp(instr, strof(lastsent))) {
                        sc->lastsent = extract_long(buf, 1);
                }
-               else if (!strcasecmp(instr, "listrecp")) {
+               else if (!strcasecmp(instr, strof(listrecp))) {
                        nptr = (namelist *)
                                malloc(sizeof(namelist));
                        nptr->next = sc->listrecps;
                        extract_token(nptr->name, buf, 1, '|', sizeof nptr->name);
                        sc->listrecps = nptr;
                }
-               else if (!strcasecmp(instr, "participate")) {
+               else if (!strcasecmp(instr, strof(participate))) {
                        nptr = (namelist *)
                                malloc(sizeof(namelist));
                        nptr->next = sc->participates;
                        extract_token(nptr->name, buf, 1, '|', sizeof nptr->name);
                        sc->participates = nptr;
                }
-               else if (!strcasecmp(instr, "digestrecp")) {
+               else if (!strcasecmp(instr, strof(digestrecp))) {
                        nptr = (namelist *)
                                malloc(sizeof(namelist));
                        nptr->next = sc->digestrecps;
                        extract_token(nptr->name, buf, 1, '|', sizeof nptr->name);
                        sc->digestrecps = nptr;
                }
-               else if (!strcasecmp(instr, "ignet_push_share")) {
+               else if (!strcasecmp(instr, strof(ignet_push_share))) {
                        extract_token(nodename, buf, 1, '|', sizeof nodename);
                        extract_token(roomname, buf, 2, '|', sizeof roomname);
                        mptr = (maplist *) malloc(sizeof(maplist));
@@ -978,12 +987,12 @@ int read_spoolcontrol_file(SpoolControl **scc, char *filename)
                         * timestamps.
                         */
                        skipthisline = 0;
-                       if (!strncasecmp(buf, "subpending|", 11)) {
+                       if (!strncasecmp(buf, strof(subpending)"|", 11)) {
                                if (time(NULL) - extract_long(buf, 4) > EXP) {
                                        skipthisline = 1;
                                }
                        }
-                       if (!strncasecmp(buf, "unsubpending|", 13)) {
+                       if (!strncasecmp(buf, strof(unsubpending)"|", 13)) {
                                if (time(NULL) - extract_long(buf, 3) > EXP) {
                                        skipthisline = 1;
                                }
@@ -1541,15 +1550,17 @@ void network_process_buffer(char *buffer, long size) {
                                        strcpy(nexthop, msg->cm_fields['D']);
                                }
                                snprintf(filename, 
-                                                sizeof filename,
-                                                "%s/%s",
-                                                ctdl_netout_dir,
-                                                nexthop);
+                                       sizeof filename,
+                                       "%s/%s@%lx%x",
+                                       ctdl_netout_dir,
+                                       nexthop,
+                                       time(NULL),
+                                       rand()
+                               );
                                CtdlLogPrintf(CTDL_DEBUG, "Appending to %s\n", filename);
                                fp = fopen(filename, "ab");
                                if (fp != NULL) {
-                                       fwrite(sermsg.ser,
-                                               sermsg.len, 1, fp);
+                                       fwrite(sermsg.ser, sermsg.len, 1, fp);
                                        fclose(fp);
                                }
                                else {
@@ -1736,10 +1747,11 @@ void network_do_spoolin(void) {
        while (d = readdir(dp), d != NULL) {
                if ((strcmp(d->d_name, ".")) && (strcmp(d->d_name, ".."))) {
                        snprintf(filename, 
-                                        sizeof filename,
-                                        "%s/%s",
-                                        ctdl_netin_dir,
-                                        d->d_name);
+                               sizeof filename,
+                               "%s/%s",
+                               ctdl_netin_dir,
+                               d->d_name
+                       );
                        network_process_file(filename);
                }
        }
@@ -1748,15 +1760,60 @@ void network_do_spoolin(void) {
 }
 
 /*
- * Delete any files in the outbound queue that were intended
- * to be sent to nodes which no longer exist.
+ * Step 1: consolidate files in the outbound queue into one file per neighbor node
+ * Step 2: delete any files in the outbound queue that were for neighbors who no longer exist.
  */
-void network_purge_spoolout(void) {
+void network_consolidate_spoolout(void) {
        DIR *dp;
        struct dirent *d;
        char filename[PATH_MAX];
+       char cmd[PATH_MAX];
        char nexthop[256];
        int i;
+       char *ptr;
+
+       /* Step 1: consolidate files in the outbound queue into one file per neighbor node */
+       dp = opendir(ctdl_netout_dir);
+       if (dp == NULL) return;
+       while (d = readdir(dp), d != NULL) {
+               if (
+                       (strcmp(d->d_name, "."))
+                       && (strcmp(d->d_name, ".."))
+                       && (strchr(d->d_name, '@') != NULL)
+               ) {
+                       safestrncpy(nexthop, d->d_name, sizeof nexthop);
+                       ptr = strchr(nexthop, '@');
+                       if (ptr) *ptr = 0;
+       
+                       snprintf(filename, 
+                               sizeof filename,
+                               "%s/%s",
+                               ctdl_netout_dir,
+                               d->d_name
+                       );
+       
+                       CtdlLogPrintf(CTDL_DEBUG, "Consolidate %s to %s\n", filename, nexthop);
+                       if (network_talking_to(nexthop, NTT_CHECK)) {
+                               CtdlLogPrintf(CTDL_DEBUG,
+                                       "Currently online with %s - skipping for now\n",
+                                       nexthop
+                               );
+                       }
+                       else {
+                               network_talking_to(nexthop, NTT_ADD);
+                               snprintf(cmd, sizeof cmd, "/bin/cat %s >>%s/%s && /bin/rm -f %s",
+                                       filename,
+                                       ctdl_netout_dir, nexthop,
+                                       filename
+                               );
+                               system(cmd);
+                               network_talking_to(nexthop, NTT_REMOVE);
+                       }
+               }
+       }
+       closedir(dp);
+
+       /* Step 2: delete any files in the outbound queue that were for neighbors who no longer exist */
 
        dp = opendir(ctdl_netout_dir);
        if (dp == NULL) return;
@@ -1764,11 +1821,15 @@ void network_purge_spoolout(void) {
        while (d = readdir(dp), d != NULL) {
                if (!strcmp(d->d_name, ".") || !strcmp(d->d_name, ".."))
                        continue;
+               ptr = strchr(d->d_name, '@');
+               if (d != NULL)
+                       continue;
                snprintf(filename, 
-                                sizeof filename,
-                                "%s/%s",
-                                ctdl_netout_dir,
-                                d->d_name);
+                       sizeof filename,
+                       "%s/%s",
+                       ctdl_netout_dir,
+                       d->d_name
+               );
 
                strcpy(nexthop, "");
                i = is_valid_node(nexthop, NULL, d->d_name);
@@ -1787,18 +1848,33 @@ void network_purge_spoolout(void) {
  * receive network spool from the remote system
  */
 void receive_spool(int *sock, char *remote_nodename) {
-       size_t siz;
        long download_len = 0L;
        long bytes_received = 0L;
-       long bytes_copied = 0L;
        char buf[SIZ];
        static char pbuf[IGNET_PACKET_SIZE];
        char tempfilename[PATH_MAX];
-       char filename[PATH_MAX];
+       char permfilename[PATH_MAX];
        long plen;
-       FILE *fp, *newfp;
+       FILE *fp;
+
+       snprintf(tempfilename, 
+               sizeof tempfilename, 
+               "%s/%s.%lx%x",
+               ctdl_nettmp_dir,
+               remote_nodename, 
+               time(NULL),
+               rand()
+       );
+
+       snprintf(permfilename, 
+               sizeof permfilename, 
+               "%s/%s.%lx%x",
+               ctdl_netin_dir,
+               remote_nodename, 
+               time(NULL),
+               rand()
+       );
 
-       CtdlMakeTempFileName(tempfilename, sizeof tempfilename);
        if (sock_puts(sock, "NDOP") < 0) return;
        if (sock_getln(sock, buf, sizeof buf) < 0) return;
        CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
@@ -1807,63 +1883,70 @@ void receive_spool(int *sock, char *remote_nodename) {
        }
        download_len = extract_long(&buf[4], 0);
 
-       bytes_received = 0L;
-       fp = fopen(tempfilename, "w");
-       if (fp == NULL) {
-               CtdlLogPrintf(CTDL_CRIT, "cannot open download file locally: %s\n",
-                       strerror(errno));
-               return;
-       }
-
-       while (bytes_received < download_len) {
-               /**
-                * If shutting down we can exit here and unlink the temp file.
-                * this shouldn't loose us any messages.
-                */
-               if (CtdlThreadCheckStop())
-               {
-                       fclose(fp);
-                       unlink(tempfilename);
+       if (download_len>0) {
+               bytes_received = 0L;
+               fp = fopen(tempfilename, "w");
+               if (fp == NULL) {
+                       CtdlLogPrintf(CTDL_CRIT, "cannot open download file locally: %s\n",
+                                     strerror(errno));
                        return;
                }
-               snprintf(buf, sizeof buf, "READ %ld|%ld",
-                       bytes_received,
-                    ((download_len - bytes_received > IGNET_PACKET_SIZE)
-                ? IGNET_PACKET_SIZE : (download_len - bytes_received)));
-               if (sock_puts(sock, buf) < 0) {
-                       fclose(fp);
-                       unlink(tempfilename);
-                       return;
-               }
-               if (sock_getln(sock, buf, sizeof buf) < 0) {
-                       fclose(fp);
-                       unlink(tempfilename);
-                       return;
-               }
-               if (buf[0] == '6') {
-                       plen = extract_long(&buf[4], 0);
-                       if (sock_read(sock, pbuf, plen, 1) < 0) {
+
+               CtdlLogPrintf(CTDL_DEBUG, "For this download we are expecting %d bytes\n", download_len);
+               while (bytes_received < download_len) {
+                       /*
+                        * If shutting down we can exit here and unlink the temp file.
+                        * this shouldn't loose us any messages.
+                        */
+                       if (CtdlThreadCheckStop())
+                       {
+                               fclose(fp);
+                               unlink(tempfilename);
+                               return;
+                       }
+                       snprintf(buf, sizeof buf, "READ %ld|%ld",
+                                bytes_received,
+                                ((download_len - bytes_received > IGNET_PACKET_SIZE)
+                                 ? IGNET_PACKET_SIZE : (download_len - bytes_received)));
+                       
+                       if (sock_puts(sock, buf) < 0) {
                                fclose(fp);
                                unlink(tempfilename);
                                return;
                        }
-                       fwrite((char *) pbuf, plen, 1, fp);
-                       bytes_received = bytes_received + plen;
+                       if (sock_getln(sock, buf, sizeof buf) < 0) {
+                               fclose(fp);
+                               unlink(tempfilename);
+                               return;
+                       }
+                       
+                       if (buf[0] == '6') {
+                               plen = extract_long(&buf[4], 0);
+                               if (sock_read(sock, pbuf, plen, 1) < 0) {
+                                       fclose(fp);
+                                       unlink(tempfilename);
+                                       return;
+                               }
+                               fwrite((char *) pbuf, plen, 1, fp);
+                               bytes_received = bytes_received + plen;
+                       }
                }
-       }
 
-       fclose(fp);
-       /** Last chance for shutdown exit */
+               fclose(fp);
+       }
+       /* Last chance for shutdown exit */
        if (CtdlThreadCheckStop())
        {
                unlink(tempfilename);
                return;
        }
+
        if (sock_puts(sock, "CLOS") < 0) {
                unlink(tempfilename);
                return;
        }
-       /**
+
+       /*
         * From here on we must complete or messages will get lost
         */
        if (sock_getln(sock, buf, sizeof buf) < 0) {
@@ -1875,36 +1958,13 @@ void receive_spool(int *sock, char *remote_nodename) {
        }
        CtdlLogPrintf(CTDL_DEBUG, "%s\n", buf);
        
-       /* Now copy the temp file to its permanent location.
-        * (We copy instead of link because they may be on different filesystems)
+       /* Now move the temp file to its permanent location.
         */
-       begin_critical_section(S_NETSPOOL);
-       snprintf(filename, 
-                        sizeof filename, 
-                        "%s/%s.%ld",
-                        ctdl_netin_dir,
-                        remote_nodename, 
-                        (long) getpid()
-       );
-       fp = fopen(tempfilename, "r");
-       if (fp != NULL) {
-               newfp = fopen(filename, "w");
-               if (newfp != NULL) {
-                       bytes_copied = 0L;
-                       while (bytes_copied < download_len) {
-                               plen = download_len - bytes_copied;
-                               if (plen > sizeof buf) {
-                                       plen = sizeof buf;
-                               }
-                               siz = fread(buf, plen, 1, fp);
-                               fwrite(buf, plen, 1, newfp);
-                               bytes_copied += plen;
-                       }
-                       fclose(newfp);
-               }
-               fclose(fp);
+       if (link(tempfilename, permfilename) != 0) {
+               CtdlLogPrintf(CTDL_ALERT, "Could not link %s to %s: %s\n",
+                       tempfilename, permfilename, strerror(errno)
+               );
        }
-       end_critical_section(S_NETSPOOL);
        unlink(tempfilename);
 }
 
@@ -1930,14 +1990,14 @@ void transmit_spool(int *sock, char *remote_nodename)
        }
 
        snprintf(sfname, sizeof sfname, 
-                        "%s/%s",
-                        ctdl_netout_dir,
-                        remote_nodename);
+               "%s/%s",
+               ctdl_netout_dir,
+               remote_nodename
+       );
        fd = open(sfname, O_RDONLY);
        if (fd < 0) {
                if (errno != ENOENT) {
-                       CtdlLogPrintf(CTDL_CRIT, "cannot open upload file locally: %s\n",
-                               strerror(errno));
+                       CtdlLogPrintf(CTDL_CRIT, "cannot open %s: %s\n", sfname, strerror(errno));
                }
                return;
        }
@@ -1945,7 +2005,7 @@ void transmit_spool(int *sock, char *remote_nodename)
        while (plen = (long) read(fd, pbuf, IGNET_PACKET_SIZE), plen > 0L) {
                bytes_to_write = plen;
                while (bytes_to_write > 0L) {
-                       /** Exit if shutting down */
+                       /* Exit if shutting down */
                        if (CtdlThreadCheckStop())
                        {
                                close(fd);
@@ -1963,8 +2023,7 @@ void transmit_spool(int *sock, char *remote_nodename)
                        }
                        thisblock = atol(&buf[4]);
                        if (buf[0] == '7') {
-                               if (sock_write(sock, pbuf,
-                                  (int) thisblock) < 0) {
+                               if (sock_write(sock, pbuf, (int) thisblock) < 0) {
                                        close(fd);
                                        return;
                                }
@@ -1978,17 +2037,18 @@ void transmit_spool(int *sock, char *remote_nodename)
 
 ABORTUPL:
        close(fd);
-       /** Last chance for shutdown exit */
+
+       /* Last chance for shutdown exit */
        if(CtdlThreadCheckStop())
                return;
                
        if (sock_puts(sock, "UCLS 1") < 0) return;
-       /**
+
+       /*
         * From here on we must complete or messages will get lost
         */
        if (sock_getln(sock, buf, sizeof buf) < 0) return;
-       CtdlLogPrintf(CTDL_NOTICE, "Sent %ld octets to <%s>\n",
-                       bytes_written, remote_nodename);
+       CtdlLogPrintf(CTDL_NOTICE, "Sent %ld octets to <%s>\n", bytes_written, remote_nodename);
        CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
        if (buf[0] == '2') {
                CtdlLogPrintf(CTDL_DEBUG, "Removing <%s>\n", sfname);
@@ -2006,12 +2066,14 @@ void network_poll_node(char *node, char *secret, char *host, char *port) {
        char buf[SIZ];
        char err_buf[SIZ];
        char connected_to[SIZ];
+       CitContext *CCC=CC;
 
        if (network_talking_to(node, NTT_CHECK)) return;
        network_talking_to(node, NTT_ADD);
+       CtdlLogPrintf(CTDL_DEBUG, "network: polling <%s>\n", node);
        CtdlLogPrintf(CTDL_NOTICE, "Connecting to <%s> at %s:%s\n", node, host, port);
 
-       sock = sock_connect(host, port, "tcp");
+       sock = sock_connect(host, port);
        if (sock < 0) {
                CtdlLogPrintf(CTDL_ERR, "Could not connect: %s\n", strerror(errno));
                network_talking_to(node, NTT_REMOVE);
@@ -2019,6 +2081,9 @@ void network_poll_node(char *node, char *secret, char *host, char *port) {
        }
        
        CtdlLogPrintf(CTDL_DEBUG, "Connected!\n");
+       CCC->sReadBuf = NewStrBuf();
+       CCC->sMigrateBuf = NewStrBuf();
+       CCC->sPos = NULL;
 
        /* Read the server greeting */
        if (sock_getln(&sock, buf, sizeof buf) < 0) goto bail;
@@ -2028,7 +2093,10 @@ void network_poll_node(char *node, char *secret, char *host, char *port) {
        extract_token (connected_to, buf, 1, ' ', sizeof connected_to);
        if (strcmp(connected_to, node))
        {
-               snprintf (err_buf, sizeof(err_buf), "Connected to node \"%s\" but I was expecting to connect to node \"%s\".", connected_to, node);
+               snprintf(err_buf, sizeof(err_buf),
+                       "Connected to node \"%s\" but I was expecting to connect to node \"%s\".",
+                       connected_to, node
+               );
                CtdlLogPrintf(CTDL_ERR, "%s\n", err_buf);
                CtdlAideMessage(err_buf, "Network error");
        }
@@ -2039,7 +2107,9 @@ void network_poll_node(char *node, char *secret, char *host, char *port) {
                if (sock_puts(&sock, buf) <0) goto bail;
                if (sock_getln(&sock, buf, sizeof buf) < 0) goto bail;
                CtdlLogPrintf(CTDL_DEBUG, ">%s\n", buf);
-               if (buf[0] != '2') goto bail;
+               if (buf[0] != '2') {
+                       goto bail;
+               }
        
                /* At this point we are authenticated. */
                if (!CtdlThreadCheckStop())
@@ -2050,6 +2120,8 @@ void network_poll_node(char *node, char *secret, char *host, char *port) {
 
        sock_puts(&sock, "QUIT");
 bail:  
+       FreeStrBuf(&CCC->sReadBuf);
+       FreeStrBuf(&CCC->sMigrateBuf);
        if (sock != -1)
                sock_close(sock);
        network_talking_to(node, NTT_REMOVE);
@@ -2073,7 +2145,7 @@ void network_poll_other_citadel_nodes(int full_poll) {
        char spoolfile[256];
 
        if (working_ignetcfg == NULL) {
-               CtdlLogPrintf(CTDL_DEBUG, "No nodes defined - not polling\n");
+               CtdlLogPrintf(CTDL_DEBUG, "network: no neighbor nodes are configured - not polling.\n");
                return;
        }
 
@@ -2091,10 +2163,11 @@ void network_poll_other_citadel_nodes(int full_poll) {
                        poll = full_poll;
                        if (poll == 0) {
                                snprintf(spoolfile, 
-                                                sizeof spoolfile,
-                                                "%s/%s",
-                                                ctdl_netout_dir, 
-                                                node);
+                                        sizeof spoolfile,
+                                        "%s/%s",
+                                        ctdl_netout_dir, 
+                                        node
+                               );
                                if (access(spoolfile, R_OK) == 0) {
                                        poll = 1;
                                }
@@ -2122,6 +2195,10 @@ void create_spool_dirs(void) {
                CtdlLogPrintf(CTDL_EMERG, "unable to create directory [%s]: %s", ctdl_netin_dir, strerror(errno));
        if (chown(ctdl_netin_dir, CTDLUID, (-1)) != 0)
                CtdlLogPrintf(CTDL_EMERG, "unable to set the access rights for [%s]: %s", ctdl_netin_dir, strerror(errno));
+       if ((mkdir(ctdl_nettmp_dir, 0700) != 0) && (errno != EEXIST))
+               CtdlLogPrintf(CTDL_EMERG, "unable to create directory [%s]: %s", ctdl_nettmp_dir, strerror(errno));
+       if (chown(ctdl_nettmp_dir, CTDLUID, (-1)) != 0)
+               CtdlLogPrintf(CTDL_EMERG, "unable to set the access rights for [%s]: %s", ctdl_nettmp_dir, strerror(errno));
        if ((mkdir(ctdl_netout_dir, 0700) != 0) && (errno != EEXIST))
                CtdlLogPrintf(CTDL_EMERG, "unable to create directory [%s]: %s", ctdl_netout_dir, strerror(errno));
        if (chown(ctdl_netout_dir, CTDLUID, (-1)) != 0)
@@ -2153,7 +2230,9 @@ void *network_do_queue(void *args) {
         */
        if ( (time(NULL) - last_run) < config.c_net_freq ) {
                full_processing = 0;
-               CtdlLogPrintf(CTDL_DEBUG, "Network full processing in %ld seconds.\n", config.c_net_freq - (time(NULL)- last_run));
+               CtdlLogPrintf(CTDL_DEBUG, "Network full processing in %ld seconds.\n",
+                       config.c_net_freq - (time(NULL)- last_run)
+               );
        }
 
        /*
@@ -2162,7 +2241,10 @@ void *network_do_queue(void *args) {
         * don't really require extremely fine granularity here, we'll do it
         * with a static variable instead.
         */
-       if (doing_queue) return NULL;
+       if (doing_queue) {
+               CtdlClearSystemContext();
+               return NULL;
+       }
        doing_queue = 1;
 
        /* Load the IGnet Configuration into memory */
@@ -2216,8 +2298,9 @@ void *network_do_queue(void *args) {
        }
 
        /* If there is anything in the inbound queue, process it */
-       if (!CtdlThreadCheckStop())
+       if (!CtdlThreadCheckStop()) {
                network_do_spoolin();
+       }
 
        /* Save the network map back to disk */
        write_network_map();
@@ -2226,7 +2309,7 @@ void *network_do_queue(void *args) {
        free_filter_list(filterlist);
        filterlist = NULL;
 
-       network_purge_spoolout();
+       network_consolidate_spoolout();
 
        CtdlLogPrintf(CTDL_DEBUG, "network: queue run completed\n");
 
@@ -2235,10 +2318,19 @@ void *network_do_queue(void *args) {
        }
 
        doing_queue = 0;
-       if (!CtdlThreadCheckStop()) // Only reschedule if system is not stopping
-               CtdlThreadSchedule("IGnet Network", CTDLTHREAD_BIGSTACK, network_do_queue, NULL, time(NULL) + 60);
-       else
+
+       /* Reschedule this task to happen again periodically, unless the thread system indicates
+        * that the server is shutting down.
+        */
+       if (!CtdlThreadCheckStop()) {
+               CtdlThreadSchedule("IGnet Network", CTDLTHREAD_BIGSTACK,
+                       network_do_queue, NULL, time(NULL) + 60
+               );
+       }
+       else {
                CtdlLogPrintf(CTDL_DEBUG, "network: Task STOPPED.\n");
+       }
+       CtdlClearSystemContext();
        return NULL;
 }
 
@@ -2261,12 +2353,6 @@ void cmd_netp(char *cmdbuf)
        extract_token(node, cmdbuf, 0, '|', sizeof node);
        extract_token(pass, cmdbuf, 1, '|', sizeof pass);
 
-       if (doing_queue) {
-               CtdlLogPrintf(CTDL_WARNING, "Network node <%s> refused - spooling\n", node);
-               cprintf("%d spooling - try again in a few minutes\n", ERROR + RESOURCE_BUSY);
-               return;
-       }
-
        /* load the IGnet Configuration to check node validity */
        load_working_ignetcfg();
        v = is_valid_node(nexthop, secret, node);
@@ -2333,5 +2419,5 @@ CTDL_MODULE_INIT(network)
        else
                CtdlThreadSchedule("IGnet Network", CTDLTHREAD_BIGSTACK, network_do_queue, NULL, 0);
        /* return our Subversion id for the Log */
-       return "$Id$";
+       return "network";
 }