Finished the code for XRDS/Yadis discovery of OP URL
[citadel.git] / citadel / modules / openid / serv_openid_rp.c
index a802a6c58da19210e2fbe3d45d01d0d251305de9..f757765ccf8f709d8fa2f3ccadb50563f7691cdc 100644 (file)
@@ -1,11 +1,13 @@
 /*
- * $Id$
- *
- * This is an implementation of OpenID 1.1 Relying Party support, in stateless mode.
+ * This is an implementation of OpenID 2.0 RELYING PARTY SUPPORT CURRENTLY B0RKEN AND BEING DEVEL0PZ0RED
+
+
+                       OPENID2 BRANCH -- NEEDS TO BE MERGEZ0RED !!!!!!111
+
  *
- * Copyright (c) 2007-2010 by the citadel.org team
+ * Copyright (c) 2007-2011 by the citadel.org team
  *
- * This program is free software; you can redistribute it and/or modify
+ * This program is open source software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
@@ -16,8 +18,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "sysdep.h"
 #include <string.h>
 #include <limits.h>
 #include <curl/curl.h>
+#include <expat.h>
 #include "ctdl_module.h"
 #include "config.h"
 #include "citserver.h"
 #include "user_ops.h"
 
 typedef struct _ctdl_openid {
-       StrBuf *claimed_id;
-       StrBuf *server;
+       StrBuf *op_url;                 /* OpenID Provider Endpoint URL */
+       StrBuf *claimed_id;             /* Claimed Identifier */
        int verified;
        HashList *sreg_keys;
 } ctdl_openid;
 
+enum {
+       openid_disco_none,
+       openid_disco_xrds,
+       openid_disco_html
+};
+
+
+
 void Free_ctdl_openid(ctdl_openid **FreeMe)
 {
-       if (*FreeMe == NULL)
+       if (*FreeMe == NULL) {
                return;
+       }
+       FreeStrBuf(&(*FreeMe)->op_url);
        FreeStrBuf(&(*FreeMe)->claimed_id);
-       FreeStrBuf(&(*FreeMe)->server);
        DeleteHash(&(*FreeMe)->sreg_keys);
        free(*FreeMe);
        *FreeMe = NULL;
@@ -76,7 +87,7 @@ void openid_cleanup_function(void) {
        struct CitContext *CCC = CC;    /* CachedCitContext - performance boost */
 
        if (CCC->openid_data != NULL) {
-               CtdlLogPrintf(CTDL_DEBUG, "Clearing OpenID session state\n");
+               syslog(LOG_DEBUG, "Clearing OpenID session state");
                Free_ctdl_openid((ctdl_openid **) &CCC->openid_data);
        }
 }
@@ -127,11 +138,11 @@ int attach_openid(struct ctdluser *who, StrBuf *claimed_id)
                cdb_free(cdboi);
 
                if (fetched_usernum == who->usernum) {
-                       CtdlLogPrintf(CTDL_INFO, "%s already associated; no action is taken\n", claimed_id);
+                       syslog(LOG_INFO, "%s already associated; no action is taken", ChrPtr(claimed_id));
                        return(0);
                }
                else {
-                       CtdlLogPrintf(CTDL_INFO, "%s already belongs to another user\n", claimed_id);
+                       syslog(LOG_INFO, "%s already belongs to another user", ChrPtr(claimed_id));
                        return(3);
                }
        }
@@ -150,7 +161,7 @@ int attach_openid(struct ctdluser *who, StrBuf *claimed_id)
        snprintf(buf, sizeof buf, "User <%s> (#%ld) has claimed the OpenID URL %s\n",
                 who->fullname, who->usernum, ChrPtr(claimed_id));
        CtdlAideMessage(buf, "OpenID claim");
-       CtdlLogPrintf(CTDL_INFO, "%s", buf);
+       syslog(LOG_INFO, "%s", buf);
        return(0);
 }
 
@@ -172,7 +183,6 @@ void openid_purge(struct ctdluser *usbuf) {
        keys = NewHash(1, NULL);
        if (!keys) return;
 
-
        cdb_rewind(CDB_OPENID);
        while (cdboi = cdb_next_item(CDB_OPENID), cdboi != NULL) {
                if (cdboi->len > sizeof(long)) {
@@ -190,7 +200,7 @@ void openid_purge(struct ctdluser *usbuf) {
        HashPos = GetNewHashPos(keys, 0);
        while (GetNextHashPos(keys, HashPos, &len, &Key, &Value)!=0)
        {
-               CtdlLogPrintf(CTDL_DEBUG, "Deleting associated OpenID <%s>\n", Value);
+               syslog(LOG_DEBUG, "Deleting associated OpenID <%s>", (char*)Value);
                cdb_delete(CDB_OPENID, Value, strlen(Value));
                /* note: don't free(Value) -- deleting the hash list will handle this for us */
        }
@@ -199,7 +209,6 @@ void openid_purge(struct ctdluser *usbuf) {
 }
 
 
-
 /*
  * List the OpenIDs associated with the currently logged in account
  */
@@ -369,8 +378,6 @@ void cmd_oidc(char *argbuf) {
 }
 
 
-
-
 /*
  * Detach an OpenID from the currently logged in account
  */
@@ -423,11 +430,11 @@ int openid_create_user_via_sreg(StrBuf *claimed_id, HashList *sreg_keys)
        if (CC->logged_in) return(3);
        if (!GetHash(sreg_keys, "sreg.nickname", 13, (void *) &desired_name)) return(4);
 
-       CtdlLogPrintf(CTDL_DEBUG, "The desired account name is <%s>\n", desired_name);
+       syslog(LOG_DEBUG, "The desired account name is <%s>", desired_name);
 
        len = cutuserkey(desired_name);
        if (!CtdlGetUser(&CC->user, desired_name)) {
-               CtdlLogPrintf(CTDL_DEBUG, "<%s> is already taken by another user.\n", desired_name);
+               syslog(LOG_DEBUG, "<%s> is already taken by another user.", desired_name);
                memset(&CC->user, 0, sizeof(struct ctdluser));
                return(5);
        }
@@ -487,7 +494,7 @@ int login_via_openid(StrBuf *claimed_id)
  */
 void extract_link(StrBuf *target_buf, const char *rel, long repllen, StrBuf *source_buf)
 {
-       int len, i;
+       int i;
        const char *ptr;
        const char *href_start = NULL;
        const char *href_end = NULL;
@@ -510,8 +517,6 @@ void extract_link(StrBuf *target_buf, const char *rel, long repllen, StrBuf *sou
                if (link_tag_end == NULL)
                        break;
                for (i=0; i < 1; i++ ){
-                       len = link_tag_end - link_tag_start;
-
                        rel_start = cbmstrcasestr(link_tag_start, "rel=");
                        if ((rel_start == NULL) ||
                            (rel_start > link_tag_end)) 
@@ -552,44 +557,31 @@ void extract_link(StrBuf *target_buf, const char *rel, long repllen, StrBuf *sou
 
 
 /*
- * Begin an HTTP fetch (returns number of bytes actually fetched, or -1 for error) using libcurl.
- *
- * If 'normalize_len' is nonzero, the caller is specifying the buffer size of 'url', and is
- * requesting that the effective (normalized) URL be copied back to it.
+ * Wrapper for curl_easy_init() that includes the options common to all calls
+ * used in this module. 
  */
-int fetch_http(StrBuf *url, StrBuf **target_buf)
-{
-       StrBuf *ReplyBuf;
+CURL *ctdl_openid_curl_easy_init(char *errmsg) {
        CURL *curl;
-       CURLcode res;
-       char errmsg[1024] = "";
-       char *effective_url = NULL;
-
-       if (StrLength(url) <=0 ) return(-1);
-       ReplyBuf = *target_buf = NewStrBuf ();
-       if (ReplyBuf == 0) return(-1);
 
        curl = curl_easy_init();
        if (!curl) {
-               CtdlLogPrintf(CTDL_ALERT, "Unable to initialize libcurl.\n");
-               return(-1);
+               return(curl);
        }
 
-       curl_easy_setopt(curl, CURLOPT_URL, ChrPtr(url));
        curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0);
        curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0);
 
-       curl_easy_setopt(curl, CURLOPT_WRITEDATA, ReplyBuf);
-       curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlFillStrBuf_callback);
-
-       curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errmsg);
+       if (errmsg) {
+               curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errmsg);
+       }
        curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1);
 #ifdef CURLOPT_HTTP_CONTENT_DECODING
        curl_easy_setopt(curl, CURLOPT_HTTP_CONTENT_DECODING, 1);
        curl_easy_setopt(curl, CURLOPT_ENCODING, "");
 #endif
        curl_easy_setopt(curl, CURLOPT_USERAGENT, CITADEL);
-       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 180);           /* die after 180 seconds */
+       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 30);            /* die after 30 seconds */
+
        if (
                (!IsEmptyStr(config.c_ip_addr))
                && (strcmp(config.c_ip_addr, "*"))
@@ -598,15 +590,259 @@ int fetch_http(StrBuf *url, StrBuf **target_buf)
        ) {
                curl_easy_setopt(curl, CURLOPT_INTERFACE, config.c_ip_addr);
        }
-       res = curl_easy_perform(curl);
-       if (res) {
-               CtdlLogPrintf(CTDL_DEBUG, "fetch_http() libcurl error %d: %s\n", res, errmsg);
+
+       return(curl);
+}
+
+
+struct xrds {
+       StrBuf *CharData;
+       int nesting_level;
+       int in_xrd;
+       int current_service_priority;
+       int selected_service_priority;
+       StrBuf *current_service_uri;
+       StrBuf *selected_service_uri;
+       int current_service_is_oid2auth;
+};
+
+
+void xrds_xml_start(void *data, const char *supplied_el, const char **attr) {
+       struct xrds *xrds = (struct xrds *) data;
+       int i;
+
+       ++xrds->nesting_level;
+
+       if (!strcasecmp(supplied_el, "XRD")) {
+               ++xrds->in_xrd;
        }
-       curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url);
-       StrBufPlain(url, effective_url, -1);
-       
+
+       else if (!strcasecmp(supplied_el, "service")) {
+               xrds->current_service_priority = 0;
+               xrds->current_service_is_oid2auth = 0;
+               for (i=0; attr[i] != NULL; i+=2) {
+                       if (!strcasecmp(attr[i], "priority")) {
+                               xrds->current_service_priority = atoi(attr[i+1]);
+                       }
+               }
+       }
+
+       FlushStrBuf(xrds->CharData);
+}
+
+
+void xrds_xml_end(void *data, const char *supplied_el) {
+       struct xrds *xrds = (struct xrds *) data;
+
+       --xrds->nesting_level;
+
+       if (!strcasecmp(supplied_el, "XRD")) {
+               --xrds->in_xrd;
+       }
+
+       else if (!strcasecmp(supplied_el, "type")) {
+               if (    (xrds->in_xrd)
+                       && (!strcasecmp(ChrPtr(xrds->CharData), "http://specs.openid.net/auth/2.0/server"))
+               ) {
+                       xrds->current_service_is_oid2auth = 1;
+               }
+       }
+
+       else if (!strcasecmp(supplied_el, "uri")) {
+               if (xrds->in_xrd) {
+                       FlushStrBuf(xrds->current_service_uri);
+                       StrBufAppendBuf(xrds->current_service_uri, xrds->CharData, 0);
+               }
+       }
+
+       else if (!strcasecmp(supplied_el, "service")) {
+               if (    (xrds->in_xrd)
+                       && (xrds->current_service_priority < xrds->selected_service_priority)
+                       && (xrds->current_service_is_oid2auth)
+               ) {
+                       xrds->selected_service_priority = xrds->current_service_priority;
+                       FlushStrBuf(xrds->selected_service_uri);
+                       StrBufAppendBuf(xrds->selected_service_uri, xrds->current_service_uri, 0);
+               }
+
+       }
+
+       FlushStrBuf(xrds->CharData);
+}
+
+
+void xrds_xml_chardata(void *data, const XML_Char *s, int len) {
+       struct xrds *xrds = (struct xrds *) data;
+
+       StrBufAppendBufPlain (xrds->CharData, s, len, 0);
+}
+
+
+/*
+ * Parse an XRDS document.
+ * If an OpenID Provider URL is discovered, op_url to that value and return nonzero.
+ * If nothing useful happened, return 0.
+ */
+int parse_xrds_document(StrBuf *ReplyBuf) {
+       ctdl_openid *oiddata = (ctdl_openid *) CC->openid_data;
+       struct xrds xrds;
+       int return_value = 0;
+
+       //      syslog(LOG_DEBUG, "\033[32m --- XRDS DOCUMENT --- \n%s\033[0m", ChrPtr(ReplyBuf));
+
+       memset(&xrds, 0, sizeof (struct xrds));
+       xrds.selected_service_priority = INT_MAX;
+       xrds.CharData = NewStrBuf();
+       xrds.current_service_uri = NewStrBuf();
+       xrds.selected_service_uri = NewStrBuf();
+       XML_Parser xp = XML_ParserCreate(NULL);
+       if (xp) {
+               XML_SetUserData(xp, &xrds);
+               XML_SetElementHandler(xp, xrds_xml_start, xrds_xml_end);
+               XML_SetCharacterDataHandler(xp, xrds_xml_chardata);
+               XML_Parse(xp, ChrPtr(ReplyBuf), StrLength(ReplyBuf), 0);
+               XML_Parse(xp, "", 0, 1);
+               XML_ParserFree(xp);
+       }
+       else {
+               syslog(LOG_ALERT, "Cannot create XML parser");
+       }
+
+       if (xrds.selected_service_priority < INT_MAX) {
+               if (oiddata->op_url == NULL) {
+                       oiddata->op_url = NewStrBuf();
+               }
+               FlushStrBuf(oiddata->op_url);
+               StrBufAppendBuf(oiddata->op_url, xrds.selected_service_uri, 0);
+               return_value = openid_disco_xrds;
+       }
+
+       FreeStrBuf(&xrds.CharData);
+       FreeStrBuf(&xrds.current_service_uri);
+       FreeStrBuf(&xrds.selected_service_uri);
+
+       return(return_value);
+}
+
+
+
+/*
+ * Callback function for perform_openid2_discovery()
+ * We're interested in the X-XRDS-Location: header.
+ */
+size_t yadis_headerfunction(void *ptr, size_t size, size_t nmemb, void *userdata) {
+       char hdr[1024];
+       StrBuf **x_xrds_location = (StrBuf **) userdata;
+
+       memcpy(hdr, ptr, (size*nmemb));
+       hdr[size*nmemb] = 0;
+
+       if (!strncasecmp(hdr, "X-XRDS-Location:", 16)) {
+               *x_xrds_location = NewStrBufPlain(&hdr[16], ((size*nmemb)-16));
+               StrBufTrim(*x_xrds_location);
+       }
+
+       return(size * nmemb);
+}
+
+
+/* Attempt to perform Yadis discovery as specified in Yadis 1.0 section 6.2.5.
+ * 
+ * If Yadis fails, we then attempt HTML discovery using the same document.
+ *
+ * If successful, returns nonzero and calls parse_xrds_document() to act upon the received data.
+ * If fails, returns 0 and does nothing else.
+ */
+int perform_openid2_discovery(StrBuf *YadisURL) {
+       ctdl_openid *oiddata = (ctdl_openid *) CC->openid_data;
+       int docbytes = (-1);
+       StrBuf *ReplyBuf = NULL;
+       int return_value = 0;
+       CURL *curl;
+       CURLcode result;
+       char errmsg[1024] = "";
+       struct curl_slist *my_headers = NULL;
+       StrBuf *x_xrds_location = NULL;
+
+       if (!YadisURL) return(0);
+       syslog(LOG_DEBUG, "perform_openid2_discovery(%s)", ChrPtr(YadisURL));
+       if (StrLength(YadisURL) == 0) return(0);
+
+       ReplyBuf = NewStrBuf();
+       if (!ReplyBuf) return(0);
+
+       curl = ctdl_openid_curl_easy_init(errmsg);
+       if (!curl) return(0);
+
+       curl_easy_setopt(curl, CURLOPT_URL, ChrPtr(YadisURL));
+       curl_easy_setopt(curl, CURLOPT_WRITEDATA, ReplyBuf);
+       curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlFillStrBuf_callback);
+
+       my_headers = curl_slist_append(my_headers, "Accept:");  /* disable the default Accept: header */
+       my_headers = curl_slist_append(my_headers, "Accept: application/xrds+xml");
+       curl_easy_setopt(curl, CURLOPT_HTTPHEADER, my_headers);
+
+       curl_easy_setopt(curl, CURLOPT_WRITEHEADER, &x_xrds_location);
+       curl_easy_setopt(curl, CURLOPT_HEADERFUNCTION, yadis_headerfunction);
+
+       result = curl_easy_perform(curl);
+       if (result) {
+               syslog(LOG_DEBUG, "libcurl error %d: %s", result, errmsg);
+       }
+       curl_slist_free_all(my_headers);
        curl_easy_cleanup(curl);
-       return StrLength(ReplyBuf);
+       docbytes = StrLength(ReplyBuf);
+
+       /*
+        * The response from the server will be one of:
+        * 
+        * Option 1: An HTML document with a <head> element that includes a <meta> element with http-equiv
+        * attribute, X-XRDS-Location,
+        */
+       /* FIXME handle this somehow */
+
+       /*
+        * Option 2: HTTP response-headers that include an X-XRDS-Location response-header,
+        *           together with a document.
+        * Option 3: HTTP response-headers only, which MAY include an X-XRDS-Location response-header,
+        *           a contenttype response-header specifying MIME media type,
+        *           application/xrds+xml, or both.
+        *
+        * If the X-XRDS-Location header was delivered, we know about it at this point...
+        */
+       if (    (x_xrds_location)
+               && (strcmp(ChrPtr(x_xrds_location), ChrPtr(YadisURL)))
+       ) {
+               syslog(LOG_DEBUG, "X-XRDS-Location: %s ... recursing!", ChrPtr(x_xrds_location));
+               return_value = perform_openid2_discovery(x_xrds_location);
+               FreeStrBuf(&x_xrds_location);
+       }
+
+       /*
+        * Option 4: the returned web page may *be* an XRDS document.  Try to parse it.
+        */
+       else if (docbytes >= 0) {
+               return_value = parse_xrds_document(ReplyBuf);
+       }
+
+       /*
+        * Option 5: if all else fails, attempt HTML based discovery.
+        */
+       if (return_value == 0) {
+               syslog(LOG_DEBUG, "Attempting HTML discovery");
+               if (oiddata->op_url == NULL) {
+                       oiddata->op_url = NewStrBuf();
+               }
+               extract_link(oiddata->op_url, HKEY("openid2.provider"), ReplyBuf);
+               if (StrLength(oiddata->op_url) > 0) {
+                       return_value = openid_disco_html;
+               }
+       }
+
+       if (ReplyBuf != NULL) {
+               FreeStrBuf(&ReplyBuf);
+       }
+       return(return_value);
 }
 
 
@@ -614,6 +850,7 @@ int fetch_http(StrBuf *url, StrBuf **target_buf)
  * Setup an OpenID authentication
  */
 void cmd_oids(char *argbuf) {
+       struct CitContext *CCC = CC;    /* CachedCitContext - performance boost */
        const char *Pos = NULL;
        StrBuf *ArgBuf = NULL;
        StrBuf *ReplyBuf = NULL;
@@ -621,14 +858,14 @@ void cmd_oids(char *argbuf) {
        StrBuf *trust_root = NULL;
        StrBuf *openid_delegate = NULL;
        StrBuf *RedirectUrl = NULL;
-       int i;
-       struct CitContext *CCC = CC;    /* CachedCitContext - performance boost */
        ctdl_openid *oiddata;
+       int discovery_succeeded = 0;
 
        Free_ctdl_openid ((ctdl_openid**)&CCC->openid_data);
 
        CCC->openid_data = oiddata = malloc(sizeof(ctdl_openid));
        if (oiddata == NULL) {
+               syslog(LOG_ALERT, "malloc() failed: %s", strerror(errno));
                cprintf("%d malloc failed\n", ERROR + INTERNAL_ERROR);
                return;
        }
@@ -637,6 +874,7 @@ void cmd_oids(char *argbuf) {
 
        ArgBuf = NewStrBufPlain(argbuf, -1);
 
+       oiddata->verified = 0;
        oiddata->claimed_id = NewStrBufPlain(NULL, StrLength(ArgBuf));
        trust_root = NewStrBufPlain(NULL, StrLength(ArgBuf));
        return_to = NewStrBufPlain(NULL, StrLength(ArgBuf));
@@ -644,29 +882,33 @@ void cmd_oids(char *argbuf) {
        StrBufExtract_NextToken(oiddata->claimed_id, ArgBuf, &Pos, '|');
        StrBufExtract_NextToken(return_to, ArgBuf, &Pos, '|');
        StrBufExtract_NextToken(trust_root, ArgBuf, &Pos, '|');
-       
-       oiddata->verified = 0;
 
-       i = fetch_http(oiddata->claimed_id, &ReplyBuf);
-       CtdlLogPrintf(CTDL_DEBUG, "Normalized URL and Claimed ID is: %s\n", 
-                     ChrPtr(oiddata->claimed_id));
-       if ((StrLength(ReplyBuf) > 0) && (i > 0)) {
-
-               openid_delegate = NewStrBuf();
-               oiddata->server = NewStrBuf();
-               extract_link(oiddata->server, HKEY("openid.server"), ReplyBuf);
-               extract_link(openid_delegate, HKEY("openid.delegate"), ReplyBuf);
-
-               if (StrLength(oiddata->server) == 0) {
-                       cprintf("%d There is no OpenID identity provider at this URL.\n", ERROR);
-                       FreeStrBuf(&ArgBuf);
-                       FreeStrBuf(&ReplyBuf);
-                       FreeStrBuf(&return_to);
-                       FreeStrBuf(&trust_root);
-                       FreeStrBuf(&openid_delegate);
-                       FreeStrBuf(&RedirectUrl);
-                       return;
-               }
+       syslog(LOG_DEBUG, "User-Supplied Identifier is: %s", ChrPtr(oiddata->claimed_id));
+
+
+       /********** OpenID 2.0 section 7.3 - Discovery **********/
+
+       /* Section 7.3.1 says we have to attempt XRI based discovery.
+        * No one is using this, no one is asking for it, no one wants it.
+        * So we're not even going to bother attempting this mode.
+        */
+
+       /* Attempt section 7.3.2 (Yadis discovery) and section 7.3.3 (HTML discovery);
+        */
+       discovery_succeeded = perform_openid2_discovery(oiddata->claimed_id);
+
+       if (discovery_succeeded == 0) {
+               cprintf("%d There is no OpenID identity provider at this location.\n", ERROR);
+       }
+
+       else {
+               /*
+                * If we get to this point we are in possession of a valid OpenID Provider URL.
+                */
+               syslog(LOG_DEBUG, "OP URI '%s' discovered using method %d",
+                       ChrPtr(oiddata->claimed_id),
+                       discovery_succeeded
+               );
 
                /* Empty delegate is legal; we just use the openid_url instead */
                if (StrLength(openid_delegate) == 0) {
@@ -674,41 +916,30 @@ void cmd_oids(char *argbuf) {
                }
 
                /* Assemble a URL to which the user-agent will be redirected. */
-
-               RedirectUrl = NewStrBufDup(oiddata->server);
-
-               StrBufAppendBufPlain(RedirectUrl, HKEY("?openid.mode=checkid_setup"
-                                                      "&openid.identity="), 0);
+       
+               RedirectUrl = NewStrBufDup(oiddata->op_url);
+       
+               StrBufAppendBufPlain(RedirectUrl, HKEY("?openid.mode=checkid_setup&openid.identity="), 0);
                StrBufUrlescAppend(RedirectUrl, openid_delegate, NULL);
-
+       
                StrBufAppendBufPlain(RedirectUrl, HKEY("&openid.return_to="), 0);
                StrBufUrlescAppend(RedirectUrl, return_to, NULL);
-
+       
                StrBufAppendBufPlain(RedirectUrl, HKEY("&openid.trust_root="), 0);
                StrBufUrlescAppend(RedirectUrl, trust_root, NULL);
-
+       
                StrBufAppendBufPlain(RedirectUrl, HKEY("&openid.sreg.optional="), 0);
                StrBufUrlescAppend(RedirectUrl, NULL, "nickname,email,fullname,postcode,country,dob,gender");
-
+       
                cprintf("%d %s\n", CIT_OK, ChrPtr(RedirectUrl));
-               
-               FreeStrBuf(&ArgBuf);
-               FreeStrBuf(&ReplyBuf);
-               FreeStrBuf(&return_to);
-               FreeStrBuf(&trust_root);
-               FreeStrBuf(&openid_delegate);
-               FreeStrBuf(&RedirectUrl);
-
-               return;
        }
+       
        FreeStrBuf(&ArgBuf);
        FreeStrBuf(&ReplyBuf);
        FreeStrBuf(&return_to);
        FreeStrBuf(&trust_root);
        FreeStrBuf(&openid_delegate);
        FreeStrBuf(&RedirectUrl);
-
-       cprintf("%d Unable to fetch OpenID URL\n", ERROR);
 }
 
 
@@ -730,7 +961,7 @@ void cmd_oidf(char *argbuf) {
                cprintf("%d run OIDS first.\n", ERROR + INTERNAL_ERROR);
                return;
        }
-       if (StrLength(oiddata->server) == 0){
+       if (StrLength(oiddata->op_url) == 0){
                cprintf("%d need a remote server to authenticate against\n", ERROR + ILLEGAL_VALUE);
                return;
        }
@@ -746,13 +977,13 @@ void cmd_oidf(char *argbuf) {
                if (len < 0)
                        len = sizeof(thiskey) - 1;
                extract_token(thisdata, buf, 1, '|', sizeof thisdata);
-               CtdlLogPrintf(CTDL_DEBUG, "%s: [%d] %s\n", thiskey, strlen(thisdata), thisdata);
+               syslog(LOG_DEBUG, "%s: ["SIZE_T_FMT"] %s", thiskey, strlen(thisdata), thisdata);
                Put(keys, thiskey, len, strdup(thisdata), NULL);
        }
 
 
        /* Now that we have all of the parameters, we have to validate the signature against the server */
-       CtdlLogPrintf(CTDL_DEBUG, "About to validate the signature...\n");
+       syslog(LOG_DEBUG, "About to validate the signature...");
 
        CURL *curl;
        CURLcode res;
@@ -773,14 +1004,14 @@ void cmd_oidf(char *argbuf) {
                CURLFORM_COPYNAME,      "openid.mode",
                CURLFORM_COPYCONTENTS,  "check_authentication",
                CURLFORM_END);
-       CtdlLogPrintf(CTDL_DEBUG, "%25s : %s\n", "openid.mode", "check_authentication");
+       syslog(LOG_DEBUG, "%25s : %s", "openid.mode", "check_authentication");
 
        if (GetHash(keys, "assoc_handle", 12, (void *) &o_assoc_handle)) {
                curl_formadd(&formpost, &lastptr,
                        CURLFORM_COPYNAME,      "openid.assoc_handle",
                        CURLFORM_COPYCONTENTS,  o_assoc_handle,
                        CURLFORM_END);
-               CtdlLogPrintf(CTDL_DEBUG, "%25s : %s\n", "openid.assoc_handle", o_assoc_handle);
+               syslog(LOG_DEBUG, "%25s : %s", "openid.assoc_handle", o_assoc_handle);
        }
 
        if (GetHash(keys, "sig", 3, (void *) &o_sig)) {
@@ -788,7 +1019,7 @@ void cmd_oidf(char *argbuf) {
                        CURLFORM_COPYNAME,      "openid.sig",
                        CURLFORM_COPYCONTENTS,  o_sig,
                        CURLFORM_END);
-                       CtdlLogPrintf(CTDL_DEBUG, "%25s : %s\n", "openid.sig", o_sig);
+                       syslog(LOG_DEBUG, "%25s : %s", "openid.sig", o_sig);
        }
 
        if (GetHash(keys, "signed", 6, (void *) &o_signed)) {
@@ -796,7 +1027,7 @@ void cmd_oidf(char *argbuf) {
                        CURLFORM_COPYNAME,      "openid.signed",
                        CURLFORM_COPYCONTENTS,  o_signed,
                        CURLFORM_END);
-               CtdlLogPrintf(CTDL_DEBUG, "%25s : %s\n", "openid.signed", o_signed);
+               syslog(LOG_DEBUG, "%25s : %s", "openid.signed", o_signed);
 
                num_signed_values = num_tokens(o_signed, ',');
                for (i=0; i<num_signed_values; ++i) {
@@ -808,10 +1039,10 @@ void cmd_oidf(char *argbuf) {
                                                CURLFORM_COPYNAME,      k_o_keyname,
                                                CURLFORM_COPYCONTENTS,  k_value,
                                                CURLFORM_END);
-                                       CtdlLogPrintf(CTDL_DEBUG, "%25s : %s\n", k_o_keyname, k_value);
+                                       syslog(LOG_DEBUG, "%25s : %s", k_o_keyname, k_value);
                                }
                                else {
-                                       CtdlLogPrintf(CTDL_INFO, "OpenID: signed field '%s' is missing\n",
+                                       syslog(LOG_INFO, "OpenID: signed field '%s' is missing",
                                                k_keyname);
                                }
                        }
@@ -820,34 +1051,15 @@ void cmd_oidf(char *argbuf) {
        
        ReplyBuf = NewStrBuf();
 
-       curl = curl_easy_init();
-       curl_easy_setopt(curl, CURLOPT_URL, ChrPtr(oiddata->server));
-       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0);
-       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0);
-
+       curl = ctdl_openid_curl_easy_init(errmsg);
+       curl_easy_setopt(curl, CURLOPT_URL, ChrPtr(oiddata->op_url));
        curl_easy_setopt(curl, CURLOPT_WRITEDATA, ReplyBuf);
        curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlFillStrBuf_callback);
        curl_easy_setopt(curl, CURLOPT_HTTPPOST, formpost);
-       curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errmsg);
-       curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1);
-#ifdef CURLOPT_HTTP_CONTENT_DECODING
-       curl_easy_setopt(curl, CURLOPT_HTTP_CONTENT_DECODING, 1);
-       curl_easy_setopt(curl, CURLOPT_ENCODING, "");
-#endif
-       curl_easy_setopt(curl, CURLOPT_USERAGENT, CITADEL);
-       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 180);           /* die after 180 seconds */
-       if (
-               (!IsEmptyStr(config.c_ip_addr))
-               && (strcmp(config.c_ip_addr, "*"))
-               && (strcmp(config.c_ip_addr, "::"))
-               && (strcmp(config.c_ip_addr, "0.0.0.0"))
-       ) {
-               curl_easy_setopt(curl, CURLOPT_INTERFACE, config.c_ip_addr);
-       }
 
        res = curl_easy_perform(curl);
        if (res) {
-               CtdlLogPrintf(CTDL_DEBUG, "cmd_oidf() libcurl error %d: %s\n", res, errmsg);
+               syslog(LOG_DEBUG, "cmd_oidf() libcurl error %d: %s", res, errmsg);
        }
        curl_easy_cleanup(curl);
        curl_formfree(formpost);
@@ -857,7 +1069,7 @@ void cmd_oidf(char *argbuf) {
        }
        FreeStrBuf(&ReplyBuf);
 
-       CtdlLogPrintf(CTDL_DEBUG, "Authentication %s.\n", (oiddata->verified ? "succeeded" : "failed") );
+       syslog(LOG_DEBUG, "Authentication %s.", (oiddata->verified ? "succeeded" : "failed") );
 
        /* Respond to the client */
 
@@ -867,11 +1079,11 @@ void cmd_oidf(char *argbuf) {
                if (CC->logged_in) {
                        if (attach_openid(&CC->user, oiddata->claimed_id) == 0) {
                                cprintf("attach\n");
-                               CtdlLogPrintf(CTDL_DEBUG, "OpenID attach succeeded\n");
+                               syslog(LOG_DEBUG, "OpenID attach succeeded");
                        }
                        else {
                                cprintf("fail\n");
-                               CtdlLogPrintf(CTDL_DEBUG, "OpenID attach failed\n");
+                               syslog(LOG_DEBUG, "OpenID attach failed");
                        }
                }
 
@@ -888,7 +1100,7 @@ void cmd_oidf(char *argbuf) {
                        if (login_via_openid(oiddata->claimed_id) == 0) {
                                cprintf("authenticate\n%s\n%s\n", CC->user.fullname, CC->user.password);
                                logged_in_response();
-                               CtdlLogPrintf(CTDL_DEBUG, "Logged in using previously claimed OpenID\n");
+                               syslog(LOG_DEBUG, "Logged in using previously claimed OpenID");
                        }
 
                        /*
@@ -897,7 +1109,7 @@ void cmd_oidf(char *argbuf) {
                         */
                        else if (config.c_disable_newu) {
                                cprintf("fail\n");
-                               CtdlLogPrintf(CTDL_DEBUG, "Creating user failed due to local policy\n");
+                               syslog(LOG_DEBUG, "Creating user failed due to local policy");
                        }
 
                        /*
@@ -906,7 +1118,7 @@ void cmd_oidf(char *argbuf) {
                        else if (openid_create_user_via_sreg(oiddata->claimed_id, keys) == 0) {
                                cprintf("authenticate\n%s\n%s\n", CC->user.fullname, CC->user.password);
                                logged_in_response();
-                               CtdlLogPrintf(CTDL_DEBUG, "Successfully auto-created new user\n");
+                               syslog(LOG_DEBUG, "Successfully auto-created new user");
                        }
 
                        /*
@@ -923,7 +1135,7 @@ void cmd_oidf(char *argbuf) {
                                else {
                                        cprintf("\n");
                                }
-                               CtdlLogPrintf(CTDL_DEBUG, "The desired Simple Registration name is already taken.\n");
+                               syslog(LOG_DEBUG, "The desired Simple Registration name is already taken.");
                        }
                }
        }
@@ -966,8 +1178,9 @@ CTDL_MODULE_INIT(openid_rp)
                }
                CtdlRegisterSessionHook(openid_cleanup_function, EVT_LOGOUT);
                CtdlRegisterUserHook(openid_purge, EVT_PURGEUSER);
+               openid_level_supported = 1;     /* This module supports OpenID 1.0 only */
        }
 
-       /* return our Subversion id for the Log */
-       return "$Id$";
+       /* return our module name for the log */
+       return "openid_rp";
 }