-/*
- * POP3 service for the Citadel system
- *
- * Copyright (c) 1998-2012 by the citadel.org team
- *
- * This program is open source software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 3.
- *
- *
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- *
- *
- *
- *
- * Current status of standards conformance:
- *
- * -> All required POP3 commands described in RFC1939 are implemented.
- * -> All optional POP3 commands described in RFC1939 are also implemented.
- * -> The deprecated "LAST" command is included in this implementation, because
- * there exist mail clients which insist on using it (such as Bynari
- * TradeMail, and certain versions of Eudora).
- * -> Capability detection via the method described in RFC2449 is implemented.
- *
- */
+// POP3 service for the Citadel system
+//
+// Copyright (c) 1998-2021 by the citadel.org team
+//
+// This program is open source software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License version 3.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// Current status of standards conformance:
+//
+// -> All required POP3 commands described in RFC1939 are implemented.
+// -> All optional POP3 commands described in RFC1939 are also implemented.
+// -> The deprecated "LAST" command is included in this implementation, because
+// there exist mail clients which insist on using it (such as Bynari
+// TradeMail, and certain versions of Eudora).
+// -> Capability detection via the method described in RFC2449 is implemented.
#include "sysdep.h"
#include <stdlib.h>
#include <pwd.h>
#include <errno.h>
#include <sys/types.h>
-
-#if TIME_WITH_SYS_TIME
-# include <sys/time.h>
-# include <time.h>
-#else
-# if HAVE_SYS_TIME_H
-# include <sys/time.h>
-# else
-# include <time.h>
-# endif
-#endif
-
+#include <time.h>
#include <sys/wait.h>
#include <string.h>
#include <limits.h>
#include "msgbase.h"
#include "internet_addressing.h"
#include "serv_pop3.h"
-#include "md5.h"
-
-
-
#include "ctdl_module.h"
-
-/*
- * This cleanup function blows away the temporary memory and files used by
- * the POP3 server.
- */
+// This cleanup function blows away the temporary memory and files used by
+// the POP3 server.
void pop3_cleanup_function(void) {
-
/* Don't do this stuff if this is not a POP3 session! */
if (CC->h_command_function != pop3_command_loop) return;
- syslog(LOG_DEBUG, "Performing POP3 cleanup hook");
- if (POP3->msgs != NULL) free(POP3->msgs);
+ struct citpop3 *pop3 = ((struct citpop3 *)CC->session_specific_data);
+ syslog(LOG_DEBUG, "pop3: performing cleanup hook");
+ if (pop3->msgs != NULL) {
+ free(pop3->msgs);
+ }
- free(POP3);
+ free(pop3);
}
-
-/*
- * Here's where our POP3 session begins its happy day.
- */
+// Here's where our POP3 session begins its happy day.
void pop3_greeting(void) {
strcpy(CC->cs_clientname, "POP3 session");
CC->internal_pgm = 1;
}
-/*
- * POP3S is just like POP3, except it goes crypto right away.
- */
+// POP3S is just like POP3, except it goes crypto right away.
void pop3s_greeting(void) {
CtdlModuleStartCryptoMsgs(NULL, NULL, NULL);
}
-
-/*
- * Specify user name (implements POP3 "USER" command)
- */
+// Specify user name (implements POP3 "USER" command)
void pop3_user(char *argbuf) {
char username[SIZ];
strcpy(username, argbuf);
striplt(username);
- /* syslog(LOG_DEBUG, "Trying <%s>", username); */
- if (CtdlLoginExistingUser(NULL, username) == login_ok) {
+ if (CtdlLoginExistingUser(username) == login_ok) {
cprintf("+OK Password required for %s\r\n", username);
}
else {
}
-
-/*
- * Back end for pop3_grab_mailbox()
- */
+// Back end for pop3_grab_mailbox()
void pop3_add_message(long msgnum, void *userdata) {
struct MetaData smi;
++POP3->num_msgs;
- if (POP3->num_msgs < 2) POP3->msgs = malloc(sizeof(struct pop3msg));
- else POP3->msgs = realloc(POP3->msgs,
- (POP3->num_msgs * sizeof(struct pop3msg)) ) ;
+ if (POP3->num_msgs < 2) {
+ POP3->msgs = malloc(sizeof(struct pop3msg));
+ }
+ else {
+ POP3->msgs = realloc(POP3->msgs, (POP3->num_msgs * sizeof(struct pop3msg)) ) ;
+ }
POP3->msgs[POP3->num_msgs-1].msgnum = msgnum;
POP3->msgs[POP3->num_msgs-1].deleted = 0;
- /* We need to know the length of this message when it is printed in
- * RFC822 format. Perhaps we have cached this length in the message's
- * metadata record. If so, great; if not, measure it and then cache
- * it for next time.
- */
+ // We need to know the length of this message when it is printed in
+ // RFC822 format. Perhaps we have cached this length in the message's
+ // metadata record. If so, great; if not, measure it and then cache
+ // it for next time.
GetMetaData(&smi, msgnum);
if (smi.meta_rfc822_length <= 0L) {
CC->redirect_buffer = NewStrBufPlain(NULL, SIZ);
- CtdlOutputMsg(msgnum, MT_RFC822, HEADERS_ALL, 0, 1, NULL, SUPPRESS_ENV_TO);
+ CtdlOutputMsg(msgnum, MT_RFC822, HEADERS_ALL, 0, 1, NULL, SUPPRESS_ENV_TO, NULL, NULL, NULL);
smi.meta_rfc822_length = StrLength(CC->redirect_buffer);
- FreeStrBuf(&CC->redirect_buffer); /* TODO: WHEW, all this for just knowing the length???? */
+ FreeStrBuf(&CC->redirect_buffer);
PutMetaData(&smi);
}
POP3->msgs[POP3->num_msgs-1].rfc822_length = smi.meta_rfc822_length;
}
-
-/*
- * Open the inbox and read its contents.
- * (This should be called only once, by pop3_pass(), and returns the number
- * of messages in the inbox, or -1 for error)
- */
+// Open the inbox and read its contents.
+// (This should be called only once, by pop3_pass(), and returns the number
+// of messages in the inbox, or -1 for error)
int pop3_grab_mailbox(void) {
visit vbuf;
int i;
if (CtdlGetRoom(&CC->room, MAILROOM) != 0) return(-1);
/* Load up the messages */
- CtdlForEachMessage(MSGS_ALL, 0L, NULL, NULL, NULL,
- pop3_add_message, NULL);
+ CtdlForEachMessage(MSGS_ALL, 0L, NULL, NULL, NULL, pop3_add_message, NULL);
/* Figure out which are old and which are new */
CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
POP3->lastseen = (-1);
if (POP3->num_msgs) for (i=0; i<POP3->num_msgs; ++i) {
- if (is_msg_in_sequence_set(vbuf.v_seen,
- (POP3->msgs[POP3->num_msgs-1].msgnum) )) {
+ if (is_msg_in_sequence_set(vbuf.v_seen, (POP3->msgs[POP3->num_msgs-1].msgnum) )) {
POP3->lastseen = i;
}
}
return(POP3->num_msgs);
}
-void pop3_login(void)
-{
+
+void pop3_login(void) {
int msgs;
msgs = pop3_grab_mailbox();
if (msgs >= 0) {
cprintf("+OK %s is logged in (%d messages)\r\n",
CC->user.fullname, msgs);
- syslog(LOG_NOTICE, "POP3 authenticated %s", CC->user.fullname);
+ syslog(LOG_DEBUG, "pop3: authenticated %s", CC->user.fullname);
}
else {
cprintf("-ERR Can't open your mailbox\r\n");
}
-/*
- * Authorize with password (implements POP3 "PASS" command)
- */
+// Authorize with password (implements POP3 "PASS" command)
void pop3_pass(char *argbuf) {
char password[SIZ];
safestrncpy(password, argbuf, sizeof password);
striplt(password);
- /* syslog(LOG_DEBUG, "Trying <%s>", password); */
if (CtdlTryPassword(password, strlen(password)) == pass_ok) {
pop3_login();
}
}
-
-/*
- * list available msgs
- */
+// list available msgs
void pop3_list(char *argbuf) {
int i;
int which_one;
which_one = atoi(argbuf);
- /* "list one" mode */
+ // "list one" mode
if (which_one > 0) {
if (which_one > POP3->num_msgs) {
- cprintf("-ERR no such message, only %d are here\r\n",
- POP3->num_msgs);
+ cprintf("-ERR no such message, only %d are here\r\n", POP3->num_msgs);
return;
}
else if (POP3->msgs[which_one-1].deleted) {
return;
}
else {
- cprintf("+OK %d %ld\r\n",
- which_one,
- (long)POP3->msgs[which_one-1].rfc822_length
- );
+ cprintf("+OK %d %ld\r\n", which_one, (long)POP3->msgs[which_one-1].rfc822_length);
return;
}
}
- /* "list all" (scan listing) mode */
+ // "list all" (scan listing) mode
else {
cprintf("+OK Here's your mail:\r\n");
if (POP3->num_msgs > 0) for (i=0; i<POP3->num_msgs; ++i) {
if (! POP3->msgs[i].deleted) {
- cprintf("%d %ld\r\n",
- i+1,
- (long)POP3->msgs[i].rfc822_length);
+ cprintf("%d %ld\r\n", i+1, (long)POP3->msgs[i].rfc822_length);
}
}
cprintf(".\r\n");
}
-/*
- * STAT (tally up the total message count and byte count) command
- */
+// STAT (tally up the total message count and byte count) command
void pop3_stat(char *argbuf) {
int total_msgs = 0;
size_t total_octets = 0;
}
-
-/*
- * RETR command (fetch a message)
- */
+// RETR command (fetch a message)
void pop3_retr(char *argbuf) {
int which_one;
}
cprintf("+OK Message %d:\r\n", which_one);
- CtdlOutputMsg(POP3->msgs[which_one - 1].msgnum,
- MT_RFC822, HEADERS_ALL, 0, 1, NULL,
- (ESC_DOT|SUPPRESS_ENV_TO)
+ CtdlOutputMsg(POP3->msgs[which_one - 1].msgnum, MT_RFC822,
+ HEADERS_ALL, 0, 1, NULL,
+ (ESC_DOT|SUPPRESS_ENV_TO), NULL, NULL, NULL
);
cprintf(".\r\n");
}
-/*
- * TOP command (dumb way of fetching a partial message or headers-only)
- */
+// TOP command (dumb way of fetching a partial message or headers-only)
void pop3_top(char *argbuf) {
int which_one;
int lines_requested = 0;
}
CC->redirect_buffer = NewStrBufPlain(NULL, SIZ);
- CtdlOutputMsg(POP3->msgs[which_one - 1].msgnum, MT_RFC822, HEADERS_ALL, 0, 1, NULL, SUPPRESS_ENV_TO);
+
+ CtdlOutputMsg(POP3->msgs[which_one - 1].msgnum,
+ MT_RFC822,
+ HEADERS_ALL,
+ 0, 1, NULL,
+ SUPPRESS_ENV_TO,
+ NULL, NULL, NULL);
+
msgtext = CC->redirect_buffer;
CC->redirect_buffer = NULL;
}
-/*
- * DELE (delete message from mailbox)
- */
+// DELE (delete message from mailbox)
void pop3_dele(char *argbuf) {
int which_one;
return;
}
- /* Flag the message as deleted. Will expunge during QUIT command. */
+ // Flag the message as deleted. Will expunge during QUIT command.
POP3->msgs[which_one - 1].deleted = 1;
cprintf("+OK Message %d deleted.\r\n",
which_one);
}
-/* Perform "UPDATE state" stuff
- */
+// Perform "UPDATE state" stuff
void pop3_update(void) {
int i;
visit vbuf;
long *deletemsgs = NULL;
int num_deletemsgs = 0;
- /* Remove messages marked for deletion */
+ // Remove messages marked for deletion
if (POP3->num_msgs > 0) {
deletemsgs = malloc(POP3->num_msgs * sizeof(long));
for (i=0; i<POP3->num_msgs; ++i) {
free(deletemsgs);
}
- /* Set last read pointer */
+ // Set last read pointer
if (POP3->num_msgs > 0) {
- CtdlGetUserLock(&CC->user, CC->curr_user);
-
+ CtdlLockGetCurrentUser();
CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
- snprintf(vbuf.v_seen, sizeof vbuf.v_seen, "*:%ld",
- POP3->msgs[POP3->num_msgs-1].msgnum);
+ snprintf(vbuf.v_seen, sizeof vbuf.v_seen, "*:%ld", POP3->msgs[POP3->num_msgs-1].msgnum);
CtdlSetRelationship(&vbuf, &CC->user, &CC->room);
-
- CtdlPutUserLock(&CC->user);
+ CtdlPutCurrentUserLock();
}
}
-/*
- * RSET (reset, i.e. undelete any deleted messages) command
- */
+// RSET (reset, i.e. undelete any deleted messages) command
void pop3_rset(char *argbuf) {
int i;
}
-
-/*
- * LAST (Determine which message is the last unread message)
- */
+// LAST (Determine which message is the last unread message)
void pop3_last(char *argbuf) {
cprintf("+OK %d\r\n", POP3->lastseen + 1);
}
-/*
- * CAPA is a command which tells the client which POP3 extensions
- * are supported.
- */
+// CAPA is a command which tells the client which POP3 extensions are supported.
void pop3_capa(void) {
cprintf("+OK Capability list follows\r\n"
"TOP\r\n"
}
-
-/*
- * UIDL (Universal IDentifier Listing) is easy. Our 'unique' message
- * identifiers are simply the Citadel message numbers in the database.
- */
+// UIDL (Universal IDentifier Listing) is easy. Our 'unique' message
+// identifiers are simply the Citadel message numbers in the database.
void pop3_uidl(char *argbuf) {
int i;
int which_one;
which_one = atoi(argbuf);
- /* "list one" mode */
+ // "list one" mode
if (which_one > 0) {
if (which_one > POP3->num_msgs) {
- cprintf("-ERR no such message, only %d are here\r\n",
- POP3->num_msgs);
+ cprintf("-ERR no such message, only %d are here\r\n", POP3->num_msgs);
return;
}
else if (POP3->msgs[which_one-1].deleted) {
return;
}
else {
- cprintf("+OK %d %ld\r\n",
- which_one,
- POP3->msgs[which_one-1].msgnum
- );
+ cprintf("+OK %d %ld\r\n", which_one, POP3->msgs[which_one-1].msgnum);
return;
}
}
- /* "list all" (scan listing) mode */
+ // "list all" (scan listing) mode
else {
cprintf("+OK Here's your mail:\r\n");
if (POP3->num_msgs > 0) for (i=0; i<POP3->num_msgs; ++i) {
if (! POP3->msgs[i].deleted) {
- cprintf("%d %ld\r\n",
- i+1,
- POP3->msgs[i].msgnum);
+ cprintf("%d %ld\r\n", i+1, POP3->msgs[i].msgnum);
}
}
cprintf(".\r\n");
}
-/*
- * implements the STLS command (Citadel API version)
- */
-void pop3_stls(void)
-{
+// implements the STLS command (Citadel API version)
+void pop3_stls(void) {
char ok_response[SIZ];
char nosup_response[SIZ];
char error_response[SIZ];
- sprintf(ok_response,
- "+OK Begin TLS negotiation now\r\n");
- sprintf(nosup_response,
- "-ERR TLS not supported here\r\n");
- sprintf(error_response,
- "-ERR Internal error\r\n");
+ sprintf(ok_response, "+OK Begin TLS negotiation now\r\n");
+ sprintf(nosup_response, "-ERR TLS not supported here\r\n");
+ sprintf(error_response, "-ERR Internal error\r\n");
CtdlModuleStartCryptoMsgs(ok_response, nosup_response, error_response);
}
-
-
-
-
-
-/*
- * Main command loop for POP3 sessions.
- */
+// Main command loop for POP3 sessions.
void pop3_command_loop(void) {
char cmdbuf[SIZ];
time(&CC->lastcmd);
- memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */
+ memset(cmdbuf, 0, sizeof cmdbuf); // Clear it, just in case
if (client_getln(cmdbuf, sizeof cmdbuf) < 1) {
- syslog(LOG_ERR, "POP3 client disconnected: ending session.");
+ syslog(LOG_INFO, "pop3: client disconnected; ending session.");
CC->kill_me = KILLME_CLIENT_DISCONNECTED;
return;
}
if (!strncasecmp(cmdbuf, "PASS", 4)) {
- syslog(LOG_INFO, "POP3: PASS...");
+ syslog(LOG_DEBUG, "pop3: PASS...");
}
else {
- syslog(LOG_INFO, "POP3: %s", cmdbuf);
+ syslog(LOG_DEBUG, "pop3: %s", cmdbuf);
}
while (strlen(cmdbuf) < 5) strcat(cmdbuf, " ");
{
if(!threading)
{
- CtdlRegisterServiceHook(config.c_pop3_port,
+ CtdlRegisterServiceHook(CtdlGetConfigInt("c_pop3_port"),
NULL,
pop3_greeting,
pop3_command_loop,
NULL,
CitadelServicePop3);
#ifdef HAVE_OPENSSL
- CtdlRegisterServiceHook(config.c_pop3s_port,
+ CtdlRegisterServiceHook(CtdlGetConfigInt("c_pop3s_port"),
NULL,
pop3s_greeting,
pop3_command_loop,