Fix warnings all over citserver; handle function replies; remove unused code.
[citadel.git] / citadel / modules / smtp / serv_smtp.c
index cc8057f8b80f06a5a101f174a99ff8da07b78096..b28ca2ef39a3ad434c582bf52aba193d1d4c2bc7 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * $Id$
- *
  * This module is an SMTP and ESMTP implementation for the Citadel system.
  * It is compliant with all of the following:
  *
@@ -43,6 +41,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>
+#include <termios.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <pwd.h>
@@ -76,7 +75,6 @@
 #include "config.h"
 #include "control.h"
 #include "user_ops.h"
-#include "policy.h"
 #include "database.h"
 #include "msgbase.h"
 #include "internet_addressing.h"
 
 #include "ctdl_module.h"
 
-
-
-typedef struct _citsmtp {              /* Information about the current session */
-       int command_state;
-       char helo_node[SIZ];
-       char from[SIZ];
-       char recipients[SIZ];
-       int number_of_recipients;
-       int delivery_mode;
-       int message_originated_locally;
-       int is_lmtp;
-       int is_unfiltered;
-       int is_msa;
-}citsmtp;
-
+#include "smtp_util.h"
 enum {                         /* Command states for login authentication */
        smtp_command,
        smtp_user,
@@ -117,12 +101,8 @@ enum {                             /* Command states for login authentication */
        smtp_plain
 };
 
-#define SMTP           ((citsmtp *)CC->session_specific_data)
-
 
-int run_queue_now = 0; /* Set to 1 to ignore SMTP send retry times */
 
-citthread_mutex_t smtp_send_lock;
 
 
 /*****************************************************************************/
@@ -151,11 +131,11 @@ void smtp_greeting(int is_msa)
         */
        if ( (config.c_rbl_at_greeting) && (sSMTP->is_msa == 0) ) {
                if (rbl_check(message_to_spammer)) {
-                       if (CtdlThreadCheckStop())
+                       if (server_shutting_down)
                                cprintf("421 %s\r\n", message_to_spammer);
                        else
                                cprintf("550 %s\r\n", message_to_spammer);
-                       CC->kill_me = 1;
+                       CC->kill_me = KILLME_SPAMMER;
                        /* no need to free_recipients(valid), it's not allocated yet */
                        return;
                }
@@ -164,10 +144,8 @@ void smtp_greeting(int is_msa)
        /* Otherwise we're either clean or we check later. */
 
        if (CC->nologin==1) {
-               cprintf("500 Too many users are already online (maximum is %d)\r\n",
-                       config.c_maxsessions
-               );
-               CC->kill_me = 1;
+               cprintf("451 Too many connections are already open; please try again later.\r\n");
+               CC->kill_me = KILLME_MAX_SESSIONS_EXCEEDED;
                /* no need to free_recipients(valid), it's not allocated yet */
                return;
        }
@@ -185,7 +163,7 @@ void smtp_greeting(int is_msa)
 void smtps_greeting(void) {
        CtdlModuleStartCryptoMsgs(NULL, NULL, NULL);
 #ifdef HAVE_OPENSSL
-       if (!CC->redirect_ssl) CC->kill_me = 1;         /* kill session if no crypto */
+       if (!CC->redirect_ssl) CC->kill_me = KILLME_NO_CRYPTO;          /* kill session if no crypto */
 #endif
        smtp_greeting(0);
 }
@@ -203,10 +181,8 @@ void smtp_msa_greeting(void) {
  * LMTP is like SMTP but with some extra bonus footage added.
  */
 void lmtp_greeting(void) {
-       citsmtp *sSMTP;
 
        smtp_greeting(0);
-       sSMTP = SMTP;
        SMTP->is_lmtp = 1;
 }
 
@@ -237,7 +213,7 @@ void lmtp_unfiltered_greeting(void) {
  */
 void smtp_auth_greeting(void) {
                cprintf("235 Hello, %s\r\n", CC->user.fullname);
-               CtdlLogPrintf(CTDL_NOTICE, "SMTP authenticated %s\n", CC->user.fullname);
+               syslog(LOG_NOTICE, "SMTP authenticated %s\n", CC->user.fullname);
                CC->internal_pgm = 0;
                CC->cs_flags &= ~CS_STEALTH;
 }
@@ -322,7 +298,7 @@ void smtp_get_user(char *argbuf) {
        citsmtp *sSMTP = SMTP;
 
        CtdlDecodeBase64(username, argbuf, SIZ);
-       /* CtdlLogPrintf(CTDL_DEBUG, "Trying <%s>\n", username); */
+       /* syslog(LOG_DEBUG, "Trying <%s>\n", username); */
        if (CtdlLoginExistingUser(NULL, username) == login_ok) {
                CtdlEncodeBase64(buf, "Password:", 9, 0);
                cprintf("334 %s\r\n", buf);
@@ -340,11 +316,12 @@ void smtp_get_user(char *argbuf) {
  */
 void smtp_get_pass(char *argbuf) {
        char password[SIZ];
+       long len;
 
        memset(password, 0, sizeof(password));  
-       CtdlDecodeBase64(password, argbuf, SIZ);
-       /* CtdlLogPrintf(CTDL_DEBUG, "Trying <%s>\n", password); */
-       if (CtdlTryPassword(password) == pass_ok) {
+       len = CtdlDecodeBase64(password, argbuf, SIZ);
+       /* syslog(LOG_DEBUG, "Trying <%s>\n", password); */
+       if (CtdlTryPassword(password, len) == pass_ok) {
                smtp_auth_greeting();
        }
        else {
@@ -363,11 +340,14 @@ void smtp_try_plain(char *encoded_authstring) {
        char user[256];
        char pass[256];
        int result;
+       long len;
 
        CtdlDecodeBase64(decoded_authstring, encoded_authstring, strlen(encoded_authstring) );
        safestrncpy(ident, decoded_authstring, sizeof ident);
        safestrncpy(user, &decoded_authstring[strlen(ident) + 1], sizeof user);
-       safestrncpy(pass, &decoded_authstring[strlen(ident) + strlen(user) + 2], sizeof pass);
+       len = safestrncpy(pass, &decoded_authstring[strlen(ident) + strlen(user) + 2], sizeof pass);
+       if (len == -1)
+               len = sizeof(pass) - 1;
 
        SMTP->command_state = smtp_command;
 
@@ -379,7 +359,7 @@ void smtp_try_plain(char *encoded_authstring) {
        }
 
        if (result == login_ok) {
-               if (CtdlTryPassword(pass) == pass_ok) {
+               if (CtdlTryPassword(pass, len) == pass_ok) {
                        smtp_auth_greeting();
                        return;
                }
@@ -495,15 +475,6 @@ void smtp_data_clear(void) {
        sSMTP->message_originated_locally = 0;
 }
 
-const char *smtp_get_Recipients(void)
-{
-       citsmtp *sSMTP = SMTP;
-
-       if (sSMTP == NULL)
-               return NULL;
-       else return sSMTP->from;
-}
-
 /*
  * Implements the "MAIL FROM:" command
  */
@@ -609,7 +580,7 @@ void smtp_rcpt(char *argbuf) {
           && (!sSMTP->is_lmtp) ) {     /* Don't RBL LMTP clients */
                if (config.c_rbl_at_greeting == 0) {    /* Don't RBL again if we already did it */
                        if (rbl_check(message_to_spammer)) {
-                               if (CtdlThreadCheckStop())
+                               if (server_shutting_down)
                                        cprintf("421 %s\r\n", message_to_spammer);
                                else
                                        cprintf("550 %s\r\n", message_to_spammer);
@@ -667,7 +638,8 @@ void smtp_rcpt(char *argbuf) {
  * Implements the DATA command
  */
 void smtp_data(void) {
-       char *body;
+       StrBuf *body;
+       char *defbody; //TODO: remove me
        struct CtdlMessage *msg = NULL;
        long msgnum = (-1L);
        char nowstamp[SIZ];
@@ -690,20 +662,20 @@ void smtp_data(void) {
        cprintf("354 Transmit message now - terminate with '.' by itself\r\n");
        
        datestring(nowstamp, sizeof nowstamp, time(NULL), DATESTRING_RFC822);
-       body = malloc(4096);
+       defbody = malloc(4096);
 
-       if (body != NULL) {
+       if (defbody != NULL) {
                if (sSMTP->is_lmtp && (CC->cs_UDSclientUID != -1)) {
-                       snprintf(body, 4096,
-                                "Received: from %s (Citadel from userid %ld)\n"
-                                "      by %s; %s\n",
-                                sSMTP->helo_node,
-                                (long int) CC->cs_UDSclientUID,
-                                config.c_fqdn,
-                                nowstamp);
+                       snprintf(defbody, 4096,
+                              "Received: from %s (Citadel from userid %ld)\n"
+                              "        by %s; %s\n",
+                              sSMTP->helo_node,
+                              (long int) CC->cs_UDSclientUID,
+                              config.c_fqdn,
+                              nowstamp);
                }
                else {
-                       snprintf(body, 4096,
+                       snprintf(defbody, 4096,
                                 "Received: from %s (%s [%s])\n"
                                 "      by %s; %s\n",
                                 sSMTP->helo_node,
@@ -713,14 +685,14 @@ void smtp_data(void) {
                                 nowstamp);
                }
        }
-       body = CtdlReadMessageBody(HKEY("."), config.c_maxmsglen, body, 1, 0);
+       body = CtdlReadMessageBodyBuf(HKEY("."), config.c_maxmsglen, defbody, 1, NULL);
        if (body == NULL) {
                cprintf("550 Unable to save message: internal error.\r\n");
                return;
        }
 
-       CtdlLogPrintf(CTDL_DEBUG, "Converting message...\n");
-       msg = convert_internet_message(body);
+       syslog(LOG_DEBUG, "Converting message...\n");
+       msg = convert_internet_message_buf(&body);
 
        /* If the user is locally authenticated, FORCE the From: header to
         * show up as the real sender.  Yes, this violates the RFC standard,
@@ -809,20 +781,18 @@ void smtp_data(void) {
                cprintf("%s", result);
        }
 
-       /* Write something to the syslog (which may or may not be where the
+       /* Write something to the syslog(which may or may not be where the
         * rest of the Citadel logs are going; some sysadmins want LOG_MAIL).
         */
-       if (enable_syslog) {
-               syslog((LOG_MAIL | LOG_INFO),
-                       "%ld: from=<%s>, nrcpts=%d, relay=%s [%s], stat=%s",
-                       msgnum,
-                       sSMTP->from,
-                       sSMTP->number_of_recipients,
-                       CC->cs_host,
-                       CC->cs_addr,
-                       result
-               );
-       }
+       syslog((LOG_MAIL | LOG_INFO),
+               "%ld: from=<%s>, nrcpts=%d, relay=%s [%s], stat=%s",
+               msgnum,
+               sSMTP->from,
+               sSMTP->number_of_recipients,
+               CC->cs_host,
+               CC->cs_addr,
+               result
+       );
 
        /* Clean up */
        CtdlFreeMessage(msg);
@@ -860,17 +830,17 @@ void smtp_command_loop(void) {
        citsmtp *sSMTP = SMTP;
 
        if (sSMTP == NULL) {
-               CtdlLogPrintf(CTDL_EMERG, "Session SMTP data is null.  WTF?  We will crash now.\n");
+               syslog(LOG_EMERG, "Session SMTP data is null.  WTF?  We will crash now.\n");
        }
 
        time(&CC->lastcmd);
        memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */
        if (client_getln(cmdbuf, sizeof cmdbuf) < 1) {
-               CtdlLogPrintf(CTDL_CRIT, "Client disconnected: ending session.\n");
-               CC->kill_me = 1;
+               syslog(LOG_CRIT, "SMTP: client disconnected: ending session.\n");
+               CC->kill_me = KILLME_CLIENT_DISCONNECTED;
                return;
        }
-       CtdlLogPrintf(CTDL_INFO, "SMTP server: %s\n", cmdbuf);
+       syslog(LOG_INFO, "SMTP server: %s\n", cmdbuf);
        while (strlen(cmdbuf) < 5) strcat(cmdbuf, " ");
 
        if (sSMTP->command_state == smtp_user) {
@@ -919,7 +889,7 @@ void smtp_command_loop(void) {
 
        else if (!strncasecmp(cmdbuf, "QUIT", 4)) {
                cprintf("221 Goodbye...\r\n");
-               CC->kill_me = 1;
+               CC->kill_me = KILLME_CLIENT_LOGGED_OUT;
                return;
        }
 
@@ -945,924 +915,6 @@ void smtp_command_loop(void) {
 
 
 
-/*****************************************************************************/
-/*               SMTP CLIENT (OUTBOUND PROCESSING) STUFF                     */
-/*****************************************************************************/
-
-
-
-/*
- * smtp_try()
- *
- * Called by smtp_do_procmsg() to attempt delivery to one SMTP host
- *
- */
-void smtp_try(const char *key, const char *addr, int *status,
-             char *dsn, size_t n, long msgnum, char *envelope_from)
-{
-       int sock = (-1);
-       char mxhosts[1024];
-       int num_mxhosts;
-       int mx;
-       int i;
-       char user[1024], node[1024], name[1024];
-       char buf[1024];
-       char mailfrom[1024];
-       char mx_user[256];
-       char mx_pass[256];
-       char mx_host[256];
-       char mx_port[256];
-       int lp, rp;
-       char *msgtext;
-       char *ptr;
-       size_t msg_size;
-       int scan_done;
-       
-       
-       /* Parse out the host portion of the recipient address */
-       process_rfc822_addr(addr, user, node, name);
-
-       CtdlLogPrintf(CTDL_DEBUG, "SMTP client: Attempting delivery to <%s> @ <%s> (%s)\n",
-               user, node, name);
-
-       /* Load the message out of the database */
-       CC->redirect_buffer = malloc(SIZ);
-       CC->redirect_len = 0;
-       CC->redirect_alloc = SIZ;
-       CtdlOutputMsg(msgnum, MT_RFC822, HEADERS_ALL, 0, 1, NULL, ESC_DOT);
-       msgtext = CC->redirect_buffer;
-       msg_size = CC->redirect_len;
-       CC->redirect_buffer = NULL;
-       CC->redirect_len = 0;
-       CC->redirect_alloc = 0;
-
-       /* If no envelope_from is supplied, extract one from the message */
-       if ( (envelope_from == NULL) || (IsEmptyStr(envelope_from)) ) {
-               strcpy(mailfrom, "");
-               scan_done = 0;
-               ptr = msgtext;
-               do {
-                       if (ptr = memreadline(ptr, buf, sizeof buf), *ptr == 0) {
-                               scan_done = 1;
-                       }
-                       if (!strncasecmp(buf, "From:", 5)) {
-                               safestrncpy(mailfrom, &buf[5], sizeof mailfrom);
-                               striplt(mailfrom);
-                               for (i=0; mailfrom[i]; ++i) {
-                                       if (!isprint(mailfrom[i])) {
-                                               strcpy(&mailfrom[i], &mailfrom[i+1]);
-                                               i=0;
-                                       }
-                               }
-       
-                               /* Strip out parenthesized names */
-                               lp = (-1);
-                               rp = (-1);
-                               for (i=0; mailfrom[i]; ++i) {
-                                       if (mailfrom[i] == '(') lp = i;
-                                       if (mailfrom[i] == ')') rp = i;
-                               }
-                               if ((lp>0)&&(rp>lp)) {
-                                       strcpy(&mailfrom[lp-1], &mailfrom[rp+1]);
-                               }
-       
-                               /* Prefer brokketized names */
-                               lp = (-1);
-                               rp = (-1);
-                               for (i=0; mailfrom[i]; ++i) {
-                                       if (mailfrom[i] == '<') lp = i;
-                                       if (mailfrom[i] == '>') rp = i;
-                               }
-                               if ( (lp>=0) && (rp>lp) ) {
-                                       mailfrom[rp] = 0;
-                                       strcpy(mailfrom, &mailfrom[lp]);
-                               }
-       
-                               scan_done = 1;
-                       }
-               } while (scan_done == 0);
-               if (IsEmptyStr(mailfrom)) strcpy(mailfrom, "someone@somewhere.org");
-               stripallbut(mailfrom, '<', '>');
-               envelope_from = mailfrom;
-       }
-
-       /* Figure out what mail exchanger host we have to connect to */
-       num_mxhosts = getmx(mxhosts, node);
-       CtdlLogPrintf(CTDL_DEBUG, "Number of MX hosts for <%s> is %d [%s]\n", node, num_mxhosts, mxhosts);
-       if (num_mxhosts < 1) {
-               *status = 5;
-               snprintf(dsn, SIZ, "No MX hosts found for <%s>", node);
-               return;
-       }
-
-       sock = (-1);
-       for (mx=0; (mx<num_mxhosts && sock < 0); ++mx) {
-               char *endpart;
-               extract_token(buf, mxhosts, mx, '|', sizeof buf);
-               strcpy(mx_user, "");
-               strcpy(mx_pass, "");
-               if (num_tokens(buf, '@') > 1) {
-                       strcpy (mx_user, buf);
-                       endpart = strrchr(mx_user, '@');
-                       *endpart = '\0';
-                       strcpy (mx_host, endpart + 1);
-                       endpart = strrchr(mx_user, ':');
-                       if (endpart != NULL) {
-                               strcpy(mx_pass, endpart+1);
-                               *endpart = '\0';
-                       }
-               }
-               else
-                       strcpy (mx_host, buf);
-               endpart = strrchr(mx_host, ':');
-               if (endpart != 0){
-                       *endpart = '\0';
-                       strcpy(mx_port, endpart + 1);
-               }               
-               else {
-                       strcpy(mx_port, "25");
-               }
-               CtdlLogPrintf(CTDL_DEBUG, "SMTP client: connecting to %s : %s ...\n", mx_host, mx_port);
-               sock = sock_connect(mx_host, mx_port, "tcp");
-               snprintf(dsn, SIZ, "Could not connect: %s", strerror(errno));
-               if (sock >= 0) CtdlLogPrintf(CTDL_DEBUG, "SMTP client: connected!\n");
-               if (sock < 0) {
-                       if (errno > 0) {
-                               snprintf(dsn, SIZ, "%s", strerror(errno));
-                       }
-                       else {
-                               snprintf(dsn, SIZ, "Unable to connect to %s : %s\n", mx_host, mx_port);
-                       }
-               }
-       }
-
-       if (sock < 0) {
-               *status = 4;    /* dsn is already filled in */
-               return;
-       }
-
-       /* Process the SMTP greeting from the server */
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP conversation");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       if (buf[0] != '2') {
-               if (buf[0] == '4') {
-                       *status = 4;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* At this point we know we are talking to a real SMTP server */
-
-       /* Do a EHLO command.  If it fails, try the HELO command. */
-       snprintf(buf, sizeof buf, "EHLO %s\r\n", config.c_fqdn);
-       CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
-       sock_write(sock, buf, strlen(buf));
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP HELO");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       if (buf[0] != '2') {
-               snprintf(buf, sizeof buf, "HELO %s\r\n", config.c_fqdn);
-               CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
-               sock_write(sock, buf, strlen(buf));
-               if (ml_sock_gets(sock, buf) < 0) {
-                       *status = 4;
-                       strcpy(dsn, "Connection broken during SMTP HELO");
-                       goto bail;
-               }
-       }
-       if (buf[0] != '2') {
-               if (buf[0] == '4') {
-                       *status = 4;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* Do an AUTH command if necessary */
-       if (!IsEmptyStr(mx_user)) {
-               char encoded[1024];
-               sprintf(buf, "%s%c%s%c%s", mx_user, '\0', mx_user, '\0', mx_pass);
-               CtdlEncodeBase64(encoded, buf, strlen(mx_user) + strlen(mx_user) + strlen(mx_pass) + 2, 0);
-               snprintf(buf, sizeof buf, "AUTH PLAIN %s\r\n", encoded);
-               CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
-               sock_write(sock, buf, strlen(buf));
-               if (ml_sock_gets(sock, buf) < 0) {
-                       *status = 4;
-                       strcpy(dsn, "Connection broken during SMTP AUTH");
-                       goto bail;
-               }
-               CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-               if (buf[0] != '2') {
-                       if (buf[0] == '4') {
-                               *status = 4;
-                               safestrncpy(dsn, &buf[4], 1023);
-                               goto bail;
-                       }
-                       else {
-                               *status = 5;
-                               safestrncpy(dsn, &buf[4], 1023);
-                               goto bail;
-                       }
-               }
-       }
-
-       /* previous command succeeded, now try the MAIL FROM: command */
-       snprintf(buf, sizeof buf, "MAIL FROM:<%s>\r\n", envelope_from);
-       CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
-       sock_write(sock, buf, strlen(buf));
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP MAIL");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       if (buf[0] != '2') {
-               if (buf[0] == '4') {
-                       *status = 4;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* MAIL succeeded, now try the RCPT To: command */
-       snprintf(buf, sizeof buf, "RCPT TO:<%s@%s>\r\n", user, node);
-       CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
-       sock_write(sock, buf, strlen(buf));
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP RCPT");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       if (buf[0] != '2') {
-               if (buf[0] == '4') {
-                       *status = 4;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* RCPT succeeded, now try the DATA command */
-       CtdlLogPrintf(CTDL_DEBUG, ">DATA\n");
-       sock_write(sock, "DATA\r\n", 6);
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP DATA");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       if (buf[0] != '3') {
-               if (buf[0] == '4') {
-                       *status = 3;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* If we reach this point, the server is expecting data.*/
-       sock_write(sock, msgtext, msg_size);
-       if (msgtext[msg_size-1] != 10) {
-               CtdlLogPrintf(CTDL_WARNING, "Possible problem: message did not "
-                       "correctly terminate. (expecting 0x10, got 0x%02x)\n",
-                               buf[msg_size-1]);
-               sock_write(sock, "\r\n", 2);
-       }
-
-       sock_write(sock, ".\r\n", 3);
-       if (ml_sock_gets(sock, buf) < 0) {
-               *status = 4;
-               strcpy(dsn, "Connection broken during SMTP message transmit");
-               goto bail;
-       }
-       CtdlLogPrintf(CTDL_DEBUG, "%s\n", buf);
-       if (buf[0] != '2') {
-               if (buf[0] == '4') {
-                       *status = 4;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-               else {
-                       *status = 5;
-                       safestrncpy(dsn, &buf[4], 1023);
-                       goto bail;
-               }
-       }
-
-       /* We did it! */
-       safestrncpy(dsn, &buf[4], 1023);
-       *status = 2;
-
-       CtdlLogPrintf(CTDL_DEBUG, ">QUIT\n");
-       sock_write(sock, "QUIT\r\n", 6);
-       ml_sock_gets(sock, buf);
-       CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
-       CtdlLogPrintf(CTDL_INFO, "SMTP client: delivery to <%s> @ <%s> (%s) succeeded\n",
-               user, node, name);
-
-bail:  free(msgtext);
-       sock_close(sock);
-
-       /* Write something to the syslog (which may or may not be where the
-        * rest of the Citadel logs are going; some sysadmins want LOG_MAIL).
-        */
-       if (enable_syslog) {
-               syslog((LOG_MAIL | LOG_INFO),
-                       "%ld: to=<%s>, relay=%s, stat=%s",
-                       msgnum,
-                       addr,
-                       mx_host,
-                       dsn
-               );
-       }
-
-       return;
-}
-
-
-
-/*
- * smtp_do_bounce() is caled by smtp_do_procmsg() to scan a set of delivery
- * instructions for "5" codes (permanent fatal errors) and produce/deliver
- * a "bounce" message (delivery status notification).
- */
-void smtp_do_bounce(char *instr) {
-       int i;
-       int lines;
-       int status;
-       char buf[1024];
-       char key[1024];
-       char addr[1024];
-       char dsn[1024];
-       char bounceto[1024];
-       char boundary[64];
-       int num_bounces = 0;
-       int bounce_this = 0;
-       long bounce_msgid = (-1);
-       time_t submitted = 0L;
-       struct CtdlMessage *bmsg = NULL;
-       int give_up = 0;
-       struct recptypes *valid;
-       int successful_bounce = 0;
-       static int seq = 0;
-       char *omsgtext;
-       size_t omsgsize;
-       long omsgid = (-1);
-
-       CtdlLogPrintf(CTDL_DEBUG, "smtp_do_bounce() called\n");
-       strcpy(bounceto, "");
-       sprintf(boundary, "=_Citadel_Multipart_%s_%04x%04x", config.c_fqdn, getpid(), ++seq);
-       lines = num_tokens(instr, '\n');
-
-       /* See if it's time to give up on delivery of this message */
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               extract_token(key, buf, 0, '|', sizeof key);
-               extract_token(addr, buf, 1, '|', sizeof addr);
-               if (!strcasecmp(key, "submitted")) {
-                       submitted = atol(addr);
-               }
-       }
-
-       if ( (time(NULL) - submitted) > SMTP_GIVE_UP ) {
-               give_up = 1;
-       }
-
-       /* Start building our bounce message */
-
-       bmsg = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
-       if (bmsg == NULL) return;
-       memset(bmsg, 0, sizeof(struct CtdlMessage));
-
-        bmsg->cm_magic = CTDLMESSAGE_MAGIC;
-        bmsg->cm_anon_type = MES_NORMAL;
-        bmsg->cm_format_type = FMT_RFC822;
-        bmsg->cm_fields['A'] = strdup("Citadel");
-        bmsg->cm_fields['O'] = strdup(MAILROOM);
-        bmsg->cm_fields['N'] = strdup(config.c_nodename);
-        bmsg->cm_fields['U'] = strdup("Delivery Status Notification (Failure)");
-       bmsg->cm_fields['M'] = malloc(1024);
-
-        strcpy(bmsg->cm_fields['M'], "Content-type: multipart/mixed; boundary=\"");
-        strcat(bmsg->cm_fields['M'], boundary);
-        strcat(bmsg->cm_fields['M'], "\"\r\n");
-        strcat(bmsg->cm_fields['M'], "MIME-Version: 1.0\r\n");
-        strcat(bmsg->cm_fields['M'], "X-Mailer: " CITADEL "\r\n");
-        strcat(bmsg->cm_fields['M'], "\r\nThis is a multipart message in MIME format.\r\n\r\n");
-        strcat(bmsg->cm_fields['M'], "--");
-        strcat(bmsg->cm_fields['M'], boundary);
-        strcat(bmsg->cm_fields['M'], "\r\n");
-        strcat(bmsg->cm_fields['M'], "Content-type: text/plain\r\n\r\n");
-
-       if (give_up) strcat(bmsg->cm_fields['M'],
-"A message you sent could not be delivered to some or all of its recipients\n"
-"due to prolonged unavailability of its destination(s).\n"
-"Giving up on the following addresses:\n\n"
-);
-
-        else strcat(bmsg->cm_fields['M'],
-"A message you sent could not be delivered to some or all of its recipients.\n"
-"The following addresses were undeliverable:\n\n"
-);
-
-       /*
-        * Now go through the instructions checking for stuff.
-        */
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               extract_token(key, buf, 0, '|', sizeof key);
-               extract_token(addr, buf, 1, '|', sizeof addr);
-               status = extract_int(buf, 2);
-               extract_token(dsn, buf, 3, '|', sizeof dsn);
-               bounce_this = 0;
-
-               CtdlLogPrintf(CTDL_DEBUG, "key=<%s> addr=<%s> status=%d dsn=<%s>\n",
-                       key, addr, status, dsn);
-
-               if (!strcasecmp(key, "bounceto")) {
-                       strcpy(bounceto, addr);
-               }
-
-               if (!strcasecmp(key, "msgid")) {
-                       omsgid = atol(addr);
-               }
-
-               if (!strcasecmp(key, "remote")) {
-                       if (status == 5) bounce_this = 1;
-                       if (give_up) bounce_this = 1;
-               }
-
-               if (bounce_this) {
-                       ++num_bounces;
-
-                       if (bmsg->cm_fields['M'] == NULL) {
-                               CtdlLogPrintf(CTDL_ERR, "ERROR ... M field is null "
-                                       "(%s:%d)\n", __FILE__, __LINE__);
-                       }
-
-                       bmsg->cm_fields['M'] = realloc(bmsg->cm_fields['M'],
-                               strlen(bmsg->cm_fields['M']) + 1024 );
-                       strcat(bmsg->cm_fields['M'], addr);
-                       strcat(bmsg->cm_fields['M'], ": ");
-                       strcat(bmsg->cm_fields['M'], dsn);
-                       strcat(bmsg->cm_fields['M'], "\r\n");
-
-                       remove_token(instr, i, '\n');
-                       --i;
-                       --lines;
-               }
-       }
-
-       /* Attach the original message */
-       if (omsgid >= 0) {
-               strcat(bmsg->cm_fields['M'], "--");
-               strcat(bmsg->cm_fields['M'], boundary);
-               strcat(bmsg->cm_fields['M'], "\r\n");
-               strcat(bmsg->cm_fields['M'], "Content-type: message/rfc822\r\n");
-               strcat(bmsg->cm_fields['M'], "Content-Transfer-Encoding: 7bit\r\n");
-               strcat(bmsg->cm_fields['M'], "Content-Disposition: inline\r\n");
-               strcat(bmsg->cm_fields['M'], "\r\n");
-       
-               CC->redirect_buffer = malloc(SIZ);
-               CC->redirect_len = 0;
-               CC->redirect_alloc = SIZ;
-               CtdlOutputMsg(omsgid, MT_RFC822, HEADERS_ALL, 0, 1, NULL, 0);
-               omsgtext = CC->redirect_buffer;
-               omsgsize = CC->redirect_len;
-               CC->redirect_buffer = NULL;
-               CC->redirect_len = 0;
-               CC->redirect_alloc = 0;
-               bmsg->cm_fields['M'] = realloc(bmsg->cm_fields['M'],
-                               (strlen(bmsg->cm_fields['M']) + omsgsize + 1024) );
-               strcat(bmsg->cm_fields['M'], omsgtext);
-               free(omsgtext);
-       }
-
-       /* Close the multipart MIME scope */
-        strcat(bmsg->cm_fields['M'], "--");
-        strcat(bmsg->cm_fields['M'], boundary);
-        strcat(bmsg->cm_fields['M'], "--\r\n");
-
-       /* Deliver the bounce if there's anything worth mentioning */
-       CtdlLogPrintf(CTDL_DEBUG, "num_bounces = %d\n", num_bounces);
-       if (num_bounces > 0) {
-
-               /* First try the user who sent the message */
-               CtdlLogPrintf(CTDL_DEBUG, "bounce to user? <%s>\n", bounceto);
-               if (IsEmptyStr(bounceto)) {
-                       CtdlLogPrintf(CTDL_ERR, "No bounce address specified\n");
-                       bounce_msgid = (-1L);
-               }
-
-               /* Can we deliver the bounce to the original sender? */
-               valid = validate_recipients(bounceto, smtp_get_Recipients (), 0);
-               if (valid != NULL) {
-                       if (valid->num_error == 0) {
-                               CtdlSubmitMsg(bmsg, valid, "", QP_EADDR);
-                               successful_bounce = 1;
-                       }
-               }
-
-               /* If not, post it in the Aide> room */
-               if (successful_bounce == 0) {
-                       CtdlSubmitMsg(bmsg, NULL, config.c_aideroom, QP_EADDR);
-               }
-
-               /* Free up the memory we used */
-               if (valid != NULL) {
-                       free_recipients(valid);
-               }
-       }
-
-       CtdlFreeMessage(bmsg);
-       CtdlLogPrintf(CTDL_DEBUG, "Done processing bounces\n");
-}
-
-
-/*
- * smtp_purge_completed_deliveries() is caled by smtp_do_procmsg() to scan a
- * set of delivery instructions for completed deliveries and remove them.
- *
- * It returns the number of incomplete deliveries remaining.
- */
-int smtp_purge_completed_deliveries(char *instr) {
-       int i;
-       int lines;
-       int status;
-       char buf[1024];
-       char key[1024];
-       char addr[1024];
-       char dsn[1024];
-       int completed;
-       int incomplete = 0;
-
-       lines = num_tokens(instr, '\n');
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               extract_token(key, buf, 0, '|', sizeof key);
-               extract_token(addr, buf, 1, '|', sizeof addr);
-               status = extract_int(buf, 2);
-               extract_token(dsn, buf, 3, '|', sizeof dsn);
-
-               completed = 0;
-
-               if (!strcasecmp(key, "remote")) {
-                       if (status == 2) completed = 1;
-                       else ++incomplete;
-               }
-
-               if (completed) {
-                       remove_token(instr, i, '\n');
-                       --i;
-                       --lines;
-               }
-       }
-
-       return(incomplete);
-}
-
-
-/*
- * smtp_do_procmsg()
- *
- * Called by smtp_do_queue() to handle an individual message.
- */
-void smtp_do_procmsg(long msgnum, void *userdata) {
-       struct CtdlMessage *msg = NULL;
-       char *instr = NULL;
-       char *results = NULL;
-       int i;
-       int lines;
-       int status;
-       char buf[1024];
-       char key[1024];
-       char addr[1024];
-       char dsn[1024];
-       char envelope_from[1024];
-       long text_msgid = (-1);
-       int incomplete_deliveries_remaining;
-       time_t attempted = 0L;
-       time_t last_attempted = 0L;
-       time_t retry = SMTP_RETRY_INTERVAL;
-
-       CtdlLogPrintf(CTDL_DEBUG, "SMTP client: smtp_do_procmsg(%ld)\n", msgnum);
-       strcpy(envelope_from, "");
-
-       msg = CtdlFetchMessage(msgnum, 1);
-       if (msg == NULL) {
-               CtdlLogPrintf(CTDL_ERR, "SMTP client: tried %ld but no such message!\n", msgnum);
-               return;
-       }
-
-       instr = strdup(msg->cm_fields['M']);
-       CtdlFreeMessage(msg);
-
-       /* Strip out the headers amd any other non-instruction line */
-       lines = num_tokens(instr, '\n');
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               if (num_tokens(buf, '|') < 2) {
-                       remove_token(instr, i, '\n');
-                       --lines;
-                       --i;
-               }
-       }
-
-       /* Learn the message ID and find out about recent delivery attempts */
-       lines = num_tokens(instr, '\n');
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               extract_token(key, buf, 0, '|', sizeof key);
-               if (!strcasecmp(key, "msgid")) {
-                       text_msgid = extract_long(buf, 1);
-               }
-               if (!strcasecmp(key, "envelope_from")) {
-                       extract_token(envelope_from, buf, 1, '|', sizeof envelope_from);
-               }
-               if (!strcasecmp(key, "retry")) {
-                       /* double the retry interval after each attempt */
-                       retry = extract_long(buf, 1) * 2L;
-                       if (retry > SMTP_RETRY_MAX) {
-                               retry = SMTP_RETRY_MAX;
-                       }
-                       remove_token(instr, i, '\n');
-               }
-               if (!strcasecmp(key, "attempted")) {
-                       attempted = extract_long(buf, 1);
-                       if (attempted > last_attempted)
-                               last_attempted = attempted;
-               }
-       }
-
-       /*
-        * Postpone delivery if we've already tried recently.
-        */
-       if (((time(NULL) - last_attempted) < retry) && (run_queue_now == 0)) {
-               CtdlLogPrintf(CTDL_DEBUG, "SMTP client: Retry time not yet reached.\n");
-               free(instr);
-               return;
-       }
-
-
-       /*
-        * Bail out if there's no actual message associated with this
-        */
-       if (text_msgid < 0L) {
-               CtdlLogPrintf(CTDL_ERR, "SMTP client: no 'msgid' directive found!\n");
-               free(instr);
-               return;
-       }
-
-       /* Plow through the instructions looking for 'remote' directives and
-        * a status of 0 (no delivery yet attempted) or 3/4 (transient errors
-        * were experienced and it's time to try again)
-        */
-       lines = num_tokens(instr, '\n');
-       for (i=0; i<lines; ++i) {
-               extract_token(buf, instr, i, '\n', sizeof buf);
-               extract_token(key, buf, 0, '|', sizeof key);
-               extract_token(addr, buf, 1, '|', sizeof addr);
-               status = extract_int(buf, 2);
-               extract_token(dsn, buf, 3, '|', sizeof dsn);
-               if ( (!strcasecmp(key, "remote"))
-                  && ((status==0)||(status==3)||(status==4)) ) {
-
-                       /* Remove this "remote" instruction from the set,
-                        * but replace the set's final newline if
-                        * remove_token() stripped it.  It has to be there.
-                        */
-                       remove_token(instr, i, '\n');
-                       if (instr[strlen(instr)-1] != '\n') {
-                               strcat(instr, "\n");
-                       }
-
-                       --i;
-                       --lines;
-                       CtdlLogPrintf(CTDL_DEBUG, "SMTP client: Trying <%s>\n", addr);
-                       smtp_try(key, addr, &status, dsn, sizeof dsn, text_msgid, envelope_from);
-                       if (status != 2) {
-                               if (results == NULL) {
-                                       results = malloc(1024);
-                                       memset(results, 0, 1024);
-                               }
-                               else {
-                                       results = realloc(results, strlen(results) + 1024);
-                               }
-                               snprintf(&results[strlen(results)], 1024,
-                                       "%s|%s|%d|%s\n",
-                                       key, addr, status, dsn);
-                       }
-               }
-       }
-
-       if (results != NULL) {
-               instr = realloc(instr, strlen(instr) + strlen(results) + 2);
-               strcat(instr, results);
-               free(results);
-       }
-
-
-       /* Generate 'bounce' messages */
-       smtp_do_bounce(instr);
-
-       /* Go through the delivery list, deleting completed deliveries */
-       incomplete_deliveries_remaining = 
-               smtp_purge_completed_deliveries(instr);
-
-
-       /*
-        * No delivery instructions remain, so delete both the instructions
-        * message and the message message.
-        */
-       if (incomplete_deliveries_remaining <= 0) {
-               long delmsgs[2];
-               delmsgs[0] = msgnum;
-               delmsgs[1] = text_msgid;
-               CtdlDeleteMessages(SMTP_SPOOLOUT_ROOM, delmsgs, 2, "");
-       }
-
-       /*
-        * Uncompleted delivery instructions remain, so delete the old
-        * instructions and replace with the updated ones.
-        */
-       if (incomplete_deliveries_remaining > 0) {
-               CtdlDeleteMessages(SMTP_SPOOLOUT_ROOM, &msgnum, 1, "");
-               msg = malloc(sizeof(struct CtdlMessage));
-               memset(msg, 0, sizeof(struct CtdlMessage));
-               msg->cm_magic = CTDLMESSAGE_MAGIC;
-               msg->cm_anon_type = MES_NORMAL;
-               msg->cm_format_type = FMT_RFC822;
-               msg->cm_fields['M'] = malloc(strlen(instr)+SIZ);
-               snprintf(msg->cm_fields['M'],
-                       strlen(instr)+SIZ,
-                       "Content-type: %s\n\n%s\n"
-                       "attempted|%ld\n"
-                       "retry|%ld\n",
-                       SPOOLMIME, instr, (long)time(NULL), (long)retry );
-               CtdlSubmitMsg(msg, NULL, SMTP_SPOOLOUT_ROOM, QP_EADDR);
-               CtdlFreeMessage(msg);
-       }
-
-       free(instr);
-}
-
-
-
-
-/*
- * smtp_do_queue()
- * 
- * Run through the queue sending out messages.
- */
-void *smtp_do_queue(void *arg) {
-       int num_processed = 0;
-       struct CitContext smtp_queue_CC;
-
-       CtdlLogPrintf(CTDL_INFO, "SMTP client: processing outbound queue\n");
-
-       CtdlFillSystemContext(&smtp_queue_CC, "SMTP Send");
-       citthread_setspecific(MyConKey, (void *)&smtp_queue_CC );
-
-       if (CtdlGetRoom(&CC->room, SMTP_SPOOLOUT_ROOM) != 0) {
-               CtdlLogPrintf(CTDL_ERR, "Cannot find room <%s>\n", SMTP_SPOOLOUT_ROOM);
-       }
-       else {
-               num_processed = CtdlForEachMessage(MSGS_ALL, 0L, NULL, SPOOLMIME, NULL, smtp_do_procmsg, NULL);
-       }
-
-       citthread_mutex_unlock (&smtp_send_lock);
-       CtdlLogPrintf(CTDL_INFO, "SMTP client: queue run completed; %d messages processed\n", num_processed);
-       return(NULL);
-}
-
-
-
-/*
- * smtp_queue_thread
- *
- * Create a thread to run the SMTP queue
- *
- * This was created as a response to a situation seen on Uncensored where a bad remote was holding
- * up SMTP sending for long times.
- * Converting to a thread does not fix the problem caused by the bad remote but it does prevent
- * the SMTP sending from stopping housekeeping and the EVT_TIMER event system which in turn prevented
- * other things from happening.
- */
-void smtp_queue_thread (void)
-{
-       if (citthread_mutex_trylock (&smtp_send_lock)) {
-               CtdlLogPrintf(CTDL_DEBUG, "SMTP queue run already in progress\n");
-       }
-       else {
-               CtdlThreadCreate("SMTP Send", CTDLTHREAD_BIGSTACK, smtp_do_queue, NULL);
-       }
-}
-
-
-
-void smtp_server_going_down (void)
-{
-       CtdlLogPrintf(CTDL_DEBUG, "SMTP module clean up for shutdown.\n");
-
-       citthread_mutex_destroy (&smtp_send_lock);
-}
-
-
-
-/*****************************************************************************/
-/*                          SMTP UTILITY COMMANDS                            */
-/*****************************************************************************/
-
-void cmd_smtp(char *argbuf) {
-       char cmd[64];
-       char node[256];
-       char buf[1024];
-       int i;
-       int num_mxhosts;
-
-       if (CtdlAccessCheck(ac_aide)) return;
-
-       extract_token(cmd, argbuf, 0, '|', sizeof cmd);
-
-       if (!strcasecmp(cmd, "mx")) {
-               extract_token(node, argbuf, 1, '|', sizeof node);
-               num_mxhosts = getmx(buf, node);
-               cprintf("%d %d MX hosts listed for %s\n",
-                       LISTING_FOLLOWS, num_mxhosts, node);
-               for (i=0; i<num_mxhosts; ++i) {
-                       extract_token(node, buf, i, '|', sizeof node);
-                       cprintf("%s\n", node);
-               }
-               cprintf("000\n");
-               return;
-       }
-
-       else if (!strcasecmp(cmd, "runqueue")) {
-               run_queue_now = 1;
-               cprintf("%d All outbound SMTP will be retried now.\n", CIT_OK);
-               return;
-       }
-
-       else {
-               cprintf("%d Invalid command.\n", ERROR + ILLEGAL_VALUE);
-       }
-
-}
-
-
-/*
- * Initialize the SMTP outbound queue
- */
-void smtp_init_spoolout(void) {
-       struct ctdlroom qrbuf;
-
-       /*
-        * Create the room.  This will silently fail if the room already
-        * exists, and that's perfectly ok, because we want it to exist.
-        */
-       CtdlCreateRoom(SMTP_SPOOLOUT_ROOM, 3, "", 0, 1, 0, VIEW_MAILBOX);
-
-       /*
-        * Make sure it's set to be a "system room" so it doesn't show up
-        * in the <K>nown rooms list for Aides.
-        */
-       if (CtdlGetRoomLock(&qrbuf, SMTP_SPOOLOUT_ROOM) == 0) {
-               qrbuf.QRflags2 |= QR2_SYSTEM;
-               CtdlPutRoomLock(&qrbuf);
-       }
-}
 
 
 
@@ -1879,7 +931,7 @@ void smtp_cleanup_function(void) {
        /* Don't do this stuff if this is not an SMTP session! */
        if (CC->h_command_function != smtp_command_loop) return;
 
-       CtdlLogPrintf(CTDL_DEBUG, "Performing SMTP cleanup hook\n");
+       syslog(LOG_DEBUG, "Performing SMTP cleanup hook\n");
        free(SMTP);
 }
 
@@ -1932,14 +984,9 @@ CTDL_MODULE_INIT(smtp)
                                        NULL,
                                        CitadelServiceSMTP_LMTP_UNF);
 
-               smtp_init_spoolout();
-               CtdlRegisterSessionHook(smtp_queue_thread, EVT_TIMER);
                CtdlRegisterSessionHook(smtp_cleanup_function, EVT_STOP);
-               CtdlRegisterProtoHook(cmd_smtp, "SMTP", "SMTP utility commands");
-               CtdlRegisterCleanupHook (smtp_server_going_down);
-               citthread_mutex_init (&smtp_send_lock, NULL);
        }
        
-       /* return our Subversion id for the Log */
-       return "$Id$";
+       /* return our module name for the log */
+       return "smtp";
 }