* LMTP is like SMTP but with some extra bonus footage added.
*/
void lmtp_greeting(void) {
+ citsmtp *sSMTP;
+
smtp_greeting(0);
+ sSMTP = SMTP;
SMTP->is_lmtp = 1;
}
* We also have an unfiltered LMTP socket that bypasses spam filters.
*/
void lmtp_unfiltered_greeting(void) {
- citsmtp *sSMTP = SMTP;
+ citsmtp *sSMTP;
+
smtp_greeting(0);
+ sSMTP = SMTP;
sSMTP->is_lmtp = 1;
sSMTP->is_unfiltered = 1;
}
* Implements the DATA command
*/
void smtp_data(void) {
- char *body;
+ StrBuf *body;
+ char *defbody; //TODO: remove me
struct CtdlMessage *msg = NULL;
long msgnum = (-1L);
char nowstamp[SIZ];
cprintf("354 Transmit message now - terminate with '.' by itself\r\n");
datestring(nowstamp, sizeof nowstamp, time(NULL), DATESTRING_RFC822);
- body = malloc(4096);
+ defbody = malloc(4096);
if (body != NULL) {
if (sSMTP->is_lmtp && (CC->cs_UDSclientUID != -1)) {
- snprintf(body, 4096,
- "Received: from %s (Citadel from userid %ld)\n"
- " by %s; %s\n",
- sSMTP->helo_node,
- (long int) CC->cs_UDSclientUID,
- config.c_fqdn,
- nowstamp);
+ snprintf(defbody, 4096,
+ "Received: from %s (Citadel from userid %ld)\n"
+ " by %s; %s\n",
+ sSMTP->helo_node,
+ (long int) CC->cs_UDSclientUID,
+ config.c_fqdn,
+ nowstamp);
}
else {
- snprintf(body, 4096,
+ snprintf(defbody, 4096,
"Received: from %s (%s [%s])\n"
" by %s; %s\n",
sSMTP->helo_node,
nowstamp);
}
}
- body = CtdlReadMessageBody(".", config.c_maxmsglen, body, 1, 0);
+ body = CtdlReadMessageBodyBuf(HKEY("."), config.c_maxmsglen, defbody, 1, NULL);
if (body == NULL) {
cprintf("550 Unable to save message: internal error.\r\n");
return;
}
CtdlLogPrintf(CTDL_DEBUG, "Converting message...\n");
- msg = convert_internet_message(body);
+ msg = convert_internet_message_buf(&body);
/* If the user is locally authenticated, FORCE the From: header to
* show up as the real sender. Yes, this violates the RFC standard,
char cmdbuf[SIZ];
citsmtp *sSMTP = SMTP;
+ if (sSMTP == NULL) {
+ CtdlLogPrintf(CTDL_EMERG, "Session SMTP data is null. WTF? We will crash now.\n");
+ }
+
time(&CC->lastcmd);
memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */
if (client_getln(cmdbuf, sizeof cmdbuf) < 1) {
}
/* Process the SMTP greeting from the server */
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP conversation");
goto bail;
snprintf(buf, sizeof buf, "EHLO %s\r\n", config.c_fqdn);
CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
sock_write(sock, buf, strlen(buf));
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP HELO");
goto bail;
snprintf(buf, sizeof buf, "HELO %s\r\n", config.c_fqdn);
CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
sock_write(sock, buf, strlen(buf));
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP HELO");
goto bail;
snprintf(buf, sizeof buf, "AUTH PLAIN %s\r\n", encoded);
CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
sock_write(sock, buf, strlen(buf));
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP AUTH");
goto bail;
snprintf(buf, sizeof buf, "MAIL FROM:<%s>\r\n", envelope_from);
CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
sock_write(sock, buf, strlen(buf));
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP MAIL");
goto bail;
snprintf(buf, sizeof buf, "RCPT TO:<%s@%s>\r\n", user, node);
CtdlLogPrintf(CTDL_DEBUG, ">%s", buf);
sock_write(sock, buf, strlen(buf));
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP RCPT");
goto bail;
/* RCPT succeeded, now try the DATA command */
CtdlLogPrintf(CTDL_DEBUG, ">DATA\n");
sock_write(sock, "DATA\r\n", 6);
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP DATA");
goto bail;
CtdlLogPrintf(CTDL_WARNING, "Possible problem: message did not "
"correctly terminate. (expecting 0x10, got 0x%02x)\n",
buf[msg_size-1]);
+ sock_write(sock, "\r\n", 2);
}
sock_write(sock, ".\r\n", 3);
- if (ml_sock_gets(sock, buf) < 0) {
+ if (ml_sock_gets(&sock, buf) < 0) {
*status = 4;
strcpy(dsn, "Connection broken during SMTP message transmit");
goto bail;
CtdlLogPrintf(CTDL_DEBUG, ">QUIT\n");
sock_write(sock, "QUIT\r\n", 6);
- ml_sock_gets(sock, buf);
+ ml_sock_gets(&sock, buf);
CtdlLogPrintf(CTDL_DEBUG, "<%s\n", buf);
CtdlLogPrintf(CTDL_INFO, "SMTP client: delivery to <%s> @ <%s> (%s) succeeded\n",
user, node, name);