projects
/
citadel.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
fix double-free when there are multiple mxes
[citadel.git]
/
citadel
/
modules
/
smtp
/
serv_smtpclient.c
diff --git
a/citadel/modules/smtp/serv_smtpclient.c
b/citadel/modules/smtp/serv_smtpclient.c
index a7fb3052e54f3525d0983934d84f9f939a83059b..bfe665984698ee69922f2843b03779ad30924c28 100644
(file)
--- a/
citadel/modules/smtp/serv_smtpclient.c
+++ b/
citadel/modules/smtp/serv_smtpclient.c
@@
-261,10
+261,10
@@
int smtp_attempt_delivery(long msgid, char *recp, char *envelope_from)
response_code = 421;
}
response_code = 421;
}
- if (recipients != NULL) {
curl_slist_free_all(recipients);
curl_slist_free_all(recipients);
- }
- curl_easy_cleanup(curl);
+ recipients = NULL; // this gets reused; avoid double-free
+ curl_easy_cleanup(curl);
+ curl = NULL; // this gets reused; avoid double-free
}
}
}
}