remove extra log message
[citadel.git] / citadel / modules / upgrade / serv_upgrade.c
index 06eb8bcae613b8d47eb1749085c5c55b91f664f0..4d3c50bd7e0037e4fb68257e00fa8b20f5e756b2 100644 (file)
@@ -1,7 +1,10 @@
 /*
- * Transparently handle the upgrading of server data formats.
+ * Transparently handle the upgrading of server data formats.  If we see
+ * an existing version number of our database, we can make some intelligent
+ * guesses about what kind of data format changes need to be applied, and
+ * we apply them transparently.
  *
- * Copyright (c) 1987-2015 by the citadel.org team
+ * Copyright (c) 1987-2016 by the citadel.org team
  *
  * This program is open source software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License version 3.
@@ -94,60 +97,6 @@ void fix_sys_user_name(void)
 }
 
 
-/* 
- * Back end processing function for cmd_bmbx
- */
-void cmd_bmbx_backend(struct ctdlroom *qrbuf, void *data) {
-       static struct RoomProcList *rplist = NULL;
-       struct RoomProcList *ptr;
-       struct ctdlroom qr;
-
-       /* Lazy programming here.  Call this function as a CtdlForEachRoom backend
-        * in order to queue up the room names, or call it with a null room
-        * to make it do the processing.
-        */
-       if (qrbuf != NULL) {
-               ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
-               if (ptr == NULL) return;
-
-               safestrncpy(ptr->name, qrbuf->QRname, sizeof ptr->name);
-               ptr->next = rplist;
-               rplist = ptr;
-               return;
-       }
-
-       while (rplist != NULL) {
-
-               if (CtdlGetRoomLock(&qr, rplist->name) == 0) {
-                       syslog(LOG_DEBUG, "Processing <%s>...", rplist->name);
-                       if ( (qr.QRflags & QR_MAILBOX) == 0) {
-                               syslog(LOG_DEBUG, "  -- not a mailbox");
-                       }
-                       else {
-
-                               qr.QRgen = time(NULL);
-                               syslog(LOG_DEBUG, "  -- fixed!");
-                       }
-                       CtdlPutRoomLock(&qr);
-               }
-
-               ptr = rplist;
-               rplist = rplist->next;
-               free(ptr);
-       }
-}
-
-/*
- * quick fix to bump mailbox generation numbers
- */
-void bump_mailbox_generation_numbers(void) {
-       syslog(LOG_WARNING, "Applying security fix to mailbox rooms");
-       CtdlForEachRoom(cmd_bmbx_backend, NULL);
-       cmd_bmbx_backend(NULL, NULL);
-       return;
-}
-
-
 /* 
  * Back end processing function for convert_ctdluid_to_minusone()
  */
@@ -253,6 +202,172 @@ void guess_time_zone(void) {
 }
 
 
+/*
+ * Per-room callback function for ingest_old_roominfo_and_roompic_files()
+ *
+ * This is the second pass, where we process the list of rooms with info or pic files.
+ */
+void iorarf_oneroom(char *roomname, char *infofile, char *picfile)
+{
+       FILE *fp;
+       long data_length;
+       char *unencoded_data;
+       char *encoded_data;
+       long info_msgnum = 0;
+       long pic_msgnum = 0;
+       char subject[SIZ];
+
+       // Test for the presence of a legacy "room info file"
+       if (!IsEmptyStr(infofile)) {
+               fp = fopen(infofile, "r");
+       }
+       else {
+               fp = NULL;
+       }
+       if (fp) {
+               fseek(fp, 0, SEEK_END);
+               data_length = ftell(fp);
+
+               if (data_length >= 1) {
+                       rewind(fp);
+                       unencoded_data = malloc(data_length);
+                       if (unencoded_data) {
+                               fread(unencoded_data, data_length, 1, fp);
+                               encoded_data = malloc((data_length * 2) + 100);
+                               if (encoded_data) {
+                                       sprintf(encoded_data, "Content-type: text/plain\nContent-transfer-encoding: base64\n\n");
+                                       CtdlEncodeBase64(&encoded_data[strlen(encoded_data)], unencoded_data, data_length, 1);
+                                       snprintf(subject, sizeof subject, "Imported room banner for %s", roomname);
+                                       info_msgnum = quickie_message("Citadel", NULL, NULL, SYSCONFIGROOM, encoded_data, FMT_RFC822, subject);
+                                       free(encoded_data);
+                               }
+                               free(unencoded_data);
+                       }
+               }
+               fclose(fp);
+               if (info_msgnum > 0) unlink(infofile);
+       }
+
+       // Test for the presence of a legacy "room picture file" and import it.
+       if (!IsEmptyStr(picfile)) {
+               fp = fopen(picfile, "r");
+       }
+       else {
+               fp = NULL;
+       }
+       if (fp) {
+               fseek(fp, 0, SEEK_END);
+               data_length = ftell(fp);
+
+               if (data_length >= 1) {
+                       rewind(fp);
+                       unencoded_data = malloc(data_length);
+                       if (unencoded_data) {
+                               fread(unencoded_data, data_length, 1, fp);
+                               encoded_data = malloc((data_length * 2) + 100);
+                               if (encoded_data) {
+                                       sprintf(encoded_data, "Content-type: image/gif\nContent-transfer-encoding: base64\n\n");
+                                       CtdlEncodeBase64(&encoded_data[strlen(encoded_data)], unencoded_data, data_length, 1);
+                                       snprintf(subject, sizeof subject, "Imported room icon for %s", roomname);
+                                       pic_msgnum = quickie_message("Citadel", NULL, NULL, SYSCONFIGROOM, encoded_data, FMT_RFC822, subject);
+                                       free(encoded_data);
+                               }
+                               free(unencoded_data);
+                       }
+               }
+               fclose(fp);
+               if (pic_msgnum > 0) unlink(picfile);
+       }
+
+       // Now we have the message numbers of our new banner and icon.  Record them in the room record.
+       // NOTE: we are not deleting the old msgnum_info because that position in the record was previously
+       // a pointer to the highest message number which existed in the room when the info file was saved,
+       // and we don't want to delete messages that are not *actually* old banners.
+       struct ctdlroom qrbuf;
+       if (CtdlGetRoomLock(&qrbuf, roomname) == 0) {
+               qrbuf.msgnum_info = info_msgnum;
+               qrbuf.msgnum_pic = pic_msgnum;
+               CtdlPutRoomLock(&qrbuf);
+       }
+
+}
+
+
+struct iorarf_list {
+       struct iorarf_list *next;
+       char name[ROOMNAMELEN];
+       char info[PATH_MAX];
+       char pic[PATH_MAX];
+};
+
+
+/*
+ * Per-room callback function for ingest_old_roominfo_and_roompic_files()
+ *
+ * This is the first pass, where the list of qualifying rooms is gathered.
+ */
+void iorarf_backend(struct ctdlroom *qrbuf, void *data)
+{
+       FILE *fp;
+       struct iorarf_list **iorarf_list = (struct iorarf_list **)data;
+
+       struct iorarf_list *i = malloc(sizeof(struct iorarf_list));
+       i->next = *iorarf_list;
+       strcpy(i->name, qrbuf->QRname);
+       strcpy(i->info, "");
+       strcpy(i->pic, "");
+
+       // Test for the presence of a legacy "room info file"
+       assoc_file_name(i->info, sizeof i->info, qrbuf, ctdl_info_dir);
+       fp = fopen(i->info, "r");
+       if (fp) {
+               fclose(fp);
+       }
+       else {
+               i->info[0] = 0;
+       }
+
+       // Test for the presence of a legacy "room picture file"
+       assoc_file_name(i->pic, sizeof i->pic, qrbuf, ctdl_image_dir);
+       fp = fopen(i->pic, "r");
+       if (fp) {
+               fclose(fp);
+       }
+       else {
+               i->pic[0] = 0;
+       }
+
+       if ( (!IsEmptyStr(i->info)) || (!IsEmptyStr(i->pic)) ) {
+               *iorarf_list = i;
+       }
+       else {
+               free(i);
+       }
+}
+
+
+/*
+ * Prior to Citadel Server version 902, room info and pictures (which comprise the
+ * displayed banner for each room) were stored in the filesystem.  If we are upgrading
+ * from version >000 to version >=902, ingest those files into the database.
+ */
+void ingest_old_roominfo_and_roompic_files(void)
+{
+       struct iorarf_list *il = NULL;
+
+       CtdlForEachRoom(iorarf_backend, &il);
+
+       struct iorarf_list *p;
+       while (il) {
+               iorarf_oneroom(il->name, il->info, il->pic);
+               p = il->next;
+               free(il);
+               il = p;
+       }
+
+}
+
+
 /*
  * Perform any upgrades that can be done automatically based on our knowledge of the previous
  * version of Citadel server that was running here.
@@ -310,15 +425,10 @@ void update_config(void) {
  */
 void check_server_upgrades(void) {
 
-       syslog(LOG_INFO, "Existing database version on disk is %d.%02d",
-               (CtdlGetConfigInt("MM_hosted_upgrade_level") / 100),
-               (CtdlGetConfigInt("MM_hosted_upgrade_level") % 100)
-       );
+       syslog(LOG_INFO, "Existing database version on disk is %d", CtdlGetConfigInt("MM_hosted_upgrade_level"));
 
        if (CtdlGetConfigInt("MM_hosted_upgrade_level") < REV_LEVEL) {
-               syslog(LOG_WARNING,
-                       "Server hosted updates need to be processed at this time.  Please wait..."
-               );
+               syslog(LOG_WARNING, "Server hosted updates need to be processed at this time.  Please wait...");
        }
        else {
                return;
@@ -326,13 +436,10 @@ void check_server_upgrades(void) {
 
        update_config();
 
-       if ((CtdlGetConfigInt("MM_hosted_upgrade_level") > 000) && (CtdlGetConfigInt("MM_hosted_upgrade_level") < 555)) {
+       if ((CtdlGetConfigInt("MM_hosted_upgrade_level") > 000) && (CtdlGetConfigInt("MM_hosted_upgrade_level") < 591)) {
                syslog(LOG_EMERG, "This database is too old to be upgraded.  Citadel server will exit.");
                exit(EXIT_FAILURE);
        }
-       if ((CtdlGetConfigInt("MM_hosted_upgrade_level") > 000) && (CtdlGetConfigInt("MM_hosted_upgrade_level") < 591)) {
-               bump_mailbox_generation_numbers();
-       }
        if ((CtdlGetConfigInt("MM_hosted_upgrade_level") > 000) && (CtdlGetConfigInt("MM_hosted_upgrade_level") < 608)) {
                convert_ctdluid_to_minusone();
        }
@@ -360,6 +467,10 @@ void check_server_upgrades(void) {
                }
        }
 
+       if ((CtdlGetConfigInt("MM_hosted_upgrade_level") > 000) && (CtdlGetConfigInt("MM_hosted_upgrade_level") < 902)) {
+               ingest_old_roominfo_and_roompic_files();
+       }
+
        CtdlSetConfigInt("MM_hosted_upgrade_level", REV_LEVEL);
 
        /*