use an Enum for the cm_fields vector instead of nameless chars
[citadel.git] / citadel / modules / vcard / serv_vcard.c
index 8340d4eebad1a7632d5c03d3376fa6208b9d2fb3..10516c3fdad3e878299914dec0d47b38f7039ff2 100644 (file)
@@ -2,21 +2,15 @@
  * A server-side module for Citadel which supports address book information
  * using the standard vCard format.
  * 
- * Copyright (c) 1999-2009 by the citadel.org team
+ * Copyright (c) 1999-2012 by the citadel.org team
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
+ * This program is open source software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
 /*
@@ -91,7 +85,7 @@ void set_mm_valid(void) {
  * Extract Internet e-mail addresses from a message containing a vCard, and
  * perform a callback for any found.
  */
-void vcard_extract_internet_addresses(struct CtdlMessage *msg, void (*callback)(char *, char *) ) {
+void vcard_extract_internet_addresses(struct CtdlMessage *msg, int (*callback)(char *, char *) ) {
        struct vCard *v;
        char *s;
        char *k;
@@ -100,12 +94,12 @@ void vcard_extract_internet_addresses(struct CtdlMessage *msg, void (*callback)(
        int instance = 0;
        int found_something = 0;
 
-       if (msg->cm_fields['A'] == NULL) return;
-       if (msg->cm_fields['N'] == NULL) return;
+       if (msg->cm_fields[eAuthor] == NULL) return;
+       if (msg->cm_fields[eNodeName] == NULL) return;
        snprintf(citadel_address, sizeof citadel_address, "%s @ %s",
-               msg->cm_fields['A'], msg->cm_fields['N']);
+               msg->cm_fields[eAuthor], msg->cm_fields[eNodeName]);
 
-       v = vcard_load(msg->cm_fields['M']);
+       v = vcard_load(msg->cm_fields[eMesageText]);
        if (v == NULL) return;
 
        /* Go through the vCard searching for *all* instances of
@@ -132,33 +126,55 @@ void vcard_extract_internet_addresses(struct CtdlMessage *msg, void (*callback)(
 
        vcard_free(v);
 }
-
-
+///TODO: gettext!
+#define _(a) a
 /*
  * Callback for vcard_add_to_directory()
  * (Lotsa ugly nested callbacks.  Oh well.)
  */
-void vcard_directory_add_user(char *internet_addr, char *citadel_addr) {
+int vcard_directory_add_user(char *internet_addr, char *citadel_addr) {
+       struct CitContext *CCC = CC;
        char buf[SIZ];
 
        /* We have to validate that we're not stepping on someone else's
         * email address ... but only if we're logged in.  Otherwise it's
         * probably just the networker or something.
         */
-       if (CC->logged_in) {
-               syslog(LOG_DEBUG, "Checking for <%s>...\n", internet_addr);
+       if (CCC->logged_in) {
+               syslog(LOG_DEBUG, "Checking for <%s>...", internet_addr);
                if (CtdlDirectoryLookup(buf, internet_addr, sizeof buf) == 0) {
                        if (strcasecmp(buf, citadel_addr)) {
                                /* This address belongs to someone else.
                                 * Bail out silently without saving.
                                 */
-                               syslog(LOG_DEBUG, "DOOP!\n");
-                               return;
+                               syslog(LOG_DEBUG, "DOOP!");
+                               
+                               StrBufAppendPrintf(CCC->StatusMessage, "\n%d|", ERROR+ALREADY_EXISTS);
+                               StrBufAppendBufPlain(CCC->StatusMessage, internet_addr, -1, 0);
+                               StrBufAppendBufPlain(CCC->StatusMessage, HKEY("|"), 0);
+                               StrBufAppendBufPlain(CCC->StatusMessage, _("Unable to add this email address again."), -1, 0);
+                               StrBufAppendBufPlain(CCC->StatusMessage, HKEY("\n"), 0);
+                               return 0;
                        }
                }
        }
-       syslog(LOG_INFO, "Adding %s (%s) to directory\n", citadel_addr, internet_addr);
-       CtdlDirectoryAddUser(internet_addr, citadel_addr);
+       syslog(LOG_INFO, "Adding %s (%s) to directory", citadel_addr, internet_addr);
+       if (CtdlDirectoryAddUser(internet_addr, citadel_addr))
+       {
+               StrBufAppendPrintf(CCC->StatusMessage, "\n%d|", CIT_OK);
+               StrBufAppendBufPlain(CCC->StatusMessage, internet_addr, -1, 0);
+               StrBufAppendBufPlain(CCC->StatusMessage, HKEY("|"), 0);
+               StrBufAppendBufPlain(CCC->StatusMessage, _("Successfully added email address."), -1, 0);
+               return 1;
+       }
+       else
+       {
+               StrBufAppendPrintf(CCC->StatusMessage, "\n%d|", ERROR+ ILLEGAL_VALUE);
+               StrBufAppendBufPlain(CCC->StatusMessage, internet_addr, -1, 0);
+               StrBufAppendBufPlain(CCC->StatusMessage, HKEY("|"), 0);
+               StrBufAppendBufPlain(CCC->StatusMessage, _("Unable to add this email address. It does not match any local domain."), -1, 0);
+               return 0;
+       }
 }
 
 
@@ -198,7 +214,8 @@ void cmd_igab(char *argbuf) {
        CtdlDirectoryInit();
 
        /* We want *all* vCards in this room */
-       CtdlForEachMessage(MSGS_ALL, 0, NULL, "^[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$",
+       NewStrBufDupAppendFlush(&CC->StatusMessage, NULL, NULL, 0);
+       CtdlForEachMessage(MSGS_ALL, 0, NULL, "[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$",
                NULL, vcard_add_to_directory, NULL);
 
        CtdlGetRoom(&CC->room, hold_rm);        /* return to saved room */
@@ -213,10 +230,14 @@ void cmd_igab(char *argbuf) {
  * Internet messages.  If there is, stick it in the buffer.
  */
 void extract_inet_email_addrs(char *emailaddrbuf, size_t emailaddrbuf_len,
-                               char *secemailaddrbuf, size_t secemailaddrbuf_len,
-                               struct vCard *v, int local_addrs_only) {
+                             char *secemailaddrbuf, size_t secemailaddrbuf_len,
+                             struct vCard *v,
+                             int local_addrs_only)
+{
+       struct CitContext *CCC = CC;            /* put this on the stack, just for speed */
        char *s, *k, *addr;
        int instance = 0;
+       int IsDirectoryAddress;
        int saved_instance = 0;
 
        /* Go through the vCard searching for *all* Internet email addresses
@@ -227,8 +248,9 @@ void extract_inet_email_addrs(char *emailaddrbuf, size_t emailaddrbuf_len,
                        addr = strdup(s);
                        striplt(addr);
                        if (!IsEmptyStr(addr)) {
-                               if ( (IsDirectory(addr, 1)) || 
-                               (!local_addrs_only) ) {
+                               IsDirectoryAddress = IsDirectory(addr, 1);
+                               if ( IsDirectoryAddress || !local_addrs_only)
+                               {
                                        ++saved_instance;
                                        if ((saved_instance == 1) && (emailaddrbuf != NULL)) {
                                                safestrncpy(emailaddrbuf, addr, emailaddrbuf_len);
@@ -244,6 +266,13 @@ void extract_inet_email_addrs(char *emailaddrbuf, size_t emailaddrbuf_len,
                                                }
                                        }
                                }
+                               if (!IsDirectoryAddress && local_addrs_only)
+                               {
+                                       StrBufAppendPrintf(CCC->StatusMessage, "\n%d|", ERROR+ ILLEGAL_VALUE);
+                                       StrBufAppendBufPlain(CCC->StatusMessage, addr, -1, 0);
+                                       StrBufAppendBufPlain(CCC->StatusMessage, HKEY("|"), 0);
+                                       StrBufAppendBufPlain(CCC->StatusMessage, _("unable to add this emailaddress; its not matching our domain."), -1, 0);
+                               }
                        }
                        free(addr);
                }
@@ -284,7 +313,7 @@ void vcard_extract_vcard(char *name, char *filename, char *partnum, char *disp,
        if (  (!strcasecmp(cbtype, "text/x-vcard"))
           || (!strcasecmp(cbtype, "text/vcard")) ) {
 
-               syslog(LOG_DEBUG, "Part %s contains a vCard!  Loading...\n", partnum);
+               syslog(LOG_DEBUG, "Part %s contains a vCard!  Loading...", partnum);
                if (*v != NULL) {
                        vcard_free(*v);
                }
@@ -300,6 +329,7 @@ void vcard_extract_vcard(char *name, char *filename, char *partnum, char *disp,
  * and in the global address book).
  */
 int vcard_upload_beforesave(struct CtdlMessage *msg) {
+       struct CitContext *CCC = CC;
        char *ptr;
        char *s;
        char buf[SIZ];
@@ -311,17 +341,17 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
        int yes_my_citadel_config = 0;
        int yes_any_vcard_room = 0;
 
-       if (!CC->logged_in) return(0);  /* Only do this if logged in. */
+       if (!CCC->logged_in) return(0); /* Only do this if logged in. */
 
        /* Is this some user's "My Citadel Config" room? */
-       if ( (CC->room.QRflags && QR_MAILBOX)
-          && (!strcasecmp(&CC->room.QRname[11], USERCONFIGROOM)) ) {
+       if (((CCC->room.QRflags & QR_MAILBOX) != 0) &&
+             (!strcasecmp(&CCC->room.QRname[11], USERCONFIGROOM)) ) {
                /* Yes, we want to do this */
                yes_my_citadel_config = 1;
 
 #ifdef VCARD_SAVES_BY_AIDES_ONLY
                /* Prevent non-aides from performing registration changes */
-               if (CC->user.axlevel < AxAideU) {
+               if (CCC->user.axlevel < AxAideU) {
                        return(1);
                }
 #endif
@@ -329,7 +359,7 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
        }
 
        /* Is this a room with an address book in it? */
-       if (CC->room.QRdefaultview == VIEW_ADDRESSBOOK) {
+       if (CCC->room.QRdefaultview == VIEW_ADDRESSBOOK) {
                yes_any_vcard_room = 1;
        }
 
@@ -343,10 +373,10 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
 
        /* Ok, if we got this far, look into the situation further... */
 
-       ptr = msg->cm_fields['M'];
+       ptr = msg->cm_fields[eMesageText];
        if (ptr == NULL) return(0);
 
-       mime_parser(msg->cm_fields['M'],
+       mime_parser(msg->cm_fields[eMesageText],
                NULL,
                *vcard_extract_vcard,
                NULL, NULL,
@@ -357,23 +387,22 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
        if (v == NULL) return(0);       /* no vCards were found in this message */
 
        /* If users cannot create their own accounts, they cannot re-register either. */
-       if ( (yes_my_citadel_config) && (config.c_disable_newu) && (CC->user.axlevel < AxAideU) ) {
+       if ( (yes_my_citadel_config) && (config.c_disable_newu) && (CCC->user.axlevel < AxAideU) ) {
                return(1);
        }
 
-       s = vcard_get_prop(v, "fn", 1, 0, 0);
-       if (s) syslog(LOG_DEBUG, "vCard beforesave hook running for <%s>\n", s);
+       vcard_get_prop(v, "fn", 1, 0, 0);
 
        if (yes_my_citadel_config) {
                /* Bingo!  The user is uploading a new vCard, so
                 * delete the old one.  First, figure out which user
                 * is being re-registered...
                 */
-               what_user = atol(CC->room.QRname);
+               what_user = atol(CCC->room.QRname);
 
-               if (what_user == CC->user.usernum) {
+               if (what_user == CCC->user.usernum) {
                        /* It's the logged in user.  That was easy. */
-                       memcpy(&usbuf, &CC->user, sizeof(struct ctdluser));
+                       memcpy(&usbuf, &CCC->user, sizeof(struct ctdluser));
                }
                
                else if (CtdlGetUserByNumber(&usbuf, what_user) == 0) {
@@ -393,13 +422,13 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
                 * vCard in the user's config room at all times.
                 *
                 */
-               CtdlDeleteMessages(CC->room.QRname, NULL, 0, "^[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$");
+               CtdlDeleteMessages(CCC->room.QRname, NULL, 0, "[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$");
 
                /* Make the author of the message the name of the user. */
-               if (msg->cm_fields['A'] != NULL) {
-                       free(msg->cm_fields['A']);
+               if (msg->cm_fields[eAuthor] != NULL) {
+                       free(msg->cm_fields[eAuthor]);
                }
-               msg->cm_fields['A'] = strdup(usbuf.fullname);
+               msg->cm_fields[eAuthor] = strdup(usbuf.fullname);
        }
 
        /* Insert or replace RFC2739-compliant free/busy URL */
@@ -422,23 +451,23 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
 
        /* Enforce local UID policy if applicable */
        if (yes_my_citadel_config) {
-               snprintf(buf, sizeof buf, VCARD_EXT_FORMAT, msg->cm_fields['A'], NODENAME);
+               snprintf(buf, sizeof buf, VCARD_EXT_FORMAT, msg->cm_fields[eAuthor], NODENAME);
                vcard_set_prop(v, "UID", buf, 0);
        }
 
        /* 
         * Set the EUID of the message to the UID of the vCard.
         */
-       if (msg->cm_fields['E'] != NULL)
+       if (msg->cm_fields[eExclusiveID] != NULL)
        {
-               free(msg->cm_fields['E']);
-               msg->cm_fields['E'] = NULL;
+               free(msg->cm_fields[eExclusiveID]);
+               msg->cm_fields[eExclusiveID] = NULL;
        }
        s = vcard_get_prop(v, "UID", 1, 0, 0);
        if (s != NULL) {
-               msg->cm_fields['E'] = strdup(s);
-               if (msg->cm_fields['U'] == NULL) {
-                       msg->cm_fields['U'] = strdup(s);
+               msg->cm_fields[eExclusiveID] = strdup(s);
+               if (msg->cm_fields[eMsgSubject] == NULL) {
+                       msg->cm_fields[eMsgSubject] = strdup(s);
                }
        }
 
@@ -450,17 +479,17 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
                s = vcard_get_prop(v, "N", 1, 0, 0);
        }
        if (s != NULL) {
-               if (msg->cm_fields['U'] != NULL) {
-                       free(msg->cm_fields['U']);
+               if (msg->cm_fields[eMsgSubject] != NULL) {
+                       free(msg->cm_fields[eMsgSubject]);
                }
-               msg->cm_fields['U'] = strdup(s);
+               msg->cm_fields[eMsgSubject] = strdup(s);
        }
 
        /* Re-serialize it back into the msg body */
        ser = vcard_serialize(v);
        if (ser != NULL) {
-               msg->cm_fields['M'] = realloc(msg->cm_fields['M'], strlen(ser) + 1024);
-               sprintf(msg->cm_fields['M'],
+               msg->cm_fields[eMesageText] = realloc(msg->cm_fields[eMesageText], strlen(ser) + 1024);
+               sprintf(msg->cm_fields[eMesageText],
                        "Content-type: " VCARD_MIME_TYPE
                        "\r\n\r\n%s\r\n", ser);
                free(ser);
@@ -480,6 +509,7 @@ int vcard_upload_beforesave(struct CtdlMessage *msg) {
  * address book).
  */
 int vcard_upload_aftersave(struct CtdlMessage *msg) {
+       struct CitContext *CCC = CC;
        char *ptr;
        int linelen;
        long I;
@@ -490,26 +520,31 @@ int vcard_upload_aftersave(struct CtdlMessage *msg) {
        char roomname[ROOMNAMELEN];
 
        if (msg->cm_format_type != 4) return(0);
-       if (!CC->logged_in) return(0);  /* Only do this if logged in. */
+       if (!CCC->logged_in) return(0); /* Only do this if logged in. */
 
        /* We're interested in user config rooms only. */
 
-       if ( (strlen(CC->room.QRname) >= 12) && (!strcasecmp(&CC->room.QRname[11], USERCONFIGROOM)) ) {
+       if ( (strlen(CCC->room.QRname) >= 12) && (!strcasecmp(&CCC->room.QRname[11], USERCONFIGROOM)) ) {
                is_UserConf = 1;        /* It's someone's config room */
        }
-       CtdlMailboxName(roomname, sizeof roomname, &CC->user, USERCONFIGROOM);
-       if (!strcasecmp(CC->room.QRname, roomname)) {
+       CtdlMailboxName(roomname, sizeof roomname, &CCC->user, USERCONFIGROOM);
+       if (!strcasecmp(CCC->room.QRname, roomname)) {
                is_UserConf = 1;
                is_MY_UserConf = 1;     /* It's MY config room */
        }
-       if (!strcasecmp(CC->room.QRname, ADDRESS_BOOK_ROOM)) {
+       if (!strcasecmp(CCC->room.QRname, ADDRESS_BOOK_ROOM)) {
                is_GAB = 1;             /* It's the Global Address Book */
        }
 
        if (!is_UserConf && !is_GAB) return(0);
 
-       ptr = msg->cm_fields['M'];
+       ptr = msg->cm_fields[eMesageText];
        if (ptr == NULL) return(0);
+
+       NewStrBufDupAppendFlush(&CCC->StatusMessage, NULL, NULL, 0);
+
+       StrBufPrintf(CCC->StatusMessage, "%d\n", LISTING_FOLLOWS);
+
        while (ptr != NULL) {
        
                linelen = strcspn(ptr, "\n");
@@ -522,16 +557,16 @@ int vcard_upload_aftersave(struct CtdlMessage *msg) {
                         * copy it to the Global Address Book room.
                         */
 
-                       I = atol(msg->cm_fields['I']);
-                       if (I < 0L) return(0);
+                       I = atol(msg->cm_fields[eVltMsgNum]);
+                       if (I <= 0L) return(0);
 
                        /* Store our Internet return address in memory */
                        if (is_MY_UserConf) {
-                               v = vcard_load(msg->cm_fields['M']);
-                               extract_inet_email_addrs(CC->cs_inet_email, sizeof CC->cs_inet_email,
-                                               CC->cs_inet_other_emails, sizeof CC->cs_inet_other_emails,
+                               v = vcard_load(msg->cm_fields[eMesageText]);
+                               extract_inet_email_addrs(CCC->cs_inet_email, sizeof CCC->cs_inet_email,
+                                               CCC->cs_inet_other_emails, sizeof CCC->cs_inet_other_emails,
                                                v, 1);
-                               extract_friendly_name(CC->cs_inet_fn, sizeof CC->cs_inet_fn, v);
+                               extract_friendly_name(CCC->cs_inet_fn, sizeof CCC->cs_inet_fn, v);
                                vcard_free(v);
                        }
 
@@ -549,19 +584,19 @@ int vcard_upload_aftersave(struct CtdlMessage *msg) {
                         * But if the user was an Aide or was edited by an Aide then we can
                         * Assume they don't need validating.
                         */
-                       if (CC->user.axlevel >= AxAideU) {
-                               CtdlGetUserLock(&CC->user, CC->curr_user);
-                               CC->user.flags |= US_REGIS;
-                               CtdlPutUserLock(&CC->user);
+                       if (CCC->user.axlevel >= AxAideU) {
+                               CtdlGetUserLock(&CCC->user, CCC->curr_user);
+                               CCC->user.flags |= US_REGIS;
+                               CtdlPutUserLock(&CCC->user);
                                return (0);
                        }
                        
                        set_mm_valid();
 
                        /* ...which also means we need to flag the user */
-                       CtdlGetUserLock(&CC->user, CC->curr_user);
-                       CC->user.flags |= (US_REGIS|US_NEEDVALID);
-                       CtdlPutUserLock(&CC->user);
+                       CtdlGetUserLock(&CCC->user, CCC->curr_user);
+                       CCC->user.flags |= (US_REGIS|US_NEEDVALID);
+                       CtdlPutUserLock(&CCC->user);
 
                        return(0);
                }
@@ -591,32 +626,33 @@ void vcard_gu_backend(long supplied_msgnum, void *userdata) {
  * and return an empty vCard.
  */
 struct vCard *vcard_get_user(struct ctdluser *u) {
+       struct CitContext *CCC = CC;
        char hold_rm[ROOMNAMELEN];
        char config_rm[ROOMNAMELEN];
        struct CtdlMessage *msg = NULL;
        struct vCard *v;
        long VCmsgnum;
 
-       strcpy(hold_rm, CC->room.QRname);       /* save current room */
+       strcpy(hold_rm, CCC->room.QRname);      /* save current room */
        CtdlMailboxName(config_rm, sizeof config_rm, u, USERCONFIGROOM);
 
-       if (CtdlGetRoom(&CC->room, config_rm) != 0) {
-               CtdlGetRoom(&CC->room, hold_rm);
+       if (CtdlGetRoom(&CCC->room, config_rm) != 0) {
+               CtdlGetRoom(&CCC->room, hold_rm);
                return vcard_new();
        }
 
        /* We want the last (and probably only) vcard in this room */
        VCmsgnum = (-1);
-       CtdlForEachMessage(MSGS_LAST, 1, NULL, "^[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$",
+       CtdlForEachMessage(MSGS_LAST, 1, NULL, "[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$",
                NULL, vcard_gu_backend, (void *)&VCmsgnum );
-       CtdlGetRoom(&CC->room, hold_rm);        /* return to saved room */
+       CtdlGetRoom(&CCC->room, hold_rm);       /* return to saved room */
 
        if (VCmsgnum < 0L) return vcard_new();
 
        msg = CtdlFetchMessage(VCmsgnum, 1);
        if (msg == NULL) return vcard_new();
 
-       v = vcard_load(msg->cm_fields['M']);
+       v = vcard_load(msg->cm_fields[eMesageText]);
        CtdlFreeMessage(msg);
        return v;
 }
@@ -663,6 +699,7 @@ void vcard_write_user(struct ctdluser *u, struct vCard *v) {
  * and enters the vCard into the user's configuration.
  */
 void cmd_regi(char *argbuf) {
+       struct CitContext *CCC = CC;
        int a,b,c;
        char buf[SIZ];
        struct vCard *my_vcard;
@@ -676,18 +713,18 @@ void cmd_regi(char *argbuf) {
 
        unbuffer_output();
 
-       if (!(CC->logged_in)) {
+       if (!(CCC->logged_in)) {
                cprintf("%d Not logged in.\n",ERROR + NOT_LOGGED_IN);
                return;
        }
 
        /* If users cannot create their own accounts, they cannot re-register either. */
-       if ( (config.c_disable_newu) && (CC->user.axlevel < AxAideU) ) {
+       if ( (config.c_disable_newu) && (CCC->user.axlevel < AxAideU) ) {
                cprintf("%d Self-service registration is not allowed here.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
        }
 
-       my_vcard = vcard_get_user(&CC->user);
+       my_vcard = vcard_get_user(&CCC->user);
        strcpy(tmpaddr, "");
        strcpy(tmpcity, "");
        strcpy(tmpstate, "");
@@ -719,7 +756,7 @@ void cmd_regi(char *argbuf) {
        snprintf(tmpaddress, sizeof tmpaddress, ";;%s;%s;%s;%s;%s",
                tmpaddr, tmpcity, tmpstate, tmpzip, tmpcountry);
        vcard_set_prop(my_vcard, "adr", tmpaddress, 0);
-       vcard_write_user(&CC->user, my_vcard);
+       vcard_write_user(&CCC->user, my_vcard);
        vcard_free(my_vcard);
 }
 
@@ -729,6 +766,7 @@ void cmd_regi(char *argbuf) {
  */
 void cmd_greg(char *argbuf)
 {
+       struct CitContext *CCC = CC;
        struct ctdluser usbuf;
        struct vCard *v;
        char *s;
@@ -738,14 +776,14 @@ void cmd_greg(char *argbuf)
 
        extract_token(who, argbuf, 0, '|', sizeof who);
 
-       if (!(CC->logged_in)) {
+       if (!(CCC->logged_in)) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
                return;
        }
 
-       if (!strcasecmp(who,"_SELF_")) strcpy(who,CC->curr_user);
+       if (!strcasecmp(who,"_SELF_")) strcpy(who,CCC->curr_user);
 
-       if ((CC->user.axlevel < AxAideU) && (strcasecmp(who,CC->curr_user))) {
+       if ((CCC->user.axlevel < AxAideU) && (strcasecmp(who,CCC->curr_user))) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -810,7 +848,7 @@ void vcard_newuser(struct ctdluser *usbuf) {
        struct vCard *v;
 
        vcard_fn_to_n(vname, usbuf->fullname, sizeof vname);
-       syslog(LOG_DEBUG, "Converted <%s> to <%s>\n", usbuf->fullname, vname);
+       syslog(LOG_DEBUG, "Converted <%s> to <%s>", usbuf->fullname, vname);
 
        /* Create and save the vCard */
        v = vcard_new();
@@ -829,7 +867,7 @@ void vcard_newuser(struct ctdluser *usbuf) {
                if (getpwuid_r(usbuf->uid, &pwd, pwd_buffer, sizeof pwd_buffer) != NULL) {
 #else // SOLARIS_GETPWUID
                struct passwd *result = NULL;
-               syslog(LOG_DEBUG, "Searching for uid %d\n", usbuf->uid);
+               syslog(LOG_DEBUG, "Searching for uid %d", usbuf->uid);
                if (getpwuid_r(usbuf->uid, &pwd, pwd_buffer, sizeof pwd_buffer, &result) == 0) {
 #endif // HAVE_GETPWUID_R
                        snprintf(buf, sizeof buf, "%s@%s", pwd.pw_name, config.c_fqdn);
@@ -867,16 +905,16 @@ void vcard_purge(struct ctdluser *usbuf) {
        msg->cm_magic = CTDLMESSAGE_MAGIC;
        msg->cm_anon_type = MES_NORMAL;
        msg->cm_format_type = 0;
-       msg->cm_fields['A'] = strdup(usbuf->fullname);
-       msg->cm_fields['O'] = strdup(ADDRESS_BOOK_ROOM);
-       msg->cm_fields['N'] = strdup(NODENAME);
-       msg->cm_fields['M'] = strdup("Purge this vCard\n");
+       msg->cm_fields[eAuthor] = strdup(usbuf->fullname);
+       msg->cm_fields[eOriginalRoom] = strdup(ADDRESS_BOOK_ROOM);
+       msg->cm_fields[eNodeName] = strdup(NODENAME);
+       msg->cm_fields[eMesageText] = strdup("Purge this vCard\n");
 
        snprintf(buf, sizeof buf, VCARD_EXT_FORMAT,
-                       msg->cm_fields['A'], NODENAME);
-       msg->cm_fields['E'] = strdup(buf);
+                       msg->cm_fields[eAuthor], NODENAME);
+       msg->cm_fields[eExclusiveID] = strdup(buf);
 
-       msg->cm_fields['S'] = strdup("CANCEL");
+       msg->cm_fields[eSpecialField] = strdup("CANCEL");
 
        CtdlSubmitMsg(msg, NULL, ADDRESS_BOOK_ROOM, QP_EADDR);
        CtdlFreeMessage(msg);
@@ -898,7 +936,7 @@ int vcard_extract_from_network(struct CtdlMessage *msg, char *target_room) {
 
        if (msg->cm_format_type != 4) return(0);
 
-       ptr = msg->cm_fields['M'];
+       ptr = msg->cm_fields[eMesageText];
        if (ptr == NULL) return(0);
        while (ptr != NULL) {
        
@@ -941,7 +979,7 @@ void vcard_delete_remove(char *room, long msgnum) {
        msg = CtdlFetchMessage(msgnum, 1);
        if (msg == NULL) return;
 
-       ptr = msg->cm_fields['M'];
+       ptr = msg->cm_fields[eMesageText];
        if (ptr == NULL) goto EOH;
        while (ptr != NULL) {
                linelen = strcspn(ptr, "\n");
@@ -966,12 +1004,14 @@ EOH:     CtdlFreeMessage(msg);
  */
 void cmd_gvsn(char *argbuf)
 {
+       struct CitContext *CCC = CC;
+
        if (CtdlAccessCheck(ac_logged_in)) return;
 
        cprintf("%d valid screen names:\n", LISTING_FOLLOWS);
-       cprintf("%s\n", CC->user.fullname);
-       if ( (!IsEmptyStr(CC->cs_inet_fn)) && (strcasecmp(CC->user.fullname, CC->cs_inet_fn)) ) {
-               cprintf("%s\n", CC->cs_inet_fn);
+       cprintf("%s\n", CCC->user.fullname);
+       if ( (!IsEmptyStr(CCC->cs_inet_fn)) && (strcasecmp(CCC->user.fullname, CCC->cs_inet_fn)) ) {
+               cprintf("%s\n", CCC->cs_inet_fn);
        }
        cprintf("000\n");
 }
@@ -982,6 +1022,7 @@ void cmd_gvsn(char *argbuf)
  */
 void cmd_gvea(char *argbuf)
 {
+       struct CitContext *CCC = CC;
        int num_secondary_emails = 0;
        int i;
        char buf[256];
@@ -989,13 +1030,13 @@ void cmd_gvea(char *argbuf)
        if (CtdlAccessCheck(ac_logged_in)) return;
 
        cprintf("%d valid email addresses:\n", LISTING_FOLLOWS);
-       if (!IsEmptyStr(CC->cs_inet_email)) {
-               cprintf("%s\n", CC->cs_inet_email);
+       if (!IsEmptyStr(CCC->cs_inet_email)) {
+               cprintf("%s\n", CCC->cs_inet_email);
        }
-       if (!IsEmptyStr(CC->cs_inet_other_emails)) {
-               num_secondary_emails = num_tokens(CC->cs_inet_other_emails, '|');
+       if (!IsEmptyStr(CCC->cs_inet_other_emails)) {
+               num_secondary_emails = num_tokens(CCC->cs_inet_other_emails, '|');
                for (i=0; i<num_secondary_emails; ++i) {
-                       extract_token(buf, CC->cs_inet_other_emails,i,'|',sizeof CC->cs_inet_other_emails);
+                       extract_token(buf, CCC->cs_inet_other_emails,i,'|',sizeof CCC->cs_inet_other_emails);
                        cprintf("%s\n", buf);
                }
        }
@@ -1014,9 +1055,9 @@ void dvca_mime_callback(char *name, char *filename, char *partnum, char *disp,
                char *cbid, void *cbuserdata) {
 
        struct vCard *v;
-       char displayname[256];
+       char displayname[256] = "";
        int displayname_len;
-       char emailaddr[256];
+       char emailaddr[256] = "";
        int i;
        int has_commas = 0;
 
@@ -1061,7 +1102,7 @@ void dvca_callback(long msgnum, void *userdata) {
 
        msg = CtdlFetchMessage(msgnum, 1);
        if (msg == NULL) return;
-       mime_parser(msg->cm_fields['M'],
+       mime_parser(msg->cm_fields[eMesageText],
                NULL,
                *dvca_mime_callback,    /* callback function */
                NULL, NULL,
@@ -1116,13 +1157,13 @@ void check_get(void) {
        time(&CC->lastcmd);
        memset(cmdbuf, 0, sizeof cmdbuf); /* Clear it, just in case */
        if (client_getln(cmdbuf, sizeof cmdbuf) < 1) {
-               syslog(LOG_CRIT, "vcard client disconnected: ending session.\n");
+               syslog(LOG_CRIT, "vcard client disconnected: ending session.");
                CC->kill_me = KILLME_CLIENT_DISCONNECTED;
                return;
        }
-       syslog(LOG_INFO, ": %s\n", cmdbuf);
+       syslog(LOG_INFO, ": %s", cmdbuf);
        while (strlen(cmdbuf) < 3) strcat(cmdbuf, " ");
-       syslog(LOG_INFO, "[ %s]\n", cmdbuf);
+       syslog(LOG_INFO, "[ %s]", cmdbuf);
        
        if (strncasecmp(cmdbuf, "GET ", 4)==0)
        {
@@ -1139,22 +1180,20 @@ void check_get(void) {
                {
 
                        cprintf("200 OK %s\n", internet_addr);
-                       syslog(LOG_INFO, "sending 200 OK for the room %s\n", rcpt->display_recp);
+                       syslog(LOG_INFO, "sending 200 OK for the room %s", rcpt->display_recp);
                }
                else 
                {
                        cprintf("500 REJECT noone here by that name.\n");
                        
-                       syslog(LOG_INFO, "sending 500 REJECT noone here by that name: %s\n", internet_addr);
+                       syslog(LOG_INFO, "sending 500 REJECT no one here by that name: %s", internet_addr);
                }
                if (rcpt != NULL) 
                        free_recipients(rcpt);
        }
-       else 
-       {
+       else {
                cprintf("500 REJECT invalid Query.\n");
-               
-               syslog(LOG_INFO, "sending 500 REJECT invalid Query: %s\n", internet_addr);
+               syslog(LOG_INFO, "sending 500 REJECT invalid query: %s", internet_addr);
        }
 }
 
@@ -1176,7 +1215,7 @@ void vcard_CtdlCreateRoom(void)
 
        /* Set expiration policy to manual; otherwise objects will be lost! */
        if (CtdlGetRoomLock(&qr, USERCONTACTSROOM)) {
-               syslog(LOG_ERR, "Couldn't get the user CONTACTS room!\n");
+               syslog(LOG_ERR, "Couldn't get the user CONTACTS room!");
                return;
        }
        qr.QRep.expire_mode = EXPIRE_MANUAL;
@@ -1286,7 +1325,7 @@ void strip_addresses_already_have(long msgnum, void *userdata) {
 
        msg = CtdlFetchMessage(msgnum, 1);
        if (msg == NULL) return;
-       v = vcard_load(msg->cm_fields['M']);
+       v = vcard_load(msg->cm_fields[eMesageText]);
        CtdlFreeMessage(msg);
 
        i = 0;
@@ -1315,7 +1354,6 @@ void strip_addresses_already_have(long msgnum, void *userdata) {
  */
 void store_this_ha(struct addresses_to_be_filed *aptr) {
        struct CtdlMessage *vmsg = NULL;
-       long vmsgnum = (-1L);
        char *ser = NULL;
        struct vCard *v = NULL;
        char recipient[256];
@@ -1323,7 +1361,7 @@ void store_this_ha(struct addresses_to_be_filed *aptr) {
 
        /* First remove any addresses we already have in the address book */
        CtdlUserGoto(aptr->roomname, 0, 0, NULL, NULL);
-       CtdlForEachMessage(MSGS_ALL, 0, NULL, "^[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$", NULL,
+       CtdlForEachMessage(MSGS_ALL, 0, NULL, "[Tt][Ee][Xx][Tt]/.*[Vv][Cc][Aa][Rr][Dd]$", NULL,
                strip_addresses_already_have, aptr->collected_addresses);
 
        if (!IsEmptyStr(aptr->collected_addresses))
@@ -1339,20 +1377,20 @@ void store_this_ha(struct addresses_to_be_filed *aptr) {
                        vmsg->cm_magic = CTDLMESSAGE_MAGIC;
                        vmsg->cm_anon_type = MES_NORMAL;
                        vmsg->cm_format_type = FMT_RFC822;
-                       vmsg->cm_fields['A'] = strdup("Citadel");
-                       vmsg->cm_fields['E'] =  strdup(vcard_get_prop(v, "UID", 1, 0, 0));
+                       vmsg->cm_fields[eAuthor] = strdup("Citadel");
+                       vmsg->cm_fields[eExclusiveID] =  strdup(vcard_get_prop(v, "UID", 1, 0, 0));
                        ser = vcard_serialize(v);
                        if (ser != NULL) {
-                               vmsg->cm_fields['M'] = malloc(strlen(ser) + 1024);
-                               sprintf(vmsg->cm_fields['M'],
+                               vmsg->cm_fields[eMesageText] = malloc(strlen(ser) + 1024);
+                               sprintf(vmsg->cm_fields[eMesageText],
                                        "Content-type: " VCARD_MIME_TYPE
                                        "\r\n\r\n%s\r\n", ser);
                                free(ser);
                        }
                        vcard_free(v);
 
-                       syslog(LOG_DEBUG, "Adding contact: %s\n", recipient);
-                       vmsgnum = CtdlSubmitMsg(vmsg, NULL, aptr->roomname, QP_EADDR);
+                       syslog(LOG_DEBUG, "Adding contact: %s", recipient);
+                       CtdlSubmitMsg(vmsg, NULL, aptr->roomname, QP_EADDR);
                        CtdlFreeMessage(vmsg);
                }
        }
@@ -1422,7 +1460,7 @@ CTDL_MODULE_INIT(vcard)
 
        if (!threading)
        {
-               CtdlRegisterSessionHook(vcard_session_login_hook, EVT_LOGIN);
+               CtdlRegisterSessionHook(vcard_session_login_hook, EVT_LOGIN, PRIO_LOGIN + 70);
                CtdlRegisterMessageHook(vcard_upload_beforesave, EVT_BEFORESAVE);
                CtdlRegisterMessageHook(vcard_upload_aftersave, EVT_AFTERSAVE);
                CtdlRegisterDeleteHook(vcard_delete_remove);
@@ -1436,7 +1474,7 @@ CTDL_MODULE_INIT(vcard)
                CtdlRegisterUserHook(vcard_newuser, EVT_NEWUSER);
                CtdlRegisterUserHook(vcard_purge, EVT_PURGEUSER);
                CtdlRegisterNetprocHook(vcard_extract_from_network);
-               CtdlRegisterSessionHook(store_harvested_addresses, EVT_TIMER);
+               CtdlRegisterSessionHook(store_harvested_addresses, EVT_TIMER, PRIO_CLEANUP + 470);
                CtdlRegisterFixedOutputHook("text/x-vcard", vcard_fixed_output);
                CtdlRegisterFixedOutputHook("text/vcard", vcard_fixed_output);
 
@@ -1459,6 +1497,13 @@ CTDL_MODULE_INIT(vcard)
                        fp = fopen(filename, "a");
                        if (fp != NULL) fclose(fp);
                        rv = chown(filename, CTDLUID, (-1));
+                       if (rv == -1)
+                               syslog(LOG_EMERG, "Failed to adjust ownership of: %s [%s]", 
+                                      filename, strerror(errno));
+                       rv = chmod(filename, 0600);
+                       if (rv == -1)
+                               syslog(LOG_EMERG, "Failed to adjust ownership of: %s [%s]", 
+                                      filename, strerror(errno));
                }
 
                /* for postfix tcpdict */
@@ -1470,6 +1515,6 @@ CTDL_MODULE_INIT(vcard)
                                        CitadelServiceDICT_TCP);
        }
        
-       /* return our Subversion id for the Log */
+       /* return our module name for the log */
        return "vcard";
 }