* move policy.c into modules/expire/expire_policy.c, since it just controls this.
[citadel.git] / citadel / modules / wiki / serv_wiki.c
index 06e404fe40835a63aa73fc7418a4321fd9a6add0..1011546cfdded663f6691b530f0d2d95d5f4e7e1 100644 (file)
@@ -53,7 +53,6 @@
 #include "config.h"
 #include "control.h"
 #include "user_ops.h"
-#include "policy.h"
 #include "database.h"
 #include "msgbase.h"
 #include "euidindex.h"
@@ -96,7 +95,7 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        int nbytes = 0;
        char *diffbuf = NULL;
        size_t diffbuf_len = 0;
-       char *ptr = NULL;
+       const char *ptr = NULL;
 
        if (!CCC->logged_in) return(0); /* Only do this if logged in. */
 
@@ -108,8 +107,9 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        /* If this isn't a MIME message, don't bother. */
        if (msg->cm_format_type != 4) return(0);
 
-       /* If there's no EUID we can't do this. */
-       if (msg->cm_fields['E'] == NULL) return(0);
+       /* If there's no EUID we can't do this.  Reject the post. */
+       if (msg->cm_fields['E'] == NULL) return(1);
+
        snprintf(history_page, sizeof history_page, "%s_HISTORY_", msg->cm_fields['E']);
 
        /* Make sure we're saving a real wiki page rather than a wiki history page.
@@ -125,8 +125,14 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        /* If there's no message text, obviously this is all b0rken and shouldn't happen at all */
        if (msg->cm_fields['M'] == NULL) return(0);
 
+       /* Set the message subject identical to the page name */
+       if (msg->cm_fields['U'] != NULL) {
+               free(msg->cm_fields['U']);
+       }
+       msg->cm_fields['U'] = strdup(msg->cm_fields['E']);
+
        /* See if we can retrieve the previous version. */
-       old_msgnum = locate_message_by_euid(msg->cm_fields['E'], &CCC->room);
+       old_msgnum = CtdlLocateMessageByEuid(msg->cm_fields['E'], &CCC->room);
        if (old_msgnum > 0L) {
                old_msg = CtdlFetchMessage(old_msgnum, 1);
        }
@@ -177,7 +183,9 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                        diffbuf_len += nbytes;
                } while (nbytes == 1024);
                diffbuf[diffbuf_len] = 0;
-               pclose(fp);
+               if (pclose(fp) != 0) {
+                       CtdlLogPrintf(CTDL_ERR, "pclose() returned an error - diff failed\n");
+               }
        }
        CtdlLogPrintf(CTDL_DEBUG, "diff length is %d bytes\n", diffbuf_len);
 
@@ -195,7 +203,7 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
 
        /* Now look for the existing edit history */
 
-       history_msgnum = locate_message_by_euid(history_page, &CCC->room);
+       history_msgnum = CtdlLocateMessageByEuid(history_page, &CCC->room);
        history_msg = NULL;
        if (history_msgnum > 0L) {
                history_msg = CtdlFetchMessage(history_msgnum, 1);
@@ -212,6 +220,7 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                history_msg->cm_fields['R'] = strdup(CCC->room.QRname);
                history_msg->cm_fields['E'] = strdup(history_page);
                history_msg->cm_fields['U'] = strdup(history_page);
+               history_msg->cm_fields['1'] = strdup("1");              /* suppress full text indexing */
                snprintf(boundary, sizeof boundary, "Citadel--Multipart--%04x--%08lx", getpid(), time(NULL));
                history_msg->cm_fields['M'] = malloc(1024);
                snprintf(history_msg->cm_fields['M'], 1024,
@@ -227,7 +236,14 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
 
        /* Update the history message (regardless of whether it's new or existing) */
 
-       /* First, figure out the boundary string.  We do this even when we generated the
+       /* Remove the Message-ID from the old version of the history message.  This will cause a brand
+        * new one to be generated, avoiding an uninitentional hit of the loop zapper when we replicate.
+        */
+       if (history_msg->cm_fields['I'] != NULL) {
+               free(history_msg->cm_fields['I']);
+       }
+
+       /* Figure out the boundary string.  We do this even when we generated the
         * boundary string in the above code, just to be safe and consistent.
         */
        strcpy(boundary, "");
@@ -349,7 +365,7 @@ void wiki_history(char *pagename) {
        }
 
        snprintf(history_page_name, sizeof history_page_name, "%s_HISTORY_", pagename);
-       msgnum = locate_message_by_euid(history_page_name, &CC->room);
+       msgnum = CtdlLocateMessageByEuid(history_page_name, &CC->room);
        if (msgnum > 0L) {
                msg = CtdlFetchMessage(msgnum, 1);
        }
@@ -408,7 +424,7 @@ void wiki_rev_callback(char *name, char *filename, char *partnum, char *disp,
        CtdlLogPrintf(CTDL_DEBUG, "callback found rev: %s\n", this_rev);
 
        /* Perform the patch */
-       fp = popen("patch -f -s -p0 >/dev/null 2>/dev/null", "w");
+       fp = popen("patch -f -s -p0 --global-reject-file=/dev/null >/dev/null 2>/dev/null", "w");
        if (fp) {
                /* Replace the filenames in the patch with the tempfilename we're actually tweaking */
                fprintf(fp, "--- %s\n", hecbd->tempfilename);
@@ -427,8 +443,10 @@ void wiki_rev_callback(char *name, char *filename, char *partnum, char *disp,
                                        fprintf(fp, "%s\n", buf);
                                }
                        }
-               } while ((*ptr != 0) && ((int)ptr < ((int)content + length)));
-               pclose(fp);
+               } while ((*ptr != 0) && (ptr < ((char*)content + length)));
+               if (pclose(fp) != 0) {
+                       CtdlLogPrintf(CTDL_ERR, "pclose() returned an error - patch failed\n");
+               }
        }
 
        if (!strcasecmp(this_rev, hecbd->stop_when)) {
@@ -450,6 +468,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
        char history_page_name[270];
        long msgnum;
        char temp[PATH_MAX];
+       char timestamp[64];
        struct CtdlMessage *msg;
        FILE *fp;
        struct HistoryEraserCallBackData hecbd;
@@ -470,7 +489,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
        /* Begin by fetching the current version of the page.  We're going to patch
         * backwards through the diffs until we get the one we want.
         */
-       msgnum = locate_message_by_euid(pagename, &CC->room);
+       msgnum = CtdlLocateMessageByEuid(pagename, &CC->room);
        if (msgnum > 0L) {
                msg = CtdlFetchMessage(msgnum, 1);
        }
@@ -504,7 +523,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
        /* Get the revision history */
 
        snprintf(history_page_name, sizeof history_page_name, "%s_HISTORY_", pagename);
-       msgnum = locate_message_by_euid(history_page_name, &CC->room);
+       msgnum = CtdlLocateMessageByEuid(history_page_name, &CC->room);
        if (msgnum > 0L) {
                msg = CtdlFetchMessage(msgnum, 1);
        }
@@ -542,13 +561,12 @@ void wiki_rev(char *pagename, char *rev, char *operation)
 
        /* We have the desired revision on disk.  Now do something with it. */
 
-       else if (!strcasecmp(operation, "fetch")) {
+       else if ( (!strcasecmp(operation, "fetch")) || (!strcasecmp(operation, "revert")) ) {
                msg = malloc(sizeof(struct CtdlMessage));
                memset(msg, 0, sizeof(struct CtdlMessage));
                msg->cm_magic = CTDLMESSAGE_MAGIC;
                msg->cm_anon_type = MES_NORMAL;
                msg->cm_format_type = FMT_RFC822;
-               msg->cm_fields['A'] = strdup("Citadel");
                fp = fopen(temp, "r");
                if (fp) {
                        fseek(fp, 0L, SEEK_END);
@@ -556,46 +574,38 @@ void wiki_rev(char *pagename, char *rev, char *operation)
                        fseek(fp, 0L, SEEK_SET);
                        msg->cm_fields['M'] = malloc(len + 1);
                        rv = fread(msg->cm_fields['M'], len, 1, fp);
-                       CtdlLogPrintf(CTDL_DEBUG, "\033[32mdid %d blocks of %d bytes\033[0m\n", rv, len);
+                       CtdlLogPrintf(CTDL_DEBUG, "did %d blocks of %d bytes\n", rv, len);
                        msg->cm_fields['M'][len] = 0;
                        fclose(fp);
                }
-               CtdlCreateRoom(wwm, 5, "", 0, 1, 1, VIEW_BBS);  /* If it already exists, not an error */
-               msgnum = CtdlSubmitMsg(msg, NULL, wwm, 0);      /* Store the revision here */
-               CtdlFreeMessage(msg);
-               cprintf("%d %ld\n", CIT_OK, msgnum);            /* And give the client a msgnum */
-       }
-
-       else if (!strcasecmp(operation, "revert")) {
-               msg = malloc(sizeof(struct CtdlMessage));
-               memset(msg, 0, sizeof(struct CtdlMessage));
-               msg->cm_magic = CTDLMESSAGE_MAGIC;
-               msg->cm_anon_type = MES_NORMAL;
-               msg->cm_format_type = FMT_RFC822;
-               msg->cm_fields['A'] = strdup(CC->user.fullname);
-               msg->cm_fields['F'] = strdup(CC->cs_inet_email);
-               msg->cm_fields['O'] = strdup(CC->room.QRname);
-               msg->cm_fields['N'] = strdup(NODENAME);
-               msg->cm_fields['E'] = strdup(pagename);
-               /* FIXME do 'T' */
-               fp = fopen(temp, "r");
-               if (fp) {
-                       fseek(fp, 0L, SEEK_END);
-                       len = ftell(fp);
-                       fseek(fp, 0L, SEEK_SET);
-                       msg->cm_fields['M'] = malloc(len + 1);
-                       rv = fread(msg->cm_fields['M'], len, 1, fp);
-                       CtdlLogPrintf(CTDL_DEBUG, "\033[31mdid %d blocks of %d bytes\033[0m\n", rv, len);
-                       msg->cm_fields['M'][len] = 0;
-                       fclose(fp);
+               if (len <= 0) {
+                       msgnum = (-1L);
+               }
+               else if (!strcasecmp(operation, "fetch")) {
+                       msg->cm_fields['A'] = strdup("Citadel");
+                       CtdlCreateRoom(wwm, 5, "", 0, 1, 1, VIEW_BBS);  /* Not an error if already exists */
+                       msgnum = CtdlSubmitMsg(msg, NULL, wwm, 0);      /* Store the revision here */
+               }
+               else if (!strcasecmp(operation, "revert")) {
+                       snprintf(timestamp, sizeof timestamp, "%ld", time(NULL));
+                       msg->cm_fields['T'] = strdup(timestamp);
+                       msg->cm_fields['A'] = strdup(CC->user.fullname);
+                       msg->cm_fields['F'] = strdup(CC->cs_inet_email);
+                       msg->cm_fields['O'] = strdup(CC->room.QRname);
+                       msg->cm_fields['N'] = strdup(NODENAME);
+                       msg->cm_fields['E'] = strdup(pagename);
+                       msgnum = CtdlSubmitMsg(msg, NULL, "", 0);       /* Replace the current revision */
+               }
+               else {
+                       /* Theoretically it is impossible to get here, but throw an error anyway */
+                       msgnum = (-1L);
                }
-               msgnum = CtdlSubmitMsg(msg, NULL, "", 0);       /* Store it back into the room */
                CtdlFreeMessage(msg);
                if (msgnum >= 0L) {
-                       cprintf("%d %ld\n", CIT_OK, msgnum);            /* And give the client a msgnum */
+                       cprintf("%d %ld\n", CIT_OK, msgnum);            /* Give the client a msgnum */
                }
                else {
-                       cprintf("%d An internal error has occurred.\n", ERROR+INTERNAL_ERROR);
+                       cprintf("%d Error %ld has occurred.\n", ERROR+INTERNAL_ERROR, msgnum);
                }
        }