use an Enum for the cm_fields vector instead of nameless chars
[citadel.git] / citadel / modules / wiki / serv_wiki.c
index b24822274fbe8577fdd7ebd9c1479dfd81a7c82a..799a3f322dfcf69d89057ecf7ec833f35d4d604f 100644 (file)
@@ -1,21 +1,15 @@
 /*
  * Server-side module for Wiki rooms.  This handles things like version control. 
  * 
- * Copyright (c) 2009-2011 by the citadel.org team
+ * Copyright (c) 2009-2012 by the citadel.org team
  *
  * This program is open source software.  You can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of the
- * License, or (at your option) any later version.
+ * modify it under the terms of the GNU General Public License, version 3.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #include "sysdep.h"
@@ -83,6 +77,7 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        struct CtdlMessage *history_msg = NULL;
        char diff_old_filename[PATH_MAX];
        char diff_new_filename[PATH_MAX];
+       char diff_out_filename[PATH_MAX];
        char diff_cmd[PATH_MAX];
        FILE *fp;
        int rv;
@@ -90,7 +85,6 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        char boundary[256];
        char prefixed_boundary[258];
        char buf[1024];
-       int nbytes = 0;
        char *diffbuf = NULL;
        size_t diffbuf_len = 0;
        char *ptr = NULL;
@@ -106,31 +100,31 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        if (msg->cm_format_type != 4) return(0);
 
        /* If there's no EUID we can't do this.  Reject the post. */
-       if (msg->cm_fields['E'] == NULL) return(1);
+       if (msg->cm_fields[eExclusiveID] == NULL) return(1);
 
-       snprintf(history_page, sizeof history_page, "%s_HISTORY_", msg->cm_fields['E']);
+       snprintf(history_page, sizeof history_page, "%s_HISTORY_", msg->cm_fields[eExclusiveID]);
 
        /* Make sure we're saving a real wiki page rather than a wiki history page.
         * This is important in order to avoid recursing infinitely into this hook.
         */
-       if (    (strlen(msg->cm_fields['E']) >= 9)
-               && (!strcasecmp(&msg->cm_fields['E'][strlen(msg->cm_fields['E'])-9], "_HISTORY_"))
+       if (    (strlen(msg->cm_fields[eExclusiveID]) >= 9)
+               && (!strcasecmp(&msg->cm_fields[eExclusiveID][strlen(msg->cm_fields[eExclusiveID])-9], "_HISTORY_"))
        ) {
                syslog(LOG_DEBUG, "History page not being historied\n");
                return(0);
        }
 
        /* If there's no message text, obviously this is all b0rken and shouldn't happen at all */
-       if (msg->cm_fields['M'] == NULL) return(0);
+       if (msg->cm_fields[eMesageText] == NULL) return(0);
 
        /* Set the message subject identical to the page name */
-       if (msg->cm_fields['U'] != NULL) {
-               free(msg->cm_fields['U']);
+       if (msg->cm_fields[eMsgSubject] != NULL) {
+               free(msg->cm_fields[eMsgSubject]);
        }
-       msg->cm_fields['U'] = strdup(msg->cm_fields['E']);
+       msg->cm_fields[eMsgSubject] = strdup(msg->cm_fields[eExclusiveID]);
 
        /* See if we can retrieve the previous version. */
-       old_msgnum = CtdlLocateMessageByEuid(msg->cm_fields['E'], &CCC->room);
+       old_msgnum = CtdlLocateMessageByEuid(msg->cm_fields[eExclusiveID], &CCC->room);
        if (old_msgnum > 0L) {
                old_msg = CtdlFetchMessage(old_msgnum, 1);
        }
@@ -138,13 +132,13 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                old_msg = NULL;
        }
 
-       if ((old_msg != NULL) && (old_msg->cm_fields['M'] == NULL)) {   /* old version is corrupt? */
+       if ((old_msg != NULL) && (old_msg->cm_fields[eMesageText] == NULL)) {   /* old version is corrupt? */
                CtdlFreeMessage(old_msg);
                old_msg = NULL;
        }
        
        /* If no changes were made, don't bother saving it again */
-       if ((old_msg != NULL) && (!strcmp(msg->cm_fields['M'], old_msg->cm_fields['M']))) {
+       if ((old_msg != NULL) && (!strcmp(msg->cm_fields[eMesageText], old_msg->cm_fields[eMesageText]))) {
                CtdlFreeMessage(old_msg);
                return(1);
        }
@@ -154,41 +148,50 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
         */
        CtdlMakeTempFileName(diff_old_filename, sizeof diff_old_filename);
        CtdlMakeTempFileName(diff_new_filename, sizeof diff_new_filename);
+       CtdlMakeTempFileName(diff_out_filename, sizeof diff_out_filename);
 
        if (old_msg != NULL) {
                fp = fopen(diff_old_filename, "w");
-               rv = fwrite(old_msg->cm_fields['M'], strlen(old_msg->cm_fields['M']), 1, fp);
+               rv = fwrite(old_msg->cm_fields[eMesageText], strlen(old_msg->cm_fields[eMesageText]), 1, fp);
                fclose(fp);
                CtdlFreeMessage(old_msg);
        }
 
        fp = fopen(diff_new_filename, "w");
-       rv = fwrite(msg->cm_fields['M'], strlen(msg->cm_fields['M']), 1, fp);
+       rv = fwrite(msg->cm_fields[eMesageText], strlen(msg->cm_fields[eMesageText]), 1, fp);
        fclose(fp);
 
-       diffbuf_len = 0;
-       diffbuf = NULL;
        snprintf(diff_cmd, sizeof diff_cmd,
-               "diff -u %s %s",
+               DIFF " -u %s %s >%s",
                diff_new_filename,
-               ((old_msg != NULL) ? diff_old_filename : "/dev/null")
+               ((old_msg != NULL) ? diff_old_filename : "/dev/null"),
+               diff_out_filename
        );
-       fp = popen(diff_cmd, "r");
+       syslog(LOG_DEBUG, "diff cmd: %s", diff_cmd);
+       rv = system(diff_cmd);
+       syslog(LOG_DEBUG, "diff cmd returned %d", rv);
+
+       diffbuf_len = 0;
+       diffbuf = NULL;
+       fp = fopen(diff_out_filename, "r");
+       if (fp == NULL) {
+               fp = fopen("/dev/null", "r");
+       }
        if (fp != NULL) {
-               do {
-                       diffbuf = realloc(diffbuf, diffbuf_len + 1025);
-                       nbytes = fread(&diffbuf[diffbuf_len], 1, 1024, fp);
-                       diffbuf_len += nbytes;
-               } while (nbytes == 1024);
+               fseek(fp, 0L, SEEK_END);
+               diffbuf_len = ftell(fp);
+               fseek(fp, 0L, SEEK_SET);
+               diffbuf = malloc(diffbuf_len + 1);
+               fread(diffbuf, diffbuf_len, 1, fp);
                diffbuf[diffbuf_len] = 0;
-               if (pclose(fp) != 0) {
-                       syslog(LOG_ERR, "pclose() returned an error - diff failed\n");
-               }
+               fclose(fp);
        }
-       syslog(LOG_DEBUG, "diff length is %d bytes\n", diffbuf_len);
+
+       syslog(LOG_DEBUG, "diff length is "SIZE_T_FMT" bytes", diffbuf_len);
 
        unlink(diff_old_filename);
        unlink(diff_new_filename);
+       unlink(diff_out_filename);
 
        /* Determine whether this was a bogus (empty) edit */
        if ((diffbuf_len = 0) && (diffbuf != NULL)) {
@@ -214,14 +217,14 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                history_msg->cm_magic = CTDLMESSAGE_MAGIC;
                history_msg->cm_anon_type = MES_NORMAL;
                history_msg->cm_format_type = FMT_RFC822;
-               history_msg->cm_fields['A'] = strdup("Citadel");
-               history_msg->cm_fields['R'] = strdup(CCC->room.QRname);
-               history_msg->cm_fields['E'] = strdup(history_page);
-               history_msg->cm_fields['U'] = strdup(history_page);
-               history_msg->cm_fields['1'] = strdup("1");              /* suppress full text indexing */
+               history_msg->cm_fields[eAuthor] = strdup("Citadel");
+               history_msg->cm_fields[eRecipient] = strdup(CCC->room.QRname);
+               history_msg->cm_fields[eExclusiveID] = strdup(history_page);
+               history_msg->cm_fields[eMsgSubject] = strdup(history_page);
+               history_msg->cm_fields[eSuppressIdx] = strdup("1");             /* suppress full text indexing */
                snprintf(boundary, sizeof boundary, "Citadel--Multipart--%04x--%08lx", getpid(), time(NULL));
-               history_msg->cm_fields['M'] = malloc(1024);
-               snprintf(history_msg->cm_fields['M'], 1024,
+               history_msg->cm_fields[eMesageText] = malloc(1024);
+               snprintf(history_msg->cm_fields[eMesageText], 1024,
                        "Content-type: multipart/mixed; boundary=\"%s\"\n\n"
                        "This is a Citadel wiki history encoded as multipart MIME.\n"
                        "Each part is comprised of a diff script representing one change set.\n"
@@ -237,8 +240,9 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
        /* Remove the Message-ID from the old version of the history message.  This will cause a brand
         * new one to be generated, avoiding an uninitentional hit of the loop zapper when we replicate.
         */
-       if (history_msg->cm_fields['I'] != NULL) {
-               free(history_msg->cm_fields['I']);
+       if (history_msg->cm_fields[emessageId] != NULL) {
+               free(history_msg->cm_fields[emessageId]);
+               history_msg->cm_fields[emessageId] = NULL;
        }
 
        /* Figure out the boundary string.  We do this even when we generated the
@@ -246,7 +250,7 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
         */
        strcpy(boundary, "");
 
-       ptr = history_msg->cm_fields['M'];
+       ptr = history_msg->cm_fields[eMesageText];
        do {
                ptr = memreadline(ptr, buf, sizeof buf);
                if (*ptr != 0) {
@@ -271,26 +275,26 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                }
        } while ( (IsEmptyStr(boundary)) && (*ptr != 0) );
 
-       /* Now look for the first boundary.  That is where we need to insert our fun.
+       /*
+        * Now look for the first boundary.  That is where we need to insert our fun.
         */
        if (!IsEmptyStr(boundary)) {
                snprintf(prefixed_boundary, sizeof prefixed_boundary, "--%s", boundary);
-               history_msg->cm_fields['M'] = realloc(history_msg->cm_fields['M'],
-                       strlen(history_msg->cm_fields['M']) + strlen(diffbuf) + 1024
+               history_msg->cm_fields[eMesageText] = realloc(history_msg->cm_fields[eMesageText],
+                       strlen(history_msg->cm_fields[eMesageText]) + strlen(diffbuf) + 1024
                );
-               ptr = bmstrcasestr(history_msg->cm_fields['M'], prefixed_boundary);
+               ptr = bmstrcasestr(history_msg->cm_fields[eMesageText], prefixed_boundary);
                if (ptr != NULL) {
                        char *the_rest_of_it = strdup(ptr);
-                       char uuid[32];
+                       char uuid[64];
                        char memo[512];
-                       char encoded_memo[768];
+                       char encoded_memo[1024];
                        generate_uuid(uuid);
                        snprintf(memo, sizeof memo, "%s|%ld|%s|%s", 
                                uuid,
                                time(NULL),
                                CCC->user.fullname,
                                config.c_nodename
-                               /* no longer logging CCC->cs_inet_email */
                        );
                        CtdlEncodeBase64(encoded_memo, memo, strlen(memo), 0);
                        sprintf(ptr, "--%s\n"
@@ -309,8 +313,10 @@ int wiki_upload_beforesave(struct CtdlMessage *msg) {
                        free(the_rest_of_it);
                }
 
-               history_msg->cm_fields['T'] = realloc(history_msg->cm_fields['T'], 32);
-               snprintf(history_msg->cm_fields['T'], 32, "%ld", time(NULL));
+               history_msg->cm_fields[eTimestamp] = realloc(history_msg->cm_fields[eTimestamp], 32);
+               if (history_msg->cm_fields[eTimestamp] != NULL) {
+                       snprintf(history_msg->cm_fields[eTimestamp], 32, "%ld", time(NULL));
+               }
        
                CtdlSubmitMsg(history_msg, NULL, "", 0);
        }
@@ -371,7 +377,7 @@ void wiki_history(char *pagename) {
                msg = NULL;
        }
 
-       if ((msg != NULL) && (msg->cm_fields['M'] == NULL)) {
+       if ((msg != NULL) && (msg->cm_fields[eMesageText] == NULL)) {
                CtdlFreeMessage(msg);
                msg = NULL;
        }
@@ -383,7 +389,7 @@ void wiki_history(char *pagename) {
 
        
        cprintf("%d Revision history for '%s'\n", LISTING_FOLLOWS, pagename);
-       mime_parser(msg->cm_fields['M'], NULL, *wiki_history_callback, NULL, NULL, NULL, 0);
+       mime_parser(msg->cm_fields[eMesageText], NULL, *wiki_history_callback, NULL, NULL, NULL, 0);
        cprintf("000\n");
 
        CtdlFreeMessage(msg);
@@ -419,11 +425,10 @@ void wiki_rev_callback(char *name, char *filename, char *partnum, char *disp,
 
        CtdlDecodeBase64(memo, filename, strlen(filename));
        extract_token(this_rev, memo, 0, '|', sizeof this_rev);
-       syslog(LOG_DEBUG, "callback found rev: %s\n", this_rev);
+       striplt(this_rev);
 
        /* Perform the patch */
-       //fp = popen("patch -f -s -p0 --global-reject-file=/dev/null >/dev/null 2>/dev/null", "w");
-       fp = popen("patch -f -s -p0 --global-reject-file=/dev/null >/dev/null 2>>/tmp/patcherr.txt", "w");
+       fp = popen(PATCH " -f -s -p0 -r /dev/null >/dev/null 2>/dev/null", "w");
        if (fp) {
                /* Replace the filenames in the patch with the tempfilename we're actually tweaking */
                fprintf(fp, "--- %s\n", hecbd->tempfilename);
@@ -504,7 +509,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
                msg = NULL;
        }
 
-       if ((msg != NULL) && (msg->cm_fields['M'] == NULL)) {
+       if ((msg != NULL) && (msg->cm_fields[eMesageText] == NULL)) {
                CtdlFreeMessage(msg);
                msg = NULL;
        }
@@ -519,7 +524,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
        CtdlMakeTempFileName(temp, sizeof temp);
        fp = fopen(temp, "w");
        if (fp != NULL) {
-               r = fwrite(msg->cm_fields['M'], strlen(msg->cm_fields['M']), 1, fp);
+               r = fwrite(msg->cm_fields[eMesageText], strlen(msg->cm_fields[eMesageText]), 1, fp);
                fclose(fp);
        }
        else {
@@ -538,7 +543,7 @@ void wiki_rev(char *pagename, char *rev, char *operation)
                msg = NULL;
        }
 
-       if ((msg != NULL) && (msg->cm_fields['M'] == NULL)) {
+       if ((msg != NULL) && (msg->cm_fields[eMesageText] == NULL)) {
                CtdlFreeMessage(msg);
                msg = NULL;
        }
@@ -555,8 +560,9 @@ void wiki_rev(char *pagename, char *rev, char *operation)
        memset(&hecbd, 0, sizeof(struct HistoryEraserCallBackData));
        hecbd.tempfilename = temp;
        hecbd.stop_when = rev;
+       striplt(hecbd.stop_when);
 
-       mime_parser(msg->cm_fields['M'], NULL, *wiki_rev_callback, NULL, NULL, (void *)&hecbd, 0);
+       mime_parser(msg->cm_fields[eMesageText], NULL, *wiki_rev_callback, NULL, NULL, (void *)&hecbd, 0);
        CtdlFreeMessage(msg);
 
        /* Were we successful? */
@@ -579,28 +585,46 @@ void wiki_rev(char *pagename, char *rev, char *operation)
                        fseek(fp, 0L, SEEK_END);
                        len = ftell(fp);
                        fseek(fp, 0L, SEEK_SET);
-                       msg->cm_fields['M'] = malloc(len + 1);
-                       rv = fread(msg->cm_fields['M'], len, 1, fp);
+                       msg->cm_fields[eMesageText] = malloc(len + 1);
+                       rv = fread(msg->cm_fields[eMesageText], len, 1, fp);
                        syslog(LOG_DEBUG, "did %d blocks of %ld bytes\n", rv, len);
-                       msg->cm_fields['M'][len] = 0;
+                       msg->cm_fields[eMesageText][len] = 0;
                        fclose(fp);
                }
                if (len <= 0) {
                        msgnum = (-1L);
                }
                else if (!strcasecmp(operation, "fetch")) {
-                       msg->cm_fields['A'] = strdup("Citadel");
+                       msg->cm_fields[eAuthor] = strdup("Citadel");
                        CtdlCreateRoom(wwm, 5, "", 0, 1, 1, VIEW_BBS);  /* Not an error if already exists */
                        msgnum = CtdlSubmitMsg(msg, NULL, wwm, 0);      /* Store the revision here */
+
+                       /*
+                        * WARNING: VILE SLEAZY HACK
+                        * This will avoid the 'message xxx is not in this room' security error,
+                        * but only if the client fetches the message we just generated immediately
+                        * without first trying to perform other fetch operations.
+                        */
+                       if (CC->cached_msglist != NULL) {
+                               free(CC->cached_msglist);
+                               CC->cached_msglist = NULL;
+                               CC->cached_num_msgs = 0;
+                       }
+                       CC->cached_msglist = malloc(sizeof(long));
+                       if (CC->cached_msglist != NULL) {
+                               CC->cached_num_msgs = 1;
+                               CC->cached_msglist[0] = msgnum;
+                       }
+
                }
                else if (!strcasecmp(operation, "revert")) {
                        snprintf(timestamp, sizeof timestamp, "%ld", time(NULL));
-                       msg->cm_fields['T'] = strdup(timestamp);
-                       msg->cm_fields['A'] = strdup(CC->user.fullname);
-                       msg->cm_fields['F'] = strdup(CC->cs_inet_email);
-                       msg->cm_fields['O'] = strdup(CC->room.QRname);
-                       msg->cm_fields['N'] = strdup(NODENAME);
-                       msg->cm_fields['E'] = strdup(pagename);
+                       msg->cm_fields[eTimestamp] = strdup(timestamp);
+                       msg->cm_fields[eAuthor] = strdup(CC->user.fullname);
+                       msg->cm_fields[erFc822Addr] = strdup(CC->cs_inet_email);
+                       msg->cm_fields[eOriginalRoom] = strdup(CC->room.QRname);
+                       msg->cm_fields[eNodeName] = strdup(NODENAME);
+                       msg->cm_fields[eExclusiveID] = strdup(pagename);
                        msgnum = CtdlSubmitMsg(msg, NULL, "", 0);       /* Replace the current revision */
                }
                else {
@@ -668,6 +692,6 @@ CTDL_MODULE_INIT(wiki)
                CtdlRegisterProtoHook(cmd_wiki, "WIKI", "Commands related to Wiki management");
        }
 
-       /* return our Subversion id for the Log */
+       /* return our module name for the log */
        return "wiki";
 }