avoid decoding mime-parts unless we realy need to.
[citadel.git] / citadel / msgbase.c
index 1d411f4c99b8804845c11691a6ae380fc16fd3b7..41b8171b9fb289f34697063d02dae06f9a2a5da9 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * $Id$
- *
  * Implements the message store.
  *
  * Copyright (c) 1987-2010 by the citadel.org team
@@ -309,7 +307,10 @@ void headers_euid(long msgnum, void *userdata)
                return;
        }
 
-       cprintf("%ld|%s|\n", msgnum, (msg->cm_fields['E'] ? msg->cm_fields['E'] : ""));
+       cprintf("%ld|%s|%s\n", 
+               msgnum, 
+               (msg->cm_fields['E'] ? msg->cm_fields['E'] : ""),
+               (msg->cm_fields['T'] ? msg->cm_fields['T'] : "0"));
        CtdlFreeMessage(msg);
 }
 
@@ -353,7 +354,7 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
  * Retrieve the "seen" message list for the current room.
  */
 void CtdlGetSeen(char *buf, int which_set) {
-       struct visit vbuf;
+       visit vbuf;
 
        /* Learn about the user and room in question */
        CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
@@ -378,7 +379,7 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums,
        int was_seen = 0;
        long lo = (-1L);
        long hi = (-1L);
-       struct visit vbuf;
+       visit vbuf;
        long *msglist;
        int num_msgs = 0;
        StrBuf *vset;
@@ -604,7 +605,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string,
 {
 
        int a, i, j;
-       struct visit vbuf;
+       visit vbuf;
        struct cdbdata *cdbfr;
        long *msglist = NULL;
        int num_msgs = 0;
@@ -796,6 +797,8 @@ void cmd_msgs(char *cmdbuf)
        char search_string[1024];
        ForEachMsgCallback CallBack;
 
+       if (CtdlAccessCheck(ac_logged_in_or_guest)) return;
+
        extract_token(which, cmdbuf, 0, '|', sizeof which);
        cm_ref = extract_int(cmdbuf, 1);
        extract_token(search_string, cmdbuf, 1, '|', sizeof search_string);
@@ -832,11 +835,6 @@ void cmd_msgs(char *cmdbuf)
        else
                mode = MSGS_ALL;
 
-       if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
-               cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN);
-               return;
-       }
-
        if ( (mode == MSGS_SEARCH) && (!config.c_enable_fulltext) ) {
                cprintf("%d Full text index is not enabled on this server.\n",
                        ERROR + CMD_NOT_SUPPORTED);
@@ -930,14 +928,14 @@ void memfmout(
        const char *nl          /* string to terminate lines with */
 ) {
        int column = 0;
-       char ch = 0;
+       unsigned char ch = 0;
        char outbuf[1024];
        int len = 0;
        int nllen = 0;
 
        if (!mptr) return;
        nllen = strlen(nl);
-       while (ch=*(mptr++), ch > 0) {
+       while (ch=*(mptr++), ch != 0) {
 
                if (ch == '\n') {
                        client_write(outbuf, len);
@@ -1099,7 +1097,49 @@ void mime_spew_section(char *name, char *filename, char *partnum, char *disp,
        }
 }
 
+#ifdef MESSAGE_IN_ROOM
+/*
+ * Check if a message is in the current room.
+ * This is used by CtdlFetchMessage to prevent random picking
+ * of messages from users private rooms
+ *
+ * The message list should probably be cached against the CC->room
+ */
+int CtdlMessageInRoom(long msgnum)
+{
+       visit vbuf;
+       struct cdbdata *cdbfr;
+
+       /* Learn about the user and room in question */
+       CtdlGetUser(&CC->user, CC->curr_user);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
+
+       /* Load the message list */
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
+       if (cdbfr != NULL) {
+               long *msglist = NULL;
+               int num_msgs = 0;
+               int i;
+               int r = 0;
+               
+               msglist = (long *) cdbfr->ptr;
+               num_msgs = cdbfr->len / sizeof(long);
+
+               /* search for message msgnum */
+               for (i=0; i<num_msgs; i++) {
+                       if (msglist[i] == msgnum) {
+                               r = 1;
+                               break;
+                       }       
+               }
 
+               cdb_free(cdbfr);
+               return r;
+       } else {
+               return 0;
+       }
+}
+#endif
 
 /*
  * Load a message from disk into memory.
@@ -1119,6 +1159,13 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
 
        CtdlLogPrintf(CTDL_DEBUG, "CtdlFetchMessage(%ld, %d)\n", msgnum, with_body);
 
+#ifdef MESSAGE_IN_ROOM
+       if (!CtdlMessageInRoom(msgnum)) {
+               CtdlLogPrintf(CTDL_DEBUG, "Message %ld not in current room\n", msgnum);
+               return NULL;
+       }
+#endif
+
        dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
        if (dmsgtext == NULL) {
                return NULL;
@@ -1170,7 +1217,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
        if ( (ret->cm_fields['M'] == NULL) && (with_body) ) {
                dmsgtext = cdb_fetch(CDB_BIGMSGS, &msgnum, sizeof(long));
                if (dmsgtext != NULL) {
-                       ret->cm_fields['M'] = strdup(dmsgtext->ptr);
+                       ret->cm_fields['M'] = dmsgtext->ptr;
+                       dmsgtext->ptr = NULL;
                        cdb_free(dmsgtext);
                }
        }
@@ -1379,16 +1427,27 @@ void choose_preferred(char *name, char *filename, char *partnum, char *disp,
 /*
  * Now that we've chosen our preferred part, output it.
  */
-void output_preferred(char *name, char *filename, char *partnum, char *disp,
-               void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, char *cbid, void *cbuserdata)
+void output_preferred(char *name, 
+                     char *filename, 
+                     char *partnum, 
+                     char *disp,
+                     void *content, 
+                     char *cbtype, 
+                     char *cbcharset, 
+                     size_t length,
+                     char *encoding, 
+                     char *cbid, 
+                     void *cbuserdata)
 {
        int i;
        char buf[128];
        int add_newline = 0;
        char *text_content;
        struct ma_info *ma;
-       
+       char *decoded = NULL;
+       size_t bytes_decoded;
+       int rc = 0;
+
        ma = (struct ma_info *)cbuserdata;
 
        /* This is not the MIME part you're looking for... */
@@ -1401,8 +1460,21 @@ void output_preferred(char *name, char *filename, char *partnum, char *disp,
                extract_token(buf, CC->preferred_formats, i, '|', sizeof buf);
                if (!strcasecmp(buf, cbtype)) {
                        /* Yeah!  Go!  W00t!! */
+                       if (ma->dont_decode == 0)
+                               rc = mime_decode_now (content, 
+                                                     length,
+                                                     encoding,
+                                                     &decoded,
+                                                     &bytes_decoded);
+                       if (rc < 0)
+                               break; /* Give us the chance, maybe theres another one. */
+
+                       if (rc == 0) text_content = (char *)content;
+                       else {
+                               text_content = decoded;
+                               length = bytes_decoded;
+                       }
 
-                       text_content = (char *)content;
                        if (text_content[length-1] != '\n') {
                                ++add_newline;
                        }
@@ -1422,14 +1494,32 @@ void output_preferred(char *name, char *filename, char *partnum, char *disp,
                        cprintf("\n");
                        client_write(content, length);
                        if (add_newline) cprintf("\n");
+                       if (decoded != NULL) free(decoded);
                        return;
                }
        }
 
        /* No translations required or possible: output as text/plain */
        cprintf("Content-type: text/plain\n\n");
-       fixed_output(name, filename, partnum, disp, content, cbtype, cbcharset,
+       rc = 0;
+       if (ma->dont_decode == 0)
+               rc = mime_decode_now (content, 
+                                     length,
+                                     encoding,
+                                     &decoded,
+                                     &bytes_decoded);
+       if (rc < 0)
+               return; /* Give us the chance, maybe theres another one. */
+       
+       if (rc == 0) text_content = (char *)content;
+       else {
+               text_content = decoded;
+               length = bytes_decoded;
+       }
+
+       fixed_output(name, filename, partnum, disp, text_content, cbtype, cbcharset,
                        length, encoding, cbid, cbuserdata);
+       if (decoded != NULL) free(decoded);
 }
 
 
@@ -1458,16 +1548,18 @@ void extract_encapsulated_message(char *name, char *filename, char *partnum, cha
                memcpy(encap->msg, content, length);
                return;
        }
-
 }
 
 
-
-
-
-
+/* 
+ * Determine whether the currently logged in session has permission to read
+ * messages in the current room.
+ */
 int CtdlDoIHavePermissionToReadMessagesInThisRoom(void) {
-       if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
+       if (    (!(CC->logged_in))
+               && (!(CC->internal_pgm))
+               && (!config.c_guest_logins)
+       ) {
                return(om_not_logged_in);
        }
        return(om_ok);
@@ -1509,7 +1601,14 @@ int CtdlOutputMsg(long msg_num,          /* message number (local) to fetch */
                return(r);
        }
 
-       /* FIXME: check message id against msglist for this room */
+#ifdef MESSAGE_IN_ROOM
+       if (!CtdlMessageInRoom(msg_num)) {
+               CtdlLogPrintf(CTDL_DEBUG, "Message %ld not in current room\n", msg_num);
+               if (do_proto) cprintf("%d Can't locate msg %ld in room\n",
+                       ERROR + MESSAGE_NOT_FOUND, msg_num);
+               return(om_no_such_msg);
+       }
+#endif
 
        /*
         * Fetch the message from disk.  If we're in HEADERS_FAST mode,
@@ -1572,7 +1671,7 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
 
 char *qp_encode_email_addrs(char *source)
 {
-       char user[256], node[256], name[256];
+       char *user, *node, *name;
        const char headerStr[] = "=?UTF-8?Q?";
        char *Encoded;
        char *EncodedName;
@@ -1590,6 +1689,8 @@ char *qp_encode_email_addrs(char *source)
 
        if (source == NULL) return source;
        if (IsEmptyStr(source)) return source;
+       cit_backtrace();
+       CtdlLogPrintf(CTDL_DEBUG, "qp_encode_email_addrs: [%s]\n", source);
 
        AddrPtr = malloc (sizeof (long) * nAddrPtrMax);
        AddrUtf8 = malloc (sizeof (long) * nAddrPtrMax);
@@ -1637,6 +1738,10 @@ char *qp_encode_email_addrs(char *source)
 
        for (i = 0; i < nColons; i++)
                source[AddrPtr[i]++] = '\0';
+       /* TODO: if libidn, this might get larger*/
+       user = malloc(SourceLen + 1);
+       node = malloc(SourceLen + 1);
+       name = malloc(SourceLen + 1);
 
        nPtr = Encoded;
        *nPtr = '\0';
@@ -1680,6 +1785,10 @@ char *qp_encode_email_addrs(char *source)
        }
        for (i = 0; i < nColons; i++)
                source[--AddrPtr[i]] = ',';
+
+       free(user);
+       free(node);
+       free(name);
        free(AddrUtf8);
        free(AddrPtr);
        return Encoded;
@@ -1710,6 +1819,330 @@ void sanitize_truncated_recipient(char *str)
 }
 
 
+void OutputCtdlMsgHeaders(
+       struct CtdlMessage *TheMessage,
+       int do_proto)           /* do Citadel protocol responses? */
+{
+       char allkeys[30];
+       int i, k, n;
+       int suppress_f = 0;
+       char buf[SIZ];
+       char display_name[256];
+
+       /* begin header processing loop for Citadel message format */
+       safestrncpy(display_name, "<unknown>", sizeof display_name);
+       if (TheMessage->cm_fields['A']) {
+               strcpy(buf, TheMessage->cm_fields['A']);
+               if (TheMessage->cm_anon_type == MES_ANONONLY) {
+                       safestrncpy(display_name, "****", sizeof display_name);
+               }
+               else if (TheMessage->cm_anon_type == MES_ANONOPT) {
+                       safestrncpy(display_name, "anonymous", sizeof display_name);
+               }
+               else {
+                       safestrncpy(display_name, buf, sizeof display_name);
+               }
+               if ((is_room_aide())
+                   && ((TheMessage->cm_anon_type == MES_ANONONLY)
+                       || (TheMessage->cm_anon_type == MES_ANONOPT))) {
+                       size_t tmp = strlen(display_name);
+                       snprintf(&display_name[tmp],
+                                sizeof display_name - tmp,
+                                " [%s]", buf);
+               }
+       }
+
+       /* Don't show Internet address for users on the
+        * local Citadel network.
+        */
+       suppress_f = 0;
+       if (TheMessage->cm_fields['N'] != NULL)
+               if (!IsEmptyStr(TheMessage->cm_fields['N']))
+                       if (haschar(TheMessage->cm_fields['N'], '.') == 0) {
+                               suppress_f = 1;
+                       }
+
+       /* Now spew the header fields in the order we like them. */
+       n = safestrncpy(allkeys, FORDER, sizeof allkeys);
+       for (i=0; i<n; ++i) {
+               k = (int) allkeys[i];
+               if (k != 'M') {
+                       if ( (TheMessage->cm_fields[k] != NULL)
+                            && (msgkeys[k] != NULL) ) {
+                               if ((k == 'V') || (k == 'R') || (k == 'Y')) {
+                                       sanitize_truncated_recipient(TheMessage->cm_fields[k]);
+                               }
+                               if (k == 'A') {
+                                       if (do_proto) cprintf("%s=%s\n",
+                                                             msgkeys[k],
+                                                             display_name);
+                               }
+                               else if ((k == 'F') && (suppress_f)) {
+                                       /* do nothing */
+                               }
+                               /* Masquerade display name if needed */
+                               else {
+                                       if (do_proto) cprintf("%s=%s\n",
+                                                             msgkeys[k],
+                                                             TheMessage->cm_fields[k]
+                                               );
+                               }
+                       }
+               }
+       }
+
+}
+
+void OutputRFC822MsgHeaders(
+       struct CtdlMessage *TheMessage,
+       int flags,              /* should the bessage be exported clean */
+       const char *nl,
+       char *mid, long sizeof_mid,
+       char *suser, long sizeof_suser,
+       char *luser, long sizeof_luser,
+       char *fuser, long sizeof_fuser,
+       char *snode, long sizeof_snode)
+{
+       char datestamp[100];
+       int subject_found = 0;
+       char buf[SIZ];
+       int i, j, k;
+       char *mptr = NULL;
+       char *mpptr = NULL;
+
+       for (i = 0; i < 256; ++i) {
+               if (TheMessage->cm_fields[i]) {
+                       mptr = mpptr = TheMessage->cm_fields[i];
+                               
+                       if (i == 'A') {
+                               safestrncpy(luser, mptr, sizeof_luser);
+                               safestrncpy(suser, mptr, sizeof_suser);
+                       }
+                       else if (i == 'Y') {
+                               if ((flags & QP_EADDR) != 0) {
+                                       mptr = qp_encode_email_addrs(mptr);
+                               }
+                               sanitize_truncated_recipient(mptr);
+                               cprintf("CC: %s%s", mptr, nl);
+                       }
+                       else if (i == 'P') {
+                               cprintf("Return-Path: %s%s", mptr, nl);
+                       }
+                       else if (i == 'L') {
+                               cprintf("List-ID: %s%s", mptr, nl);
+                       }
+                       else if (i == 'V') {
+                               if ((flags & QP_EADDR) != 0) 
+                                       mptr = qp_encode_email_addrs(mptr);
+                               cprintf("Envelope-To: %s%s", mptr, nl);
+                       }
+                       else if (i == 'U') {
+                               cprintf("Subject: %s%s", mptr, nl);
+                               subject_found = 1;
+                       }
+                       else if (i == 'I')
+                               safestrncpy(mid, mptr, sizeof_mid); /// TODO: detect @ here and copy @nodename in if not found.
+                       else if (i == 'F')
+                               safestrncpy(fuser, mptr, sizeof_fuser);
+                       /* else if (i == 'O')
+                          cprintf("X-Citadel-Room: %s%s",
+                          mptr, nl); */
+                       else if (i == 'N')
+                               safestrncpy(snode, mptr, sizeof_snode);
+                       else if (i == 'R')
+                       {
+                               if (haschar(mptr, '@') == 0)
+                               {
+                                       sanitize_truncated_recipient(mptr);
+                                       cprintf("To: %s@%s", mptr, config.c_fqdn);
+                                       cprintf("%s", nl);
+                               }
+                               else
+                               {
+                                       if ((flags & QP_EADDR) != 0) {
+                                               mptr = qp_encode_email_addrs(mptr);
+                                       }
+                                       sanitize_truncated_recipient(mptr);
+                                       cprintf("To: %s", mptr);
+                                       cprintf("%s", nl);
+                               }
+                       }
+                       else if (i == 'T') {
+                               datestring(datestamp, sizeof datestamp,
+                                          atol(mptr), DATESTRING_RFC822);
+                               cprintf("Date: %s%s", datestamp, nl);
+                       }
+                       else if (i == 'W') {
+                               cprintf("References: ");
+                               k = num_tokens(mptr, '|');
+                               for (j=0; j<k; ++j) {
+                                       extract_token(buf, mptr, j, '|', sizeof buf);
+                                       cprintf("<%s>", buf);
+                                       if (j == (k-1)) {
+                                               cprintf("%s", nl);
+                                       }
+                                       else {
+                                               cprintf(" ");
+                                       }
+                               }
+                       }
+                       else if (i == 'K') {
+                               cprintf("Reply-To: <%s>%s", mptr, nl);
+                       }
+                       if (mptr != mpptr)
+                               free (mptr);
+               }
+       }
+       if (subject_found == 0) {
+               cprintf("Subject: (no subject)%s", nl);
+       }
+}
+
+
+void Dump_RFC822HeadersBody(
+       struct CtdlMessage *TheMessage,
+       int headers_only,       /* eschew the message body? */
+       int flags,              /* should the bessage be exported clean? */
+
+       const char *nl)
+{
+       cit_uint8_t prev_ch;
+       int eoh = 0;
+       const char *StartOfText = StrBufNOTNULL;
+       char outbuf[1024];
+       int outlen = 0;
+       int nllen = strlen(nl);
+       char *mptr;
+
+       mptr = TheMessage->cm_fields['M'];
+
+
+       prev_ch = '\0';
+       while (*mptr != '\0') {
+               if (*mptr == '\r') {
+                       /* do nothing */
+               }
+               else {
+                       if ((!eoh) &&
+                           (*mptr == '\n'))
+                       {
+                               eoh = (*(mptr+1) == '\r') && (*(mptr+2) == '\n');
+                               if (!eoh)
+                                       eoh = *(mptr+1) == '\n';
+                               if (eoh)
+                               {
+                                       StartOfText = mptr;
+                                       StartOfText = strchr(StartOfText, '\n');
+                                       StartOfText = strchr(StartOfText, '\n');
+                               }
+                       }
+                       if (((headers_only == HEADERS_NONE) && (mptr >= StartOfText)) ||
+                           ((headers_only == HEADERS_ONLY) && (mptr < StartOfText)) ||
+                           ((headers_only != HEADERS_NONE) && 
+                            (headers_only != HEADERS_ONLY))
+                               ) {
+                               if (*mptr == '\n') {
+                                       memcpy(&outbuf[outlen], nl, nllen);
+                                       outlen += nllen;
+                                       outbuf[outlen] = '\0';
+                               }
+                               else {
+                                       outbuf[outlen++] = *mptr;
+                               }
+                       }
+               }
+               if (flags & ESC_DOT)
+               {
+                       if ((prev_ch == '\n') && 
+                           (*mptr == '.') && 
+                           ((*(mptr+1) == '\r') || (*(mptr+1) == '\n')))
+                       {
+                               outbuf[outlen++] = '.';
+                       }
+                       prev_ch = *mptr;
+               }
+               ++mptr;
+               if (outlen > 1000) {
+                       client_write(outbuf, outlen);
+                       outlen = 0;
+               }
+       }
+       if (outlen > 0) {
+               client_write(outbuf, outlen);
+               outlen = 0;
+       }
+}
+
+
+
+/* If the format type on disk is 1 (fixed-format), then we want
+ * everything to be output completely literally ... regardless of
+ * what message transfer format is in use.
+ */
+void DumpFormatFixed(
+       struct CtdlMessage *TheMessage,
+       int mode,               /* how would you like that message? */
+       const char *nl)
+{
+       cit_uint8_t ch;
+       char buf[SIZ];
+       int buflen;
+       int xlline = 0;
+       int nllen = strlen (nl);
+       char *mptr;
+
+       mptr = TheMessage->cm_fields['M'];
+       
+       if (mode == MT_MIME) {
+               cprintf("Content-type: text/plain\n\n");
+       }
+       *buf = '\0';
+       buflen = 0;
+       while (ch = *mptr++, ch > 0) {
+               if (ch == '\n')
+                       ch = '\r';
+
+               if ((buflen > 250) && (!xlline)){
+                       int tbuflen;
+                       tbuflen = buflen;
+
+                       while ((buflen > 0) && 
+                              (!isspace(buf[buflen])))
+                               buflen --;
+                       if (buflen == 0) {
+                               xlline = 1;
+                       }
+                       else {
+                               mptr -= tbuflen - buflen;
+                               buf[buflen] = '\0';
+                               ch = '\r';
+                       }
+               }
+               /* if we reach the outer bounds of our buffer, 
+                  abort without respect what whe purge. */
+               if (xlline && 
+                   ((isspace(ch)) || 
+                    (buflen > SIZ - nllen - 2)))
+                       ch = '\r';
+
+               if (ch == '\r') {
+                       memcpy (&buf[buflen], nl, nllen);
+                       buflen += nllen;
+                       buf[buflen] = '\0';
+
+                       client_write(buf, buflen);
+                       *buf = '\0';
+                       buflen = 0;
+                       xlline = 0;
+               } else {
+                       buf[buflen] = ch;
+                       buflen++;
+               }
+       }
+       buf[buflen] = '\0';
+       if (!IsEmptyStr(buf))
+               cprintf("%s%s", buf, nl);
+}
 
 /*
  * Get a message off disk.  (returns om_* values found in msgbase.h)
@@ -1722,15 +2155,9 @@ int CtdlOutputPreLoadedMsg(
                int crlf,               /* Use CRLF newlines instead of LF? */
                int flags               /* should the bessage be exported clean? */
 ) {
-       int i, j, k, n;
-       char buf[SIZ];
-       cit_uint8_t ch, prev_ch;
-       char allkeys[30];
-       char display_name[256];
-       char *mptr, *mpptr;
+       int i;
+       char *mptr = NULL;
        const char *nl; /* newline string */
-       int suppress_f = 0;
-       int subject_found = 0;
        struct ma_info ma;
 
        /* Buffers needed for RFC822 translation.  These are all filled
@@ -1742,7 +2169,6 @@ int CtdlOutputPreLoadedMsg(
        char fuser[100];
        char snode[100];
        char mid[100];
-       char datestamp[100];
 
        CtdlLogPrintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %d, %d, %d, %d\n",
                ((TheMessage == NULL) ? "NULL" : "not null"),
@@ -1837,164 +2263,27 @@ int CtdlOutputPreLoadedMsg(
                cprintf("nhdr=yes\n");
        }
 
-       /* begin header processing loop for Citadel message format */
-
-       if ((mode == MT_CITADEL) || (mode == MT_MIME)) {
-
-               safestrncpy(display_name, "<unknown>", sizeof display_name);
-               if (TheMessage->cm_fields['A']) {
-                       strcpy(buf, TheMessage->cm_fields['A']);
-                       if (TheMessage->cm_anon_type == MES_ANONONLY) {
-                               safestrncpy(display_name, "****", sizeof display_name);
-                       }
-                       else if (TheMessage->cm_anon_type == MES_ANONOPT) {
-                               safestrncpy(display_name, "anonymous", sizeof display_name);
-                       }
-                       else {
-                               safestrncpy(display_name, buf, sizeof display_name);
-                       }
-                       if ((is_room_aide())
-                           && ((TheMessage->cm_anon_type == MES_ANONONLY)
-                            || (TheMessage->cm_anon_type == MES_ANONOPT))) {
-                               size_t tmp = strlen(display_name);
-                               snprintf(&display_name[tmp],
-                                        sizeof display_name - tmp,
-                                        " [%s]", buf);
-                       }
-               }
+       if ((mode == MT_CITADEL) || (mode == MT_MIME)) 
+               OutputCtdlMsgHeaders(TheMessage, do_proto);
 
-               /* Don't show Internet address for users on the
-                * local Citadel network.
-                */
-               suppress_f = 0;
-               if (TheMessage->cm_fields['N'] != NULL)
-                  if (!IsEmptyStr(TheMessage->cm_fields['N']))
-                     if (haschar(TheMessage->cm_fields['N'], '.') == 0) {
-                       suppress_f = 1;
-               }
-
-               /* Now spew the header fields in the order we like them. */
-               n = safestrncpy(allkeys, FORDER, sizeof allkeys);
-               for (i=0; i<n; ++i) {
-                       k = (int) allkeys[i];
-                       if (k != 'M') {
-                               if ( (TheMessage->cm_fields[k] != NULL)
-                                  && (msgkeys[k] != NULL) ) {
-                                       if ((k == 'V') || (k == 'R') || (k == 'Y')) {
-                                               sanitize_truncated_recipient(TheMessage->cm_fields[k]);
-                                       }
-                                       if (k == 'A') {
-                                               if (do_proto) cprintf("%s=%s\n",
-                                                       msgkeys[k],
-                                                       display_name);
-                                       }
-                                       else if ((k == 'F') && (suppress_f)) {
-                                               /* do nothing */
-                                       }
-                                       /* Masquerade display name if needed */
-                                       else {
-                                               if (do_proto) cprintf("%s=%s\n",
-                                                       msgkeys[k],
-                                                       TheMessage->cm_fields[k]
-                                       );
-                                       }
-                               }
-                       }
-               }
-
-       }
 
        /* begin header processing loop for RFC822 transfer format */
-
        strcpy(suser, "");
        strcpy(luser, "");
        strcpy(fuser, "");
        strcpy(snode, NODENAME);
-       if (mode == MT_RFC822) {
-               for (i = 0; i < 256; ++i) {
-                       if (TheMessage->cm_fields[i]) {
-                               mptr = mpptr = TheMessage->cm_fields[i];
-                               
-                               if (i == 'A') {
-                                       safestrncpy(luser, mptr, sizeof luser);
-                                       safestrncpy(suser, mptr, sizeof suser);
-                               }
-                               else if (i == 'Y') {
-                                       if ((flags & QP_EADDR) != 0) {
-                                               mptr = qp_encode_email_addrs(mptr);
-                                       }
-                                       sanitize_truncated_recipient(mptr);
-                                       cprintf("CC: %s%s", mptr, nl);
-                               }
-                               else if (i == 'P') {
-                                       cprintf("Return-Path: %s%s", mptr, nl);
-                               }
-                               else if (i == 'L') {
-                                       cprintf("List-ID: %s%s", mptr, nl);
-                               }
-                               else if (i == 'V') {
-                                       if ((flags & QP_EADDR) != 0) 
-                                               mptr = qp_encode_email_addrs(mptr);
-                                       cprintf("Envelope-To: %s%s", mptr, nl);
-                               }
-                               else if (i == 'U') {
-                                       cprintf("Subject: %s%s", mptr, nl);
-                                       subject_found = 1;
-                               }
-                               else if (i == 'I')
-                                       safestrncpy(mid, mptr, sizeof mid);
-                               else if (i == 'F')
-                                       safestrncpy(fuser, mptr, sizeof fuser);
-                               /* else if (i == 'O')
-                                       cprintf("X-Citadel-Room: %s%s",
-                                               mptr, nl); */
-                               else if (i == 'N')
-                                       safestrncpy(snode, mptr, sizeof snode);
-                               else if (i == 'R')
-                               {
-                                       if (haschar(mptr, '@') == 0)
-                                       {
-                                               sanitize_truncated_recipient(mptr);
-                                               cprintf("To: %s@%s", mptr, config.c_fqdn);
-                                               cprintf("%s", nl);
-                                       }
-                                       else
-                                       {
-                                               if ((flags & QP_EADDR) != 0) {
-                                                       mptr = qp_encode_email_addrs(mptr);
-                                               }
-                                               sanitize_truncated_recipient(mptr);
-                                               cprintf("To: %s", mptr);
-                                               cprintf("%s", nl);
-                                       }
-                               }
-                               else if (i == 'T') {
-                                       datestring(datestamp, sizeof datestamp,
-                                               atol(mptr), DATESTRING_RFC822);
-                                       cprintf("Date: %s%s", datestamp, nl);
-                               }
-                               else if (i == 'W') {
-                                       cprintf("References: ");
-                                       k = num_tokens(mptr, '|');
-                                       for (j=0; j<k; ++j) {
-                                               extract_token(buf, mptr, j, '|', sizeof buf);
-                                               cprintf("<%s>", buf);
-                                               if (j == (k-1)) {
-                                                       cprintf("%s", nl);
-                                               }
-                                               else {
-                                                       cprintf(" ");
-                                               }
-                                       }
-                               }
-                               if (mptr != mpptr)
-                                       free (mptr);
-                       }
-               }
-               if (subject_found == 0) {
-                       cprintf("Subject: (no subject)%s", nl);
-               }
-       }
+       if (mode == MT_RFC822) 
+               OutputRFC822MsgHeaders(
+                       TheMessage,
+                       flags,
+                       nl,
+                       mid, sizeof(mid),
+                       suser, sizeof(suser),
+                       luser, sizeof(luser),
+                       fuser, sizeof(fuser),
+                       snode, sizeof(snode)
+                       );
+
 
        for (i=0; !IsEmptyStr(&suser[i]); ++i) {
                suser[i] = tolower(suser[i]);
@@ -2035,80 +2324,24 @@ int CtdlOutputPreLoadedMsg(
        /* end header processing loop ... at this point, we're in the text */
 START_TEXT:
        if (headers_only == HEADERS_FAST) goto DONE;
-       mptr = TheMessage->cm_fields['M'];
 
        /* Tell the client about the MIME parts in this message */
        if (TheMessage->cm_format_type == FMT_RFC822) {
                if ( (mode == MT_CITADEL) || (mode == MT_MIME) ) {
+                       mptr = TheMessage->cm_fields['M'];
                        memset(&ma, 0, sizeof(struct ma_info));
                        mime_parser(mptr, NULL,
                                (do_proto ? *list_this_part : NULL),
                                (do_proto ? *list_this_pref : NULL),
                                (do_proto ? *list_this_suff : NULL),
-                               (void *)&ma, 0);
+                               (void *)&ma, 1);
                }
                else if (mode == MT_RFC822) {   /* unparsed RFC822 dump */
-                       int eoh = 0;
-                       const char *StartOfText = StrBufNOTNULL;
-
-                       char outbuf[1024];
-                       int outlen = 0;
-                       int nllen = strlen(nl);
-                       prev_ch = '\0';
-                       while (*mptr != '\0') {
-                               if (*mptr == '\r') {
-                                       /* do nothing */
-                               }
-                               else {
-                                       if ((!eoh) &&
-                                           (*mptr == '\n'))
-                                       {
-                                               eoh = (*(mptr+1) == '\r') && (*(mptr+2) == '\n');
-                                               if (!eoh)
-                                                       eoh = *(mptr+1) == '\n';
-                                               if (eoh)
-                                               {
-                                                       StartOfText = mptr;
-                                                       StartOfText = strchr(StartOfText, '\n');
-                                                       StartOfText = strchr(StartOfText, '\n');
-                                               }
-                                       }
-                                       if (((headers_only == HEADERS_NONE) && (mptr >= StartOfText)) ||
-                                           ((headers_only == HEADERS_ONLY) && (mptr < StartOfText)) ||
-                                           ((headers_only != HEADERS_NONE) && 
-                                            (headers_only != HEADERS_ONLY))
-                                       ) {
-                                               if (*mptr == '\n') {
-                                                       memcpy(&outbuf[outlen], nl, nllen);
-                                                       outlen += nllen;
-                                                       outbuf[outlen] = '\0';
-                                               }
-                                               else {
-                                                       outbuf[outlen++] = *mptr;
-                                               }
-                                       }
-                               }
-                               if (flags & ESC_DOT)
-                               {
-                                       if ((prev_ch == '\n') && 
-                                           (*mptr == '.') && 
-                                           ((*(mptr+1) == '\r') || (*(mptr+1) == '\n')))
-                                       {
-                                               outbuf[outlen++] = '.';
-                                       }
-                                       prev_ch = *mptr;
-                               }
-                               ++mptr;
-                               if (outlen > 1000) {
-                                       client_write(outbuf, outlen);
-                                       outlen = 0;
-                               }
-                       }
-                       if (outlen > 0) {
-                               client_write(outbuf, outlen);
-                               outlen = 0;
-                       }
-
+                       Dump_RFC822HeadersBody(
+                               TheMessage,
+                               headers_only,
+                               flags,
+                               nl);
                        goto DONE;
                }
        }
@@ -2122,64 +2355,11 @@ START_TEXT:
                if (do_proto) cprintf("text\n");
        }
 
-       /* If the format type on disk is 1 (fixed-format), then we want
-        * everything to be output completely literally ... regardless of
-        * what message transfer format is in use.
-        */
-       if (TheMessage->cm_format_type == FMT_FIXED) {
-               int buflen;
-               int xlline = 0;
-               int nllen = strlen (nl);
-               if (mode == MT_MIME) {
-                       cprintf("Content-type: text/plain\n\n");
-               }
-               *buf = '\0';
-               buflen = 0;
-               while (ch = *mptr++, ch > 0) {
-                       if (ch == '\n')
-                               ch = '\r';
-
-                       if ((buflen > 250) && (!xlline)){
-                               int tbuflen;
-                               tbuflen = buflen;
-
-                               while ((buflen > 0) && 
-                                      (!isspace(buf[buflen])))
-                                       buflen --;
-                               if (buflen == 0) {
-                                       xlline = 1;
-                               }
-                               else {
-                                       mptr -= tbuflen - buflen;
-                                       buf[buflen] = '\0';
-                                       ch = '\r';
-                               }
-                       }
-                       /* if we reach the outer bounds of our buffer, 
-                          abort without respect what whe purge. */
-                       if (xlline && 
-                           ((isspace(ch)) || 
-                            (buflen > SIZ - nllen - 2)))
-                               ch = '\r';
-
-                       if (ch == '\r') {
-                               memcpy (&buf[buflen], nl, nllen);
-                               buflen += nllen;
-                               buf[buflen] = '\0';
-
-                               client_write(buf, buflen);
-                               *buf = '\0';
-                               buflen = 0;
-                               xlline = 0;
-                       } else {
-                               buf[buflen] = ch;
-                               buflen++;
-                       }
-               }
-               buf[buflen] = '\0';
-               if (!IsEmptyStr(buf))
-                       cprintf("%s%s", buf, nl);
-       }
+       if (TheMessage->cm_format_type == FMT_FIXED) 
+               DumpFormatFixed(
+                       TheMessage,
+                       mode,           /* how would you like that message? */
+                       nl);
 
        /* If the message on disk is format 0 (Citadel vari-format), we
         * output using the formatter at 80 columns.  This is the final output
@@ -2189,6 +2369,8 @@ START_TEXT:
         * message to the reader's screen width.
         */
        if (TheMessage->cm_format_type == FMT_CITADEL) {
+               mptr = TheMessage->cm_fields['M'];
+
                if (mode == MT_MIME) {
                        cprintf("Content-type: text/x-citadel-variformat\n\n");
                }
@@ -2207,11 +2389,12 @@ START_TEXT:
                        ma.use_fo_hooks = 0;
                        strcpy(ma.chosen_part, "1");
                        ma.chosen_pref = 9999;
+                       ma.dont_decode = CC->msg4_dont_decode;
                        mime_parser(mptr, NULL,
                                *choose_preferred, *fixed_output_pre,
-                               *fixed_output_post, (void *)&ma, 0);
+                               *fixed_output_post, (void *)&ma, 1);
                        mime_parser(mptr, NULL,
-                               *output_preferred, NULL, NULL, (void *)&ma, CC->msg4_dont_decode);
+                               *output_preferred, NULL, NULL, (void *)&ma, 1);
                }
                else {
                        ma.use_fo_hooks = 1;
@@ -2770,7 +2953,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        struct addresses_to_be_filed *aptr = NULL;
        StrBuf *saved_rfc822_version = NULL;
        int qualified_for_journaling = 0;
-       CitContext *CCC = CC;           /* CachedCitContext - performance boost */
+       CitContext *CCC = MyContext();
        char bounce_to[1024] = "";
        size_t tmp = 0;
        int rv = 0;
@@ -3258,7 +3441,7 @@ StrBuf *CtdlReadMessageBodyBuf(char *terminator,  /* token signalling EOT */
        /* read in the lines of message text one by one */
        do {
                if (sock != NULL) {
-                       if ((CtdlSockGetLine(sock, LineBuf) < 0) ||
+                       if ((CtdlSockGetLine(sock, LineBuf, 5) < 0) ||
                            (*sock == -1))
                                finished = 1;
                }
@@ -3349,6 +3532,8 @@ struct CtdlMessage *CtdlMakeMessage(
        char dest_node[256];
        char buf[1024];
        struct CtdlMessage *msg;
+       StrBuf *FakeAuthor;
+       StrBuf *FakeEncAuthor = NULL;
 
        msg = malloc(sizeof(struct CtdlMessage));
        memset(msg, 0, sizeof(struct CtdlMessage));
@@ -3378,11 +3563,14 @@ struct CtdlMessage *CtdlMakeMessage(
        msg->cm_fields['T'] = strdup(buf);
 
        if ((fake_name != NULL) && (fake_name[0])) {            /* author */
-               msg->cm_fields['A'] = strdup(fake_name);
+               FakeAuthor = NewStrBufPlain (fake_name, -1);
        }
        else {
-               msg->cm_fields['A'] = strdup(author->fullname);
+               FakeAuthor = NewStrBufPlain (author->fullname, -1);
        }
+       StrBufRFC2047encode(&FakeEncAuthor, FakeAuthor);
+       msg->cm_fields['A'] = SmashStrBuf(&FakeEncAuthor);
+       FreeStrBuf(&FakeAuthor);
 
        if (CC->room.QRflags & QR_MAILBOX) {            /* room */
                msg->cm_fields['O'] = strdup(&CC->room.QRname[11]);
@@ -3459,10 +3647,13 @@ struct CtdlMessage *CtdlMakeMessage(
  * room.  Returns a *CITADEL ERROR CODE* and puts a message in errmsgbuf, or
  * returns 0 on success.
  */
-int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, 
-                                         size_t n, 
-                                         const char* RemoteIdentifier,
-                                         int PostPublic) {
+int CtdlDoIHavePermissionToPostInThisRoom(
+       char *errmsgbuf, 
+       size_t n, 
+       const char* RemoteIdentifier,
+       int PostPublic,
+       int is_reply
+) {
        int ra;
 
        if (!(CC->logged_in) && 
@@ -3527,7 +3718,18 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf,
        }
 
        CtdlRoomAccess(&CC->room, &CC->user, &ra, NULL);
-       if (!(ra & UA_POSTALLOWED)) {
+
+       if ( (!(ra & UA_POSTALLOWED)) && (ra & UA_REPLYALLOWED) && (!is_reply) ) {
+               /*
+                * To be thorough, we ought to check to see if the message they are
+                * replying to is actually a valid one in this room, but unless this
+                * actually becomes a problem we'll go with high performance instead.
+                */
+               snprintf(errmsgbuf, n, "You may only reply to existing messages here.");
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       else if (!(ra & UA_POSTALLOWED)) {
                snprintf(errmsgbuf, n, "Higher access is required to post in this room.");
                return (ERROR + HIGHER_ACCESS_REQUIRED);
        }
@@ -3687,10 +3889,12 @@ struct recptypes *validate_recipients(const char *supplied_recipients,
                                        CC->room = tempQR;
                                        
                                        /* Check permissions to send mail to this room */
-                                       err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, 
-                                                                                   sizeof errmsg, 
-                                                                                   RemoteIdentifier,
-                                                                                   Flags
+                                       err = CtdlDoIHavePermissionToPostInThisRoom(
+                                               errmsg, 
+                                               sizeof errmsg, 
+                                               RemoteIdentifier,
+                                               Flags,
+                                               0                       /* 0 = not a reply */
                                        );
                                        if (err)
                                        {
@@ -3893,7 +4097,13 @@ void cmd_ent0(char *entargs)
 
        /* first check to make sure the request is valid. */
 
-       err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, sizeof errmsg, NULL, POST_LOGGED_IN);
+       err = CtdlDoIHavePermissionToPostInThisRoom(
+               errmsg,
+               sizeof errmsg,
+               NULL,
+               POST_LOGGED_IN,
+               (!IsEmptyStr(references))               /* is this a reply?  or a top-level post? */
+       );
        if (err)
        {
                cprintf("%d %s\n", err, errmsg);
@@ -3949,12 +4159,13 @@ void cmd_ent0(char *entargs)
        /* In mailbox rooms we have to behave a little differently --
         * make sure the user has specified at least one recipient.  Then
         * validate the recipient(s).  We do this for the Mail> room, as
-        * well as any room which has the "Mailbox" view set.
+        * well as any room which has the "Mailbox" view set - unless it
+        * is the DRAFTS room which does not require recipients
         */
 
-       if (  ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) )
-          || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) )
-       ) {
+       if (  ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) )
+            || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) )
+       ) && (strcasecmp(&CC->room.QRname[11], USERDRAFTROOM)) !=0 ) {
                if (CC->user.axlevel < AxProbU) {
                        strcpy(recp, "sysop");
                        strcpy(cc, "");
@@ -4856,5 +5067,5 @@ CTDL_MODULE_INIT(msgbase)
        }
 
         /* return our Subversion id for the Log */
-       return "$Id$";
+       return "msgbase";
 }