* First cut at Solaris fixes. There may still be some *printf("%s", NULL)
[citadel.git] / citadel / msgbase.c
index b6255c01b859f450db838976d7880fa85310bf1b..486e89323a974d9403e56bff5f5b38fc739c59e3 100644 (file)
@@ -1,4 +1,5 @@
 /* $Id$ */
+
 #include "sysdep.h"
 #include <stdlib.h>
 #include <unistd.h>
@@ -8,14 +9,12 @@
 #include <ctype.h>
 #include <string.h>
 #include <syslog.h>
-#ifdef HAVE_PTHREAD_H
-#include <pthread.h>
-#endif
 #include <limits.h>
-#include "citadel.h"
-#include "server.h"
 #include <errno.h>
+#include <stdarg.h>
 #include <sys/stat.h>
+#include "citadel.h"
+#include "server.h"
 #include "database.h"
 #include "msgbase.h"
 #include "support.h"
 #include "tools.h"
 #include "mime_parser.h"
 #include "html.h"
+#include "genstamp.h"
+#include "internet_addressing.h"
 
 #define desired_section ((char *)CtdlGetUserData(SYM_DESIRED_SECTION))
 #define ma ((struct ma_info *)CtdlGetUserData(SYM_MA_INFO))
+#define msg_repl ((struct repl *)CtdlGetUserData(SYM_REPL))
 
 extern struct config config;
+long config_msgnum;
+
+char *msgkeys[] = {
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", 
+       "from",
+       "", "", "",
+       "exti",
+       "rfca",
+       "", 
+       "hnod",
+       "msgn",
+       "", "", "",
+       "text",
+       "node",
+       "room",
+       "path",
+       "",
+       "rcpt",
+       "spec",
+       "time",
+       "subj",
+       "",
+       "",
+       "",
+       "",
+       ""
+};
 
 /*
  * This function is self explanatory.
@@ -67,8 +104,6 @@ int alias(char *name)
        int a, b;
        char aaa[300], bbb[300];
 
-       lprintf(9, "alias() called for <%s>\n", name);
-
        remove_any_whitespace_to_the_left_or_right_of_at_symbol(name);
 
        fp = fopen("network/mail.aliases", "r");
@@ -95,6 +130,16 @@ int alias(char *name)
        fclose(fp);
        lprintf(7, "Mail is being forwarded to %s\n", name);
 
+       /* Change "user @ xxx" to "user" if xxx is an alias for this host */
+       for (a=0; a<strlen(name); ++a) {
+               if (name[a] == '@') {
+                       if (CtdlHostAlias(&name[a+1]) == hostalias_localhost) {
+                               name[a] = 0;
+                               lprintf(7, "Changed to <%s>\n", name);
+                       }
+               }
+       }
+
        /* determine local or remote type, see citadel.h */
        for (a = 0; a < strlen(name); ++a)
                if (name[a] == '!')
@@ -121,7 +166,7 @@ int alias(char *name)
                fp = fopen("network/mail.sysinfo", "r");
                if (fp == NULL)
                        return (MES_ERROR);
-             GETSN:do {
+GETSN:         do {
                        a = getstring(fp, aaa);
                } while ((a >= 0) && (strcasecmp(aaa, bbb)));
                a = getstring(fp, aaa);
@@ -142,6 +187,7 @@ int alias(char *name)
                        while (bbb[strlen(bbb) - 1] == '_')
                                bbb[strlen(bbb) - 1] = 0;
                        sprintf(name, &aaa[4], bbb);
+                       lprintf(9, "returning MES_INTERNET\n");
                        return (MES_INTERNET);
                }
                if (!strncmp(aaa, "bin", 3)) {
@@ -158,10 +204,12 @@ int alias(char *name)
                        while (bbb[0] == ' ')
                                strcpy(bbb, &bbb[1]);
                        sprintf(name, "%s @%s", aaa, bbb);
+                       lprintf(9, "returning MES_BINARY\n");
                        return (MES_BINARY);
                }
                return (MES_ERROR);
        }
+       lprintf(9, "returning MES_LOCAL\n");
        return (MES_LOCAL);
 }
 
@@ -183,12 +231,45 @@ void simple_listing(long msgnum)
 }
 
 
+
+/* Determine if a given message matches the fields in a message template.
+ * Return 0 for a successful match.
+ */
+int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
+       int i;
+
+       /* If there aren't any fields in the template, all messages will
+        * match.
+        */
+       if (template == NULL) return(0);
+
+       /* Null messages are bogus. */
+       if (msg == NULL) return(1);
+
+       for (i='A'; i<='Z'; ++i) {
+               if (template->cm_fields[i] != NULL) {
+                       if (msg->cm_fields[i] == NULL) {
+                               return 1;
+                       }
+                       if (strcasecmp(msg->cm_fields[i],
+                               template->cm_fields[i])) return 1;
+               }
+       }
+
+       /* All compares succeeded: we have a match! */
+       return 0;
+}
+
+
+
+
 /*
  * API function to perform an operation for each qualifying message in the
  * current room.
  */
 void CtdlForEachMessage(int mode, long ref,
                        char *content_type,
+                       struct CtdlMessage *compare,
                        void (*CallBack) (long msgnum))
 {
 
@@ -199,6 +280,7 @@ void CtdlForEachMessage(int mode, long ref,
        int num_msgs = 0;
        long thismsg;
        struct SuppMsgInfo smi;
+       struct CtdlMessage *msg;
 
        /* Learn about the user and room in question */
        get_mm();
@@ -231,6 +313,24 @@ void CtdlForEachMessage(int mode, long ref,
                                }
 
        num_msgs = sort_msglist(msglist, num_msgs);
+
+       /* If a template was supplied, filter out the messages which
+        * don't match.  (This could induce some delays!)
+        */
+       if (num_msgs > 0) {
+               if (compare != NULL) {
+                       for (a = 0; a < num_msgs; ++a) {
+                               msg = CtdlFetchMessage(msglist[a]);
+                               if (msg != NULL) {
+                                       if (CtdlMsgCmp(msg, compare)) {
+                                               msglist[a] = 0L;
+                                       }
+                                       CtdlFreeMessage(msg);
+                               }
+                       }
+               }
+       }
+
        
        /*
         * Now iterate through the message list, according to the
@@ -268,10 +368,17 @@ void cmd_msgs(char *cmdbuf)
 {
        int mode = 0;
        char which[256];
+       char buf[256];
+       char tfield[256];
+       char tvalue[256];
        int cm_ref = 0;
+       int i;
+       int with_template = 0;
+       struct CtdlMessage *template = NULL;
 
        extract(which, cmdbuf, 0);
        cm_ref = extract_int(cmdbuf, 1);
+       with_template = extract_int(cmdbuf, 2);
 
        mode = MSGS_ALL;
        strcat(which, "   ");
@@ -290,8 +397,30 @@ void cmd_msgs(char *cmdbuf)
                cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN);
                return;
        }
-       cprintf("%d Message list...\n", LISTING_FOLLOWS);
-       CtdlForEachMessage(mode, cm_ref, NULL, simple_listing);
+
+       if (with_template) {
+               cprintf("%d Send template then receive message list\n",
+                       START_CHAT_MODE);
+               template = (struct CtdlMessage *)
+                       mallok(sizeof(struct CtdlMessage));
+               memset(template, 0, sizeof(struct CtdlMessage));
+               while(client_gets(buf), strcmp(buf,"000")) {
+                       extract(tfield, buf, 0);
+                       extract(tvalue, buf, 1);
+                       for (i='A'; i<='Z'; ++i) if (msgkeys[i]!=NULL) {
+                               if (!strcasecmp(tfield, msgkeys[i])) {
+                                       template->cm_fields[i] =
+                                               strdoop(tvalue);
+                               }
+                       }
+               }
+       }
+       else {
+               cprintf("%d Message list...\n", LISTING_FOLLOWS);
+       }
+
+       CtdlForEachMessage(mode, cm_ref, NULL, template, simple_listing);
+       if (template != NULL) CtdlFreeMessage(template);
        cprintf("000\n");
 }
 
@@ -339,10 +468,11 @@ void do_help_subst(char *buffer)
  *             for here is to format text out to 80 columns before sending it
  *             to the client.  The client software may reformat it again.
  */
-void memfmout(int width, char *mptr, char subst)
-                       /* screen width to use */
-                       /* where are we going to get our text from? */
-                       /* nonzero if we should use hypertext mode */
+void memfmout(
+       int width,              /* screen width to use */
+       char *mptr,             /* where are we going to get our text from? */
+       char subst,             /* nonzero if we should do substitutions */
+       char *nl)               /* string to terminate lines with */
 {
        int a, b, c;
        int real = 0;
@@ -381,7 +511,7 @@ FMTA:       if (subst) {
        if (((ch == 13) || (ch == 10)) && (old != 13) && (old != 10))
                ch = 32;
        if (((old == 13) || (old == 10)) && (isspace(real))) {
-               cprintf("\n");
+               cprintf("%s", nl);
                c = 1;
        }
        if (ch > 126)
@@ -389,7 +519,7 @@ FMTA:       if (subst) {
 
        if (ch > 32) {
                if (((strlen(aaa) + c) > (width - 5)) && (strlen(aaa) > (width - 5))) {
-                       cprintf("\n%s", aaa);
+                       cprintf("%s%s", nl, aaa);
                        c = strlen(aaa);
                        aaa[0] = 0;
                }
@@ -399,7 +529,7 @@ FMTA:       if (subst) {
        }
        if (ch == 32) {
                if ((strlen(aaa) + c) > (width - 5)) {
-                       cprintf("\n");
+                       cprintf("%s", nl);
                        c = 1;
                }
                cprintf("%s ", aaa);
@@ -409,14 +539,14 @@ FMTA:     if (subst) {
                goto FMTA;
        }
        if ((ch == 13) || (ch == 10)) {
-               cprintf("%s\n", aaa);
+               cprintf("%s%s", aaa, nl);
                c = 1;
                strcpy(aaa, "");
                goto FMTA;
        }
        goto FMTA;
 
-FMTEND:        cprintf("%s\n", aaa);
+FMTEND:        cprintf("%s%s", aaa, nl);
 }
 
 
@@ -433,46 +563,6 @@ void list_this_part(char *name, char *filename, char *partnum, char *disp,
 }
 
 
-/*
- * Callback function for mime parser that wants to display text
- */
-void fixed_output(char *name, char *filename, char *partnum, char *disp,
-                 void *content, char *cbtype, size_t length)
-{
-       char *ptr;
-
-       if (!strcasecmp(cbtype, "multipart/alternative")) {
-               strcpy(ma->prefix, partnum);
-               strcat(ma->prefix, ".");
-               ma->is_ma = 1;
-               ma->did_print = 0;
-               return;
-       }
-
-       if ( (!strncasecmp(partnum, ma->prefix, strlen(ma->prefix)))
-          && (ma->is_ma == 1) 
-          && (ma->did_print == 1) ) {
-               lprintf(9, "Skipping part %s (%s)\n", partnum, cbtype);
-               return;
-       }
-
-       ma->did_print = 1;
-
-       if (!strcasecmp(cbtype, "text/plain")) {
-               client_write(content, length);
-       }
-       else if (!strcasecmp(cbtype, "text/html")) {
-               ptr = html_to_ascii(content, 80, 0);
-               client_write(ptr, strlen(ptr));
-               phree(ptr);
-       }
-       else if (strncasecmp(cbtype, "multipart/", 10)) {
-               cprintf("Part %s: %s (%s) (%d bytes)\n",
-                       partnum, filename, cbtype, length);
-       }
-}
-
-
 /*
  * Callback function for mime parser that opens a section for downloading
  */
@@ -503,7 +593,7 @@ void mime_download(char *name, char *filename, char *partnum, char *disp,
 
 /*
  * Load a message from disk into memory.
- * This is used by output_message() and other fetch functions.
+ * This is used by CtdlOutputMsg() and other fetch functions.
  *
  * NOTE: Caller is responsible for freeing the returned CtdlMessage struct
  *       using the CtdlMessageFree() function.
@@ -517,10 +607,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
        CIT_UBYTE field_header;
        size_t field_length;
 
-
        dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
        if (dmsgtext == NULL) {
-               lprintf(9, "CtdlFetchMessage(%ld) failed.\n");
                return NULL;
        }
        mptr = dmsgtext->ptr;
@@ -562,6 +650,10 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
 
        cdb_free(dmsgtext);
 
+       /* Always make sure there's something in the msg text field */
+       if (ret->cm_fields['M'] == NULL)
+               ret->cm_fields['M'] = strdoop("<no text>\n");
+
        /* Perform "before read" hooks (aborting if any return nonzero) */
        if (PerformMessageHooks(ret, EVT_BEFOREREAD) > 0) {
                CtdlFreeMessage(ret);
@@ -597,56 +689,123 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
        if (is_valid_message(msg) == 0) return;
 
        for (i = 0; i < 256; ++i)
-               if (msg->cm_fields[i] != NULL)
+               if (msg->cm_fields[i] != NULL) {
                        phree(msg->cm_fields[i]);
+               }
 
        msg->cm_magic = 0;      /* just in case */
        phree(msg);
 }
 
 
+/*
+ * Callback function for mime parser that wants to display text
+ */
+void fixed_output(char *name, char *filename, char *partnum, char *disp,
+               void *content, char *cbtype, size_t length)
+       {
+               char *ptr;
+               char *wptr;
+               size_t wlen;
+               CIT_UBYTE ch;
+       
+               if (!strcasecmp(cbtype, "multipart/alternative")) {
+                       strcpy(ma->prefix, partnum);
+                       strcat(ma->prefix, ".");
+                       ma->is_ma = 1;
+                       ma->did_print = 0;
+                       return;
+               }
+       
+               if ( (!strncasecmp(partnum, ma->prefix, strlen(ma->prefix)))
+               && (ma->is_ma == 1) 
+               && (ma->did_print == 1) ) {
+                       lprintf(9, "Skipping part %s (%s)\n", partnum, cbtype);
+                       return;
+               }
+       
+               ma->did_print = 1;
+       
+               if ( (!strcasecmp(cbtype, "text/plain")) 
+                  || (strlen(cbtype)==0) ) {
+                       wlen = length;
+                       wptr = content;
+                       while (wlen--) {
+                               ch = *wptr++;
+                               if (ch==10) cprintf("\r\n");
+                               else cprintf("%c", ch);
+                       }
+               }
+               else if (!strcasecmp(cbtype, "text/html")) {
+                       ptr = html_to_ascii(content, 80, 0);
+                       wlen = strlen(ptr);
+                       wptr = ptr;
+                       while (wlen--) {
+                               ch = *wptr++;
+                               if (ch==10) cprintf("\r\n");
+                               else cprintf("%c", ch);
+                       }
+                       phree(ptr);
+               }
+               else if (strncasecmp(cbtype, "multipart/", 10)) {
+                       cprintf("Part %s: %s (%s) (%d bytes)\r\n",
+                               partnum, filename, cbtype, length);
+               }
+       }
+
 
 /*
- * Get a message off disk.  (return value is the message's timestamp)
+ * Get a message off disk.  (returns om_* values found in msgbase.h)
  * 
  */
-void output_message(char *msgid, int mode, int headers_only)
-{
-       long msg_num;
-       int a, i;
+int CtdlOutputMsg(long msg_num,                /* message number (local) to fetch */
+               int mode,               /* how would you like that message? */
+               int headers_only,       /* eschew the message body? */
+               int do_proto,           /* do Citadel protocol responses? */
+               int crlf                /* Use CRLF newlines instead of LF? */
+) {
+       int i, k;
        char buf[1024];
-       time_t xtime;
        CIT_UBYTE ch;
-
-       struct CtdlMessage *TheMessage = NULL;
-
+       char allkeys[256];
+       char display_name[256];
+       struct CtdlMessage *TheMessage;
        char *mptr;
+       char *nl;       /* newline string */
 
        /* buffers needed for RFC822 translation */
        char suser[256];
        char luser[256];
+       char fuser[256];
        char snode[256];
        char lnode[256];
        char mid[256];
+       char datestamp[256];
        /*                                       */
 
-       msg_num = atol(msgid);
+       lprintf(7, "CtdlOutputMsg() msgnum=%ld, mode=%d\n", 
+               msg_num, mode);
+
+       TheMessage = NULL;
+       sprintf(mid, "%ld", msg_num);
+       nl = (crlf ? "\r\n" : "\n");
 
        if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
-               cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
-               return;
+               if (do_proto) cprintf("%d Not logged in.\n",
+                       ERROR + NOT_LOGGED_IN);
+               return(om_not_logged_in);
        }
 
-       /* FIX ... small security issue
+       /* FIXME ... small security issue
         * We need to check to make sure the requested message is actually
         * in the current room, and set msg_ok to 1 only if it is.  This
         * functionality is currently missing because I'm in a hurry to replace
         * broken production code with nonbroken pre-beta code.  :(   -- ajc
         *
         if (!msg_ok) {
-        cprintf("%d Message %ld is not in this room.\n",
+        if (do_proto) cprintf("%d Message %ld is not in this room.\n",
         ERROR, msg_num);
-        return;
+        return(om_no_such_msg);
         }
         */
 
@@ -655,17 +814,20 @@ void output_message(char *msgid, int mode, int headers_only)
         */
        TheMessage = CtdlFetchMessage(msg_num);
        if (TheMessage == NULL) {
-               cprintf("%d Can't locate msg %ld on disk\n", ERROR, msg_num);
-               return;
+               if (do_proto) cprintf("%d Can't locate msg %ld on disk\n",
+                       ERROR, msg_num);
+               return(om_no_such_msg);
        }
 
        /* Are we downloading a MIME component? */
        if (mode == MT_DOWNLOAD) {
-               if (TheMessage->cm_format_type != 4) {
-                       cprintf("%d This is not a MIME message.\n",
+               if (TheMessage->cm_format_type != FMT_RFC822) {
+                       if (do_proto)
+                               cprintf("%d This is not a MIME message.\n",
                                ERROR);
                } else if (CC->download_fp != NULL) {
-                       cprintf("%d You already have a download open.\n",
+                       if (do_proto) cprintf(
+                               "%d You already have a download open.\n",
                                ERROR);
                } else {
                        /* Parse the message text component */
@@ -675,129 +837,150 @@ void output_message(char *msgid, int mode, int headers_only)
                         * section wasn't found, so print an error
                         */
                        if (CC->download_fp == NULL) {
-                               cprintf("%d Section %s not found.\n",
+                               if (do_proto) cprintf(
+                                       "%d Section %s not found.\n",
                                        ERROR + FILE_NOT_FOUND,
                                        desired_section);
                        }
                }
                CtdlFreeMessage(TheMessage);
-               return;
+               return((CC->download_fp != NULL) ? om_ok : om_mime_error);
        }
 
        /* now for the user-mode message reading loops */
-       cprintf("%d Message %ld:\n", LISTING_FOLLOWS, msg_num);
+       if (do_proto) cprintf("%d Message %ld:\n", LISTING_FOLLOWS, msg_num);
 
        /* Tell the client which format type we're using.  If this is a
         * MIME message, *lie* about it and tell the user it's fixed-format.
         */
        if (mode == MT_CITADEL) {
-               if (TheMessage->cm_format_type == 4)
-                       cprintf("type=1\n");
-               else
-                       cprintf("type=%d\n", TheMessage->cm_format_type);
+               if (TheMessage->cm_format_type == FMT_RFC822) {
+                       if (do_proto) cprintf("type=1\n");
+               }
+               else {
+                       if (do_proto) cprintf("type=%d\n",
+                               TheMessage->cm_format_type);
+               }
        }
 
        /* nhdr=yes means that we're only displaying headers, no body */
        if ((TheMessage->cm_anon_type == MES_ANON) && (mode == MT_CITADEL)) {
-               cprintf("nhdr=yes\n");
+               if (do_proto) cprintf("nhdr=yes\n");
        }
 
        /* begin header processing loop for Citadel message format */
 
        if ((mode == MT_CITADEL) || (mode == MT_MIME)) {
 
-               if (TheMessage->cm_fields['P']) {
-                       cprintf("path=%s\n", TheMessage->cm_fields['P']);
-               }
-               if (TheMessage->cm_fields['I']) {
-                       cprintf("msgn=%s\n", TheMessage->cm_fields['I']);
-               }
-               if (TheMessage->cm_fields['T']) {
-                       cprintf("time=%s\n", TheMessage->cm_fields['T']);
-               }
+               strcpy(display_name, "<unknown>");
                if (TheMessage->cm_fields['A']) {
                        strcpy(buf, TheMessage->cm_fields['A']);
                        PerformUserHooks(buf, (-1L), EVT_OUTPUTMSG);
                        if (TheMessage->cm_anon_type == MES_ANON)
-                               cprintf("from=****");
+                               strcpy(display_name, "****");
                        else if (TheMessage->cm_anon_type == MES_AN2)
-                               cprintf("from=anonymous");
+                               strcpy(display_name, "anonymous");
                        else
-                               cprintf("from=%s", buf);
+                               strcpy(display_name, buf);
                        if ((is_room_aide())
                            && ((TheMessage->cm_anon_type == MES_ANON)
                             || (TheMessage->cm_anon_type == MES_AN2))) {
-                               cprintf(" [%s]", buf);
+                               sprintf(&display_name[strlen(display_name)],
+                                       " [%s]", buf);
                        }
-                       cprintf("\n");
-               }
-               if (TheMessage->cm_fields['O']) {
-                       cprintf("room=%s\n", TheMessage->cm_fields['O']);
-               }
-               if (TheMessage->cm_fields['N']) {
-                       cprintf("node=%s\n", TheMessage->cm_fields['N']);
                }
-               if (TheMessage->cm_fields['H']) {
-                       cprintf("hnod=%s\n", TheMessage->cm_fields['H']);
-               }
-               if (TheMessage->cm_fields['R']) {
-                       cprintf("rcpt=%s\n", TheMessage->cm_fields['R']);
-               }
-               if (TheMessage->cm_fields['U']) {
-                       cprintf("subj=%s\n", TheMessage->cm_fields['U']);
+
+               strcpy(allkeys, FORDER);
+               for (i=0; i<strlen(allkeys); ++i) {
+                       k = (int) allkeys[i];
+                       if (k != 'M') {
+                               if (TheMessage->cm_fields[k] != NULL) {
+                                       if (k == 'A') {
+                                               if (do_proto) cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       display_name);
+                                       }
+                                       else {
+                                               if (do_proto) cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       TheMessage->cm_fields[k]
+                                       );
+                                       }
+                               }
+                       }
                }
+
        }
 
        /* begin header processing loop for RFC822 transfer format */
 
        strcpy(suser, "");
        strcpy(luser, "");
+       strcpy(fuser, "");
        strcpy(snode, NODENAME);
        strcpy(lnode, HUMANNODE);
        if (mode == MT_RFC822) {
+               cprintf("X-UIDL: %ld%s", msg_num, nl);
                for (i = 0; i < 256; ++i) {
                        if (TheMessage->cm_fields[i]) {
                                mptr = TheMessage->cm_fields[i];
 
                                if (i == 'A') {
                                        strcpy(luser, mptr);
-                               } else if (i == 'P') {
-                                       cprintf("Path: %s\n", mptr);
-                                       for (a = 0; a < strlen(mptr); ++a) {
-                                               if (mptr[a] == '!') {
-                                                       strcpy(mptr, &mptr[a + 1]);
-                                                       a = 0;
-                                               }
-                                       }
                                        strcpy(suser, mptr);
-                               } else if (i == 'U')
-                                       cprintf("Subject: %s\n", mptr);
+                               }
+                               else if (i == 'P') {
+                                       cprintf("Path: %s%s", mptr, nl);
+                               }
+                               else if (i == 'U')
+                                       cprintf("Subject: %s%s", mptr, nl);
                                else if (i == 'I')
                                        strcpy(mid, mptr);
                                else if (i == 'H')
                                        strcpy(lnode, mptr);
                                else if (i == 'O')
-                                       cprintf("X-Citadel-Room: %s\n", mptr);
+                                       cprintf("X-Citadel-Room: %s%s",
+                                               mptr, nl);
                                else if (i == 'N')
                                        strcpy(snode, mptr);
                                else if (i == 'R')
-                                       cprintf("To: %s\n", mptr);
+                                       cprintf("To: %s%s", mptr, nl);
                                else if (i == 'T') {
-                                       xtime = atol(mptr);
-                                       cprintf("Date: %s", asctime(localtime(&xtime)));
+                                       generate_rfc822_datestamp(datestamp,
+                                                               atol(mptr) );
+                                       cprintf("Date: %s%s", datestamp, nl);
                                }
                        }
                }
        }
 
+       for (i=0; i<strlen(suser); ++i) {
+               suser[i] = tolower(suser[i]);
+               if (!isalnum(suser[i])) suser[i]='_';
+       }
+
        if (mode == MT_RFC822) {
                if (!strcasecmp(snode, NODENAME)) {
                        strcpy(snode, FQDN);
                }
-               cprintf("Message-ID: <%s@%s>\n", mid, snode);
+
+               /* Construct a fun message id */
+               cprintf("Message-ID: <%s", mid);
+               if (strchr(mid, '@')==NULL) {
+                       cprintf("@%s", snode);
+               }
+               cprintf(">%s", nl);
+
                PerformUserHooks(luser, (-1L), EVT_OUTPUTMSG);
-               cprintf("From: %s@%s (%s)\n", suser, snode, luser);
-               cprintf("Organization: %s\n", lnode);
+
+               if (strlen(fuser) > 0) {
+                       cprintf("From: %s (%s)%s", fuser, luser, nl);
+               }
+               else {
+                       cprintf("From: %s@%s (%s)%s", suser, snode, luser, nl);
+               }
+
+               cprintf("Organization: %s%s", lnode, nl);
        }
 
        /* end header processing loop ... at this point, we're in the text */
@@ -805,41 +988,60 @@ void output_message(char *msgid, int mode, int headers_only)
        mptr = TheMessage->cm_fields['M'];
 
        /* Tell the client about the MIME parts in this message */
-       if (TheMessage->cm_format_type == 4) {  /* legacy textual dump */
+       if (TheMessage->cm_format_type == FMT_RFC822) {
                if (mode == MT_CITADEL) {
                        mime_parser(mptr, NULL, *list_this_part);
                }
                else if (mode == MT_MIME) {     /* list parts only */
                        mime_parser(mptr, NULL, *list_this_part);
-                       cprintf("000\n");
+                       if (do_proto) cprintf("000\n");
                        CtdlFreeMessage(TheMessage);
-                       return;
+                       return(om_ok);
+               }
+               else if (mode == MT_RFC822) {   /* unparsed RFC822 dump */
+                       /* FIXME ... we have to put some code in here to avoid
+                        * printing duplicate header information when both
+                        * Citadel and RFC822 headers exist.  Preference should
+                        * probably be given to the RFC822 headers.
+                        */
+                       while (ch=*(mptr++), ch!=0) {
+                               if (ch==13) ;
+                               else if (ch==10) cprintf("%s", nl);
+                               else cprintf("%c", ch);
+                       }
+                       if (do_proto) cprintf("000\n");
+                       CtdlFreeMessage(TheMessage);
+                       return(om_ok);
                }
        }
 
        if (headers_only) {
-               cprintf("000\n");
+               if (do_proto) cprintf("000\n");
                CtdlFreeMessage(TheMessage);
-               return;
+               return(om_ok);
        }
 
        /* signify start of msg text */
        if (mode == MT_CITADEL)
-               cprintf("text\n");
-       if ((mode == MT_RFC822) && (TheMessage->cm_format_type != 4))
-               cprintf("\n");
+               if (do_proto) cprintf("text\n");
+       if (mode == MT_RFC822) {
+               if (TheMessage->cm_fields['U'] == NULL) {
+                       cprintf("Subject: (no subject)%s", nl);
+               }
+               cprintf("%s", nl);
+       }
 
        /* If the format type on disk is 1 (fixed-format), then we want
         * everything to be output completely literally ... regardless of
         * what message transfer format is in use.
         */
-       if (TheMessage->cm_format_type == 1) {
+       if (TheMessage->cm_format_type == FMT_FIXED) {
                strcpy(buf, "");
                while (ch = *mptr++, ch > 0) {
                        if (ch == 13)
                                ch = 10;
                        if ((ch == 10) || (strlen(buf) > 250)) {
-                               cprintf("%s\n", buf);
+                               cprintf("%s%s", buf, nl);
                                strcpy(buf, "");
                        } else {
                                buf[strlen(buf) + 1] = 0;
@@ -847,7 +1049,7 @@ void output_message(char *msgid, int mode, int headers_only)
                        }
                }
                if (strlen(buf) > 0)
-                       cprintf("%s\n", buf);
+                       cprintf("%s%s", buf, nl);
        }
 
        /* If the message on disk is format 0 (Citadel vari-format), we
@@ -857,8 +1059,8 @@ void output_message(char *msgid, int mode, int headers_only)
         * for new paragraphs is correct and the client will reformat the
         * message to the reader's screen width.
         */
-       if (TheMessage->cm_format_type == 0) {
-               memfmout(80, mptr, 0);
+       if (TheMessage->cm_format_type == FMT_CITADEL) {
+               memfmout(80, mptr, 0, nl);
        }
 
        /* If the message on disk is format 4 (MIME), we've gotta hand it
@@ -866,16 +1068,16 @@ void output_message(char *msgid, int mode, int headers_only)
         * this message is format 1 (fixed format), so the callback function
         * we use will display those parts as-is.
         */
-       if (TheMessage->cm_format_type == 4) {
+       if (TheMessage->cm_format_type == FMT_RFC822) {
                CtdlAllocUserData(SYM_MA_INFO, sizeof(struct ma_info));
                memset(ma, 0, sizeof(struct ma_info));
                mime_parser(mptr, NULL, *fixed_output);
        }
 
        /* now we're done */
-       cprintf("000\n");
+       if (do_proto) cprintf("000\n");
        CtdlFreeMessage(TheMessage);
-       return;
+       return(om_ok);
 }
 
 
@@ -885,13 +1087,13 @@ void output_message(char *msgid, int mode, int headers_only)
  */
 void cmd_msg0(char *cmdbuf)
 {
-       char msgid[256];
+       long msgid;
        int headers_only = 0;
 
-       extract(msgid, cmdbuf, 0);
+       msgid = extract_long(cmdbuf, 0);
        headers_only = extract_int(cmdbuf, 1);
 
-       output_message(msgid, MT_CITADEL, headers_only);
+       CtdlOutputMsg(msgid, MT_CITADEL, headers_only, 1, 0);
        return;
 }
 
@@ -901,13 +1103,13 @@ void cmd_msg0(char *cmdbuf)
  */
 void cmd_msg2(char *cmdbuf)
 {
-       char msgid[256];
+       long msgid;
        int headers_only = 0;
 
-       extract(msgid, cmdbuf, 0);
+       msgid = extract_long(cmdbuf, 0);
        headers_only = extract_int(cmdbuf, 1);
 
-       output_message(msgid, MT_RFC822, headers_only);
+       CtdlOutputMsg(msgid, MT_RFC822, headers_only, 1, 1);
 }
 
 
@@ -919,7 +1121,7 @@ void cmd_msg3(char *cmdbuf)
 {
        long msgnum;
        struct CtdlMessage *msg;
-       struct sermsgret smr;
+       struct ser_ret smr;
 
        if (CC->internal_pgm == 0) {
                cprintf("%d This command is for internal programs only.\n",
@@ -952,15 +1154,14 @@ void cmd_msg3(char *cmdbuf)
 
 
 /* 
- * display a message (mode 4 - MIME) (FIX ... still evolving, not complete)
+ * display a message (mode 4 - MIME) (FIXME ... still evolving, not complete)
  */
 void cmd_msg4(char *cmdbuf)
 {
-       char msgid[256];
+       long msgid;
 
-       extract(msgid, cmdbuf, 0);
-
-       output_message(msgid, MT_MIME, 0);
+       msgid = extract_long(cmdbuf, 0);
+       CtdlOutputMsg(msgid, MT_MIME, 0, 1, 0);
 }
 
 /*
@@ -968,16 +1169,139 @@ void cmd_msg4(char *cmdbuf)
  */
 void cmd_opna(char *cmdbuf)
 {
-       char msgid[256];
+       long msgid;
 
        CtdlAllocUserData(SYM_DESIRED_SECTION, 64);
 
-       extract(msgid, cmdbuf, 0);
+       msgid = extract_long(cmdbuf, 0);
        extract(desired_section, cmdbuf, 1);
 
-       output_message(msgid, MT_DOWNLOAD, 0);
+       CtdlOutputMsg(msgid, MT_DOWNLOAD, 0, 1, 1);
 }                      
 
+
+/*
+ * Save a message pointer into a specified room
+ * (Returns 0 for success, nonzero for failure)
+ * roomname may be NULL to use the current room
+ */
+int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
+       int i;
+       char hold_rm[ROOMNAMELEN];
+        struct cdbdata *cdbfr;
+        int num_msgs;
+        long *msglist;
+        long highest_msg = 0L;
+       struct CtdlMessage *msg = NULL;
+
+       lprintf(9, "CtdlSaveMsgPointerInRoom(%s, %ld, %d)\n",
+               roomname, msgid, flags);
+
+       strcpy(hold_rm, CC->quickroom.QRname);
+
+       /* We may need to check to see if this message is real */
+       if (  (flags & SM_VERIFY_GOODNESS)
+          || (flags & SM_DO_REPL_CHECK)
+          ) {
+               msg = CtdlFetchMessage(msgid);
+               if (msg == NULL) return(ERROR + ILLEGAL_VALUE);
+       }
+
+       /* Perform replication checks if necessary */
+       if ( (flags & SM_DO_REPL_CHECK) && (msg != NULL) ) {
+
+               if (getroom(&CC->quickroom,
+                  ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+                  != 0) {
+                       lprintf(9, "No such room <%s>\n", roomname);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       return(ERROR + ROOM_NOT_FOUND);
+               }
+
+               if (ReplicationChecks(msg) != 0) {
+                       getroom(&CC->quickroom, hold_rm);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       lprintf(9, "Did replication, and newer exists\n");
+                       return(0);
+               }
+       }
+
+       /* Now the regular stuff */
+       if (lgetroom(&CC->quickroom,
+          ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+          != 0) {
+               lprintf(9, "No such room <%s>\n", roomname);
+               if (msg != NULL) CtdlFreeMessage(msg);
+               return(ERROR + ROOM_NOT_FOUND);
+       }
+
+        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+        if (cdbfr == NULL) {
+                msglist = NULL;
+                num_msgs = 0;
+        } else {
+                msglist = mallok(cdbfr->len);
+                if (msglist == NULL)
+                        lprintf(3, "ERROR malloc msglist!\n");
+                num_msgs = cdbfr->len / sizeof(long);
+                memcpy(msglist, cdbfr->ptr, cdbfr->len);
+                cdb_free(cdbfr);
+        }
+
+
+       /* Make sure the message doesn't already exist in this room.  It
+        * is absolutely taboo to have more than one reference to the same
+        * message in a room.
+        */
+        if (num_msgs > 0) for (i=0; i<num_msgs; ++i) {
+               if (msglist[i] == msgid) {
+                       lputroom(&CC->quickroom);       /* unlock the room */
+                       getroom(&CC->quickroom, hold_rm);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       return(ERROR + ALREADY_EXISTS);
+               }
+       }
+
+        /* Now add the new message */
+        ++num_msgs;
+        msglist = reallok(msglist,
+                          (num_msgs * sizeof(long)));
+
+        if (msglist == NULL) {
+                lprintf(3, "ERROR: can't realloc message list!\n");
+        }
+        msglist[num_msgs - 1] = msgid;
+
+        /* Sort the message list, so all the msgid's are in order */
+        num_msgs = sort_msglist(msglist, num_msgs);
+
+        /* Determine the highest message number */
+        highest_msg = msglist[num_msgs - 1];
+
+        /* Write it back to disk. */
+        cdb_store(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long),
+                  msglist, num_msgs * sizeof(long));
+
+        /* Free up the memory we used. */
+        phree(msglist);
+
+       /* Update the highest-message pointer and unlock the room. */
+       CC->quickroom.QRhighest = highest_msg;
+       lputroom(&CC->quickroom);
+       getroom(&CC->quickroom, hold_rm);
+
+       /* Bump the reference count for this message. */
+       if ((flags & SM_DONT_BUMP_REF)==0) {
+               AdjRefCount(msgid, +1);
+       }
+
+       /* Return success. */
+       if (msg != NULL) CtdlFreeMessage(msg);
+        return (0);
+}
+
+
+
 /*
  * Message base operation to send a message to the master file
  * (returns new message number)
@@ -987,19 +1311,19 @@ void cmd_opna(char *cmdbuf)
  *
  */
 long send_message(struct CtdlMessage *msg,     /* pointer to buffer */
-               int generate_id,                /* generate 'I' field? */
                FILE *save_a_copy)              /* save a copy to disk? */
 {
        long newmsgid;
        long retval;
-       char msgidbuf[32];
-        struct sermsgret smr;
+       char msgidbuf[256];
+        struct ser_ret smr;
 
        /* Get a new message number */
        newmsgid = get_new_message_number();
-       sprintf(msgidbuf, "%ld", newmsgid);
+       sprintf(msgidbuf, "%ld@%s", newmsgid, config.c_fqdn);
 
-       if (generate_id) {
+       /* Generate an ID if we don't have one already */
+       if (msg->cm_fields['I']==NULL) {
                msg->cm_fields['I'] = strdoop(msgidbuf);
        }
        
@@ -1043,31 +1367,25 @@ long send_message(struct CtdlMessage *msg,      /* pointer to buffer */
 /*
  * Serialize a struct CtdlMessage into the format used on disk and network.
  * 
- * This function returns a "struct sermsgret" (defined in msgbase.h) which
+ * This function loads up a "struct ser_ret" (defined in server.h) which
  * contains the length of the serialized message and a pointer to the
  * serialized message in memory.  THE LATTER MUST BE FREED BY THE CALLER.
  */
-void serialize_message(struct sermsgret *ret,          /* return values */
+void serialize_message(struct ser_ret *ret,            /* return values */
                        struct CtdlMessage *msg)        /* unserialized msg */
 {
        size_t wlen;
        int i;
        static char *forder = FORDER;
 
-       lprintf(9, "serialize_message() called\n");
-
        if (is_valid_message(msg) == 0) return;         /* self check */
 
-       lprintf(9, "magic number check OK.\n");
-
        ret->len = 3;
        for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL)
                ret->len = ret->len +
                        strlen(msg->cm_fields[(int)forder[i]]) + 2;
 
-       lprintf(9, "message is %d bytes\n", ret->len);
-
-       lprintf(9, "calling malloc\n");
+       lprintf(9, "calling malloc(%d)\n", ret->len);
        ret->ser = mallok(ret->len);
        if (ret->ser == NULL) {
                ret->len = 0;
@@ -1078,7 +1396,6 @@ void serialize_message(struct sermsgret *ret,             /* return values */
        ret->ser[1] = msg->cm_anon_type;
        ret->ser[2] = msg->cm_format_type;
        wlen = 3;
-       lprintf(9, "stuff\n");
 
        for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL) {
                ret->ser[wlen++] = (char)forder[i];
@@ -1093,38 +1410,110 @@ void serialize_message(struct sermsgret *ret,          /* return values */
 
 
 
+/*
+ * Back end for the ReplicationChecks() function
+ */
+void check_repl(long msgnum) {
+       struct CtdlMessage *msg;
+       time_t timestamp = (-1L);
+
+       lprintf(9, "check_repl() found message %ld\n", msgnum);
+       msg = CtdlFetchMessage(msgnum);
+       if (msg == NULL) return;
+       if (msg->cm_fields['T'] != NULL) {
+               timestamp = atol(msg->cm_fields['T']);
+       }
+       CtdlFreeMessage(msg);
+
+       if (timestamp > msg_repl->highest) {
+               msg_repl->highest = timestamp;  /* newer! */
+               lprintf(9, "newer!\n");
+               return;
+       }
+       lprintf(9, "older!\n");
+
+       /* Existing isn't newer?  Then delete the old one(s). */
+       CtdlDeleteMessages(CC->quickroom.QRname, msgnum, NULL);
+}
+
+
+/*
+ * Check to see if any messages already exist which carry the same Extended ID
+ * as this one.  
+ *
+ * If any are found:
+ * -> With older timestamps: delete them and return 0.  Message will be saved.
+ * -> With newer timestamps: return 1.  Message save will be aborted.
+ */
+int ReplicationChecks(struct CtdlMessage *msg) {
+       struct CtdlMessage *template;
+       int abort_this = 0;
+
+       lprintf(9, "ReplicationChecks() started\n");
+       /* No extended id?  Don't do anything. */
+       if (msg->cm_fields['E'] == NULL) return 0;
+       if (strlen(msg->cm_fields['E']) == 0) return 0;
+       lprintf(9, "Extended ID: <%s>\n", msg->cm_fields['E']);
+
+       CtdlAllocUserData(SYM_REPL, sizeof(struct repl));
+       strcpy(msg_repl->extended_id, msg->cm_fields['E']);
+       msg_repl->highest = atol(msg->cm_fields['T']);
+
+       template = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
+       memset(template, 0, sizeof(struct CtdlMessage));
+       template->cm_fields['E'] = strdoop(msg->cm_fields['E']);
+
+       CtdlForEachMessage(MSGS_ALL, 0L, NULL, template, check_repl);
+
+       /* If a newer message exists with the same Extended ID, abort
+        * this save.
+        */
+       if (msg_repl->highest > atol(msg->cm_fields['T']) ) {
+               abort_this = 1;
+               }
+
+       CtdlFreeMessage(template);
+       lprintf(9, "ReplicationChecks() returning %d\n", abort_this);
+       return(abort_this);
+}
+
+
+
+
 /*
  * Save a message to disk
  */
-void CtdlSaveMsg(struct CtdlMessage *msg,      /* message to save */
+long CtdlSaveMsg(struct CtdlMessage *msg,      /* message to save */
                char *rec,                      /* Recipient (mail) */
                char *force,                    /* force a particular room? */
-               int mailtype,                   /* local or remote type */
-               int generate_id)                /* 1 = generate 'I' field */
+               int supplied_mailtype)          /* local or remote type */
 {
        char aaa[100];
        char hold_rm[ROOMNAMELEN];
        char actual_rm[ROOMNAMELEN];
        char force_room[ROOMNAMELEN];
-       char content_type[256]; /* We have to learn this */
+       char content_type[256];                 /* We have to learn this */
        char recipient[256];
        long newmsgid;
-       char *mptr;
+       char *mptr = NULL;
        struct usersupp userbuf;
        int a;
-       int successful_local_recipients = 0;
-       struct quickroom qtemp;
        struct SuppMsgInfo smi;
        FILE *network_fp = NULL;
        static int seqnum = 1;
+       struct CtdlMessage *imsg;
+       char *instr;
+       int mailtype;
 
        lprintf(9, "CtdlSaveMsg() called\n");
-       if (is_valid_message(msg) == 0) return;         /* self check */
+       if (is_valid_message(msg) == 0) return(-1);     /* self check */
+       mailtype = supplied_mailtype;
 
        /* If this message has no timestamp, we take the liberty of
         * giving it one, right now.
         */
        if (msg->cm_fields['T'] == NULL) {
+               lprintf(9, "Generating timestamp\n");
                sprintf(aaa, "%ld", time(NULL));
                msg->cm_fields['T'] = strdoop(aaa);
        }
@@ -1132,23 +1521,48 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
        /* If this message has no path, we generate one.
         */
        if (msg->cm_fields['P'] == NULL) {
-               msg->cm_fields['P'] = strdoop(msg->cm_fields['A']);
-               for (a=0; a<strlen(msg->cm_fields['P']); ++a) {
-                       if (isspace(msg->cm_fields['P'][a])) {
-                               msg->cm_fields['P'][a] = ' ';
+               lprintf(9, "Generating path\n");
+               if (msg->cm_fields['A'] != NULL) {
+                       msg->cm_fields['P'] = strdoop(msg->cm_fields['A']);
+                       for (a=0; a<strlen(msg->cm_fields['P']); ++a) {
+                               if (isspace(msg->cm_fields['P'][a])) {
+                                       msg->cm_fields['P'][a] = ' ';
+                               }
                        }
                }
+               else {
+                       msg->cm_fields['P'] = strdoop("unknown");
+               }
        }
 
        strcpy(force_room, force);
 
        /* Strip non-printable characters out of the recipient name */
+       lprintf(9, "Checking recipient (if present)\n");
        strcpy(recipient, rec);
        for (a = 0; a < strlen(recipient); ++a)
                if (!isprint(recipient[a]))
                        strcpy(&recipient[a], &recipient[a + 1]);
 
+       /* Change "user @ xxx" to "user" if xxx is an alias for this host */
+       for (a=0; a<strlen(recipient); ++a) {
+               if (recipient[a] == '@') {
+                       if (CtdlHostAlias(&recipient[a+1]) 
+                          == hostalias_localhost) {
+                               recipient[a] = 0;
+                               lprintf(7, "Changed to <%s>\n", recipient);
+                               mailtype = MES_LOCAL;
+                       }
+               }
+       }
+
+       lprintf(9, "Recipient is <%s>\n", recipient);
+
        /* Learn about what's inside, because it's what's inside that counts */
+       lprintf(9, "Learning what's inside\n");
+       if (msg->cm_fields['M'] == NULL) {
+               lprintf(1, "ERROR: attempt to save message with NULL body\n");
+       }
 
        switch (msg->cm_format_type) {
        case 0:
@@ -1179,11 +1593,48 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
                }
        }
 
+       /* Goto the correct room */
+       lprintf(9, "Switching rooms\n");
+       strcpy(hold_rm, CC->quickroom.QRname);
+       strcpy(actual_rm, CC->quickroom.QRname);
+
+       /* If the user is a twit, move to the twit room for posting */
+       lprintf(9, "Handling twit stuff\n");
+       if (TWITDETECT) {
+               if (CC->usersupp.axlevel == 2) {
+                       strcpy(hold_rm, actual_rm);
+                       strcpy(actual_rm, config.c_twitroom);
+               }
+       }
+
+       /* ...or if this message is destined for Aide> then go there. */
+       if (strlen(force_room) > 0) {
+               strcpy(actual_rm, force_room);
+       }
+
+       lprintf(9, "Possibly relocating\n");
+       if (strcasecmp(actual_rm, CC->quickroom.QRname)) {
+               getroom(&CC->quickroom, actual_rm);
+       }
+
+       /*
+        * If this message has no O (room) field, generate one.
+        */
+       if (msg->cm_fields['O'] == NULL) {
+               msg->cm_fields['O'] = strdoop(CC->quickroom.QRname);
+       }
+
        /* Perform "before save" hooks (aborting if any return nonzero) */
-       if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return;
+       lprintf(9, "Performing before-save hooks\n");
+       if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return(-1);
+
+       /* If this message has an Extended ID, perform replication checks */
+       lprintf(9, "Performing replication checks\n");
+       if (ReplicationChecks(msg) > 0) return(-1);
 
        /* Network mail - send a copy to the network program. */
-       if ((strlen(recipient) > 0) && (mailtype != MES_LOCAL)) {
+       if ((strlen(recipient) > 0) && (mailtype == MES_BINARY)) {
+               lprintf(9, "Sending network spool\n");
                sprintf(aaa, "./network/spoolin/netmail.%04lx.%04x.%04x",
                        (long) getpid(), CC->cs_pid, ++seqnum);
                lprintf(9, "Saving a copy to %s\n", aaa);
@@ -1193,56 +1644,47 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
        }
 
        /* Save it to disk */
-       newmsgid = send_message(msg, generate_id, network_fp);
+       lprintf(9, "Saving to disk\n");
+       newmsgid = send_message(msg, network_fp);
        if (network_fp != NULL) {
                fclose(network_fp);
                system("exec nohup ./netproc -i >/dev/null 2>&1 &");
        }
-       if (newmsgid <= 0L)
-               return;
 
-       strcpy(actual_rm, CC->quickroom.QRname);
-       strcpy(hold_rm, "");
+       if (newmsgid <= 0L) return(-1);
+
+       /* Write a supplemental message info record.  This doesn't have to
+        * be a critical section because nobody else knows about this message
+        * yet.
+        */
+       lprintf(9, "Creating SuppMsgInfo record\n");
+       memset(&smi, 0, sizeof(struct SuppMsgInfo));
+       smi.smi_msgnum = newmsgid;
+       smi.smi_refcount = 0;
+       safestrncpy(smi.smi_content_type, content_type, 64);
+       PutSuppMsgInfo(&smi);
+
+       /* Now figure out where to store the pointers */
+       lprintf(9, "Storing pointers\n");
 
        /* If this is being done by the networker delivering a private
         * message, we want to BYPASS saving the sender's copy (because there
         * is no local sender; it would otherwise go to the Trashcan).
         */
        if ((!CC->internal_pgm) || (strlen(recipient) == 0)) {
-               /* If the user is a twit, move to the twit room for posting */
-               if (TWITDETECT)
-                       if (CC->usersupp.axlevel == 2) {
-                               strcpy(hold_rm, actual_rm);
-                               strcpy(actual_rm, config.c_twitroom);
-                       }
-               /* ...or if this message is destined for Aide> then go there. */
-               if (strlen(force_room) > 0) {
-                       strcpy(hold_rm, actual_rm);
-                       strcpy(actual_rm, force_room);
+               if (CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0) != 0) {
+                       lprintf(3, "ERROR saving message pointer!\n");
+                       CtdlSaveMsgPointerInRoom(AIDEROOM, newmsgid, 0);
                }
-               /* This call to usergoto() changes rooms if necessary.  It also
-                  * causes the latest message list to be read into memory.
-                */
-               usergoto(actual_rm, 0);
-
-               /* read in the quickroom record, obtaining a lock... */
-               lgetroom(&CC->quickroom, actual_rm);
-
-               /* Fix an obscure bug */
-               if (!strcasecmp(CC->quickroom.QRname, AIDEROOM)) {
-                       CC->quickroom.QRflags =
-                           CC->quickroom.QRflags & ~QR_MAILBOX;
-               }
-               /* Add the message pointer to the room */
-               CC->quickroom.QRhighest =
-                   AddMessageToRoom(&CC->quickroom, newmsgid);
+       }
 
-               /* update quickroom */
-               lputroom(&CC->quickroom);
-               ++successful_local_recipients;
+       /* For internet mail, drop a copy in the outbound queue room */
+       if (mailtype == MES_INTERNET) {
+               CtdlSaveMsgPointerInRoom(SMTP_SPOOLOUT_ROOM, newmsgid, 0);
        }
 
        /* Bump this user's messages posted counter. */
+       lprintf(9, "Updating user\n");
        lgetuser(&CC->usersupp, CC->curr_user);
        CC->usersupp.posted = CC->usersupp.posted + 1;
        lputuser(&CC->usersupp);
@@ -1252,34 +1694,52 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
         */
        if ((strlen(recipient) > 0) && (mailtype == MES_LOCAL)) {
                if (getuser(&userbuf, recipient) == 0) {
+                       lprintf(9, "Delivering private mail\n");
                        MailboxName(actual_rm, &userbuf, MAILROOM);
-                       if (lgetroom(&qtemp, actual_rm) == 0) {
-                               qtemp.QRhighest =
-                                   AddMessageToRoom(&qtemp, newmsgid);
-                               lputroom(&qtemp);
-                               ++successful_local_recipients;
-                       }
+                       CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0);
+               }
+               else {
+                       lprintf(9, "No user <%s>, saving in %s> instead\n",
+                               recipient, AIDEROOM);
+                       CtdlSaveMsgPointerInRoom(AIDEROOM, newmsgid, 0);
                }
        }
-       /* If we've posted in a room other than the current room, then we
-        * have to now go back to the current room...
-        */
-       if (strlen(hold_rm) > 0) {
-               usergoto(hold_rm, 0);
-       }
-
-       /* Write a supplemental message info record.  This doesn't have to
-        * be a critical section because nobody else knows about this message
-        * yet.
-        */
-       memset(&smi, 0, sizeof(struct SuppMsgInfo));
-       smi.smi_msgnum = newmsgid;
-       smi.smi_refcount = successful_local_recipients;
-       safestrncpy(smi.smi_content_type, content_type, 64);
-       PutSuppMsgInfo(&smi);
 
        /* Perform "after save" hooks */
+       lprintf(9, "Performing after-save hooks\n");
        PerformMessageHooks(msg, EVT_AFTERSAVE);
+
+       /* */
+       lprintf(9, "Returning to original room\n");
+       if (strcasecmp(hold_rm, CC->quickroom.QRname))
+               getroom(&CC->quickroom, hold_rm);
+
+       /* For internet mail, generate delivery instructions 
+        * (Yes, this is recursive!   Deal with it!)
+        */
+       if (mailtype == MES_INTERNET) {
+               lprintf(9, "Generating delivery instructions\n");
+               instr = mallok(2048);
+               sprintf(instr,
+                       "Content-type: %s\n\nmsgid|%ld\nsubmitted|%ld\n"
+                       "bounceto|%s@%s\n"
+                       "remote|%s|0||\n",
+                       SPOOLMIME, newmsgid, time(NULL),
+                       msg->cm_fields['A'], msg->cm_fields['N'],
+                       recipient );
+
+               imsg = mallok(sizeof(struct CtdlMessage));
+               memset(imsg, 0, sizeof(struct CtdlMessage));
+               imsg->cm_magic = CTDLMESSAGE_MAGIC;
+               imsg->cm_anon_type = MES_NORMAL;
+               imsg->cm_format_type = FMT_RFC822;
+               imsg->cm_fields['A'] = strdoop("Citadel");
+               imsg->cm_fields['M'] = instr;
+               CtdlSaveMsg(imsg, "", SMTP_SPOOLOUT_ROOM, MES_LOCAL);
+               CtdlFreeMessage(imsg);
+       }
+
+       return(newmsgid);
 }
 
 
@@ -1303,12 +1763,80 @@ void quickie_message(char *from, char *to, char *room, char *text)
                msg->cm_fields['R'] = strdoop(to);
        msg->cm_fields['M'] = strdoop(text);
 
-       CtdlSaveMsg(msg, "", room, MES_LOCAL, 1);
+       CtdlSaveMsg(msg, "", room, MES_LOCAL);
        CtdlFreeMessage(msg);
        syslog(LOG_NOTICE, text);
 }
 
 
+
+/*
+ * Back end function used by make_message() and similar functions
+ */
+char *CtdlReadMessageBody(char *terminator,    /* token signalling EOT */
+                       size_t maxlen,          /* maximum message length */
+                       char *exist             /* if non-null, append to it;
+                                                  exist is ALWAYS freed  */
+                       ) {
+       char buf[256];
+       size_t message_len = 0;
+       size_t buffer_len = 0;
+       char *ptr, *append;
+       char *m;
+
+       if (exist == NULL) {
+               m = mallok(4096);
+       }
+       else {
+               m = reallok(exist, strlen(exist) + 4096);
+               if (m == NULL) phree(exist);
+       }
+       if (m == NULL) {
+               while ( (client_gets(buf)>0) && strcmp(buf, terminator) ) ;;
+               return(NULL);
+       } else {
+               buffer_len = 4096;
+               m[0] = 0;
+               message_len = 0;
+       }
+       /* read in the lines of message text one by one */
+       append = NULL;
+       while ( (client_gets(buf)>0) && strcmp(buf, terminator) ) {
+
+               /* augment the buffer if we have to */
+               if ((message_len + strlen(buf) + 2) > buffer_len) {
+                       lprintf(9, "realloking\n");
+                       ptr = reallok(m, (buffer_len * 2) );
+                       if (ptr == NULL) {      /* flush if can't allocate */
+                               while ( (client_gets(buf)>0) &&
+                                       strcmp(buf, terminator)) ;;
+                               return(m);
+                       } else {
+                               buffer_len = (buffer_len * 2);
+                               m = ptr;
+                               append = NULL;
+                               lprintf(9, "buffer_len is %d\n", buffer_len);
+                       }
+               }
+
+               if (append == NULL) append = m;
+               while (strlen(append) > 0) ++append;
+               strcpy(append, buf);
+               strcat(append, "\n");
+               message_len = message_len + strlen(buf) + 1;
+
+               /* if we've hit the max msg length, flush the rest */
+               if (message_len >= maxlen) {
+                       while ( (client_gets(buf)>0) && strcmp(buf, terminator)) ;;
+                       return(m);
+               }
+       }
+       return(m);
+}
+
+
+
+
 /*
  * Build a binary message to be saved on disk.
  */
@@ -1326,9 +1854,6 @@ struct CtdlMessage *make_message(
        int a;
        char dest_node[32];
        char buf[256];
-       size_t message_len = 0;
-       size_t buffer_len = 0;
-       char *ptr;
        struct CtdlMessage *msg;
 
        msg = mallok(sizeof(struct CtdlMessage));
@@ -1383,40 +1908,10 @@ struct CtdlMessage *make_message(
        if (dest_node[0] != 0)
                msg->cm_fields['D'] = strdoop(dest_node);
 
-       msg->cm_fields['M'] = mallok(4096);
-       if (msg->cm_fields['M'] == NULL) {
-               while (client_gets(buf), strcmp(buf, "000")) ;; /* flush */
-               return(msg);
-       } else {
-               buffer_len = 4096;
-               msg->cm_fields['M'][0] = 0;
-               message_len = 0;
-       }
-
-       /* read in the lines of message text one by one */
-       while (client_gets(buf), strcmp(buf, "000")) {
-
-               /* augment the buffer if we have to */
-               if ((message_len + strlen(buf) + 2) > buffer_len) {
-                       ptr = reallok(msg->cm_fields['M'], (buffer_len * 2) );
-                       if (ptr == NULL) {      /* flush if can't allocate */
-                               while (client_gets(buf), strcmp(buf, "000")) ;;
-                               return(msg);
-                       } else {
-                               buffer_len = (buffer_len * 2);
-                               msg->cm_fields['M'] = ptr;
-                       }
-               }
 
-               strcat(msg->cm_fields['M'], buf);
-               strcat(msg->cm_fields['M'], "\n");
+       msg->cm_fields['M'] = CtdlReadMessageBody("000",
+                                               config.c_maxmsglen, NULL);
 
-               /* if we've hit the max msg length, flush the rest */
-               if (message_len >= config.c_maxmsglen) {
-                       while (client_gets(buf), strcmp(buf, "000")) ;;
-                       return(msg);
-               }
-       }
 
        return(msg);
 }
@@ -1566,7 +2061,7 @@ SKFALL:   b = MES_NORMAL;
                        CC->quickroom.QRname, b, e, format_type, "");
 
        if (msg != NULL)
-               CtdlSaveMsg(msg, buf, (mtsflag ? AIDEROOM : ""), e, 1);
+               CtdlSaveMsg(msg, buf, (mtsflag ? AIDEROOM : ""), e);
                CtdlFreeMessage(msg);
        CC->fake_postname[0] = '\0';
        return;
@@ -1582,6 +2077,7 @@ void cmd_ent3(char *entargs)
        char recp[256];
        int a;
        int e = 0;
+       int valid_msg = 1;
        unsigned char ch, which_field;
        struct usersupp tempUS;
        long msglen;
@@ -1655,6 +2151,7 @@ void cmd_ent3(char *entargs)
 
        while (msglen > 0) {
                client_read(&which_field, 1);
+               if (!isalpha(which_field)) valid_msg = 0;
                --msglen;
                tempbuf[0] = 0;
                do {
@@ -1664,10 +2161,12 @@ void cmd_ent3(char *entargs)
                        tempbuf[a+1] = 0;
                        tempbuf[a] = ch;
                } while ( (ch != 0) && (msglen > 0) );
-               msg->cm_fields[which_field] = strdoop(tempbuf);
+               if (valid_msg)
+                       msg->cm_fields[which_field] = strdoop(tempbuf);
        }
 
-       CtdlSaveMsg(msg, recp, "", e, 0);
+       msg->cm_flags = CM_SKIP_HOOKS;
+       if (valid_msg) CtdlSaveMsg(msg, recp, "", e);
        CtdlFreeMessage(msg);
        phree(tempbuf);
 }
@@ -1693,7 +2192,7 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
        struct SuppMsgInfo smi;
 
        lprintf(9, "CtdlDeleteMessages(%s, %ld, %s)\n",
-               room_name, dmsgnum, content_type);
+               room_name, dmsgnum, content_type ? content_type : "NULL");
 
        /* get room record, obtaining a lock... */
        if (lgetroom(&qrbuf, room_name) != 0) {
@@ -1761,7 +2260,8 @@ void cmd_dele(char *delstr)
        getuser(&CC->usersupp, CC->curr_user);
        if ((CC->usersupp.axlevel < 6)
            && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
+           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
+           && (!(CC->internal_pgm))) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -1780,17 +2280,20 @@ void cmd_dele(char *delstr)
 
 
 /*
- * move a message to another room
+ * move or copy a message to another room
  */
 void cmd_move(char *args)
 {
        long num;
-       char targ[32];
+       char targ[256];
        struct quickroom qtemp;
-       int foundit;
+       int err;
+       int is_copy = 0;
 
        num = extract_long(args, 0);
        extract(targ, args, 1);
+       targ[ROOMNAMELEN - 1] = 0;
+       is_copy = extract_int(args, 2);
 
        getuser(&CC->usersupp, CC->curr_user);
        if ((CC->usersupp.axlevel < 6)
@@ -1799,28 +2302,26 @@ void cmd_move(char *args)
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
        }
+
        if (getroom(&qtemp, targ) != 0) {
                cprintf("%d '%s' does not exist.\n", ERROR, targ);
                return;
        }
-       /* Bump the reference count, otherwise the message will be deleted
-        * from disk when we remove it from the source room.
-        */
-       AdjRefCount(num, 1);
-
-       /* yank the message out of the current room... */
-       foundit = CtdlDeleteMessages(CC->quickroom.QRname, num, NULL);
 
-       if (foundit) {
-               /* put the message into the target room */
-               lgetroom(&qtemp, targ);
-               qtemp.QRhighest = AddMessageToRoom(&qtemp, num);
-               lputroom(&qtemp);
-               cprintf("%d Message moved.\n", OK);
-       } else {
-               AdjRefCount(num, (-1));         /* oops */
-               cprintf("%d msg %ld does not exist.\n", ERROR, num);
+       err = CtdlSaveMsgPointerInRoom(targ, num,
+               (SM_VERIFY_GOODNESS | SM_DO_REPL_CHECK) );
+       if (err != 0) {
+               cprintf("%d Cannot store message in %s: error %d\n",
+                       err, targ, err);
+               return;
        }
+
+       /* Now delete the message from the source room,
+        * if this is a 'move' rather than a 'copy' operation.
+        */
+       if (is_copy == 0) CtdlDeleteMessages(CC->quickroom.QRname, num, NULL);
+
+       cprintf("%d Message %s.\n", OK, (is_copy ? "copied" : "moved") );
 }
 
 
@@ -1888,10 +2389,11 @@ void AdjRefCount(long msgnum, int incr)
         */
        begin_critical_section(S_SUPPMSGMAIN);
        GetSuppMsgInfo(&smi, msgnum);
+       lprintf(9, "Ref count for message <%ld> before write is <%d>\n",
+               msgnum, smi.smi_refcount);
        smi.smi_refcount += incr;
        PutSuppMsgInfo(&smi);
        end_critical_section(S_SUPPMSGMAIN);
-
        lprintf(9, "Ref count for message <%ld> after write is <%d>\n",
                msgnum, smi.smi_refcount);
 
@@ -1916,27 +2418,27 @@ void AdjRefCount(long msgnum, int incr)
 void CtdlWriteObject(char *req_room,           /* Room to stuff it in */
                        char *content_type,     /* MIME type of this object */
                        char *tempfilename,     /* Where to fetch it from */
-                       int is_mailbox,         /* Private mailbox room? */
+                       struct usersupp *is_mailbox,    /* Mailbox room? */
                        int is_binary,          /* Is encoding necessary? */
-                       int is_unique           /* Del others of this type? */
+                       int is_unique,          /* Del others of this type? */
+                       unsigned int flags      /* Internal save flags */
                        )
 {
 
        FILE *fp, *tempfp;
        char filename[PATH_MAX];
        char cmdbuf[256];
-       int ch;
+       char ch;
        struct quickroom qrbuf;
        char roomname[ROOMNAMELEN];
        struct CtdlMessage *msg;
        size_t len;
 
-       lprintf(9, "CtdlWriteObject() called\n");
-
-       if (is_mailbox)
-               MailboxName(roomname, &CC->usersupp, req_room);
+       if (is_mailbox != NULL)
+               MailboxName(roomname, is_mailbox, req_room);
        else
                safestrncpy(roomname, req_room, sizeof(roomname));
+       lprintf(9, "CtdlWriteObject() to <%s> (flags=%d)\n", roomname, flags);
 
        strcpy(filename, tmpnam(NULL));
        fp = fopen(filename, "w");
@@ -1976,9 +2478,10 @@ void CtdlWriteObject(char *req_room,             /* Room to stuff it in */
        msg->cm_anon_type = MES_NORMAL;
        msg->cm_format_type = 4;
        msg->cm_fields['A'] = strdoop(CC->usersupp.fullname);
-       msg->cm_fields['O'] = strdoop(roomname);
+       msg->cm_fields['O'] = strdoop(req_room);
        msg->cm_fields['N'] = strdoop(config.c_nodename);
        msg->cm_fields['H'] = strdoop(config.c_humannode);
+       msg->cm_flags = flags;
        
        lprintf(9, "Loading\n");
        fp = fopen(filename, "rb");
@@ -1992,7 +2495,9 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
 
        /* Create the requested room if we have to. */
        if (getroom(&qrbuf, roomname) != 0) {
-               create_room(roomname, 4, "", 0);
+               create_room(roomname, 
+                       ( (is_mailbox != NULL) ? 4 : 3 ),
+                       "", 0);
        }
        /* If the caller specified this object as unique, delete all
         * other objects of this type that are currently in the room.
@@ -2002,6 +2507,80 @@ void CtdlWriteObject(char *req_room,             /* Room to stuff it in */
                        CtdlDeleteMessages(roomname, 0L, content_type));
        }
        /* Now write the data */
-       CtdlSaveMsg(msg, "", roomname, MES_LOCAL, 1);
+       CtdlSaveMsg(msg, "", roomname, MES_LOCAL);
        CtdlFreeMessage(msg);
 }
+
+
+
+
+
+
+void CtdlGetSysConfigBackend(long msgnum) {
+       config_msgnum = msgnum;
+}
+
+
+char *CtdlGetSysConfig(char *sysconfname) {
+       char hold_rm[ROOMNAMELEN];
+       long msgnum;
+       char *conf;
+       struct CtdlMessage *msg;
+       char buf[256];
+       
+       strcpy(hold_rm, CC->quickroom.QRname);
+       if (getroom(&CC->quickroom, SYSCONFIGROOM) != 0) {
+               getroom(&CC->quickroom, hold_rm);
+               return NULL;
+       }
+
+
+       /* We want the last (and probably only) config in this room */
+       begin_critical_section(S_CONFIG);
+       config_msgnum = (-1L);
+       CtdlForEachMessage(MSGS_LAST, 1, sysconfname, NULL,
+               CtdlGetSysConfigBackend);
+       msgnum = config_msgnum;
+       end_critical_section(S_CONFIG);
+
+       if (msgnum < 0L) {
+               conf = NULL;
+       }
+       else {
+               msg = CtdlFetchMessage(msgnum);
+               if (msg != NULL) {
+                       conf = strdoop(msg->cm_fields['M']);
+                       CtdlFreeMessage(msg);
+               }
+               else {
+                       conf = NULL;
+               }
+       }
+
+       getroom(&CC->quickroom, hold_rm);
+
+       lprintf(9, "eggstracting...\n");
+       if (conf != NULL) do {
+               extract_token(buf, conf, 0, '\n');
+               lprintf(9, "eggstracted <%s>\n", buf);
+               strcpy(conf, &conf[strlen(buf)+1]);
+       } while ( (strlen(conf)>0) && (strlen(buf)>0) );
+
+       return(conf);
+}
+
+void CtdlPutSysConfig(char *sysconfname, char *sysconfdata) {
+       char temp[PATH_MAX];
+       FILE *fp;
+
+       strcpy(temp, tmpnam(NULL));
+
+       fp = fopen(temp, "w");
+       if (fp == NULL) return;
+       fprintf(fp, "%s", sysconfdata);
+       fclose(fp);
+
+       /* this handy API function does all the work for us */
+       CtdlWriteObject(SYSCONFIGROOM, sysconfname, temp, NULL, 0, 1, 0);
+       unlink(temp);
+}