* Got some more parsing in there
[citadel.git] / citadel / msgbase.c
index ca2d130f4e50bacd770247508643034700d9c9dc..61488f1faf6a7fd178874e0f29a88cf302d0d2e4 100644 (file)
@@ -8,9 +8,6 @@
 #include <ctype.h>
 #include <string.h>
 #include <syslog.h>
-#ifdef HAVE_PTHREAD_H
-#include <pthread.h>
-#endif
 #include <limits.h>
 #include "citadel.h"
 #include "server.h"
 
 #define desired_section ((char *)CtdlGetUserData(SYM_DESIRED_SECTION))
 #define ma ((struct ma_info *)CtdlGetUserData(SYM_MA_INFO))
+#define msg_repl ((struct repl *)CtdlGetUserData(SYM_REPL))
 
 extern struct config config;
 
+char *msgkeys[] = {
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", "", "", "", "", "", "", "", 
+       "", 
+       "from",
+       "", "", "",
+       "exti",
+       "", "", 
+       "hnod",
+       "msgn",
+       "", "", "",
+       "text",
+       "node",
+       "room",
+       "path",
+       "",
+       "rcpt",
+       "spec",
+       "time",
+       "subj",
+       "",
+       "",
+       "",
+       "",
+       ""
+};
+
 /*
  * This function is self explanatory.
  * (What can I say, I'm in a weird mood today...)
@@ -67,8 +98,6 @@ int alias(char *name)
        int a, b;
        char aaa[300], bbb[300];
 
-       lprintf(9, "alias() called for <%s>\n", name);
-
        remove_any_whitespace_to_the_left_or_right_of_at_symbol(name);
 
        fp = fopen("network/mail.aliases", "r");
@@ -183,12 +212,45 @@ void simple_listing(long msgnum)
 }
 
 
+
+/* Determine if a given message matches the fields in a message template.
+ * Return 0 for a successful match.
+ */
+int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
+       int i;
+
+       /* If there aren't any fields in the template, all messages will
+        * match.
+        */
+       if (template == NULL) return(0);
+
+       /* Null messages are bogus. */
+       if (msg == NULL) return(1);
+
+       for (i='A'; i<='Z'; ++i) {
+               if (template->cm_fields[i] != NULL) {
+                       if (msg->cm_fields[i] == NULL) {
+                               return 1;
+                       }
+                       if (strcasecmp(msg->cm_fields[i],
+                               template->cm_fields[i])) return 1;
+               }
+       }
+
+       /* All compares succeeded: we have a match! */
+       return 0;
+}
+
+
+
+
 /*
  * API function to perform an operation for each qualifying message in the
  * current room.
  */
 void CtdlForEachMessage(int mode, long ref,
                        char *content_type,
+                       struct CtdlMessage *compare,
                        void (*CallBack) (long msgnum))
 {
 
@@ -199,6 +261,7 @@ void CtdlForEachMessage(int mode, long ref,
        int num_msgs = 0;
        long thismsg;
        struct SuppMsgInfo smi;
+       struct CtdlMessage *msg;
 
        /* Learn about the user and room in question */
        get_mm();
@@ -231,6 +294,24 @@ void CtdlForEachMessage(int mode, long ref,
                                }
 
        num_msgs = sort_msglist(msglist, num_msgs);
+
+       /* If a template was supplied, filter out the messages which
+        * don't match.  (This could induce some delays!)
+        */
+       if (num_msgs > 0) {
+               if (compare != NULL) {
+                       for (a = 0; a < num_msgs; ++a) {
+                               msg = CtdlFetchMessage(msglist[a]);
+                               if (msg != NULL) {
+                                       if (CtdlMsgCmp(msg, compare)) {
+                                               msglist[a] = 0L;
+                                       }
+                                       CtdlFreeMessage(msg);
+                               }
+                       }
+               }
+       }
+
        
        /*
         * Now iterate through the message list, according to the
@@ -268,10 +349,17 @@ void cmd_msgs(char *cmdbuf)
 {
        int mode = 0;
        char which[256];
+       char buf[256];
+       char tfield[256];
+       char tvalue[256];
        int cm_ref = 0;
+       int i;
+       int with_template = 0;
+       struct CtdlMessage *template = NULL;
 
        extract(which, cmdbuf, 0);
        cm_ref = extract_int(cmdbuf, 1);
+       with_template = extract_int(cmdbuf, 2);
 
        mode = MSGS_ALL;
        strcat(which, "   ");
@@ -290,8 +378,30 @@ void cmd_msgs(char *cmdbuf)
                cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN);
                return;
        }
-       cprintf("%d Message list...\n", LISTING_FOLLOWS);
-       CtdlForEachMessage(mode, cm_ref, NULL, simple_listing);
+
+       if (with_template) {
+               cprintf("%d Send template then receive message list\n",
+                       START_CHAT_MODE);
+               template = (struct CtdlMessage *)
+                       mallok(sizeof(struct CtdlMessage));
+               memset(template, 0, sizeof(struct CtdlMessage));
+               while(client_gets(buf), strcmp(buf,"000")) {
+                       extract(tfield, buf, 0);
+                       extract(tvalue, buf, 1);
+                       for (i='A'; i<='Z'; ++i) if (msgkeys[i]!=NULL) {
+                               if (!strcasecmp(tfield, msgkeys[i])) {
+                                       template->cm_fields[i] =
+                                               strdoop(tvalue);
+                               }
+                       }
+               }
+       }
+       else {
+               cprintf("%d Message list...\n", LISTING_FOLLOWS);
+       }
+
+       CtdlForEachMessage(mode, cm_ref, NULL, template, simple_listing);
+       if (template != NULL) CtdlFreeMessage(template);
        cprintf("000\n");
 }
 
@@ -517,10 +627,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
        CIT_UBYTE field_header;
        size_t field_length;
 
-
        dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
        if (dmsgtext == NULL) {
-               lprintf(9, "CtdlFetchMessage(%ld) failed.\n");
                return NULL;
        }
        mptr = dmsgtext->ptr;
@@ -562,6 +670,10 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
 
        cdb_free(dmsgtext);
 
+       /* Always make sure there's something in the msg text field */
+       if (ret->cm_fields['M'] == NULL)
+               ret->cm_fields['M'] = strdoop("<no text>\n");
+
        /* Perform "before read" hooks (aborting if any return nonzero) */
        if (PerformMessageHooks(ret, EVT_BEFOREREAD) > 0) {
                CtdlFreeMessage(ret);
@@ -613,10 +725,12 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
 void output_message(char *msgid, int mode, int headers_only)
 {
        long msg_num;
-       int a, i;
+       int a, i, k;
        char buf[1024];
        time_t xtime;
        CIT_UBYTE ch;
+       char allkeys[256];
+       char display_name[256];
 
        struct CtdlMessage *TheMessage = NULL;
 
@@ -631,6 +745,7 @@ void output_message(char *msgid, int mode, int headers_only)
        /*                                       */
 
        msg_num = atol(msgid);
+       safestrncpy(mid, msgid, sizeof mid);
 
        if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
                cprintf("%d Not logged in.\n", ERROR + NOT_LOGGED_IN);
@@ -706,46 +821,44 @@ void output_message(char *msgid, int mode, int headers_only)
 
        if ((mode == MT_CITADEL) || (mode == MT_MIME)) {
 
-               if (TheMessage->cm_fields['P']) {
-                       cprintf("path=%s\n", TheMessage->cm_fields['P']);
-               }
-               if (TheMessage->cm_fields['I']) {
-                       cprintf("msgn=%s\n", TheMessage->cm_fields['I']);
-               }
-               if (TheMessage->cm_fields['T']) {
-                       cprintf("time=%s\n", TheMessage->cm_fields['T']);
-               }
+               strcpy(display_name, "<unknown>");
                if (TheMessage->cm_fields['A']) {
                        strcpy(buf, TheMessage->cm_fields['A']);
                        PerformUserHooks(buf, (-1L), EVT_OUTPUTMSG);
                        if (TheMessage->cm_anon_type == MES_ANON)
-                               cprintf("from=****");
+                               strcpy(display_name, "****");
                        else if (TheMessage->cm_anon_type == MES_AN2)
-                               cprintf("from=anonymous");
+                               strcpy(display_name, "anonymous");
                        else
-                               cprintf("from=%s", buf);
+                               strcpy(display_name, buf);
                        if ((is_room_aide())
                            && ((TheMessage->cm_anon_type == MES_ANON)
                             || (TheMessage->cm_anon_type == MES_AN2))) {
-                               cprintf(" [%s]", buf);
+                               sprintf(&display_name[strlen(display_name)],
+                                       " [%s]", buf);
                        }
-                       cprintf("\n");
-               }
-               if (TheMessage->cm_fields['O']) {
-                       cprintf("room=%s\n", TheMessage->cm_fields['O']);
-               }
-               if (TheMessage->cm_fields['N']) {
-                       cprintf("node=%s\n", TheMessage->cm_fields['N']);
                }
-               if (TheMessage->cm_fields['H']) {
-                       cprintf("hnod=%s\n", TheMessage->cm_fields['H']);
-               }
-               if (TheMessage->cm_fields['R']) {
-                       cprintf("rcpt=%s\n", TheMessage->cm_fields['R']);
-               }
-               if (TheMessage->cm_fields['U']) {
-                       cprintf("subj=%s\n", TheMessage->cm_fields['U']);
+
+               strcpy(allkeys, FORDER);
+               for (i=0; i<strlen(allkeys); ++i) {
+                       k = (int) allkeys[i];
+                       if (k != 'M') {
+                               if (TheMessage->cm_fields[k] != NULL) {
+                                       if (k == 'A') {
+                                               cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       display_name);
+                                       }
+                                       else {
+                                               cprintf("%s=%s\n",
+                                                       msgkeys[k],
+                                                       TheMessage->cm_fields[k]
+                                       );
+                                       }
+                               }
+                       }
                }
+
        }
 
        /* begin header processing loop for RFC822 transfer format */
@@ -978,6 +1091,127 @@ void cmd_opna(char *cmdbuf)
        output_message(msgid, MT_DOWNLOAD, 0);
 }                      
 
+
+/*
+ * Save a message pointer into a specified room
+ * (Returns 0 for success, nonzero for failure)
+ * roomname may be NULL to use the current room
+ */
+int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
+       int i;
+       char hold_rm[ROOMNAMELEN];
+        struct cdbdata *cdbfr;
+        int num_msgs;
+        long *msglist;
+        long highest_msg = 0L;
+       struct CtdlMessage *msg = NULL;
+
+       lprintf(9, "CtdlSaveMsgPointerInRoom(%s, %ld, %d)\n",
+               roomname, msgid, flags);
+
+       strcpy(hold_rm, CC->quickroom.QRname);
+
+       /* We may need to check to see if this message is real */
+       if (  (flags & SM_VERIFY_GOODNESS)
+          || (flags & SM_DO_REPL_CHECK)
+          ) {
+               msg = CtdlFetchMessage(msgid);
+               if (msg == NULL) return(ERROR + ILLEGAL_VALUE);
+       }
+
+       /* Perform replication checks if necessary */
+       if ( (flags & SM_DO_REPL_CHECK) && (msg != NULL) ) {
+
+               if (getroom(&CC->quickroom,
+                  ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+                  != 0) {
+                       lprintf(9, "No such room <%s>\n", roomname);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       return(ERROR + ROOM_NOT_FOUND);
+               }
+
+               if (ReplicationChecks(msg) != 0) {
+                       getroom(&CC->quickroom, hold_rm);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       lprintf(9, "Did replication, and newer exists\n");
+                       return(0);
+               }
+       }
+
+       /* Now the regular stuff */
+       if (lgetroom(&CC->quickroom,
+          ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+          != 0) {
+               lprintf(9, "No such room <%s>\n", roomname);
+               if (msg != NULL) CtdlFreeMessage(msg);
+               return(ERROR + ROOM_NOT_FOUND);
+       }
+
+        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+        if (cdbfr == NULL) {
+                msglist = NULL;
+                num_msgs = 0;
+        } else {
+                msglist = mallok(cdbfr->len);
+                if (msglist == NULL)
+                        lprintf(3, "ERROR malloc msglist!\n");
+                num_msgs = cdbfr->len / sizeof(long);
+                memcpy(msglist, cdbfr->ptr, cdbfr->len);
+                cdb_free(cdbfr);
+        }
+
+
+       /* Make sure the message doesn't already exist in this room.  It
+        * is absolutely taboo to have more than one reference to the same
+        * message in a room.
+        */
+        if (num_msgs > 0) for (i=0; i<num_msgs; ++i) {
+               if (msglist[i] == msgid) {
+                       lputroom(&CC->quickroom);       /* unlock the room */
+                       getroom(&CC->quickroom, hold_rm);
+                       if (msg != NULL) CtdlFreeMessage(msg);
+                       return(ERROR + ALREADY_EXISTS);
+               }
+       }
+
+        /* Now add the new message */
+        ++num_msgs;
+        msglist = reallok(msglist,
+                          (num_msgs * sizeof(long)));
+
+        if (msglist == NULL) {
+                lprintf(3, "ERROR: can't realloc message list!\n");
+        }
+        msglist[num_msgs - 1] = msgid;
+
+        /* Sort the message list, so all the msgid's are in order */
+        num_msgs = sort_msglist(msglist, num_msgs);
+
+        /* Determine the highest message number */
+        highest_msg = msglist[num_msgs - 1];
+
+        /* Write it back to disk. */
+        cdb_store(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long),
+                  msglist, num_msgs * sizeof(long));
+
+        /* Free up the memory we used. */
+        phree(msglist);
+
+       /* Update the highest-message pointer and unlock the room. */
+       CC->quickroom.QRhighest = highest_msg;
+       lputroom(&CC->quickroom);
+       getroom(&CC->quickroom, hold_rm);
+
+       /* Bump the reference count for this message. */
+       AdjRefCount(msgid, +1);
+
+       /* Return success. */
+       if (msg != NULL) CtdlFreeMessage(msg);
+        return (0);
+}
+
+
+
 /*
  * Message base operation to send a message to the master file
  * (returns new message number)
@@ -1054,19 +1288,13 @@ void serialize_message(struct ser_ret *ret,             /* return values */
        int i;
        static char *forder = FORDER;
 
-       lprintf(9, "serialize_message() called\n");
-
        if (is_valid_message(msg) == 0) return;         /* self check */
 
-       lprintf(9, "magic number check OK.\n");
-
        ret->len = 3;
        for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL)
                ret->len = ret->len +
                        strlen(msg->cm_fields[(int)forder[i]]) + 2;
 
-       lprintf(9, "message is %d bytes\n", ret->len);
-
        lprintf(9, "calling malloc\n");
        ret->ser = mallok(ret->len);
        if (ret->ser == NULL) {
@@ -1078,7 +1306,6 @@ void serialize_message(struct ser_ret *ret,               /* return values */
        ret->ser[1] = msg->cm_anon_type;
        ret->ser[2] = msg->cm_format_type;
        wlen = 3;
-       lprintf(9, "stuff\n");
 
        for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL) {
                ret->ser[wlen++] = (char)forder[i];
@@ -1093,6 +1320,76 @@ void serialize_message(struct ser_ret *ret,              /* return values */
 
 
 
+/*
+ * Back end for the ReplicationChecks() function
+ */
+void check_repl(long msgnum) {
+       struct CtdlMessage *msg;
+       time_t timestamp = (-1L);
+
+       lprintf(9, "check_repl() found message %ld\n", msgnum);
+       msg = CtdlFetchMessage(msgnum);
+       if (msg == NULL) return;
+       if (msg->cm_fields['T'] != NULL) {
+               timestamp = atol(msg->cm_fields['T']);
+       }
+       CtdlFreeMessage(msg);
+
+       if (timestamp > msg_repl->highest) {
+               msg_repl->highest = timestamp;  /* newer! */
+               lprintf(9, "newer!\n");
+               return;
+       }
+       lprintf(9, "older!\n");
+
+       /* Existing isn't newer?  Then delete the old one(s). */
+       CtdlDeleteMessages(CC->quickroom.QRname, msgnum, NULL);
+}
+
+
+/*
+ * Check to see if any messages already exist which carry the same Extended ID
+ * as this one.  
+ *
+ * If any are found:
+ * -> With older timestamps: delete them and return 0.  Message will be saved.
+ * -> With newer timestamps: return 1.  Message save will be aborted.
+ */
+int ReplicationChecks(struct CtdlMessage *msg) {
+       struct CtdlMessage *template;
+       int abort_this = 0;
+
+       lprintf(9, "ReplicationChecks() started\n");
+       /* No extended id?  Don't do anything. */
+       if (msg->cm_fields['E'] == NULL) return 0;
+       if (strlen(msg->cm_fields['E']) == 0) return 0;
+       lprintf(9, "Extended ID: <%s>\n", msg->cm_fields['E']);
+
+       CtdlAllocUserData(SYM_REPL, sizeof(struct repl));
+       strcpy(msg_repl->extended_id, msg->cm_fields['E']);
+       msg_repl->highest = atol(msg->cm_fields['T']);
+
+       template = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
+       memset(template, 0, sizeof(struct CtdlMessage));
+       template->cm_fields['E'] = strdoop(msg->cm_fields['E']);
+
+       CtdlForEachMessage(MSGS_ALL, 0L, NULL, template, check_repl);
+
+       /* If a newer message exists with the same Extended ID, abort
+        * this save.
+        */
+       if (msg_repl->highest > atol(msg->cm_fields['T']) ) {
+               abort_this = 1;
+               }
+
+       CtdlFreeMessage(template);
+       lprintf(9, "ReplicationChecks() returning %d\n", abort_this);
+       return(abort_this);
+}
+
+
+
+
 /*
  * Save a message to disk
  */
@@ -1106,14 +1403,12 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
        char hold_rm[ROOMNAMELEN];
        char actual_rm[ROOMNAMELEN];
        char force_room[ROOMNAMELEN];
-       char content_type[256]; /* We have to learn this */
+       char content_type[256];                 /* We have to learn this */
        char recipient[256];
        long newmsgid;
        char *mptr;
        struct usersupp userbuf;
        int a;
-       int successful_local_recipients = 0;
-       struct quickroom qtemp;
        struct SuppMsgInfo smi;
        FILE *network_fp = NULL;
        static int seqnum = 1;
@@ -1129,8 +1424,12 @@ void CtdlSaveMsg(struct CtdlMessage *msg,        /* message to save */
                msg->cm_fields['T'] = strdoop(aaa);
        }
 
+       lprintf(9, "checkpoint 1      \n");
        /* If this message has no path, we generate one.
         */
+       if (msg->cm_fields['A'] == NULL) {
+               msg->cm_fields['A'] = strdoop("unknown user");
+       }
        if (msg->cm_fields['P'] == NULL) {
                msg->cm_fields['P'] = strdoop(msg->cm_fields['A']);
                for (a=0; a<strlen(msg->cm_fields['P']); ++a) {
@@ -1142,6 +1441,7 @@ void CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
 
        strcpy(force_room, force);
 
+       lprintf(9, "checkpoint 2      \n");
        /* Strip non-printable characters out of the recipient name */
        strcpy(recipient, rec);
        for (a = 0; a < strlen(recipient); ++a)
@@ -1150,6 +1450,7 @@ void CtdlSaveMsg(struct CtdlMessage *msg, /* message to save */
 
        /* Learn about what's inside, because it's what's inside that counts */
 
+       lprintf(9, "checkpoint 3      \n");
        switch (msg->cm_format_type) {
        case 0:
                strcpy(content_type, "text/x-citadel-variformat");
@@ -1179,9 +1480,39 @@ void CtdlSaveMsg(struct CtdlMessage *msg,        /* message to save */
                }
        }
 
+       lprintf(9, "checkpoint 4      \n");
+       /* Goto the correct room */
+       strcpy(hold_rm, CC->quickroom.QRname);
+       strcpy(actual_rm, CC->quickroom.QRname);
+
+       lprintf(9, "checkpoint 5      \n");
+       /* If the user is a twit, move to the twit room for posting */
+       if ( (CC->logged_in) && (TWITDETECT) ) {
+               if (CC->usersupp.axlevel == 2) {
+                       strcpy(hold_rm, actual_rm);
+                       strcpy(actual_rm, config.c_twitroom);
+               }
+       }
+
+       lprintf(9, "checkpoint 6      \n");
+       /* ...or if this message is destined for Aide> then go there. */
+       if (strlen(force_room) > 0) {
+               strcpy(actual_rm, force_room);
+       }
+
+       lprintf(9, "checkpoint 7      \n");
+       if (strcasecmp(actual_rm, CC->quickroom.QRname))
+               getroom(&CC->quickroom, actual_rm);
+
+       lprintf(9, "checkpoint 8      \n");
        /* Perform "before save" hooks (aborting if any return nonzero) */
        if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return;
 
+       lprintf(9, "checkpoint 9      \n");
+       /* If this message has an Extended ID, perform replication checks */
+       if (ReplicationChecks(msg) > 0) return;
+
+       lprintf(9, "checkpoint 10     \n");
        /* Network mail - send a copy to the network program. */
        if ((strlen(recipient) > 0) && (mailtype != MES_LOCAL)) {
                sprintf(aaa, "./network/spoolin/netmail.%04lx.%04x.%04x",
@@ -1192,94 +1523,66 @@ void CtdlSaveMsg(struct CtdlMessage *msg,       /* message to save */
                        lprintf(2, "ERROR: %s\n", strerror(errno));
        }
 
+       lprintf(9, "checkpoint 11     \n");
        /* Save it to disk */
        newmsgid = send_message(msg, generate_id, network_fp);
        if (network_fp != NULL) {
                fclose(network_fp);
                system("exec nohup ./netproc -i >/dev/null 2>&1 &");
        }
-       if (newmsgid <= 0L)
-               return;
 
-       strcpy(actual_rm, CC->quickroom.QRname);
-       strcpy(hold_rm, "");
+       if (newmsgid <= 0L) return;
+
+       lprintf(9, "checkpoint 12     \n");
+       /* Write a supplemental message info record.  This doesn't have to
+        * be a critical section because nobody else knows about this message
+        * yet.
+        */
+       memset(&smi, 0, sizeof(struct SuppMsgInfo));
+       smi.smi_msgnum = newmsgid;
+       smi.smi_refcount = 0;
+       safestrncpy(smi.smi_content_type, content_type, 64);
+       PutSuppMsgInfo(&smi);
+
+       /* Now figure out where to store the pointers */
 
+
+       lprintf(9, "checkpoint 13     \n");
        /* If this is being done by the networker delivering a private
         * message, we want to BYPASS saving the sender's copy (because there
         * is no local sender; it would otherwise go to the Trashcan).
         */
        if ((!CC->internal_pgm) || (strlen(recipient) == 0)) {
-               /* If the user is a twit, move to the twit room for posting */
-               if (TWITDETECT)
-                       if (CC->usersupp.axlevel == 2) {
-                               strcpy(hold_rm, actual_rm);
-                               strcpy(actual_rm, config.c_twitroom);
-                       }
-               /* ...or if this message is destined for Aide> then go there. */
-               if (strlen(force_room) > 0) {
-                       strcpy(hold_rm, actual_rm);
-                       strcpy(actual_rm, force_room);
-               }
-               /* This call to usergoto() changes rooms if necessary.  It also
-                  * causes the latest message list to be read into memory.
-                */
-               usergoto(actual_rm, 0);
-
-               /* read in the quickroom record, obtaining a lock... */
-               lgetroom(&CC->quickroom, actual_rm);
-
-               /* Fix an obscure bug */
-               if (!strcasecmp(CC->quickroom.QRname, AIDEROOM)) {
-                       CC->quickroom.QRflags =
-                           CC->quickroom.QRflags & ~QR_MAILBOX;
-               }
-               /* Add the message pointer to the room */
-               CC->quickroom.QRhighest =
-                   AddMessageToRoom(&CC->quickroom, newmsgid);
-
-               /* update quickroom */
-               lputroom(&CC->quickroom);
-               ++successful_local_recipients;
+               CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0);
        }
 
+       lprintf(9, "checkpoint 14     \n");
        /* Bump this user's messages posted counter. */
-       lgetuser(&CC->usersupp, CC->curr_user);
-       CC->usersupp.posted = CC->usersupp.posted + 1;
-       lputuser(&CC->usersupp);
+       if (CC->logged_in) {
+               lgetuser(&CC->usersupp, CC->curr_user);
+               CC->usersupp.posted = CC->usersupp.posted + 1;
+               lputuser(&CC->usersupp);
+       }
 
+       lprintf(9, "checkpoint 15     \n");
        /* If this is private, local mail, make a copy in the
         * recipient's mailbox and bump the reference count.
         */
        if ((strlen(recipient) > 0) && (mailtype == MES_LOCAL)) {
                if (getuser(&userbuf, recipient) == 0) {
                        MailboxName(actual_rm, &userbuf, MAILROOM);
-                       if (lgetroom(&qtemp, actual_rm) == 0) {
-                               qtemp.QRhighest =
-                                   AddMessageToRoom(&qtemp, newmsgid);
-                               lputroom(&qtemp);
-                               ++successful_local_recipients;
-                       }
+                       CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0);
                }
        }
-       /* If we've posted in a room other than the current room, then we
-        * have to now go back to the current room...
-        */
-       if (strlen(hold_rm) > 0) {
-               usergoto(hold_rm, 0);
-       }
-
-       /* Write a supplemental message info record.  This doesn't have to
-        * be a critical section because nobody else knows about this message
-        * yet.
-        */
-       memset(&smi, 0, sizeof(struct SuppMsgInfo));
-       smi.smi_msgnum = newmsgid;
-       smi.smi_refcount = successful_local_recipients;
-       safestrncpy(smi.smi_content_type, content_type, 64);
-       PutSuppMsgInfo(&smi);
 
+       lprintf(9, "checkpoint 16     \n");
        /* Perform "after save" hooks */
        PerformMessageHooks(msg, EVT_AFTERSAVE);
+
+       lprintf(9, "checkpoint 17     \n");
+       /* */
+       if (strcasecmp(hold_rm, CC->quickroom.QRname))
+               getroom(&CC->quickroom, hold_rm);
 }
 
 
@@ -1309,6 +1612,64 @@ void quickie_message(char *from, char *to, char *room, char *text)
 }
 
 
+
+/*
+ * Back end function used by make_message() and similar functions
+ */
+char *CtdlReadMessageBody(char *terminator, size_t maxlen) {
+       char buf[256];
+       size_t message_len = 0;
+       size_t buffer_len = 0;
+       char *ptr, *append;
+       char *m;
+
+       m = mallok(4096);
+       if (m == NULL) {
+               while ( (client_gets(buf)>0) && strcmp(buf, terminator) ) ;;
+               return(NULL);
+       } else {
+               buffer_len = 4096;
+               m[0] = 0;
+               message_len = 0;
+       }
+       /* read in the lines of message text one by one */
+       append = NULL;
+       while ( (client_gets(buf)>0) && strcmp(buf, terminator) ) {
+
+               /* augment the buffer if we have to */
+               if ((message_len + strlen(buf) + 2) > buffer_len) {
+                       lprintf(9, "realloking\n");
+                       ptr = reallok(m, (buffer_len * 2) );
+                       if (ptr == NULL) {      /* flush if can't allocate */
+                               while ( (client_gets(buf)>0) &&
+                                       strcmp(buf, terminator)) ;;
+                               return(m);
+                       } else {
+                               buffer_len = (buffer_len * 2);
+                               m = ptr;
+                               append = NULL;
+                               lprintf(9, "buffer_len is %d\n", buffer_len);
+                       }
+               }
+
+               if (append == NULL) append = m;
+               while (strlen(append) > 0) ++append;
+               strcpy(append, buf);
+               strcat(append, "\n");
+               message_len = message_len + strlen(buf) + 1;
+
+               /* if we've hit the max msg length, flush the rest */
+               if (message_len >= maxlen) {
+                       while ( (client_gets(buf)>0) && strcmp(buf, terminator)) ;;
+                       return(m);
+               }
+       }
+       return(m);
+}
+
+
+
+
 /*
  * Build a binary message to be saved on disk.
  */
@@ -1326,9 +1687,6 @@ struct CtdlMessage *make_message(
        int a;
        char dest_node[32];
        char buf[256];
-       size_t message_len = 0;
-       size_t buffer_len = 0;
-       char *ptr;
        struct CtdlMessage *msg;
 
        msg = mallok(sizeof(struct CtdlMessage));
@@ -1383,40 +1741,9 @@ struct CtdlMessage *make_message(
        if (dest_node[0] != 0)
                msg->cm_fields['D'] = strdoop(dest_node);
 
-       msg->cm_fields['M'] = mallok(4096);
-       if (msg->cm_fields['M'] == NULL) {
-               while (client_gets(buf), strcmp(buf, "000")) ;; /* flush */
-               return(msg);
-       } else {
-               buffer_len = 4096;
-               msg->cm_fields['M'][0] = 0;
-               message_len = 0;
-       }
 
-       /* read in the lines of message text one by one */
-       while (client_gets(buf), strcmp(buf, "000")) {
+       msg->cm_fields['M'] = CtdlReadMessageBody("000", config.c_maxmsglen);
 
-               /* augment the buffer if we have to */
-               if ((message_len + strlen(buf) + 2) > buffer_len) {
-                       ptr = reallok(msg->cm_fields['M'], (buffer_len * 2) );
-                       if (ptr == NULL) {      /* flush if can't allocate */
-                               while (client_gets(buf), strcmp(buf, "000")) ;;
-                               return(msg);
-                       } else {
-                               buffer_len = (buffer_len * 2);
-                               msg->cm_fields['M'] = ptr;
-                       }
-               }
-
-               strcat(msg->cm_fields['M'], buf);
-               strcat(msg->cm_fields['M'], "\n");
-
-               /* if we've hit the max msg length, flush the rest */
-               if (message_len >= config.c_maxmsglen) {
-                       while (client_gets(buf), strcmp(buf, "000")) ;;
-                       return(msg);
-               }
-       }
 
        return(msg);
 }
@@ -1582,6 +1909,7 @@ void cmd_ent3(char *entargs)
        char recp[256];
        int a;
        int e = 0;
+       int valid_msg = 1;
        unsigned char ch, which_field;
        struct usersupp tempUS;
        long msglen;
@@ -1655,6 +1983,7 @@ void cmd_ent3(char *entargs)
 
        while (msglen > 0) {
                client_read(&which_field, 1);
+               if (!isalpha(which_field)) valid_msg = 0;
                --msglen;
                tempbuf[0] = 0;
                do {
@@ -1664,10 +1993,12 @@ void cmd_ent3(char *entargs)
                        tempbuf[a+1] = 0;
                        tempbuf[a] = ch;
                } while ( (ch != 0) && (msglen > 0) );
-               msg->cm_fields[which_field] = strdoop(tempbuf);
+               if (valid_msg)
+                       msg->cm_fields[which_field] = strdoop(tempbuf);
        }
 
-       CtdlSaveMsg(msg, recp, "", e, 0);
+       msg->cm_flags = CM_SKIP_HOOKS;
+       if (valid_msg) CtdlSaveMsg(msg, recp, "", e, 0);
        CtdlFreeMessage(msg);
        phree(tempbuf);
 }
@@ -1761,7 +2092,8 @@ void cmd_dele(char *delstr)
        getuser(&CC->usersupp, CC->curr_user);
        if ((CC->usersupp.axlevel < 6)
            && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
+           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
+           && (!(CC->internal_pgm))) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -1780,17 +2112,20 @@ void cmd_dele(char *delstr)
 
 
 /*
- * move a message to another room
+ * move or copy a message to another room
  */
 void cmd_move(char *args)
 {
        long num;
-       char targ[32];
+       char targ[256];
        struct quickroom qtemp;
-       int foundit;
+       int err;
+       int is_copy = 0;
 
        num = extract_long(args, 0);
        extract(targ, args, 1);
+       targ[ROOMNAMELEN - 1] = 0;
+       is_copy = extract_int(args, 2);
 
        getuser(&CC->usersupp, CC->curr_user);
        if ((CC->usersupp.axlevel < 6)
@@ -1799,28 +2134,26 @@ void cmd_move(char *args)
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
        }
+
        if (getroom(&qtemp, targ) != 0) {
                cprintf("%d '%s' does not exist.\n", ERROR, targ);
                return;
        }
-       /* Bump the reference count, otherwise the message will be deleted
-        * from disk when we remove it from the source room.
-        */
-       AdjRefCount(num, 1);
 
-       /* yank the message out of the current room... */
-       foundit = CtdlDeleteMessages(CC->quickroom.QRname, num, NULL);
-
-       if (foundit) {
-               /* put the message into the target room */
-               lgetroom(&qtemp, targ);
-               qtemp.QRhighest = AddMessageToRoom(&qtemp, num);
-               lputroom(&qtemp);
-               cprintf("%d Message moved.\n", OK);
-       } else {
-               AdjRefCount(num, (-1));         /* oops */
-               cprintf("%d msg %ld does not exist.\n", ERROR, num);
+       err = CtdlSaveMsgPointerInRoom(targ, num,
+               (SM_VERIFY_GOODNESS | SM_DO_REPL_CHECK) );
+       if (err != 0) {
+               cprintf("%d Cannot store message in %s: error %d\n",
+                       err, targ, err);
+               return;
        }
+
+       /* Now delete the message from the source room,
+        * if this is a 'move' rather than a 'copy' operation.
+        */
+       if (is_copy == 0) CtdlDeleteMessages(CC->quickroom.QRname, num, NULL);
+
+       cprintf("%d Message %s.\n", OK, (is_copy ? "copied" : "moved") );
 }
 
 
@@ -1918,7 +2251,8 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
                        char *tempfilename,     /* Where to fetch it from */
                        struct usersupp *is_mailbox,    /* Mailbox room? */
                        int is_binary,          /* Is encoding necessary? */
-                       int is_unique           /* Del others of this type? */
+                       int is_unique,          /* Del others of this type? */
+                       unsigned int flags      /* Internal save flags */
                        )
 {
 
@@ -1935,7 +2269,7 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
                MailboxName(roomname, is_mailbox, req_room);
        else
                safestrncpy(roomname, req_room, sizeof(roomname));
-       lprintf(9, "CtdlWriteObject() to <%s>\n", roomname);
+       lprintf(9, "CtdlWriteObject() to <%s> (flags=%d)\n", roomname, flags);
 
        strcpy(filename, tmpnam(NULL));
        fp = fopen(filename, "w");
@@ -1975,9 +2309,10 @@ void CtdlWriteObject(char *req_room,             /* Room to stuff it in */
        msg->cm_anon_type = MES_NORMAL;
        msg->cm_format_type = 4;
        msg->cm_fields['A'] = strdoop(CC->usersupp.fullname);
-       msg->cm_fields['O'] = strdoop(roomname);
+       msg->cm_fields['O'] = strdoop(req_room);
        msg->cm_fields['N'] = strdoop(config.c_nodename);
        msg->cm_fields['H'] = strdoop(config.c_humannode);
+       msg->cm_flags = flags;
        
        lprintf(9, "Loading\n");
        fp = fopen(filename, "rb");