* Renamed the "Extended message ID" field to "Exclusive message ID"
[citadel.git] / citadel / msgbase.c
index d68451b140f5939eddb9f9e845ce8dade5e73f22..98dbafc2714bd5275acc4754d20c546036254e6d 100644 (file)
@@ -29,7 +29,6 @@
 
 #include <ctype.h>
 #include <string.h>
-#include <syslog.h>
 #include <limits.h>
 #include <errno.h>
 #include <stdarg.h>
@@ -176,14 +175,14 @@ int alias(char *name)
                strcpy(name, aaa);
        }
 
-       lprintf(7, "Mail is being forwarded to %s\n", name);
+       lprintf(CTDL_INFO, "Mail is being forwarded to %s\n", name);
 
        /* Change "user @ xxx" to "user" if xxx is an alias for this host */
        for (a=0; a<strlen(name); ++a) {
                if (name[a] == '@') {
                        if (CtdlHostAlias(&name[a+1]) == hostalias_localhost) {
                                name[a] = 0;
-                               lprintf(7, "Changed to <%s>\n", name);
+                               lprintf(CTDL_INFO, "Changed to <%s>\n", name);
                        }
                }
        }
@@ -212,11 +211,11 @@ int alias(char *name)
                extract_token(buf, ignetcfg, i, '\n');
                extract_token(testnode, buf, 0, '|');
                if (!strcasecmp(node, testnode)) {
-                       phree(ignetcfg);
+                       free(ignetcfg);
                        return(MES_IGNET);
                }
        }
-       phree(ignetcfg);
+       free(ignetcfg);
 
        /*
         * Then try nodes that are two or more hops away.
@@ -226,11 +225,11 @@ int alias(char *name)
                extract_token(buf, ignetmap, i, '\n');
                extract_token(testnode, buf, 0, '|');
                if (!strcasecmp(node, testnode)) {
-                       phree(ignetmap);
+                       free(ignetmap);
                        return(MES_IGNET);
                }
        }
-       phree(ignetmap);
+       free(ignetmap);
 
        /* If we get to this point it's an invalid node name */
        return (MES_ERROR);
@@ -242,6 +241,11 @@ void get_mm(void)
        FILE *fp;
 
        fp = fopen("citadel.control", "r");
+       if (fp == NULL) {
+               lprintf(CTDL_CRIT, "Cannot open citadel.control: %s\n",
+                       strerror(errno));
+               exit(errno);
+       }
        fread((char *) &CitControl, sizeof(struct CitControl), 1, fp);
        fclose(fp);
 }
@@ -288,21 +292,24 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
 /*
  * Retrieve the "seen" message list for the current room.
  */
-void CtdlGetSeen(char *buf) {
+void CtdlGetSeen(char *buf, int which_set) {
        struct visit vbuf;
 
        /* Learn about the user and room in question */
-       CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
 
-       safestrncpy(buf, vbuf.v_seen, SIZ);
+       if (which_set == ctdlsetseen_seen)
+               safestrncpy(buf, vbuf.v_seen, SIZ);
+       if (which_set == ctdlsetseen_answered)
+               safestrncpy(buf, vbuf.v_answered, SIZ);
 }
 
 
 
 /*
- * Manipulate the "seen msgs" string.
+ * Manipulate the "seen msgs" string (or other message set strings)
  */
-void CtdlSetSeen(long target_msgnum, int target_setting) {
+void CtdlSetSeen(long target_msgnum, int target_setting, int which_set) {
        char newseen[SIZ];
        struct cdbdata *cdbfr;
        int i;
@@ -313,14 +320,18 @@ void CtdlSetSeen(long target_msgnum, int target_setting) {
        struct visit vbuf;
        long *msglist;
        int num_msgs = 0;
+       char vset[SIZ];
+
+       lprintf(CTDL_DEBUG, "CtdlSetSeen(%ld, %d, %d)\n",
+               target_msgnum, target_setting, which_set);
 
        /* Learn about the user and room in question */
-       CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
 
        /* Load the message list */
-       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
        if (cdbfr != NULL) {
-               msglist = mallok(cdbfr->len);
+               msglist = malloc(cdbfr->len);
                memcpy(msglist, cdbfr->ptr, cdbfr->len);
                num_msgs = cdbfr->len / sizeof(long);
                cdb_free(cdbfr);
@@ -328,7 +339,11 @@ void CtdlSetSeen(long target_msgnum, int target_setting) {
                return; /* No messages at all?  No further action. */
        }
 
-       lprintf(9, "before optimize: %s\n", vbuf.v_seen);
+       /* Decide which message set we're manipulating */
+       if (which_set == ctdlsetseen_seen) strcpy(vset, vbuf.v_seen);
+       if (which_set == ctdlsetseen_answered) strcpy(vset, vbuf.v_answered);
+
+       lprintf(CTDL_DEBUG, "before optimize: %s\n", vset);
        strcpy(newseen, "");
 
        for (i=0; i<num_msgs; ++i) {
@@ -338,7 +353,7 @@ void CtdlSetSeen(long target_msgnum, int target_setting) {
                        is_seen = target_setting;
                }
                else {
-                       if (is_msg_in_mset(vbuf.v_seen, msglist[i])) {
+                       if (is_msg_in_mset(vset, msglist[i])) {
                                is_seen = 1;
                        }
                }
@@ -374,10 +389,13 @@ void CtdlSetSeen(long target_msgnum, int target_setting) {
                was_seen = is_seen;
        }
 
-       safestrncpy(vbuf.v_seen, newseen, SIZ);
-       lprintf(9, " after optimize: %s\n", vbuf.v_seen);
-       phree(msglist);
-       CtdlSetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+       /* Decide which message set we're manipulating */
+       if (which_set == ctdlsetseen_seen) strcpy(vbuf.v_seen, newseen);
+       if (which_set == ctdlsetseen_answered) strcpy(vbuf.v_answered, newseen);
+
+       lprintf(CTDL_DEBUG, " after optimize: %s\n", newseen);
+       free(msglist);
+       CtdlSetRelationship(&vbuf, &CC->user, &CC->room);
 }
 
 
@@ -407,13 +425,13 @@ int CtdlForEachMessage(int mode, long ref,
 
        /* Learn about the user and room in question */
        get_mm();
-       getuser(&CC->usersupp, CC->curr_user);
-       CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
+       getuser(&CC->user, CC->curr_user);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
 
        /* Load the message list */
-       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
        if (cdbfr != NULL) {
-               msglist = mallok(cdbfr->len);
+               msglist = malloc(cdbfr->len);
                memcpy(msglist, cdbfr->ptr, cdbfr->len);
                num_msgs = cdbfr->len / sizeof(long);
                cdb_free(cdbfr);
@@ -457,7 +475,7 @@ int CtdlForEachMessage(int mode, long ref,
        if (num_msgs > 0) {
                if (compare != NULL) {
                        for (a = 0; a < num_msgs; ++a) {
-                               msg = CtdlFetchMessage(msglist[a]);
+                               msg = CtdlFetchMessage(msglist[a], 1);
                                if (msg != NULL) {
                                        if (CtdlMsgCmp(msg, compare)) {
                                                msglist[a] = 0L;
@@ -490,7 +508,7 @@ int CtdlForEachMessage(int mode, long ref,
                                || ((mode == MSGS_EQ) && (thismsg == ref))
                            )
                            ) {
-                               if ((mode == MSGS_NEW) && (CC->usersupp.flags & US_LASTOLD) && (lastold > 0L) && (printed_lastold == 0) && (!is_seen)) {
+                               if ((mode == MSGS_NEW) && (CC->user.flags & US_LASTOLD) && (lastold > 0L) && (printed_lastold == 0) && (!is_seen)) {
                                        if (CallBack)
                                                CallBack(lastold, userdata);
                                        printed_lastold = 1;
@@ -500,7 +518,7 @@ int CtdlForEachMessage(int mode, long ref,
                                ++num_processed;
                        }
                }
-       phree(msglist);         /* Clean up */
+       free(msglist);          /* Clean up */
        return num_processed;
 }
 
@@ -545,10 +563,11 @@ void cmd_msgs(char *cmdbuf)
        }
 
        if (with_template) {
+               unbuffer_output();
                cprintf("%d Send template then receive message list\n",
                        START_CHAT_MODE);
                template = (struct CtdlMessage *)
-                       mallok(sizeof(struct CtdlMessage));
+                       malloc(sizeof(struct CtdlMessage));
                memset(template, 0, sizeof(struct CtdlMessage));
                while(client_gets(buf), strcmp(buf,"000")) {
                        extract(tfield, buf, 0);
@@ -556,10 +575,11 @@ void cmd_msgs(char *cmdbuf)
                        for (i='A'; i<='Z'; ++i) if (msgkeys[i]!=NULL) {
                                if (!strcasecmp(tfield, msgkeys[i])) {
                                        template->cm_fields[i] =
-                                               strdoop(tvalue);
+                                               strdup(tvalue);
                                }
                        }
                }
+               buffer_output();
        }
        else {
                cprintf("%d Message list...\n", LISTING_FOLLOWS);
@@ -597,8 +617,8 @@ void do_help_subst(char *buffer)
        help_subst(buffer, "^nodename", config.c_nodename);
        help_subst(buffer, "^humannode", config.c_humannode);
        help_subst(buffer, "^fqdn", config.c_fqdn);
-       help_subst(buffer, "^username", CC->usersupp.fullname);
-       snprintf(buf2, sizeof buf2, "%ld", CC->usersupp.usernum);
+       help_subst(buffer, "^username", CC->user.fullname);
+       snprintf(buf2, sizeof buf2, "%ld", CC->user.usernum);
        help_subst(buffer, "^usernum", buf2);
        help_subst(buffer, "^sysadm", config.c_sysadm);
        help_subst(buffer, "^variantname", CITADEL);
@@ -766,7 +786,7 @@ void mime_download(char *name, char *filename, char *partnum, char *disp,
  * NOTE: Caller is responsible for freeing the returned CtdlMessage struct
  *       using the CtdlMessageFree() function.
  */
-struct CtdlMessage *CtdlFetchMessage(long msgnum)
+struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
 {
        struct cdbdata *dmsgtext;
        struct CtdlMessage *ret = NULL;
@@ -775,6 +795,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
        cit_uint8_t field_header;
        size_t field_length;
 
+       lprintf(CTDL_DEBUG, "CtdlFetchMessage(%ld, %d)\n", msgnum, with_body);
+
        dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
        if (dmsgtext == NULL) {
                return NULL;
@@ -788,11 +810,13 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
         */
        ch = *mptr++;
        if (ch != 255) {
-               lprintf(5, "Message %ld appears to be corrupted.\n", msgnum);
+               lprintf(CTDL_ERR,
+                       "Message %ld appears to be corrupted.\n",
+                       msgnum);
                cdb_free(dmsgtext);
                return NULL;
        }
-       ret = (struct CtdlMessage *) mallok(sizeof(struct CtdlMessage));
+       ret = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
        memset(ret, 0, sizeof(struct CtdlMessage));
 
        ret->cm_magic = CTDLMESSAGE_MAGIC;
@@ -809,7 +833,7 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
                if (field_length == 0)
                        break;
                field_header = *mptr++;
-               ret->cm_fields[field_header] = mallok(field_length);
+               ret->cm_fields[field_header] = malloc(field_length + 1);
                strcpy(ret->cm_fields[field_header], mptr);
 
                while (*mptr++ != 0);   /* advance to next field */
@@ -818,9 +842,21 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum)
 
        cdb_free(dmsgtext);
 
-       /* Always make sure there's something in the msg text field */
-       if (ret->cm_fields['M'] == NULL)
-               ret->cm_fields['M'] = strdoop("<no text>\n");
+       /* Always make sure there's something in the msg text field.  If
+        * it's NULL, the message text is most likely stored separately,
+        * so go ahead and fetch that.  Failing that, just set a dummy
+        * body so other code doesn't barf.
+        */
+       if ( (ret->cm_fields['M'] == NULL) && (with_body) ) {
+               dmsgtext = cdb_fetch(CDB_BIGMSGS, &msgnum, sizeof(long));
+               if (dmsgtext != NULL) {
+                       ret->cm_fields['M'] = strdup(dmsgtext->ptr);
+                       cdb_free(dmsgtext);
+               }
+       }
+       if (ret->cm_fields['M'] == NULL) {
+               ret->cm_fields['M'] = strdup("<no text>\n");
+       }
 
        /* Perform "before read" hooks (aborting if any return nonzero) */
        if (PerformMessageHooks(ret, EVT_BEFOREREAD) > 0) {
@@ -840,7 +876,7 @@ int is_valid_message(struct CtdlMessage *msg) {
        if (msg == NULL)
                return 0;
        if ((msg->cm_magic) != CTDLMESSAGE_MAGIC) {
-               lprintf(3, "is_valid_message() -- self-check failed\n");
+               lprintf(CTDL_WARNING, "is_valid_message() -- self-check failed\n");
                return 0;
        }
        return 1;
@@ -858,11 +894,11 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
 
        for (i = 0; i < 256; ++i)
                if (msg->cm_fields[i] != NULL) {
-                       phree(msg->cm_fields[i]);
+                       free(msg->cm_fields[i]);
                }
 
        msg->cm_magic = 0;      /* just in case */
-       phree(msg);
+       free(msg);
 }
 
 
@@ -880,7 +916,7 @@ void fixed_output_pre(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, size_t length, char *encoding,
                void *cbuserdata)
 {
-               lprintf(9, "fixed_output_pre() type=<%s>\n", cbtype);   
+               lprintf(CTDL_DEBUG, "fixed_output_pre() type=<%s>\n", cbtype);  
                if (!strcasecmp(cbtype, "multipart/alternative")) {
                        ++ma->is_ma;
                        ma->did_print = 0;
@@ -895,7 +931,7 @@ void fixed_output_post(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, size_t length, char *encoding,
                void *cbuserdata)
 {
-               lprintf(9, "fixed_output_post() type=<%s>\n", cbtype);  
+               lprintf(CTDL_DEBUG, "fixed_output_post() type=<%s>\n", cbtype); 
                if (!strcasecmp(cbtype, "multipart/alternative")) {
                        --ma->is_ma;
                        ma->did_print = 0;
@@ -914,14 +950,14 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp,
                char *wptr;
                size_t wlen;
 
-               lprintf(9, "fixed_output() type=<%s>\n", cbtype);       
+               lprintf(CTDL_DEBUG, "fixed_output() type=<%s>\n", cbtype);      
 
                /*
                 * If we're in the middle of a multipart/alternative scope and
                 * we've already printed another section, skip this one.
                 */     
                if ( (ma->is_ma == 1) && (ma->did_print == 1) ) {
-                       lprintf(9, "Skipping part %s (%s)\n", partnum, cbtype);
+                       lprintf(CTDL_DEBUG, "Skipping part %s (%s)\n", partnum, cbtype);
                        return;
                }
                ma->did_print = 1;
@@ -943,7 +979,7 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp,
                        if (ptr[wlen-1] != '\n') {
                                cprintf("\n");
                        }
-                       phree(ptr);
+                       free(ptr);
                }
                else if (strncasecmp(cbtype, "multipart/", 10)) {
                        cprintf("Part %s: %s (%s) (%ld bytes)\r\n",
@@ -1034,41 +1070,35 @@ int CtdlOutputMsg(long msg_num,         /* message number (local) to fetch */
                int do_proto,           /* do Citadel protocol responses? */
                int crlf                /* Use CRLF newlines instead of LF? */
 ) {
-       struct CtdlMessage *TheMessage;
-       int retcode;
+       struct CtdlMessage *TheMessage = NULL;
+       int retcode = om_no_such_msg;
 
-       lprintf(7, "CtdlOutputMsg() msgnum=%ld, mode=%d\n", 
+       lprintf(CTDL_DEBUG, "CtdlOutputMsg() msgnum=%ld, mode=%d\n", 
                msg_num, mode);
 
-       TheMessage = NULL;
-
        if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
                if (do_proto) cprintf("%d Not logged in.\n",
                        ERROR + NOT_LOGGED_IN);
                return(om_not_logged_in);
        }
 
-       /* FIXME ... small security issue
-        * We need to check to make sure the requested message is actually
-        * in the current room, and set msg_ok to 1 only if it is.  This
-        * functionality is currently missing because I'm in a hurry to replace
-        * broken production code with nonbroken pre-beta code.  :(   -- ajc
-        *
-        if (!msg_ok) {
-        if (do_proto) cprintf("%d Message %ld is not in this room.\n",
-        ERROR, msg_num);
-        return(om_no_such_msg);
-        }
-        */
+       /* FIXME: check message id against msglist for this room */
 
        /*
-        * Fetch the message from disk.
+        * Fetch the message from disk.  If we're in sooper-fast headers
+        * only mode, request that we don't even bother loading the body
+        * into memory.
         */
-       TheMessage = CtdlFetchMessage(msg_num);
+       if (headers_only == HEADERS_FAST) {
+               TheMessage = CtdlFetchMessage(msg_num, 0);
+       }
+       else {
+               TheMessage = CtdlFetchMessage(msg_num, 1);
+       }
 
        if (TheMessage == NULL) {
                if (do_proto) cprintf("%d Can't locate msg %ld on disk\n",
-                       ERROR, msg_num);
+                       ERROR + MESSAGE_NOT_FOUND, msg_num);
                return(om_no_such_msg);
        }
        
@@ -1086,7 +1116,8 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
  * Get a message off disk.  (returns om_* values found in msgbase.h)
  * 
  */
-int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
+int CtdlOutputPreLoadedMsg(
+               struct CtdlMessage *TheMessage,
                long msg_num,
                int mode,               /* how would you like that message? */
                int headers_only,       /* eschew the message body? */
@@ -1094,7 +1125,7 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
                int crlf                /* Use CRLF newlines instead of LF? */
 ) {
        int i, k;
-       char buf[1024];
+       char buf[SIZ];
        cit_uint8_t ch;
        char allkeys[SIZ];
        char display_name[SIZ];
@@ -1113,11 +1144,17 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
        char datestamp[SIZ];
        /*                                       */
 
+       lprintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %ld, %d, %d, %d, %d\n",
+               ((TheMessage == NULL) ? "NULL" : "not null"),
+               msg_num,
+               mode, headers_only, do_proto, crlf);
+
        snprintf(mid, sizeof mid, "%ld", msg_num);
        nl = (crlf ? "\r\n" : "\n");
 
        if (!is_valid_message(TheMessage)) {
-               lprintf(1, "ERROR: invalid preloaded message for output\n");
+               lprintf(CTDL_ERR,
+                       "ERROR: invalid preloaded message for output\n");
                return(om_no_such_msg);
        }
 
@@ -1126,11 +1163,11 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
                if (TheMessage->cm_format_type != FMT_RFC822) {
                        if (do_proto)
                                cprintf("%d This is not a MIME message.\n",
-                               ERROR);
+                               ERROR + ILLEGAL_VALUE);
                } else if (CC->download_fp != NULL) {
                        if (do_proto) cprintf(
                                "%d You already have a download open.\n",
-                               ERROR);
+                               ERROR + RESOURCE_BUSY);
                } else {
                        /* Parse the message text component */
                        mptr = TheMessage->cm_fields['M'];
@@ -1176,7 +1213,6 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
                strcpy(display_name, "<unknown>");
                if (TheMessage->cm_fields['A']) {
                        strcpy(buf, TheMessage->cm_fields['A']);
-                       PerformUserHooks(buf, (-1L), EVT_OUTPUTMSG);
                        if (TheMessage->cm_anon_type == MES_ANONONLY) {
                                strcpy(display_name, "****");
                        }
@@ -1242,24 +1278,14 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
        strcpy(snode, NODENAME);
        strcpy(lnode, HUMANNODE);
        if (mode == MT_RFC822) {
-               cprintf("X-UIDL: %ld%s", msg_num, nl);
                for (i = 0; i < 256; ++i) {
                        if (TheMessage->cm_fields[i]) {
                                mptr = TheMessage->cm_fields[i];
 
                                if (i == 'A') {
-                                       strcpy(luser, mptr);
-                                       strcpy(suser, mptr);
-                               }
-/****
- "Path:" removed for now because it confuses brain-dead Microsoft shitware
- into thinking that mail messages are newsgroup messages instead.  When we
- add NNTP support back into Citadel we'll have to add code to only output
- this field when appropriate.
-                               else if (i == 'P') {
-                                       cprintf("Path: %s%s", mptr, nl);
+                                       safestrncpy(luser, mptr, sizeof luser);
+                                       safestrncpy(suser, mptr, sizeof suser);
                                }
- ****/
                                else if (i == 'U') {
                                        cprintf("Subject: %s%s", mptr, nl);
                                        subject_found = 1;
@@ -1296,7 +1322,7 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
 
        if (mode == MT_RFC822) {
                if (!strcasecmp(snode, NODENAME)) {
-                       strcpy(snode, FQDN);
+                       safestrncpy(snode, FQDN, sizeof snode);
                }
 
                /* Construct a fun message id */
@@ -1306,9 +1332,13 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
                }
                cprintf(">%s", nl);
 
-               PerformUserHooks(luser, (-1L), EVT_OUTPUTMSG);
-
-               if (strlen(fuser) > 0) {
+               if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONONLY)) {
+                       cprintf("From: x@x.org (----)%s", nl);
+               }
+               else if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONOPT)) {
+                       cprintf("From: x@x.org (anonymous)%s", nl);
+               }
+               else if (strlen(fuser) > 0) {
                        cprintf("From: %s (%s)%s", fuser, luser, nl);
                }
                else {
@@ -1325,6 +1355,7 @@ int CtdlOutputPreLoadedMsg(struct CtdlMessage *TheMessage,
 
        /* end header processing loop ... at this point, we're in the text */
 START_TEXT:
+       if (headers_only == HEADERS_FAST) goto DONE;
        mptr = TheMessage->cm_fields['M'];
 
        /* Tell the client about the MIME parts in this message */
@@ -1503,15 +1534,15 @@ void cmd_msg3(char *cmdbuf)
 
        if (CC->internal_pgm == 0) {
                cprintf("%d This command is for internal programs only.\n",
-                       ERROR);
+                       ERROR + HIGHER_ACCESS_REQUIRED);
                return;
        }
 
        msgnum = extract_long(cmdbuf, 0);
-       msg = CtdlFetchMessage(msgnum);
+       msg = CtdlFetchMessage(msgnum, 1);
        if (msg == NULL) {
                cprintf("%d Message %ld not found.\n", 
-                       ERROR, msgnum);
+                       ERROR + MESSAGE_NOT_FOUND, msgnum);
                return;
        }
 
@@ -1520,13 +1551,13 @@ void cmd_msg3(char *cmdbuf)
 
        if (smr.len == 0) {
                cprintf("%d Unable to serialize message\n",
-                       ERROR+INTERNAL_ERROR);
+                       ERROR + INTERNAL_ERROR);
                return;
        }
 
        cprintf("%d %ld\n", BINARY_FOLLOWS, (long)smr.len);
-       client_write(smr.ser, smr.len);
-       phree(smr.ser);
+       client_write((char *)smr.ser, (int)smr.len);
+       free(smr.ser);
 }
 
 
@@ -1585,55 +1616,56 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
         long highest_msg = 0L;
        struct CtdlMessage *msg = NULL;
 
-       lprintf(9, "CtdlSaveMsgPointerInRoom(%s, %ld, %d)\n",
+       lprintf(CTDL_DEBUG, "CtdlSaveMsgPointerInRoom(%s, %ld, %d)\n",
                roomname, msgid, flags);
 
-       strcpy(hold_rm, CC->quickroom.QRname);
+       strcpy(hold_rm, CC->room.QRname);
 
        /* We may need to check to see if this message is real */
        if (  (flags & SM_VERIFY_GOODNESS)
           || (flags & SM_DO_REPL_CHECK)
           ) {
-               msg = CtdlFetchMessage(msgid);
+               msg = CtdlFetchMessage(msgid, 1);
                if (msg == NULL) return(ERROR + ILLEGAL_VALUE);
        }
 
        /* Perform replication checks if necessary */
        if ( (flags & SM_DO_REPL_CHECK) && (msg != NULL) ) {
 
-               if (getroom(&CC->quickroom,
-                  ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+               if (getroom(&CC->room,
+                  ((roomname != NULL) ? roomname : CC->room.QRname) )
                   != 0) {
-                       lprintf(9, "No such room <%s>\n", roomname);
+                       lprintf(CTDL_ERR, "No such room <%s>\n", roomname);
                        if (msg != NULL) CtdlFreeMessage(msg);
                        return(ERROR + ROOM_NOT_FOUND);
                }
 
                if (ReplicationChecks(msg) != 0) {
-                       getroom(&CC->quickroom, hold_rm);
+                       getroom(&CC->room, hold_rm);
                        if (msg != NULL) CtdlFreeMessage(msg);
-                       lprintf(9, "Did replication, and newer exists\n");
+                       lprintf(CTDL_DEBUG,
+                               "Did replication, and newer exists\n");
                        return(0);
                }
        }
 
        /* Now the regular stuff */
-       if (lgetroom(&CC->quickroom,
-          ((roomname != NULL) ? roomname : CC->quickroom.QRname) )
+       if (lgetroom(&CC->room,
+          ((roomname != NULL) ? roomname : CC->room.QRname) )
           != 0) {
-               lprintf(9, "No such room <%s>\n", roomname);
+               lprintf(CTDL_ERR, "No such room <%s>\n", roomname);
                if (msg != NULL) CtdlFreeMessage(msg);
                return(ERROR + ROOM_NOT_FOUND);
        }
 
-        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
+        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
         if (cdbfr == NULL) {
                 msglist = NULL;
                 num_msgs = 0;
         } else {
-                msglist = mallok(cdbfr->len);
+                msglist = malloc(cdbfr->len);
                 if (msglist == NULL)
-                        lprintf(3, "ERROR malloc msglist!\n");
+                        lprintf(CTDL_ALERT, "ERROR malloc msglist!\n");
                 num_msgs = cdbfr->len / sizeof(long);
                 memcpy(msglist, cdbfr->ptr, cdbfr->len);
                 cdb_free(cdbfr);
@@ -1646,20 +1678,20 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
         */
         if (num_msgs > 0) for (i=0; i<num_msgs; ++i) {
                if (msglist[i] == msgid) {
-                       lputroom(&CC->quickroom);       /* unlock the room */
-                       getroom(&CC->quickroom, hold_rm);
+                       lputroom(&CC->room);    /* unlock the room */
+                       getroom(&CC->room, hold_rm);
                        if (msg != NULL) CtdlFreeMessage(msg);
+                       free(msglist);
                        return(ERROR + ALREADY_EXISTS);
                }
        }
 
         /* Now add the new message */
         ++num_msgs;
-        msglist = reallok(msglist,
-                          (num_msgs * sizeof(long)));
+        msglist = realloc(msglist, (num_msgs * sizeof(long)));
 
         if (msglist == NULL) {
-                lprintf(3, "ERROR: can't realloc message list!\n");
+                lprintf(CTDL_ALERT, "ERROR: can't realloc message list!\n");
         }
         msglist[num_msgs - 1] = msgid;
 
@@ -1670,16 +1702,16 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
         highest_msg = msglist[num_msgs - 1];
 
         /* Write it back to disk. */
-        cdb_store(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long),
-                  msglist, num_msgs * sizeof(long));
+        cdb_store(CDB_MSGLISTS, &CC->room.QRnumber, (int)sizeof(long),
+                  msglist, (int)(num_msgs * sizeof(long)));
 
         /* Free up the memory we used. */
-        phree(msglist);
+        free(msglist);
 
        /* Update the highest-message pointer and unlock the room. */
-       CC->quickroom.QRhighest = highest_msg;
-       lputroom(&CC->quickroom);
-       getroom(&CC->quickroom, hold_rm);
+       CC->room.QRhighest = highest_msg;
+       lputroom(&CC->room);
+       getroom(&CC->room, hold_rm);
 
        /* Bump the reference count for this message. */
        if ((flags & SM_DONT_BUMP_REF)==0) {
@@ -1694,20 +1726,20 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
 
 
 /*
- * Message base operation to send a message to the master file
+ * Message base operation to save a new message to the message store
  * (returns new message number)
  *
  * This is the back end for CtdlSubmitMsg() and should not be directly
  * called by server-side modules.
  *
  */
-long send_message(struct CtdlMessage *msg,     /* pointer to buffer */
-               FILE *save_a_copy)              /* save a copy to disk? */
-{
+long send_message(struct CtdlMessage *msg) {
        long newmsgid;
        long retval;
        char msgidbuf[SIZ];
         struct ser_ret smr;
+       int is_bigmsg = 0;
+       char *holdM = NULL;
 
        /* Get a new message number */
        newmsgid = get_new_message_number();
@@ -1715,35 +1747,50 @@ long send_message(struct CtdlMessage *msg,      /* pointer to buffer */
 
        /* Generate an ID if we don't have one already */
        if (msg->cm_fields['I']==NULL) {
-               msg->cm_fields['I'] = strdoop(msgidbuf);
+               msg->cm_fields['I'] = strdup(msgidbuf);
        }
-       
+
+       /* If the message is big, set its body aside for storage elsewhere */
+       if (msg->cm_fields['M'] != NULL) {
+               if (strlen(msg->cm_fields['M']) > BIGMSG) {
+                       is_bigmsg = 1;
+                       holdM = msg->cm_fields['M'];
+                       msg->cm_fields['M'] = NULL;
+               }
+       }
+
+       /* Serialize our data structure for storage in the database */  
         serialize_message(&smr, msg);
 
+       if (is_bigmsg) {
+               msg->cm_fields['M'] = holdM;
+       }
+
         if (smr.len == 0) {
                 cprintf("%d Unable to serialize message\n",
-                        ERROR+INTERNAL_ERROR);
+                        ERROR + INTERNAL_ERROR);
                 return (-1L);
         }
 
        /* Write our little bundle of joy into the message base */
-       if (cdb_store(CDB_MSGMAIN, &newmsgid, sizeof(long),
+       if (cdb_store(CDB_MSGMAIN, &newmsgid, (int)sizeof(long),
                      smr.ser, smr.len) < 0) {
-               lprintf(2, "Can't store message\n");
+               lprintf(CTDL_ERR, "Can't store message\n");
                retval = 0L;
        } else {
+               if (is_bigmsg) {
+                       cdb_store(CDB_BIGMSGS,
+                               &newmsgid,
+                               (int)sizeof(long),
+                               holdM,
+                               (strlen(holdM) + 1)
+                       );
+               }
                retval = newmsgid;
        }
 
-       /* If the caller specified that a copy should be saved to a particular
-        * file handle, do that now too.
-        */
-       if (save_a_copy != NULL) {
-               fwrite(smr.ser, smr.len, 1, save_a_copy);
-       }
-
        /* Free the memory we used for the serialized message */
-        phree(smr.ser);
+        free(smr.ser);
 
        /* Return the *local* message ID to the caller
         * (even if we're storing an incoming network message)
@@ -1774,8 +1821,8 @@ void serialize_message(struct ser_ret *ret,               /* return values */
                ret->len = ret->len +
                        strlen(msg->cm_fields[(int)forder[i]]) + 2;
 
-       lprintf(9, "serialize_message() calling malloc(%ld)\n", (long)ret->len);
-       ret->ser = mallok(ret->len);
+       lprintf(CTDL_DEBUG, "serialize_message() calling malloc(%ld)\n", (long)ret->len);
+       ret->ser = malloc(ret->len);
        if (ret->ser == NULL) {
                ret->len = 0;
                return;
@@ -1788,10 +1835,10 @@ void serialize_message(struct ser_ret *ret,             /* return values */
 
        for (i=0; i<26; ++i) if (msg->cm_fields[(int)forder[i]] != NULL) {
                ret->ser[wlen++] = (char)forder[i];
-               strcpy(&ret->ser[wlen], msg->cm_fields[(int)forder[i]]);
+               strcpy((char *)&ret->ser[wlen], msg->cm_fields[(int)forder[i]]);
                wlen = wlen + strlen(msg->cm_fields[(int)forder[i]]) + 1;
        }
-       if (ret->len != wlen) lprintf(3, "ERROR: len=%ld wlen=%ld\n",
+       if (ret->len != wlen) lprintf(CTDL_ERR, "ERROR: len=%ld wlen=%ld\n",
                (long)ret->len, (long)wlen);
 
        return;
@@ -1806,8 +1853,8 @@ void check_repl(long msgnum, void *userdata) {
        struct CtdlMessage *msg;
        time_t timestamp = (-1L);
 
-       lprintf(9, "check_repl() found message %ld\n", msgnum);
-       msg = CtdlFetchMessage(msgnum);
+       lprintf(CTDL_DEBUG, "check_repl() found message %ld\n", msgnum);
+       msg = CtdlFetchMessage(msgnum, 1);
        if (msg == NULL) return;
        if (msg->cm_fields['T'] != NULL) {
                timestamp = atol(msg->cm_fields['T']);
@@ -1816,18 +1863,18 @@ void check_repl(long msgnum, void *userdata) {
 
        if (timestamp > msg_repl->highest) {
                msg_repl->highest = timestamp;  /* newer! */
-               lprintf(9, "newer!\n");
+               lprintf(CTDL_DEBUG, "newer!\n");
                return;
        }
-       lprintf(9, "older!\n");
+       lprintf(CTDL_DEBUG, "older!\n");
 
        /* Existing isn't newer?  Then delete the old one(s). */
-       CtdlDeleteMessages(CC->quickroom.QRname, msgnum, "");
+       CtdlDeleteMessages(CC->room.QRname, msgnum, "");
 }
 
 
 /*
- * Check to see if any messages already exist which carry the same Extended ID
+ * Check to see if any messages already exist which carry the same Exclusive ID
  * as this one.  
  *
  * If any are found:
@@ -1838,23 +1885,23 @@ int ReplicationChecks(struct CtdlMessage *msg) {
        struct CtdlMessage *template;
        int abort_this = 0;
 
-       lprintf(9, "ReplicationChecks() started\n");
-       /* No extended id?  Don't do anything. */
+       lprintf(CTDL_DEBUG, "ReplicationChecks() started\n");
+       /* No exclusive id?  Don't do anything. */
        if (msg->cm_fields['E'] == NULL) return 0;
        if (strlen(msg->cm_fields['E']) == 0) return 0;
-       lprintf(9, "Extended ID: <%s>\n", msg->cm_fields['E']);
+       lprintf(CTDL_DEBUG, "Exclusive ID: <%s>\n", msg->cm_fields['E']);
 
        CtdlAllocUserData(SYM_REPL, sizeof(struct repl));
-       strcpy(msg_repl->extended_id, msg->cm_fields['E']);
+       strcpy(msg_repl->exclusive_id, msg->cm_fields['E']);
        msg_repl->highest = atol(msg->cm_fields['T']);
 
        template = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
        memset(template, 0, sizeof(struct CtdlMessage));
-       template->cm_fields['E'] = strdoop(msg->cm_fields['E']);
+       template->cm_fields['E'] = strdup(msg->cm_fields['E']);
 
        CtdlForEachMessage(MSGS_ALL, 0L, NULL, template, check_repl, NULL);
 
-       /* If a newer message exists with the same Extended ID, abort
+       /* If a newer message exists with the same Exclusive ID, abort
         * this save.
         */
        if (msg_repl->highest > atol(msg->cm_fields['T']) ) {
@@ -1862,7 +1909,7 @@ int ReplicationChecks(struct CtdlMessage *msg) {
                }
 
        CtdlFreeMessage(template);
-       lprintf(9, "ReplicationChecks() returning %d\n", abort_this);
+       lprintf(CTDL_DEBUG, "ReplicationChecks() returning %d\n", abort_this);
        return(abort_this);
 }
 
@@ -1884,7 +1931,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        char recipient[SIZ];
        long newmsgid;
        char *mptr = NULL;
-       struct usersupp userbuf;
+       struct ctdluser userbuf;
        int a, i;
        struct MetaData smi;
        FILE *network_fp = NULL;
@@ -1894,24 +1941,24 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
        struct ser_ret smr;
        char *hold_R, *hold_D;
 
-       lprintf(9, "CtdlSubmitMsg() called\n");
+       lprintf(CTDL_DEBUG, "CtdlSubmitMsg() called\n");
        if (is_valid_message(msg) == 0) return(-1);     /* self check */
 
        /* If this message has no timestamp, we take the liberty of
         * giving it one, right now.
         */
        if (msg->cm_fields['T'] == NULL) {
-               lprintf(9, "Generating timestamp\n");
+               lprintf(CTDL_DEBUG, "Generating timestamp\n");
                snprintf(aaa, sizeof aaa, "%ld", (long)time(NULL));
-               msg->cm_fields['T'] = strdoop(aaa);
+               msg->cm_fields['T'] = strdup(aaa);
        }
 
        /* If this message has no path, we generate one.
         */
        if (msg->cm_fields['P'] == NULL) {
-               lprintf(9, "Generating path\n");
+               lprintf(CTDL_DEBUG, "Generating path\n");
                if (msg->cm_fields['A'] != NULL) {
-                       msg->cm_fields['P'] = strdoop(msg->cm_fields['A']);
+                       msg->cm_fields['P'] = strdup(msg->cm_fields['A']);
                        for (a=0; a<strlen(msg->cm_fields['P']); ++a) {
                                if (isspace(msg->cm_fields['P'][a])) {
                                        msg->cm_fields['P'][a] = ' ';
@@ -1919,7 +1966,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                        }
                }
                else {
-                       msg->cm_fields['P'] = strdoop("unknown");
+                       msg->cm_fields['P'] = strdup("unknown");
                }
        }
 
@@ -1931,9 +1978,10 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,      /* message to save */
        }
 
        /* Learn about what's inside, because it's what's inside that counts */
-       lprintf(9, "Learning what's inside\n");
+       lprintf(CTDL_DEBUG, "Learning what's inside\n");
        if (msg->cm_fields['M'] == NULL) {
-               lprintf(1, "ERROR: attempt to save message with NULL body\n");
+               lprintf(CTDL_ERR, "ERROR: attempt to save message with NULL body\n");
+               return(-1);
        }
 
        switch (msg->cm_format_type) {
@@ -1966,17 +2014,18 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
        }
 
        /* Goto the correct room */
-       lprintf(9, "Switching rooms\n");
-       strcpy(hold_rm, CC->quickroom.QRname);
-       strcpy(actual_rm, CC->quickroom.QRname);
+       lprintf(CTDL_DEBUG, "Selected room %s\n", (recps) ? CC->room.QRname : SENTITEMS);
+       strcpy(hold_rm, CC->room.QRname);
+       strcpy(actual_rm, CC->room.QRname);
        if (recps != NULL) {
                strcpy(actual_rm, SENTITEMS);
        }
 
        /* If the user is a twit, move to the twit room for posting */
-       lprintf(9, "Handling twit stuff\n");
+       lprintf(CTDL_DEBUG, "Handling twit stuff: %s\n",
+                       (CC->user.axlevel == 2) ? config.c_twitroom : "OK");
        if (TWITDETECT) {
-               if (CC->usersupp.axlevel == 2) {
+               if (CC->user.axlevel == 2) {
                        strcpy(hold_rm, actual_rm);
                        strcpy(actual_rm, config.c_twitroom);
                }
@@ -1987,44 +2036,44 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                strcpy(actual_rm, force_room);
        }
 
-       lprintf(9, "Possibly relocating\n");
-       if (strcasecmp(actual_rm, CC->quickroom.QRname)) {
-               getroom(&CC->quickroom, actual_rm);
+       lprintf(CTDL_DEBUG, "Final selection: %s\n", actual_rm);
+       if (strcasecmp(actual_rm, CC->room.QRname)) {
+               getroom(&CC->room, actual_rm);
        }
 
        /*
         * If this message has no O (room) field, generate one.
         */
        if (msg->cm_fields['O'] == NULL) {
-               msg->cm_fields['O'] = strdoop(CC->quickroom.QRname);
+               msg->cm_fields['O'] = strdup(CC->room.QRname);
        }
 
        /* Perform "before save" hooks (aborting if any return nonzero) */
-       lprintf(9, "Performing before-save hooks\n");
+       lprintf(CTDL_DEBUG, "Performing before-save hooks\n");
        if (PerformMessageHooks(msg, EVT_BEFORESAVE) > 0) return(-1);
 
-       /* If this message has an Extended ID, perform replication checks */
-       lprintf(9, "Performing replication checks\n");
+       /* If this message has an Exclusive ID, perform replication checks */
+       lprintf(CTDL_DEBUG, "Performing replication checks\n");
        if (ReplicationChecks(msg) > 0) return(-1);
 
        /* Save it to disk */
-       lprintf(9, "Saving to disk\n");
-       newmsgid = send_message(msg, NULL);
+       lprintf(CTDL_DEBUG, "Saving to disk\n");
+       newmsgid = send_message(msg);
        if (newmsgid <= 0L) return(-1);
 
        /* Write a supplemental message info record.  This doesn't have to
         * be a critical section because nobody else knows about this message
         * yet.
         */
-       lprintf(9, "Creating MetaData record\n");
+       lprintf(CTDL_DEBUG, "Creating MetaData record\n");
        memset(&smi, 0, sizeof(struct MetaData));
        smi.meta_msgnum = newmsgid;
        smi.meta_refcount = 0;
-       safestrncpy(smi.meta_content_type, content_type, 64);
+       safestrncpy(smi.meta_content_type, content_type, sizeof smi.meta_content_type);
        PutMetaData(&smi);
 
        /* Now figure out where to store the pointers */
-       lprintf(9, "Storing pointers\n");
+       lprintf(CTDL_DEBUG, "Storing pointers\n");
 
        /* If this is being done by the networker delivering a private
         * message, we want to BYPASS saving the sender's copy (because there
@@ -2032,7 +2081,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
         */
        if ((!CC->internal_pgm) || (recps == NULL)) {
                if (CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0) != 0) {
-                       lprintf(3, "ERROR saving message pointer!\n");
+                       lprintf(CTDL_ERR, "ERROR saving message pointer!\n");
                        CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0);
                }
        }
@@ -2048,15 +2097,15 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
         if (recps->num_room > 0)
          for (i=0; i<num_tokens(recps->recp_room, '|'); ++i) {
                extract(recipient, recps->recp_room, i);
-               lprintf(9, "Delivering to local room <%s>\n", recipient);
+               lprintf(CTDL_DEBUG, "Delivering to local room <%s>\n", recipient);
                CtdlSaveMsgPointerInRoom(recipient, newmsgid, 0);
        }
 
        /* Bump this user's messages posted counter. */
-       lprintf(9, "Updating user\n");
-       lgetuser(&CC->usersupp, CC->curr_user);
-       CC->usersupp.posted = CC->usersupp.posted + 1;
-       lputuser(&CC->usersupp);
+       lprintf(CTDL_DEBUG, "Updating user\n");
+       lgetuser(&CC->user, CC->curr_user);
+       CC->user.posted = CC->user.posted + 1;
+       lputuser(&CC->user);
 
        /* If this is private, local mail, make a copy in the
         * recipient's mailbox and bump the reference count.
@@ -2065,7 +2114,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
         if (recps->num_local > 0)
          for (i=0; i<num_tokens(recps->recp_local, '|'); ++i) {
                extract(recipient, recps->recp_local, i);
-               lprintf(9, "Delivering private local mail to <%s>\n",
+               lprintf(CTDL_DEBUG, "Delivering private local mail to <%s>\n",
                        recipient);
                if (getuser(&userbuf, recipient) == 0) {
                        MailboxName(actual_rm, sizeof actual_rm, &userbuf, MAILROOM);
@@ -2073,13 +2122,13 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                        BumpNewMailCounter(userbuf.usernum);
                }
                else {
-                       lprintf(9, "No user <%s>\n", recipient);
+                       lprintf(CTDL_DEBUG, "No user <%s>\n", recipient);
                        CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0);
                }
        }
 
        /* Perform "after save" hooks */
-       lprintf(9, "Performing after-save hooks\n");
+       lprintf(CTDL_DEBUG, "Performing after-save hooks\n");
        PerformMessageHooks(msg, EVT_AFTERSAVE);
 
        /* For IGnet mail, we have to save a new copy into the spooler for
@@ -2097,8 +2146,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
 
                hold_R = msg->cm_fields['R'];
                hold_D = msg->cm_fields['D'];
-               msg->cm_fields['R'] = mallok(SIZ);
-               msg->cm_fields['D'] = mallok(SIZ);
+               msg->cm_fields['R'] = malloc(SIZ);
+               msg->cm_fields['D'] = malloc(SIZ);
                extract_token(msg->cm_fields['R'], recipient, 0, '@');
                extract_token(msg->cm_fields['D'], recipient, 1, '@');
                
@@ -2112,19 +2161,19 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                                fwrite(smr.ser, smr.len, 1, network_fp);
                                fclose(network_fp);
                        }
-                       phree(smr.ser);
+                       free(smr.ser);
                }
 
-               phree(msg->cm_fields['R']);
-               phree(msg->cm_fields['D']);
+               free(msg->cm_fields['R']);
+               free(msg->cm_fields['D']);
                msg->cm_fields['R'] = hold_R;
                msg->cm_fields['D'] = hold_D;
        }
 
        /* Go back to the room we started from */
-       lprintf(9, "Returning to original room\n");
-       if (strcasecmp(hold_rm, CC->quickroom.QRname))
-               getroom(&CC->quickroom, hold_rm);
+       lprintf(CTDL_DEBUG, "Returning to original room %s\n", hold_rm);
+       if (strcasecmp(hold_rm, CC->room.QRname))
+               getroom(&CC->room, hold_rm);
 
        /* For internet mail, generate delivery instructions.
         * Yes, this is recursive.  Deal with it.  Infinite recursion does
@@ -2133,8 +2182,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
         */
        if (recps != NULL)
         if (recps->num_internet > 0) {
-               lprintf(9, "Generating delivery instructions\n");
-               instr = mallok(SIZ * 2);
+               lprintf(CTDL_DEBUG, "Generating delivery instructions\n");
+               instr = malloc(SIZ * 2);
                snprintf(instr, SIZ * 2,
                        "Content-type: %s\n\nmsgid|%ld\nsubmitted|%ld\n"
                        "bounceto|%s@%s\n",
@@ -2149,12 +2198,12 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                                 "remote|%s|0||\n", recipient);
                }
 
-               imsg = mallok(sizeof(struct CtdlMessage));
+               imsg = malloc(sizeof(struct CtdlMessage));
                memset(imsg, 0, sizeof(struct CtdlMessage));
                imsg->cm_magic = CTDLMESSAGE_MAGIC;
                imsg->cm_anon_type = MES_NORMAL;
                imsg->cm_format_type = FMT_RFC822;
-               imsg->cm_fields['A'] = strdoop("Citadel");
+               imsg->cm_fields['A'] = strdup("Citadel");
                imsg->cm_fields['M'] = instr;
                CtdlSubmitMsg(imsg, NULL, SMTP_SPOOLOUT_ROOM);
                CtdlFreeMessage(imsg);
@@ -2174,26 +2223,26 @@ void quickie_message(char *from, char *to, char *room, char *text,
        struct CtdlMessage *msg;
        struct recptypes *recp = NULL;
 
-       msg = mallok(sizeof(struct CtdlMessage));
+       msg = malloc(sizeof(struct CtdlMessage));
        memset(msg, 0, sizeof(struct CtdlMessage));
        msg->cm_magic = CTDLMESSAGE_MAGIC;
        msg->cm_anon_type = MES_NORMAL;
        msg->cm_format_type = format_type;
-       msg->cm_fields['A'] = strdoop(from);
-       if (room != NULL) msg->cm_fields['O'] = strdoop(room);
-       msg->cm_fields['N'] = strdoop(NODENAME);
+       msg->cm_fields['A'] = strdup(from);
+       if (room != NULL) msg->cm_fields['O'] = strdup(room);
+       msg->cm_fields['N'] = strdup(NODENAME);
        if (to != NULL) {
-               msg->cm_fields['R'] = strdoop(to);
+               msg->cm_fields['R'] = strdup(to);
                recp = validate_recipients(to);
        }
        if (subject != NULL) {
-               msg->cm_fields['U'] = strdoop(subject);
+               msg->cm_fields['U'] = strdup(subject);
        }
-       msg->cm_fields['M'] = strdoop(text);
+       msg->cm_fields['M'] = strdup(text);
 
        CtdlSubmitMsg(msg, recp, room);
        CtdlFreeMessage(msg);
-       if (recp != NULL) phree(recp);
+       if (recp != NULL) free(recp);
 }
 
 
@@ -2217,7 +2266,7 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
        int finished = 0;
 
        if (exist == NULL) {
-               m = mallok(4096);
+               m = malloc(4096);
                m[0] = 0;
                buffer_len = 4096;
                message_len = 0;
@@ -2225,9 +2274,9 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
        else {
                message_len = strlen(exist);
                buffer_len = message_len + 4096;
-               m = reallok(exist, buffer_len);
+               m = realloc(exist, buffer_len);
                if (m == NULL) {
-                       phree(exist);
+                       free(exist);
                        return m;
                }
        }
@@ -2254,13 +2303,13 @@ char *CtdlReadMessageBody(char *terminator,     /* token signalling EOT */
        
                        /* augment the buffer if we have to */
                        if ((message_len + linelen) >= buffer_len) {
-                               ptr = reallok(m, (buffer_len * 2) );
+                               ptr = realloc(m, (buffer_len * 2) );
                                if (ptr == NULL) {      /* flush if can't allocate */
                                        flushing = 1;
                                } else {
                                        buffer_len = (buffer_len * 2);
                                        m = ptr;
-                                       lprintf(9, "buffer_len is now %ld\n", (long)buffer_len);
+                                       lprintf(CTDL_DEBUG, "buffer_len is now %ld\n", (long)buffer_len);
                                }
                        }
        
@@ -2292,7 +2341,7 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
  */
 
 struct CtdlMessage *CtdlMakeMessage(
-       struct usersupp *author,        /* author's usersupp structure */
+       struct ctdluser *author,        /* author's user structure */
        char *recipient,                /* NULL if it's not mail */
        char *room,                     /* room where it's going */
        int type,                       /* see MES_ types in header file */
@@ -2305,7 +2354,7 @@ struct CtdlMessage *CtdlMakeMessage(
        char buf[SIZ];
        struct CtdlMessage *msg;
 
-       msg = mallok(sizeof(struct CtdlMessage));
+       msg = malloc(sizeof(struct CtdlMessage));
        memset(msg, 0, sizeof(struct CtdlMessage));
        msg->cm_magic = CTDLMESSAGE_MAGIC;
        msg->cm_anon_type = type;
@@ -2317,41 +2366,41 @@ struct CtdlMessage *CtdlMakeMessage(
        striplt(recipient);
 
        snprintf(buf, sizeof buf, "cit%ld", author->usernum);   /* Path */
-       msg->cm_fields['P'] = strdoop(buf);
+       msg->cm_fields['P'] = strdup(buf);
 
        snprintf(buf, sizeof buf, "%ld", (long)time(NULL));     /* timestamp */
-       msg->cm_fields['T'] = strdoop(buf);
+       msg->cm_fields['T'] = strdup(buf);
 
        if (fake_name[0])                                       /* author */
-               msg->cm_fields['A'] = strdoop(fake_name);
+               msg->cm_fields['A'] = strdup(fake_name);
        else
-               msg->cm_fields['A'] = strdoop(author->fullname);
+               msg->cm_fields['A'] = strdup(author->fullname);
 
-       if (CC->quickroom.QRflags & QR_MAILBOX) {               /* room */
-               msg->cm_fields['O'] = strdoop(&CC->quickroom.QRname[11]);
+       if (CC->room.QRflags & QR_MAILBOX) {            /* room */
+               msg->cm_fields['O'] = strdup(&CC->room.QRname[11]);
        }
        else {
-               msg->cm_fields['O'] = strdoop(CC->quickroom.QRname);
+               msg->cm_fields['O'] = strdup(CC->room.QRname);
        }
 
-       msg->cm_fields['N'] = strdoop(NODENAME);                /* nodename */
-       msg->cm_fields['H'] = strdoop(HUMANNODE);               /* hnodename */
+       msg->cm_fields['N'] = strdup(NODENAME);         /* nodename */
+       msg->cm_fields['H'] = strdup(HUMANNODE);                /* hnodename */
 
        if (recipient[0] != 0) {
-               msg->cm_fields['R'] = strdoop(recipient);
+               msg->cm_fields['R'] = strdup(recipient);
        }
        if (dest_node[0] != 0) {
-               msg->cm_fields['D'] = strdoop(dest_node);
+               msg->cm_fields['D'] = strdup(dest_node);
        }
 
-       if ( (author == &CC->usersupp) && (strlen(CC->cs_inet_email) > 0) ) {
-               msg->cm_fields['F'] = strdoop(CC->cs_inet_email);
+       if ( (author == &CC->user) && (strlen(CC->cs_inet_email) > 0) ) {
+               msg->cm_fields['F'] = strdup(CC->cs_inet_email);
        }
 
        if (subject != NULL) {
                striplt(subject);
                if (strlen(subject) > 0) {
-                       msg->cm_fields['U'] = strdoop(subject);
+                       msg->cm_fields['U'] = strdup(subject);
                }
        }
 
@@ -2379,21 +2428,21 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, size_t n) {
                return (ERROR + NOT_LOGGED_IN);
        }
 
-       if ((CC->usersupp.axlevel < 2)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)) {
+       if ((CC->user.axlevel < 2)
+           && ((CC->room.QRflags & QR_MAILBOX) == 0)) {
                snprintf(errmsgbuf, n, "Need to be validated to enter "
                                "(except in %s> to sysop)", MAILROOM);
                return (ERROR + HIGHER_ACCESS_REQUIRED);
        }
 
-       if ((CC->usersupp.axlevel < 4)
-          && (CC->quickroom.QRflags & QR_NETWORK)) {
+       if ((CC->user.axlevel < 4)
+          && (CC->room.QRflags & QR_NETWORK)) {
                snprintf(errmsgbuf, n, "Need net privileges to enter here.");
                return (ERROR + HIGHER_ACCESS_REQUIRED);
        }
 
-       if ((CC->usersupp.axlevel < 6)
-          && (CC->quickroom.QRflags & QR_READONLY)) {
+       if ((CC->user.axlevel < 6)
+          && (CC->room.QRflags & QR_READONLY)) {
                snprintf(errmsgbuf, n, "Sorry, this is a read-only room.");
                return (ERROR + HIGHER_ACCESS_REQUIRED);
        }
@@ -2407,7 +2456,10 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, size_t n) {
  * Check to see if the specified user has Internet mail permission
  * (returns nonzero if permission is granted)
  */
-int CtdlCheckInternetMailPermission(struct usersupp *who) {
+int CtdlCheckInternetMailPermission(struct ctdluser *who) {
+
+       /* Do not allow twits to send Internet mail */
+       if (who->axlevel <= 2) return(0);
 
        /* Globally enabled? */
        if (config.c_restrict == 0) return(1);
@@ -2437,8 +2489,8 @@ struct recptypes *validate_recipients(char *recipients) {
        int i, j;
        int mailtype;
        int invalid;
-       struct usersupp tempUS;
-       struct quickroom tempQR;
+       struct ctdluser tempUS;
+       struct ctdlroom tempQR;
 
        /* Initialize */
        ret = (struct recptypes *) malloc(sizeof(struct recptypes));
@@ -2472,7 +2524,7 @@ struct recptypes *validate_recipients(char *recipients) {
        if (num_recps > 0) for (i=0; i<num_recps; ++i) {
                extract_token(this_recp, recipients, i, ',');
                striplt(this_recp);
-               lprintf(9, "Evaluating recipient #%d <%s>\n", i, this_recp);
+               lprintf(CTDL_DEBUG, "Evaluating recipient #%d <%s>\n", i, this_recp);
                mailtype = alias(this_recp);
                mailtype = alias(this_recp);
                mailtype = alias(this_recp);
@@ -2525,11 +2577,23 @@ struct recptypes *validate_recipients(char *recipients) {
                                }
                                break;
                        case MES_INTERNET:
-                               ++ret->num_internet;
-                               if (strlen(ret->recp_internet) > 0) {
-                                       strcat(ret->recp_internet, "|");
+                               /* Yes, you're reading this correctly: if the target
+                                * domain points back to the local system or an attached
+                                * Citadel directory, the address is invalid.  That's
+                                * because if the address were valid, we would have
+                                * already translated it to a local address by now.
+                                */
+                               if (IsDirectory(this_recp)) {
+                                       ++ret->num_error;
+                                       invalid = 1;
+                               }
+                               else {
+                                       ++ret->num_internet;
+                                       if (strlen(ret->recp_internet) > 0) {
+                                               strcat(ret->recp_internet, "|");
+                                       }
+                                       strcat(ret->recp_internet, this_recp);
                                }
-                               strcat(ret->recp_internet, this_recp);
                                break;
                        case MES_IGNET:
                                ++ret->num_ignet;
@@ -2577,12 +2641,12 @@ struct recptypes *validate_recipients(char *recipients) {
                strcpy(ret->errormsg, "No recipients specified.");
        }
 
-       lprintf(9, "validate_recipients()\n");
-       lprintf(9, " local: %d <%s>\n", ret->num_local, ret->recp_local);
-       lprintf(9, "  room: %d <%s>\n", ret->num_room, ret->recp_room);
-       lprintf(9, "  inet: %d <%s>\n", ret->num_internet, ret->recp_internet);
-       lprintf(9, " ignet: %d <%s>\n", ret->num_ignet, ret->recp_ignet);
-       lprintf(9, " error: %d <%s>\n", ret->num_error, ret->errormsg);
+       lprintf(CTDL_DEBUG, "validate_recipients()\n");
+       lprintf(CTDL_DEBUG, " local: %d <%s>\n", ret->num_local, ret->recp_local);
+       lprintf(CTDL_DEBUG, "  room: %d <%s>\n", ret->num_room, ret->recp_room);
+       lprintf(CTDL_DEBUG, "  inet: %d <%s>\n", ret->num_internet, ret->recp_internet);
+       lprintf(CTDL_DEBUG, " ignet: %d <%s>\n", ret->num_ignet, ret->recp_ignet);
+       lprintf(CTDL_DEBUG, " error: %d <%s>\n", ret->num_error, ret->errormsg);
 
        return(ret);
 }
@@ -2607,6 +2671,8 @@ void cmd_ent0(char *entargs)
        struct recptypes *valid = NULL;
        char subject[SIZ];
 
+       unbuffer_output();
+
        post = extract_int(entargs, 0);
        extract(recp, entargs, 1);
        anon_flag = extract_int(entargs, 2);
@@ -2624,7 +2690,7 @@ void cmd_ent0(char *entargs)
        /* Check some other permission type things. */
 
        if (post == 2) {
-               if (CC->usersupp.axlevel < 6) {
+               if (CC->user.axlevel < 6) {
                        cprintf("%d You don't have permission to masquerade.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
                        return;
@@ -2642,10 +2708,10 @@ void cmd_ent0(char *entargs)
         * make sure the user has specified at least one recipient.  Then
         * validate the recipient(s).
         */
-       if ( (CC->quickroom.QRflags & QR_MAILBOX)
-          && (!strcasecmp(&CC->quickroom.QRname[11], MAILROOM)) ) {
+       if ( (CC->room.QRflags & QR_MAILBOX)
+          && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) ) {
 
-               if (CC->usersupp.axlevel < 2) {
+               if (CC->user.axlevel < 2) {
                        strcpy(recp, "sysop");
                }
 
@@ -2653,33 +2719,33 @@ void cmd_ent0(char *entargs)
                if (valid->num_error > 0) {
                        cprintf("%d %s\n",
                                ERROR + NO_SUCH_USER, valid->errormsg);
-                       phree(valid);
+                       free(valid);
                        return;
                }
                if (valid->num_internet > 0) {
-                       if (CtdlCheckInternetMailPermission(&CC->usersupp)==0) {
+                       if (CtdlCheckInternetMailPermission(&CC->user)==0) {
                                cprintf("%d You do not have permission "
                                        "to send Internet mail.\n",
                                        ERROR + HIGHER_ACCESS_REQUIRED);
-                               phree(valid);
+                               free(valid);
                                return;
                        }
                }
 
                if ( ( (valid->num_internet + valid->num_ignet) > 0)
-                  && (CC->usersupp.axlevel < 4) ) {
+                  && (CC->user.axlevel < 4) ) {
                        cprintf("%d Higher access required for network mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       phree(valid);
+                       free(valid);
                        return;
                }
        
                if ((RESTRICT_INTERNET == 1) && (valid->num_internet > 0)
-                   && ((CC->usersupp.flags & US_INTERNET) == 0)
+                   && ((CC->user.flags & US_INTERNET) == 0)
                    && (!CC->internal_pgm)) {
                        cprintf("%d You don't have access to Internet mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       phree(valid);
+                       free(valid);
                        return;
                }
 
@@ -2687,16 +2753,16 @@ void cmd_ent0(char *entargs)
 
        /* Is this a room which has anonymous-only or anonymous-option? */
        anonymous = MES_NORMAL;
-       if (CC->quickroom.QRflags & QR_ANONONLY) {
+       if (CC->room.QRflags & QR_ANONONLY) {
                anonymous = MES_ANONONLY;
        }
-       if (CC->quickroom.QRflags & QR_ANONOPT) {
+       if (CC->room.QRflags & QR_ANONOPT) {
                if (anon_flag == 1) {   /* only if the user requested it */
                        anonymous = MES_ANONOPT;
                }
        }
 
-       if ((CC->quickroom.QRflags & QR_MAILBOX) == 0) {
+       if ((CC->room.QRflags & QR_MAILBOX) == 0) {
                recp[0] = 0;
        }
 
@@ -2706,7 +2772,7 @@ void cmd_ent0(char *entargs)
        if (post == 0) {
                cprintf("%d %s\n", CIT_OK,
                        ((valid != NULL) ? valid->display_recp : "") );
-               phree(valid);
+               free(valid);
                return;
        }
 
@@ -2723,8 +2789,8 @@ void cmd_ent0(char *entargs)
 
        /* Read in the message from the client. */
        cprintf("%d send message\n", SEND_LISTING);
-       msg = CtdlMakeMessage(&CC->usersupp, recp,
-               CC->quickroom.QRname, anonymous, format_type,
+       msg = CtdlMakeMessage(&CC->user, recp,
+               CC->room.QRname, anonymous, format_type,
                masquerade_as, subject, NULL);
 
        if (msg != NULL) {
@@ -2732,7 +2798,7 @@ void cmd_ent0(char *entargs)
                CtdlFreeMessage(msg);
        }
        CC->fake_postname[0] = '\0';
-       phree(valid);
+       free(valid);
        return;
 }
 
@@ -2748,7 +2814,7 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
 )
 {
 
-       struct quickroom qrbuf;
+       struct ctdlroom qrbuf;
        struct cdbdata *cdbfr;
        long *msglist = NULL;
        long *dellist = NULL;
@@ -2758,20 +2824,20 @@ int CtdlDeleteMessages(char *room_name,         /* which room */
        int delete_this;
        struct MetaData smi;
 
-       lprintf(9, "CtdlDeleteMessages(%s, %ld, %s)\n",
+       lprintf(CTDL_DEBUG, "CtdlDeleteMessages(%s, %ld, %s)\n",
                room_name, dmsgnum, content_type);
 
        /* get room record, obtaining a lock... */
        if (lgetroom(&qrbuf, room_name) != 0) {
-               lprintf(7, "CtdlDeleteMessages(): Room <%s> not found\n",
+               lprintf(CTDL_ERR, "CtdlDeleteMessages(): Room <%s> not found\n",
                        room_name);
                return (0);     /* room not found */
        }
        cdbfr = cdb_fetch(CDB_MSGLISTS, &qrbuf.QRnumber, sizeof(long));
 
        if (cdbfr != NULL) {
-               msglist = mallok(cdbfr->len);
-               dellist = mallok(cdbfr->len);
+               msglist = malloc(cdbfr->len);
+               dellist = malloc(cdbfr->len);
                memcpy(msglist, cdbfr->ptr, cdbfr->len);
                num_msgs = cdbfr->len / sizeof(long);
                cdb_free(cdbfr);
@@ -2803,8 +2869,8 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
                }
 
                num_msgs = sort_msglist(msglist, num_msgs);
-               cdb_store(CDB_MSGLISTS, &qrbuf.QRnumber, sizeof(long),
-                         msglist, (num_msgs * sizeof(long)));
+               cdb_store(CDB_MSGLISTS, &qrbuf.QRnumber, (int)sizeof(long),
+                         msglist, (int)(num_msgs * sizeof(long)));
 
                qrbuf.QRhighest = msglist[num_msgs - 1];
        }
@@ -2815,7 +2881,7 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
         * was in, the reference count will reach zero and the message will
         * automatically be deleted from the database.  We do this in a
         * separate pass because there might be plug-in hooks getting called,
-        * and we don't want that happening during an S_QUICKROOM critical
+        * and we don't want that happening during an S_ROOMS critical
         * section.
         */
        if (num_deleted) for (i=0; i<num_deleted; ++i) {
@@ -2824,9 +2890,9 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
        }
 
        /* Now free the memory we used, and go away. */
-       if (msglist != NULL) phree(msglist);
-       if (dellist != NULL) phree(dellist);
-       lprintf(9, "%d message(s) deleted.\n", num_deleted);
+       if (msglist != NULL) free(msglist);
+       if (dellist != NULL) free(dellist);
+       lprintf(CTDL_DEBUG, "%d message(s) deleted.\n", num_deleted);
        return (num_deleted);
 }
 
@@ -2837,10 +2903,10 @@ int CtdlDeleteMessages(char *room_name,         /* which room */
  * the current room (returns 1 for yes, 0 for no)
  */
 int CtdlDoIHavePermissionToDeleteMessagesFromThisRoom(void) {
-       getuser(&CC->usersupp, CC->curr_user);
-       if ((CC->usersupp.axlevel < 6)
-           && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           && ((CC->quickroom.QRflags & QR_MAILBOX) == 0)
+       getuser(&CC->user, CC->curr_user);
+       if ((CC->user.axlevel < 6)
+           && (CC->user.usernum != CC->room.QRroomaide)
+           && ((CC->room.QRflags & QR_MAILBOX) == 0)
            && (!(CC->internal_pgm))) {
                return(0);
        }
@@ -2864,13 +2930,13 @@ void cmd_dele(char *delstr)
        }
        delnum = extract_long(delstr, 0);
 
-       num_deleted = CtdlDeleteMessages(CC->quickroom.QRname, delnum, "");
+       num_deleted = CtdlDeleteMessages(CC->room.QRname, delnum, "");
 
        if (num_deleted) {
                cprintf("%d %d message%s deleted.\n", CIT_OK,
                        num_deleted, ((num_deleted != 1) ? "s" : ""));
        } else {
-               cprintf("%d Message %ld not found.\n", ERROR, delnum);
+               cprintf("%d Message %ld not found.\n", ERROR + MESSAGE_NOT_FOUND, delnum);
        }
 }
 
@@ -2897,9 +2963,11 @@ void cmd_move(char *args)
 {
        long num;
        char targ[SIZ];
-       struct quickroom qtemp;
+       struct ctdlroom qtemp;
        int err;
        int is_copy = 0;
+       int ra;
+       int permit = 0;
 
        num = extract_long(args, 0);
        extract(targ, args, 1);
@@ -2907,21 +2975,38 @@ void cmd_move(char *args)
        is_copy = extract_int(args, 2);
 
        if (getroom(&qtemp, targ) != 0) {
-               cprintf("%d '%s' does not exist.\n", ERROR, targ);
+               cprintf("%d '%s' does not exist.\n",
+                       ERROR + ROOM_NOT_FOUND, targ);
                return;
        }
 
-       getuser(&CC->usersupp, CC->curr_user);
+       getuser(&CC->user, CC->curr_user);
+       ra = CtdlRoomAccess(&qtemp, &CC->user);
+
+       /* Check for permission to perform this operation.
+        * Remember: "CC->room" is source, "qtemp" is target.
+        */
+       permit = 0;
+
        /* Aides can move/copy */
-       if ((CC->usersupp.axlevel < 6)
-           /* Roomaides can move/copy */
-           && (CC->usersupp.usernum != CC->quickroom.QRroomaide)
-           /* Permit move/copy to/from personal rooms */
-           && (!((CC->quickroom.QRflags & QR_MAILBOX)
-                           && (qtemp.QRflags & QR_MAILBOX)))
-           /* Permit only copy from public to personal room */
-           && (!(is_copy && !(CC->quickroom.QRflags & QR_MAILBOX)
-                           && (qtemp.QRflags & QR_MAILBOX)))) {
+       if (CC->user.axlevel >= 6) permit = 1;
+
+       /* Room aides can move/copy */
+       if (CC->user.usernum == CC->room.QRroomaide) permit = 1;
+
+       /* Permit move/copy from personal rooms */
+       if ((CC->room.QRflags & QR_MAILBOX)
+          && (qtemp.QRflags & QR_MAILBOX)) permit = 1;
+
+       /* Permit only copy from public to personal room */
+       if ( (is_copy)
+          && (!(CC->room.QRflags & QR_MAILBOX))
+          && (qtemp.QRflags & QR_MAILBOX)) permit = 1;
+
+       /* User must have access to target room */
+       if (!(ra & UA_KNOWN))  permit = 0;
+
+       if (!permit) {
                cprintf("%d Higher access required.\n",
                        ERROR + HIGHER_ACCESS_REQUIRED);
                return;
@@ -2938,7 +3023,7 @@ void cmd_move(char *args)
         * if this is a 'move' rather than a 'copy' operation.
         */
        if (is_copy == 0) {
-               CtdlDeleteMessages(CC->quickroom.QRname, num, "");
+               CtdlDeleteMessages(CC->room.QRname, num, "");
        }
 
        cprintf("%d Message %s.\n", CIT_OK, (is_copy ? "copied" : "moved") );
@@ -2984,12 +3069,12 @@ void PutMetaData(struct MetaData *smibuf)
        /* Use the negative of the message number for the metadata db index */
        TheIndex = (0L - smibuf->meta_msgnum);
 
-       lprintf(9, "PutMetaData(%ld) - ref count is %d\n",
+       lprintf(CTDL_DEBUG, "PutMetaData(%ld) - ref count is %d\n",
                smibuf->meta_msgnum, smibuf->meta_refcount);
 
        cdb_store(CDB_MSGMAIN,
-                 &TheIndex, sizeof(long),
-                 smibuf, sizeof(struct MetaData));
+                 &TheIndex, (int)sizeof(long),
+                 smibuf, (int)sizeof(struct MetaData));
 
 }
 
@@ -3009,25 +3094,26 @@ void AdjRefCount(long msgnum, int incr)
         */
        begin_critical_section(S_SUPPMSGMAIN);
        GetMetaData(&smi, msgnum);
-       lprintf(9, "Ref count for message <%ld> before write is <%d>\n",
+       lprintf(CTDL_DEBUG, "Ref count for message <%ld> before write is <%d>\n",
                msgnum, smi.meta_refcount);
        smi.meta_refcount += incr;
        PutMetaData(&smi);
        end_critical_section(S_SUPPMSGMAIN);
-       lprintf(9, "Ref count for message <%ld> after write is <%d>\n",
+       lprintf(CTDL_DEBUG, "Ref count for message <%ld> after write is <%d>\n",
                msgnum, smi.meta_refcount);
 
        /* If the reference count is now zero, delete the message
         * (and its supplementary record as well).
         */
        if (smi.meta_refcount == 0) {
-               lprintf(9, "Deleting message <%ld>\n", msgnum);
+               lprintf(CTDL_DEBUG, "Deleting message <%ld>\n", msgnum);
                delnum = msgnum;
-               cdb_delete(CDB_MSGMAIN, &delnum, sizeof(long));
+               cdb_delete(CDB_MSGMAIN, &delnum, (int)sizeof(long));
+               cdb_delete(CDB_BIGMSGS, &delnum, (int)sizeof(long));
 
                /* We have to delete the metadata record too! */
                delnum = (0L - msgnum);
-               cdb_delete(CDB_MSGMAIN, &delnum, sizeof(long));
+               cdb_delete(CDB_MSGMAIN, &delnum, (int)sizeof(long));
        }
 }
 
@@ -3040,7 +3126,7 @@ void AdjRefCount(long msgnum, int incr)
 void CtdlWriteObject(char *req_room,           /* Room to stuff it in */
                        char *content_type,     /* MIME type of this object */
                        char *tempfilename,     /* Where to fetch it from */
-                       struct usersupp *is_mailbox,    /* Mailbox room? */
+                       struct ctdluser *is_mailbox,    /* Mailbox room? */
                        int is_binary,          /* Is encoding necessary? */
                        int is_unique,          /* Del others of this type? */
                        unsigned int flags      /* Internal save flags */
@@ -3048,7 +3134,7 @@ void CtdlWriteObject(char *req_room,              /* Room to stuff it in */
 {
 
        FILE *fp;
-       struct quickroom qrbuf;
+       struct ctdlroom qrbuf;
        char roomname[ROOMNAMELEN];
        struct CtdlMessage *msg;
 
@@ -3060,30 +3146,30 @@ void CtdlWriteObject(char *req_room,            /* Room to stuff it in */
                MailboxName(roomname, sizeof roomname, is_mailbox, req_room);
        else
                safestrncpy(roomname, req_room, sizeof(roomname));
-       lprintf(9, "CtdlWriteObject() to <%s> (flags=%d)\n", roomname, flags);
+       lprintf(CTDL_DEBUG, "CtdlWriteObject() to <%s> (flags=%d)\n", roomname, flags);
 
 
        fp = fopen(tempfilename, "rb");
        if (fp == NULL) {
-               lprintf(5, "Cannot open %s: %s\n",
+               lprintf(CTDL_CRIT, "Cannot open %s: %s\n",
                        tempfilename, strerror(errno));
                return;
        }
        fseek(fp, 0L, SEEK_END);
        raw_length = ftell(fp);
        rewind(fp);
-       lprintf(9, "Raw length is %ld\n", (long)raw_length);
+       lprintf(CTDL_DEBUG, "Raw length is %ld\n", (long)raw_length);
 
-       raw_message = mallok((size_t)raw_length);
+       raw_message = malloc((size_t)raw_length + 2);
        fread(raw_message, (size_t)raw_length, 1, fp);
        fclose(fp);
 
        if (is_binary) {
-               encoded_message = mallok((size_t)
+               encoded_message = malloc((size_t)
                        (((raw_length * 134) / 100) + 4096 ) );
        }
        else {
-               encoded_message = mallok((size_t)(raw_length + 4096));
+               encoded_message = malloc((size_t)(raw_length + 4096));
        }
 
        sprintf(encoded_message, "Content-type: %s\n", content_type);
@@ -3115,18 +3201,18 @@ void CtdlWriteObject(char *req_room,            /* Room to stuff it in */
                );
        }
 
-       phree(raw_message);
+       free(raw_message);
 
-       lprintf(9, "Allocating\n");
-       msg = mallok(sizeof(struct CtdlMessage));
+       lprintf(CTDL_DEBUG, "Allocating\n");
+       msg = malloc(sizeof(struct CtdlMessage));
        memset(msg, 0, sizeof(struct CtdlMessage));
        msg->cm_magic = CTDLMESSAGE_MAGIC;
        msg->cm_anon_type = MES_NORMAL;
        msg->cm_format_type = 4;
-       msg->cm_fields['A'] = strdoop(CC->usersupp.fullname);
-       msg->cm_fields['O'] = strdoop(req_room);
-       msg->cm_fields['N'] = strdoop(config.c_nodename);
-       msg->cm_fields['H'] = strdoop(config.c_humannode);
+       msg->cm_fields['A'] = strdup(CC->user.fullname);
+       msg->cm_fields['O'] = strdup(req_room);
+       msg->cm_fields['N'] = strdup(config.c_nodename);
+       msg->cm_fields['H'] = strdup(config.c_humannode);
        msg->cm_flags = flags;
        
        msg->cm_fields['M'] = encoded_message;
@@ -3135,13 +3221,13 @@ void CtdlWriteObject(char *req_room,            /* Room to stuff it in */
        if (getroom(&qrbuf, roomname) != 0) {
                create_room(roomname, 
                        ( (is_mailbox != NULL) ? 5 : 3 ),
-                       "", 0, 1, 0);
+                       "", 0, 1, 0, VIEW_BBS);
        }
        /* If the caller specified this object as unique, delete all
         * other objects of this type that are currently in the room.
         */
        if (is_unique) {
-               lprintf(9, "Deleted %d other msgs of this type\n",
+               lprintf(CTDL_DEBUG, "Deleted %d other msgs of this type\n",
                        CtdlDeleteMessages(roomname, 0L, content_type));
        }
        /* Now write the data */
@@ -3166,9 +3252,9 @@ char *CtdlGetSysConfig(char *sysconfname) {
        struct CtdlMessage *msg;
        char buf[SIZ];
        
-       strcpy(hold_rm, CC->quickroom.QRname);
-       if (getroom(&CC->quickroom, SYSCONFIGROOM) != 0) {
-               getroom(&CC->quickroom, hold_rm);
+       strcpy(hold_rm, CC->room.QRname);
+       if (getroom(&CC->room, SYSCONFIGROOM) != 0) {
+               getroom(&CC->room, hold_rm);
                return NULL;
        }
 
@@ -3185,9 +3271,9 @@ char *CtdlGetSysConfig(char *sysconfname) {
                conf = NULL;
        }
        else {
-               msg = CtdlFetchMessage(msgnum);
+               msg = CtdlFetchMessage(msgnum, 1);
                if (msg != NULL) {
-                       conf = strdoop(msg->cm_fields['M']);
+                       conf = strdup(msg->cm_fields['M']);
                        CtdlFreeMessage(msg);
                }
                else {
@@ -3195,7 +3281,7 @@ char *CtdlGetSysConfig(char *sysconfname) {
                }
        }
 
-       getroom(&CC->quickroom, hold_rm);
+       getroom(&CC->room, hold_rm);
 
        if (conf != NULL) do {
                extract_token(buf, conf, 0, '\n');
@@ -3233,19 +3319,19 @@ int CtdlIsMe(char *addr) {
        if (recp == NULL) return(0);
 
        if (recp->num_local == 0) {
-               phree(recp);
+               free(recp);
                return(0);
        }
 
        for (i=0; i<recp->num_local; ++i) {
                extract(addr, recp->recp_local, i);
-               if (!strcasecmp(addr, CC->usersupp.fullname)) {
-                       phree(recp);
+               if (!strcasecmp(addr, CC->user.fullname)) {
+                       free(recp);
                        return(1);
                }
        }
 
-       phree(recp);
+       free(recp);
        return(0);
 }
 
@@ -3263,7 +3349,7 @@ void cmd_isme(char *argbuf) {
                cprintf("%d %s\n", CIT_OK, addr);
        }
        else {
-               cprintf("%d Not you.\n", ERROR);
+               cprintf("%d Not you.\n", ERROR + ILLEGAL_VALUE);
        }
 
 }