CtdlRoomAccess() can now return a new value UA_REPLYALLOWED, which
[citadel.git] / citadel / msgbase.c
index 2de00fd2909475770ebbcdfb4b616487e03b04e7..a2224a8b5edcdf552afc328b344ea5629173ac0e 100644 (file)
@@ -1,23 +1,21 @@
 /*
- * $Id$
- *
  * Implements the message store.
- * 
- * Copyright (c) 1987-2009 by the citadel.org team
  *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 3 of the License, or
- *  (at your option) any later version.
+ * Copyright (c) 1987-2010 by the citadel.org team
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
  *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
 #include "sysdep.h"
@@ -309,10 +307,10 @@ void headers_euid(long msgnum, void *userdata)
                return;
        }
 
-       cprintf("%ld|%s|\n",
-               msgnum,
-               (msg->cm_fields['U'] ? msg->cm_fields['U'] : "")
-       );
+       cprintf("%ld|%s|%s\n", 
+               msgnum, 
+               (msg->cm_fields['E'] ? msg->cm_fields['E'] : ""),
+               (msg->cm_fields['T'] ? msg->cm_fields['T'] : "0"));
        CtdlFreeMessage(msg);
 }
 
@@ -356,7 +354,7 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
  * Retrieve the "seen" message list for the current room.
  */
 void CtdlGetSeen(char *buf, int which_set) {
-       struct visit vbuf;
+       visit vbuf;
 
        /* Learn about the user and room in question */
        CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
@@ -381,7 +379,7 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums,
        int was_seen = 0;
        long lo = (-1L);
        long hi = (-1L);
-       struct visit vbuf;
+       visit vbuf;
        long *msglist;
        int num_msgs = 0;
        StrBuf *vset;
@@ -607,7 +605,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string,
 {
 
        int a, i, j;
-       struct visit vbuf;
+       visit vbuf;
        struct cdbdata *cdbfr;
        long *msglist = NULL;
        int num_msgs = 0;
@@ -760,6 +758,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string,
                                       || ((mode == MSGS_LAST) && (a >= (num_msgs - ref)))
                                   || ((mode == MSGS_FIRST) && (a < ref))
                                || ((mode == MSGS_GT) && (thismsg > ref))
+                               || ((mode == MSGS_LT) && (thismsg < ref))
                                || ((mode == MSGS_EQ) && (thismsg == ref))
                            )
                            ) {
@@ -798,6 +797,8 @@ void cmd_msgs(char *cmdbuf)
        char search_string[1024];
        ForEachMsgCallback CallBack;
 
+       if (CtdlAccessCheck(ac_logged_in_or_guest)) return;
+
        extract_token(which, cmdbuf, 0, '|', sizeof which);
        cm_ref = extract_int(cmdbuf, 1);
        extract_token(search_string, cmdbuf, 1, '|', sizeof search_string);
@@ -827,16 +828,13 @@ void cmd_msgs(char *cmdbuf)
                mode = MSGS_LAST;
        else if (!strncasecmp(which, "GT", 2))
                mode = MSGS_GT;
+       else if (!strncasecmp(which, "LT", 2))
+               mode = MSGS_LT;
        else if (!strncasecmp(which, "SEARCH", 6))
                mode = MSGS_SEARCH;
        else
                mode = MSGS_ALL;
 
-       if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
-               cprintf("%d not logged in\n", ERROR + NOT_LOGGED_IN);
-               return;
-       }
-
        if ( (mode == MSGS_SEARCH) && (!config.c_enable_fulltext) ) {
                cprintf("%d Full text index is not enabled on this server.\n",
                        ERROR + CMD_NOT_SUPPORTED);
@@ -927,79 +925,56 @@ void do_help_subst(char *buffer)
  */
 void memfmout(
        char *mptr,             /* where are we going to get our text from? */
-       char subst,             /* nonzero if we should do substitutions */
-       char *nl)               /* string to terminate lines with */
-{
-       int a, b, c;
-       int real = 0;
-       int old = 0;
-       cit_uint8_t ch;
-       char aaa[140];
-       char buffer[SIZ];
-       static int width = 80;
-
-       strcpy(aaa, "");
-       old = 255;
-       strcpy(buffer, "");
-       c = 1;                  /* c is the current pos */
-
-       do {
-               if (subst) {
-                       while (ch = *mptr, ((ch != 0) && (strlen(buffer) < 126))) {
-                               ch = *mptr++;
-                               buffer[strlen(buffer) + 1] = 0;
-                               buffer[strlen(buffer)] = ch;
-                       }
-
-                       if (buffer[0] == '^')
-                               do_help_subst(buffer);
-
-                       buffer[strlen(buffer) + 1] = 0;
-                       a = buffer[0];
-                       strcpy(buffer, &buffer[1]);
-               } else {
-                       ch = *mptr++;
-               }
-
-               old = real;
-               real = ch;
-
-               if (((ch == 13) || (ch == 10)) && (old != 13) && (old != 10)) {
-                       ch = 32;
+       const char *nl          /* string to terminate lines with */
+) {
+       int column = 0;
+       unsigned char ch = 0;
+       char outbuf[1024];
+       int len = 0;
+       int nllen = 0;
+
+       if (!mptr) return;
+       nllen = strlen(nl);
+       while (ch=*(mptr++), ch != 0) {
+
+               if (ch == '\n') {
+                       client_write(outbuf, len);
+                       len = 0;
+                       client_write(nl, nllen);
+                       column = 0;
                }
-               if (((old == 13) || (old == 10)) && (isspace(real))) {
-                       cprintf("%s", nl);
-                       c = 1;
+               else if (ch == '\r') {
+                       /* Ignore carriage returns.  Newlines are always LF or CRLF but never CR. */
                }
-               if (ch > 32) {
-                       if (((strlen(aaa) + c) > (width - 5)) && (strlen(aaa) > (width - 5))) {
-                               cprintf("%s%s", nl, aaa);
-                               c = strlen(aaa);
-                               aaa[0] = 0;
+               else if (isspace(ch)) {
+                       if (column > 72) {              /* Beyond 72 columns, break on the next space */
+                               client_write(outbuf, len);
+                               len = 0;
+                               client_write(nl, nllen);
+                               column = 0;
                        }
-                       b = strlen(aaa);
-                       aaa[b] = ch;
-                       aaa[b + 1] = 0;
-               }
-               if (ch == 32) {
-                       if ((strlen(aaa) + c) > (width - 5)) {
-                               cprintf("%s", nl);
-                               c = 1;
+                       else {
+                               outbuf[len++] = ch;
+                               ++column;
                        }
-                       cprintf("%s ", aaa);
-                       ++c;
-                       c = c + strlen(aaa);
-                       strcpy(aaa, "");
                }
-               if ((ch == 13) || (ch == 10)) {
-                       cprintf("%s%s", aaa, nl);
-                       c = 1;
-                       strcpy(aaa, "");
+               else {
+                       outbuf[len++] = ch;
+                       ++column;
+                       if (column > 1000) {            /* Beyond 1000 columns, break anywhere */
+                               client_write(outbuf, len);
+                               len = 0;
+                               client_write(nl, nllen);
+                               column = 0;
+                       }
                }
-
-       } while (ch > 0);
-
-       cprintf("%s%s", aaa, nl);
+       }
+       if (len) {
+               client_write(outbuf, len);
+               len = 0;
+               client_write(nl, nllen);
+               column = 0;
+       }
 }
 
 
@@ -1015,8 +990,15 @@ void list_this_part(char *name, char *filename, char *partnum, char *disp,
        
        ma = (struct ma_info *)cbuserdata;
        if (ma->is_ma == 0) {
-               cprintf("part=%s|%s|%s|%s|%s|%ld|%s\n",
-                       name, filename, partnum, disp, cbtype, (long)length, cbid);
+               cprintf("part=%s|%s|%s|%s|%s|%ld|%s|%s\n",
+                       name, 
+                       filename, 
+                       partnum, 
+                       disp, 
+                       cbtype, 
+                       (long)length, 
+                       cbid, 
+                       cbcharset);
        }
 }
 
@@ -1104,17 +1086,60 @@ void mime_spew_section(char *name, char *filename, char *partnum, char *disp,
        ||      (!IsEmptyStr(cbid) && (!strcasecmp(CC->download_desired_section, cbid)))
        ) {
                *found_it = 1;
-               cprintf("%d %d|-1|%s|%s\n",
+               cprintf("%d %d|-1|%s|%s|%s\n",
                        BINARY_FOLLOWS,
                        (int)length,
                        filename,
-                       cbtype
+                       cbtype,
+                       cbcharset
                );
                client_write(content, length);
        }
 }
 
+#ifdef MESSAGE_IN_ROOM
+/*
+ * Check if a message is in the current room.
+ * This is used by CtdlFetchMessage to prevent random picking
+ * of messages from users private rooms
+ *
+ * The message list should probably be cached against the CC->room
+ */
+int CtdlMessageInRoom(long msgnum)
+{
+       visit vbuf;
+       struct cdbdata *cdbfr;
 
+       /* Learn about the user and room in question */
+       CtdlGetUser(&CC->user, CC->curr_user);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
+
+       /* Load the message list */
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
+       if (cdbfr != NULL) {
+               long *msglist = NULL;
+               int num_msgs = 0;
+               int i;
+               int r = 0;
+               
+               msglist = (long *) cdbfr->ptr;
+               num_msgs = cdbfr->len / sizeof(long);
+
+               /* search for message msgnum */
+               for (i=0; i<num_msgs; i++) {
+                       if (msglist[i] == msgnum) {
+                               r = 1;
+                               break;
+                       }       
+               }
+
+               cdb_free(cdbfr);
+               return r;
+       } else {
+               return 0;
+       }
+}
+#endif
 
 /*
  * Load a message from disk into memory.
@@ -1134,6 +1159,13 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
 
        CtdlLogPrintf(CTDL_DEBUG, "CtdlFetchMessage(%ld, %d)\n", msgnum, with_body);
 
+#ifdef MESSAGE_IN_ROOM
+       if (!CtdlMessageInRoom(msgnum)) {
+               CtdlLogPrintf(CTDL_DEBUG, "Message %ld not in current room\n", msgnum);
+               return NULL;
+       }
+#endif
+
        dmsgtext = cdb_fetch(CDB_MSGMAIN, &msgnum, sizeof(long));
        if (dmsgtext == NULL) {
                return NULL;
@@ -1185,7 +1217,8 @@ struct CtdlMessage *CtdlFetchMessage(long msgnum, int with_body)
        if ( (ret->cm_fields['M'] == NULL) && (with_body) ) {
                dmsgtext = cdb_fetch(CDB_BIGMSGS, &msgnum, sizeof(long));
                if (dmsgtext != NULL) {
-                       ret->cm_fields['M'] = strdup(dmsgtext->ptr);
+                       ret->cm_fields['M'] = dmsgtext->ptr;
+                       dmsgtext->ptr = NULL;
                        cdb_free(dmsgtext);
                }
        }
@@ -1473,16 +1506,18 @@ void extract_encapsulated_message(char *name, char *filename, char *partnum, cha
                memcpy(encap->msg, content, length);
                return;
        }
-
 }
 
 
-
-
-
-
+/* 
+ * Determine whether the currently logged in session has permission to read
+ * messages in the current room.
+ */
 int CtdlDoIHavePermissionToReadMessagesInThisRoom(void) {
-       if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
+       if (    (!(CC->logged_in))
+               && (!(CC->internal_pgm))
+               && (!config.c_guest_logins)
+       ) {
                return(om_not_logged_in);
        }
        return(om_ok);
@@ -1524,7 +1559,14 @@ int CtdlOutputMsg(long msg_num,          /* message number (local) to fetch */
                return(r);
        }
 
-       /* FIXME: check message id against msglist for this room */
+#ifdef MESSAGE_IN_ROOM
+       if (!CtdlMessageInRoom(msg_num)) {
+               CtdlLogPrintf(CTDL_DEBUG, "Message %ld not in current room\n", msg_num);
+               if (do_proto) cprintf("%d Can't locate msg %ld in room\n",
+                       ERROR + MESSAGE_NOT_FOUND, msg_num);
+               return(om_no_such_msg);
+       }
+#endif
 
        /*
         * Fetch the message from disk.  If we're in HEADERS_FAST mode,
@@ -1587,7 +1629,7 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
 
 char *qp_encode_email_addrs(char *source)
 {
-       char user[256], node[256], name[256];
+       char *user, *node, *name;
        const char headerStr[] = "=?UTF-8?Q?";
        char *Encoded;
        char *EncodedName;
@@ -1605,6 +1647,8 @@ char *qp_encode_email_addrs(char *source)
 
        if (source == NULL) return source;
        if (IsEmptyStr(source)) return source;
+       cit_backtrace();
+       CtdlLogPrintf(CTDL_DEBUG, "qp_encode_email_addrs: [%s]\n", source);
 
        AddrPtr = malloc (sizeof (long) * nAddrPtrMax);
        AddrUtf8 = malloc (sizeof (long) * nAddrPtrMax);
@@ -1652,6 +1696,10 @@ char *qp_encode_email_addrs(char *source)
 
        for (i = 0; i < nColons; i++)
                source[AddrPtr[i]++] = '\0';
+       /* TODO: if libidn, this might get larger*/
+       user = malloc(SourceLen + 1);
+       node = malloc(SourceLen + 1);
+       name = malloc(SourceLen + 1);
 
        nPtr = Encoded;
        *nPtr = '\0';
@@ -1695,6 +1743,10 @@ char *qp_encode_email_addrs(char *source)
        }
        for (i = 0; i < nColons; i++)
                source[--AddrPtr[i]] = ',';
+
+       free(user);
+       free(node);
+       free(name);
        free(AddrUtf8);
        free(AddrPtr);
        return Encoded;
@@ -1725,6 +1777,330 @@ void sanitize_truncated_recipient(char *str)
 }
 
 
+void OutputCtdlMsgHeaders(
+       struct CtdlMessage *TheMessage,
+       int do_proto)           /* do Citadel protocol responses? */
+{
+       char allkeys[30];
+       int i, k, n;
+       int suppress_f = 0;
+       char buf[SIZ];
+       char display_name[256];
+
+       /* begin header processing loop for Citadel message format */
+       safestrncpy(display_name, "<unknown>", sizeof display_name);
+       if (TheMessage->cm_fields['A']) {
+               strcpy(buf, TheMessage->cm_fields['A']);
+               if (TheMessage->cm_anon_type == MES_ANONONLY) {
+                       safestrncpy(display_name, "****", sizeof display_name);
+               }
+               else if (TheMessage->cm_anon_type == MES_ANONOPT) {
+                       safestrncpy(display_name, "anonymous", sizeof display_name);
+               }
+               else {
+                       safestrncpy(display_name, buf, sizeof display_name);
+               }
+               if ((is_room_aide())
+                   && ((TheMessage->cm_anon_type == MES_ANONONLY)
+                       || (TheMessage->cm_anon_type == MES_ANONOPT))) {
+                       size_t tmp = strlen(display_name);
+                       snprintf(&display_name[tmp],
+                                sizeof display_name - tmp,
+                                " [%s]", buf);
+               }
+       }
+
+       /* Don't show Internet address for users on the
+        * local Citadel network.
+        */
+       suppress_f = 0;
+       if (TheMessage->cm_fields['N'] != NULL)
+               if (!IsEmptyStr(TheMessage->cm_fields['N']))
+                       if (haschar(TheMessage->cm_fields['N'], '.') == 0) {
+                               suppress_f = 1;
+                       }
+
+       /* Now spew the header fields in the order we like them. */
+       n = safestrncpy(allkeys, FORDER, sizeof allkeys);
+       for (i=0; i<n; ++i) {
+               k = (int) allkeys[i];
+               if (k != 'M') {
+                       if ( (TheMessage->cm_fields[k] != NULL)
+                            && (msgkeys[k] != NULL) ) {
+                               if ((k == 'V') || (k == 'R') || (k == 'Y')) {
+                                       sanitize_truncated_recipient(TheMessage->cm_fields[k]);
+                               }
+                               if (k == 'A') {
+                                       if (do_proto) cprintf("%s=%s\n",
+                                                             msgkeys[k],
+                                                             display_name);
+                               }
+                               else if ((k == 'F') && (suppress_f)) {
+                                       /* do nothing */
+                               }
+                               /* Masquerade display name if needed */
+                               else {
+                                       if (do_proto) cprintf("%s=%s\n",
+                                                             msgkeys[k],
+                                                             TheMessage->cm_fields[k]
+                                               );
+                               }
+                       }
+               }
+       }
+
+}
+
+void OutputRFC822MsgHeaders(
+       struct CtdlMessage *TheMessage,
+       int flags,              /* should the bessage be exported clean */
+       const char *nl,
+       char *mid, long sizeof_mid,
+       char *suser, long sizeof_suser,
+       char *luser, long sizeof_luser,
+       char *fuser, long sizeof_fuser,
+       char *snode, long sizeof_snode)
+{
+       char datestamp[100];
+       int subject_found = 0;
+       char buf[SIZ];
+       int i, j, k;
+       char *mptr = NULL;
+       char *mpptr = NULL;
+
+       for (i = 0; i < 256; ++i) {
+               if (TheMessage->cm_fields[i]) {
+                       mptr = mpptr = TheMessage->cm_fields[i];
+                               
+                       if (i == 'A') {
+                               safestrncpy(luser, mptr, sizeof_luser);
+                               safestrncpy(suser, mptr, sizeof_suser);
+                       }
+                       else if (i == 'Y') {
+                               if ((flags & QP_EADDR) != 0) {
+                                       mptr = qp_encode_email_addrs(mptr);
+                               }
+                               sanitize_truncated_recipient(mptr);
+                               cprintf("CC: %s%s", mptr, nl);
+                       }
+                       else if (i == 'P') {
+                               cprintf("Return-Path: %s%s", mptr, nl);
+                       }
+                       else if (i == 'L') {
+                               cprintf("List-ID: %s%s", mptr, nl);
+                       }
+                       else if (i == 'V') {
+                               if ((flags & QP_EADDR) != 0) 
+                                       mptr = qp_encode_email_addrs(mptr);
+                               cprintf("Envelope-To: %s%s", mptr, nl);
+                       }
+                       else if (i == 'U') {
+                               cprintf("Subject: %s%s", mptr, nl);
+                               subject_found = 1;
+                       }
+                       else if (i == 'I')
+                               safestrncpy(mid, mptr, sizeof_mid); /// TODO: detect @ here and copy @nodename in if not found.
+                       else if (i == 'F')
+                               safestrncpy(fuser, mptr, sizeof_fuser);
+                       /* else if (i == 'O')
+                          cprintf("X-Citadel-Room: %s%s",
+                          mptr, nl); */
+                       else if (i == 'N')
+                               safestrncpy(snode, mptr, sizeof_snode);
+                       else if (i == 'R')
+                       {
+                               if (haschar(mptr, '@') == 0)
+                               {
+                                       sanitize_truncated_recipient(mptr);
+                                       cprintf("To: %s@%s", mptr, config.c_fqdn);
+                                       cprintf("%s", nl);
+                               }
+                               else
+                               {
+                                       if ((flags & QP_EADDR) != 0) {
+                                               mptr = qp_encode_email_addrs(mptr);
+                                       }
+                                       sanitize_truncated_recipient(mptr);
+                                       cprintf("To: %s", mptr);
+                                       cprintf("%s", nl);
+                               }
+                       }
+                       else if (i == 'T') {
+                               datestring(datestamp, sizeof datestamp,
+                                          atol(mptr), DATESTRING_RFC822);
+                               cprintf("Date: %s%s", datestamp, nl);
+                       }
+                       else if (i == 'W') {
+                               cprintf("References: ");
+                               k = num_tokens(mptr, '|');
+                               for (j=0; j<k; ++j) {
+                                       extract_token(buf, mptr, j, '|', sizeof buf);
+                                       cprintf("<%s>", buf);
+                                       if (j == (k-1)) {
+                                               cprintf("%s", nl);
+                                       }
+                                       else {
+                                               cprintf(" ");
+                                       }
+                               }
+                       }
+                       else if (i == 'K') {
+                               cprintf("Reply-To: <%s>%s", mptr, nl);
+                       }
+                       if (mptr != mpptr)
+                               free (mptr);
+               }
+       }
+       if (subject_found == 0) {
+               cprintf("Subject: (no subject)%s", nl);
+       }
+}
+
+
+void Dump_RFC822HeadersBody(
+       struct CtdlMessage *TheMessage,
+       int headers_only,       /* eschew the message body? */
+       int flags,              /* should the bessage be exported clean? */
+
+       const char *nl)
+{
+       cit_uint8_t prev_ch;
+       int eoh = 0;
+       const char *StartOfText = StrBufNOTNULL;
+       char outbuf[1024];
+       int outlen = 0;
+       int nllen = strlen(nl);
+       char *mptr;
+
+       mptr = TheMessage->cm_fields['M'];
+
+
+       prev_ch = '\0';
+       while (*mptr != '\0') {
+               if (*mptr == '\r') {
+                       /* do nothing */
+               }
+               else {
+                       if ((!eoh) &&
+                           (*mptr == '\n'))
+                       {
+                               eoh = (*(mptr+1) == '\r') && (*(mptr+2) == '\n');
+                               if (!eoh)
+                                       eoh = *(mptr+1) == '\n';
+                               if (eoh)
+                               {
+                                       StartOfText = mptr;
+                                       StartOfText = strchr(StartOfText, '\n');
+                                       StartOfText = strchr(StartOfText, '\n');
+                               }
+                       }
+                       if (((headers_only == HEADERS_NONE) && (mptr >= StartOfText)) ||
+                           ((headers_only == HEADERS_ONLY) && (mptr < StartOfText)) ||
+                           ((headers_only != HEADERS_NONE) && 
+                            (headers_only != HEADERS_ONLY))
+                               ) {
+                               if (*mptr == '\n') {
+                                       memcpy(&outbuf[outlen], nl, nllen);
+                                       outlen += nllen;
+                                       outbuf[outlen] = '\0';
+                               }
+                               else {
+                                       outbuf[outlen++] = *mptr;
+                               }
+                       }
+               }
+               if (flags & ESC_DOT)
+               {
+                       if ((prev_ch == '\n') && 
+                           (*mptr == '.') && 
+                           ((*(mptr+1) == '\r') || (*(mptr+1) == '\n')))
+                       {
+                               outbuf[outlen++] = '.';
+                       }
+                       prev_ch = *mptr;
+               }
+               ++mptr;
+               if (outlen > 1000) {
+                       client_write(outbuf, outlen);
+                       outlen = 0;
+               }
+       }
+       if (outlen > 0) {
+               client_write(outbuf, outlen);
+               outlen = 0;
+       }
+}
+
+
+
+/* If the format type on disk is 1 (fixed-format), then we want
+ * everything to be output completely literally ... regardless of
+ * what message transfer format is in use.
+ */
+void DumpFormatFixed(
+       struct CtdlMessage *TheMessage,
+       int mode,               /* how would you like that message? */
+       const char *nl)
+{
+       cit_uint8_t ch;
+       char buf[SIZ];
+       int buflen;
+       int xlline = 0;
+       int nllen = strlen (nl);
+       char *mptr;
+
+       mptr = TheMessage->cm_fields['M'];
+       
+       if (mode == MT_MIME) {
+               cprintf("Content-type: text/plain\n\n");
+       }
+       *buf = '\0';
+       buflen = 0;
+       while (ch = *mptr++, ch > 0) {
+               if (ch == '\n')
+                       ch = '\r';
+
+               if ((buflen > 250) && (!xlline)){
+                       int tbuflen;
+                       tbuflen = buflen;
+
+                       while ((buflen > 0) && 
+                              (!isspace(buf[buflen])))
+                               buflen --;
+                       if (buflen == 0) {
+                               xlline = 1;
+                       }
+                       else {
+                               mptr -= tbuflen - buflen;
+                               buf[buflen] = '\0';
+                               ch = '\r';
+                       }
+               }
+               /* if we reach the outer bounds of our buffer, 
+                  abort without respect what whe purge. */
+               if (xlline && 
+                   ((isspace(ch)) || 
+                    (buflen > SIZ - nllen - 2)))
+                       ch = '\r';
+
+               if (ch == '\r') {
+                       memcpy (&buf[buflen], nl, nllen);
+                       buflen += nllen;
+                       buf[buflen] = '\0';
+
+                       client_write(buf, buflen);
+                       *buf = '\0';
+                       buflen = 0;
+                       xlline = 0;
+               } else {
+                       buf[buflen] = ch;
+                       buflen++;
+               }
+       }
+       buf[buflen] = '\0';
+       if (!IsEmptyStr(buf))
+               cprintf("%s%s", buf, nl);
+}
 
 /*
  * Get a message off disk.  (returns om_* values found in msgbase.h)
@@ -1737,15 +2113,9 @@ int CtdlOutputPreLoadedMsg(
                int crlf,               /* Use CRLF newlines instead of LF? */
                int flags               /* should the bessage be exported clean? */
 ) {
-       int i, j, k;
-       char buf[SIZ];
-       cit_uint8_t ch, prev_ch;
-       char allkeys[30];
-       char display_name[256];
-       char *mptr, *mpptr;
-       char *nl;       /* newline string */
-       int suppress_f = 0;
-       int subject_found = 0;
+       int i;
+       char *mptr = NULL;
+       const char *nl; /* newline string */
        struct ma_info ma;
 
        /* Buffers needed for RFC822 translation.  These are all filled
@@ -1757,7 +2127,6 @@ int CtdlOutputPreLoadedMsg(
        char fuser[100];
        char snode[100];
        char mid[100];
-       char datestamp[100];
 
        CtdlLogPrintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %d, %d, %d, %d\n",
                ((TheMessage == NULL) ? "NULL" : "not null"),
@@ -1852,164 +2221,27 @@ int CtdlOutputPreLoadedMsg(
                cprintf("nhdr=yes\n");
        }
 
-       /* begin header processing loop for Citadel message format */
-
-       if ((mode == MT_CITADEL) || (mode == MT_MIME)) {
+       if ((mode == MT_CITADEL) || (mode == MT_MIME)) 
+               OutputCtdlMsgHeaders(TheMessage, do_proto);
 
-               safestrncpy(display_name, "<unknown>", sizeof display_name);
-               if (TheMessage->cm_fields['A']) {
-                       strcpy(buf, TheMessage->cm_fields['A']);
-                       if (TheMessage->cm_anon_type == MES_ANONONLY) {
-                               safestrncpy(display_name, "****", sizeof display_name);
-                       }
-                       else if (TheMessage->cm_anon_type == MES_ANONOPT) {
-                               safestrncpy(display_name, "anonymous", sizeof display_name);
-                       }
-                       else {
-                               safestrncpy(display_name, buf, sizeof display_name);
-                       }
-                       if ((is_room_aide())
-                           && ((TheMessage->cm_anon_type == MES_ANONONLY)
-                            || (TheMessage->cm_anon_type == MES_ANONOPT))) {
-                               size_t tmp = strlen(display_name);
-                               snprintf(&display_name[tmp],
-                                        sizeof display_name - tmp,
-                                        " [%s]", buf);
-                       }
-               }
-
-               /* Don't show Internet address for users on the
-                * local Citadel network.
-                */
-               suppress_f = 0;
-               if (TheMessage->cm_fields['N'] != NULL)
-                  if (!IsEmptyStr(TheMessage->cm_fields['N']))
-                     if (haschar(TheMessage->cm_fields['N'], '.') == 0) {
-                       suppress_f = 1;
-               }
-
-               /* Now spew the header fields in the order we like them. */
-               safestrncpy(allkeys, FORDER, sizeof allkeys);
-               for (i=0; i<strlen(allkeys); ++i) {
-                       k = (int) allkeys[i];
-                       if (k != 'M') {
-                               if ( (TheMessage->cm_fields[k] != NULL)
-                                  && (msgkeys[k] != NULL) ) {
-                                       if ((k == 'V') || (k == 'R') || (k == 'Y')) {
-                                               sanitize_truncated_recipient(TheMessage->cm_fields[k]);
-                                       }
-                                       if (k == 'A') {
-                                               if (do_proto) cprintf("%s=%s\n",
-                                                       msgkeys[k],
-                                                       display_name);
-                                       }
-                                       else if ((k == 'F') && (suppress_f)) {
-                                               /* do nothing */
-                                       }
-                                       /* Masquerade display name if needed */
-                                       else {
-                                               if (do_proto) cprintf("%s=%s\n",
-                                                       msgkeys[k],
-                                                       TheMessage->cm_fields[k]
-                                       );
-                                       }
-                               }
-                       }
-               }
-
-       }
 
        /* begin header processing loop for RFC822 transfer format */
-
        strcpy(suser, "");
        strcpy(luser, "");
        strcpy(fuser, "");
        strcpy(snode, NODENAME);
-       if (mode == MT_RFC822) {
-               for (i = 0; i < 256; ++i) {
-                       if (TheMessage->cm_fields[i]) {
-                               mptr = mpptr = TheMessage->cm_fields[i];
-                               
-                               if (i == 'A') {
-                                       safestrncpy(luser, mptr, sizeof luser);
-                                       safestrncpy(suser, mptr, sizeof suser);
-                               }
-                               else if (i == 'Y') {
-                                       if ((flags & QP_EADDR) != 0) {
-                                               mptr = qp_encode_email_addrs(mptr);
-                                       }
-                                       sanitize_truncated_recipient(mptr);
-                                       cprintf("CC: %s%s", mptr, nl);
-                               }
-                               else if (i == 'P') {
-                                       cprintf("Return-Path: %s%s", mptr, nl);
-                               }
-                               else if (i == 'L') {
-                                       cprintf("List-ID: %s%s", mptr, nl);
-                               }
-                               else if (i == 'V') {
-                                       if ((flags & QP_EADDR) != 0) 
-                                               mptr = qp_encode_email_addrs(mptr);
-                                       cprintf("Envelope-To: %s%s", mptr, nl);
-                               }
-                               else if (i == 'U') {
-                                       cprintf("Subject: %s%s", mptr, nl);
-                                       subject_found = 1;
-                               }
-                               else if (i == 'I')
-                                       safestrncpy(mid, mptr, sizeof mid);
-                               else if (i == 'F')
-                                       safestrncpy(fuser, mptr, sizeof fuser);
-                               /* else if (i == 'O')
-                                       cprintf("X-Citadel-Room: %s%s",
-                                               mptr, nl); */
-                               else if (i == 'N')
-                                       safestrncpy(snode, mptr, sizeof snode);
-                               else if (i == 'R')
-                               {
-                                       if (haschar(mptr, '@') == 0)
-                                       {
-                                               sanitize_truncated_recipient(mptr);
-                                               cprintf("To: %s@%s", mptr, config.c_fqdn);
-                                               cprintf("%s", nl);
-                                       }
-                                       else
-                                       {
-                                               if ((flags & QP_EADDR) != 0) {
-                                                       mptr = qp_encode_email_addrs(mptr);
-                                               }
-                                               sanitize_truncated_recipient(mptr);
-                                               cprintf("To: %s", mptr);
-                                               cprintf("%s", nl);
-                                       }
-                               }
-                               else if (i == 'T') {
-                                       datestring(datestamp, sizeof datestamp,
-                                               atol(mptr), DATESTRING_RFC822);
-                                       cprintf("Date: %s%s", datestamp, nl);
-                               }
-                               else if (i == 'W') {
-                                       cprintf("References: ");
-                                       k = num_tokens(mptr, '|');
-                                       for (j=0; j<k; ++j) {
-                                               extract_token(buf, mptr, j, '|', sizeof buf);
-                                               cprintf("<%s>", buf);
-                                               if (j == (k-1)) {
-                                                       cprintf("%s", nl);
-                                               }
-                                               else {
-                                                       cprintf(" ");
-                                               }
-                                       }
-                               }
-                               if (mptr != mpptr)
-                                       free (mptr);
-                       }
-               }
-               if (subject_found == 0) {
-                       cprintf("Subject: (no subject)%s", nl);
-               }
-       }
+       if (mode == MT_RFC822) 
+               OutputRFC822MsgHeaders(
+                       TheMessage,
+                       flags,
+                       nl,
+                       mid, sizeof(mid),
+                       suser, sizeof(suser),
+                       luser, sizeof(luser),
+                       fuser, sizeof(fuser),
+                       snode, sizeof(snode)
+                       );
+
 
        for (i=0; !IsEmptyStr(&suser[i]); ++i) {
                suser[i] = tolower(suser[i]);
@@ -2050,11 +2282,11 @@ int CtdlOutputPreLoadedMsg(
        /* end header processing loop ... at this point, we're in the text */
 START_TEXT:
        if (headers_only == HEADERS_FAST) goto DONE;
-       mptr = TheMessage->cm_fields['M'];
 
        /* Tell the client about the MIME parts in this message */
        if (TheMessage->cm_format_type == FMT_RFC822) {
                if ( (mode == MT_CITADEL) || (mode == MT_MIME) ) {
+                       mptr = TheMessage->cm_fields['M'];
                        memset(&ma, 0, sizeof(struct ma_info));
                        mime_parser(mptr, NULL,
                                (do_proto ? *list_this_part : NULL),
@@ -2063,56 +2295,11 @@ START_TEXT:
                                (void *)&ma, 0);
                }
                else if (mode == MT_RFC822) {   /* unparsed RFC822 dump */
-                       char *start_of_text = NULL;
-                       start_of_text = strstr(mptr, "\n\r\n");
-                       if (start_of_text == NULL) start_of_text = strstr(mptr, "\n\n");
-                       if (start_of_text == NULL) start_of_text = mptr;
-                       ++start_of_text;
-                       start_of_text = strstr(start_of_text, "\n");
-                       ++start_of_text;
-
-                       char outbuf[1024];
-                       int outlen = 0;
-                       int nllen = strlen(nl);
-                       prev_ch = 0;
-                       while (ch=*mptr, ch!=0) {
-                               if (ch==13) {
-                                       /* do nothing */
-                               }
-                               else {
-                                       if (
-                                               ((headers_only == HEADERS_NONE) && (mptr >= start_of_text))
-                                          ||   ((headers_only == HEADERS_ONLY) && (mptr < start_of_text))
-                                          ||   ((headers_only != HEADERS_NONE) && (headers_only != HEADERS_ONLY))
-                                       ) {
-                                               if (ch == 10) {
-                                                       sprintf(&outbuf[outlen], "%s", nl);
-                                                       outlen += nllen;
-                                               }
-                                               else {
-                                                       outbuf[outlen++] = ch;
-                                               }
-                                       }
-                               }
-                               if (flags & ESC_DOT)
-                               {
-                                       if ((prev_ch == 10) && (ch == '.') && ((*(mptr+1) == 13) || (*(mptr+1) == 10)))
-                                       {
-                                               outbuf[outlen++] = '.';
-                                       }
-                               }
-                               prev_ch = ch;
-                               ++mptr;
-                               if (outlen > 1000) {
-                                       client_write(outbuf, outlen);
-                                       outlen = 0;
-                               }
-                       }
-                       if (outlen > 0) {
-                               client_write(outbuf, outlen);
-                               outlen = 0;
-                       }
-
+                       Dump_RFC822HeadersBody(
+                               TheMessage,
+                               headers_only,
+                               flags,
+                               nl);
                        goto DONE;
                }
        }
@@ -2126,34 +2313,11 @@ START_TEXT:
                if (do_proto) cprintf("text\n");
        }
 
-       /* If the format type on disk is 1 (fixed-format), then we want
-        * everything to be output completely literally ... regardless of
-        * what message transfer format is in use.
-        */
-       if (TheMessage->cm_format_type == FMT_FIXED) {
-               int buflen;
-               if (mode == MT_MIME) {
-                       cprintf("Content-type: text/plain\n\n");
-               }
-               *buf = '\0';
-               buflen = 0;
-               while (ch = *mptr++, ch > 0) {
-                       if (ch == 13)
-                               ch = 10;
-                       if ((ch == 10) || (buflen > 250)) {
-                               buf[buflen] = '\0';
-                               cprintf("%s%s", buf, nl);
-                               *buf = '\0';
-                               buflen = 0;
-                       } else {
-                               buf[buflen] = ch;
-                               buflen++;
-                       }
-               }
-               buf[buflen] = '\0';
-               if (!IsEmptyStr(buf))
-                       cprintf("%s%s", buf, nl);
-       }
+       if (TheMessage->cm_format_type == FMT_FIXED) 
+               DumpFormatFixed(
+                       TheMessage,
+                       mode,           /* how would you like that message? */
+                       nl);
 
        /* If the message on disk is format 0 (Citadel vari-format), we
         * output using the formatter at 80 columns.  This is the final output
@@ -2163,10 +2327,12 @@ START_TEXT:
         * message to the reader's screen width.
         */
        if (TheMessage->cm_format_type == FMT_CITADEL) {
+               mptr = TheMessage->cm_fields['M'];
+
                if (mode == MT_MIME) {
                        cprintf("Content-type: text/x-citadel-variformat\n\n");
                }
-               memfmout(mptr, 0, nl);
+               memfmout(mptr, nl);
        }
 
        /* If the message on disk is format 4 (MIME), we've gotta hand it
@@ -2202,7 +2368,6 @@ DONE:     /* now we're done */
 }
 
 
-
 /*
  * display a message (mode 0 - Citadel proprietary)
  */
@@ -2349,8 +2514,8 @@ void cmd_dlat(char *cmdbuf)
  * this mode of operation only works if we're saving a single message.)
  */
 int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newmsgs,
-                               int do_repl_check, struct CtdlMessage *supplied_msg)
-{
+                       int do_repl_check, struct CtdlMessage *supplied_msg, int suppress_refcount_adj
+{
        int i, j, unique;
        char hold_rm[ROOMNAMELEN];
        struct cdbdata *cdbfr;
@@ -2365,8 +2530,9 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
        int num_msgs_to_be_merged = 0;
 
        CtdlLogPrintf(CTDL_DEBUG,
-               "CtdlSaveMsgPointersInRoom(room=%s, num_msgs=%d, repl=%d)\n",
-               roomname, num_newmsgs, do_repl_check);
+               "CtdlSaveMsgPointersInRoom(room=%s, num_msgs=%d, repl=%d, suppress_rca=%d)\n",
+               roomname, num_newmsgs, do_repl_check, suppress_refcount_adj
+       );
 
        strcpy(hold_rm, CC->room.QRname);
 
@@ -2487,8 +2653,10 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
        CtdlGetRoom(&CC->room, hold_rm);
 
        /* Bump the reference count for all messages which were merged */
-       for (i=0; i<num_msgs_to_be_merged; ++i) {
-               AdjRefCount(msgs_to_be_merged[i], +1);
+       if (!suppress_refcount_adj) {
+               for (i=0; i<num_msgs_to_be_merged; ++i) {
+                       AdjRefCount(msgs_to_be_merged[i], +1);
+               }
        }
 
        /* Free up memory... */
@@ -2508,7 +2676,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
 int CtdlSaveMsgPointerInRoom(char *roomname, long msgid,
                        int do_repl_check, struct CtdlMessage *supplied_msg)
 {
-       return CtdlSaveMsgPointersInRoom(roomname, &msgid, 1, do_repl_check, supplied_msg);
+       return CtdlSaveMsgPointersInRoom(roomname, &msgid, 1, do_repl_check, supplied_msg, 0);
 }
 
 
@@ -2702,7 +2870,7 @@ void ReplicationChecks(struct CtdlMessage *msg) {
        /*CtdlLogPrintf(CTDL_DEBUG, "Exclusive ID: <%s> for room <%s>\n",
                msg->cm_fields['E'], CC->room.QRname);*/
 
-       old_msgnum = locate_message_by_euid(msg->cm_fields['E'], &CC->room);
+       old_msgnum = CtdlLocateMessageByEuid(msg->cm_fields['E'], &CC->room);
        if (old_msgnum > 0L) {
                CtdlLogPrintf(CTDL_DEBUG, "ReplicationChecks() replacing message %ld\n", old_msgnum);
                CtdlDeleteMessages(CC->room.QRname, &old_msgnum, 1, "");
@@ -2717,7 +2885,7 @@ void ReplicationChecks(struct CtdlMessage *msg) {
 long CtdlSubmitMsg(struct CtdlMessage *msg,    /* message to save */
                   struct recptypes *recps,     /* recipients (if mail) */
                   char *force,                 /* force a particular room? */
-                  int flags                    /* should the bessage be exported clean? */
+                  int flags                    /* should the message be exported clean? */
 ) {
        char submit_filename[128];
        char generated_timestamp[32];
@@ -2727,7 +2895,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        char content_type[SIZ];                 /* We have to learn this */
        char recipient[SIZ];
        long newmsgid;
-       char *mptr = NULL;
+       const char *mptr = NULL;
        struct ctdluser userbuf;
        int a, i;
        struct MetaData smi;
@@ -2740,9 +2908,9 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        char *hold_R, *hold_D;
        char *collected_addresses = NULL;
        struct addresses_to_be_filed *aptr = NULL;
-       char *saved_rfc822_version = NULL;
+       StrBuf *saved_rfc822_version = NULL;
        int qualified_for_journaling = 0;
-       struct CitContext *CCC = CC;            /* CachedCitContext - performance boost */
+       CitContext *CCC = MyContext();
        char bounce_to[1024] = "";
        size_t tmp = 0;
        int rv = 0;
@@ -2824,7 +2992,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
 
        /* If the user is a twit, move to the twit room for posting */
        if (TWITDETECT) {
-               if (CCC->user.axlevel == 2) {
+               if (CCC->user.axlevel == AxProbU) {
                        strcpy(hold_rm, actual_rm);
                        strcpy(actual_rm, config.c_twitroom);
                        CtdlLogPrintf(CTDL_DEBUG, "Diverting to twit room\n");
@@ -2891,15 +3059,11 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                CtdlLogPrintf(CTDL_ALERT, "CCC->redirect_buffer is not NULL during message submission!\n");
                abort();
        }
-       CCC->redirect_buffer = malloc(SIZ);
-       CCC->redirect_len = 0;
-       CCC->redirect_alloc = SIZ;
+       CCC->redirect_buffer = NewStrBufPlain(NULL, SIZ);
        CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ALL, 0, 1, QP_EADDR);
-       smi.meta_rfc822_length = CCC->redirect_len;
+       smi.meta_rfc822_length = StrLength(CCC->redirect_buffer);
        saved_rfc822_version = CCC->redirect_buffer;
        CCC->redirect_buffer = NULL;
-       CCC->redirect_len = 0;
-       CCC->redirect_alloc = 0;
 
        PutMetaData(&smi);
 
@@ -2962,7 +3126,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                        msg->cm_fields['W'] = strdup(recipient);
                        CtdlMailboxName(actual_rm, sizeof actual_rm, &userbuf, MAILROOM);
                        CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0, msg);
-                       BumpNewMailCounter(userbuf.usernum);
+                       CtdlBumpNewMailCounter(userbuf.usernum);
                        if (!IsEmptyStr(config.c_funambol_host) || !IsEmptyStr(config.c_pager_program)) {
                        /* Generate a instruction message for the Funambol notification
                         * server, in the same style as the SMTP queue
@@ -3136,7 +3300,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                        JournalBackgroundSubmit(msg, saved_rfc822_version, recps);
                }
                else {
-                       free(saved_rfc822_version);
+                       FreeStrBuf(&saved_rfc822_version);
                }
        }
 
@@ -3202,105 +3366,102 @@ void quickie_message(const char *from, const char *fromaddr, char *to, char *roo
 /*
  * Back end function used by CtdlMakeMessage() and similar functions
  */
-char *CtdlReadMessageBody(char *terminator,    /* token signalling EOT */
-                       size_t maxlen,          /* maximum message length */
-                       char *exist,            /* if non-null, append to it;
-                                                  exist is ALWAYS freed  */
-                       int crlf,               /* CRLF newlines instead of LF */
-                       int sock                /* socket handle or 0 for this session's client socket */
-                       ) {
-       char buf[1024];
-       int linelen;
-       size_t message_len = 0;
-       size_t buffer_len = 0;
-       char *ptr;
-       char *m;
+StrBuf *CtdlReadMessageBodyBuf(char *terminator,       /* token signalling EOT */
+                              long tlen,
+                              size_t maxlen,           /* maximum message length */
+                              char *exist,             /* if non-null, append to it;
+                                                          exist is ALWAYS freed  */
+                              int crlf,                /* CRLF newlines instead of LF */
+                              int *sock                /* socket handle or 0 for this session's client socket */
+                       ) 
+{
+       StrBuf *Message;
+       StrBuf *LineBuf;
        int flushing = 0;
        int finished = 0;
        int dotdot = 0;
 
+       LineBuf = NewStrBufPlain(NULL, SIZ);
        if (exist == NULL) {
-               m = malloc(4096);
-               m[0] = 0;
-               buffer_len = 4096;
-               message_len = 0;
+               Message = NewStrBufPlain(NULL, 4 * SIZ);
        }
        else {
-               message_len = strlen(exist);
-               buffer_len = message_len + 4096;
-               m = realloc(exist, buffer_len);
-               if (m == NULL) {
-                       free(exist);
-                       return m;
-               }
+               Message = NewStrBufPlain(exist, -1);
+               free(exist);
        }
 
        /* Do we need to change leading ".." to "." for SMTP escaping? */
-       if (!strcmp(terminator, ".")) {
+       if ((tlen == 1) && (*terminator == '.')) {
                dotdot = 1;
        }
 
-       /* flush the input if we have nowhere to store it */
-       if (m == NULL) {
-               flushing = 1;
-       }
-
        /* read in the lines of message text one by one */
        do {
-               if (sock > 0) {
-                       if (sock_getln(sock, buf, (sizeof buf - 3)) < 0) finished = 1;
+               if (sock != NULL) {
+                       if ((CtdlSockGetLine(sock, LineBuf) < 0) ||
+                           (*sock == -1))
+                               finished = 1;
                }
                else {
-                       if (client_getln(buf, (sizeof buf - 3)) < 1) finished = 1;
-               }
-               if (!strcmp(buf, terminator)) finished = 1;
-               if (crlf) {
-                       strcat(buf, "\r\n");
-               }
-               else {
-                       strcat(buf, "\n");
-               }
-
-               /* Unescape SMTP-style input of two dots at the beginning of the line */
-               if (dotdot) {
-                       if (!strncmp(buf, "..", 2)) {
-                               strcpy(buf, &buf[1]);
-                       }
+                       if (CtdlClientGetLine(LineBuf) < 0) finished = 1;
                }
+               if ((StrLength(LineBuf) == tlen) && 
+                   (!strcmp(ChrPtr(LineBuf), terminator)))
+                       finished = 1;
 
                if ( (!flushing) && (!finished) ) {
-                       /* Measure the line */
-                       linelen = strlen(buf);
-       
-                       /* augment the buffer if we have to */
-                       if ((message_len + linelen) >= buffer_len) {
-                               ptr = realloc(m, (buffer_len * 2) );
-                               if (ptr == NULL) {      /* flush if can't allocate */
-                                       flushing = 1;
-                               } else {
-                                       buffer_len = (buffer_len * 2);
-                                       m = ptr;
-                                       CtdlLogPrintf(CTDL_DEBUG, "buffer_len is now %ld\n", (long)buffer_len);
-                               }
+                       if (crlf) {
+                               StrBufAppendBufPlain(LineBuf, HKEY("\r\n"), 0);
                        }
-       
-                       /* Add the new line to the buffer.  NOTE: this loop must avoid
-                       * using functions like strcat() and strlen() because they
-                       * traverse the entire buffer upon every call, and doing that
-                       * for a multi-megabyte message slows it down beyond usability.
-                       */
-                       strcpy(&m[message_len], buf);
-                       message_len += linelen;
+                       else {
+                               StrBufAppendBufPlain(LineBuf, HKEY("\n"), 0);
+                       }
+                       
+                       /* Unescape SMTP-style input of two dots at the beginning of the line */
+                       if ((dotdot) &&
+                           (StrLength(LineBuf) == 2) && 
+                           (!strcmp(ChrPtr(LineBuf), "..")))
+                       {
+                               StrBufCutLeft(LineBuf, 1);
+                       }
+                       
+                       StrBufAppendBuf(Message, LineBuf, 0);
                }
 
                /* if we've hit the max msg length, flush the rest */
-               if (message_len >= maxlen) flushing = 1;
+               if (StrLength(Message) >= maxlen) flushing = 1;
 
        } while (!finished);
-       return(m);
+       FreeStrBuf(&LineBuf);
+       return Message;
 }
 
 
+/*
+ * Back end function used by CtdlMakeMessage() and similar functions
+ */
+char *CtdlReadMessageBody(char *terminator,    /* token signalling EOT */
+                         long tlen,
+                         size_t maxlen,                /* maximum message length */
+                         char *exist,          /* if non-null, append to it;
+                                                  exist is ALWAYS freed  */
+                         int crlf,             /* CRLF newlines instead of LF */
+                         int *sock             /* socket handle or 0 for this session's client socket */
+       ) 
+{
+       StrBuf *Message;
+
+       Message = CtdlReadMessageBodyBuf(terminator,
+                                        tlen,
+                                        maxlen,
+                                        exist,
+                                        crlf,
+                                        sock);
+       if (Message == NULL)
+               return NULL;
+       else
+               return SmashStrBuf(&Message);
+}
 
 
 /*
@@ -3426,7 +3587,7 @@ struct CtdlMessage *CtdlMakeMessage(
                msg->cm_fields['M'] = preformatted_text;
        }
        else {
-               msg->cm_fields['M'] = CtdlReadMessageBody("000", config.c_maxmsglen, NULL, 0, 0);
+               msg->cm_fields['M'] = CtdlReadMessageBody(HKEY("000"), config.c_maxmsglen, NULL, 0, 0);
        }
 
        return(msg);
@@ -3438,10 +3599,13 @@ struct CtdlMessage *CtdlMakeMessage(
  * room.  Returns a *CITADEL ERROR CODE* and puts a message in errmsgbuf, or
  * returns 0 on success.
  */
-int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf, 
-                                         size_t n, 
-                                         const char* RemoteIdentifier,
-                                         int PostPublic) {
+int CtdlDoIHavePermissionToPostInThisRoom(
+       char *errmsgbuf, 
+       size_t n, 
+       const char* RemoteIdentifier,
+       int PostPublic,
+       int is_reply
+) {
        int ra;
 
        if (!(CC->logged_in) && 
@@ -3498,7 +3662,7 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf,
 
        }
 
-       if ((CC->user.axlevel < 2)
+       if ((CC->user.axlevel < AxProbU)
            && ((CC->room.QRflags & QR_MAILBOX) == 0)) {
                snprintf(errmsgbuf, n, "Need to be validated to enter "
                                "(except in %s> to sysop)", MAILROOM);
@@ -3506,7 +3670,18 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf,
        }
 
        CtdlRoomAccess(&CC->room, &CC->user, &ra, NULL);
-       if (!(ra & UA_POSTALLOWED)) {
+
+       if ( (!(ra & UA_POSTALLOWED)) && (ra & UA_REPLYALLOWED) && (!is_reply) ) {
+               /*
+                * To be thorough, we ought to check to see if the message they are
+                * replying to is actually a valid one in this room, but unless this
+                * actually becomes a problem we'll go with high performance instead.
+                */
+               snprintf(errmsgbuf, n, "You may only reply to existing messages here.");
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       else if (!(ra & UA_POSTALLOWED)) {
                snprintf(errmsgbuf, n, "Higher access is required to post in this room.");
                return (ERROR + HIGHER_ACCESS_REQUIRED);
        }
@@ -3523,7 +3698,7 @@ int CtdlDoIHavePermissionToPostInThisRoom(char *errmsgbuf,
 int CtdlCheckInternetMailPermission(struct ctdluser *who) {
 
        /* Do not allow twits to send Internet mail */
-       if (who->axlevel <= 2) return(0);
+       if (who->axlevel <= AxProbU) return(0);
 
        /* Globally enabled? */
        if (config.c_restrict == 0) return(1);
@@ -3532,7 +3707,7 @@ int CtdlCheckInternetMailPermission(struct ctdluser *who) {
        if (who->flags & US_INTERNET) return(2);
 
        /* Aide level access? */
-       if (who->axlevel >= 6) return(3);
+       if (who->axlevel >= AxAideU) return(3);
 
        /* No mail for you! */
        return(0);
@@ -3548,7 +3723,7 @@ int CtdlCheckInternetMailPermission(struct ctdluser *who) {
  *
  * Caller needs to free the result using free_recipients()
  */
-struct recptypes *validate_recipients(char *supplied_recipients, 
+struct recptypes *validate_recipients(const char *supplied_recipients, 
                                      const char *RemoteIdentifier, 
                                      int Flags) {
        struct recptypes *ret;
@@ -3666,10 +3841,12 @@ struct recptypes *validate_recipients(char *supplied_recipients,
                                        CC->room = tempQR;
                                        
                                        /* Check permissions to send mail to this room */
-                                       err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, 
-                                                                                   sizeof errmsg, 
-                                                                                   RemoteIdentifier,
-                                                                                   Flags
+                                       err = CtdlDoIHavePermissionToPostInThisRoom(
+                                               errmsg, 
+                                               sizeof errmsg, 
+                                               RemoteIdentifier,
+                                               Flags,
+                                               0                       /* 0 = not a reply */
                                        );
                                        if (err)
                                        {
@@ -3872,7 +4049,13 @@ void cmd_ent0(char *entargs)
 
        /* first check to make sure the request is valid. */
 
-       err = CtdlDoIHavePermissionToPostInThisRoom(errmsg, sizeof errmsg, NULL, POST_LOGGED_IN);
+       err = CtdlDoIHavePermissionToPostInThisRoom(
+               errmsg,
+               sizeof errmsg,
+               NULL,
+               POST_LOGGED_IN,
+               (!IsEmptyStr(references))               /* is this a reply?  or a top-level post? */
+       );
        if (err)
        {
                cprintf("%d %s\n", err, errmsg);
@@ -3884,7 +4067,7 @@ void cmd_ent0(char *entargs)
        if (IsEmptyStr(newusername)) {
                strcpy(newusername, CC->user.fullname);
        }
-       if (  (CC->user.axlevel < 6)
+       if (  (CC->user.axlevel < AxAideU)
           && (strcasecmp(newusername, CC->user.fullname))
           && (strcasecmp(newusername, CC->cs_inet_fn))
        ) {     
@@ -3928,13 +4111,14 @@ void cmd_ent0(char *entargs)
        /* In mailbox rooms we have to behave a little differently --
         * make sure the user has specified at least one recipient.  Then
         * validate the recipient(s).  We do this for the Mail> room, as
-        * well as any room which has the "Mailbox" view set.
+        * well as any room which has the "Mailbox" view set - unless it
+        * is the DRAFTS room which does not require recipients
         */
 
-       if (  ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) )
-          || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) )
-       ) {
-               if (CC->user.axlevel < 2) {
+       if (  ( (CC->room.QRflags & QR_MAILBOX) && (!strcasecmp(&CC->room.QRname[11], MAILROOM)) )
+            || ( (CC->room.QRflags & QR_MAILBOX) && (CC->curr_view == VIEW_MAILBOX) )
+       ) && (strcasecmp(&CC->room.QRname[11], USERDRAFTROOM)) !=0 ) {
+               if (CC->user.axlevel < AxProbU) {
                        strcpy(recp, "sysop");
                        strcpy(cc, "");
                        strcpy(bcc, "");
@@ -3986,7 +4170,7 @@ void cmd_ent0(char *entargs)
                }
 
                if ( ( (valid_to->num_internet + valid_to->num_ignet + valid_cc->num_internet + valid_cc->num_ignet + valid_bcc->num_internet + valid_bcc->num_ignet) > 0)
-                  && (CC->user.axlevel < 4) ) {
+                  && (CC->user.axlevel < AxNetU) ) {
                        cprintf("%d Higher access required for network mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
                        free_recipients(valid_to);
@@ -4204,7 +4388,10 @@ int CtdlDeleteMessages(char *room_name,          /* which room */
                cdb_store(CDB_MSGLISTS, &qrbuf.QRnumber, (int)sizeof(long),
                          msglist, (int)(num_msgs * sizeof(long)));
 
-               qrbuf.QRhighest = msglist[num_msgs - 1];
+               if (num_msgs > 0)
+                       qrbuf.QRhighest = msglist[num_msgs - 1];
+               else
+                       qrbuf.QRhighest = 0;
        }
        CtdlPutRoomLock(&qrbuf);
 
@@ -4342,7 +4529,7 @@ void cmd_move(char *args)
        permit = 0;
 
        /* Aides can move/copy */
-       if (CC->user.axlevel >= 6) permit = 1;
+       if (CC->user.axlevel >= AxAideU) permit = 1;
 
        /* Room aides can move/copy */
        if (CC->user.usernum == CC->room.QRroomaide) permit = 1;
@@ -4384,7 +4571,7 @@ void cmd_move(char *args)
        /*
         * Do the copy
         */
-       err = CtdlSaveMsgPointersInRoom(targ, msgs, num_msgs, 1, NULL);
+       err = CtdlSaveMsgPointersInRoom(targ, msgs, num_msgs, 1, NULL, 0);
        if (err != 0) {
                cprintf("%d Cannot store message(s) in %s: error %d\n",
                        err, targ, err);
@@ -4458,6 +4645,10 @@ void AdjRefCount(long msgnum, int incr)
        struct arcq new_arcq;
        int rv = 0;
 
+       CtdlLogPrintf(CTDL_DEBUG, "AdjRefCount() msg %ld ref count delta %+d\n",
+               msgnum, incr
+       );
+
        begin_critical_section(S_SUPPMSGMAIN);
        if (arcfp == NULL) {
                arcfp = fopen(file_arcq, "ab+");
@@ -4571,8 +4762,9 @@ void TDAP_AdjRefCount(long msgnum, int incr)
        smi.meta_refcount += incr;
        PutMetaData(&smi);
        end_critical_section(S_SUPPMSGMAIN);
-       CtdlLogPrintf(CTDL_DEBUG, "msg %ld ref count delta %+d, is now %d\n",
-               msgnum, incr, smi.meta_refcount);
+       CtdlLogPrintf(CTDL_DEBUG, "TDAP_AdjRefCount() msg %ld ref count delta %+d, is now %d\n",
+               msgnum, incr, smi.meta_refcount
+       );
 
        /* If the reference count is now zero, delete the message
         * (and its supplementary record as well).
@@ -4811,19 +5003,21 @@ void cmd_isme(char *argbuf) {
 
 CTDL_MODULE_INIT(msgbase)
 {
-       CtdlRegisterProtoHook(cmd_msgs, "MSGS", "Output a list of messages in the current room");
-       CtdlRegisterProtoHook(cmd_msg0, "MSG0", "Output a message in plain text format");
-       CtdlRegisterProtoHook(cmd_msg2, "MSG2", "Output a message in RFC822 format");
-       CtdlRegisterProtoHook(cmd_msg3, "MSG3", "Output a message in raw format (deprecated)");
-       CtdlRegisterProtoHook(cmd_msg4, "MSG4", "Output a message in the client's preferred format");
-       CtdlRegisterProtoHook(cmd_msgp, "MSGP", "Select preferred format for MSG4 output");
-       CtdlRegisterProtoHook(cmd_opna, "OPNA", "Open an attachment for download");
-       CtdlRegisterProtoHook(cmd_dlat, "DLAT", "Download an attachment");
-       CtdlRegisterProtoHook(cmd_ent0, "ENT0", "Enter a message");
-       CtdlRegisterProtoHook(cmd_dele, "DELE", "Delete a message");
-       CtdlRegisterProtoHook(cmd_move, "MOVE", "Move or copy a message to another room");
-       CtdlRegisterProtoHook(cmd_isme, "ISME", "Determine whether an email address belongs to a user");
+       if (!threading) {
+               CtdlRegisterProtoHook(cmd_msgs, "MSGS", "Output a list of messages in the current room");
+               CtdlRegisterProtoHook(cmd_msg0, "MSG0", "Output a message in plain text format");
+               CtdlRegisterProtoHook(cmd_msg2, "MSG2", "Output a message in RFC822 format");
+               CtdlRegisterProtoHook(cmd_msg3, "MSG3", "Output a message in raw format (deprecated)");
+               CtdlRegisterProtoHook(cmd_msg4, "MSG4", "Output a message in the client's preferred format");
+               CtdlRegisterProtoHook(cmd_msgp, "MSGP", "Select preferred format for MSG4 output");
+               CtdlRegisterProtoHook(cmd_opna, "OPNA", "Open an attachment for download");
+               CtdlRegisterProtoHook(cmd_dlat, "DLAT", "Download an attachment");
+               CtdlRegisterProtoHook(cmd_ent0, "ENT0", "Enter a message");
+               CtdlRegisterProtoHook(cmd_dele, "DELE", "Delete a message");
+               CtdlRegisterProtoHook(cmd_move, "MOVE", "Move or copy a message to another room");
+               CtdlRegisterProtoHook(cmd_isme, "ISME", "Determine whether an email address belongs to a user");
+       }
 
         /* return our Subversion id for the Log */
-       return "$Id$";
+       return "msgbase";
 }