Citadel API clean up.
[citadel.git] / citadel / msgbase.c
index 2324ee694b67dbd7f2c2c97230e20e8527711209..d46ec6cf6814fbf7dd3c990eb160c0a5b33da733 100644 (file)
@@ -54,6 +54,8 @@
 #include "serv_network.h"
 #include "threads.h"
 
+#include "ctdl_module.h"
+
 long config_msgnum;
 struct addresses_to_be_filed *atbf = NULL;
 
@@ -89,7 +91,8 @@ char *msgkeys[] = {
        "hnod",
        "msgn",
        "jrnl",
-       NULL, NULL,
+       NULL,
+       "list",
        "text",
        "node",
        "room",
@@ -297,6 +300,8 @@ int CtdlMsgCmp(struct CtdlMessage *msg, struct CtdlMessage *template) {
        for (i='A'; i<='Z'; ++i) {
                if (template->cm_fields[i] != NULL) {
                        if (msg->cm_fields[i] == NULL) {
+                               /* Considered equal if temmplate is empty string */
+                               if (IsEmptyStr(template->cm_fields[i])) continue;
                                return 1;
                        }
                        if (strcasecmp(msg->cm_fields[i],
@@ -334,40 +339,47 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums,
                int target_setting, int which_set,
                struct ctdluser *which_user, struct ctdlroom *which_room) {
        struct cdbdata *cdbfr;
-       int i, j, k;
+       int i, k;
        int is_seen = 0;
        int was_seen = 0;
        long lo = (-1L);
        long hi = (-1L);
-       long t = (-1L);
-       int trimming = 0;
        struct visit vbuf;
        long *msglist;
        int num_msgs = 0;
-       char vset[SIZ];
+       StrBuf *vset;
+       StrBuf *setstr;
+       StrBuf *lostr;
+       StrBuf *histr;
+       const char *pvset;
        char *is_set;   /* actually an array of booleans */
-       int num_sets;
-       int s;
-       char setstr[SIZ], lostr[SIZ], histr[SIZ];
-       size_t tmp;
 
        /* Don't bother doing *anything* if we were passed a list of zero messages */
        if (num_target_msgnums < 1) {
                return;
        }
 
-       CtdlLogPrintf(CTDL_DEBUG, "CtdlSetSeen(%d msgs starting with %ld, %d, %d)\n",
+       /* If no room was specified, we go with the current room. */
+       if (!which_room) {
+               which_room = &CC->room;
+       }
+
+       /* If no user was specified, we go with the current user. */
+       if (!which_user) {
+               which_user = &CC->user;
+       }
+
+       CtdlLogPrintf(CTDL_DEBUG, "CtdlSetSeen(%d msgs starting with %ld, %s, %d) in <%s>\n",
                num_target_msgnums, target_msgnums[0],
-               target_setting, which_set);
+               (target_setting ? "SET" : "CLEAR"),
+               which_set,
+               which_room->QRname);
 
        /* Learn about the user and room in question */
-       CtdlGetRelationship(&vbuf,
-               ((which_user != NULL) ? which_user : &CC->user),
-               ((which_room != NULL) ? which_room : &CC->room)
-       );
+       CtdlGetRelationship(&vbuf, which_user, which_room);
 
        /* Load the message list */
-       cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
+       cdbfr = cdb_fetch(CDB_MSGLISTS, &which_room->QRnumber, sizeof(long));
        if (cdbfr != NULL) {
                msglist = (long *) cdbfr->ptr;
                cdbfr->ptr = NULL;      /* CtdlSetSeen() now owns this memory */
@@ -382,33 +394,52 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums,
 
        /* Decide which message set we're manipulating */
        switch(which_set) {
-               case ctdlsetseen_seen:
-                       safestrncpy(vset, vbuf.v_seen, sizeof vset);
-                       break;
-               case ctdlsetseen_answered:
-                       safestrncpy(vset, vbuf.v_answered, sizeof vset);
-                       break;
+       case ctdlsetseen_seen:
+               vset = NewStrBufPlain(vbuf.v_seen, -1);
+               break;
+       case ctdlsetseen_answered:
+               vset = NewStrBufPlain(vbuf.v_answered, -1);
+               break;
+       default:
+               vset = NewStrBuf();
        }
 
-       /* CtdlLogPrintf(CTDL_DEBUG, "before optimize: %s\n", vset); */
+
+#if 0  /* This is a special diagnostic section.  Do not allow it to run during normal operation. */
+       CtdlLogPrintf(CTDL_DEBUG, "There are %d messages in the room.\n", num_msgs);
+       for (i=0; i<num_msgs; ++i) {
+               if ((i > 0) && (msglist[i] <= msglist[i-1])) abort();
+       }
+       CtdlLogPrintf(CTDL_DEBUG, "We are twiddling %d of them.\n", num_target_msgnums);
+       for (k=0; k<num_target_msgnums; ++k) {
+               if ((k > 0) && (target_msgnums[k] <= target_msgnums[k-1])) abort();
+       }
+#endif
+
+       CtdlLogPrintf(CTDL_DEBUG, "before update: %s\n", ChrPtr(vset));
 
        /* Translate the existing sequence set into an array of booleans */
-       num_sets = num_tokens(vset, ',');
-       for (s=0; s<num_sets; ++s) {
-               extract_token(setstr, vset, s, ',', sizeof setstr);
-
-               extract_token(lostr, setstr, 0, ':', sizeof lostr);
-               if (num_tokens(setstr, ':') >= 2) {
-                       extract_token(histr, setstr, 1, ':', sizeof histr);
-                       if (!strcmp(histr, "*")) {
-                               snprintf(histr, sizeof histr, "%ld", LONG_MAX);
-                       }
+       setstr = NewStrBuf();
+       lostr = NewStrBuf();
+       histr = NewStrBuf();
+       pvset = NULL;
+       while (StrBufExtract_NextToken(setstr, vset, &pvset, ',') >= 0) {
+
+               StrBufExtract_token(lostr, setstr, 0, ':');
+               if (StrBufNum_tokens(setstr, ':') >= 2) {
+                       StrBufExtract_token(histr, setstr, 1, ':');
+               }
+               else {
+                       FlushStrBuf(histr);
+                       StrBufAppendBuf(histr, lostr, 0);
+               }
+               lo = StrTol(lostr);
+               if (!strcmp(ChrPtr(histr), "*")) {
+                       hi = LONG_MAX;
                }
                else {
-                       strcpy(histr, lostr);
+                       hi = StrTol(histr);
                }
-               lo = atol(lostr);
-               hi = atol(histr);
 
                for (i = 0; i < num_msgs; ++i) {
                        if ((msglist[i] >= lo) && (msglist[i] <= hi)) {
@@ -416,85 +447,114 @@ void CtdlSetSeen(long *target_msgnums, int num_target_msgnums,
                        }
                }
        }
+       FreeStrBuf(&setstr);
+       FreeStrBuf(&lostr);
+       FreeStrBuf(&histr);
+
 
        /* Now translate the array of booleans back into a sequence set */
-       strcpy(vset, "");
-       lo = (-1L);
-       hi = (-1L);
+       FlushStrBuf(vset);
+       was_seen = 0;
+       lo = (-1);
+       hi = (-1);
 
        for (i=0; i<num_msgs; ++i) {
+               is_seen = is_set[i];
 
-               is_seen = is_set[i];    /* Default to existing setting */
-
+               /* Apply changes */
                for (k=0; k<num_target_msgnums; ++k) {
                        if (msglist[i] == target_msgnums[k]) {
                                is_seen = target_setting;
                        }
                }
 
-               if (is_seen) {
-                       if (lo < 0L) lo = msglist[i];
-                       hi = msglist[i];
+               if ((was_seen == 0) && (is_seen == 1)) {
+                       lo = msglist[i];
                }
+               else if ((was_seen == 1) && (is_seen == 0)) {
+                       hi = msglist[i-1];
 
-               if (  ((is_seen == 0) && (was_seen == 1))
-                  || ((is_seen == 1) && (i == num_msgs-1)) ) {
-
-                       /* begin trim-o-matic code */
-                       j=9;
-                       trimming = 0;
-                       while ( (strlen(vset) + 20) > sizeof vset) {
-                               remove_token(vset, 0, ',');
-                               trimming = 1;
-                               if (j--) break; /* loop no more than 9 times */
+                       if (StrLength(vset) > 0) {
+                               StrBufAppendBufPlain(vset, HKEY(","), 0);
                        }
-                       if ( (trimming) && (which_set == ctdlsetseen_seen) ) {
-                               t = atol(vset);
-                               if (t<2) t=2;
-                               --t;
-                               snprintf(lostr, sizeof lostr,
-                                       "1:%ld,%s", t, vset);
-                               safestrncpy(vset, lostr, sizeof vset);
+                       if (lo == hi) {
+                               StrBufAppendPrintf(vset, "%ld", hi);
+                       }
+                       else {
+                               StrBufAppendPrintf(vset, "%ld:%ld", lo, hi);
                        }
-                       /* end trim-o-matic code */
+               }
 
-                       tmp = strlen(vset);
-                       if (tmp > 0) {
-                               strcat(vset, ",");
-                               ++tmp;
+               if ((is_seen) && (i == num_msgs - 1)) {
+                       if (StrLength(vset) > 0) {
+                               StrBufAppendBufPlain(vset, HKEY(","), 0);
                        }
-                       if (lo == hi) {
-                               snprintf(&vset[tmp], (sizeof vset) - tmp,
-                                        "%ld", lo);
+                       if ((i==0) || (was_seen == 0)) {
+                               StrBufAppendPrintf(vset, "%ld", msglist[i]);
                        }
                        else {
-                               snprintf(&vset[tmp], (sizeof vset) - tmp,
-                                        "%ld:%ld", lo, hi);
+                               StrBufAppendPrintf(vset, "%ld:%ld", lo, msglist[i]);
                        }
-                       lo = (-1L);
-                       hi = (-1L);
                }
+
                was_seen = is_seen;
        }
 
+       /*
+        * We will have to stuff this string back into a 4096 byte buffer, so if it's
+        * larger than that now, truncate it by removing tokens from the beginning.
+        * The limit of 100 iterations is there to prevent an infinite loop in case
+        * something unexpected happens.
+        */
+       int number_of_truncations = 0;
+       while ( (StrLength(vset) > SIZ) && (number_of_truncations < 100) ) {
+               StrBufRemove_token(vset, 0, ',');
+               ++number_of_truncations;
+       }
+
+       /*
+        * If we're truncating the sequence set of messages marked with the 'seen' flag,
+        * we want the earliest messages (the truncated ones) to be marked, not unmarked.
+        * Otherwise messages at the beginning will suddenly appear to be 'unseen'.
+        */
+       if ( (which_set == ctdlsetseen_seen) && (number_of_truncations > 0) ) {
+               StrBuf *first_tok;
+               first_tok = NewStrBuf();
+               StrBufExtract_token(first_tok, vset, 0, ',');
+               StrBufRemove_token(vset, 0, ',');
+
+               if (StrBufNum_tokens(first_tok, ':') > 1) {
+                       StrBufRemove_token(first_tok, 0, ':');
+               }
+               
+               StrBuf *new_set;
+               new_set = NewStrBuf();
+               StrBufAppendBufPlain(new_set, HKEY("1:"), 0);
+               StrBufAppendBuf(new_set, first_tok, 0);
+               StrBufAppendBufPlain(new_set, HKEY(":"), 0);
+               StrBufAppendBuf(new_set, vset, 0);
+
+               FreeStrBuf(&vset);
+               FreeStrBuf(&first_tok);
+               vset = new_set;
+       }
+
+       CtdlLogPrintf(CTDL_DEBUG, " after update: %s\n", ChrPtr(vset));
+
        /* Decide which message set we're manipulating */
        switch (which_set) {
                case ctdlsetseen_seen:
-                       safestrncpy(vbuf.v_seen, vset, sizeof vbuf.v_seen);
+                       safestrncpy(vbuf.v_seen, ChrPtr(vset), sizeof vbuf.v_seen);
                        break;
                case ctdlsetseen_answered:
-                       safestrncpy(vbuf.v_answered, vset,
-                                               sizeof vbuf.v_answered);
+                       safestrncpy(vbuf.v_answered, ChrPtr(vset), sizeof vbuf.v_answered);
                        break;
        }
-       free(is_set);
 
-       /* CtdlLogPrintf(CTDL_DEBUG, " after optimize: %s\n", vset); */
+       free(is_set);
        free(msglist);
-       CtdlSetRelationship(&vbuf,
-               ((which_user != NULL) ? which_user : &CC->user),
-               ((which_room != NULL) ? which_room : &CC->room)
-       );
+       CtdlSetRelationship(&vbuf, which_user, which_room);
+       FreeStrBuf(&vset);
 }
 
 
@@ -527,7 +587,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string,
        int need_to_free_re = 0;
        regmatch_t pm;
 
-       if (content_type) if (!IsEmptyStr(content_type)) {
+       if ((content_type) && (!IsEmptyStr(content_type))) {
                regcomp(&re, content_type, 0);
                need_to_free_re = 1;
        }
@@ -555,7 +615,7 @@ int CtdlForEachMessage(int mode, long ref, char *search_string,
                /* If the caller is looking for a specific MIME type, filter
                 * out all messages which are not of the type requested.
                 */
-               if (content_type != NULL) if (!IsEmptyStr(content_type)) {
+               if ((content_type != NULL) && (!IsEmptyStr(content_type))) {
 
                        /* This call to GetMetaData() sits inside this loop
                         * so that we only do the extra database read per msg
@@ -901,14 +961,14 @@ void memfmout(
  */
 void list_this_part(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-                   void *cbuserdata)
+                   char *cbid, void *cbuserdata)
 {
        struct ma_info *ma;
        
        ma = (struct ma_info *)cbuserdata;
        if (ma->is_ma == 0) {
-               cprintf("part=%s|%s|%s|%s|%s|%ld\n",
-                       name, filename, partnum, disp, cbtype, (long)length);
+               cprintf("part=%s|%s|%s|%s|%s|%ld|%s\n",
+                       name, filename, partnum, disp, cbtype, (long)length, cbid);
        }
 }
 
@@ -917,7 +977,7 @@ void list_this_part(char *name, char *filename, char *partnum, char *disp,
  */
 void list_this_pref(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-                   void *cbuserdata)
+                   char *cbid, void *cbuserdata)
 {
        struct ma_info *ma;
        
@@ -936,7 +996,7 @@ void list_this_pref(char *name, char *filename, char *partnum, char *disp,
  */
 void list_this_suff(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-                   void *cbuserdata)
+                   char *cbid, void *cbuserdata)
 {
        struct ma_info *ma;
        
@@ -955,47 +1015,55 @@ void list_this_suff(char *name, char *filename, char *partnum, char *disp,
  */
 void mime_download(char *name, char *filename, char *partnum, char *disp,
                   void *content, char *cbtype, char *cbcharset, size_t length,
-                  char *encoding, void *cbuserdata)
+                  char *encoding, char *cbid, void *cbuserdata)
 {
+       int rv = 0;
 
-       /* Silently go away if there's already a download open... */
+       /* Silently go away if there's already a download open. */
        if (CC->download_fp != NULL)
                return;
 
-       /* ...or if this is not the desired section */
-       if (strcasecmp(CC->download_desired_section, partnum))
-               return;
-
-       CC->download_fp = tmpfile();
-       if (CC->download_fp == NULL)
-               return;
-
-       fwrite(content, length, 1, CC->download_fp);
-       fflush(CC->download_fp);
-       rewind(CC->download_fp);
-
-       OpenCmdResult(filename, cbtype);
+       if (
+               (!IsEmptyStr(partnum) && (!strcasecmp(CC->download_desired_section, partnum)))
+       ||      (!IsEmptyStr(cbid) && (!strcasecmp(CC->download_desired_section, cbid)))
+       ) {
+               CC->download_fp = tmpfile();
+               if (CC->download_fp == NULL)
+                       return;
+       
+               rv = fwrite(content, length, 1, CC->download_fp);
+               fflush(CC->download_fp);
+               rewind(CC->download_fp);
+       
+               OpenCmdResult(filename, cbtype);
+       }
 }
 
 
 
 /*
- * Callback function for mime parser that outputs a section all at once
+ * Callback function for mime parser that outputs a section all at once.
+ * We can specify the desired section by part number *or* content-id.
  */
 void mime_spew_section(char *name, char *filename, char *partnum, char *disp,
                   void *content, char *cbtype, char *cbcharset, size_t length,
-                  char *encoding, void *cbuserdata)
+                  char *encoding, char *cbid, void *cbuserdata)
 {
        int *found_it = (int *)cbuserdata;
 
-       /* ...or if this is not the desired section */
-       if (strcasecmp(CC->download_desired_section, partnum))
-               return;
-
-       *found_it = 1;
-
-       cprintf("%d %d\n", BINARY_FOLLOWS, (int)length);
-       client_write(content, length);
+       if (
+               (!IsEmptyStr(partnum) && (!strcasecmp(CC->download_desired_section, partnum)))
+       ||      (!IsEmptyStr(cbid) && (!strcasecmp(CC->download_desired_section, cbid)))
+       ) {
+               *found_it = 1;
+               cprintf("%d %d|-1|%s|%s\n",
+                       BINARY_FOLLOWS,
+                       (int)length,
+                       filename,
+                       cbtype
+               );
+               client_write(content, length);
+       }
 }
 
 
@@ -1137,7 +1205,7 @@ void CtdlFreeMessage(struct CtdlMessage *msg)
  */
 void fixed_output_pre(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
-               void *cbuserdata)
+               char *cbid, void *cbuserdata)
 {
        struct ma_info *ma;
        
@@ -1157,7 +1225,7 @@ void fixed_output_pre(char *name, char *filename, char *partnum, char *disp,
  */
 void fixed_output_post(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        struct ma_info *ma;
        
@@ -1177,7 +1245,7 @@ void fixed_output_post(char *name, char *filename, char *partnum, char *disp,
  */
 void fixed_output(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        char *ptr;
        char *wptr;
@@ -1250,7 +1318,7 @@ void fixed_output(char *name, char *filename, char *partnum, char *disp,
  */
 void choose_preferred(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        char buf[1024];
        int i;
@@ -1280,7 +1348,7 @@ void choose_preferred(char *name, char *filename, char *partnum, char *disp,
  */
 void output_preferred(char *name, char *filename, char *partnum, char *disp,
                void *content, char *cbtype, char *cbcharset, size_t length,
-               char *encoding, void *cbuserdata)
+               char *encoding, char *cbid, void *cbuserdata)
 {
        int i;
        char buf[128];
@@ -1328,7 +1396,7 @@ void output_preferred(char *name, char *filename, char *partnum, char *disp,
        /* No translations required or possible: output as text/plain */
        cprintf("Content-type: text/plain\n\n");
        fixed_output(name, filename, partnum, disp, content, cbtype, cbcharset,
-                       length, encoding, cbuserdata);
+                       length, encoding, cbid, cbuserdata);
 }
 
 
@@ -1344,7 +1412,7 @@ struct encapmsg {
  */
 void extract_encapsulated_message(char *name, char *filename, char *partnum, char *disp,
                   void *content, char *cbtype, char *cbcharset, size_t length,
-                  char *encoding, void *cbuserdata)
+                  char *encoding, char *cbid, void *cbuserdata)
 {
        struct encapmsg *encap;
 
@@ -1373,7 +1441,7 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
                  int do_proto,         /* do Citadel protocol responses? */
                  int crlf,             /* Use CRLF newlines instead of LF? */
                  char *section,        /* NULL or a message/rfc822 section */
-                 int flags             /* should the bessage be exported clean? */
+                 int flags             /* various flags; see msgbase.h */
 ) {
        struct CtdlMessage *TheMessage = NULL;
        int retcode = om_no_such_msg;
@@ -1393,11 +1461,10 @@ int CtdlOutputMsg(long msg_num,         /* message number (local) to fetch */
        /* FIXME: check message id against msglist for this room */
 
        /*
-        * Fetch the message from disk.  If we're in any sort of headers
-        * only mode, request that we don't even bother loading the body
-        * into memory.
+        * Fetch the message from disk.  If we're in HEADERS_FAST mode,
+        * request that we don't even bother loading the body into memory.
         */
-       if ( (headers_only == HEADERS_FAST) || (headers_only == HEADERS_ONLY) ) {
+       if (headers_only == HEADERS_FAST) {
                TheMessage = CtdlFetchMessage(msg_num, 0);
        }
        else {
@@ -1568,6 +1635,31 @@ char *qp_encode_email_addrs(char *source)
 }
 
 
+/* If the last item in a list of recipients was truncated to a partial address,
+ * remove it completely in order to avoid choking libSieve
+ */
+void sanitize_truncated_recipient(char *str)
+{
+       if (!str) return;
+       if (num_tokens(str, ',') < 2) return;
+
+       int len = strlen(str);
+       if (len < 900) return;
+       if (len > 998) str[998] = 0;
+
+       char *cptr = strrchr(str, ',');
+       if (!cptr) return;
+
+       char *lptr = strchr(cptr, '<');
+       char *rptr = strchr(cptr, '>');
+
+       if ( (lptr) && (rptr) && (rptr > lptr) ) return;
+
+       *cptr = 0;
+}
+
+
+
 /*
  * Get a message off disk.  (returns om_* values found in msgbase.h)
  */
@@ -1598,7 +1690,6 @@ int CtdlOutputPreLoadedMsg(
        char luser[100];
        char fuser[100];
        char snode[100];
-       char lnode[100];
        char mid[100];
        char datestamp[100];
 
@@ -1616,6 +1707,13 @@ int CtdlOutputPreLoadedMsg(
                return(om_no_such_msg);
        }
 
+       /* Suppress envelope recipients if required to avoid disclosing BCC addresses.
+        * Pad it with spaces in order to avoid changing the RFC822 length of the message.
+        */
+       if ( (flags & SUPPRESS_ENV_TO) && (TheMessage->cm_fields['V'] != NULL) ) {
+               memset(TheMessage->cm_fields['V'], ' ', strlen(TheMessage->cm_fields['V']));
+       }
+               
        /* Are we downloading a MIME component? */
        if (mode == MT_DOWNLOAD) {
                if (TheMessage->cm_format_type != FMT_RFC822) {
@@ -1682,7 +1780,7 @@ int CtdlOutputPreLoadedMsg(
 
        /* nhdr=yes means that we're only displaying headers, no body */
        if ( (TheMessage->cm_anon_type == MES_ANONONLY)
-          && (mode == MT_CITADEL)
+          && ((mode == MT_CITADEL) || (mode == MT_MIME))
           && (do_proto)
           ) {
                cprintf("nhdr=yes\n");
@@ -1723,7 +1821,7 @@ int CtdlOutputPreLoadedMsg(
                      if (haschar(TheMessage->cm_fields['N'], '.') == 0) {
                        suppress_f = 1;
                }
-               
+
                /* Now spew the header fields in the order we like them. */
                safestrncpy(allkeys, FORDER, sizeof allkeys);
                for (i=0; i<strlen(allkeys); ++i) {
@@ -1731,6 +1829,9 @@ int CtdlOutputPreLoadedMsg(
                        if (k != 'M') {
                                if ( (TheMessage->cm_fields[k] != NULL)
                                   && (msgkeys[k] != NULL) ) {
+                                       if ((k == 'V') || (k == 'R') || (k == 'Y')) {
+                                               sanitize_truncated_recipient(TheMessage->cm_fields[k]);
+                                       }
                                        if (k == 'A') {
                                                if (do_proto) cprintf("%s=%s\n",
                                                        msgkeys[k],
@@ -1758,7 +1859,6 @@ int CtdlOutputPreLoadedMsg(
        strcpy(luser, "");
        strcpy(fuser, "");
        strcpy(snode, NODENAME);
-       strcpy(lnode, HUMANNODE);
        if (mode == MT_RFC822) {
                for (i = 0; i < 256; ++i) {
                        if (TheMessage->cm_fields[i]) {
@@ -1769,8 +1869,10 @@ int CtdlOutputPreLoadedMsg(
                                        safestrncpy(suser, mptr, sizeof suser);
                                }
                                else if (i == 'Y') {
-                                       if ((flags & QP_EADDR) != 0) 
+                                       if ((flags & QP_EADDR) != 0) {
                                                mptr = qp_encode_email_addrs(mptr);
+                                       }
+                                       sanitize_truncated_recipient(mptr);
                                        cprintf("CC: %s%s", mptr, nl);
                                }
                                else if (i == 'P') {
@@ -1790,8 +1892,6 @@ int CtdlOutputPreLoadedMsg(
                                }
                                else if (i == 'I')
                                        safestrncpy(mid, mptr, sizeof mid);
-                               else if (i == 'H')
-                                       safestrncpy(lnode, mptr, sizeof lnode);
                                else if (i == 'F')
                                        safestrncpy(fuser, mptr, sizeof fuser);
                                /* else if (i == 'O')
@@ -1803,13 +1903,18 @@ int CtdlOutputPreLoadedMsg(
                                {
                                        if (haschar(mptr, '@') == 0)
                                        {
-                                               cprintf("To: %s@%s%s", mptr, config.c_fqdn, nl);
+                                               sanitize_truncated_recipient(mptr);
+                                               cprintf("To: %s@%s", mptr, config.c_fqdn);
+                                               cprintf("%s", nl);
                                        }
                                        else
                                        {
-                                               if ((flags & QP_EADDR) != 0) 
+                                               if ((flags & QP_EADDR) != 0) {
                                                        mptr = qp_encode_email_addrs(mptr);
-                                               cprintf("To: %s%s", mptr, nl);
+                                               }
+                                               sanitize_truncated_recipient(mptr);
+                                               cprintf("To: %s", mptr);
+                                               cprintf("%s", nl);
                                        }
                                }
                                else if (i == 'T') {
@@ -1870,8 +1975,6 @@ int CtdlOutputPreLoadedMsg(
                        cprintf("From: \"%s\" <%s@%s>%s", luser, suser, snode, nl);
                }
 
-               cprintf("Organization: %s%s", lnode, nl);
-
                /* Blank line signifying RFC822 end-of-headers */
                if (TheMessage->cm_format_type != FMT_RFC822) {
                        cprintf("%s", nl);
@@ -2207,7 +2310,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
        if (num_newmsgs > 1) supplied_msg = NULL;
 
        /* Now the regular stuff */
-       if (lgetroom(&CC->room,
+       if (CtdlGetRoomLock(&CC->room,
           ((roomname != NULL) ? roomname : CC->room.QRname) )
           != 0) {
                CtdlLogPrintf(CTDL_ERR, "No such room <%s>\n", roomname);
@@ -2274,7 +2377,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
 
        /* Update the highest-message pointer and unlock the room. */
        CC->room.QRhighest = highest_msg;
-       lputroom(&CC->room);
+       CtdlPutRoomLock(&CC->room);
 
        /* Perform replication checks if necessary */
        if ( (DoesThisRoomNeedEuidIndexing(&CC->room)) && (do_repl_check) ) {
@@ -2315,7 +2418,7 @@ int CtdlSaveMsgPointersInRoom(char *roomname, long newmsgidlist[], int num_newms
        PerformRoomHooks(&CC->room);
 
        /* Go back to the room we were in before we wandered here... */
-       getroom(&CC->room, hold_rm);
+       CtdlGetRoom(&CC->room, hold_rm);
 
        /* Bump the reference count for all messages which were merged */
        for (i=0; i<num_msgs_to_be_merged; ++i) {
@@ -2575,6 +2678,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        int qualified_for_journaling = 0;
        struct CitContext *CCC = CC;            /* CachedCitContext - performance boost */
        char bounce_to[1024] = "";
+       size_t tmp = 0;
+       int rv = 0;
 
        CtdlLogPrintf(CTDL_DEBUG, "CtdlSubmitMsg() called\n");
        if (is_valid_message(msg) == 0) return(-1);     /* self check */
@@ -2667,8 +2772,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
 
        CtdlLogPrintf(CTDL_DEBUG, "Final selection: %s\n", actual_rm);
        if (strcasecmp(actual_rm, CCC->room.QRname)) {
-               /* getroom(&CCC->room, actual_rm); */
-               usergoto(actual_rm, 0, 1, NULL, NULL);
+               /* CtdlGetRoom(&CCC->room, actual_rm); */
+               CtdlUserGoto(actual_rm, 0, 1, NULL, NULL);
        }
 
        /*
@@ -2747,14 +2852,12 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
        }
 
        /* For internet mail, drop a copy in the outbound queue room */
-       if (recps != NULL)
-        if (recps->num_internet > 0) {
+       if ((recps != NULL) && (recps->num_internet > 0)) {
                CtdlSaveMsgPointerInRoom(SMTP_SPOOLOUT_ROOM, newmsgid, 0, msg);
        }
 
        /* If other rooms are specified, drop them there too. */
-       if (recps != NULL)
-        if (recps->num_room > 0)
+       if ((recps != NULL) && (recps->num_room > 0))
          for (i=0; i<num_tokens(recps->recp_room, '|'); ++i) {
                extract_token(recipient, recps->recp_room, i,
                                        '|', sizeof recipient);
@@ -2769,7 +2872,10 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,      /* message to save */
        lputuser(&CCC->user);
 
        /* Decide where bounces need to be delivered */
-       if (CCC->logged_in) {
+       if ((recps != NULL) && (recps->bounce_to != NULL)) {
+               safestrncpy(bounce_to, recps->bounce_to, sizeof bounce_to);
+       }
+       else if (CCC->logged_in) {
                snprintf(bounce_to, sizeof bounce_to, "%s@%s", CCC->user.fullname, config.c_nodename);
        }
        else {
@@ -2779,8 +2885,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        /* If this is private, local mail, make a copy in the
         * recipient's mailbox and bump the reference count.
         */
-       if (recps != NULL)
-        if (recps->num_local > 0)
+       if ((recps != NULL) && (recps->num_local > 0))
          for (i=0; i<num_tokens(recps->recp_local, '|'); ++i) {
                extract_token(recipient, recps->recp_local, i,
                                        '|', sizeof recipient);
@@ -2837,8 +2942,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
         * node.  We'll revisit this again in a year or so when everyone has
         * a network spool receiver that can handle the new style messages.
         */
-       if (recps != NULL)
-        if (recps->num_ignet > 0)
+       if ((recps != NULL) && (recps->num_ignet > 0))
          for (i=0; i<num_tokens(recps->recp_ignet, '|'); ++i) {
                extract_token(recipient, recps->recp_ignet, i,
                                '|', sizeof recipient);
@@ -2858,7 +2962,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                                         (long) getpid(), CCC->cs_pid, ++seqnum);
                        network_fp = fopen(submit_filename, "wb+");
                        if (network_fp != NULL) {
-                               fwrite(smr.ser, smr.len, 1, network_fp);
+                               rv = fwrite(smr.ser, smr.len, 1, network_fp);
                                fclose(network_fp);
                        }
                        free(smr.ser);
@@ -2873,15 +2977,14 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
        /* Go back to the room we started from */
        CtdlLogPrintf(CTDL_DEBUG, "Returning to original room %s\n", hold_rm);
        if (strcasecmp(hold_rm, CCC->room.QRname))
-               usergoto(hold_rm, 0, 1, NULL, NULL);
+               CtdlUserGoto(hold_rm, 0, 1, NULL, NULL);
 
        /* For internet mail, generate delivery instructions.
         * Yes, this is recursive.  Deal with it.  Infinite recursion does
         * not happen because the delivery instructions message does not
         * contain a recipient.
         */
-       if (recps != NULL)
-        if (recps->num_internet > 0) {
+       if ((recps != NULL) && (recps->num_internet > 0)) {
                CtdlLogPrintf(CTDL_DEBUG, "Generating delivery instructions\n");
                instr_alloc = 1024;
                instr = malloc(instr_alloc);
@@ -2892,8 +2995,13 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,      /* message to save */
                        bounce_to
                );
 
+               if (recps->envelope_from != NULL) {
+                       tmp = strlen(instr);
+                       snprintf(&instr[tmp], instr_alloc-tmp, "envelope_from|%s\n", recps->envelope_from);
+               }
+
                for (i=0; i<num_tokens(recps->recp_internet, '|'); ++i) {
-                       size_t tmp = strlen(instr);
+                       tmp = strlen(instr);
                        extract_token(recipient, recps->recp_internet, i, '|', sizeof recipient);
                        if ((tmp + strlen(recipient) + 32) > instr_alloc) {
                                instr_alloc = instr_alloc * 2;
@@ -2977,8 +3085,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
 /*
  * Convenience function for generating small administrative messages.
  */
-void quickie_message(char *from, char *fromaddr, char *to, char *room, char *text, 
-                       int format_type, char *subject)
+void quickie_message(const char *from, const char *fromaddr, char *to, char *room, const char *text, 
+                       int format_type, const char *subject)
 {
        struct CtdlMessage *msg;
        struct recptypes *recp = NULL;
@@ -3160,8 +3268,8 @@ struct CtdlMessage *CtdlMakeMessage(
        /* Don't confuse the poor folks if it's not routed mail. */
        strcpy(dest_node, "");
 
-       striplt(recipient);
-       striplt(recp_cc);
+       if (recipient != NULL) striplt(recipient);
+       if (recp_cc != NULL) striplt(recp_cc);
 
        /* Path or Return-Path */
        if (my_email == NULL) my_email = "";
@@ -3178,10 +3286,12 @@ struct CtdlMessage *CtdlMakeMessage(
        snprintf(buf, sizeof buf, "%ld", (long)time(NULL));     /* timestamp */
        msg->cm_fields['T'] = strdup(buf);
 
-       if (fake_name[0])                                       /* author */
+       if ((fake_name != NULL) && (fake_name[0])) {            /* author */
                msg->cm_fields['A'] = strdup(fake_name);
-       else
+       }
+       else {
                msg->cm_fields['A'] = strdup(author->fullname);
+       }
 
        if (CC->room.QRflags & QR_MAILBOX) {            /* room */
                msg->cm_fields['O'] = strdup(&CC->room.QRname[11]);
@@ -3193,10 +3303,10 @@ struct CtdlMessage *CtdlMakeMessage(
        msg->cm_fields['N'] = strdup(NODENAME);         /* nodename */
        msg->cm_fields['H'] = strdup(HUMANNODE);                /* hnodename */
 
-       if (recipient[0] != 0) {
+       if ((recipient != NULL) && (recipient[0] != 0)) {
                msg->cm_fields['R'] = strdup(recipient);
        }
-       if (recp_cc[0] != 0) {
+       if ((recp_cc != NULL) && (recp_cc[0] != 0)) {
                msg->cm_fields['Y'] = strdup(recp_cc);
        }
        if (dest_node[0] != 0) {
@@ -3479,7 +3589,7 @@ struct recptypes *validate_recipients(char *supplied_recipients,
                                        strcat(ret->recp_room, this_recp);
                                }
                                else if ( (!strncasecmp(this_recp, "room_", 5))
-                                     && (!getroom(&tempQR, &this_recp_cooked[5])) ) {
+                                     && (!CtdlGetRoom(&tempQR, &this_recp_cooked[5])) ) {
 
                                        /* Save room so we can restore it later */
                                        tempQR2 = CC->room;
@@ -3625,6 +3735,8 @@ void free_recipients(struct recptypes *valid) {
        if (valid->recp_ignet != NULL)          free(valid->recp_ignet);
        if (valid->recp_room != NULL)           free(valid->recp_room);
        if (valid->display_recp != NULL)        free(valid->display_recp);
+       if (valid->bounce_to != NULL)           free(valid->bounce_to);
+       if (valid->envelope_from != NULL)       free(valid->envelope_from);
        free(valid);
 }
 
@@ -3847,9 +3959,9 @@ void cmd_ent0(char *entargs)
         * is set, or if there is one or more Internet email recipients.
         */
        if (CC->room.QRflags2 & QR2_SUBJECTREQ) subject_required = 1;
-       if (valid_to) if (valid_to->num_internet > 0) subject_required = 1;
-       if (valid_cc) if (valid_cc->num_internet > 0) subject_required = 1;
-       if (valid_bcc) if (valid_bcc->num_internet > 0) subject_required = 1;
+       if ((valid_to)  && (valid_to->num_internet > 0))        subject_required = 1;
+       if ((valid_cc)  && (valid_cc->num_internet > 0))        subject_required = 1;
+       if ((valid_bcc) && (valid_bcc->num_internet > 0))       subject_required = 1;
 
        /* If we're only checking the validity of the request, return
         * success without creating the message.
@@ -3967,7 +4079,7 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
                room_name, num_dmsgnums, content_type);
 
        /* get room record, obtaining a lock... */
-       if (lgetroom(&qrbuf, room_name) != 0) {
+       if (CtdlGetRoomLock(&qrbuf, room_name) != 0) {
                CtdlLogPrintf(CTDL_ERR, "CtdlDeleteMessages(): Room <%s> not found\n",
                        room_name);
                if (need_to_free_re) regfree(&re);
@@ -4024,7 +4136,7 @@ int CtdlDeleteMessages(char *room_name,           /* which room */
 
                qrbuf.QRhighest = msglist[num_msgs - 1];
        }
-       lputroom(&qrbuf);
+       CtdlPutRoomLock(&qrbuf);
 
        /* Go through the messages we pulled out of the index, and decrement
         * their reference counts by 1.  If this is the only room the message
@@ -4109,19 +4221,6 @@ void cmd_dele(char *args)
 }
 
 
-/*
- * Back end API function for moves and deletes (multiple messages)
- */
-int CtdlCopyMsgsToRoom(long *msgnums, int num_msgs, char *dest) {
-       int err;
-
-       err = CtdlSaveMsgPointersInRoom(dest, msgnums, num_msgs, 1, NULL);
-       if (err != 0) return(err);
-
-       return(0);
-}
-
-
 
 
 /*
@@ -4154,9 +4253,13 @@ void cmd_move(char *args)
        targ[ROOMNAMELEN - 1] = 0;
        is_copy = extract_int(args, 2);
 
-       if (getroom(&qtemp, targ) != 0) {
-               cprintf("%d '%s' does not exist.\n",
-                       ERROR + ROOM_NOT_FOUND, targ);
+       if (CtdlGetRoom(&qtemp, targ) != 0) {
+               cprintf("%d '%s' does not exist.\n", ERROR + ROOM_NOT_FOUND, targ);
+               return;
+       }
+
+       if (!strcasecmp(qtemp.QRname, CC->room.QRname)) {
+               cprintf("%d Source and target rooms are the same.\n", ERROR + ALREADY_EXISTS);
                return;
        }
 
@@ -4211,7 +4314,7 @@ void cmd_move(char *args)
        /*
         * Do the copy
         */
-       err = CtdlCopyMsgsToRoom(msgs, num_msgs, targ);
+       err = CtdlSaveMsgPointersInRoom(targ, msgs, num_msgs, 1, NULL);
        if (err != 0) {
                cprintf("%d Cannot store message(s) in %s: error %d\n",
                        err, targ, err);
@@ -4283,6 +4386,7 @@ void PutMetaData(struct MetaData *smibuf)
 void AdjRefCount(long msgnum, int incr)
 {
        struct arcq new_arcq;
+       int rv = 0;
 
        begin_critical_section(S_SUPPMSGMAIN);
        if (arcfp == NULL) {
@@ -4312,7 +4416,7 @@ void AdjRefCount(long msgnum, int incr)
 
        new_arcq.arcq_msgnum = msgnum;
        new_arcq.arcq_delta = incr;
-       fwrite(&new_arcq, sizeof(struct arcq), 1, arcfp);
+       rv = fwrite(&new_arcq, sizeof(struct arcq), 1, arcfp);
        fflush(arcfp);
 
        return;
@@ -4334,7 +4438,7 @@ int TDAP_ProcessAdjRefCountQueue(void)
        struct arcq arcq_rec;
        int num_records_processed = 0;
 
-       snprintf(file_arcq_temp, sizeof file_arcq_temp, "%s2", file_arcq);
+       snprintf(file_arcq_temp, sizeof file_arcq_temp, "%s.%04x", file_arcq, rand());
 
        begin_critical_section(S_SUPPMSGMAIN);
        if (arcfp != NULL) {
@@ -4397,7 +4501,7 @@ void TDAP_AdjRefCount(long msgnum, int incr)
        smi.meta_refcount += incr;
        PutMetaData(&smi);
        end_critical_section(S_SUPPMSGMAIN);
-       CtdlLogPrintf(CTDL_DEBUG, "msg %ld ref count delta %d, is now %d\n",
+       CtdlLogPrintf(CTDL_DEBUG, "msg %ld ref count delta %+d, is now %d\n",
                msgnum, incr, smi.meta_refcount);
 
        /* If the reference count is now zero, delete the message
@@ -4503,8 +4607,8 @@ void CtdlWriteObject(char *req_room,                      /* Room to stuff it in */
        msg->cm_fields['M'] = encoded_message;
 
        /* Create the requested room if we have to. */
-       if (getroom(&qrbuf, roomname) != 0) {
-               create_room(roomname, 
+       if (CtdlGetRoom(&qrbuf, roomname) != 0) {
+               CtdlCreateRoom(roomname, 
                        ( (is_mailbox != NULL) ? 5 : 3 ),
                        "", 0, 1, 0, VIEW_BBS);
        }
@@ -4539,8 +4643,8 @@ char *CtdlGetSysConfig(char *sysconfname) {
        char buf[SIZ];
        
        strcpy(hold_rm, CC->room.QRname);
-       if (getroom(&CC->room, SYSCONFIGROOM) != 0) {
-               getroom(&CC->room, hold_rm);
+       if (CtdlGetRoom(&CC->room, SYSCONFIGROOM) != 0) {
+               CtdlGetRoom(&CC->room, hold_rm);
                return NULL;
        }
 
@@ -4567,7 +4671,7 @@ char *CtdlGetSysConfig(char *sysconfname) {
                }
        }
 
-       getroom(&CC->room, hold_rm);
+       CtdlGetRoom(&CC->room, hold_rm);
 
        if (conf != NULL) do {
                extract_token(buf, conf, 0, '\n', sizeof buf);
@@ -4629,3 +4733,27 @@ void cmd_isme(char *argbuf) {
        }
 
 }
+
+
+/*****************************************************************************/
+/*                      MODULE INITIALIZATION STUFF                          */
+/*****************************************************************************/
+
+CTDL_MODULE_INIT(msgbase)
+{
+       CtdlRegisterProtoHook(cmd_msgs, "MSGS", "Output a list of messages in the current room");
+       CtdlRegisterProtoHook(cmd_msg0, "MSG0", "Output a message in plain text format");
+       CtdlRegisterProtoHook(cmd_msg2, "MSG2", "Output a message in RFC822 format");
+       CtdlRegisterProtoHook(cmd_msg3, "MSG3", "Output a message in raw format (deprecated)");
+       CtdlRegisterProtoHook(cmd_msg4, "MSG4", "Output a message in the client's preferred format");
+       CtdlRegisterProtoHook(cmd_msgp, "MSGP", "Select preferred format for MSG4 output");
+       CtdlRegisterProtoHook(cmd_opna, "OPNA", "Open an attachment for download");
+       CtdlRegisterProtoHook(cmd_dlat, "DLAT", "Download an attachment");
+       CtdlRegisterProtoHook(cmd_ent0, "ENT0", "Enter a message");
+       CtdlRegisterProtoHook(cmd_dele, "DELE", "Delete a message");
+       CtdlRegisterProtoHook(cmd_move, "MOVE", "Move or copy a message to another room");
+       CtdlRegisterProtoHook(cmd_isme, "ISME", "Determine whether an email address belongs to a user");
+
+        /* return our Subversion id for the Log */
+       return "$Id$";
+}