* Changed the format of the euidindex record to contain the record's key.
[citadel.git] / citadel / msgbase.c
index 941af80b4701ee72df29d73e42543e9cabf94feb..ffddf5c7392bf988f3533429577f60ffa67d14fe 100644 (file)
 #include "genstamp.h"
 #include "internet_addressing.h"
 #include "serv_fulltext.h"
+#include "vcard.h"
+#include "euidindex.h"
 
 long config_msgnum;
-
+struct addresses_to_be_filed *atbf = NULL;
 
 /* 
  * This really belongs in serv_network.c, but I don't know how to export
@@ -97,7 +99,7 @@ char *msgkeys[] = {
        NULL,
        NULL,
        NULL,
-       NULL,
+       "cccc",
        NULL
 };
 
@@ -174,7 +176,7 @@ int alias(char *name)
        fclose(fp);
 
        /* Hit the Global Address Book */
-       if (CtdlDirectoryLookup(aaa, name) == 0) {
+       if (CtdlDirectoryLookup(aaa, name, sizeof aaa) == 0) {
                strcpy(name, aaa);
        }
 
@@ -845,9 +847,13 @@ void list_this_part(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
                    void *cbuserdata)
 {
-
-       cprintf("part=%s|%s|%s|%s|%s|%ld\n",
-               name, filename, partnum, disp, cbtype, (long)length);
+       struct ma_info *ma;
+       
+       ma = (struct ma_info *)cbuserdata;
+       if (ma->is_ma == 0) {
+               cprintf("part=%s|%s|%s|%s|%s|%ld\n",
+                       name, filename, partnum, disp, cbtype, (long)length);
+       }
 }
 
 /* 
@@ -857,7 +863,16 @@ void list_this_pref(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
                    void *cbuserdata)
 {
-       cprintf("pref=%s|%s\n", partnum, cbtype);
+       struct ma_info *ma;
+       
+       ma = (struct ma_info *)cbuserdata;
+       if (!strcasecmp(cbtype, "multipart/alternative")) {
+               ++ma->is_ma;
+       }
+
+       if (ma->is_ma == 0) {
+               cprintf("pref=%s|%s\n", partnum, cbtype);
+       }
 }
 
 /* 
@@ -867,7 +882,15 @@ void list_this_suff(char *name, char *filename, char *partnum, char *disp,
                    void *content, char *cbtype, char *cbcharset, size_t length, char *encoding,
                    void *cbuserdata)
 {
-       cprintf("suff=%s|%s\n", partnum, cbtype);
+       struct ma_info *ma;
+       
+       ma = (struct ma_info *)cbuserdata;
+       if (ma->is_ma == 0) {
+               cprintf("suff=%s|%s\n", partnum, cbtype);
+       }
+       if (!strcasecmp(cbtype, "multipart/alternative")) {
+               --ma->is_ma;
+       }
 }
 
 
@@ -1242,7 +1265,7 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
        }
        
        retcode = CtdlOutputPreLoadedMsg(
-                       TheMessage, msg_num, mode,
+                       TheMessage, mode,
                        headers_only, do_proto, crlf);
 
        CtdlFreeMessage(TheMessage);
@@ -1257,7 +1280,6 @@ int CtdlOutputMsg(long msg_num,           /* message number (local) to fetch */
  */
 int CtdlOutputPreLoadedMsg(
                struct CtdlMessage *TheMessage,
-               long msg_num,
                int mode,               /* how would you like that message? */
                int headers_only,       /* eschew the message body? */
                int do_proto,           /* do Citadel protocol responses? */
@@ -1272,7 +1294,7 @@ int CtdlOutputPreLoadedMsg(
        char *nl;       /* newline string */
        int suppress_f = 0;
        int subject_found = 0;
-       struct ma_info *ma;
+       struct ma_info ma;
 
        /* Buffers needed for RFC822 translation.  These are all filled
         * using functions that are bounds-checked, and therefore we can
@@ -1286,12 +1308,11 @@ int CtdlOutputPreLoadedMsg(
        char mid[100];
        char datestamp[100];
 
-       lprintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %ld, %d, %d, %d, %d\n",
+       lprintf(CTDL_DEBUG, "CtdlOutputPreLoadedMsg(TheMessage=%s, %d, %d, %d, %d\n",
                ((TheMessage == NULL) ? "NULL" : "not null"),
-               msg_num,
                mode, headers_only, do_proto, crlf);
 
-       snprintf(mid, sizeof mid, "%ld", msg_num);
+       strcpy(mid, "unknown");
        nl = (crlf ? "\r\n" : "\n");
 
        if (!is_valid_message(TheMessage)) {
@@ -1313,10 +1334,7 @@ int CtdlOutputPreLoadedMsg(
                } else {
                        /* Parse the message text component */
                        mptr = TheMessage->cm_fields['M'];
-                       ma = malloc(sizeof(struct ma_info));
-                       memset(ma, 0, sizeof(struct ma_info));
-                       mime_parser(mptr, NULL, *mime_download, NULL, NULL, (void *)ma, 0);
-                       free(ma);
+                       mime_parser(mptr, NULL, *mime_download, NULL, NULL, NULL, 0);
                        /* If there's no file open by this time, the requested
                         * section wasn't found, so print an error
                         */
@@ -1331,7 +1349,7 @@ int CtdlOutputPreLoadedMsg(
        }
 
        /* now for the user-mode message reading loops */
-       if (do_proto) cprintf("%d Message %ld:\n", LISTING_FOLLOWS, msg_num);
+       if (do_proto) cprintf("%d msg:\n", LISTING_FOLLOWS);
 
        /* Does the caller want to skip the headers? */
        if (headers_only == HEADERS_NONE) goto START_TEXT;
@@ -1429,6 +1447,9 @@ int CtdlOutputPreLoadedMsg(
                                        safestrncpy(luser, mptr, sizeof luser);
                                        safestrncpy(suser, mptr, sizeof suser);
                                }
+                               else if (i == 'Y') {
+                                       cprintf("CC: %s%s", mptr, nl);
+                               }
                                else if (i == 'U') {
                                        cprintf("Subject: %s%s", mptr, nl);
                                        subject_found = 1;
@@ -1476,19 +1497,15 @@ int CtdlOutputPreLoadedMsg(
                cprintf(">%s", nl);
 
                if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONONLY)) {
-                       // cprintf("From: x@x.org (----)%s", nl);
                        cprintf("From: \"----\" <x@x.org>%s", nl);
                }
                else if (!is_room_aide() && (TheMessage->cm_anon_type == MES_ANONOPT)) {
-                       // cprintf("From: x@x.org (anonymous)%s", nl);
                        cprintf("From: \"anonymous\" <x@x.org>%s", nl);
                }
                else if (strlen(fuser) > 0) {
-                       // cprintf("From: %s (%s)%s", fuser, luser, nl);
                        cprintf("From: \"%s\" <%s>%s", luser, fuser, nl);
                }
                else {
-                       // cprintf("From: %s@%s (%s)%s", suser, snode, luser, nl);
                        cprintf("From: \"%s\" <%s@%s>%s", luser, suser, snode, nl);
                }
 
@@ -1508,53 +1525,44 @@ START_TEXT:
        /* Tell the client about the MIME parts in this message */
        if (TheMessage->cm_format_type == FMT_RFC822) {
                if ( (mode == MT_CITADEL) || (mode == MT_MIME) ) {
+                       memset(&ma, 0, sizeof(struct ma_info));
                        mime_parser(mptr, NULL,
                                (do_proto ? *list_this_part : NULL),
                                (do_proto ? *list_this_pref : NULL),
                                (do_proto ? *list_this_suff : NULL),
-                               NULL, 0);
+                               (void *)&ma, 0);
                }
                else if (mode == MT_RFC822) {   /* unparsed RFC822 dump */
-                       /* FIXME ... we have to put some code in here to avoid
-                        * printing duplicate header information when both
-                        * Citadel and RFC822 headers exist.  Preference should
-                        * probably be given to the RFC822 headers.
-                        */
-                       int done_rfc822_hdrs = 0;
-                       while (ch=*(mptr++), ch!=0) {
+                       char *start_of_text = NULL;
+                       start_of_text = strstr(mptr, "\n\r\n");
+                       if (start_of_text == NULL) start_of_text = strstr(mptr, "\n\n");
+                       if (start_of_text == NULL) start_of_text = mptr;
+                       ++start_of_text;
+                       start_of_text = strstr(start_of_text, "\n");
+                       ++start_of_text;
+                       while (ch=*mptr, ch!=0) {
                                if (ch==13) {
                                        /* do nothing */
                                }
-                               else if (ch==10) {
-                                       if (!done_rfc822_hdrs) {
-                                               if (headers_only != HEADERS_NONE) {
-                                                       cprintf("%s", nl);
-                                               }
-                                       }
-                                       else {
-                                               if (headers_only != HEADERS_ONLY) {
-                                                       cprintf("%s", nl);
-                                               }
-                                       }
-                                       if ((*(mptr) == 13) || (*(mptr) == 10)) {
-                                               done_rfc822_hdrs = 1;
-                                       }
-                               }
-                               else {
-                                       if (done_rfc822_hdrs) {
-                                               if (headers_only != HEADERS_NONE) {
-                                                       cprintf("%c", ch);
+                               else switch(headers_only) {
+                                       case HEADERS_NONE:
+                                               if (mptr >= start_of_text) {
+                                                       if (ch == 10) cprintf("%s", nl);
+                                                       else cprintf("%c", ch);
                                                }
-                                       }
-                                       else {
-                                               if (headers_only != HEADERS_ONLY) {
-                                                       cprintf("%c", ch);
+                                               break;
+                                       case HEADERS_ONLY:
+                                               if (mptr < start_of_text) {
+                                                       if (ch == 10) cprintf("%s", nl);
+                                                       else cprintf("%c", ch);
                                                }
-                                       }
-                                       if ((*mptr == 13) || (*mptr == 10)) {
-                                               done_rfc822_hdrs = 1;
-                                       }
+                                               break;
+                                       default:
+                                               if (ch == 10) cprintf("%s", nl);
+                                               else cprintf("%c", ch);
+                                               break;
                                }
+                               ++mptr;
                        }
                        goto DONE;
                }
@@ -1613,24 +1621,22 @@ START_TEXT:
         * we use will display those parts as-is.
         */
        if (TheMessage->cm_format_type == FMT_RFC822) {
-               ma = malloc(sizeof(struct ma_info));
-               memset(ma, 0, sizeof(struct ma_info));
+               memset(&ma, 0, sizeof(struct ma_info));
 
                if (mode == MT_MIME) {
-                       strcpy(ma->chosen_part, "1");
+                       strcpy(ma.chosen_part, "1");
                        mime_parser(mptr, NULL,
                                *choose_preferred, *fixed_output_pre,
-                               *fixed_output_post, (void *)ma, 0);
+                               *fixed_output_post, (void *)&ma, 0);
                        mime_parser(mptr, NULL,
-                               *output_preferred, NULL, NULL, (void *)ma, 0);
+                               *output_preferred, NULL, NULL, (void *)&ma, 0);
                }
                else {
                        mime_parser(mptr, NULL,
                                *fixed_output, *fixed_output_pre,
-                               *fixed_output_post, (void *)ma, 0);
+                               *fixed_output_post, (void *)&ma, 0);
                }
 
-               free(ma);
        }
 
 DONE:  /* now we're done */
@@ -1754,8 +1760,14 @@ void cmd_opna(char *cmdbuf)
  * Save a message pointer into a specified room
  * (Returns 0 for success, nonzero for failure)
  * roomname may be NULL to use the current room
+ *
+ * Note that the 'supplied_msg' field may be set to NULL, in which case
+ * the message will be fetched from disk, by number, if we need to perform
+ * replication checks.  This adds an additional database read, so if the
+ * caller already has the message in memory then it should be supplied.
  */
-int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
+int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int do_repl_check,
+                               struct CtdlMessage *supplied_msg) {
        int i;
        char hold_rm[ROOMNAMELEN];
        struct cdbdata *cdbfr;
@@ -1764,37 +1776,34 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
        long highest_msg = 0L;
        struct CtdlMessage *msg = NULL;
 
-       lprintf(CTDL_DEBUG, "CtdlSaveMsgPointerInRoom(%s, %ld, %d)\n",
-               roomname, msgid, flags);
+       lprintf(CTDL_DEBUG, "CtdlSaveMsgPointerInRoom(roomname=%s, msgid=%ld, do_repl_check=%d)\n",
+               roomname, msgid, do_repl_check);
 
        strcpy(hold_rm, CC->room.QRname);
 
        /* We may need to check to see if this message is real */
-       if (  (flags & SM_VERIFY_GOODNESS)
-          || (flags & SM_DO_REPL_CHECK)
-          ) {
-               msg = CtdlFetchMessage(msgid, 1);
+       if (do_repl_check) {
+               if (supplied_msg != NULL) {
+                       msg = supplied_msg;
+               }
+               else {
+                       msg = CtdlFetchMessage(msgid, 0);
+               }
                if (msg == NULL) return(ERROR + ILLEGAL_VALUE);
        }
 
        /* Perform replication checks if necessary */
-       if ( (flags & SM_DO_REPL_CHECK) && (msg != NULL) ) {
+       if ( (do_repl_check) && (msg != NULL) ) {
 
                if (getroom(&CC->room,
                   ((roomname != NULL) ? roomname : CC->room.QRname) )
                   != 0) {
                        lprintf(CTDL_ERR, "No such room <%s>\n", roomname);
-                       if (msg != NULL) CtdlFreeMessage(msg);
+                       if ( (msg != NULL) && (msg != supplied_msg) ) CtdlFreeMessage(msg);
                        return(ERROR + ROOM_NOT_FOUND);
                }
 
-               if (ReplicationChecks(msg) != 0) {
-                       getroom(&CC->room, hold_rm);
-                       if (msg != NULL) CtdlFreeMessage(msg);
-                       lprintf(CTDL_DEBUG,
-                               "Did replication, and newer exists\n");
-                       return(0);
-               }
+               ReplicationChecks(msg);
        }
 
        /* Now the regular stuff */
@@ -1802,7 +1811,7 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
           ((roomname != NULL) ? roomname : CC->room.QRname) )
           != 0) {
                lprintf(CTDL_ERR, "No such room <%s>\n", roomname);
-               if (msg != NULL) CtdlFreeMessage(msg);
+               if ( (msg != NULL) && (msg != supplied_msg) ) CtdlFreeMessage(msg);
                return(ERROR + ROOM_NOT_FOUND);
        }
 
@@ -1828,7 +1837,7 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
                if (msglist[i] == msgid) {
                        lputroom(&CC->room);    /* unlock the room */
                        getroom(&CC->room, hold_rm);
-                       if (msg != NULL) CtdlFreeMessage(msg);
+                       if ( (msg != NULL) && (msg != supplied_msg) ) CtdlFreeMessage(msg);
                        free(msglist);
                        return(ERROR + ALREADY_EXISTS);
                }
@@ -1856,18 +1865,23 @@ int CtdlSaveMsgPointerInRoom(char *roomname, long msgid, int flags) {
        /* Free up the memory we used. */
        free(msglist);
 
+       /* If the message has an Exclusive ID, index that... */
+       if (msg != NULL) {
+               if (msg->cm_fields['E'] != NULL) {
+                       index_message_by_euid(msg->cm_fields['E'], &CC->room, msgid);
+               }
+       }
+
        /* Update the highest-message pointer and unlock the room. */
        CC->room.QRhighest = highest_msg;
        lputroom(&CC->room);
        getroom(&CC->room, hold_rm);
 
        /* Bump the reference count for this message. */
-       if ((flags & SM_DONT_BUMP_REF)==0) {
-               AdjRefCount(msgid, +1);
-       }
+       AdjRefCount(msgid, +1);
 
        /* Return success. */
-       if (msg != NULL) CtdlFreeMessage(msg);
+       if ( (msg != NULL) && (msg != supplied_msg) ) CtdlFreeMessage(msg);
        return (0);
 }
 
@@ -1995,42 +2009,28 @@ void serialize_message(struct ser_ret *ret,             /* return values */
 
 
 /*
- * Back end for the ReplicationChecks() function
- */
-void check_repl(long msgnum, void *userdata) {
-       lprintf(CTDL_DEBUG, "check_repl() replacing message %ld\n", msgnum);
-       CtdlDeleteMessages(CC->room.QRname, msgnum, "", 0);
-}
-
-
-/*
- * Check to see if any messages already exist which carry the same Exclusive ID
- * as this one.  If any are found, delete them.
- *
+ * Check to see if any messages already exist in the current room which
+ * carry the same Exclusive ID as this one.  If any are found, delete them.
  */
-int ReplicationChecks(struct CtdlMessage *msg) {
-       struct CtdlMessage *template;
-       int abort_this = 0;
+void ReplicationChecks(struct CtdlMessage *msg) {
+       long old_msgnum = (-1L);
 
        /* No exclusive id?  Don't do anything. */
-       if (msg->cm_fields['E'] == NULL) return 0;
-       if (strlen(msg->cm_fields['E']) == 0) return 0;
-       lprintf(CTDL_DEBUG, "Exclusive ID: <%s>\n", msg->cm_fields['E']);
-
-       template = (struct CtdlMessage *) malloc(sizeof(struct CtdlMessage));
-       memset(template, 0, sizeof(struct CtdlMessage));
-       template->cm_fields['E'] = strdup(msg->cm_fields['E']);
-
-       CtdlForEachMessage(MSGS_ALL, 0L, NULL, template, check_repl, NULL);
+       if (msg == NULL) return;
+       if (msg->cm_fields['E'] == NULL) return;
+       if (strlen(msg->cm_fields['E']) == 0) return;
+       lprintf(CTDL_DEBUG, "Exclusive ID: <%s> for room <%s>\n",
+               msg->cm_fields['E'], CC->room.QRname);
 
-       CtdlFreeMessage(template);
-       lprintf(CTDL_DEBUG, "ReplicationChecks() returning %d\n", abort_this);
-       return(abort_this);
+       old_msgnum = locate_message_by_euid(msg->cm_fields['E'], &CC->room);
+       if (old_msgnum > 0L) {
+               lprintf(CTDL_DEBUG, "ReplicationChecks() replacing message %ld\n", old_msgnum);
+               CtdlDeleteMessages(CC->room.QRname, old_msgnum, "", 0);
+       }
 }
 
 
 
-
 /*
  * Save a message to disk and submit it into the delivery system.
  */
@@ -2056,6 +2056,8 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        char *instr;
        struct ser_ret smr;
        char *hold_R, *hold_D;
+       char *collected_addresses = NULL;
+       struct addresses_to_be_filed *aptr = NULL;
 
        lprintf(CTDL_DEBUG, "CtdlSubmitMsg() called\n");
        if (is_valid_message(msg) == 0) return(-1);     /* self check */
@@ -2109,8 +2111,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                break;
        case 4:
                strcpy(content_type, "text/plain");
-               mptr = bmstrstr(msg->cm_fields['M'],
-                               "Content-type: ", strncasecmp);
+               mptr = bmstrcasestr(msg->cm_fields['M'], "Content-type: ");
                if (mptr != NULL) {
                        safestrncpy(content_type, &mptr[14], 
                                        sizeof content_type);
@@ -2168,7 +2169,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
 
        /* If this message has an Exclusive ID, perform replication checks */
        lprintf(CTDL_DEBUG, "Performing replication checks\n");
-       if (ReplicationChecks(msg) > 0) return(-4);
+       ReplicationChecks(msg);
 
        /* Save it to disk */
        lprintf(CTDL_DEBUG, "Saving to disk\n");
@@ -2200,7 +2201,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
        CC->redirect_buffer = malloc(SIZ);
        CC->redirect_len = 0;
        CC->redirect_alloc = SIZ;
-       CtdlOutputPreLoadedMsg(msg, 0L, MT_RFC822, HEADERS_ALL, 0, 1);
+       CtdlOutputPreLoadedMsg(msg, MT_RFC822, HEADERS_ALL, 0, 1);
        smi.meta_rfc822_length = CC->redirect_len;
        free(CC->redirect_buffer);
        CC->redirect_buffer = NULL;
@@ -2217,17 +2218,16 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
         * is no local sender; it would otherwise go to the Trashcan).
         */
        if ((!CC->internal_pgm) || (recps == NULL)) {
-               if (CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0) != 0) {
+               if (CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 1, msg) != 0) {
                        lprintf(CTDL_ERR, "ERROR saving message pointer!\n");
-                       CtdlSaveMsgPointerInRoom(config.c_aideroom,
-                                                       newmsgid, 0);
+                       CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0, msg);
                }
        }
 
        /* For internet mail, drop a copy in the outbound queue room */
        if (recps != NULL)
         if (recps->num_internet > 0) {
-               CtdlSaveMsgPointerInRoom(SMTP_SPOOLOUT_ROOM, newmsgid, 0);
+               CtdlSaveMsgPointerInRoom(SMTP_SPOOLOUT_ROOM, newmsgid, 0, msg);
        }
 
        /* If other rooms are specified, drop them there too. */
@@ -2237,7 +2237,7 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,       /* message to save */
                extract_token(recipient, recps->recp_room, i,
                                        '|', sizeof recipient);
                lprintf(CTDL_DEBUG, "Delivering to room <%s>\n", recipient);
-               CtdlSaveMsgPointerInRoom(recipient, newmsgid, 0);
+               CtdlSaveMsgPointerInRoom(recipient, newmsgid, 0, msg);
        }
 
        /* Bump this user's messages posted counter. */
@@ -2259,13 +2259,12 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                if (getuser(&userbuf, recipient) == 0) {
                        MailboxName(actual_rm, sizeof actual_rm,
                                        &userbuf, MAILROOM);
-                       CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0);
+                       CtdlSaveMsgPointerInRoom(actual_rm, newmsgid, 0, msg);
                        BumpNewMailCounter(userbuf.usernum);
                }
                else {
                        lprintf(CTDL_DEBUG, "No user <%s>\n", recipient);
-                       CtdlSaveMsgPointerInRoom(config.c_aideroom,
-                                                       newmsgid, 0);
+                       CtdlSaveMsgPointerInRoom(config.c_aideroom, newmsgid, 0, msg);
                }
        }
 
@@ -2358,11 +2357,33 @@ long CtdlSubmitMsg(struct CtdlMessage *msg,     /* message to save */
                CtdlFreeMessage(imsg);
        }
 
+       /*
+        * Any addresses to harvest for someone's address book?
+        */
+       if ( (CC->logged_in) && (recps != NULL) ) {
+               collected_addresses = harvest_collected_addresses(msg);
+       }
+
+       if (collected_addresses != NULL) {
+               begin_critical_section(S_ATBF);
+               aptr = (struct addresses_to_be_filed *) malloc(sizeof(struct addresses_to_be_filed));
+               aptr->next = atbf;
+               MailboxName(actual_rm, sizeof actual_rm, &CC->user, USERCONTACTSROOM);
+               aptr->roomname = strdup(actual_rm);
+               aptr->collected_addresses = collected_addresses;
+               atbf = aptr;
+               end_critical_section(S_ATBF);
+       }
        return(newmsgid);
 }
 
 
 
+
+
+
+
+
 /*
  * Convenience function for generating small administrative messages.
  */
@@ -2492,6 +2513,7 @@ char *CtdlReadMessageBody(char *terminator,       /* token signalling EOT */
 struct CtdlMessage *CtdlMakeMessage(
        struct ctdluser *author,        /* author's user structure */
        char *recipient,                /* NULL if it's not mail */
+       char *recp_cc,                  /* NULL if it's not mail */
        char *room,                     /* room where it's going */
        int type,                       /* see MES_ types in header file */
        int format_type,                /* variformat, plain text, MIME... */
@@ -2513,6 +2535,7 @@ struct CtdlMessage *CtdlMakeMessage(
        strcpy(dest_node, "");
 
        striplt(recipient);
+       striplt(recp_cc);
 
        snprintf(buf, sizeof buf, "cit%ld", author->usernum);   /* Path */
        msg->cm_fields['P'] = strdup(buf);
@@ -2538,6 +2561,9 @@ struct CtdlMessage *CtdlMakeMessage(
        if (recipient[0] != 0) {
                msg->cm_fields['R'] = strdup(recipient);
        }
+       if (recp_cc[0] != 0) {
+               msg->cm_fields['Y'] = strdup(recp_cc);
+       }
        if (dest_node[0] != 0) {
                msg->cm_fields['D'] = strdup(dest_node);
        }
@@ -2624,10 +2650,11 @@ int CtdlCheckInternetMailPermission(struct ctdluser *who) {
 }
 
 
-
 /*
  * Validate recipients, count delivery types and errors, and handle aliasing
  * FIXME check for dupes!!!!!
+ * Returns 0 if all addresses are ok, -1 if no addresses were specified,
+ * or the number of addresses found invalid.
  */
 struct recptypes *validate_recipients(char *recipients) {
        struct recptypes *ret;
@@ -2786,7 +2813,7 @@ struct recptypes *validate_recipients(char *recipients) {
 
        if ((ret->num_local + ret->num_internet + ret->num_ignet +
           ret->num_room + ret->num_error) == 0) {
-               ++ret->num_error;
+               ret->num_error = (-1);
                strcpy(ret->errormsg, "No recipients specified.");
        }
 
@@ -2809,6 +2836,8 @@ void cmd_ent0(char *entargs)
 {
        int post = 0;
        char recp[SIZ];
+       char cc[SIZ];
+       char bcc[SIZ];
        char masquerade_as[SIZ];
        int anon_flag = 0;
        int format_type = 0;
@@ -2818,6 +2847,9 @@ void cmd_ent0(char *entargs)
        char errmsg[SIZ];
        int err = 0;
        struct recptypes *valid = NULL;
+       struct recptypes *valid_to = NULL;
+       struct recptypes *valid_cc = NULL;
+       struct recptypes *valid_bcc = NULL;
        char subject[SIZ];
        int do_confirm = 0;
        long msgnum;
@@ -2830,6 +2862,8 @@ void cmd_ent0(char *entargs)
        format_type = extract_int(entargs, 3);
        extract_token(subject, entargs, 4, '|', sizeof subject);
        do_confirm = extract_int(entargs, 6);
+       extract_token(cc, entargs, 7, '|', sizeof cc);
+       extract_token(bcc, entargs, 8, '|', sizeof bcc);
 
        /* first check to make sure the request is valid. */
 
@@ -2865,39 +2899,74 @@ void cmd_ent0(char *entargs)
 
                if (CC->user.axlevel < 2) {
                        strcpy(recp, "sysop");
+                       strcpy(cc, "");
+                       strcpy(bcc, "");
                }
 
-               valid = validate_recipients(recp);
-               if (valid->num_error > 0) {
-                       cprintf("%d %s\n",
-                               ERROR + NO_SUCH_USER, valid->errormsg);
-                       free(valid);
+               valid_to = validate_recipients(recp);
+               if (valid_to->num_error > 0) {
+                       cprintf("%d Invalid recipient (To)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
                        return;
                }
-               if (valid->num_internet > 0) {
+
+               valid_cc = validate_recipients(cc);
+               if (valid_cc->num_error > 0) {
+                       cprintf("%d Invalid recipient (CC)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
+                       free(valid_cc);
+                       return;
+               }
+
+               valid_bcc = validate_recipients(bcc);
+               if (valid_bcc->num_error > 0) {
+                       cprintf("%d Invalid recipient (BCC)\n", ERROR + NO_SUCH_USER);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
+                       return;
+               }
+
+               /* Recipient required, but none were specified */
+               if ( (valid_to->num_error < 0) && (valid_cc->num_error < 0) && (valid_bcc->num_error < 0) ) {
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
+                       cprintf("%d At least one recipient is required.\n", ERROR + NO_SUCH_USER);
+                       return;
+               }
+
+               if (valid_to->num_internet + valid_cc->num_internet + valid_bcc->num_internet > 0) {
                        if (CtdlCheckInternetMailPermission(&CC->user)==0) {
                                cprintf("%d You do not have permission "
                                        "to send Internet mail.\n",
                                        ERROR + HIGHER_ACCESS_REQUIRED);
-                               free(valid);
+                               free(valid_to);
+                               free(valid_cc);
+                               free(valid_bcc);
                                return;
                        }
                }
 
-               if ( ( (valid->num_internet + valid->num_ignet) > 0)
+               if ( ( (valid_to->num_internet + valid_to->num_ignet + valid_cc->num_internet + valid_cc->num_ignet + valid_bcc->num_internet + valid_bcc->num_ignet) > 0)
                   && (CC->user.axlevel < 4) ) {
                        cprintf("%d Higher access required for network mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       free(valid);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
                        return;
                }
        
-               if ((RESTRICT_INTERNET == 1) && (valid->num_internet > 0)
+               if ((RESTRICT_INTERNET == 1)
+                   && (valid_to->num_internet + valid_cc->num_internet + valid_bcc->num_internet > 0)
                    && ((CC->user.flags & US_INTERNET) == 0)
                    && (!CC->internal_pgm)) {
                        cprintf("%d You don't have access to Internet mail.\n",
                                ERROR + HIGHER_ACCESS_REQUIRED);
-                       free(valid);
+                       free(valid_to);
+                       free(valid_cc);
+                       free(valid_bcc);
                        return;
                }
 
@@ -2923,11 +2992,18 @@ void cmd_ent0(char *entargs)
         */
        if (post == 0) {
                cprintf("%d %s\n", CIT_OK,
-                       ((valid != NULL) ? valid->display_recp : "") );
-               free(valid);
+                       ((valid_to != NULL) ? valid_to->display_recp : "") );
+               free(valid_to);
+               free(valid_cc);
+               free(valid_bcc);
                return;
        }
 
+       /* We don't need these anymore because we'll do it differently below */
+       free(valid_to);
+       free(valid_cc);
+       free(valid_bcc);
+
        /* Handle author masquerading */
        if (CC->fake_postname[0]) {
                strcpy(masquerade_as, CC->fake_postname);
@@ -2945,10 +3021,36 @@ void cmd_ent0(char *entargs)
        } else {
                cprintf("%d send message\n", SEND_LISTING);
        }
-       msg = CtdlMakeMessage(&CC->user, recp,
+
+       msg = CtdlMakeMessage(&CC->user, recp, cc,
                CC->room.QRname, anonymous, format_type,
                masquerade_as, subject, NULL);
 
+       /* Put together one big recipients struct containing to/cc/bcc all in
+        * one.  This is for the envelope.
+        */
+       char *all_recps = malloc(SIZ * 3);
+       strcpy(all_recps, recp);
+       if (strlen(cc) > 0) {
+               if (strlen(all_recps) > 0) {
+                       strcat(all_recps, ",");
+               }
+               strcat(all_recps, cc);
+       }
+       if (strlen(bcc) > 0) {
+               if (strlen(all_recps) > 0) {
+                       strcat(all_recps, ",");
+               }
+               strcat(all_recps, bcc);
+       }
+       if (strlen(all_recps) > 0) {
+               valid = validate_recipients(all_recps);
+       }
+       else {
+               valid = NULL;
+       }
+       free(all_recps);
+
        if (msg != NULL) {
                msgnum = CtdlSubmitMsg(msg, valid, "");
 
@@ -2971,7 +3073,9 @@ void cmd_ent0(char *entargs)
                CtdlFreeMessage(msg);
        }
        CC->fake_postname[0] = '\0';
-       free(valid);
+       if (valid != NULL) {
+               free(valid);
+       }
        return;
 }
 
@@ -3135,8 +3239,7 @@ void cmd_dele(char *delstr)
 int CtdlCopyMsgToRoom(long msgnum, char *dest) {
        int err;
 
-       err = CtdlSaveMsgPointerInRoom(dest, msgnum,
-               (SM_VERIFY_GOODNESS | SM_DO_REPL_CHECK) );
+       err = CtdlSaveMsgPointerInRoom(dest, msgnum, 1, NULL);
        if (err != 0) return(err);
 
        return(0);
@@ -3290,7 +3393,6 @@ void AdjRefCount(long msgnum, int incr)
 
        /* If the reference count is now zero, delete the message
         * (and its supplementary record as well).
-        * FIXME ... defer this so it doesn't keep the user waiting.
         */
        if (smi.meta_refcount == 0) {
                lprintf(CTDL_DEBUG, "Deleting message <%ld>\n", msgnum);