Removed the logging facility from citserver, use syslog instead
[citadel.git] / citadel / sysdep.c
index 2e43b66bb0c472ddfae6558e3e7661cb7b911e80..5468d24ca7519af883d5aa7a1209466479b31d95 100644 (file)
@@ -1,6 +1,5 @@
 /*
  * Citadel "system dependent" stuff.
- * See COPYING for copyright information.
  *
  * Here's where we (hopefully) have most parts of the Citadel server that
  * would need to be altered to run the server in a non-POSIX environment.
@@ -8,6 +7,21 @@
  * If we ever port to a different platform and either have multiple
  * variants of this file or simply load it up with #ifdefs.
  *
+ * Copyright (c) 1987-2011 by the citadel.org team
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
 #include "sysdep.h"
@@ -87,89 +101,6 @@ struct igheap *igheap = NULL;
 #endif
 
 
-int verbosity = DEFAULT_VERBOSITY;             /* Logging level */
-
-int syslog_facility = LOG_DAEMON;
-int enable_syslog = 0;
-int print_to_logfile = 1;
-
-/*
- * CtdlLogPrintf()  ...   Write logging information
- */
-void CtdlLogPrintf(enum LogLevel loglevel, const char *format, ...) {   
-       va_list arg_ptr;
-       va_start(arg_ptr, format);
-       vCtdlLogPrintf(loglevel, format, arg_ptr);
-       va_end(arg_ptr);
-}
-
-void vCtdlLogPrintf(enum LogLevel loglevel, const char *format, va_list arg_ptr)
-{
-
-       if (enable_syslog) {
-               vsyslog((syslog_facility | loglevel), format, arg_ptr);
-       }
-
-       /* stderr output code */
-       if (enable_syslog || !print_to_logfile) return;
-
-       /* if we run in forground and syslog is disabled, log to terminal */
-       if (loglevel <= verbosity) { 
-               struct timeval tv;
-               struct tm tim;
-               time_t unixtime;
-               CitContext *CCC = CC;
-               ThreadTSD *cTSD = CTP;
-               CtdlThreadNode *node = NULL;
-               long lwpid = 0;
-               char formatbuf[SIZ];
-               char LWP[64];
-               char SESS[64];
-
-               if (cTSD != NULL) {
-                       node = cTSD->self;
-               }
-
-               if ((node != NULL) && (node->reltid != 0)) {
-                       lwpid = node->reltid;
-               }
-
-               gettimeofday(&tv, NULL);
-
-               /* Promote to time_t; types differ on some OSes (like darwin) */
-               unixtime = tv.tv_sec;
-               localtime_r(&unixtime, &tim);
-
-               *LWP = '\0';
-               if (lwpid != 0) {
-                       snprintf(LWP, 64, "[LWP:%ld] ", lwpid);
-               }
-                       
-               *SESS = '\0';
-               if (CCC != NULL) {
-                       if (CCC->cs_pid != 0) {
-                               snprintf(SESS, 64, " [%3d] ", CCC->cs_pid);
-                       }
-                       else if (CCC->user.usernum != 0) {
-                               snprintf(SESS, 64, " [:%ld] ", CCC->user.usernum);
-                       }
-               }
-
-               snprintf(formatbuf, SIZ, 
-                        "%04d/%02d/%02d %2d:%02d:%02d.%06ld %s%s%s",
-                        tim.tm_year + 1900, tim.tm_mon + 1,
-                        tim.tm_mday, tim.tm_hour, tim.tm_min,
-                        tim.tm_sec, (long)tv.tv_usec, 
-                        LWP, SESS, format
-               );
-
-               vfprintf(stderr, formatbuf, arg_ptr);   
-               fflush(stderr);
-       }
-}   
-
-
-
 /*
  * Signal handler to shut down the server.
  */
@@ -180,12 +111,14 @@ volatile int restart_server = 0;
 volatile int running_as_daemon = 0;
 
 static RETSIGTYPE signal_cleanup(int signum) {
+       ThreadTSD *Cc;
 
-       if (CT)
-               CT->signal = signum;
+       Cc = CTP;
+       if (Cc && Cc->self)
+               Cc->self->signal = signum;
        else
        {
-               CtdlLogPrintf(CTDL_DEBUG, "Caught signal %d; shutting down.\n", signum);
+               syslog(LOG_DEBUG, "Caught signal %d; shutting down.\n", signum);
                exit_signal = signum;
        }
 }
@@ -225,7 +158,7 @@ void init_sysdep(void) {
         * session to which the calling thread is currently bound.
         */
        if (citthread_key_create(&MyConKey, NULL) != 0) {
-               CtdlLogPrintf(CTDL_CRIT, "Can't create TSD key: %s\n",
+               syslog(LOG_CRIT, "Can't create TSD key: %s\n",
                        strerror(errno));
        }
 
@@ -301,7 +234,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                        snprintf(errormessage, SIZ,
                                 "Error binding to [%s] : %s", ip_addr, strerror(errno)
                        );
-                       CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+                       syslog(LOG_ALERT, "%s\n", errormessage);
                        return (-1);
                }
        }
@@ -312,7 +245,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                        snprintf(errormessage, SIZ,
                                 "Error binding to [%s] : %s", ip_addr, strerror(errno)
                        );
-                       CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+                       syslog(LOG_ALERT, "%s\n", errormessage);
                        return (-1);
                }
        }
@@ -321,7 +254,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                snprintf(errormessage, SIZ,
                         "Can't start: no port number specified."
                );
-               CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+               syslog(LOG_ALERT, "%s\n", errormessage);
                return (-1);
        }
        sin6.sin6_port = htons((u_short) port_number);
@@ -334,7 +267,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                snprintf(errormessage, SIZ,
                         "Can't create a listening socket: %s", strerror(errno)
                );
-               CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+               syslog(LOG_ALERT, "%s\n", errormessage);
                return (-1);
        }
        /* Set some socket options that make sense. */
@@ -352,7 +285,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                snprintf(errormessage, SIZ,
                         "Can't bind: %s", strerror(errno)
                );
-               CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+               syslog(LOG_ALERT, "%s\n", errormessage);
                return (-1);
        }
 
@@ -362,7 +295,7 @@ int ctdl_tcp_server(char *ip_addr, int port_number, int queue_len, char *errorme
                snprintf(errormessage, SIZ,
                         "Can't listen: %s", strerror(errno)
                );
-               CtdlLogPrintf(CTDL_ALERT, "%s\n", errormessage);
+               syslog(LOG_ALERT, "%s\n", errormessage);
                return (-1);
        }
        return (s);
@@ -393,7 +326,7 @@ int ctdl_uds_server(char *sockpath, int queue_len, char *errormessage)
                snprintf(errormessage, SIZ, "citserver: can't unlink %s: %s",
                        sockpath, strerror(errno)
                );
-               CtdlLogPrintf(CTDL_EMERG, "%s\n", errormessage);
+               syslog(LOG_EMERG, "%s\n", errormessage);
                return(-1);
        }
 
@@ -406,7 +339,7 @@ int ctdl_uds_server(char *sockpath, int queue_len, char *errormessage)
                snprintf(errormessage, SIZ, 
                         "citserver: Can't create a socket: %s",
                         strerror(errno));
-               CtdlLogPrintf(CTDL_EMERG, "%s\n", errormessage);
+               syslog(LOG_EMERG, "%s\n", errormessage);
                return(-1);
        }
 
@@ -414,7 +347,7 @@ int ctdl_uds_server(char *sockpath, int queue_len, char *errormessage)
                snprintf(errormessage, SIZ, 
                         "citserver: Can't bind: %s",
                         strerror(errno));
-               CtdlLogPrintf(CTDL_EMERG, "%s\n", errormessage);
+               syslog(LOG_EMERG, "%s\n", errormessage);
                return(-1);
        }
 
@@ -423,7 +356,7 @@ int ctdl_uds_server(char *sockpath, int queue_len, char *errormessage)
                snprintf(errormessage, SIZ, 
                         "citserver: Can't set socket to non-blocking: %s",
                         strerror(errno));
-               CtdlLogPrintf(CTDL_EMERG, "%s\n", errormessage);
+               syslog(LOG_EMERG, "%s\n", errormessage);
                close(s);
                return(-1);
        }
@@ -432,7 +365,7 @@ int ctdl_uds_server(char *sockpath, int queue_len, char *errormessage)
                snprintf(errormessage, SIZ, 
                         "citserver: Can't listen: %s",
                         strerror(errno));
-               CtdlLogPrintf(CTDL_EMERG, "%s\n", errormessage);
+               syslog(LOG_EMERG, "%s\n", errormessage);
                return(-1);
        }
 
@@ -495,7 +428,7 @@ static void flush_client_inbuf(void)
        CitContext *CCC=CC;
 
        FlushStrBuf(CCC->ReadBuf);
-       CCC->Pos = NULL;
+       CCC->RecvBuf->ReadWritePointer = NULL;
 
 }
 */
@@ -527,13 +460,14 @@ int client_write(const char *buf, int nbytes)
                snprintf(fn, SIZ, "/tmp/foolog_%s.%d", Ctx->ServiceName, Ctx->cs_pid);
                
                fd = fopen(fn, "a+");
-               fprintf(fd, "Sending: BufSize: %d BufContent: [",
-                       nbytes);
-               rv = fwrite(buf, nbytes, 1, fd);
-               fprintf(fd, "]\n");
-               
-                       
-               fclose(fd);
+               if (fd)
+               {
+                   fprintf(fd, "Sending: BufSize: %d BufContent: [",
+                           nbytes);
+                   rv = fwrite(buf, nbytes, 1, fd);
+                   fprintf(fd, "]\n");
+                   fclose(fd);
+               }
        }
 #endif
 //     flush_client_inbuf();
@@ -560,7 +494,7 @@ int client_write(const char *buf, int nbytes)
                        if (select(1, NULL, &wset, NULL, NULL) == -1) {
                                if (errno == EINTR)
                                {
-                                       CtdlLogPrintf(CTDL_DEBUG, "client_write(%d bytes) select() interrupted.\n", nbytes-bytes_written);
+                                       syslog(LOG_DEBUG, "client_write(%d bytes) select() interrupted.\n", nbytes-bytes_written);
                                        if (CtdlThreadCheckStop()) {
                                                CC->kill_me = 1;
                                                return (-1);
@@ -569,7 +503,7 @@ int client_write(const char *buf, int nbytes)
                                                continue;
                                        }
                                } else {
-                                       CtdlLogPrintf(CTDL_ERR,
+                                       syslog(LOG_ERR,
                                                "client_write(%d bytes) select failed: %s (%d)\n",
                                                nbytes - bytes_written,
                                                strerror(errno), errno);
@@ -583,12 +517,12 @@ int client_write(const char *buf, int nbytes)
                retval = write(Ctx->client_socket, &buf[bytes_written],
                        nbytes - bytes_written);
                if (retval < 1) {
-                       CtdlLogPrintf(CTDL_ERR,
+                       syslog(LOG_ERR,
                                "client_write(%d bytes) failed: %s (%d)\n",
                                nbytes - bytes_written,
                                strerror(errno), errno);
                        cit_backtrace();
-                       // CtdlLogPrintf(CTDL_DEBUG, "Tried to send: %s",  &buf[bytes_written]);
+                       // syslog(LOG_DEBUG, "Tried to send: %s",  &buf[bytes_written]);
                        Ctx->kill_me = 1;
                        return -1;
                }
@@ -657,7 +591,7 @@ int client_read_blob(StrBuf *Target, int bytes, int timeout)
 #endif
                retval = client_read_sslblob(Target, bytes, timeout);
                if (retval < 0) {
-                       CtdlLogPrintf(CTDL_CRIT, 
+                       syslog(LOG_CRIT, 
                                      "%s failed\n",
                                      __FUNCTION__);
                }
@@ -694,15 +628,15 @@ int client_read_blob(StrBuf *Target, int bytes, int timeout)
                fclose(fd);
 #endif
                retval = StrBufReadBLOBBuffered(Target, 
-                                               CCC->ReadBuf,
-                                               &CCC->Pos,
+                                               CCC->RecvBuf.Buf,
+                                               &CCC->RecvBuf.ReadWritePointer,
                                                &CCC->client_socket,
                                                1, 
                                                bytes,
                                                O_TERM,
                                                &Error);
                if (retval < 0) {
-                       CtdlLogPrintf(CTDL_CRIT, 
+                       syslog(LOG_CRIT, 
                                      "%s failed: %s\n",
                                      __FUNCTION__, 
                                      Error);
@@ -731,8 +665,9 @@ int client_read_blob(StrBuf *Target, int bytes, int timeout)
  */
 void client_set_inbound_buf(long N)
 {
-       FlushStrBuf(CC->ReadBuf);
-       ReAdjustEmptyBuf(CC->ReadBuf, N * SIZ, N * SIZ);
+       CitContext *CCC=CC;
+       FlushStrBuf(CCC->RecvBuf.Buf);
+       ReAdjustEmptyBuf(CCC->RecvBuf.Buf, N * SIZ, N * SIZ);
 }
 
 int client_read_random_blob(StrBuf *Target, int timeout)
@@ -746,18 +681,18 @@ int client_read_random_blob(StrBuf *Target, int timeout)
                long len;
                const char *pch;
                
-               len = StrLength(CCC->ReadBuf);
-               pch = ChrPtr(CCC->ReadBuf);
+               len = StrLength(CCC->RecvBuf.Buf);
+               pch = ChrPtr(CCC->RecvBuf.Buf);
 
                if (len > 0)
                {
-                       if (CCC->Pos != NULL) {
-                               len -= CCC->Pos - pch;
-                               pch = CCC->Pos;
+                       if (CCC->RecvBuf.ReadWritePointer != NULL) {
+                               len -= CCC->RecvBuf.ReadWritePointer - pch;
+                               pch = CCC->RecvBuf.ReadWritePointer;
                        }
                        StrBufAppendBufPlain(Target, pch, len, 0);
-                       FlushStrBuf(CCC->ReadBuf);
-                       CCC->Pos = NULL;
+                       FlushStrBuf(CCC->RecvBuf.Buf);
+                       CCC->RecvBuf.ReadWritePointer = NULL;
 #ifdef BIGBAD_IODBG
                        {
                                int rv = 0;
@@ -810,8 +745,8 @@ int client_read_to(char *buf, int bytes, int timeout)
 int HaveMoreLinesWaiting(CitContext *CCC)
 {
        if ((CCC->kill_me == 1) || (
-           (CCC->Pos == NULL) && 
-           (StrLength(CCC->ReadBuf) == 0) && 
+           (CCC->RecvBuf.ReadWritePointer == NULL) && 
+           (StrLength(CCC->RecvBuf.Buf) == 0) && 
            (CCC->client_socket != -1)) )
                return 0;
        else
@@ -850,10 +785,10 @@ int CtdlClientGetLine(StrBuf *Target)
                snprintf(fn, SIZ, "/tmp/foolog_%s.%d", CCC->ServiceName, CCC->cs_pid);
 
                fd = fopen(fn, "a+");
-               pch = ChrPtr(CCC->ReadBuf);
-               len = StrLength(CCC->ReadBuf);
-               if (CCC->Pos != NULL)
-                       rlen = CC->Pos - pch;
+               pch = ChrPtr(CCC->RecvBuf.Buf);
+               len = StrLength(CCC->RecvBuf.Buf);
+               if (CCC->RecvBuf.ReadWritePointer != NULL)
+                       rlen = CCC->RecvBuf.ReadWritePointer - pch;
                else
                        rlen = 0;
 
@@ -864,14 +799,14 @@ int CtdlClientGetLine(StrBuf *Target)
                        len, rlen);
 #endif
                rc = client_readline_sslbuffer(Target,
-                                              CCC->ReadBuf,
-                                              &CCC->Pos,
+                                              CCC->RecvBuf.Buf,
+                                              &CCC->RecvBuf.ReadWritePointer,
                                               1);
 #ifdef BIGBAD_IODBG
-                pch = ChrPtr(CCC->ReadBuf);
-                nlen = StrLength(CCC->ReadBuf);
-                if (CCC->Pos != NULL)
-                        nrlen = CC->Pos - pch;
+                pch = ChrPtr(CCC->RecvBuf.Buf);
+                nlen = StrLength(CCC->RecvBuf.Buf);
+                if (CCC->RecvBuf.ReadWritePointer != NULL)
+                        nrlen = CCC->RecvBuf.ReadWritePointer - pch;
                 else
                         nrlen = 0;
 /*
@@ -886,7 +821,7 @@ int CtdlClientGetLine(StrBuf *Target)
                 fclose(fd);
 
                if (rc < 0)
-                       CtdlLogPrintf(CTDL_CRIT, 
+                       syslog(LOG_CRIT, 
                                      "%s failed\n",
                                      __FUNCTION__);
 #endif
@@ -904,10 +839,10 @@ int CtdlClientGetLine(StrBuf *Target)
                snprintf(fn, SIZ, "/tmp/foolog_%s.%d", CCC->ServiceName, CCC->cs_pid);
 
                fd = fopen(fn, "a+");
-               pch = ChrPtr(CCC->ReadBuf);
-               len = StrLength(CCC->ReadBuf);
-               if (CCC->Pos != NULL)
-                       rlen = CC->Pos - pch;
+               pch = ChrPtr(CCC->RecvBuf.Buf);
+               len = StrLength(CCC->RecvBuf.Buf);
+               if (CCC->RecvBuf.ReadWritePointer != NULL)
+                       rlen = CCC->RecvBuf.ReadWritePointer - pch;
                else
                        rlen = 0;
 
@@ -918,18 +853,18 @@ int CtdlClientGetLine(StrBuf *Target)
                        len, rlen);
 #endif
                rc = StrBufTCP_read_buffered_line_fast(Target, 
-                                                      CCC->ReadBuf,
-                                                      &CCC->Pos,
+                                                      CCC->RecvBuf.Buf,
+                                                      &CCC->RecvBuf.ReadWritePointer,
                                                       &CCC->client_socket,
                                                       5,
                                                       1,
                                                       &Error);
 
 #ifdef BIGBAD_IODBG
-                pch = ChrPtr(CCC->ReadBuf);
-                nlen = StrLength(CCC->ReadBuf);
-                if (CCC->Pos != NULL)
-                        nrlen = CC->Pos - pch;
+                pch = ChrPtr(CCC->RecvBuf.Buf);
+                nlen = StrLength(CCC->RecvBuf.Buf);
+                if (CCC->RecvBuf.ReadWritePointer != NULL)
+                        nrlen = CCC->RecvBuf.ReadWritePointer - pch;
                 else
                         nrlen = 0;
 /*
@@ -944,7 +879,7 @@ int CtdlClientGetLine(StrBuf *Target)
                 fclose(fd);
 
                if ((rc < 0) && (Error != NULL))
-                       CtdlLogPrintf(CTDL_CRIT, 
+                       syslog(LOG_CRIT, 
                                      "%s failed: %s\n",
                                      __FUNCTION__,
                                      Error);
@@ -1009,13 +944,13 @@ void close_masters (void)
 
                if (serviceptr->tcp_port > 0)
                {
-                       CtdlLogPrintf(CTDL_INFO, "Closing listener on port %d\n",
+                       syslog(LOG_INFO, "Closing listener on port %d\n",
                                serviceptr->tcp_port);
                        serviceptr->tcp_port = 0;
                }
                
                if (serviceptr->sockpath != NULL)
-                       CtdlLogPrintf(CTDL_INFO, "Closing listener on '%s'\n",
+                       syslog(LOG_INFO, "Closing listener on '%s'\n",
                                serviceptr->sockpath);
 
                close(serviceptr->msock);
@@ -1051,6 +986,7 @@ void sysdep_master_cleanup(void) {
        CtdlDestroySessionHooks();
        CtdlDestroyServiceHook();
        CtdlDestroyRoomHooks();
+       CtdlDestroySearchHooks();
        #ifdef HAVE_BACKTRACE
 ///    eCrash_Uninit();
        #endif
@@ -1085,7 +1021,7 @@ void start_daemon(int unused) {
         * to be reused for other files.
         */
        if (chdir(ctdl_run_dir) != 0)
-               CtdlLogPrintf(CTDL_EMERG, 
+               syslog(LOG_EMERG, 
                              "unable to change into directory [%s]: %s", 
                              ctdl_run_dir, strerror(errno));
 
@@ -1103,7 +1039,7 @@ void start_daemon(int unused) {
         if ((freopen("/dev/null", "r", stdin) != stdin) || 
            (freopen("/dev/null", "w", stdout) != stdout) || 
            (freopen("/dev/null", "w", stderr) != stderr))
-               CtdlLogPrintf(CTDL_EMERG, 
+               syslog(LOG_EMERG, 
                              "unable to reopen stdin/out/err %s", 
                              strerror(errno));
                
@@ -1165,7 +1101,7 @@ void checkcrash(void)
                StrBuf *CrashMail;
 
                CrashMail = NewStrBuf();
-               CtdlLogPrintf(CTDL_ALERT, "Posting crash message\n");
+               syslog(LOG_ALERT, "Posting crash message\n");
                StrBufPrintf(CrashMail, 
                        " \n"
                        " The Citadel server process (citserver) terminated unexpectedly."
@@ -1263,11 +1199,13 @@ do_select:      force_purge = 0;
                begin_critical_section(S_SESSION_TABLE);
                for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
                        int client_socket;
+                       if ((ptr->state == CON_SYS) && (ptr->client_socket == 0))
+                           continue;
                        client_socket = ptr->client_socket;
                        /* Dont select on dead sessions only truly idle ones */
                        if ((ptr->state == CON_IDLE) && 
                            (CC->kill_me == 0) &&
-                           (client_socket != -1))
+                           (client_socket > 0))
                        {
                                FD_SET(client_socket, &readfds);
                                if (client_socket > highest)
@@ -1308,16 +1246,18 @@ do_select:      force_purge = 0;
                 */
                if (retval < 0) {
                        if (errno == EBADF) {
-                               CtdlLogPrintf(CTDL_NOTICE, "select() failed: (%s)\n",
+                               syslog(LOG_NOTICE, "select() failed: (%s)\n",
                                        strerror(errno));
                                goto do_select;
                        }
                        if (errno != EINTR) {
-                               CtdlLogPrintf(CTDL_EMERG, "Exiting (%s)\n", strerror(errno));
+                               syslog(LOG_EMERG, "Exiting (%s)\n", strerror(errno));
                                CtdlThreadStopAll();
                                continue;
                        } else {
-                               CtdlLogPrintf(CTDL_DEBUG, "Interrupted CtdlThreadSelect.\n");
+#if 0
+                               syslog(LOG_DEBUG, "Interrupted CtdlThreadSelect.\n");
+#endif
                                if (CtdlThreadCheckStop()) return(NULL);
                                goto do_select;
                        }
@@ -1450,15 +1390,17 @@ void *select_on_master (void *arg)
                 */
                if (retval < 0) {
                        if (errno == EBADF) {
-                               CtdlLogPrintf(CTDL_NOTICE, "select() failed: (%s)\n",
+                               syslog(LOG_NOTICE, "select() failed: (%s)\n",
                                        strerror(errno));
                                continue;
                        }
                        if (errno != EINTR) {
-                               CtdlLogPrintf(CTDL_EMERG, "Exiting (%s)\n", strerror(errno));
+                               syslog(LOG_EMERG, "Exiting (%s)\n", strerror(errno));
                                CtdlThreadStopAll();
                        } else {
-                               CtdlLogPrintf(CTDL_DEBUG, "Interrupted CtdlThreadSelect.\n");
+#if 0
+                               syslog(LOG_DEBUG, "Interrupted CtdlThreadSelect.\n");
+#endif
                                if (CtdlThreadCheckStop()) return(NULL);
                                continue;
                        }
@@ -1476,7 +1418,7 @@ void *select_on_master (void *arg)
                        if (FD_ISSET(serviceptr->msock, &master_fds)) {
                                ssock = accept(serviceptr->msock, NULL, 0);
                                if (ssock >= 0) {
-                                       CtdlLogPrintf(CTDL_DEBUG,
+                                       syslog(LOG_DEBUG,
                                                "New client socket %d\n",
                                                ssock);
 
@@ -1485,7 +1427,7 @@ void *select_on_master (void *arg)
                                         * operations barf on FreeBSD.  Not a fatal error.
                                         */
                                        if (fcntl(ssock, F_SETFL, 0) < 0) {
-                                               CtdlLogPrintf(CTDL_EMERG,
+                                               syslog(LOG_EMERG,
                                                        "citserver: Can't set socket to blocking: %s\n",
                                                        strerror(errno));
                                        }
@@ -1567,7 +1509,6 @@ int SyslogFacility(char *name)
                if(!strcasecmp(name, facTbl[i].name))
                        return facTbl[i].facility;
        }
-       enable_syslog = 0;
        return LOG_DAEMON;
 }
 
@@ -1673,7 +1614,7 @@ void dump_heap(void) {
        struct igheap *thisheap;
 
        for (thisheap = igheap; thisheap != NULL; thisheap = thisheap->next) {
-               CtdlLogPrintf(CTDL_CRIT, "UNFREED: %30s : %d\n",
+               syslog(LOG_CRIT, "UNFREED: %30s : %d\n",
                        thisheap->file, thisheap->line);
        }
 }