Fix more warnings; output errors to the users.

[citadel.git] / citadel / textclient / commands.c

diff --git a/citadel/textclient/commands.c b/citadel/textclient/commands.c
index 6371cb46e800fdcee5e58f76f19e1f103f35d768..e98dad3872955267bc358fa2d75392baead8b30e 100644 (file)
--- a/citadel/textclient/commands.c
+++ b/citadel/textclient/commands.c
@@ -135,7 +135,7 @@ char was_a_key_pressed(void) {
         * in the middle of a data transfer from the server, in which case
         * sending a NOOP would throw the client protocol out of sync.
         */
-       if (FD_ISSET(0, &rfds)) {
+       if ((retval > 0) && FD_ISSET(0, &rfds)) {
                set_keepalives(KA_NO);
                the_character = inkey();
                set_keepalives(KA_YES);
@@ -284,7 +284,6 @@ void set_keepalives(int s)
 
 static time_t idlet = 0;
 static void really_do_keepalive(void) {
-       int r;                          /* IPC response code */
 
        time(&idlet);
 
@@ -298,7 +297,7 @@ static void really_do_keepalive(void) {
         * wait for a response.
         */
        if (keepalives_enabled == KA_YES) {
-               r = CtdlIPCNoop(ipc_for_signal_handlers);
+               CtdlIPCNoop(ipc_for_signal_handlers);
                if (instant_msgs > 0) {
                        if (ok_to_interrupt == 1) {
                                scr_printf("\r%64s\r", "");
@@ -1021,7 +1020,6 @@ int getcmd(CtdlIPC *ipc, char *argbuf)
        scr_printf("\n%s", room_name);
        color(DIM_WHITE);
        scr_printf("%c ", room_prompt(room_flags));
-       scr_flush();
 
        while (1) {
                ch = inkey();
@@ -1421,7 +1419,6 @@ void color(int colornum)
                                        (colornum & 7),
                                        rc_color_use_bg);
 
-               scr_flush();
        }
 }
 
@@ -1430,7 +1427,6 @@ void cls(int colornum)
        if (enable_color) {
                printf("\033[4%dm\033[2J\033[H\033[0m",
                                colornum ? colornum : rc_color_use_bg);
-               scr_flush();
        }
 }
 
@@ -1479,6 +1475,11 @@ void look_for_ansi(void)
                        if (FD_ISSET(0, &rfds)) {
                                abuf[strlen(abuf) + 1] = 0;
                                rv = read(0, &abuf[strlen(abuf)], 1);
+                               if (rv < 0) {
+                                       scr_printf("failed to read after select: %s", 
+                                                  strerror(errno));
+                                       break;
+                               }
                        }
                } while (FD_ISSET(0, &rfds));