use the gnu format string checker for CtdlLogPrintf; fix associated new warnings...
[citadel.git] / citadel / threads.c
index 6e95ed3b3d017d83510e1c84ead9609299de1d85..0dcf4c38e8e4c255a98bc23e3cde03cf14a988f7 100644 (file)
@@ -1,19 +1,34 @@
 /*
- * $Id: sysdep.c 5882 2007-12-13 19:46:05Z davew $
+ * Thread handling stuff for Citadel server
  *
- * Citadel "system dependent" stuff.
- * See copyright.txt for copyright information.
+ * Copyright (c) 1987-2010 by the citadel.org team
  *
- * Here's where we have the Citadel thread implimentation
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
  *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
+#include <stdlib.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <sys/types.h>
 #include <errno.h>
 #include <sys/socket.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <signal.h>
 
+#include "sysdep.h"
 #if TIME_WITH_SYS_TIME
 # include <sys/time.h>
 # include <time.h>
 # endif
 #endif
 
+#ifdef HAVE_SYSCALL_H
+# include <syscall.h>
+#else 
+# if HAVE_SYS_SYSCALL_H
+#  include <sys/syscall.h>
+# endif
+#endif
+
+#include <libcitadel.h>
+
 #include "threads.h"
 #include "ctdl_module.h"
 #include "modules_init.h"
@@ -32,6 +57,8 @@
 #include "config.h"
 #include "citserver.h"
 #include "sysdep_decls.h"
+#include "context.h"
+#include "event_client.h"
 
 /*
  * define this to use the new worker_thread method of handling connections
  * remove the need for the calls to eCrashRegisterThread and friends
  */
 
-static int num_threads = 0;    /* Current number of threads */
-static int num_workers = 0;    /* Current number of worker threads */
+static int num_threads = 0;                    /* Current number of threads */
+static int num_workers = 0;                    /* Current number of worker threads */
+long statcount = 0;            /* are we doing a stats check? */
+static long stats_done = 0;
 
 CtdlThreadNode *CtdlThreadList = NULL;
 CtdlThreadNode *CtdlThreadSchedList = NULL;
 
-static citthread_t GC_thread;
+static CtdlThreadNode *GC_thread = NULL;
 static char *CtdlThreadStates[CTDL_THREAD_LAST_STATE];
 double CtdlThreadLoadAvg = 0;
 double CtdlThreadWorkerAvg = 0;
@@ -65,9 +94,6 @@ citthread_key_t ThreadKey;
 
 citthread_mutex_t Critters[MAX_SEMAPHORES];    /* Things needing locking */
 
-int idle_workers = 0;
-citthread_cond_t worker_block;
-citthread_mutex_t worker_block_mutex;
 
 
 void InitialiseSemaphores(void)
@@ -75,7 +101,7 @@ void InitialiseSemaphores(void)
        int i;
 
        /* Set up a bunch of semaphores to be used for critical sections */
-       for (i = 0; i < MAX_SEMAPHORES; ++i) {
+       for (i=0; i<MAX_SEMAPHORES; ++i) {
                citthread_mutex_init(&Critters[i], NULL);
        }
 }
@@ -93,12 +119,12 @@ int try_critical_section(int which_one)
         * ensure nobody ever tries to do a critical section within a
         * transaction; this could lead to deadlock.
         */
-       if ((which_one != S_FLOORCACHE)
+       if (    (which_one != S_FLOORCACHE)
 #ifdef DEBUG_MEMORY_LEAKS
-           && (which_one != S_DEBUGMEMLEAKS)
+               && (which_one != S_DEBUGMEMLEAKS)
 #endif
-           && (which_one != S_RPLIST)
-           ) {
+               && (which_one != S_RPLIST)
+       ) {
                cdb_check_handles();
        }
        return (citthread_mutex_trylock(&Critters[which_one]));
@@ -116,12 +142,12 @@ void begin_critical_section(int which_one)
         * ensure nobody ever tries to do a critical section within a
         * transaction; this could lead to deadlock.
         */
-       if ((which_one != S_FLOORCACHE)
+       if (    (which_one != S_FLOORCACHE)
 #ifdef DEBUG_MEMORY_LEAKS
-           && (which_one != S_DEBUGMEMLEAKS)
+               && (which_one != S_DEBUGMEMLEAKS)
 #endif
-           && (which_one != S_RPLIST)
-           ) {
+               && (which_one != S_RPLIST)
+       ) {
                cdb_check_handles();
        }
        citthread_mutex_lock(&Critters[which_one]);
@@ -154,16 +180,11 @@ static void ctdl_thread_internal_dest_tsd(void *arg)
 void ctdl_thread_internal_init_tsd(void)
 {
        int ret;
-
-       if ((ret =
-            citthread_key_create(&ThreadKey,
-                                 ctdl_thread_internal_dest_tsd))) {
-               lprintf(CTDL_EMERG, "citthread_key_create: %s\n",
-                       strerror(ret));
+       
+       if ((ret = citthread_key_create(&ThreadKey, ctdl_thread_internal_dest_tsd))) {
+               CtdlLogPrintf(CTDL_EMERG, "citthread_key_create: %s\n", strerror(ret));
                exit(CTDLEXIT_DB);
        }
-       citthread_mutex_init (&worker_block_mutex, NULL);
-       citthread_cond_init(&worker_block, NULL);
 }
 
 /*
@@ -185,7 +206,7 @@ void CtdlThreadAllocTSD(void)
 
        memset(tsd->cursors, 0, sizeof tsd->cursors);
        tsd->self = NULL;
-
+       
        citthread_setspecific(ThreadKey, tsd);
 }
 
@@ -201,14 +222,16 @@ void ctdl_thread_internal_cleanup(void)
 {
        int i;
        CtdlThreadNode *this_thread, *that_thread;
-
-       for (i = 0; i < CTDL_THREAD_LAST_STATE; i++) {
-               free(CtdlThreadStates[i]);
+       
+       for (i=0; i<CTDL_THREAD_LAST_STATE; i++)
+       {
+               free (CtdlThreadStates[i]);
        }
-
+       
        /* Clean up the scheduled thread list */
        this_thread = CtdlThreadSchedList;
-       while (this_thread) {
+       while (this_thread)
+       {
                that_thread = this_thread;
                this_thread = this_thread->next;
                citthread_mutex_destroy(&that_thread->ThreadMutex);
@@ -225,70 +248,64 @@ void ctdl_thread_internal_init(void)
 {
        CtdlThreadNode *this_thread;
        int ret = 0;
-
-       GC_thread = citthread_self();
-       CtdlThreadStates[CTDL_THREAD_INVALID] = strdup("Invalid Thread");
+       
+       CtdlThreadStates[CTDL_THREAD_INVALID] = strdup ("Invalid Thread");
        CtdlThreadStates[CTDL_THREAD_VALID] = strdup("Valid Thread");
-       CtdlThreadStates[CTDL_THREAD_CREATE] =
-           strdup("Thread being Created");
-       CtdlThreadStates[CTDL_THREAD_CANCELLED] =
-           strdup("Thread Cancelled");
+       CtdlThreadStates[CTDL_THREAD_CREATE] = strdup("Thread being Created");
+       CtdlThreadStates[CTDL_THREAD_CANCELLED] = strdup("Thread Cancelled");
        CtdlThreadStates[CTDL_THREAD_EXITED] = strdup("Thread Exited");
        CtdlThreadStates[CTDL_THREAD_STOPPING] = strdup("Thread Stopping");
-       CtdlThreadStates[CTDL_THREAD_STOP_REQ] =
-           strdup("Thread Stop Requested");
+       CtdlThreadStates[CTDL_THREAD_STOP_REQ] = strdup("Thread Stop Requested");
        CtdlThreadStates[CTDL_THREAD_SLEEPING] = strdup("Thread Sleeping");
        CtdlThreadStates[CTDL_THREAD_RUNNING] = strdup("Thread Running");
        CtdlThreadStates[CTDL_THREAD_BLOCKED] = strdup("Thread Blocked");
-
+       
        /* Get ourself a thread entry */
        this_thread = malloc(sizeof(CtdlThreadNode));
        if (this_thread == NULL) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, can't allocate CtdlThreadNode, exiting\n");
+               CtdlLogPrintf(CTDL_EMERG, "Thread system, can't allocate CtdlThreadNode, exiting\n");
                return;
        }
        // Ensuring this is zero'd means we make sure the thread doesn't start doing its thing until we are ready.
-       memset(this_thread, 0, sizeof(CtdlThreadNode));
-
-       citthread_mutex_init(&(this_thread->ThreadMutex), NULL);
-       citthread_cond_init(&(this_thread->ThreadCond), NULL);
-       citthread_mutex_init(&(this_thread->SleepMutex), NULL);
-       citthread_cond_init(&(this_thread->SleepCond), NULL);
-
+       memset (this_thread, 0, sizeof(CtdlThreadNode));
+       
+       citthread_mutex_init (&(this_thread->ThreadMutex), NULL);
+       citthread_cond_init (&(this_thread->ThreadCond), NULL);
+       citthread_mutex_init (&(this_thread->SleepMutex), NULL);
+       citthread_cond_init (&(this_thread->SleepCond), NULL);
+       
        /* We are garbage collector so create us as running */
        this_thread->state = CTDL_THREAD_RUNNING;
-
+       
        if ((ret = citthread_attr_init(&this_thread->attr))) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, citthread_attr_init: %s\n",
-                             strerror(ret));
+               CtdlLogPrintf(CTDL_EMERG, "Thread system, citthread_attr_init: %s\n", strerror(ret));
                free(this_thread);
                return;
        }
 
        this_thread->name = "Garbage Collection Thread";
-
-       this_thread->tid = GC_thread;
+       
+       this_thread->tid = citthread_self();
+       GC_thread = this_thread;
        CT = this_thread;
-
-       num_threads++;          // Increase the count of threads in the system.
+       
+       num_threads++;  // Increase the count of threads in the system.
 
        this_thread->next = CtdlThreadList;
        CtdlThreadList = this_thread;
        if (this_thread->next)
                this_thread->next->prev = this_thread;
        /* Set up start times */
-       gettimeofday(&this_thread->start_time, NULL);   /* Time this thread started */
-       memcpy(&this_thread->last_state_change, &this_thread->start_time, sizeof(struct timeval));      /* Changed state so mark it. */
+       gettimeofday(&this_thread->start_time, NULL);           /* Time this thread started */
+       memcpy(&this_thread->last_state_change, &this_thread->start_time, sizeof (struct timeval));     /* Changed state so mark it. */
 }
 
 
 /*
  * A function to update a threads load averages
  */
-void ctdl_thread_internal_update_avgs(CtdlThreadNode * this_thread)
-{
+ void ctdl_thread_internal_update_avgs(CtdlThreadNode *this_thread)
+ {
        struct timeval now, result;
        double last_duration;
 
@@ -297,42 +314,33 @@ void ctdl_thread_internal_update_avgs(CtdlThreadNode * this_thread)
        /* I don't think these mutex's are needed here */
        citthread_mutex_lock(&this_thread->ThreadMutex);
        // result now has a timeval for the time we spent in the last state since we last updated
-       last_duration =
-           (double) result.tv_sec +
-           ((double) result.tv_usec / (double) 1000000);
+       last_duration = (double)result.tv_sec + ((double)result.tv_usec / (double) 1000000);
        if (this_thread->state == CTDL_THREAD_SLEEPING)
                this_thread->avg_sleeping += last_duration;
        if (this_thread->state == CTDL_THREAD_RUNNING)
                this_thread->avg_running += last_duration;
        if (this_thread->state == CTDL_THREAD_BLOCKED)
                this_thread->avg_blocked += last_duration;
-       memcpy(&this_thread->last_state_change, &now,
-              sizeof(struct timeval));
+       memcpy (&this_thread->last_state_change, &now, sizeof (struct timeval));
        citthread_mutex_unlock(&this_thread->ThreadMutex);
 }
 
 /*
  * A function to chenge the state of a thread
  */
-void ctdl_thread_internal_change_state(CtdlThreadNode * this_thread,
-                                      enum CtdlThreadState new_state)
+void ctdl_thread_internal_change_state (CtdlThreadNode *this_thread, enum CtdlThreadState new_state)
 {
        /*
         * Wether we change state or not we need update the load values
         */
        ctdl_thread_internal_update_avgs(this_thread);
        /* This mutex not needed here? */
-       citthread_mutex_lock(&this_thread->ThreadMutex);        /* To prevent race condition of a sleeping thread */
-       if ((new_state == CTDL_THREAD_STOP_REQ)
-           && (this_thread->state > CTDL_THREAD_STOP_REQ))
+       citthread_mutex_lock(&this_thread->ThreadMutex); /* To prevent race condition of a sleeping thread */
+       if ((new_state == CTDL_THREAD_STOP_REQ) && (this_thread->state > CTDL_THREAD_STOP_REQ))
                this_thread->state = new_state;
-       if (((new_state == CTDL_THREAD_SLEEPING)
-            || (new_state == CTDL_THREAD_BLOCKED))
-           && (this_thread->state == CTDL_THREAD_RUNNING))
+       if (((new_state == CTDL_THREAD_SLEEPING) || (new_state == CTDL_THREAD_BLOCKED)) && (this_thread->state == CTDL_THREAD_RUNNING))
                this_thread->state = new_state;
-       if ((new_state == CTDL_THREAD_RUNNING)
-           && ((this_thread->state == CTDL_THREAD_SLEEPING)
-               || (this_thread->state == CTDL_THREAD_BLOCKED)))
+       if ((new_state == CTDL_THREAD_RUNNING) && ((this_thread->state == CTDL_THREAD_SLEEPING) || (this_thread->state == CTDL_THREAD_BLOCKED)))
                this_thread->state = new_state;
        citthread_mutex_unlock(&this_thread->ThreadMutex);
 }
@@ -343,29 +351,36 @@ void ctdl_thread_internal_change_state(CtdlThreadNode * this_thread,
  */
 void CtdlThreadStopAll(void)
 {
+       /* First run any registered shutdown hooks.  This probably doesn't belong here. */
+       PerformSessionHooks(EVT_SHUTDOWN);
+       
+       /* then close all tcp ports so nobody else can talk to us anymore. */
+       CtdlShutdownServiceHooks();
        //FIXME: The signalling of the condition should not be in the critical_section
        // We need to build a list of threads we are going to signal and then signal them afterwards
+       
+       ShutDownEventQueue();
 
        CtdlThreadNode *this_thread;
-
+       
        begin_critical_section(S_THREAD_LIST);
        this_thread = CtdlThreadList;
-       while (this_thread) {
-#ifdef THREADS_USESIGNALS
-               citthread_killl(this_thread->tid, SIGHUP);
-#endif
-               citthread_kill(this_thread->tid, SIGUSR1);
-               ctdl_thread_internal_change_state(this_thread,
-                                                 CTDL_THREAD_STOP_REQ);
+       // Ask the GC thread to stop first so everything knows we are shutting down.
+       GC_thread->state = CTDL_THREAD_STOP_REQ;
+       while(this_thread)
+       {
+               if (!citthread_equal(this_thread->tid, GC_thread->tid))
+                       citthread_kill(this_thread->tid, SIGHUP);
+
+               ctdl_thread_internal_change_state (this_thread, CTDL_THREAD_STOP_REQ);
                citthread_cond_signal(&this_thread->ThreadCond);
                citthread_cond_signal(&this_thread->SleepCond);
-               CtdlLogPrintf(CTDL_DEBUG,
-                             "Thread system stopping thread \"%s\" (%ld).\n",
-                             this_thread->name, this_thread->tid);
+               this_thread->stop_ticker = time(NULL);
+               CtdlLogPrintf(CTDL_DEBUG, "Thread system stopping thread \"%s\" (0x%08lx).\n",
+                       this_thread->name, this_thread->tid);
                this_thread = this_thread->next;
        }
        end_critical_section(S_THREAD_LIST);
-       citthread_cond_broadcast(&worker_block);
 }
 
 
@@ -375,13 +390,15 @@ void CtdlThreadStopAll(void)
 void CtdlThreadWakeAll(void)
 {
        CtdlThreadNode *this_thread;
-
+       
        CtdlLogPrintf(CTDL_DEBUG, "Thread system waking all threads.\n");
-
+       
        begin_critical_section(S_THREAD_LIST);
        this_thread = CtdlThreadList;
-       while (this_thread) {
-               if (!this_thread->thread_func) {
+       while(this_thread)
+       {
+               if (!this_thread->thread_func)
+               {
                        citthread_cond_signal(&this_thread->ThreadCond);
                        citthread_cond_signal(&this_thread->SleepCond);
                }
@@ -396,32 +413,55 @@ void CtdlThreadWakeAll(void)
  */
 int CtdlThreadGetCount(void)
 {
-       return num_threads;
+       return  num_threads;
 }
 
 int CtdlThreadGetWorkers(void)
 {
-       return num_workers;
+       return  num_workers;
 }
 
 double CtdlThreadGetWorkerAvg(void)
 {
        double ret;
-
+       
        begin_critical_section(S_THREAD_LIST);
-       ret = CtdlThreadWorkerAvg;
+       ret =  CtdlThreadWorkerAvg;
        end_critical_section(S_THREAD_LIST);
        return ret;
 }
 
 double CtdlThreadGetLoadAvg(void)
 {
-       double ret;
+       double load_avg[3] = {0.0, 0.0, 0.0};
+
+       int ret = 0;
+       int smp_num_cpus;
+
+       /* Borrowed this straight from procps */
+       smp_num_cpus = sysconf(_SC_NPROCESSORS_ONLN);
+       if(smp_num_cpus<1) smp_num_cpus=1; /* SPARC glibc is buggy */
+
+#ifdef HAVE_GETLOADAVG
+       ret = getloadavg(load_avg, 3);
+#endif
+       if (ret < 0)
+               return 0;
+       return load_avg[0] / smp_num_cpus;
+/*
+ * This old chunk of code return a value that indicated the load on citserver
+ * This value could easily reach 100 % even when citserver was doing very little and
+ * hence the machine has much more spare capacity.
+ * Because this value was used to determine if the machine was under heavy load conditions
+ * from other processes in the system then citserver could be strangled un-necesarily
+ * What we are actually trying to achieve is to strangle citserver if the machine is heavily loaded.
+ * So we have changed this.
 
        begin_critical_section(S_THREAD_LIST);
-       ret = CtdlThreadLoadAvg;
+       ret =  CtdlThreadLoadAvg;
        end_critical_section(S_THREAD_LIST);
        return ret;
+*/
 }
 
 
@@ -434,47 +474,45 @@ double CtdlThreadGetLoadAvg(void)
 const char *CtdlThreadName(const char *name)
 {
        const char *old_name;
-
-       if (!CT) {
-               CtdlLogPrintf(CTDL_WARNING,
-                             "Thread system WARNING. Attempt to CtdlThreadRename() a non thread. %s\n",
-                             name);
+       
+       if (!CT)
+       {
+               CtdlLogPrintf(CTDL_WARNING, "Thread system WARNING. Attempt to CtdlThreadRename() a non thread. %s\n", name);
                return NULL;
        }
        old_name = CT->name;
        if (name)
                CT->name = name;
        return (old_name);
-}
+}      
 
 
 /*
  * A function to force a thread to exit
  */
-void CtdlThreadCancel(CtdlThreadNode * thread)
+void CtdlThreadCancel(CtdlThreadNode *thread)
 {
        CtdlThreadNode *this_thread;
-
+       
        if (!thread)
                this_thread = CT;
        else
                this_thread = thread;
-       if (!this_thread) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system PANIC. Attempt to CtdlThreadCancel() a non thread.\n");
+       if (!this_thread)
+       {
+               CtdlLogPrintf(CTDL_EMERG, "Thread system PANIC. Attempt to CtdlThreadCancel() a non thread.\n");
                CtdlThreadStopAll();
                return;
        }
-
-       if (!this_thread->thread_func) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system PANIC. Attempt to CtdlThreadCancel() the garbage collector.\n");
+       
+       if (!this_thread->thread_func)
+       {
+               CtdlLogPrintf(CTDL_EMERG, "Thread system PANIC. Attempt to CtdlThreadCancel() the garbage collector.\n");
                CtdlThreadStopAll();
                return;
        }
-
-       ctdl_thread_internal_change_state(this_thread,
-                                         CTDL_THREAD_CANCELLED);
+       
+       ctdl_thread_internal_change_state (this_thread, CTDL_THREAD_CANCELLED);
        citthread_cancel(this_thread->tid);
 }
 
@@ -485,27 +523,30 @@ void CtdlThreadCancel(CtdlThreadNode * thread)
 int CtdlThreadCheckStop(void)
 {
        int state;
-
-       if (!CT) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system PANIC, CtdlThreadCheckStop() called by a non thread.\n");
+       
+       if (!CT)
+       {
+               CtdlLogPrintf(CTDL_EMERG, "Thread system PANIC, CtdlThreadCheckStop() called by a non thread.\n");
                CtdlThreadStopAll();
                return -1;
        }
-
+       
        state = CT->state;
 
-#ifdef THREADS_USERSIGNALS
        if (CT->signal)
-               CtdlLogPrintf(CTDL_DEBUG,
-                             "Thread \"%s\" caught signal %d.\n",
-                             CT->name, CT->signal);
-#endif
-       if (state == CTDL_THREAD_STOP_REQ) {
+       {
+               CtdlLogPrintf(CTDL_DEBUG, "Thread \"%s\" caught signal %d.\n", CT->name, CT->signal);
+               if (CT->signal == SIGHUP)
+                       CT->state = CTDL_THREAD_STOP_REQ;
+               CT->signal = 0;
+       }
+       if(state == CTDL_THREAD_STOP_REQ)
+       {
                CT->state = CTDL_THREAD_STOPPING;
                return -1;
-       } else if ((state < CTDL_THREAD_STOP_REQ)
-                  && (state > CTDL_THREAD_CREATE)) {
+       }
+       else if((state < CTDL_THREAD_STOP_REQ) && (state > CTDL_THREAD_CREATE))
+       {
                return -1;
        }
        return 0;
@@ -516,10 +557,10 @@ int CtdlThreadCheckStop(void)
  * A function to ask a thread to exit
  * The thread must call CtdlThreadCheckStop() periodically to determine if it should exit
  */
-void CtdlThreadStop(CtdlThreadNode * thread)
+void CtdlThreadStop(CtdlThreadNode *thread)
 {
        CtdlThreadNode *this_thread;
-
+       
        if (!thread)
                this_thread = CT;
        else
@@ -527,14 +568,15 @@ void CtdlThreadStop(CtdlThreadNode * thread)
        if (!this_thread)
                return;
        if (!(this_thread->thread_func))
-               return;         // Don't stop garbage collector
-#ifdef THREADS_USESIGNALS
-       citthread_kill(this_thread->tid, SIGHUP);
-#endif
-       ctdl_thread_internal_change_state(this_thread,
-                                         CTDL_THREAD_STOP_REQ);
+               return;         // Don't stop garbage collector
+
+       if (!citthread_equal(this_thread->tid, GC_thread->tid))
+               citthread_kill(this_thread->tid, SIGHUP);
+
+       ctdl_thread_internal_change_state (this_thread, CTDL_THREAD_STOP_REQ);
        citthread_cond_signal(&this_thread->ThreadCond);
        citthread_cond_signal(&this_thread->SleepCond);
+       this_thread->stop_ticker = time(NULL);
 }
 
 /*
@@ -544,27 +586,26 @@ void CtdlThreadSleep(int secs)
 {
        struct timespec wake_time;
        struct timeval time_now;
-
-
-       if (!CT) {
-               CtdlLogPrintf(CTDL_WARNING,
-                             "CtdlThreadSleep() called by something that is not a thread. Should we die?\n");
+       
+       
+       if (!CT)
+       {
+               CtdlLogPrintf(CTDL_WARNING, "CtdlThreadSleep() called by something that is not a thread. Should we die?\n");
                return;
        }
-
-       memset(&wake_time, 0, sizeof(struct timespec));
+       
+       memset (&wake_time, 0, sizeof(struct timespec));
        gettimeofday(&time_now, NULL);
        wake_time.tv_sec = time_now.tv_sec + secs;
        wake_time.tv_nsec = time_now.tv_usec * 10;
 
-       ctdl_thread_internal_change_state(CT, CTDL_THREAD_SLEEPING);
-
-       citthread_mutex_lock(&CT->ThreadMutex); /* Prevent something asking us to awaken before we've gone to sleep */
-       citthread_cond_timedwait(&CT->SleepCond, &CT->ThreadMutex,
-                                &wake_time);
+       ctdl_thread_internal_change_state (CT, CTDL_THREAD_SLEEPING);
+       
+       citthread_mutex_lock(&CT->ThreadMutex); /* Prevent something asking us to awaken before we've gone to sleep */
+       citthread_cond_timedwait(&CT->SleepCond, &CT->ThreadMutex, &wake_time);
        citthread_mutex_unlock(&CT->ThreadMutex);
-
-       ctdl_thread_internal_change_state(CT, CTDL_THREAD_RUNNING);
+       
+       ctdl_thread_internal_change_state (CT, CTDL_THREAD_RUNNING);
 }
 
 
@@ -577,13 +618,22 @@ static void ctdl_internal_thread_cleanup(void *arg)
         * In here we were called by the current thread because it is exiting
         * NB. WE ARE THE CURRENT THREAD
         */
-       CtdlLogPrintf(CTDL_NOTICE, "Thread \"%s\" (%ld) exited.\n",
-                     CT->name, CT->tid);
-
-#ifdef HAVE_BACKTRACE
-       eCrash_UnregisterThread();
-#endif
+       if (CT)
+       {
+               const char *name = CT->name;
+               const pid_t tid = CT->tid;
 
+               CtdlLogPrintf(CTDL_NOTICE, "Thread \"%s\" (0x%08lx) exited.\n", name, (unsigned long) tid);
+       }
+       else 
+       {
+               CtdlLogPrintf(CTDL_NOTICE, "some ((unknown ? ? ?) Thread exited.\n");
+       }
+       
+       #ifdef HAVE_BACKTRACE
+///    eCrash_UnregisterThread();
+       #endif
+       
        citthread_mutex_lock(&CT->ThreadMutex);
        CT->state = CTDL_THREAD_EXITED; // needs to be last thing else house keeping will unlink us too early
        citthread_mutex_unlock(&CT->ThreadMutex);
@@ -601,43 +651,38 @@ void ctdl_thread_internal_calc_loadavg(void)
        that_thread = CtdlThreadList;
        load_avg = 0;
        worker_avg = 0;
-       while (that_thread) {
+       while(that_thread)
+       {
                /* Update load averages */
                ctdl_thread_internal_update_avgs(that_thread);
                citthread_mutex_lock(&that_thread->ThreadMutex);
-               that_thread->load_avg =
-                   (that_thread->avg_sleeping +
-                    that_thread->avg_running) /
-                   (that_thread->avg_sleeping + that_thread->avg_running +
-                    that_thread->avg_blocked) * 100;
+               that_thread->load_avg = (that_thread->avg_sleeping + that_thread->avg_running) / (that_thread->avg_sleeping + that_thread->avg_running + that_thread->avg_blocked) * 100;
                that_thread->avg_sleeping /= 2;
                that_thread->avg_running /= 2;
                that_thread->avg_blocked /= 2;
                load_avg += that_thread->load_avg;
-               if (that_thread->flags & CTDLTHREAD_WORKER) {
+               if (that_thread->flags & CTDLTHREAD_WORKER)
+               {
                        worker_avg += that_thread->load_avg;
                        workers++;
                }
 #ifdef WITH_THREADLOG
-               CtdlLogPrintf(CTDL_DEBUG,
-                             "CtdlThread, \"%s\" (%lu) \"%s\" %.2f %.2f %.2f %.2f\n",
-                             that_thread->name, that_thread->tid,
-                             CtdlThreadStates[that_thread->state],
-                             that_thread->avg_sleeping,
-                             that_thread->avg_running,
-                             that_thread->avg_blocked,
-                             that_thread->load_avg);
+               CtdlLogPrintf(CTDL_DEBUG, "CtdlThread, \"%s\" (%lu) \"%s\" %.2f %.2f %.2f %.2f\n",
+                       that_thread->name,
+                       that_thread->tid,
+                       CtdlThreadStates[that_thread->state],
+                       that_thread->avg_sleeping,
+                       that_thread->avg_running,
+                       that_thread->avg_blocked,
+                       that_thread->load_avg);
 #endif
                citthread_mutex_unlock(&that_thread->ThreadMutex);
                that_thread = that_thread->next;
        }
-       CtdlThreadLoadAvg = load_avg / num_threads;
-       CtdlThreadWorkerAvg = worker_avg / workers;
+       CtdlThreadLoadAvg = load_avg/num_threads;
+       CtdlThreadWorkerAvg = worker_avg/workers;
 #ifdef WITH_THREADLOG
-       CtdlLogPrintf(CTDL_INFO,
-                     "System load average %.2f, workers averag %.2f, threads %d, workers %d, sessions %d\n",
-                     CtdlThreadLoadAvg, CtdlThreadWorkerAvg, num_threads,
-                     num_workers, num_sessions);
+       CtdlLogPrintf(CTDL_INFO, "System load average %.2f, workers averag %.2f, threads %d, workers %d, sessions %d\n", CtdlThreadGetLoadAvg(), CtdlThreadWorkerAvg, num_threads, num_workers, num_sessions);
 #endif
 }
 
@@ -646,64 +691,91 @@ void ctdl_thread_internal_calc_loadavg(void)
  * Garbage collection routine.
  * Gets called by main() in a loop to clean up the thread list periodically.
  */
-void CtdlThreadGC(void)
+void CtdlThreadGC (void)
 {
        CtdlThreadNode *this_thread, *that_thread;
        int workers = 0, sys_workers;
-       int ret = 0;
+       int ret=0;
 
        begin_critical_section(S_THREAD_LIST);
-
+       
        /* Handle exiting of garbage collector thread */
-       if (num_threads == 1)
+       if(num_threads == 1)
                CtdlThreadList->state = CTDL_THREAD_EXITED;
-
+       
 #ifdef WITH_THREADLOG
-       CtdlLogPrintf(CTDL_DEBUG,
-                     "Thread system running garbage collection.\n");
+       CtdlLogPrintf(CTDL_DEBUG, "Thread system running garbage collection.\n");
 #endif
        /*
         * Woke up to do garbage collection
         */
        this_thread = CtdlThreadList;
-       while (this_thread) {
+       while(this_thread)
+       {
                that_thread = this_thread;
                this_thread = this_thread->next;
-
+               
+               if ((that_thread->state == CTDL_THREAD_STOP_REQ || that_thread->state == CTDL_THREAD_STOPPING)
+                       && (!citthread_equal(that_thread->tid, citthread_self())))
+               {
+                       CtdlLogPrintf(CTDL_DEBUG, "Waiting for thread %s (0x%08lx) to exit.\n", that_thread->name, that_thread->tid);
+                       terminate_stuck_sessions();
+               }
+               else
+               {
+                       /**
+                        * Catch the situation where a worker was asked to stop but couldn't and we are not
+                        * shutting down.
+                        */
+                       that_thread->stop_ticker = 0;
+               }
+               
+               if (that_thread->stop_ticker + 5 == time(NULL))
+               {
+                       CtdlLogPrintf(CTDL_DEBUG, "Thread System: The thread \"%s\" (0x%08lx) failed to self terminate within 5 ticks. It would be cancelled now.\n", that_thread->name, that_thread->tid);
+                       if ((that_thread->flags & CTDLTHREAD_WORKER) == 0)
+                               CtdlLogPrintf(CTDL_INFO, "Thread System: A non worker thread would have been canceled this may cause message loss.\n");
+//                     that_thread->state = CTDL_THREAD_CANCELLED;
+                       that_thread->stop_ticker++;
+//                     citthread_cancel(that_thread->tid);
+//                     continue;
+               }
+               
                /* Do we need to clean up this thread? */
-               if (that_thread->state != CTDL_THREAD_EXITED) {
-                       if (that_thread->flags & CTDLTHREAD_WORKER)
+               if ((that_thread->state != CTDL_THREAD_EXITED) && (that_thread->state != CTDL_THREAD_CANCELLED))
+               {
+                       if(that_thread->flags & CTDLTHREAD_WORKER)
                                workers++;      /* Sanity check on number of worker threads */
                        continue;
                }
-
-               if (citthread_equal(that_thread->tid, citthread_self()) && that_thread->thread_func) {  /* Sanity check */
+               
+               if (citthread_equal(that_thread->tid, citthread_self()) && that_thread->thread_func)
+               {       /* Sanity check */
                        end_critical_section(S_THREAD_LIST);
-                       CtdlLogPrintf(CTDL_EMERG,
-                                     "Thread system PANIC, a thread is trying to clean up after itself.\n");
+                       CtdlLogPrintf(CTDL_EMERG, "Thread system PANIC, a thread is trying to clean up after itself.\n");
                        abort();
                        return;
                }
-
-               if (num_threads <= 0) { /* Sanity check */
+               
+               if (num_threads <= 0)
+               {       /* Sanity check */
                        end_critical_section(S_THREAD_LIST);
-                       CtdlLogPrintf(CTDL_EMERG,
-                                     "Thread system PANIC, num_threads <= 0 and trying to do Garbage Collection.\n");
+                       CtdlLogPrintf(CTDL_EMERG, "Thread system PANIC, num_threads <= 0 and trying to do Garbage Collection.\n");
                        abort();
                        return;
                }
 
-               if (that_thread->flags & CTDLTHREAD_WORKER)
+               if(that_thread->flags & CTDLTHREAD_WORKER)
                        num_workers--;  /* This is a wroker thread so reduce the count. */
                num_threads--;
                /* If we are unlinking the list head then the next becomes the list head */
-               if (that_thread->prev)
+               if(that_thread->prev)
                        that_thread->prev->next = that_thread->next;
                else
                        CtdlThreadList = that_thread->next;
-               if (that_thread->next)
+               if(that_thread->next)
                        that_thread->next->prev = that_thread->prev;
-
+               
                citthread_cond_signal(&that_thread->ThreadCond);
                citthread_cond_signal(&that_thread->SleepCond); // Make sure this thread is awake
                citthread_mutex_lock(&that_thread->ThreadMutex);        // Make sure it has done what its doing
@@ -713,25 +785,20 @@ void CtdlThreadGC(void)
                 * Also makes sure the thread has cleaned up after itself before we remove it from the list
                 * We can join on the garbage collector thread the join should just return EDEADLCK
                 */
-               ret = citthread_join(that_thread->tid, NULL);
+               ret = citthread_join (that_thread->tid, NULL);
                if (ret == EDEADLK)
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "Garbage collection on own thread.\n");
+                       CtdlLogPrintf(CTDL_DEBUG, "Garbage collection on own thread.\n");
                else if (ret == EINVAL)
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "Garbage collection, that thread already joined on.\n");
+                       CtdlLogPrintf(CTDL_DEBUG, "Garbage collection, that thread already joined on.\n");
                else if (ret == ESRCH)
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "Garbage collection, no thread to join on.\n");
+                       CtdlLogPrintf(CTDL_DEBUG, "Garbage collection, no thread to join on.\n");
                else if (ret != 0)
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "Garbage collection, citthread_join returned an unknown error.\n");
+                       CtdlLogPrintf(CTDL_DEBUG, "Garbage collection, citthread_join returned an unknown error(%d).\n", ret);
                /*
                 * Now we own that thread entry
                 */
-               CtdlLogPrintf(CTDL_INFO,
-                             "Garbage Collection for thread \"%s\" (%ld).\n",
-                             that_thread->name, that_thread->tid);
+               CtdlLogPrintf(CTDL_INFO, "Garbage Collection for thread \"%s\" (0x%08lx).\n",
+                       that_thread->name, that_thread->tid);
                citthread_mutex_destroy(&that_thread->ThreadMutex);
                citthread_cond_destroy(&that_thread->ThreadCond);
                citthread_mutex_destroy(&that_thread->SleepMutex);
@@ -741,25 +808,27 @@ void CtdlThreadGC(void)
        }
        sys_workers = num_workers;
        end_critical_section(S_THREAD_LIST);
-
+       
        /* Sanity check number of worker threads */
-       if (workers != sys_workers) {
+       if (workers != sys_workers)
+       {
                CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system PANIC, discrepancy in number of worker threads. Counted %d, should be %d.\n",
-                             workers, sys_workers);
+                       "Thread system PANIC, discrepancy in number of worker threads. Counted %d, should be %d.\n",
+                       workers, sys_workers
+                       );
                abort();
        }
 }
 
 
 
-
 /*
  * Runtime function for a Citadel Thread.
  * This initialises the threads environment and then calls the user supplied thread function
  * Note that this is the REAL thread function and wraps the users thread function.
- */
-static void *ctdl_internal_thread_func(void *arg)
+ */ 
+static void *ctdl_internal_thread_func (void *arg)
 {
        CtdlThreadNode *this_thread;
        void *ret = NULL;
@@ -770,53 +839,52 @@ static void *ctdl_internal_thread_func(void *arg)
         */
        begin_critical_section(S_THREAD_LIST);
        this_thread = (CtdlThreadNode *) arg;
-       gettimeofday(&this_thread->start_time, NULL);   /* Time this thread started */
-//      citthread_mutex_lock(&this_thread->ThreadMutex);
-
+       gettimeofday(&this_thread->start_time, NULL);           /* Time this thread started */
+       
        // Register the cleanup function to take care of when we exit.
        citthread_cleanup_push(ctdl_internal_thread_cleanup, NULL);
        // Get our thread data structure
        CtdlThreadAllocTSD();
        CT = this_thread;
        this_thread->pid = getpid();
-       memcpy(&this_thread->last_state_change, &this_thread->start_time, sizeof(struct timeval));      /* Changed state so mark it. */
+       memcpy(&this_thread->last_state_change, &this_thread->start_time, sizeof (struct timeval));     /* Changed state so mark it. */
        /* Only change to running state if we weren't asked to stop during the create cycle
         * Other wise there is a window to allow this threads creation to continue to full grown and
         * therby prevent a shutdown of the server.
         */
-//      citthread_mutex_unlock(&this_thread->ThreadMutex);
-
-       if (!CtdlThreadCheckStop()) {
+       if (!CtdlThreadCheckStop())
+       {
                citthread_mutex_lock(&this_thread->ThreadMutex);
                this_thread->state = CTDL_THREAD_RUNNING;
                citthread_mutex_unlock(&this_thread->ThreadMutex);
        }
        end_critical_section(S_THREAD_LIST);
-
+       
        // Register for tracing
-#ifdef HAVE_BACKTRACE
-       eCrash_RegisterThread(this_thread->name, 0);
-#endif
-
+       #ifdef HAVE_BACKTRACE
+///    eCrash_RegisterThread(this_thread->name, 0);
+       #endif
+       
        // Tell the world we are here
-       CtdlLogPrintf(CTDL_NOTICE, "Created a new thread \"%s\" (%ld). \n",
-                     this_thread->name, this_thread->tid);
-
-
-
+#if defined(HAVE_SYSCALL_H) && defined (SYS_gettid)
+       this_thread->reltid = syscall(SYS_gettid);
+#endif
+       CtdlLogPrintf(CTDL_NOTICE, "Created a new thread \"%s\" (0x%08lx).\n",
+               this_thread->name, this_thread->tid);
+       
        /*
         * run the thread to do the work but only if we haven't been asked to stop
         */
        if (!CtdlThreadCheckStop())
-               ret = (this_thread->thread_func) (this_thread->user_args);
-
+               ret = (this_thread->thread_func)(this_thread->user_args);
+       
        /*
         * Our thread is exiting either because it wanted to end or because the server is stopping
         * We need to clean up
         */
        citthread_cleanup_pop(1);       // Execute our cleanup routine and remove it
-
-       return (ret);
+       
+       return(ret);
 }
 
 
@@ -825,31 +893,28 @@ static void *ctdl_internal_thread_func(void *arg)
 /*
  * Function to initialise an empty thread structure
  */
-CtdlThreadNode *ctdl_internal_init_thread_struct(CtdlThreadNode *
-                                                this_thread, long flags)
+CtdlThreadNode *ctdl_internal_init_thread_struct(CtdlThreadNode *this_thread, long flags)
 {
        int ret = 0;
-
+       
        // Ensuring this is zero'd means we make sure the thread doesn't start doing its thing until we are ready.
-       memset(this_thread, 0, sizeof(CtdlThreadNode));
-
+       memset (this_thread, 0, sizeof(CtdlThreadNode));
+       
        /* Create the mutex's early so we can use them */
-       citthread_mutex_init(&(this_thread->ThreadMutex), NULL);
-       citthread_cond_init(&(this_thread->ThreadCond), NULL);
-       citthread_mutex_init(&(this_thread->SleepMutex), NULL);
-       citthread_cond_init(&(this_thread->SleepCond), NULL);
-
+       citthread_mutex_init (&(this_thread->ThreadMutex), NULL);
+       citthread_cond_init (&(this_thread->ThreadCond), NULL);
+       citthread_mutex_init (&(this_thread->SleepMutex), NULL);
+       citthread_cond_init (&(this_thread->SleepCond), NULL);
+       
        this_thread->state = CTDL_THREAD_CREATE;
-
+       
        if ((ret = citthread_attr_init(&this_thread->attr))) {
                citthread_mutex_unlock(&this_thread->ThreadMutex);
                citthread_mutex_destroy(&(this_thread->ThreadMutex));
                citthread_cond_destroy(&(this_thread->ThreadCond));
                citthread_mutex_destroy(&(this_thread->SleepMutex));
                citthread_cond_destroy(&(this_thread->SleepCond));
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, citthread_attr_init: %s\n",
-                             strerror(ret));
+               CtdlLogPrintf(CTDL_EMERG, "Thread system, citthread_attr_init: %s\n", strerror(ret));
                free(this_thread);
                return NULL;
        }
@@ -858,26 +923,20 @@ CtdlThreadNode *ctdl_internal_init_thread_struct(CtdlThreadNode *
         * otherwise the MIME parser crashes on FreeBSD, and the IMAP service
         * crashes on 64-bit Linux.
         */
-       if (flags & CTDLTHREAD_BIGSTACK) {
+       if (flags & CTDLTHREAD_BIGSTACK)
+       {
 #ifdef WITH_THREADLOG
-               CtdlLogPrintf(CTDL_INFO,
-                             "Thread system. Creating BIG STACK thread.\n");
+               CtdlLogPrintf(CTDL_INFO, "Thread system. Creating BIG STACK thread.\n");
 #endif
-               if ((ret =
-                    citthread_attr_setstacksize(&this_thread->attr,
-                                                THREADSTACKSIZE))) {
+               if ((ret = citthread_attr_setstacksize(&this_thread->attr, THREADSTACKSIZE))) {
                        citthread_mutex_unlock(&this_thread->ThreadMutex);
-                       citthread_mutex_destroy(&
-                                               (this_thread->
-                                                ThreadMutex));
+                       citthread_mutex_destroy(&(this_thread->ThreadMutex));
                        citthread_cond_destroy(&(this_thread->ThreadCond));
-                       citthread_mutex_destroy(&
-                                               (this_thread->SleepMutex));
+                       citthread_mutex_destroy(&(this_thread->SleepMutex));
                        citthread_cond_destroy(&(this_thread->SleepCond));
                        citthread_attr_destroy(&this_thread->attr);
-                       CtdlLogPrintf(CTDL_EMERG,
-                                     "Thread system, citthread_attr_setstacksize: %s\n",
-                                     strerror(ret));
+                       CtdlLogPrintf(CTDL_EMERG, "Thread system, citthread_attr_setstacksize: %s\n",
+                               strerror(ret));
                        free(this_thread);
                        return NULL;
                }
@@ -888,42 +947,38 @@ CtdlThreadNode *ctdl_internal_init_thread_struct(CtdlThreadNode *
         * because the creation didn't affect the load average.
         */
        this_thread->avg_blocked = 2;
-
+       
        return (this_thread);
 }
 
 
 
-
 /*
  * Internal function to create a thread.
- */
-CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags,
-                                           void *(*thread_func) (void
-                                                                 *arg),
-                                           void *args)
+ */ 
+CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags, void *(*thread_func) (void *arg), void *args)
 {
        int ret = 0;
        CtdlThreadNode *this_thread;
 
-       if (num_threads >= 32767) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system. Thread list full.\n");
+       if (num_threads >= 32767)
+       {
+               CtdlLogPrintf(CTDL_EMERG, "Thread system. Thread list full.\n");
                return NULL;
        }
-
+               
        this_thread = malloc(sizeof(CtdlThreadNode));
        if (this_thread == NULL) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, can't allocate CtdlThreadNode, exiting\n");
+               CtdlLogPrintf(CTDL_EMERG, "Thread system, can't allocate CtdlThreadNode, exiting\n");
                return NULL;
        }
-
+       
        /* Initialise the thread structure */
-       if (ctdl_internal_init_thread_struct(this_thread, flags) == NULL) {
+       if (ctdl_internal_init_thread_struct(this_thread, flags) == NULL)
+       {
                free(this_thread);
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, can't initialise CtdlThreadNode, exiting\n");
+               CtdlLogPrintf(CTDL_EMERG, "Thread system, can't initialise CtdlThreadNode, exiting\n");
                return NULL;
        }
        /*
@@ -931,32 +986,30 @@ CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags,
         * first because most implimentations of threading can't create it in a stopped state
         * and it might want to do things with its structure that aren't initialised otherwise.
         */
-       if (name) {
+       if(name)
+       {
                this_thread->name = name;
-       } else {
+       }
+       else
+       {
                this_thread->name = "Un-named Thread";
        }
-
+       
        this_thread->flags = flags;
        this_thread->thread_func = thread_func;
        this_thread->user_args = args;
-
-//      citthread_mutex_lock(&this_thread->ThreadMutex);
-
+       
        begin_critical_section(S_THREAD_LIST);
        /*
         * We pass this_thread into the thread as its args so that it can find out information
         * about itself and it has a bit of storage space for itself, not to mention that the REAL
         * thread function needs to finish off the setup of the structure
         */
-       if ((ret =
-            citthread_create(&this_thread->tid, &this_thread->attr,
-                             ctdl_internal_thread_func,
-                             this_thread) != 0)) {
+       if ((ret = citthread_create(&this_thread->tid, &this_thread->attr, ctdl_internal_thread_func, this_thread) != 0))
+       {
                end_critical_section(S_THREAD_LIST);
-               CtdlLogPrintf(CTDL_ALERT,
-                             "Thread system, Can't create thread: %s\n",
-                             strerror(ret));
+               CtdlLogPrintf(CTDL_ALERT, "Thread system, Can't create thread: %s\n",
+                       strerror(ret));
                citthread_mutex_unlock(&this_thread->ThreadMutex);
                citthread_mutex_destroy(&(this_thread->ThreadMutex));
                citthread_cond_destroy(&(this_thread->ThreadCond));
@@ -966,9 +1019,8 @@ CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags,
                free(this_thread);
                return NULL;
        }
-
-       num_threads++;          // Increase the count of threads in the system.
-       if (this_thread->flags & CTDLTHREAD_WORKER)
+       num_threads++;  // Increase the count of threads in the system.
+       if(this_thread->flags & CTDLTHREAD_WORKER)
                num_workers++;
 
        this_thread->next = CtdlThreadList;
@@ -976,10 +1028,9 @@ CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags,
        if (this_thread->next)
                this_thread->next->prev = this_thread;
        ctdl_thread_internal_calc_loadavg();
-
-//      citthread_mutex_unlock(&this_thread->ThreadMutex);
+       
        end_critical_section(S_THREAD_LIST);
-
+       
        return this_thread;
 }
 
@@ -989,101 +1040,30 @@ CtdlThreadNode *ctdl_internal_create_thread(char *name, long flags,
  * char *name = name to give to thread, if NULL, use generic name
  * int flags = flags to determine type of thread and standard facilities
  */
-CtdlThreadNode *CtdlThreadCreate(char *name, long flags,
-                                void *(*thread_func) (void *arg),
-                                void *args)
+CtdlThreadNode *CtdlThreadCreate(char *name, long flags, void *(*thread_func) (void *arg), void *args)
 {
        CtdlThreadNode *ret = NULL;
-
+       
        ret = ctdl_internal_create_thread(name, flags, thread_func, args);
        return ret;
 }
 
 
 
-/*
- * Internal function to schedule a thread.
- * Must be called from within a S_THREAD_LIST critical section
- */
-CtdlThreadNode *CtdlThreadSchedule(char *name, long flags,
-                                  void *(*thread_func) (void *arg),
-                                  void *args, time_t when)
-{
-       CtdlThreadNode *this_thread;
-
-       if (num_threads >= 32767) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system. Thread list full.\n");
-               return NULL;
-       }
-
-       this_thread = malloc(sizeof(CtdlThreadNode));
-       if (this_thread == NULL) {
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, can't allocate CtdlThreadNode, exiting\n");
-               return NULL;
-       }
-       /* Initialise the thread structure */
-       if (ctdl_internal_init_thread_struct(this_thread, flags) == NULL) {
-               free(this_thread);
-               CtdlLogPrintf(CTDL_EMERG,
-                             "Thread system, can't initialise CtdlThreadNode, exiting\n");
-               return NULL;
-       }
-
-       /*
-        * If we got here we are going to create the thread so we must initilise the structure
-        * first because most implimentations of threading can't create it in a stopped state
-        * and it might want to do things with its structure that aren't initialised otherwise.
-        */
-       if (name) {
-               this_thread->name = name;
-       } else {
-               this_thread->name = "Un-named Thread";
-       }
-
-       this_thread->flags = flags;
-       this_thread->thread_func = thread_func;
-       this_thread->user_args = args;
-
-       /*
-        * When to start this thread
-        */
-       this_thread->when = when;
-
-       begin_critical_section(S_SCHEDULE_LIST);
-       this_thread->next = CtdlThreadSchedList;
-       CtdlThreadSchedList = this_thread;
-       if (this_thread->next)
-               this_thread->next->prev = this_thread;
-       end_critical_section(S_SCHEDULE_LIST);
-
-       return this_thread;
-}
-
-
-
-CtdlThreadNode *ctdl_thread_internal_start_scheduled(CtdlThreadNode *
-                                                    this_thread)
+CtdlThreadNode *ctdl_thread_internal_start_scheduled (CtdlThreadNode *this_thread)
 {
        int ret = 0;
-
-//      citthread_mutex_lock(&that_thread->ThreadMutex);
+       
        begin_critical_section(S_THREAD_LIST);
        /*
         * We pass this_thread into the thread as its args so that it can find out information
         * about itself and it has a bit of storage space for itself, not to mention that the REAL
         * thread function needs to finish off the setup of the structure
         */
-       if ((ret =
-            citthread_create(&this_thread->tid, &this_thread->attr,
-                             ctdl_internal_thread_func,
-                             this_thread) != 0)) {
+       if ((ret = citthread_create(&this_thread->tid, &this_thread->attr, ctdl_internal_thread_func, this_thread) != 0))
+       {
                end_critical_section(S_THREAD_LIST);
-               CtdlLogPrintf(CTDL_DEBUG,
-                             "Failed to start scheduled thread \"%s\": %s\n",
-                             this_thread->name, strerror(ret));
-//              citthread_mutex_unlock(&this_thread->ThreadMutex);
+               CtdlLogPrintf(CTDL_DEBUG, "Failed to start scheduled thread \"%s\": %s\n", this_thread->name, strerror(ret));
                citthread_mutex_destroy(&(this_thread->ThreadMutex));
                citthread_cond_destroy(&(this_thread->ThreadCond));
                citthread_mutex_destroy(&(this_thread->SleepMutex));
@@ -1092,22 +1072,21 @@ CtdlThreadNode *ctdl_thread_internal_start_scheduled(CtdlThreadNode *
                free(this_thread);
                return NULL;
        }
-
-
-       num_threads++;          // Increase the count of threads in the system.
-       if (this_thread->flags & CTDLTHREAD_WORKER)
+       
+       
+       num_threads++;  // Increase the count of threads in the system.
+       if(this_thread->flags & CTDLTHREAD_WORKER)
                num_workers++;
 
        this_thread->next = CtdlThreadList;
        CtdlThreadList = this_thread;
        if (this_thread->next)
                this_thread->next->prev = this_thread;
-//      citthread_mutex_unlock(&that_thread->ThreadMutex);
-
+       
        ctdl_thread_internal_calc_loadavg();
        end_critical_section(S_THREAD_LIST);
-
-
+       
+       
        return this_thread;
 }
 
@@ -1117,57 +1096,56 @@ void ctdl_thread_internal_check_scheduled(void)
 {
        CtdlThreadNode *this_thread, *that_thread;
        time_t now;
-
+       
+       /* Don't start scheduled threads if the system wants single user mode */
+       if (CtdlWantSingleUser())
+               return;
+       
        if (try_critical_section(S_SCHEDULE_LIST))
-               return;         /* If this list is locked we wait till the next chance */
-
+               return; /* If this list is locked we wait till the next chance */
+       
        now = time(NULL);
-
+       
 #ifdef WITH_THREADLOG
-       CtdlLogPrintf(CTDL_DEBUG,
-                     "Checking for scheduled threads to start.\n");
+       CtdlLogPrintf(CTDL_DEBUG, "Checking for scheduled threads to start.\n");
 #endif
 
        this_thread = CtdlThreadSchedList;
-       while (this_thread) {
+       while(this_thread)
+       {
                that_thread = this_thread;
                this_thread = this_thread->next;
-
-               if (now > that_thread->when) {
+               
+               if (now > that_thread->when)
+               {
                        /* Unlink from schedule list */
                        if (that_thread->prev)
-                               that_thread->prev->next =
-                                   that_thread->next;
+                               that_thread->prev->next = that_thread->next;
                        else
                                CtdlThreadSchedList = that_thread->next;
                        if (that_thread->next)
-                               that_thread->next->prev =
-                                   that_thread->prev;
-
+                               that_thread->next->prev = that_thread->prev;
+                               
                        that_thread->next = that_thread->prev = NULL;
 #ifdef WITH_THREADLOG
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "About to start scheduled thread \"%s\".\n",
-                                     that_thread->name);
+                       CtdlLogPrintf(CTDL_DEBUG, "About to start scheduled thread \"%s\".\n", that_thread->name);
 #endif
-                       if (CT->state > CTDL_THREAD_STOP_REQ) { /* Only start it if the system is not stopping */
-                               if (ctdl_thread_internal_start_scheduled
-                                   (that_thread)) {
+                       if (CT->state > CTDL_THREAD_STOP_REQ)
+                       {       /* Only start it if the system is not stopping */
+                               if (ctdl_thread_internal_start_scheduled (that_thread))
+                               {
 #ifdef WITH_THREADLOG
-                                       CtdlLogPrintf(CTDL_INFO,
-                                                     "Thread system, Started a scheduled thread \"%s\" (%ud).\n",
-                                                     that_thread->name,
-                                                     that_thread->tid);
+                                       CtdlLogPrintf(CTDL_INFO, "Thread system, Started a scheduled thread \"%s\" (0x%08lx).\n",
+                                               that_thread->name, that_thread->tid);
 #endif
                                }
                        }
                }
 #ifdef WITH_THREADLOG
-               else {
-                       CtdlLogPrintf(CTDL_DEBUG,
-                                     "Thread \"%s\" will start in %ld seconds.\n",
-                                     that_thread->name,
-                                     that_thread->when - time(NULL));
+               else
+               {
+                       CtdlLogPrintf(CTDL_DEBUG, "Thread \"%s\" will start in %ld seconds.\n",
+                               that_thread->name, that_thread->when - time(NULL));
                }
 #endif
        }
@@ -1178,30 +1156,86 @@ void ctdl_thread_internal_check_scheduled(void)
 /*
  * A warapper function for select so we can show a thread as blocked
  */
-int CtdlThreadSelect(int n, fd_set * readfds, fd_set * writefds,
-                    fd_set * exceptfds, struct timeval *timeout)
+int CtdlThreadSelect(int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout)
 {
-       int ret;
-
+       int ret = 0;
+       
        ctdl_thread_internal_change_state(CT, CTDL_THREAD_BLOCKED);
-       ret = select(n, readfds, writefds, exceptfds, timeout);
+       if (!CtdlThreadCheckStop())
+               ret = select(n, readfds, writefds, exceptfds, timeout);
+       /**
+        * If the select returned <= 0 then it failed due to an error
+        * or timeout so this thread could stop if asked to do so.
+        * Anything else means it needs to continue unless the system is shutting down
+        */
+       if (ret > 0)
+       {
+               /**
+                * The select says this thread needs to do something useful.
+                * This thread was in an idle state so it may have been asked to stop
+                * but if the system isn't shutting down this thread is no longer
+                * idle and select has given it a task to do so it must not stop
+                * In this condition we need to force it into the running state.
+                * CtdlThreadGC will clear its ticker for us.
+                *
+                * FIXME: there is still a small hole here. It is possible for the sequence of locking
+                * to allow the state to get changed to STOP_REQ just after this code if the other thread
+                * has decided to change the state before this lock, it there fore has to wait till the lock
+                * completes but it will continue to change the state. We need something a bit better here.
+                */
+               citthread_mutex_lock(&CT->ThreadMutex); /* To prevent race condition of a sleeping thread */
+               if (GC_thread->state > CTDL_THREAD_STOP_REQ && CT->state <= CTDL_THREAD_STOP_REQ)
+               {
+                       CtdlLogPrintf(CTDL_DEBUG, "Thread %s (0x%08lx) refused stop request.\n", CT->name, CT->tid);
+                       CT->state = CTDL_THREAD_RUNNING;
+               }
+               citthread_mutex_unlock(&CT->ThreadMutex);
+       }
+
        ctdl_thread_internal_change_state(CT, CTDL_THREAD_RUNNING);
+
        return ret;
 }
 
 
 
 void *new_worker_thread(void *arg);
-extern void close_masters(void);
-void *select_on_master(void *args);
-void *select_on_client(void *args);
-CtdlThreadNode *client_select_thread;
-CtdlThreadNode *master_select_thread;
+extern void close_masters (void);
+
+
+void *simulation_worker (void*arg) {
+       struct CitContext *this;
+
+       this = CreateNewContext();
+       CtdlThreadSleep(1);
+       this->kill_me = 1;
+       this->state = CON_IDLE;
+       dead_session_purge(1);
+       begin_critical_section(S_SESSION_TABLE);
+       stats_done++;
+       end_critical_section(S_SESSION_TABLE);
+       return NULL;
+}
+
+
+void *simulation_thread (void *arg)
+{
+       long stats = statcount;
+
+       while(stats && !CtdlThreadCheckStop()) {
+               CtdlThreadCreate("Connection simulation worker", CTDLTHREAD_BIGSTACK, simulation_worker, NULL);
+               stats--;
+       }
+       CtdlThreadStopAll();
+       return NULL;
+}
 
 void go_threading(void)
 {
        int i;
        CtdlThreadNode *last_worker;
+       struct timeval start, now, result;
+       double last_duration;
 
        /*
         * Initialise the thread system
@@ -1209,25 +1243,21 @@ void go_threading(void)
        ctdl_thread_internal_init();
 
        /* Second call to module init functions now that threading is up */
-       initialise_modules(1);
-       
-       
-                               CtdlThreadCreate("House keeping",
-                                                CTDLTHREAD_BIGSTACK,
-                                                do_housekeeping, NULL);
+       if (!statcount) {
+               initialise_modules(1);
+               CtdlThreadCreate("select_on_master", CTDLTHREAD_BIGSTACK, select_on_master, NULL);
+       }
+       else {
+               CtdlLogPrintf(CTDL_EMERG, "Running connection simulation stats\n");
+               gettimeofday(&start, NULL);
+               CtdlThreadCreate("Connection simulation master", CTDLTHREAD_BIGSTACK, simulation_thread, NULL);
+       }
 
-                                                
-#ifdef NEW_WORKER
-       master_select_thread = CtdlThreadCreate ("Select on Master", 0, select_on_master, NULL);
-       client_select_thread = CtdlThreadCreate ("Select on client", 0, select_on_client, NULL);
-#endif
 
        /*
         * This thread is now used for garbage collection of other threads in the thread list
         */
-       CtdlLogPrintf(CTDL_INFO,
-                     "Startup thread %d becoming garbage collector,\n",
-                     citthread_self());
+       CtdlLogPrintf(CTDL_INFO, "Startup thread %ld becoming garbage collector,\n", (long) citthread_self());
 
        /*
         * We do a lot of locking and unlocking of the thread list in here.
@@ -1235,57 +1265,55 @@ void go_threading(void)
         * that may be waiting on the thread list.
         * We are a low priority thread so we can afford to do this
         */
-
-       while (CtdlThreadGetCount()) {
+       
+       while (CtdlThreadGetCount())
+       {
                if (CT->signal)
                        exit_signal = CT->signal;
-               if (exit_signal) {
+               if (exit_signal)
+               {
                        CtdlThreadStopAll();
-//                      close_masters();
                }
                check_sched_shutdown();
-               if (CT->state > CTDL_THREAD_STOP_REQ) {
+               if (CT->state > CTDL_THREAD_STOP_REQ)
+               {
                        begin_critical_section(S_THREAD_LIST);
                        ctdl_thread_internal_calc_loadavg();
                        end_critical_section(S_THREAD_LIST);
-
-                       ctdl_thread_internal_check_scheduled(); /* start scheduled threads */
+                       
+                       ctdl_thread_internal_check_scheduled(); /* start scheduled threads */
                }
-
+               
                /* Reduce the size of the worker thread pool if necessary. */
-               if ((CtdlThreadGetWorkers() > config.c_min_workers + 1)
-                   && (CtdlThreadWorkerAvg < 20)
-                   && (CT->state > CTDL_THREAD_STOP_REQ)) {
+               if ((CtdlThreadGetWorkers() > config.c_min_workers + 1) && (CtdlThreadWorkerAvg < 20) && (CT->state > CTDL_THREAD_STOP_REQ))
+               {
                        /* Ask a worker thread to stop as we no longer need it */
                        begin_critical_section(S_THREAD_LIST);
                        last_worker = CtdlThreadList;
-                       while (last_worker) {
-                               citthread_mutex_lock(&last_worker->
-                                                    ThreadMutex);
-                               if (last_worker->flags & CTDLTHREAD_WORKER
-                                   && (last_worker->state >
-                                       CTDL_THREAD_STOPPING)
-                                   && (last_worker->Context == NULL)) {
-                                       citthread_mutex_unlock
-                                           (&last_worker->ThreadMutex);
+                       while (last_worker)
+                       {
+                               citthread_mutex_lock(&last_worker->ThreadMutex);
+                               if (last_worker->flags & CTDLTHREAD_WORKER && (last_worker->state > CTDL_THREAD_STOPPING) && (last_worker->Context == NULL))
+                               {
+                                       citthread_mutex_unlock(&last_worker->ThreadMutex);
                                        break;
                                }
-                               citthread_mutex_unlock(&last_worker->
-                                                      ThreadMutex);
+                               citthread_mutex_unlock(&last_worker->ThreadMutex);
                                last_worker = last_worker->next;
                        }
                        end_critical_section(S_THREAD_LIST);
-                       if (last_worker) {
+                       if (last_worker)
+                       {
 #ifdef WITH_THREADLOG
-                               CtdlLogPrintf(CTDL_DEBUG,
-                                             "Thread system, stopping excess worker thread \"%s\" (%ld).\n",
-                                             last_worker->name,
-                                             last_worker->tid);
+                               CtdlLogPrintf(CTDL_DEBUG, "Thread system, stopping excess worker thread \"%s\" (0x%08lx).\n",
+                                       last_worker->name,
+                                       last_worker->tid
+                                       );
 #endif
                                CtdlThreadStop(last_worker);
                        }
                }
-
+       
                /*
                 * If all our workers are working hard, start some more to help out
                 * with things
@@ -1293,371 +1321,53 @@ void go_threading(void)
                /* FIXME: come up with a better way to dynamically alter the number of threads
                 * based on the system load
                 */
-#ifdef NEW_WORKER
-               if ((((CtdlThreadGetWorkers() < config.c_max_workers)
-                     && (CtdlThreadGetWorkers() <= num_sessions))
-                    || CtdlThreadGetWorkers() < config.c_min_workers)
-                   && (CT->state > CTDL_THREAD_STOP_REQ))
-#else
-               if ((((CtdlThreadGetWorkers() < config.c_max_workers)
-                     && (CtdlThreadGetWorkerAvg() > 60)
-                     && (CtdlThreadGetLoadAvg() < 90))
-                    || CtdlThreadGetWorkers() < config.c_min_workers)
-                   && (CT->state > CTDL_THREAD_STOP_REQ))
-#endif                         /* NEW_WORKER */
+               if (!statcount) {
+               if ((((CtdlThreadGetWorkers() < config.c_max_workers) && (CtdlThreadGetWorkerAvg() > 60)) || CtdlThreadGetWorkers() < config.c_min_workers) && (CT->state > CTDL_THREAD_STOP_REQ))
                {
-                       for (i = 0; i < 5; i++) {
-#ifdef NEW_WORKER
-                               CtdlThreadCreate("Worker Thread (new)",
-                                                CTDLTHREAD_BIGSTACK +
-                                                CTDLTHREAD_WORKER,
-                                                new_worker_thread, NULL);
-#else
-                               CtdlThreadCreate("Worker Thread",
-                                                CTDLTHREAD_BIGSTACK +
-                                                CTDLTHREAD_WORKER,
-                                                worker_thread, NULL);
-#endif                         /* NEW_WORKER */
+                       /* Only start new threads if we are not going to overload the machine */
+                       /* Temporarily set to 10 should be enough to make sure we don't stranglew the server
+                        * at least until we make this a config option */
+                       if (CtdlThreadGetLoadAvg() < ((double)10.00)) {
+                               for (i=0; i<5 ; i++) {
+                                       CtdlThreadCreate("Worker Thread",
+                                               CTDLTHREAD_BIGSTACK + CTDLTHREAD_WORKER,
+                                               worker_thread,
+                                               NULL
+                                               );
+                               }
                        }
+                       else
+                               CtdlLogPrintf (CTDL_WARNING, "Server strangled due to machine load average too high.\n");
+               }
                }
 
                CtdlThreadGC();
 
-               if (CtdlThreadGetCount() <= 1)  // Shutting down clean up the garbage collector
+               if (CtdlThreadGetCount() <= 1) // Shutting down clean up the garbage collector
                {
                        CtdlThreadGC();
                }
-
+               
+#ifdef THREADS_USESIGNALS
+               if (CtdlThreadGetCount() && CT->state > CTDL_THREAD_STOP_REQ)
+#else
                if (CtdlThreadGetCount())
+#endif
                        CtdlThreadSleep(1);
        }
        /*
         * If the above loop exits we must be shutting down since we obviously have no threads
         */
        ctdl_thread_internal_cleanup();
-}
-
-
-
-
-
-/*
- * Starting a new implimentation of a worker thread.
- * This new implimentation will be faster and do more work per thread.
- */
-
-// TODO: need to sort out the thread states and signals
-// TODO: slect_on_master should not be a big stack thread.
-// TODO: slect_on_client should not be a big stack thread.
-// TODO: select_on_master is not a worker thread and should be blocked when in select
-// TODO: select_on_client is not a worker thread and should be blocked when in select
-/**
- * Select on master socket.
- * One specific thread comes in here and never leaves.
- * This thread blocks on select until something happens.
- * The select only returns if a new connection is made or the select is interrupted by some means.
- * We need to interrupt the select if the list of ServiceHook's changes or we are shutting down.
- * We should probably use a signal to interrupt the select is a ServiceHook is created.
- * When a ServiceHook is destroyed its socket will close which will awaken the select.
- */
-void *select_on_master(void *arg)
-{
-       fd_set readfds;
-       struct ServiceFunctionHook *serviceptr;
-       int ssock;              /* Descriptor for client socket */
-       int highest;
-       int m, i;
-       int retval = 0;
-       struct CitContext *con;
-
-
-
-       while (!CtdlThreadCheckStop()) {
-               CtdlThreadName("select_on_master");
-
-               /* Initialize the fdset. */
-               FD_ZERO(&readfds);
-               highest = 0;
-
-               /* First, add the various master sockets to the fdset. */
-               for (serviceptr = ServiceHookTable; serviceptr != NULL;
-                    serviceptr = serviceptr->next) {
-                       m = serviceptr->msock;
-                       FD_SET(m, &readfds);
-                       if (m > highest) {
-                               highest = m;
-                       }
-               }
-
-       /** We can block indefinately since something will wake us up eventually
-        * Even if it is a signal telling us the system is shutting down
-        */
-               retval =
-                   CtdlThreadSelect(highest + 1, &readfds, NULL, NULL,
-                                    NULL);
-
-       /** Select got an error or we are shutting down so get out */
-               if (retval == 0 || CtdlThreadCheckStop()) {
-                       return NULL;
-               }
 
-       /** Select says something happened on one of our master sockets so now we handle it */
-               for (serviceptr = ServiceHookTable; serviceptr != NULL;
-                    serviceptr = serviceptr->next) {
-                       if (FD_ISSET(serviceptr->msock, &readfds)) {
-                               ssock = accept(serviceptr->msock, NULL, 0);
-                               if (ssock >= 0) {
-                                       CtdlLogPrintf(CTDL_DEBUG,
-                                                     "New client socket %d\n",
-                                                     ssock);
-                                       /* The master socket is non-blocking but the client
-                                        * sockets need to be blocking, otherwise certain
-                                        * operations barf on FreeBSD.  Not a fatal error.
-                                        */
-                                       if (fcntl(ssock, F_SETFL, 0) < 0) {
-                                               CtdlLogPrintf(CTDL_EMERG,
-                                                             "citserver: Can't set socket to blocking: %s\n",
-                                                             strerror
-                                                             (errno));
-                                       }
-                                       /* New context will be created already
-                                        * set up in the CON_EXECUTING state.
-                                        */
-                                       con = CreateNewContext();
-                                       /* Assign our new socket number to it. */
-                                       con->client_socket = ssock;
-                                       con->h_command_function =
-                                           serviceptr->h_command_function;
-                                       con->h_async_function =
-                                           serviceptr->h_async_function;
-                                       con->ServiceName =
-                                           serviceptr->ServiceName;
-                                       con->h_greeting_function = serviceptr->h_greeting_function;
-                                       /* Determine whether it's a local socket */
-                                       if (serviceptr->sockpath != NULL)
-                                               con->is_local_socket = 1;
-
-                                       /* Set the SO_REUSEADDR socket option */
-                                       i = 1;
-                                       setsockopt(ssock, SOL_SOCKET,
-                                                  SO_REUSEADDR, &i,
-                                                  sizeof(i));
-
-                       /** Now we can pass this context to an idle worker thread to get things going
-                        * What if there are no idle workers?
-                        * We could create one but what if the thread list is full?
-                        * Then I guess we need to close the socket a reject the connection.
-                        */
-                       /** TODO: If there are no idle threads then this server is overloaded and we should reject the connection
-                        * This will have the effect of throttling the incomming connections on master sockets
-                        * a little and slow the process down.
-                        */
-//                                     if (idle_workers)
-                                       {
-                                               con->state = CON_START;
-                                               citthread_kill(client_select_thread->tid, SIGUSR1);
-                                               citthread_cond_signal(&worker_block);
-                                       }
-                                       // else
-                                       // output try later message
-                                       //start_context(con);
-                               }
-                       }
-               }
+       if (statcount) {
+               gettimeofday(&now, NULL);
+               timersub(&now, &start, &result);
+               last_duration = (double)result.tv_sec + ((double)result.tv_usec / (double) 1000000);
+               CtdlLogPrintf(CTDL_EMERG, "Simulated %ld connections in %f seconds\n", stats_done, last_duration);
        }
-       return NULL;
 }
 
 
 
-/*
- * Select on client socket.
- * Only one dedicated thread in here.
- * We have to interrupt our select whenever a context is returned to the CON_READY state.
- * as a result each context may be close to timing out its client so we have to calculate
- * which client socket will timeout first and expire our select on that time.
- * 
- */
-void *select_on_client(void *arg)
-{
-       fd_set readfds;
-       struct timeval tv, now, result;
-       int retval = 0;
-       int highest;
-       struct CitContext *ptr;
-
-       CtdlThreadName("select_on_client");
-
-       while (!CtdlThreadCheckStop()) {
-               /* Initialise the fdset */
-               FD_ZERO(&readfds);
-               highest = 0;
-               /** Get the clients to select on */
-               tv.tv_sec = config.c_sleeping;
-               tv.tv_usec = 0;
-               begin_critical_section(S_SESSION_TABLE);
-               for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-                       if (ptr->state == CON_IDLE) {
-                               gettimeofday(&now, NULL);
-                               timersub(&(ptr->client_expires_at),
-                                        &now, &result);
-                               if (result.tv_sec <= 0) {
-                                       /** This client has timed out so kill it */
-                                       ptr->kill_me = 1;
-                                       continue;
-                               }
-                               /** Is this one going to expire first? */
-                               timersub(&result, &tv, &now);
-                               if (now.tv_sec <= 0 && now.tv_usec <= 0) {
-                                       tv.tv_sec = result.tv_sec;
-                                       tv.tv_usec = result.tv_usec;
-                               }
-                               FD_SET(ptr->client_socket, &readfds);
-                               if (ptr->client_socket > highest)
-                                       highest = ptr->client_socket;
-                       }
-               }
-               end_critical_section(S_SESSION_TABLE);
-
-               /* Now we can select on any connections that are waiting */
-               if (!CtdlThreadCheckStop()) {
-                       retval =
-                           CtdlThreadSelect(highest + 1, &readfds, NULL, NULL, &tv);
-               } else {        /* Shutting down? */
 
-                       return NULL;
-               }
-
-
-               /* Now figure out who made this select() unblock.
-                * First, check for an error or exit condition.
-                */
-               if (retval < 0) {
-                       if (errno == EBADF) {
-                               CtdlLogPrintf(CTDL_NOTICE,
-                                             "select() failed: (%s)\n",
-                                             strerror(errno));
-                       }
-                       if (errno != EINTR) {
-                               CtdlLogPrintf(CTDL_EMERG,
-                                             "Exiting (%s)\n",
-                                             strerror(errno));
-                               CtdlThreadStopAll();
-                       } else if (!CtdlThreadCheckStop()) {
-                               CtdlLogPrintf(CTDL_DEBUG,
-                                             "Un handled select failure.\n");
-                       }
-               } else if (retval > 0) {
-                       begin_critical_section(S_SESSION_TABLE);
-                       for (ptr = ContextList; ptr != NULL;
-                            ptr = ptr->next) {
-                               if ((FD_ISSET
-                                    (ptr->client_socket, &readfds))
-                                   && (ptr->state == CON_IDLE)) {
-                                       ptr->input_waiting = 1;
-                                       ptr->state = CON_READY;
-                                       /** reset client expire time */
-                                       ptr->client_expires_at.tv_sec = config.c_sleeping;
-                                       ptr->client_expires_at.tv_usec = 0;
-                               }
-                       }
-                       end_critical_section(S_SESSION_TABLE);
-               }
-       }
-       return NULL;
-}
-
-
-
-/*
- * Do the worker threads work when needed
- */
-int execute_session(struct CitContext *bind_me)
-{
-       int force_purge;
-
-       become_session(bind_me);
-
-       /* If the client has sent a command, execute it. */
-       if (CC->input_waiting) {
-               CC->h_command_function();
-               CC->input_waiting = 0;
-       }
-
-       /* If there are asynchronous messages waiting and the
-        * client supports it, do those now */
-       if ((CC->is_async) && (CC->async_waiting)
-           && (CC->h_async_function != NULL)) {
-               CC->h_async_function();
-               CC->async_waiting = 0;
-       }
-
-       force_purge = CC->kill_me;
-       if (force_purge)
-               CT->Context = NULL;
-       become_session(NULL);
-       bind_me->state = CON_IDLE;
-       return force_purge;
-}
-
-
-
-extern void dead_session_purge(int force);
-
-/*
- * A new worker_thread loop.
- */
-
-void *new_worker_thread(void *arg)
-{
-       struct CitContext *bind_me, *ptr;
-       int force_purge;
-
-       while (!CtdlThreadCheckStop()) {
-
-               /* make doubly sure we're not holding any stale db handles
-                * which might cause a deadlock.
-                */
-               cdb_check_handles();
-               force_purge = 0;
-               bind_me = NULL; /* Which session shall we handle? */
-
-               begin_critical_section(S_SESSION_TABLE);
-               for (ptr = ContextList; ptr != NULL; ptr = ptr->next) {
-                       if (ptr->state == CON_START) {
-                               ptr->state = CON_EXECUTING;
-                               end_critical_section(S_SESSION_TABLE);
-                               become_session(ptr);
-                               begin_session(ptr);
-                               ptr->h_greeting_function();
-                               become_session(NULL);
-                               ptr->state = CON_IDLE;
-                               break;
-                       }
-                       if (ptr->state == CON_READY) {
-                               ptr->state = CON_EXECUTING;
-                               end_critical_section(S_SESSION_TABLE);
-                               force_purge = execute_session(ptr);
-                               break;
-                       }
-
-               }
-               end_critical_section(S_SESSION_TABLE);
-
-               dead_session_purge(force_purge);
-               
-               /** block the worker threads waiting for a select to do something */
-               idle_workers++;
-               ctdl_thread_internal_change_state(CT, CTDL_THREAD_BLOCKED);
-               citthread_mutex_lock(&worker_block_mutex);
-               citthread_cond_wait(&worker_block, &worker_block_mutex);
-               citthread_mutex_unlock(&worker_block_mutex);
-               ctdl_thread_internal_change_state(CT, CTDL_THREAD_RUNNING);
-               idle_workers--;
-               
-               if (CtdlThreadCheckStop())
-                       break;
-
-       }
-       return NULL;
-}