fix dlen
[citadel.git] / libcitadel / lib / mime_parser.c
index e6d65e9f42be5dfd13bfd392a37e554399df37cf..776e3fe4ac2f5af83f92ab676817b5ac533b3d54 100644 (file)
@@ -1,10 +1,9 @@
-/*
- * This is the MIME parser for Citadel.
- *
- * Copyright (c) 1998-2010 by the citadel.org development team.
- * This code is distributed under the GNU General Public License v3.
- *
- */
+// This is the MIME parser for Citadel.
+//
+// Copyright (c) 1998-2023 by the citadel.org development team.
+//
+// This program is open source software.  Use, duplication, or disclosure
+// is subject to the terms of the GNU General Public License, version 3.
 
 #include <stdlib.h>
 #include <unistd.h>
@@ -22,7 +21,7 @@
 #include "libcitadel.h"
 #include "libcitadellocal.h"
 
-const unsigned char FromHexTable [256] = {
+const unsigned char FromHexTable[256] = {
        0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, //  0
        0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 10
        0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, // 20
@@ -52,29 +51,23 @@ const unsigned char FromHexTable [256] = {
 };
 
 
-long extract_key(char *target, char *source, long sourcelen, char *key, long keylen, char KeyEnd)
-{
+long extract_key(char *target, char *source, long sourcelen, char *key, long keylen, char KeyEnd) {
        char *sptr, *ptr = NULL;
        int double_quotes = 0;
        long RealKeyLen = keylen;
 
        sptr = source;
 
-       while (sptr != NULL)
-       {
-               ptr = bmstrcasestr_len(sptr, sourcelen - (sptr - source), 
-                                      key, keylen);
-               if(ptr != NULL)
-               {
+       while (sptr != NULL) {
+               ptr = bmstrcasestr_len(sptr, sourcelen - (sptr - source), key, keylen);
+               if (ptr != NULL) {
                        while (isspace(*(ptr + RealKeyLen)))
                                RealKeyLen ++;
-                       if (*(ptr + RealKeyLen) == KeyEnd)
-                       {
+                       if (*(ptr + RealKeyLen) == KeyEnd) {
                                sptr = NULL;
                                RealKeyLen ++;                          
                        }
-                       else
-                       {
+                       else {
                                sptr = ptr + RealKeyLen + 1;
                        }
                }
@@ -89,12 +82,12 @@ long extract_key(char *target, char *source, long sourcelen, char *key, long key
 
        for (ptr=target; (*ptr != 0); ptr++) {
 
-               /* A semicolon means we've hit the end of the key, unless we're inside double quotes */
+               // A semicolon means we've hit the end of the key, unless we're inside double quotes
                if ( (double_quotes != 1) && (*ptr == ';')) {
                        *ptr = 0;
                }
 
-               /* if we find double quotes, we've got a great set of string boundaries */
+               // if we find double quotes, we've got a great set of string boundaries
                if (*ptr == '\"') {
                        ++double_quotes;
                        if (double_quotes == 1) {
@@ -110,10 +103,8 @@ long extract_key(char *target, char *source, long sourcelen, char *key, long key
 }
 
 
-/*
- * For non-multipart messages, we need to generate a quickie partnum of "1"
- * to return to callback functions.  Some callbacks demand it.
- */
+// For non-multipart messages, we need to generate a quickie partnum of "1"
+// to return to callback functions.  Some callbacks demand it.
 char *fixed_partnum(char *supplied_partnum) {
        if (supplied_partnum == NULL) return "1";
        if (strlen(supplied_partnum)==0) return "1";
@@ -121,9 +112,8 @@ char *fixed_partnum(char *supplied_partnum) {
 }
 
 
-static inline unsigned int _decode_hex(const char *Source)
-{
-       int ret = '?';
+static inline unsigned int _decode_hex(const char *Source) {
+       unsigned int ret = '?';
        unsigned char LO_NIBBLE;
        unsigned char HI_NIBBLE;
 
@@ -140,40 +130,32 @@ static inline unsigned int _decode_hex(const char *Source)
 
 unsigned int decode_hex(char *Source) {return _decode_hex(Source);}
 
-/*
- * Convert "quoted-printable" to binary.  Returns number of bytes decoded.
- * according to RFC2045 section 6.7
- */
+
+// Convert "quoted-printable" to binary.  Returns number of bytes decoded.
+// according to RFC2045 section 6.7
 int CtdlDecodeQuotedPrintable(char *decoded, char *encoded, int sourcelen) {
        unsigned int ch;
        int decoded_length = 0;
        int pos = 0;
 
-       while (pos < sourcelen)
-       {
-               if (*(encoded + pos) == '=')
-               {
+       while (pos < sourcelen) {
+               if (*(encoded + pos) == '=') {
                        pos ++;
-                       if (*(encoded + pos) == '\n')
-                       {
+                       if (*(encoded + pos) == '\n') {
                                pos ++;
                        }
-                       else if (*(encoded + pos) == '\r')
-                       {
+                       else if (*(encoded + pos) == '\r') {
                                pos ++;
                                if (*(encoded + pos) == '\n')
                                        pos++;
                        }
-                       else
-                       {
-                               ch = 0;
+                       else {
                                ch = _decode_hex(&encoded[pos]);
                                pos += 2;
                                decoded[decoded_length++] = ch;
                        }
                }
-               else
-               {
+               else {
                        decoded[decoded_length++] = encoded[pos];
                        pos += 1;
                }
@@ -183,10 +165,8 @@ int CtdlDecodeQuotedPrintable(char *decoded, char *encoded, int sourcelen) {
 }
 
 
-/*
- * Given a message or message-part body and a length, handle any necessary
- * decoding and pass the request up the stack.
- */
+// Given a message or message-part body and a length, handle any necessary
+// decoding and pass the request up the stack.
 void mime_decode(char *partnum,
                 char *part_start, size_t length,
                 char *content_type, char *charset, char *encoding,
@@ -197,21 +177,22 @@ void mime_decode(char *partnum,
                 MimeParserCallBackType PreMultiPartCallBack,
                 MimeParserCallBackType PostMultiPartCallBack,
                 void *userdata,
-                int dont_decode)
-{
-
+                int dont_decode
+) {
        char *decoded;
        size_t bytes_decoded = 0;
 
-       /* Some encodings aren't really encodings */
+       // Some encodings aren't really encodings
        if (!strcasecmp(encoding, "7bit"))
-               strcpy(encoding, "");
+               *encoding = '\0';
        if (!strcasecmp(encoding, "8bit"))
-               strcpy(encoding, "");
+               *encoding = '\0';
        if (!strcasecmp(encoding, "binary"))
-               strcpy(encoding, "");
+               *encoding = '\0';
+       if (!strcasecmp(encoding, "ISO-8859-1"))
+               *encoding = '\0';
 
-       /* If this part is not encoded, send as-is */
+       // If this part is not encoded, send as-is
        if ( (strlen(encoding) == 0) || (dont_decode)) {
                if (CallBack != NULL) {
                        CallBack(name, 
@@ -229,18 +210,15 @@ void mime_decode(char *partnum,
                return;
        }
        
-       /* Fail silently if we hit an unknown encoding. */
-       if ((strcasecmp(encoding, "base64"))
-           && (strcasecmp(encoding, "quoted-printable"))) {
+       // Fail silently if we hit an unknown encoding.
+       if ((strcasecmp(encoding, "base64")) && (strcasecmp(encoding, "quoted-printable"))) {
                return;
        }
 
-       /*
-        * Allocate a buffer for the decoded data.  The output buffer is slightly
-        * larger than the input buffer; this assumes that the decoded data
-        * will never be significantly larger than the encoded data.  This is a
-        * safe assumption with base64, uuencode, and quoted-printable.
-        */
+       // Allocate a buffer for the decoded data.  The output buffer is slightly
+       // larger than the input buffer; this assumes that the decoded data
+       // will never be significantly larger than the encoded data.  This is a
+       // safe assumption with base64, uuencode, and quoted-printable.
        decoded = malloc(length + 32768);
        if (decoded == NULL) {
                return;
@@ -273,14 +251,13 @@ void mime_decode(char *partnum,
        free(decoded);
 }
 
-/*
- * this is the extract of mime_decode which can be called if 'dont_decode' was set; 
- * to save the cpu intense process of decoding to the time when it realy wants the content. 
- * returns: 
- *   - > 0 we decoded something, its on *decoded, you need to free it.
- *   - = 0 no need to decode stuff. *decoded will be NULL.
- *   - < 0 an error occured, either an unknown encoding, or alloc failed. no need to free.
- */
+
+// this is a bastardization of mime_decode() which can be called if 'dont_decode' was set; 
+// to postpone the cpu intense process of decoding until the time when it realy wants the content. 
+// returns: 
+//   - > 0 we decoded something, its on *decoded, you need to free it.
+//   - = 0 no need to decode stuff. *decoded will be NULL.
+//   - < 0 an error occured, either an unknown encoding, or alloc failed. no need to free.
 int mime_decode_now (char *part_start, 
                     size_t length,
                     char *encoding,
@@ -289,32 +266,28 @@ int mime_decode_now (char *part_start,
 {
        *bytes_decoded = 0;
        *decoded = NULL;
-       /* Some encodings aren't really encodings */
+       // Some encodings aren't really encodings
        if (!strcasecmp(encoding, "7bit"))
-               strcpy(encoding, "");
+               *encoding = '\0';
        if (!strcasecmp(encoding, "8bit"))
-               strcpy(encoding, "");
+               *encoding = '\0';
        if (!strcasecmp(encoding, "binary"))
-               strcpy(encoding, "");
+               *encoding = '\0';
 
-       /* If this part is not encoded, send as-is */
+       // If this part is not encoded, send as-is
        if (strlen(encoding) == 0) {
                return 0;
        }
-       
 
-       /* Fail if we hit an unknown encoding. */
-       if ((strcasecmp(encoding, "base64"))
-           && (strcasecmp(encoding, "quoted-printable"))) {
+       // Fail if we hit an unknown encoding.
+       if ((strcasecmp(encoding, "base64")) && (strcasecmp(encoding, "quoted-printable"))) {
                return -1;
        }
 
-       /*
-        * Allocate a buffer for the decoded data.  The output buffer is slightly
-        * larger than the input buffer; this assumes that the decoded data
-        * will never be significantly larger than the encoded data.  This is a
-        * safe assumption with base64, uuencode, and quoted-printable.
-        */
+       // Allocate a buffer for the decoded data.  The output buffer is slightly
+       // larger than the input buffer; this assumes that the decoded data
+       // will never be significantly larger than the encoded data.  This is a
+       // safe assumption with base64, uuencode, and quoted-printable.
        *decoded = malloc(length + 32768);
        if (decoded == NULL) {
                return -1;
@@ -343,7 +316,7 @@ typedef enum _eIntMimeHdrs {
        filename,
        disposition,
        id,
-       eMax /* don't move ! */
+       eMax // don't move!
 } eIntMimeHdrs;
 
 typedef struct _CBufStr {
@@ -358,18 +331,18 @@ typedef struct _interesting_mime_headers {
 } interesting_mime_headers;
 
 
-static void FlushInterestingMimes(interesting_mime_headers *m)
-{
+static void FlushInterestingMimes(interesting_mime_headers *m) {
        int i;
        
        for (i = 0; i < eMax; i++) {
-            m->b[i].Key[0] = '\0';
-            m->b[i].len = 0;
+               m->b[i].Key[0] = '\0';
+               m->b[i].len = 0;
        }
        m->content_length = -1;
 }
-static interesting_mime_headers *InitInterestingMimes(void)
-{
+
+
+static interesting_mime_headers *InitInterestingMimes(void) {
        interesting_mime_headers *m;
        m = (interesting_mime_headers*) malloc( sizeof(interesting_mime_headers));
 
@@ -379,10 +352,7 @@ static interesting_mime_headers *InitInterestingMimes(void)
 }
 
 
-static long parse_MimeHeaders(interesting_mime_headers *m, 
-                             char** pcontent_start, 
-                             char *content_end)
-{
+static long parse_MimeHeaders(interesting_mime_headers *m, char** pcontent_start, char *content_end) {
        char buf[SIZ];
        char header[SIZ];
        long headerlen;
@@ -390,7 +360,7 @@ static long parse_MimeHeaders(interesting_mime_headers *m,
        int buflen = 0;
        int i;
 
-       /* Learn interesting things from the headers */
+       // Learn interesting things from the headers
        ptr = *pcontent_start;
        *header = '\0';
        headerlen = 0;
@@ -406,13 +376,14 @@ static long parse_MimeHeaders(interesting_mime_headers *m,
                if (!isspace(buf[0]) && (headerlen > 0)) {
                        if (!strncasecmp(header, "Content-type:", 13)) {
                                memcpy (m->b[content_type].Key, &header[13], headerlen - 12);
-                               m->b[content_type].len = striplt (m->b[content_type].Key);
+                               m->b[content_type].Key[headerlen - 12] = '\0';
+                               m->b[content_type].len = string_trim (m->b[content_type].Key);
 
                                m->b[content_type_name].len = extract_key(m->b[content_type_name].Key, CKEY(m->b[content_type]), HKEY("name"), '=');
                                m->b[charset].len           = extract_key(m->b[charset].Key,           CKEY(m->b[content_type]), HKEY("charset"), '=');
                                m->b[boundary].len          = extract_key(m->b[boundary].Key,          header,       headerlen,  HKEY("boundary"), '=');
 
-                               /* Deal with weird headers */
+                               // Deal with weird headers
                                pch = strchr(m->b[content_type].Key, ' ');
                                if (pch != NULL) {
                                        *pch = '\0';
@@ -426,17 +397,19 @@ static long parse_MimeHeaders(interesting_mime_headers *m,
                        }
                        else if (!strncasecmp(header, "Content-Disposition:", 20)) {
                                memcpy (m->b[disposition].Key, &header[20], headerlen - 19);
-                               m->b[disposition].len = striplt(m->b[disposition].Key);
+                               m->b[disposition].Key[headerlen - 19] = '\0';
+                               m->b[disposition].len = string_trim(m->b[disposition].Key);
 
                                m->b[content_disposition_name].len = extract_key(m->b[content_disposition_name].Key, CKEY(m->b[disposition]), HKEY("name"), '=');
                                m->b[filename].len                 = extract_key(m->b[filename].Key,                 CKEY(m->b[disposition]), HKEY("filename"), '=');
                                pch = strchr(m->b[disposition].Key, ';');
                                if (pch != NULL) *pch = '\0';
-                               m->b[disposition].len = striplt(m->b[disposition].Key);
+                               m->b[disposition].len = string_trim(m->b[disposition].Key);
                        }
                        else if (!strncasecmp(header, "Content-ID:", 11)) {
-                               memcpy(m->b[id].Key, &header[11], headerlen);
-                               striplt(m->b[id].Key);
+                               memcpy(m->b[id].Key, &header[11], headerlen - 11);
+                               m->b[id].Key[headerlen - 11] = '\0';
+                               string_trim(m->b[id].Key);
                                m->b[id].len = stripallbut(m->b[id].Key, '<', '>');
                        }
                        else if (!strncasecmp(header, "Content-length: ", 15)) {
@@ -448,7 +421,8 @@ static long parse_MimeHeaders(interesting_mime_headers *m,
                        }
                        else if (!strncasecmp(header, "Content-transfer-encoding: ", 26)) {
                                memcpy(m->b[encoding].Key, &header[26], headerlen - 26);
-                               m->b[encoding].len = striplt(m->b[encoding].Key);
+                               m->b[encoding].Key[headerlen - 26] = '\0';
+                               m->b[encoding].len = string_trim(m->b[encoding].Key);
                        }
                        *header = '\0';
                        headerlen = 0;
@@ -470,50 +444,48 @@ static long parse_MimeHeaders(interesting_mime_headers *m,
 }
 
 
-static int IsAsciiEncoding(interesting_mime_headers *m)
-{
+static int IsAsciiEncoding(interesting_mime_headers *m) {
 
-       if ((m->b[encoding].len != 0) &&
-           (strcasecmp(m->b[encoding].Key, "base64") == 0))
+       if ((m->b[encoding].len != 0) && (strcasecmp(m->b[encoding].Key, "base64") == 0)) {
                return 1;
-       if ((m->b[encoding].len != 0) &&
-           (strcmp(m->b[encoding].Key, "quoted-printable") == 0))
+       }
+       if ((m->b[encoding].len != 0) && (strcmp(m->b[encoding].Key, "quoted-printable") == 0)) {
                return 1;
+       }
 
        return 0;
 }
 
-static char *FindNextContent(char *ptr,
-                            char *content_end,
-                            interesting_mime_headers *SubMimeHeaders,
-                            interesting_mime_headers *m)
-{
+
+static char *FindNextContent(
+               char *ptr,
+               char *content_end,
+               interesting_mime_headers *SubMimeHeaders,
+               interesting_mime_headers *m
+) {
        char *next_boundary;
-       char  tmp;
+       char tmp;
 
        if (IsAsciiEncoding(SubMimeHeaders)) {
                tmp = *content_end;
                *content_end = '\0';
 
-               /** 
-                * ok, if we have a content length of the mime part, 
-                * try skipping the content on the search for the next
-                * boundary. since we don't trust the content_length
-                * to be all accurate, and suspect it to lose one digit 
-                * per line with a line length of 80 chars, we need 
-                * to start searching a little before..
-                */
-                                  
-               if ((SubMimeHeaders->content_length != -1) &&
-                   (SubMimeHeaders->content_length > 10))
-               {
+               // ok, if we have a content length of the mime part, 
+               // try skipping the content on the search for the next
+               // boundary. since we don't trust the content_length
+               // to be all accurate, and suspect it to lose one digit 
+               // per line with a line length of 80 chars, we need 
+               // to start searching a little before..
+
+               if ((SubMimeHeaders->content_length != -1) && (SubMimeHeaders->content_length > 10)) {
                        char *pptr;
                        long lines;
                                        
                        lines = SubMimeHeaders->content_length / 80;
                        pptr = ptr + SubMimeHeaders->content_length - lines - 10;
-                       if (pptr < content_end)
+                       if (pptr < content_end) {
                                ptr = pptr;
+                       }
                }
                        
                next_boundary = strstr(ptr, m->b[startary].Key);
@@ -521,103 +493,98 @@ static char *FindNextContent(char *ptr,
        }
        else {
                char *srch;
-               /** 
-                * ok, if we have a content length of the mime part, 
-                * try skipping the content on the search for the next
-                * boundary. since we don't trust the content_length
-                * to be all accurate, start searching a little before..
-                */
-                                  
-               if ((SubMimeHeaders->content_length != -1) &&
-                   (SubMimeHeaders->content_length > 10))
-               {
+               // ok, if we have a content length of the mime part, 
+               // try skipping the content on the search for the next
+               // boundary. since we don't trust the content_length
+               // to be all accurate, start searching a little before..
+
+               if ((SubMimeHeaders->content_length != -1) && (SubMimeHeaders->content_length > 10)) {
                        char *pptr;
                        pptr = ptr + SubMimeHeaders->content_length - 10;
                        if (pptr < content_end)
                                ptr = pptr;
                }
                
-
                srch = next_boundary = NULL;
-               for (srch = memchr(ptr, '-',  content_end - srch);
-                    (srch != NULL) && (srch < content_end); 
-                    srch = memchr(srch, '-',  content_end - srch)) 
+               for (srch = memchr(ptr, '-',  content_end - ptr);
+                       (srch != NULL) && (srch < content_end); 
+                       srch = memchr(srch, '-',  content_end - srch)) 
                {
-                       if (!memcmp(srch, 
-                                   m->b[startary].Key, 
-                                   m->b[startary].len)) 
-                       {
+                       if (!memcmp(srch, m->b[startary].Key, m->b[startary].len)) {
                                next_boundary = srch;
                                srch = content_end;
                        }
-                       else srch ++;
-
+                       else {
+                               srch++;
+                       }
                }
 
        }
        return next_boundary;
 }
 
-/*
- * Break out the components of a multipart message
- * (This function expects to be fed HEADERS + CONTENT)
- * Note: NULL can be supplied as content_end; in this case, the message is
- * considered to have ended when the parser encounters a 0x00 byte.
- */
+
+// Break out the components of a multipart message
+// (This function expects to be fed HEADERS + CONTENT)
+// Note: NULL can be supplied as content_end; in this case, the message is
+// considered to have ended when the parser encounters a 0x00 byte.
 static void recurseable_mime_parser(char *partnum,
-                                   char *content_start, char *content_end,
-                                   MimeParserCallBackType CallBack,
-                                   MimeParserCallBackType PreMultiPartCallBack,
-                                   MimeParserCallBackType PostMultiPartCallBack,
-                                   void *userdata,
-                                   int dont_decode, 
-                                   interesting_mime_headers *m)
-{
+               char *content_start, char *content_end,
+               MimeParserCallBackType CallBack,
+               MimeParserCallBackType PreMultiPartCallBack,
+               MimeParserCallBackType PostMultiPartCallBack,
+               void *userdata,
+               int dont_decode, 
+               interesting_mime_headers *m
+{
        interesting_mime_headers *SubMimeHeaders;
-       char     *ptr;
-       char     *part_start;
-       char     *part_end = NULL;
-       char     *evaluate_crlf_ptr = NULL;
-       char     *next_boundary;
-       char      nested_partnum[256];
-       int       crlf_in_use = 0;
-       int       part_seq = 0;
-       CBufStr  *chosen_name;
-
-
-       /* If this is a multipart message, then recursively process it */
+       char *ptr;
+       char *part_start;
+       char *part_end = NULL;
+       char *evaluate_crlf_ptr = NULL;
+       char *next_boundary;
+       char nested_partnum[256];
+       int crlf_in_use = 0;
+       int part_seq = 0;
+       CBufStr *chosen_name;
+
+       // If this is a multipart message, then recursively process it
        ptr = content_start;
        part_start = NULL;
        if (m->is_multipart) {
 
-               /* Tell the client about this message's multipartedness */
+               // Tell the client about this message's multipartedness
                if (PreMultiPartCallBack != NULL) {
                        PreMultiPartCallBack("", 
-                                            "", 
-                                            partnum, 
-                                            "",
-                                            NULL, 
-                                            m->b[content_type].Key, 
-                                            m->b[charset].Key,
-                                            0, 
-                                            m->b[encoding].Key, 
-                                            m->b[id].Key, 
-                                            userdata);
+                               "", 
+                               partnum, 
+                               "",
+                               NULL, 
+                               m->b[content_type].Key, 
+                               m->b[charset].Key,
+                               0, 
+                               m->b[encoding].Key, 
+                               m->b[id].Key, 
+                               userdata
+                       );
                }
 
-               /* Figure out where the boundaries are */
+               // Figure out where the boundaries are
                m->b[startary].len = snprintf(m->b[startary].Key, SIZ, "--%s", m->b[boundary].Key);
-               SubMimeHeaders = InitInterestingMimes ();
-               if (*ptr == '\r')
-                       ptr ++;
-               if (*ptr == '\n')
-                       ptr ++;
-               if (strncmp(ptr, m->b[startary].Key, m->b[startary].len) == 0)
+               SubMimeHeaders = InitInterestingMimes();
+
+               while ((*ptr == '\r') || (*ptr == '\n')) {
+                       ptr++;
+               }
+
+               if (strncmp(ptr, m->b[startary].Key, m->b[startary].len) == 0) {
                        ptr += m->b[startary].len;
-               if (*ptr == '\r')
-                       ptr ++;
-               if (*ptr == '\n')
+               }
+
+               while ((*ptr == '\r') || (*ptr == '\n')) {
                        ptr ++;
+               }
+
                part_start = NULL;
                do {
                        char *optr;
@@ -625,40 +592,35 @@ static void recurseable_mime_parser(char *partnum,
                        optr = ptr;
                        if (parse_MimeHeaders(SubMimeHeaders, &ptr, content_end) != 0)
                                break;
-                       if ((ptr - optr > 2) && 
-                           (*(ptr - 2) == '\r'))
+                       if ((ptr - optr > 2) && (*(ptr - 2) == '\r')) {
                                crlf_in_use = 1;
+                       }
                        
                        part_start = ptr;
                        
-                       next_boundary = FindNextContent(ptr,
-                                                       content_end,
-                                                       SubMimeHeaders,
-                                                       m);
-                       if ((next_boundary != NULL) && 
-                           (next_boundary - part_start < 3)) {
+                       next_boundary = FindNextContent(ptr, content_end, SubMimeHeaders, m);
+                       if ((next_boundary != NULL) && (next_boundary - part_start < 3)) {
                                FlushInterestingMimes(SubMimeHeaders);
-
                                continue;
                        }
 
                        if ( (part_start != NULL) && (next_boundary != NULL) ) {
                                part_end = next_boundary;
-                               --part_end;             /* omit the trailing LF */
+                               --part_end;             // omit the trailing LF
                                if (crlf_in_use) {
-                                       --part_end;     /* omit the trailing CR */
+                                       --part_end;     // omit the trailing CR
                                }
 
                                if (!IsEmptyStr(partnum)) {
                                        snprintf(nested_partnum,
-                                                sizeof nested_partnum,
-                                                "%s.%d", partnum,
-                                                ++part_seq);
+                                               sizeof nested_partnum,
+                                               "%s.%d", partnum,
+                                               ++part_seq);
                                }
                                else {
                                        snprintf(nested_partnum,
-                                                sizeof nested_partnum,
-                                                "%d", ++part_seq);
+                                               sizeof nested_partnum,
+                                               "%d", ++part_seq);
                                }
                                recurseable_mime_parser(nested_partnum,
                                                        part_start, 
@@ -672,35 +634,32 @@ static void recurseable_mime_parser(char *partnum,
                        }
 
                        if (next_boundary != NULL) {
-                               /* If we pass out of scope, don't attempt to
-                                * read past the end boundary. */
-                               if ((*(next_boundary + m->b[startary].len + 1) == '-') && 
-                                   (*(next_boundary + m->b[startary].len + 2) == '-') ){
+                               // If we pass out of scope, don't attempt to read past the end boundary.
+                               if ((*(next_boundary + m->b[startary].len) == '-') && 
+                                   (*(next_boundary + m->b[startary].len + 1) == '-') ){
                                        ptr = content_end;
                                }
                                else {
-                                       /* Set up for the next part. */
+                                       // Set up for the next part.
                                        part_start = strstr(next_boundary, "\n");
                                        
-                                       /* Determine whether newlines are LF or CRLF */
+                                       // Determine whether newlines are LF or CRLF
                                        evaluate_crlf_ptr = part_start;
                                        --evaluate_crlf_ptr;
-                                       if ((*evaluate_crlf_ptr == '\r') && 
-                                           (*(evaluate_crlf_ptr + 1) == '\n'))
-                                       {
+                                       if ((*evaluate_crlf_ptr == '\r') && (*(evaluate_crlf_ptr + 1) == '\n')) {
                                                crlf_in_use = 1;
                                        }
                                        else {
                                                crlf_in_use = 0;
                                        }
 
-                                       /* Advance past the LF ... now we're in the next part */
+                                       // Advance past the LF ... now we're in the next part
                                        ++part_start;
                                        ptr = part_start;
                                }
                        }
                        else {
-                               /* Invalid end of multipart.  Bail out! */
+                               // Invalid end of multipart.  Bail out!
                                ptr = content_end;
                        }
                        FlushInterestingMimes(SubMimeHeaders);
@@ -710,38 +669,38 @@ static void recurseable_mime_parser(char *partnum,
 
                if (PostMultiPartCallBack != NULL) {
                        PostMultiPartCallBack("", 
-                                             "", 
-                                             partnum, 
-                                             "", 
-                                             NULL,
-                                             m->b[content_type].Key, 
-                                             m->b[charset].Key,
-                                             0, 
-                                             m->b[encoding].Key, 
-                                             m->b[id].Key, 
-                                             userdata);
+                               "", 
+                               partnum, 
+                               "", 
+                               NULL,
+                               m->b[content_type].Key, 
+                               m->b[charset].Key,
+                               0, 
+                               m->b[encoding].Key, 
+                               m->b[id].Key, 
+                               userdata
+                       );
                }
-       } /* If it's not a multipart message, then do something with it */
+       }
+
+       // If it's not a multipart message, then do something with it
        else {
                size_t length;
                part_start = ptr;
                length = content_end - part_start;
                ptr = part_end = content_end;
 
-
-               /* The following code will truncate the MIME part to the size
-                * specified by the Content-length: header.   We have commented it
-                * out because these headers have a tendency to be wrong.
-                *
-                *      if ( (content_length > 0) && (length > content_length) ) {
-                *              length = content_length;
-                *      }
-                 */
-
-               /* Sometimes the "name" field is tacked on to Content-type,
-                * and sometimes it's tacked on to Content-disposition.  Use
-                * whichever one we have.
-                */
+               // The following code will truncate the MIME part to the size
+               // specified by the Content-length: header.   We have commented it
+               // out because these headers have a tendency to be wrong.
+               //
+               //      if ( (content_length > 0) && (length > content_length) ) {
+               //              length = content_length;
+               //      }
+
+               // Sometimes the "name" field is tacked on to Content-type,
+               // and sometimes it's tacked on to Content-disposition.  Use
+               // whichever one we have.
                if (m->b[content_disposition_name].len > m->b[content_type_name].len) {
                        chosen_name = &m->b[content_disposition_name];
                }
@@ -749,41 +708,39 @@ static void recurseable_mime_parser(char *partnum,
                        chosen_name = &m->b[content_type_name];
                }
        
-               /* Ok, we've got a non-multipart part here, so do something with it.
-                */
+               // Ok, we've got a non-multipart part here, so do something with it.
                mime_decode(partnum,
-                           part_start, 
-                           length,
-                           m->b[content_type].Key, 
-                           m->b[charset].Key,
-                           m->b[encoding].Key, 
-                           m->b[disposition].Key, 
-                           m->b[id].Key, 
-                           chosen_name->Key, 
-                           m->b[filename].Key,
-                           CallBack, 
-                           NULL, NULL,
-                           userdata, 
-                           dont_decode
+                               part_start, 
+                               length,
+                               m->b[content_type].Key, 
+                               m->b[charset].Key,
+                               m->b[encoding].Key, 
+                               m->b[disposition].Key, 
+                               m->b[id].Key, 
+                               chosen_name->Key, 
+                               m->b[filename].Key,
+                               CallBack, 
+                               NULL,
+                               NULL,
+                               userdata, 
+                               dont_decode
                        );
 
-               /*
-                * Now if it's an encapsulated message/rfc822 then we have to recurse into it
-                */
+               // Now if it's an encapsulated message/rfc822 then we have to recurse into it
                if (!strcasecmp(&m->b[content_type].Key[0], "message/rfc822")) {
 
                        if (PreMultiPartCallBack != NULL) {
                                PreMultiPartCallBack("", 
-                                                    "", 
-                                                    partnum, 
-                                                    "",
-                                                    NULL, 
-                                                    m->b[content_type].Key, 
-                                                    m->b[charset].Key,
-                                                    0, 
-                                                    m->b[encoding].Key, 
-                                                    m->b[id].Key, 
-                                                    userdata);
+                                                        "", 
+                                                        partnum, 
+                                                        "",
+                                                        NULL, 
+                                                        m->b[content_type].Key, 
+                                                        m->b[charset].Key,
+                                                        0, 
+                                                        m->b[encoding].Key, 
+                                                        m->b[id].Key, 
+                                                        userdata);
                        }
                        if (CallBack != NULL) {
                                if (strlen(partnum) > 0) {
@@ -809,16 +766,17 @@ static void recurseable_mime_parser(char *partnum,
                        }
                        if (PostMultiPartCallBack != NULL) {
                                PostMultiPartCallBack("", 
-                                                     "", 
-                                                     partnum, 
-                                                     "", 
-                                                     NULL,
-                                                     m->b[content_type].Key, 
-                                                     m->b[charset].Key,
-                                                     0, 
-                                                     m->b[encoding].Key, 
-                                                     m->b[id].Key, 
-                                                     userdata);
+                                       "", 
+                                       partnum, 
+                                       "", 
+                                       NULL,
+                                       m->b[content_type].Key, 
+                                       m->b[charset].Key,
+                                       0, 
+                                       m->b[encoding].Key, 
+                                       m->b[id].Key, 
+                                       userdata
+                               );
                        }
 
 
@@ -828,12 +786,11 @@ static void recurseable_mime_parser(char *partnum,
 
 }
 
-/*
- * Break out the components of a multipart message
- * (This function expects to be fed HEADERS + CONTENT)
- * Note: NULL can be supplied as content_end; in this case, the message is
- * considered to have ended when the parser encounters a 0x00 byte.
- */
+
+// Break out the components of a multipart message
+// (This function expects to be fed HEADERS + CONTENT)
+// Note: NULL can be supplied as content_end; in this case, the message is
+// considered to have ended when the parser encounters a 0x00 byte.
 void the_mime_parser(char *partnum,
                     char *content_start, char *content_end,
                     MimeParserCallBackType CallBack,
@@ -844,16 +801,13 @@ void the_mime_parser(char *partnum,
 {
        interesting_mime_headers *m;
 
-       /* If the caller didn't supply an endpointer, generate one by measure */
+       // If the caller didn't supply an endpointer, generate one by measure
        if (content_end == NULL) {
                content_end = &content_start[strlen(content_start)];
        }
 
        m = InitInterestingMimes();
-
-       if (!parse_MimeHeaders(m, &content_start, content_end))
-       {
-
+       if (!parse_MimeHeaders(m, &content_start, content_end)) {
                recurseable_mime_parser(partnum,
                                        content_start, content_end,
                                        CallBack,
@@ -866,12 +820,11 @@ void the_mime_parser(char *partnum,
        free(m);
 }
 
-/*
- * Entry point for the MIME parser.
- * (This function expects to be fed HEADERS + CONTENT)
- * Note: NULL can be supplied as content_end; in this case, the message is
- * considered to have ended when the parser encounters a 0x00 byte.
- */
+
+// Entry point for the MIME parser.
+// (This function expects to be fed HEADERS + CONTENT)
+// Note: NULL can be supplied as content_end; in this case, the message is
+// considered to have ended when the parser encounters a 0x00 byte.
 void mime_parser(char *content_start,
                 char *content_end,
                 MimeParserCallBackType CallBack,
@@ -880,7 +833,6 @@ void mime_parser(char *content_start,
                 void *userdata,
                 int dont_decode)
 {
-
        the_mime_parser("", content_start, content_end,
                        CallBack,
                        PreMultiPartCallBack,
@@ -889,10 +841,6 @@ void mime_parser(char *content_start,
 }
 
 
-
-
-
-
 typedef struct _MimeGuess {
        const char *Pattern;
        size_t PatternLen;
@@ -928,12 +876,10 @@ MimeGuess MyMimes [] = {
 };
 
 
-const char *GuessMimeType(const char *data, size_t dlen)
-{
+const char *GuessMimeType(const char *data, size_t dlen) {
        int MimeIndex = 0;
 
-       while (MyMimes[MimeIndex].PatternLen != 0)
-       {
+       while (MyMimes[MimeIndex].PatternLen != 0) {
                if ((MyMimes[MimeIndex].PatternLen + 
                     MyMimes[MimeIndex].PatternOffset < dlen) &&
                    strncmp(MyMimes[MimeIndex].Pattern, 
@@ -944,17 +890,14 @@ const char *GuessMimeType(const char *data, size_t dlen)
                }
                MimeIndex ++;
        }
-       /* 
-        * ok, our simple minded algorythm didn't find anything, 
-        * let the big chegger try it, he wil default to application/octet-stream
-        */
+       // ok, our simple minded algorythm didn't find anything, 
+       // let the big chegger try it, he wil default to application/octet-stream
        return (xdg_mime_get_mime_type_for_data(data, dlen));
 }
 
 
-const char* GuessMimeByFilename(const char *what, size_t len)
-{
-       /* we know some hardcoded on our own, try them... */
+const char* GuessMimeByFilename(const char *what, size_t len) {
+       // we know some hardcoded on our own, try them...
        if ((len > 3) && !strncasecmp(&what[len - 4], ".gif", 4))
                return "image/gif";
        else if ((len > 2) && !strncasecmp(&what[len - 3], ".js", 3))
@@ -967,6 +910,8 @@ const char* GuessMimeByFilename(const char *what, size_t len)
                return "text/x-component";
        else if ((len > 3) && !strncasecmp(&what[len - 4], ".jpg", 4))
                return "image/jpeg";
+       else if ((len > 4) && !strncasecmp(&what[len - 5], ".jpeg", 5))
+               return "image/jpeg";
        else if ((len > 3) && !strncasecmp(&what[len - 4], ".png", 4))
                return "image/png";
        else if ((len > 3) && !strncasecmp(&what[len - 4], ".ico", 4))
@@ -988,7 +933,7 @@ const char* GuessMimeByFilename(const char *what, size_t len)
        else if ((len > 4) && !strncasecmp(&what[len - 5], ".wbmp", 5))
                return "image/vnd.wap.wbmp";
        else
-               /* and let xdgmime do the fallback. */
+               // and let xdgmime do the fallback.
                return xdg_mime_get_mime_type_from_file_name(what);
 }
 
@@ -1001,31 +946,18 @@ struct IconName {
        char *FileName;
 };
 
-static void DeleteIcon(void *IconNamePtr)
-{
+
+static void DeleteIcon(void *IconNamePtr) {
        IconName *Icon = (IconName*) IconNamePtr;
        free(Icon->FlatName);
        free(Icon->FileName);
        free(Icon);
 }
 
-/*
-static const char *PrintFlat(void *IconNamePtr)
-{
-       IconName *Icon = (IconName*) IconNamePtr;
-       return Icon->FlatName;
-}
-static const char *PrintFile(void *IconNamePtr)
-{
-       IconName *Icon = (IconName*) IconNamePtr;
-       return Icon->FileName;
-}
-*/
 
 #define GENSTR "x-generic"
 #define IGNORE_PREFIX_1 "gnome-mime"
-int LoadIconDir(const char *DirName)
-{
+int LoadIconDir(const char *DirName) {
        DIR *filedir = NULL;
        struct dirent *filedir_entry;
        int d_namelen;
@@ -1038,12 +970,11 @@ int LoadIconDir(const char *DirName)
                return 0;
        }
 
-       while ((filedir_entry = readdir(filedir)))
-       {
+       while ((filedir_entry = readdir(filedir))) {
                char *MinorPtr;
                char *PStart;
-#ifdef _DIRENT_HAVE_D_NAMELEN
-               d_namelen = filedir_entry->d_namelen;
+#ifdef _DIRENT_HAVE_D_NAMLEN
+               d_namelen = filedir_entry->d_namlen;
 #else
                d_namelen = strlen(filedir_entry->d_name);
 #endif
@@ -1071,41 +1002,39 @@ int LoadIconDir(const char *DirName)
                Icon->FlatName = malloc(d_without_ext + 1);
                memcpy(Icon->FlatName, PStart, d_without_ext);
                Icon->FlatName[d_without_ext] = '\0';
-               /* Try to find Minor type in image-jpeg */
+               // Try to find Minor type in image-jpeg
                MinorPtr = strchr(Icon->FlatName, '-');
                if (MinorPtr != NULL) {
                        size_t MinorLen;
                        MinorLen = 1 + d_without_ext - (MinorPtr - Icon->FlatName + 1);
                        if ((MinorLen == sizeof(GENSTR)) && 
                            (strncmp(MinorPtr + 1, GENSTR, sizeof(GENSTR)) == 0)) {
-                               /* ok, we found a generic filename. cut the generic. */
+                               // ok, we found a generic filename. cut the generic.
                                *MinorPtr = '\0';
                                d_without_ext = d_without_ext - (MinorPtr - Icon->FlatName);
                        }
-                       else { /* Map the major / minor separator to / */
+                       else { // Map the major / minor separator to /
                                *MinorPtr = '/';
                        }
                }
 
-//             PrintHash(IconHash, PrintFlat, PrintFile);
-//             printf("%s - %s\n", Icon->FlatName, Icon->FileName);
                Put(IconHash, Icon->FlatName, d_without_ext, Icon, DeleteIcon);
-//             PrintHash(IconHash, PrintFlat, PrintFile);
        }
        closedir(filedir);
        return 1;
 }
 
-const char *GetIconFilename(char *MimeType, size_t len)
-{
+
+const char *GetIconFilename(char *MimeType, size_t len) {
        void *vIcon;
        IconName *Icon;
        
-       if(IconHash == NULL)
+       if (IconHash == NULL) {
                return NULL;
+       }
 
        GetHash(IconHash, MimeType, len, &vIcon), Icon = (IconName*) vIcon;
-       /* didn't find the exact mimetype? try major only. */
+       // didn't find the exact mimetype? try major only.
        if (Icon == NULL) {
                char * pMinor;
                pMinor = strchr(MimeType, '/');
@@ -1119,11 +1048,10 @@ const char *GetIconFilename(char *MimeType, size_t len)
                return NULL;
        }
 
-       /*printf("Getting: [%s] == [%s] -> [%s]\n", MimeType, Icon->FlatName, Icon->FileName);*/
        return Icon->FileName;
 }
 
-void ShutDownLibCitadelMime(void)
-{
+
+void ShutDownLibCitadelMime(void) {
        DeleteHash(&IconHash);
 }