Removed traces after realizing that I was hitting config.c_maxmsglen and not an actua...
[citadel.git] / libcitadel / lib / stringbuf.c
index baa9c69a79ea8a5df0e58e8e2096a93a567f8f0f..8830ffc60c557308cf9f9fb42c3f3e90cb668bd1 100644 (file)
@@ -1,20 +1,18 @@
-/*
- * Copyright (c) 1987-2013 by the citadel.org team
- *
- * This program is open source software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- */
+// Copyright (c) 1987-2022 by the citadel.org team
+//
+// This program is open source software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 
 #define _GNU_SOURCE
 #include "sysdep.h"
@@ -256,7 +254,7 @@ void dbg_Init(StrBuf *Buf)
  * @param A First one
  * @param B second one
  */
-static inline void SwapBuffers(StrBuf *A, StrBuf *B)
+static inline void iSwapBuffers(StrBuf *A, StrBuf *B)
 {
        StrBuf C;
 
@@ -266,6 +264,12 @@ static inline void SwapBuffers(StrBuf *A, StrBuf *B)
 
 }
 
+void SwapBuffers(StrBuf *A, StrBuf *B)
+{
+       iSwapBuffers(A, B);
+}
+
+
 /** 
  * @ingroup StrBuf_Cast
  * @brief Cast operator to Plain String 
@@ -294,38 +298,37 @@ inline int StrLength(const StrBuf *Str)
        return (Str != NULL) ? Str->BufUsed : 0;
 }
 
-/**
- * @ingroup StrBuf_DeConstructors
- * @brief local utility function to resize the buffer
- * @param Buf the buffer whichs storage we should increase
- * @param KeepOriginal should we copy the original buffer or just start over with a new one
- * @param DestSize what should fit in after?
- */
-static int IncreaseBuf(StrBuf *Buf, int KeepOriginal, int DestSize)
-{
+// local utility function to resize the buffer
+// Buf         the buffer whichs storage we should increase
+// KeepOriginal        should we copy the original buffer or just start over with a new one
+// DestSize    what should fit in after?
+static int IncreaseBuf(StrBuf *Buf, int KeepOriginal, int DestSize) {
        char *NewBuf;
        size_t NewSize = Buf->BufSize * 2;
 
-       if (Buf->ConstBuf)
+       if (Buf->ConstBuf) {
                return -1;
+       }
                
-       if (DestSize > 0)
-               while ((NewSize <= DestSize) && (NewSize != 0))
+       if (DestSize > 0) {
+               while ((NewSize <= DestSize) && (NewSize != 0)) {
                        NewSize *= 2;
+               }
+       }
 
-       if (NewSize == 0)
+       if (NewSize == 0) {
                return -1;
+       }
 
-       NewBuf= (char*) malloc(NewSize);
-       if (NewBuf == NULL)
+       NewBuf = (char*) malloc(NewSize);
+       if (NewBuf == NULL) {
                return -1;
+       }
 
-       if (KeepOriginal && (Buf->BufUsed > 0))
-       {
+       if (KeepOriginal && (Buf->BufUsed > 0)) {
                memcpy(NewBuf, Buf->buf, Buf->BufUsed);
        }
-       else
-       {
+       else {
                NewBuf[0] = '\0';
                Buf->BufUsed = 0;
        }
@@ -338,18 +341,13 @@ static int IncreaseBuf(StrBuf *Buf, int KeepOriginal, int DestSize)
        return Buf->BufSize;
 }
 
-/**
- * @ingroup StrBuf_DeConstructors
- * @brief shrink / increase an _EMPTY_ buffer to NewSize. Buffercontent is thoroughly ignored and flushed.
- * @param Buf Buffer to shrink (has to be empty)
- * @param ThreshHold if the buffer is bigger then this, its readjusted
- * @param NewSize if we Shrink it, how big are we going to be afterwards?
- */
-void ReAdjustEmptyBuf(StrBuf *Buf, long ThreshHold, long NewSize)
-{
-       if ((Buf != NULL) && 
-           (Buf->BufUsed == 0) &&
-           (Buf->BufSize < ThreshHold)) {
+
+// shrink / increase an _EMPTY_ buffer to NewSize. Buffercontent is thoroughly ignored and flushed.
+// Buf         Buffer to shrink (has to be empty)
+// ThreshHold  if the buffer is bigger then this, its readjusted
+// NewSize     if we Shrink it, how big are we going to be afterwards?
+void ReAdjustEmptyBuf(StrBuf *Buf, long ThreshHold, long NewSize) {
+       if ((Buf != NULL) && (Buf->BufUsed == 0) && (Buf->BufSize < ThreshHold)) {
                free(Buf->buf);
                Buf->buf = (char*) malloc(NewSize);
                Buf->BufUsed = 0;
@@ -357,6 +355,7 @@ void ReAdjustEmptyBuf(StrBuf *Buf, long ThreshHold, long NewSize)
        }
 }
 
+
 /**
  * @ingroup StrBuf_DeConstructors
  * @brief shrink long term buffers to their real size so they don't waste memory
@@ -510,7 +509,7 @@ void NewStrBufDupAppendFlush(StrBuf **CreateRelpaceMe, StrBuf *CopyFlushMe, cons
                }
                else 
                        NewBuf = *CreateRelpaceMe;
-               SwapBuffers (NewBuf, CopyFlushMe);
+               iSwapBuffers (NewBuf, CopyFlushMe);
        }
        if (!KeepOriginal)
                FlushStrBuf(CopyFlushMe);
@@ -858,42 +857,37 @@ void StrBufAppendBuf(StrBuf *Buf, const StrBuf *AppendBuf, unsigned long Offset)
                return;
 
        if (Buf->BufSize - Offset < AppendBuf->BufUsed + Buf->BufUsed + 1)
-               IncreaseBuf(Buf, 
-                           (Buf->BufUsed > 0), 
-                           AppendBuf->BufUsed + Buf->BufUsed);
+               IncreaseBuf(Buf, (Buf->BufUsed > 0), AppendBuf->BufUsed + Buf->BufUsed);
 
-       memcpy(Buf->buf + Buf->BufUsed, 
-              AppendBuf->buf + Offset, 
-              AppendBuf->BufUsed - Offset);
+       memcpy(Buf->buf + Buf->BufUsed, AppendBuf->buf + Offset, AppendBuf->BufUsed - Offset);
        Buf->BufUsed += AppendBuf->BufUsed - Offset;
        Buf->buf[Buf->BufUsed] = '\0';
 }
 
 
-/**
- * @ingroup StrBuf_Filler
- * @brief Append a C-String to the buffer
- * @param Buf Buffer to modify
- * @param AppendBuf Buffer to copy at the end of our buffer
- * @param AppendSize number of bytes to copy; set to -1 if we should count it in advance
- * @param Offset Should we start copying from an offset?
- */
-void StrBufAppendBufPlain(StrBuf *Buf, const char *AppendBuf, long AppendSize, unsigned long Offset)
-{
+// Append a C-String to the buffer
+// Buf         Buffer to modify
+// AppendBuf   Buffer to copy at the end of our buffer
+// AppendSize  number of bytes to copy; set to -1 if we should count it in advance
+// Offset      Should we start copying from an offset?
+void StrBufAppendBufPlain(StrBuf *Buf, const char *AppendBuf, long AppendSize, unsigned long Offset) {
        long aps;
        long BufSizeRequired;
 
        if ((AppendBuf == NULL) || (Buf == NULL))
                return;
 
-       if (AppendSize < 0 )
+       if (AppendSize < 0) {
                aps = strlen(AppendBuf + Offset);
-       else
+       }
+       else {
                aps = AppendSize - Offset;
+       }
 
        BufSizeRequired = Buf->BufUsed + aps + 1;
-       if (Buf->BufSize <= BufSizeRequired)
+       if (Buf->BufSize <= BufSizeRequired) {
                IncreaseBuf(Buf, (Buf->BufUsed > 0), BufSizeRequired);
+       }
 
        memcpy(Buf->buf + Buf->BufUsed, 
               AppendBuf + Offset, 
@@ -902,7 +896,7 @@ void StrBufAppendBufPlain(StrBuf *Buf, const char *AppendBuf, long AppendSize, u
        Buf->buf[Buf->BufUsed] = '\0';
 }
 
-/**
+/*
  * @ingroup StrBuf_Filler
  * @brief sprintf like function appending the formated string to the buffer
  * vsnprintf version to wrap into own calls
@@ -2006,32 +2000,13 @@ void StrBufXMLEscAppend(StrBuf *OutBuf,
                        *pt = *pch;
                        pt++; pch++;
                }
-               else if (*pch < 0x20) {
-                       /* we probably shouldn't be doing this */
-                       if (OverrideLowChars)
-                       {
-                               *pt = '_';
-                               pt ++;
-                               pch ++;
-                       }
-                       else
-                       {
-                               *pt = '&';
-                               pt++;
-                               *pt = HexList[*(unsigned char*)pch][0];
-                               pt ++;
-                               *pt = HexList[*(unsigned char*)pch][1];
-                               pt ++; pch ++;
-                               *pt = '&';
-                               pt++;
-                               pch ++;
-                       }
-               }
                else {
                        IsUtf8Sequence =  Ctdl_GetUtf8SequenceLength(pch, pche);
                        if (IsUtf8Sequence)
                        {
-                               while (IsUtf8Sequence > 0){
+                               while ((IsUtf8Sequence > 0) && 
+                                      (pch < pche))
+                               {
                                        *pt = *pch;
                                        pt ++;
                                        pch ++;
@@ -2846,7 +2821,7 @@ int StrBufDecodeBase64To(const StrBuf *BufIn, StrBuf *BufOut)
                return -1;
 
        if (BufOut->BufSize < BufIn->BufUsed)
-               IncreaseBuf(BufOut, BufIn->BufUsed, 0);
+               IncreaseBuf(BufOut, 0, BufIn->BufUsed);
 
        BufOut->BufUsed = CtdlDecodeBase64(BufOut->buf,
                                           BufIn->buf,
@@ -3066,7 +3041,7 @@ int StrBufStreamTranscode(eStreamType type, IOBuffer *Target, IOBuffer *In, cons
                     (stream->OutBuf.BufUsed != org_outbuf_len)
                            ))
                {
-                       SwapBuffers(Target->Buf, &stream->OutBuf);
+                       iSwapBuffers(Target->Buf, &stream->OutBuf);
                }
 
                if (stream->zstream.avail_in == 0)
@@ -3137,7 +3112,7 @@ int StrBufStreamTranscode(eStreamType type, IOBuffer *Target, IOBuffer *In, cons
 
                stream->OutBuf.BufUsed += stream->zstream.total_out + org_outbuf_len;
 
-               if (Target) SwapBuffers(Target->Buf, &stream->OutBuf);
+               if (Target) iSwapBuffers(Target->Buf, &stream->OutBuf);
 
                if (stream->zstream.avail_in == 0)
                {
@@ -3786,7 +3761,7 @@ TRYAGAIN:
                TmpBuf->buf[TmpBuf->BufUsed] = '\0';
                
                /* little card game: wheres the red lady? */
-               SwapBuffers(ConvertBuf, TmpBuf);
+               iSwapBuffers(ConvertBuf, TmpBuf);
                FlushStrBuf(TmpBuf);
        }
 #endif
@@ -4155,11 +4130,11 @@ long StrBuf_Utf8StrCut(StrBuf *Buf, int maxlen)
                        n++;
                        aptr++;
                }
-               if (n > maxlen) {
+               if (n >= maxlen) {
                        *aptr = '\0';
                        Buf->BufUsed = aptr - Buf->buf;
                        return Buf->BufUsed;
-               }                       
+               }
        }
        return Buf->BufUsed;
 
@@ -4519,421 +4494,6 @@ long IOBufferStrLength(IOBuffer *FB)
        return StrLength(FB->Buf) - (FB->ReadWritePointer - FB->Buf->buf);
 }
 
-inline static void FDIOBufferFlush(FDIOBuffer *FDB)
-{
-       memset(FDB, 0, sizeof(FDIOBuffer));
-       FDB->OtherFD = -1;
-       FDB->SplicePipe[0] = -1;
-       FDB->SplicePipe[1] = -1;
-}
-
-void FDIOBufferInit(FDIOBuffer *FDB, IOBuffer *IO, int FD, long TotalSendSize)
-{
-       FDIOBufferFlush(FDB);
-
-       FDB->TotalSendSize = TotalSendSize;
-       if (TotalSendSize > 0)
-               FDB->ChunkSize = TotalSendSize;
-       else
-       {
-               TotalSendSize = SIZ * 10;
-               FDB->ChunkSize = TotalSendSize;
-       }
-       FDB->IOB = IO;
-
-#ifdef LINUX_SPLICE
-       if (EnableSplice)
-               pipe(FDB->SplicePipe);
-       else
-#endif
-               FDB->ChunkBuffer = NewStrBufPlain(NULL, TotalSendSize+ 1);
-
-       FDB->OtherFD = FD;
-}
-
-void FDIOBufferDelete(FDIOBuffer *FDB)
-{
-#ifdef LINUX_SPLICE
-       if (EnableSplice)
-       {
-               if (FDB->SplicePipe[0] > 0)
-                       close(FDB->SplicePipe[0]);
-               if (FDB->SplicePipe[1] > 0)
-                       close(FDB->SplicePipe[1]);
-       }
-       else
-#endif
-               FreeStrBuf(&FDB->ChunkBuffer);
-       
-       if (FDB->OtherFD > 0)
-               close(FDB->OtherFD);
-       FDIOBufferFlush(FDB);
-}
-
-int FileSendChunked(FDIOBuffer *FDB, const char **Err)
-{
-       ssize_t sent, pipesize;
-
-       if (FDB->TotalSendSize > 0)
-       {
-#ifdef LINUX_SPLICE
-               if (EnableSplice)
-               {
-                       if (FDB->PipeSize == 0)
-                       {
-                               pipesize = splice(FDB->OtherFD,
-                                                 &FDB->TotalSentAlready, 
-                                                 FDB->SplicePipe[1],
-                                                 NULL, 
-                                                 FDB->ChunkSendRemain, 
-                                                 SPLICE_F_MOVE);
-       
-                               if (pipesize == -1)
-                               {
-                                       *Err = strerror(errno);
-                                       return pipesize;
-                               }
-                               FDB->PipeSize = pipesize;
-                       }
-                       sent =  splice(FDB->SplicePipe[0],
-                                      NULL, 
-                                      FDB->IOB->fd,
-                                      NULL, 
-                                      FDB->PipeSize,
-                                      SPLICE_F_MORE | SPLICE_F_MOVE | SPLICE_F_NONBLOCK);
-                       if (sent == -1)
-                       {
-                               *Err = strerror(errno);
-                               return sent;
-                       }
-                       FDB->PipeSize -= sent;
-                       FDB->ChunkSendRemain -= sent;
-                       return sent;
-               }
-               else
-#endif
-               {
-                       char *pRead;
-                       long nRead = 0;
-
-                       pRead = FDB->ChunkBuffer->buf;
-                       while ((FDB->ChunkBuffer->BufUsed < FDB->TotalSendSize) && (nRead >= 0))
-                       {
-                               nRead = read(FDB->OtherFD, pRead, FDB->TotalSendSize - FDB->ChunkBuffer->BufUsed);
-                               if (nRead > 0) {
-                                       FDB->ChunkBuffer->BufUsed += nRead;
-                                       FDB->ChunkBuffer->buf[FDB->ChunkBuffer->BufUsed] = '\0';
-                               }
-                               else if (nRead == 0) {}
-                               else return nRead;
-                       }
-
-                       nRead = write(FDB->IOB->fd,
-                                     FDB->ChunkBuffer->buf     + FDB->TotalSentAlready,
-                                     FDB->ChunkBuffer->BufUsed - FDB->TotalSentAlready);
-
-                       if (nRead >= 0) {
-                               FDB->TotalSentAlready += nRead;
-                               FDB->ChunkSendRemain -= nRead;
-                               return FDB->ChunkSendRemain;
-                       }
-                       else {
-                               return nRead;
-                       }
-               }
-       }
-       else
-       {
-#ifdef LINUX_SPLICE
-               if (EnableSplice)
-               {
-                       if (FDB->PipeSize == 0)
-                       {
-                               pipesize = splice(FDB->OtherFD,
-                                                 &FDB->TotalSentAlready, 
-                                                 FDB->SplicePipe[1],
-                                                 NULL, 
-                                                 SIZ * 10, 
-                                                 SPLICE_F_MOVE);
-       
-                               if (pipesize == -1)
-                               {
-                                       *Err = strerror(errno);
-                                       return pipesize;
-                               }
-                               FDB->PipeSize = pipesize;
-                               if (pipesize == 0)
-                                       return -1;
-                       }
-                       sent =  splice(FDB->SplicePipe[0],
-                                      NULL, 
-                                      FDB->IOB->fd,
-                                      NULL, 
-                                      FDB->PipeSize,
-                                      SPLICE_F_MORE | SPLICE_F_MOVE | SPLICE_F_NONBLOCK);
-                       if (sent == -1)
-                       {
-                               *Err = strerror(errno);
-                               return sent;
-                       }
-                       FDB->PipeSize -= sent;
-                       FDB->ChunkSendRemain -= sent;
-                       return sent;
-               }
-               else
-#endif
-               {
-                       char *pRead;
-                       long nRead = 0;
-
-                       pRead = FDB->ChunkBuffer->buf;
-                       while ((FDB->ChunkSendRemain == 0) && 
-                              (FDB->ChunkBuffer->BufUsed < FDB->ChunkBuffer->BufSize) &&
-                              (nRead >= 0))
-                       {
-                               FDB->TotalSentAlready = 0;
-                               nRead = read(FDB->OtherFD, pRead, FDB->ChunkBuffer->BufSize - FDB->ChunkBuffer->BufUsed);
-                               if (nRead > 0) {
-                                       FDB->ChunkBuffer->BufUsed += nRead;
-                                       FDB->ChunkBuffer->buf[FDB->ChunkBuffer->BufUsed] = '\0';
-                                       FDB->ChunkSendRemain += nRead;
-                               }
-                               else if (nRead == 0)
-                               {
-                                       return -1;
-                               }
-                               else
-                               {
-                                       *Err = strerror(errno);
-                                       return nRead;
-                               }
-                       }
-
-                       nRead = write(FDB->IOB->fd,
-                                     FDB->ChunkBuffer->buf     + FDB->TotalSentAlready,
-                                     FDB->ChunkBuffer->BufUsed - FDB->TotalSentAlready);
-
-                       if (nRead >= 0) {
-                               FDB->TotalSentAlready += nRead;
-                               FDB->ChunkSendRemain -= nRead;
-                               if (FDB->ChunkSendRemain == 0)
-                               {
-                                       FDB->ChunkBuffer->BufUsed = 0;
-                                       FDB->TotalSentAlready = 0;
-                               }
-                               return FDB->ChunkSendRemain;
-                       }
-                       else {
-                               return nRead;
-                       }
-               }
-       }
-}
-
-int FileRecvChunked(FDIOBuffer *FDB, const char **Err)
-{
-       ssize_t sent, pipesize;
-
-#ifdef LINUX_SPLICE
-       if (EnableSplice)
-       {
-               if (FDB->PipeSize == 0)
-               {
-                       pipesize = splice(FDB->IOB->fd,
-                                         NULL, 
-                                         FDB->SplicePipe[1],
-                                         NULL, 
-                                         FDB->ChunkSendRemain, 
-                                         SPLICE_F_MORE | SPLICE_F_MOVE|SPLICE_F_NONBLOCK);
-
-                       if (pipesize == -1)
-                       {
-                               *Err = strerror(errno);
-                               return pipesize;
-                       }
-                       FDB->PipeSize = pipesize;
-               }
-       
-               sent = splice(FDB->SplicePipe[0],
-                             NULL, 
-                             FDB->OtherFD,
-                             &FDB->TotalSentAlready, 
-                             FDB->PipeSize,
-                             SPLICE_F_MORE | SPLICE_F_MOVE);
-
-               if (sent == -1)
-               {
-                       *Err = strerror(errno);
-                       return sent;
-               }
-               FDB->PipeSize -= sent;
-               FDB->ChunkSendRemain -= sent;
-               return sent;
-       }
-       else
-#endif
-       {
-               sent = read(FDB->IOB->fd, FDB->ChunkBuffer->buf, FDB->ChunkSendRemain);
-               if (sent > 0) {
-                       int nWritten = 0;
-                       int rc; 
-               
-                       FDB->ChunkBuffer->BufUsed = sent;
-
-                       while (nWritten < FDB->ChunkBuffer->BufUsed) {
-                               rc =  write(FDB->OtherFD, FDB->ChunkBuffer->buf + nWritten, FDB->ChunkBuffer->BufUsed - nWritten);
-                               if (rc < 0) {
-                                       *Err = strerror(errno);
-                                       return rc;
-                               }
-                               nWritten += rc;
-
-                       }
-                       FDB->ChunkBuffer->BufUsed = 0;
-                       FDB->TotalSentAlready += sent;
-                       FDB->ChunkSendRemain -= sent;
-                       return FDB->ChunkSendRemain;
-               }
-               else if (sent < 0) {
-                       *Err = strerror(errno);
-                       return sent;
-               }
-               return 0;
-       }
-}
-
-int FileMoveChunked(FDIOBuffer *FDB, const char **Err)
-{
-       ssize_t sent, pipesize;
-
-#ifdef LINUX_SPLICE
-       if (EnableSplice)
-       {
-               if (FDB->PipeSize == 0)
-               {
-                       pipesize = splice(FDB->IOB->fd,
-                                         &FDB->TotalReadAlready, 
-                                         FDB->SplicePipe[1],
-                                         NULL, 
-                                         FDB->ChunkSendRemain, 
-                                         SPLICE_F_MORE | SPLICE_F_MOVE|SPLICE_F_NONBLOCK);
-                       
-                       if (pipesize == -1)
-                       {
-                               *Err = strerror(errno);
-                               return pipesize;
-                       }
-                       FDB->PipeSize = pipesize;
-               }
-               
-               sent = splice(FDB->SplicePipe[0],
-                             NULL, 
-                             FDB->OtherFD,
-                             &FDB->TotalSentAlready, 
-                             FDB->PipeSize,
-                             SPLICE_F_MORE | SPLICE_F_MOVE);
-               
-               if (sent == -1)
-               {
-                       *Err = strerror(errno);
-                       return sent;
-               }
-               FDB->PipeSize -= sent;
-               FDB->ChunkSendRemain -= sent;
-               return sent;
-       }
-       else
-#endif 
-       {
-               sent = read(FDB->IOB->fd, FDB->ChunkBuffer->buf, FDB->ChunkSendRemain);
-               if (sent > 0) {
-                       int nWritten = 0;
-                       int rc; 
-               
-                       FDB->ChunkBuffer->BufUsed = sent;
-
-                       while (nWritten < FDB->ChunkBuffer->BufUsed) {
-                               rc =  write(FDB->OtherFD, FDB->ChunkBuffer->buf + nWritten, FDB->ChunkBuffer->BufUsed - nWritten);
-                               if (rc < 0) {
-                                       *Err = strerror(errno);
-                                       return rc;
-                               }
-                               nWritten += rc;
-
-                       }
-                       FDB->ChunkBuffer->BufUsed = 0;
-                       FDB->TotalSentAlready += sent;
-                       FDB->ChunkSendRemain -= sent;
-                       return FDB->ChunkSendRemain;
-               }
-               else if (sent < 0) {
-                       *Err = strerror(errno);
-                       return sent;
-               }
-               return 0;
-       }
-}
-
-eReadState WriteIOBAlreadyRead(FDIOBuffer *FDB, const char **Error)
-{
-       int IsNonBlock;
-       int fdflags;
-       long rlen;
-       long should_write;
-       int nSuccessLess = 0;
-       struct timeval tv;
-       fd_set rfds;
-
-       fdflags = fcntl(FDB->OtherFD, F_GETFL);
-       IsNonBlock = (fdflags & O_NONBLOCK) == O_NONBLOCK;
-
-       while ((FDB->IOB->ReadWritePointer - FDB->IOB->Buf->buf < FDB->IOB->Buf->BufUsed) &&
-              (FDB->ChunkSendRemain > 0))
-       {
-               if (IsNonBlock){
-                       tv.tv_sec = 1; /* selectresolution; */
-                       tv.tv_usec = 0;
-                       
-                       FD_ZERO(&rfds);
-                       FD_SET(FDB->OtherFD, &rfds);
-                       if (select(FDB->OtherFD + 1, NULL, &rfds, NULL, &tv) == -1) {
-                               *Error = strerror(errno);
-                               return eReadFail;
-                       }
-               }
-               if (IsNonBlock && !  FD_ISSET(FDB->OtherFD, &rfds)) {
-                       nSuccessLess ++;
-                       continue;
-               }
-
-               should_write = FDB->IOB->Buf->BufUsed - 
-                       (FDB->IOB->ReadWritePointer - FDB->IOB->Buf->buf);
-               if (should_write > FDB->ChunkSendRemain)
-                       should_write = FDB->ChunkSendRemain;
-
-               rlen = write(FDB->OtherFD, 
-                            FDB->IOB->ReadWritePointer, 
-                            should_write);
-               if (rlen < 1) {
-                       *Error = strerror(errno);
-                                               
-                       return eReadFail;
-               }
-               FDB->TotalSentAlready += rlen;
-               FDB->IOB->ReadWritePointer += rlen;
-               FDB->ChunkSendRemain -= rlen;
-       }
-       if (FDB->IOB->ReadWritePointer >= FDB->IOB->Buf->buf + FDB->IOB->Buf->BufUsed)
-       {
-               FlushStrBuf(FDB->IOB->Buf);
-               FDB->IOB->ReadWritePointer = NULL;
-       }
-
-       if (FDB->ChunkSendRemain == 0)
-               return eReadSuccess;
-       else 
-               return eMustReadMore;
-}
 
 /*******************************************************************************
  *           File I/O; Prefer buffered read since its faster!                  *
@@ -4987,6 +4547,7 @@ int StrBufTCP_read_line(StrBuf *buf, int *fd, int append, const char **Error)
        return len - slen;
 }
 
+
 /**
  * @ingroup StrBuf_BufferedIO
  * @brief Read a line from socket
@@ -5416,14 +4977,13 @@ int StrBufReadBLOBBuffered(StrBuf *Blob,
        
        pos = *Pos;
 
-       if (pos != NULL)
+       if (pos != NULL) {
                rlen = pos - IOBuf->buf;
+       }
        rlen = IOBuf->BufUsed - rlen;
 
 
-       if ((IOBuf->BufUsed > 0) && 
-           (pos != NULL) && 
-           (pos < IOBuf->buf + IOBuf->BufUsed)) 
+       if ((IOBuf->BufUsed > 0) && (pos != NULL) && (pos < IOBuf->buf + IOBuf->BufUsed)) 
        {
                if (rlen < nBytes) {
                        memcpy(Blob->buf + Blob->BufUsed, pos, rlen);
@@ -5448,8 +5008,9 @@ int StrBufReadBLOBBuffered(StrBuf *Blob,
 
        FlushStrBuf(IOBuf);
        *Pos = NULL;
-       if (IOBuf->BufSize < nBytes - nRead)
+       if (IOBuf->BufSize < nBytes - nRead) {
                IncreaseBuf(IOBuf, 0, nBytes - nRead);
+       }
        ptr = IOBuf->buf;
 
        fdflags = fcntl(*fd, F_GETFL);
@@ -5461,11 +5022,8 @@ int StrBufReadBLOBBuffered(StrBuf *Blob,
 
        nBytes -= nRead;
        nRead = 0;
-       while ((nSuccessLess < MaxTries) && 
-              (nRead < nBytes) &&
-              (*fd != -1)) {
-               if (IsNonBlock)
-               {
+       while ((nSuccessLess < MaxTries) && (nRead < nBytes) && (*fd != -1)) {
+               if (IsNonBlock) {
                        tv.tv_sec = 1;
                        tv.tv_usec = 0;
                
@@ -5475,8 +5033,9 @@ int StrBufReadBLOBBuffered(StrBuf *Blob,
                                *Error = strerror(errno);
                                close (*fd);
                                *fd = -1;
-                               if (*Error == NULL)
+                               if (*Error == NULL) {
                                        *Error = ErrRBLF_SelectFailed;
+                               }
                                return -1;
                        }
                        if (! FD_ISSET(*fd, &rfds) != 0) {
@@ -5484,20 +5043,16 @@ int StrBufReadBLOBBuffered(StrBuf *Blob,
                                continue;
                        }
                }
-               rlen = read(*fd, 
-                           ptr,
-                           IOBuf->BufSize - (ptr - IOBuf->buf));
-               if (rlen == -1) {
+               rlen = read(*fd, ptr, IOBuf->BufSize - (ptr - IOBuf->buf));
+               // if (rlen == -1) {            2021feb27 ajc changed this, apparently we will always get at least 1 byte unless the connection is broken
+               if (rlen < 1) {
                        close(*fd);
                        *fd = -1;
                        *Error = strerror(errno);
                        return rlen;
                }
                else if (rlen == 0){
-                       if ((check == NNN_TERM) && 
-                           (nRead > 5) &&
-                           (strncmp(IOBuf->buf + IOBuf->BufUsed - 5, "\n000\n", 5) == 0)) 
-                       {
+                       if ((check == NNN_TERM) && (nRead > 5) && (strncmp(IOBuf->buf + IOBuf->BufUsed - 5, "\n000\n", 5) == 0)) {
                                StrBufPlain(Blob, HKEY("\n000\n"));
                                StrBufCutRight(Blob, 5);
                                return Blob->BufUsed;
@@ -5635,3 +5190,44 @@ void StrBufStripSlashes(StrBuf *Dir, int RemoveTrailingSlash)
 }
 
 
+/*
+ * Decode a quoted-printable encoded StrBuf buffer "in place"
+ * This is possible because the decoded will always be shorter than the encoded
+ * so we don't have to worry about the buffer being to small.
+ */
+void StrBufDecodeQP(StrBuf *Buf)
+{
+       if (!Buf) {                             // sanity check #1
+               return;
+       }
+
+       int source_len = StrLength(Buf);
+       if (source_len < 1) {                   // sanity check #2
+               return;
+       }
+
+       int spos = 0;                           // source position
+       int tpos = 0;                           // target position
+
+       while (spos < source_len) {
+               if (!strncmp(&Buf->buf[spos], "=\r\n", 3)) {
+                       spos += 3;
+               }
+               else if (!strncmp(&Buf->buf[spos], "=\n", 2)) {
+                       spos += 2;
+               }
+               else if (Buf->buf[spos] == '=') {
+                       ++spos;
+                       int ch;
+                       sscanf(&Buf->buf[spos], "%02x", &ch);
+                       Buf->buf[tpos++] = ch;
+                       spos +=2;
+               }
+               else {
+                       Buf->buf[tpos++] = Buf->buf[spos++];
+               }
+       }
+
+       Buf->buf[tpos] = 0;
+       Buf->BufUsed = tpos;
+}